[05:27:21] (previously this gave the edit conflict page!!) [05:27:49] And in the API I get either "Unknown error `mymessage'" , or if I add something for ApiBase::$messageMap['mymessage'] I'll get that [05:28:02] (previously this just gave "Unknown error 231" or something) [05:28:06] hmm not very flexible but better than nothing [05:28:21] Well, you can pass params [05:28:45] in very hacky way... does it even support raw params? [05:28:45] And EditFilter runs before ArticleSave in case you want to do additional UI stuff [05:28:50] I don't know [05:28:59] It supports whatever the Status class supports [05:29:05] Which... well [05:29:11] It renders to wikitext, so probably not I guess [05:30:18] it was made before Message class [05:30:36] Yeah [05:30:38] Well, also [05:30:41] It renders to /wikitext/ [05:30:53] So you're kind of screwed unless you make it also render to HTML, right? [05:32:27] yup [05:32:53] why doesn't API automatically pull the message text? [05:35:05] I guess it could pull the English message text by default [05:35:26] That would allow us to clean up the message map a bit [09:54:40] -*MemoServ*- You are not logged in. [12:54:41] [[User:Tim StarIing bót]] :D [14:15:44] sumanah: could you please tell me when Hackathon venue will be announced? [14:15:49] hi vvv! [14:15:54] vvv: we're hoping today, officially [14:16:06] Hello [14:16:08] vvv: the papers have been signed [14:16:13] Today in east-costish time? [14:16:20] *coastish [14:16:23] vvv: (I believe that by today the papers are all signed!) [14:16:47] vvv: today in West Coast-ish, unfortunately. I presume that the announcement is a bottleneck or blocker that is stopping you from doing something? [14:20:24] vvv: maybe booking something? [14:20:26] * sumanah wonders [14:20:31] Exactly [14:20:35] ok. [14:52:35] hi Daniel_WMDE_! [14:58:25] hi sumanah [16:31:43] Hey AaronShulz-- when a picture is displayed, are their generic hooks to transform the image before it's returned by the server? Including the "Full resolution" version? [16:32:20] s/their/there... because en is my first langauge. [16:33:47] maybe the FileTransformed hook? Are you trying to change language tags in svgs or something? [16:38:01] No... Thinking if that would be a good place to transform some css inside the svg. [16:43:16] yeah I don't see any efficient hooks for that [16:46:52] bummer. But there is an entry point in the code for displaying pictures? [16:49:07] not normally, no, it's just apache [17:28:02] So AaronShulz-- Tim was thinking it would be best to make some of the svg rewriting part of core. Do you have any recommendation on where in the upload process I should do that? I think I can do the rewrite at any time before the temp time has been moved to its final location, but I'm not sure how the new/swift stuff might change that. [17:30:30] csteipp: it's almost something like you want to keep it in the upload stash, process it with the job queue, and then finish uploading it after [17:31:06] I was afraid that would be the best way to do it.... [17:34:40] Hello yoni_omniti, rsterbin, mlitn and RoanKattouw ! How's everybody today? Are we ready for another awesome AFT deployment? [17:34:55] im here [17:35:17] Hi [17:36:06] hi [17:36:49] Good morning everyone [17:36:50] hi [17:36:53] I apologize for being late (again) [17:36:54] morning [17:37:19] I noticed some change related to jQuery, that I can't trace back the source of [17:37:27] for example, if I do $('#content').css('margin-left', 0); , it is animated, whereas it wasn't animated before [17:37:32] and it is not supposed to be animated [17:38:13] TrevorParscal: [17:38:14] Od1n I noticed some change related to jQuery, that I can't trace back the source of [17:38:16] Od1n for example, if I do $('#content').css('margin-left', 0); , it is animated, whereas it wasn't animated before [17:38:17] Od1n and it is not supposed to be animatedv [17:38:26] rsterbin: Are there any changes pending in Gerrit that need to be merged for today's deployment? [17:38:56] thanks RoanKattouw for forwarding [17:39:04] TrevorParscal, did you catch it? [17:39:20] Od1n: I know what's going on [17:39:47] RoanKattouw, fabriceflorin: the central feedback log and the redesign are NOT reviewed. would you like me to switch prototype to the master branch so we can see what is ready to go to production? [17:39:48] basically we use a media selector to switch between two levels of margins [17:40:06] we also have CSS transitions set on those properties [17:40:13] so, if you change them, they will animate [17:40:20] you have 2 options [17:40:42] 1, adjust a different property to get a comparable result (this sometimes works, but not always) [17:41:18] how and where are these CSS transitions set? [17:41:18] 2, we could add a animated class to the body which the selectors that set the animation properties depend on [17:41:30] then you can remove that class, make you change, and then set that class again [17:41:39] they are in the bottom of vector's screen.css [17:42:07] i think option 2 is best, because it gives people a general purpose way to solve this problem in the future [17:42:26] rsterbin, RoanKattouw: Yes, please switch prototype to reflect what we are planning to deploy today, i.e: the latest gerrit revisions. [17:42:28] if you want to write a patch for that I can review it [17:42:47] rsterbin: Were you able to make my proposed tweak to widen the drop down menu, which is too narrow on Firefox? https://bugzilla.wikimedia.org/show_bug.cgi?id=36688 [17:43:14] at the bottom of screen.css? I don't get it: it must be related to some JS, doesn't it? [17:43:20] no [17:43:25] fabriceflorin: that's not part of today's deployment [17:44:01] Od1n: look at skins/vector/main.css @ line 848 and below [17:44:07] Od1n: It's animated using a CSS3 transition [17:44:12] indeed, jQuery's css() isn't animated, so it shouldn't be overriden [17:44:23] those are CSS3 rules that cause certain CSS properties to be animated any time they are changed, it's called a transition [17:44:33] fabriceflorin: prototype is now showing the master branch [17:44:56] rsterbin: Oh, I thought the central feedback page and new design were going to be included in today's deployment. So can you summarize what we are now planning to deploy, so I understand this better? Also, what's the difference between the master branch and the 'other' branch? [17:45:03] spotted, didn't know this css property [17:45:11] Od1n: jQuery's css method simply sets a property, a transition will still be used, this has nothing to do with jQuery.animate [17:45:24] yep, understood ;) [17:45:37] jQuery.animate changes a property multiple times over a period of time to simulate a transition [17:45:42] so [17:45:51] fabriceflorin: the central feedback page and the new design have been submitted to gerrit, but they have not been reviewed [17:46:18] if we add 'body.transitionLayout' (or something similar) to the beginning of all of these selectors [17:46:38] and then add the 'transitionLayout' class to the body when in vector [17:46:58] so for my gadget, I could just set temporarly the transition to 0ms, but a better solution would be to hack mediawiki so the transition css is isolated into a class [17:46:59] fabriceflorin: it's up to RoanKattouw to tell you when he and the dba team will be able to review them [17:47:03] you could just toggle this class off, set your css property, then toggle this class back on [17:47:13] rsterbin: thanks for the clarification. How much code is involved in the central page and new design? Is this something RoanKattouw could review now? Or would this take too long for today's limited deployment window? [17:47:27] Od1n: do you feel up to this task with Vector? [17:47:32] I could probably hack it in [17:47:34] fabriceflorin: That's a lot of code and I'm not reviewing this morning [17:47:46] fabriceflorin: what's in the queue for this week's deployment is what was in the queue for last week's, which we didn't have [17:48:02] rsterbin: No, I approved some more stuff [17:48:03] fabriceflorin: those are two very large features with a lot of code to review [17:48:11] ow, I don't have enough knowledge for it, I think [17:48:13] * RoanKattouw looks at git log wmf/1.20wmf2..master [17:48:14] RoanKattouw, rsterbin: OK, I understand. Let's just deploy last week's code, then. [17:48:21] ah, yes, there are some bug fixes [17:48:42] and the refactoring, which doesn't have any affect on users [17:49:06] RoanKattouw: can you also review merge in the three small revisions currently in the queue? [17:49:18] RoanKattouw: Did you resolve the small DB issue with Werdna for his Abuse filter code change? If so, what are the chances we could deploy this today as well? [17:49:22] they don't rely on the two big features; might as well get them in [17:49:39] New commits in master: http://pastebin.com/uuCCWYSXhttp://pastebin.com/uuCCWYSX [17:49:41] Oops [17:49:42] http://pastebin.com/uuCCWYSX [17:50:03] rsterbin: You mean the ones authored by you ending in (bug NNNNN) ? [17:50:12] er, two of them, that is [17:50:13] yes [17:50:22] I see three of those [17:50:27] not the redesign! [17:50:35] that is giant and will have to wait ;) [17:50:43] Woha [17:50:50] 7151 ain't small [17:51:08] That commit summary is 2.5x my screen height [17:51:11] indeed [17:51:23] And that's just the summary, we're not even talking code yet :D [17:51:27] well, i like to be complete in my commit summaries. [17:51:58] It's appreciated :) [17:52:32] OK merged those two [17:52:36] thanks [17:53:08] * RoanKattouw glances over Matthias's changes [17:54:24] Thanks, RoanKattouw. That commit list was very helpful. [17:54:26] RoanKattouw: i just noticed a bug that i think got fixed in the central feedback commit [17:54:41] let me send it to gerrit real quick... [17:54:44] Hmm two of Matthias's changes are things I don't wanna review right now, and the third has issues [17:55:55] but where/when will these css transitions be in effect, since screen-hd.css is applied from the beginning? [17:56:38] RoanKattouw: igJ5tutDVO [17:56:40] lol [17:56:44] just for the time between loadings of screen.css and screen-hd.css? [17:56:52] https://gerrit.wikimedia.org/r/7189 [17:57:07] From a product standpoint, it's not the end of the world if we don't deploy all of the changes today. The one I was hoping for, though, is the permalink change that allows us to see the relevance score, so we can test and debug as needed. [17:58:00] fabriceflorin: that's been merged already — http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/540 [17:58:03] rsterbin: Merged [17:58:10] thank you! [17:58:23] rsterbin: Cool, thanks. [18:01:56] np [18:02:42] OK so [18:02:47] Want me to take the current master to testwiki? [18:07:07] fabriceflorin, rsterbin: ---^ ? [18:07:22] anyone about my css transition topic? [18:07:34] sounds good to me. fabriceflorin, are you ready? [18:08:10] Yes, I am ready for test.wiki. [18:10:02] Od1n: i have a patch I'm about to submit [18:10:24] OK, starting deployment prep now [18:10:38] fine, so I could easily adjust my gadget [18:11:23] Od1n: did you open a bug for this issue? [18:11:33] what I'd like to know, is when are these transitions in effect? see my prev messages about loading of screen-hd.css [18:12:35] Od1n: did you open a bug for this issue? no, since it's brand new and it's just that it changed the rendering of one of my gadgets [18:22:08] Od1n: patch for CSS transition thing: https://gerrit.wikimedia.org/r/#/c/7198/ [18:22:52] thanks :) [18:25:41] did you write the patch only because of my questions, or did other people ask for it? [18:31:20] RoanKattouw, rsterbin, yoni_omniti: How goes the deployment to testing? Still under way? I just checked this permalink page on testing, and it seems almost there, though some strange strings are showing up at the bottom of the page: http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/75 [18:32:01] Sorry I'm still working on it [18:32:10] I managed to mess up our bastion host a little bit [18:32:36] RoanKattouw: No worries, just wanted to make sure I was not holding you guys up ;o) [18:37:07] AaronSchulz: Aha so your changes to SiteStats.php were in 1.20wmf2, but they were deployed as a local change, not from git [18:37:18] So now when I try updating it, it goes 'conflict!' :D [18:37:21] * RoanKattouw is fixing it [18:37:54] so many I cherry-picked from the wrong window? [18:37:59] Possible [18:38:05] * AaronSchulz tries to have local the the left, remote to the right [18:39:27] Are you stuck in the middle? [18:39:34] rsterbin, fabriceflorin: OK that was a yak shave, I have the new AFTv5 code up on test now [18:39:57] Sorry for the delay, our bastion host was a bit messed up and I made it worse before I made it better [18:40:09] ok, no worries, testing now... [18:40:11] RoanKattouw, rsterbin, yoni_omniti : Sounds good. We'll start testing now. [18:41:51] i18n is still broken for me [18:41:55] RoanKattouw: we seem to have some missing messages — http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/73 [18:42:05] needs scapping [18:42:17] rsterbin: Sorry abuot that [18:42:20] Reedy: NO! Don't scap [18:42:24] I'll rebuild the l10n cache [18:42:27] I wasn't going to [18:42:32] thx [18:43:17] I am still getting a strange behavior on this permalink page: http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/75 On Safari, it's showing some strange tags from the new fields we just added () -- on Firefox, it shows none of them. [18:44:36] OK try now? [18:44:38] en is rebuilt [18:45:01] You might see some of the due to caching still but that should go away with a hard refresh [18:45:06] (sorry about that) [18:48:07] RoanKattouw: No worries, that did the trick for me on Safari and Firefox. (The reason I wasn't seeing the permalink info on Firefox is because I was not logged in, which matches our requirements). [18:49:29] rsterbin: Can you please remind me what we should be testing specifically, besides the permalink page? I lost track of what's included in this deployment and what's not. Is there anything else that's tricky and should be tested before we go to production? [18:50:57] let's see... [18:51:15] 1) unoversight should have an icon now [18:51:49] 2) you should get a different default filter depending on what privileges you have [18:52:22] 3) horizontal dividers in the toolbox [18:53:24] 4) 50 posts per page instead of 25 [18:53:38] 5) View activity link gets grayed out when there's no activity [18:54:45] rsterbin, yoni_omniti, RoanKattouw: Cool. I can confirm that all 5 items listed above generally work as intended on Firefox. Do they work for you too? [18:54:52] 6) comments should no longer be partially hidden by the toolbox [18:55:32] fabriceflorin: they work for me, too [18:56:55] rsterbin, yoni_omniti, RoanKattouw: OK, then. So do we feel good about pushing to production? Any other issues we should check? [18:57:37] good on my end [18:59:09] yoni_omniti: Are we good to go to production on your end as well? [18:59:53] I'm good [19:00:58] RoanKattouw: OK, let's do it, since it works for both rsterbin and myself. I hope you're OK with pushing the deployment window back a bit, since we started 30 mins. late ;o) [19:01:18] Yeah sure [19:01:23] OK lemme push to prod now then [19:01:45] RoanKattouw: Cool. [19:16:43] AaronSchulz: OK go :) [19:16:50] * RoanKattouw is still waiting for scap [19:19:01] RoanKattouw: Thanks. Ready when you are ;o) [19:20:36] RoanKattouw: re https://gerrit.wikimedia.org/r/#/c/7205/ - is this against current HEAD? [19:20:54] echo 'Hello world' | node parse.js works for me [19:25:40] gwicke: It fails for me on master [19:25:56] You're indirectly doing somefunction.apply( this, {} ) [19:26:27] works for some reason on my master checkout, but your fix is correct anyway [19:26:39] merged it already [19:26:51] thanks! [19:29:12] Yay [19:29:56] fabriceflorin: OK should be done now [19:29:59] That was hella slow [19:30:29] rsterbin: can you please switch prototype back to the master, now that we have a version on testing? I would like to show some of the new work in progress to the team later today. Thanks. [19:31:08] sure thing, if you mean what i think you mean [19:31:19] RoanKattouw, rsterbin, yoni_omniti: Thanks! I will start testing now at this URL: http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow [19:31:19] master = the main branch, for deploy [19:31:24] omniti = the dev branch [19:32:16] rsterbin: sorry if I wasn't clear. What I would like to show is the central feedback page and the new design, when you get a minute to revert to that view. This can wait until we're done testing on production. [19:32:44] just switched it [19:33:05] rsterbin: Thanks! [19:33:30] np [19:36:35] OK, going upstairs to the Wikia lunch now [19:37:16] RoanKattouw: Sounds good. See you there! (I'm in the back, testing and listening with one ear ;o) [19:54:46] rsterbin, yoni_omniti: From my standpoint, we are good to go with this deployment. I only found minor issues, which I will report separately on Bugzilla. Are you guys comfortable with this deployment as well, or are there any showstoppers on your end? [19:55:31] looks good to me. i'll keep an eye on bugzilla [19:59:30] rsterbin: OK, sounds good. Many thanks for all your good work this week! Look forward to deploying the rest of the code next week. I'll send an email now to the team to let them know this deployment went well. BTW, it was really helpful to get a short list from you of what was being deployed, and I am including this in the email as well. Speak with you tomorrow! [20:01:14] :) [20:58:21] TrevorParscal: Hi [20:58:25] hi [20:58:27] what's crackin? [20:58:34] regarding vector-animateLayout, is that also related to the bugs I heard in Vector extension? [20:58:47] which cause a jump animation when the page is loaded sometimes [20:58:57] maybe set the animation after document ready from core instead of from php right away [20:59:03] animation class* [20:59:11] Krinkle, no that was a different issue [20:59:29] i mean, it's possible that those kinds of issues could continue [20:59:52] so, yeah, you could use js to add that class like 500ms after load or something [20:59:52] k [21:00:44] I resolved the issue with the vector extension's changes to the margins of the sidebar portals by changing the way the hd layout was changing things [21:01:08] https://gerrit.wikimedia.org/r/#/c/6316/ [21:01:15] ah, I remember [21:01:46] btw, do you use git from cli, and if so, some kind of colored diff ? [21:02:11] ask hashar [21:02:14] probably [21:02:26] I don't have a problem, I'm asking in general. [21:02:30] to TrevorParscal :P [21:03:04] Krinkle: in your ~/.gitconfig put something like http://dpaste.org/obytR/ [21:03:09] will give you colors :-] [21:03:10] I know [21:03:42] I use [color] diff=auto [21:05:10] hashar: btw, http://dpaste.org/ will be my new favorite paste bin. It has highlighting, simple interface, expiration date, and for the creator: a delete button. Those are my requirements and this is the first non-flash-ads paste bin that meets that :) [21:05:12] thx [21:05:37] http://pastie.org/ is also nice [21:05:55] also allows editing, oh, they no longer have ads [21:06:42] :-] [21:06:49] or gist ? [21:06:59] yeah... true [21:06:59] https://gist.github.com/ [21:07:09] not sure why I didn't mentally link that with a paste bin [21:07:19] it is better than both, it also has forking, comments, history, ... [21:08:28] http://dpaste.org/LzZ1q/ http://pastie.org/3891629 https://gist.github.com/2655914 [21:08:31] choose your poison [21:08:59] ah dpaste also has comparison history [21:09:22] gist does too, but it doesn't had a diff button by default, there is a chrome extension out there that adds it though, for some reason it is not shown by default [21:10:47] https://github.com/blog/595-diff-your-gist [21:11:30] TrevorParscal: so anyway, I was going to saw.. git diffs with color on (the default 'auto' color scheme at least) also highlights pending whitespace, which is nice. when checking the diff before commit, easy to spot. [21:11:35] say* [21:11:48] just noticed it when doing something on labs, pretty nice [21:13:47] ___-------___ [21:13:49] _-~~ ~~-_ [21:13:52] _-~ /~-_ [21:13:54] /^\__/^\ /~ \ / \ [21:13:57] /| O|| O| / \_______________/ \ [21:13:59] Reedy: ^ blackman again [21:13:59] | |___||__| / / \ \ [21:14:02] | \ / / \ \ [21:14:04] | (_______) /______/ \_________ \ [21:14:07] | / / \ / \ [21:14:09] \ \^\\ \ / \ / [21:14:12] \ || \______________/ _-_ //\__// [21:14:14] \ ||------_-~~-_ ------------- \ --/~ ~\ || __/ [21:14:16] I don't have rights in here [21:14:17] ~-----||====/~ |==================| |/~~~~~ [21:14:19] (_(__/ ./ / \_\ \. [21:14:22] (_(___/ \_____)_) [21:14:30] magic! [21:14:35] apparently I do [21:14:48] Expect similar stuff in other wmf channels [21:15:04] he also got to wikimedia -stewards, -commons, -nl and more yesterday [21:16:00] he's been getting a few channels all week [21:27:43] I enjoy his ASCII art [21:27:57] it's particularly useful in the middle of boring office hours [21:28:22] I thought it was an ingenious idea by the organizers :) [21:30:39] ...and the kickbanning is part of the performance art :) [21:33:20] Krinkle broke the combo [21:35:27] Nemo_bis: Oh, it is a turtle... When viewed in normal sans-serif fonts, it doesn't look like a turtle, more like a man standing up with a beer [21:35:53] i like turtles. [21:36:22] Krinkle, what client are you using? :) [21:36:23] `http://cl.ly/21180H3X1U2P0q00011y [21:36:33] Colloquy [21:36:40] and yes, I know one can set a monospace font, and no I wont [21:36:45] too many clients nowadays spoil ascii, including webmails [21:37:22] Yesterday he was spreading messages related to anus tickling, today it is turtle ANCI art.. [21:37:40] hm, I saw only one of those [21:37:47] mainly ASCII art [21:38:25] why doesn't ChanServ provide an ASCII-art-on-demand service? [21:38:39] ChanServ, where is your artistic heart? [21:38:49] Cowsay! [21:39:50] sudo apt-get install cowsay [21:40:28] irssi makes cowsay to irc very easy [22:29:21] OK I think I found out what happened to our fenari clones [22:29:35] Antoine cherry-picked a change from master onto wmf/1.20wmf2 on fenari, and deployed it [22:30:00] Then later, he cherry-picked /the same change/ onto wmf/1.20wmf2 and submitted the cherry-pick for review, approved it and merged it [22:30:17] A similar thing probably happened to wmf1 [22:32:22] haha [22:32:39] A similar thing *did* happen to wmf1, but it was caused by Reedy 2 days earlier [22:32:52] Computer ssuck [22:33:01] At least he reverted himself [23:52:28] could someone please take a look at my questions in http://lists.wikimedia.org/pipermail/wikitech-l/2012-May/060529.html?