[00:01:03] I thought it must have come from the existing ExtensionMessages-1.20wmf1.php, but I replaced the body of that file with a throw statement and it doesn't hit the exception [00:01:25] it is producing a different error instead, which wasn't there before [00:02:16] ^demon: still around? [00:02:24] <^demon> Yeah, what's up? [00:02:52] if I type "git branch" in a 1.20 extension on fenari it says it's on "no branch" [00:02:54] is that meant to happen? [00:04:02] <^demon> No, that sounds odd, let me login [00:04:19] Sounds like normal submodule behavior? [00:04:30] Also, who's been messing with ExtensionMessages-1.20 ? [00:04:34] me [00:04:37] see above [00:04:52] * RoanKattouw grabs logs from the web [00:05:16] <^demon> RoanKattouw: Where on fenari? /h/w/c/php-1.20wmf1 says I'm on wmf/1.20wmf1 [00:05:19] <^demon> TimStarling: ^ [00:05:33] if it's a submodule then that probably explains it [00:05:58] anyway ExtensionMessages-1.20wmf1.php was completely screwed up and now it is empty while I try to regenerate it [00:06:18] the same thing happened in the 1.19 deployment [00:06:23] <^demon> TimStarling: Submodules will give you that, they're detached until you start working with them and explicitly checkout a branch. [00:06:36] you can't just copy the file from an old version and expect it to work, you have to regenerate it [00:06:52] * RoanKattouw is also looking at mergeMessageFileList.php [00:06:54] and that means fixing all the bugs that inevitably come up with each new version [00:06:59] I have a live hack in it now, no one run it [00:07:21] you were hacking it without being on IRC at the same time as I was hacking it? [00:07:24] <^demon> TimStarling: Do we still need the PrefStats extension to be added? [00:07:51] I don't know how that extension came to be in there, it's not the error that it hits now [00:08:03] RoanKattouw: what problem are you trying to solve exactly? [00:08:20] I know that it doesn't work, it fails when it gets to MoodBar [00:08:41] for obvious reasons, and I will commit a fix when I work out how [00:09:09] I was trying replacing include_once() with require_once() [00:09:13] But that doesn't work either [00:09:27] I had hoped that that would make the file run in the global scope, not the foreach loop's scope [00:09:30] it sounds like it would screw it up even more [00:09:44] I said half an hour ago "please nobody run scap, I am fixing ExtensionMessages" [00:09:53] after preilly complained about it [00:10:39] so it sounds like shortly after that, you ran scap and started playing with ExtensionMessages [00:10:53] <^demon> Something is totally messed up with the AbuseFilter submodule. Even on a fresh clone I end up in a weird place. [00:10:56] * ^demon is working on that [00:11:07] apparently everything I work on is breaking [00:12:25] I didn't run scap [00:12:38] I just tried running mergeMessageFilelist.php with a different outfile [00:12:45] why? [00:13:21] To test include_once vs require_once [00:13:28] But I've found the guilty change [00:13:30] 5586e73fac6f70d7b16bc5a4d185d35f80ff53b5 [00:13:36] commit 5586e73fac6f70d7b16bc5a4d185d35f80ff53b5 [00:13:38] Author: Sam Reed [00:13:39] Date: Tue Oct 11 21:34:53 2011 +0000 [00:13:41] Bit more refactoring [00:13:44] was there some bug that you were trying to fix? [00:13:47] OF COURSE it has a commit summary like that [00:13:54] Ah, the fact that it throws lots of notices? [00:14:05] it's done that since 1.19 [00:14:07] Yes [00:14:13] And it's irked me ever since [00:14:26] Roll back that change and you won't have to worry about the MoodBar thing either [00:14:36] right, so you just happened to try to fix it in the same 10 minutes as I was fixing complete breakage in it [00:15:25] The complete breakage and the notices have the same cause I think [00:15:42] do we need to come up with some way to call dibs on scap? [00:15:42] It's running the extension setup files in the scope of execute(), not in the global scope [00:15:55] So the globals (other than $IP and $wgExtensionMessagesFiles) aren't there [00:16:05] It used to run them in the global scope before [00:16:33] hmm, right [00:16:44] <^demon> Well, AbuseFilter seems to have broken when Sam updated the subproject commit to a commit that doesn't seem to exist in AbuseFilter. [00:16:49] <^demon> Probably copy+paste error [00:17:12] RoanKattouw: you want me to do the honours? [00:20:27] TimStarling: For fixing mMFL? I've got a commit almost ready [00:20:39] Just writing the commit summary ow [00:20:44] ok [00:22:02] TimStarling: https://gerrit.wikimedia.org/r/4829 [00:22:49] yes, fine, merge it in [00:23:09] TimStarling: can I run scap? [00:23:13] no [00:23:28] RoanKattouw will tell you when you can [00:23:44] funny that Reedy called it "refactoring" [00:23:48] Yeah [00:23:53] That is the full commit summary too [00:24:03] * RoanKattouw +2s his own commit because Tim said he could [00:24:26] TimStarling: okay, well the mobile site is broken [00:24:37] TimStarling: so, I need it as soon as possible [00:24:40] can you use sync-file instead? [00:24:56] TimStarling: it's a number of changes [00:25:01] TimStarling: can I sync-dir? [00:25:09] no, you can run it a lot of times though [00:27:53] OK hang on [00:27:55] <^demon> Whoops, wrong channel. AbuseFilter should be fixed now in 4830. Roan, mind looking at that for me? [00:28:07] I merged the mMFL change, let me put that on fenari [00:28:15] ^demon: sure but you're 4th in line ;) [00:28:27] * ^demon cuts [00:28:29] <^demon> :) [00:29:04] TimStarling: OK mMFL should be fixed now [00:29:14] Could you direct preilly through the rest of this? [00:29:26] sure [00:30:23] TimStarling: what's up? [00:30:34] someone needs to run scap, I think it should probably be me in case it doesn't work [00:30:49] assuming Roan is going away [00:31:41] running it now [00:33:03] it's not really Reedy's fault, I should have realised what was going on when I hacked it up in 1.19 [00:33:48] When did you hack it up? [00:33:49] but obviously I had forgotten by then how mergeMessageFileList.php was meant to work, even though I wrote it [00:33:58] History doesn't show you touching it since Reedy broke it [00:34:06] or anyone, in fact, apart from Siebrand making a one-line change [00:34:12] I fixed all the extension registration files so that they didn't break too badly without global variables [00:34:29] <^demon> So, do we need PrefStats as a submodule? I don't see it in make-wmf-branch's config. We *do* have PrefSwitch still. [00:34:33] before I did that, there were lots of fatal errors, not just notices [00:35:39] right [00:35:58] ^demon: Let me see what I can do about eliminating that dependency [00:36:05] <^demon> Even better. [00:36:07] TimStarling: are you running the scap command right now? [00:37:50] yes [00:38:10] TimStarling: okay, great [00:38:14] RoanKattouw: didn't work [00:38:25] D;oh [00:38:31] I only backported it to 1.20wmf1 [00:38:33] Not 1.19wmf1 [00:38:57] * RoanKattouw fixes that locally [00:39:04] it's broken in 1.20 too [00:39:11] you might want to fix it before you backport [00:39:28] OK let me test that then [00:39:28] look at /home/wikipedia/common/wmf-config/ExtensionMessages-1.20wmf1.php, it's a parse error [00:40:05] PHP Parse error: syntax error, unexpected $end, expecting '(' in /home/wikipedia/common/wmf-config/ExtensionMessages-1.20wmf1.php on line 205 [00:40:07] WTF [00:40:15] OK that's embarassing sorry [00:40:49] what the ... [00:40:57] This must've been in the backport itself [00:44:20] Oh, no, I see [00:45:20] <^demon> Who needs a channel full of people talking when we can just sit here and watch Roan editorialize his work. [00:45:42] lol [00:45:49] OK why the hell is it outputting Array at the end [00:46:27] dot [00:46:34] '$wgExtensionMessagesFiles = ' . var_export( $wgExtensionMessagesFiles, true ) . ";\n\n" . [00:46:40] should be semicolon [00:46:58] it appends $dirs to the end of the output [00:47:25] Aaah [00:47:27] Oh [00:47:29] That's me [00:47:33] Bad bad Roan [00:47:38] I removed the line below [00:48:33] OK someone approve https://gerrit.wikimedia.org/r/4831 please [00:49:19] <^demon> Har har. [00:49:21] <^demon> Silly Roan. [00:49:54] TimStarling: OK fixed now [00:49:57] <^demon> Merged. [00:50:09] running scap [00:51:41] might be nice to have that in 1.19 also [00:52:06] I just edited the working copy [00:52:27] /usr/local/bin/lint: line 2: 4725 Segmentation fault php -n -dextension=parsekit.so `dirname $0`/lint.php "$@" [00:52:34] hmm [00:54:37] <^demon> RoanKattouw: Does 4831 need backporting to 1.20wmf1 and 1.19wmf1? [00:55:05] raindrift: ResourceLoader only ever loads things as text/js , even CSS is loaded that way (as a string) [00:55:11] !g 4831 [00:55:11] https://gerrit.wikimedia.org/r/4831 [00:55:40] ^demon: Backport to 1.20wmf1 is already done [00:55:48] Backport to 1.19wmf1 I will handle [00:55:54] RoanKattouw: i can likely load the templates that way too. they end up in JS vars anyway. It's just a pain to make a mutiline string in JS... [00:55:58] <^demon> Ok good, I don't have it checkout out right now :) [00:56:01] Tim is syncing the 1.20 and 1.19 copies on fenari all the time, I'll just commit what he ends up with [00:56:14] Huray to whoever enabled magic bug, hash and external links in gerrit commit msgs [00:56:18] TimStarling: did you finish running scap? [00:56:27] anything else new? [00:56:28] raindrift: If you want you can write a custom RL module that takes the template from the file and runs it through escapeJsString [00:56:37] <^demon> Krinkle: That was me. It was a simple config change. And we can totally add more to those if we want :) [00:57:05] RoanKattouw: that sounds like it might be reasonable. is there an example of that someplace? [00:57:11] ^demon: "show me tha source coude!" [00:57:24] raindrift: Ahm, let me see [00:57:30] <^demon> Krinkle: https://gerrit.wikimedia.org/r/#change,4796 [00:58:11] raindrift: See ResourceLoaderUserTokensModule.php in core [00:58:38] Except that you'll want to remove the origin override [00:59:16] OK bad example maybe, cause you need to strip everything except getScript() :D [00:59:28] ^demon: nice [00:59:41] ^demon: that config is shared between comment parsing and commit-msg ? [01:00:00] RoanKattouw: no, this makes some sense… so, how is this called? [01:00:07] raindrift: So long story short, make a subclass of ResourceLoaderModule and implement getScript() and getModifiedTime() [01:00:15] <^demon> Krinkle: Yes, afaict. [01:00:20] raindrift: $wgResourceModules['foobar'] = array( 'class' => 'MyClass' ); [01:00:31] nice [01:00:32] We will want to make a generic class for this probably [01:00:44] That's parameterized and stuff [01:00:45] scap is finished now [01:01:08] <^demon> Krinkle: https://gerrit.wikimedia.org/r/#change,4828 last comment. [01:01:53] RoanKattouw: oh, I see, and then I can make it so everything under the 'scripts' parameter gets loaded with escapeJsString()? [01:02:10] Ideally that's how it would work yes [01:02:11] Actually [01:02:15] Maybe I should just make this class [01:02:22] As a subclass of FileModule [01:02:25] or something [01:02:36] <^demon> RoanKattouw, TimStarling: Any other deployment branch/submodules questions? I'm thinking of calling it a night if you guys don't need me any more. [01:02:47] RoanKattouw: well, I won't stop you, but I'll do it either way since I have a lot of templates. :) [01:03:19] Or not, FileModule is a behemoth [01:03:53] Hmm yeah you could write getScript() so it reads the script files from the $context parameter [01:03:56] Look at how FileModule does it [01:04:11] You'll also have to get the mtimes from the file system and use them in getModifiedTime() [01:04:22] FileModule does these things but in a much much more complicated way [01:04:29] RoanKattouw: what are the times for? [01:04:33] because it's got CSS and embedded images and all that crap to deal with [01:04:35] raindrift: Cache invalidation [01:04:42] RoanKattouw: right, of course. [01:05:02] ^demon: no other questions, thanks ^demon [01:05:54] <^demon> Alrighty, night all. [01:06:02] hrm....I just noticed the REL1_20 branch. bummer....that's really premature [01:06:20] <^demon|zzz> robla: Actually, Sam and I wanted to talk to you about that. [01:06:30] <^demon|zzz> /msg? [01:06:34] sure [01:06:41] YuviPanda: action=raw isn't very flexible, and not able to load batches or optimize the load (e.g. minify) [01:06:52] YuviPanda: load.php requests through resource loader will be more effeceint [01:07:08] Krinkle: hmm, but I don't see a way to use them for templates... [01:07:13] don't get me wrong though, if you need a quick hack and don't have server access (e.g. a quick gadget) then using action=raw will work fine [01:07:31] Krinkle: yeah, I don't think there was another solution in my case. [01:07:33] YuviPanda: In this case it is a mediawiki extension. [01:07:39] (raindrift case that is) [01:07:45] or mw core [01:07:51] Krinkle: are there thoughts of adding support for this into RL? [01:07:59] support for what? [01:08:00] 'this' -> 'templates' or in general, 'data'? [01:08:09] Sure, but it's all there. [01:08:09] i'm not sure you can do any 'batching', etc on them though... [01:08:24] Maybe not with those words, but its very flexibile [01:09:07] Especially now that Gadgets (as of 1.18 and will be better around the time 1.21 gets around) can use ResourceLoader [01:09:34] there could be a few adjustments in core, but I think for the most part the support is all there, ready to use. Anything specific done would only limit it. [01:10:09] RoanKattouw, Krinkle: thanks for the advice. I'll see what I can do, and probably come back with more questions. [01:10:15] headed home now, though… g'night! [01:11:55] Krinkle: hmmm, I haven't looked too closely into all of RL, except for mw.loader. Not explored that fully either. Will poke you when I do that, which I guess i'll when I get the time :) [01:11:59] * YuviPanda likes client side template [02:38:48] TimStarling: ping [02:38:59] TimStarling: is the message cache having issues? [02:38:59] you rang? [02:39:17] not that I'm aware of [02:39:27] TimStarling: I'm seeing [02:39:39] TimStarling: on http://en.m.wikipedia.org/w/index.php?title=India#section_footer [02:40:28] TimStarling: you'll need to opt in to the beta to see it http://en.wikipedia.org/wiki/Special:MobileOptions/BetaOptIn [02:41:24] TimStarling: I've got those keys in the MobileFrontend.i18n.php file on fenari [02:42:09] I'll try rebuilding the l10n cache [02:42:19] TimStarling: okay, great [02:46:22] TimStarling: do you mind letting me know when it completes [02:46:53] ok [02:51:06] it's finished [02:51:50] and I see your messages in the l10n file now, they were missing before [02:52:33] TimStarling: thanks [02:52:40] TimStarling: any idea why that failed? [02:53:33] maybe that cache was generated with the broken version of mergeMessageFileList.php and not updated after Roan fixed it [02:54:30] TimStarling: okay, that makes sense [03:00:27] TimStarling: is it possible that it is still having issues [03:00:52] anything's possible [03:01:17] TimStarling: well, I'm still seeing it being wrong on some page view and correct on others [03:01:26] s/page view/page views/ [03:01:33] sounds like HTML caching [03:02:51] TimStarling: well, I'm changing the URL parameters and it still does it [03:05:14] does MobileFrontend do its own caching? [03:06:55] check the Age header in the response [09:23:55] hi there, does anyone know how can I emulate storing temproray files? I just installed mediawiki in localhost and I want to run uploadwizard but I get an error on storing temporary files [09:30:02] davidpardz: make sure you remember to say when it gets resolved in #mediawiki since you are asking there too, or say what progress you make if it doesn't get completely resolved. [09:34:23] bianca: hi, thank you. I resolved it with what potter suggested [10:11:24] hashar: thanks for pointing me to Adam's parserTests patch yesterday! [10:12:24] The 'parsed' keyword triggered an alarm [10:12:31] you might want to get in touch with him [10:12:45] since he could probably help writing tests or fix the parser :D [10:13:50] hashar: he already wrote quite a few patches [10:14:15] and he is still working on lists: https://gerrit.wikimedia.org/r/#change,4847 [10:14:42] well that patch is your! [10:14:54] oops [10:15:01] https://gerrit.wikimedia.org/r/#change,3729 [10:15:16] ;) [10:15:34] \O/ [10:15:50] I spent sometime in November trying to figure out the parser [10:15:56] and eventually gave out :-]] [10:16:05] I will need a training course one day [10:16:26] will try to grab you in Berlin [10:16:31] ;) [12:40:51] New patchset: Hashar; "split classes in their own files" [integration/testswarm] (master) - https://gerrit.wikimedia.org/r/4861 [12:41:10] New review: Hashar; "(no comment)" [integration/testswarm] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4861 [12:41:13] Change merged: Hashar; [integration/testswarm] (master) - https://gerrit.wikimedia.org/r/4861 [16:10:25] can somebody guide me to the codebase of mwbot ? [16:11:53] !bot [16:11:53] A bot is an automatic process which interacts with MediaWiki as though it were a human editor and is designed to simplify repetitive actions too cumbersome to do manually. An overview of how to create a bot and a list of known frameworks can be found at http://en.wikipedia.org/wiki/Wikipedia:Creating_a_bot [16:11:57] !mw-bot [16:11:57] Hi! I'm mwbot, a bot that was quickly whipped up by Daniel Cannon (AmiDaniel) to help out around #mediawiki. Some quick help is at http://www.mediawiki.org/wiki/Mwbot, you can find all my source code at http://amidaniel.com/viewvc/trunk/MWBot/?root=svn [16:12:02] drecodeam: ^^ [16:12:41] sumanah: thanks, i was thinking of making the logs more readable [16:12:56] drecodeam: you might also like to look at wmbot, which petan worked on [16:13:04] drecodeam: it is in a different language IIRC [16:13:31] sumanah: i would search it, but the source code link is not working [16:14:14] drecodeam: IIRC the code is also on toolserver.org somewhere, not sure where [16:14:37] i would search it and ping others if i don find it [16:15:15] but i can not seem to find the source code of mwbot [16:16:11] drecodeam, I don't think it's available [16:16:23] we have the jars, but the code... [16:16:36] there was a thread in wikitech a few months ago [16:16:56] Platonides: we do have the code [16:17:00] drecodeam: yeah, look in the wikitech-l mailing lists [16:17:15] Snowolf, then they hide it to me [16:17:29] I was told it was decompiled... [16:17:48] (well, initially, they said it was available, but ended up as not being) [16:18:03] might depend on your definition of code, though x [16:18:06] xD [16:18:11] Platonides: I thought OverlordQ had the code [16:18:23] sumanah: re [16:18:25] I don't see anything in gsoc [16:18:33] OrenDsk: what do you mean? [16:19:08] I got a nemail from you [16:19:22] but I don't see any place I can rate anything yet [16:19:31] I created a profile [16:19:52] OrenDsk: what is your LinkID? [16:20:09] Platonides: sumanah Snowolf i would search the mailing lists then. Sorry but i need to go for dinner now, would get back to you if i dont find anything [16:20:14] bye drecodeam! [16:20:16] orenbochman [16:20:31] drecodeam: I am going thru the thread, which is http://www.gossamer-threads.com/lists/wiki/wikitech/263620 [16:20:35] OrenDsk: please find the spot where you apply to mentor for a specific organization [16:20:45] OrenDsk: and request to mentor for "Wikimedia Foundation" [16:21:02] I never saw that option [16:21:16] OrenDsk: please look around [16:21:25] OrenDsk: Melange's interface is hard [16:21:28] Snowolf: i would look at it. Thanks [16:21:36] OrenDsk: I'm not a Mentor so I don't know where to tell you to click [16:21:41] drecodeam http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/57630 [16:21:43] ok [16:21:44] OrenDsk: maybe in your "dashboard"? [16:21:50] I'll look around [16:22:18] Platonides: http://toolserver.org/~mwbot/mwbot.tar.gz this is the code, dunno if it is indeed decompiled or not tho [16:22:45] it was decompiled [16:22:51] Ah [16:22:53] see http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/57677 [16:23:16] Platonides: "may be" but k [16:24:13] Ok I sent a mentor request [16:24:58] Snowolf, I took from the remainder of the email that *that instance* had been decompiled [16:25:34] OrenDsk: accepted. You can now score proposals and you can leave public or private comments on proposals [16:25:39] Platonides: k :) [16:25:43] ok [16:26:02] OrenDsk: please do not tell any student that s/he will be accepted or rejected [16:26:06] on April 23rd we announce everything [16:26:20] I've been working all week on a the search project proposal [16:26:36] OrenDsk: what do you mean? [16:26:42] OrenDsk: a proposal for GSoC? [16:42:52] New patchset: Hashar; "testswarm: new simpler submit script" [integration/testswarm] (master) - https://gerrit.wikimedia.org/r/4894 [16:43:15] New review: Hashar; "(no comment)" [integration/testswarm] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4894 [16:43:17] Change merged: Hashar; [integration/testswarm] (master) - https://gerrit.wikimedia.org/r/4894 [16:44:10] tewwy: please try logging into Gerrit with your Labs credentials [16:52:10] Platonides: Snowolf drecodeam you might want to add https://www.mediawiki.org/wiki/Talk:Mwbot to your watchlist [16:58:48] <^demon> http://gerrit-dev.wmflabs.org/r/Documentation/dev-design.html is a good read, hehe. [16:58:59] <^demon> It has wonderful little tidbits that explain why gerrit did what they did :) [16:59:25] <^demon> "Supporting non-JavaScript enabled browsers is a non-goal for Gerrit." [16:59:34] <^demon> ...As Gerrit is a pure-GWT application with no server side rendering fallbacks, the browser must support modern JavaScript semantics in order to access the Gerrit web application. Dumb clients such as lynx, wget, curl, or even many search engine spiders are not able to access Gerrit content. [16:59:53] <^demon> "Users who are committed to developing changes for a Gerrit managed project can be expected to be able to run a JavaScript enabled browser, as they also would need to be running Git in order to contribute." [16:59:55] <^demon> Heh [17:01:32] Still, I don't think Gerrit is necessarily the best example of clueful web dev [17:02:16] <^demon> Maybe not, but at least they took the time to explain why they did what they did :) [17:02:25] True [17:02:27] <^demon> Even if you're like "I totally disagree with everything you're asserting" [17:04:27] git does not requite js [17:04:30] just sayin... [17:04:32] *require [17:04:35] Yeah that assertion is kinda stupid [17:05:00] assert(..): fail :-P [17:07:33] maybe they are only presenting their excuses :P [17:16:48] ok! time for me to look at https://www.mediawiki.org/wiki/Wikimedia_engineering_20%25_policy [17:17:21] bsitu: awjr Reedy and Ryan Kaldari [17:17:36] and Antoine and gwicke [17:17:37] hello, sumanah [17:17:46] hi there! [17:18:06] so, I have a few offerings y'all could pick through for 20% time [17:18:22] Hello [17:18:29] sumanah: i've got to resolve some emergency issues around yesterday's MobileFrontend deployment but was then planning on continuing work on my dippy-bird scripts for doing various gerrit actions via the command line [17:18:40] I have patches from volunteers, and I have some other kinds of work [17:18:46] awjr: makes a lot of sense! [17:18:49] awjr: best of luck [17:18:52] :D [17:19:58] bsitu: do you think you would prefer to review more patches, or to perhaps work on some unit tests? [17:22:14] is Kaldari around? [17:22:20] I have no preference [17:22:28] bsitu: ok, patch review it is [17:22:44] yes he is here, let me ask him to sign into irc [17:23:47] bsitu: https://bugzilla.wikimedia.org/show_bug.cgi?id=35923 and https://bugzilla.wikimedia.org/show_bug.cgi?id=22770 and https://bugzilla.wikimedia.org/show_bug.cgi?id=35060 [17:24:01] hi kaldari! how are you today? [17:24:05] reporting for duty! [17:24:11] kaldari: do you already have 20% plans? [17:24:21] okay, I will take care of this one first: https://gerrit.wikimedia.org/r/3328 [17:24:30] kaldari: because I understand that you are reviewing some drecodeam patches [17:24:31] I was going to do code review on PageTriage, but what else do you have? [17:24:40] Oh yeah, I need to do that too [17:25:11] kaldari: and in fact that might be more urgent, since it would feed into your analysis of GSoC candidate stuff [17:25:48] kaldari: https://bugzilla.wikimedia.org/show_bug.cgi?id=32247 is one - do you need links to the others? I can grab [17:25:50] true, I already did some proposal scoring BTW [17:25:55] thank you kaldari! I appreciate it [17:26:31] drecodeam already sent me all of them [17:26:37] kaldari: eager! :) [17:26:48] kaldari: ok, sounds like you are set for the rest of your day of work then :D [17:26:56] indeed [17:26:59] bsitu: and you have enough to do for the rest of the day as well? [17:27:14] and I know Arthur does [17:27:37] I shall email Amir and gwicke to follow up [17:28:04] (regarding the weekend) [17:28:06] Thanks all! [17:28:40] hi kaldari, good to see you ! [17:28:49] howdy :) [17:29:43] trying to find the irc bot code and starting off with writing documentation of Upload Wizard [17:29:47] did you get my mail ? [17:30:10] drecodeam: see https://www.mediawiki.org/wiki/Talk:Mwbot [17:30:17] ok, off to a meeting [17:30:45] ya sumanah seeing it only [17:47:04] kaldari: for https://bugzilla.wikimedia.org/show_bug.cgi?id=32247, the patch is not the right solution. There are some issues which i discovered later, i am modifying the bug now. [17:48:55] thanks [17:49:02] I'll hold off on that one then [18:07:18] kaldari: ping [18:07:32] hello [18:08:28] hi kaldari [18:08:41] howdy [18:09:15] Platonides: Did you see my comment on your GSoC proposal? [18:09:19] kaldari: i hope that you got my mail [18:10:04] drecodeam: I'm not sure if I did, what was the subject? [18:10:50] kaldari: the old one, i replied to the ideas you had suggested me [18:11:19] subject : GSoC 2012 - Integration of Flickr and enhancing Geolocation support in Upload Wizard [18:12:26] oh yeah, I saw that... [18:12:40] The tineye thing was just an idea, wasn't sure how practical it would be [18:12:52] regarding the flickrreview part.. [18:13:18] I think that's already written into the FlickrReviewer code in UploadWizard (I think) [18:13:51] er sorry FlickrChecker code [18:13:53] mw.FlickrChecker.js [18:14:34] ya it is [18:14:43] it added the template where appropriate. Of course that code isn't actually being used yet. [18:14:48] added=adds [18:15:26] Are you aware of the Flickr blacklists on Commons? [18:15:41] you'll want to look into those as well [18:15:49] kaldari: ya i have read about them [18:15:55] awesome [18:17:35] kaldari: i was talking to sumanah the other day about starting off with improving the documentation of upload wizard. She told me some points, and i am gonna start working on improving the docs [18:18:57] also, did we get any reply on the Browser Stack request ? [18:22:39] not yet :( [18:22:59] improving the documentation would be great [18:23:23] ya, do you have any points i should keep in mind while writing it ? [18:41:32] not anything specifically [19:03:19] drecodeam: kaldari: hey, if you have a moment to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=11142 which is also uploadwizard-related then I'd appreciate it [19:05:26] hi kaldari I'd like to get more involve with UploadWizard. Rigth know I'm working on a bug to get more familiar with the code. I only wanted to pointing out [19:14:54] davidpardz: what is it you wanted to point out? [19:15:18] !seen Amgine [19:15:46] heh, ww [19:23:51] hi i'm wondering if there is a way to see the old green and yellow diffs without applying a non-vector skin [19:24:39] any problem if i run scap in ~15 minutes? [19:24:47] the bubbles around the diffs are making it harder to visually process all of it [19:30:37] <^demon|away> awjr: I'd ask RoanKattouw_away. There were some problems last night. [19:31:16] ^demon|away thanks for the tip [19:31:32] it would be nice if when there are issues with scap or whatever there would be an email sent out or something [19:47:43] robla: do you know if the current state of scap is sane enough to use safely? [19:48:01] none of the other usual suspects seem to be around to confirm [19:49:21] awjr: you should have one of the usual suspects around for any deploys that you do. is there something being deployed today? [19:49:52] robla: yeah it's a semi-emergency fix [19:50:57] awjr: can you elaborate? [19:51:01] robla: we were going to push out a few additional things since i was going to deploy anyway, but if things are ambiguous, i can just push out the fix with sync-file [19:51:16] robla: it's a bug fix for MobileFrontend that was introduced in yesterday's deployment [19:51:28] robla: https://bugzilla.wikimedia.org/show_bug.cgi?id=35940 [19:53:14] robla: basically it's a case where toggling desktop/mobile views sometimes will not work. it would be nice to not leave it broken over the weekend. [19:53:45] Reedy: are you about? [19:56:01] * robla consults with AaronSchulz in real life [19:56:47] * AaronSchulz thinks roan fixed scap [19:57:17] preilly: awjr: how comfortable are you two with the new deployment system after yesterday? [19:57:33] awjr: were you around, or was it just preilly? [19:57:36] it would be really great to get emails about those kinds of things when scap breaks/gets fixed [19:57:40] robla: just me [19:57:49] robla: it seemed fine [19:57:50] robla: i was preipherally around eysterday but it was preilly who pushed the buttons [20:00:22] awjr: ok....I'd still like to make sure AaronSchulz is around for your sending out the fix, but otherwise, it's probably fine to do it. before you start though... [20:01:08] robla sure thing [20:01:26] AaronSchulz: are you going to be around for a bit? we'd like to push these changes out pretty soon [20:01:28] awjr: one question for you...is this a big enough change that scap is the right tool for the job? I'm naively asking that [20:01:51] robla: to do /just/ the bug fix, we could do sync-file, but to do the other changes we'll need scap [20:02:21] how long? [20:04:55] * robla starts looking up the difference on the MobileFrontend stuff [20:06:33] awjr: use sync-dir [20:07:03] oo i didnt even know that was a thing. [20:08:06] awjr: neither AaronSchulz or I have had lunch yet...can this wait until after then? [20:10:27] robla, AaronSchulz: yeah that's fine. i'm making a motion to the rest of the team that we just push the bug fix and save the rest of the stuff to deploy until next week anyway [20:10:50] robla, AaronSchulz: if we just sync-file for the bug fix do you still want to be around? [20:11:56] <^demon|away> sync-file or sync-dir should be fine. [20:12:14] <^demon|away> We're just leery about scap because it rebuilds message caches and that was flakey last night. [20:12:21] me can stay for a while [20:12:25] <^demon> RoanKattouw: Did you and Tim clean that up after I signed off? [20:12:31] * /me :) [20:12:38] <^demon> Or Aaron :) [20:12:40] <^demon> Heh [20:12:43] ok...cool, thanks Aaron [20:12:51] Yes, I believe so [20:12:58] mMFL runs without errors now [20:13:15] <^demon> I can stick around for a bit too in case anything explodes. [20:13:23] <^demon> Hopefully it doesn't, it's 4pm on a friday for me :) [20:13:29] ...and the second shift has arrived, so this is almost certainly a non-issue now. awjr: fire at will [20:14:01] heh ok thanks ^demon, robla, AaronSchulz, RoanKattouw [20:15:01] <^demon> It's 4pm Friday on this coast. You know what time that is :) [20:16:16] <^demon> Stupid question: does dry vermouth go bad? [20:23:20] <^demon> Ah yep, it most certainly does. [20:24:59] hey rsterbin1 [20:25:10] what's up? [20:25:12] hola [20:25:22] I'm working on the clicktracking specs fr Stage 3 [20:25:30] just one clarification [20:25:35] ok [20:26:04] Option4E will default to the learn more alternative when the page is not editable (like the CTA), right? [20:27:22] that's right [20:27:38] cool [20:27:42] do we have any protected page on prototype to test this? [20:27:51] i think so [20:28:03] looking it up [20:28:10] i think there's a category page [20:28:17] should be easy to find :) [20:28:33] http://prototype.wikimedia.org/release-en/Edit_semi_protected_page_test [20:28:39] there's a special page [20:28:42] cool [20:28:45] http://prototype.wikimedia.org/release-en/Special:ProtectedPages [20:29:30] aah [20:29:40] hmm, I see exactly the same Option4E design when I am logged out [20:29:55] hm [20:30:05] is that because of the override in the URL? [20:30:10] yep [20:30:19] override always works [20:30:46] it shouldn't tho, right? If I specify option 4 and af_link = 5 I should be able to see the Option4E version with the learn more design, no? [20:30:59] or is that a separate form_id ? [20:31:35] to put t differently what's a URL override to see that form? [20:32:26] aftv5_form=4&aftv5_link=E [20:32:37] learn more is a CTA [20:32:52] it won't affect option 4 [20:32:55] hmmm [20:33:01] i'd have to add that [20:33:24] wait, I'm confused [20:33:24] ok, will do. [20:33:47] i was wrong before — option 4 is not the same thing as the edit CTA [20:33:51] it should be an alternative version of Option4E for non-editable pages [20:33:52] right [20:33:59] therefore it doesn't get replaced by the learn more CTA [20:34:06] ha [20:34:18] so right now it just displays the same form, right? [20:34:20] yep [20:34:41] that wasn't in the specs way back when option 4 was designed [20:34:43] ok [20:34:53] so we'll need to update the specs [20:34:56] I see, I think it should be there [20:35:07] yes, let me talk to Fabrice [20:35:20] it won't be exactly the same as the learn more cta — no confirmation message, for one thing [20:35:35] thanks [20:35:44] right [20:35:46] let me know when the specs are ready, and i'll make it happen [20:35:54] great, thanks [20:36:42] np [20:40:55] fabrice is ooo today, I'll mail the rest of the team and Howie [20:50:57] I've just seen "Scribunto — Dolphin" in my task bar, and for a second I was trying to guess which of this is an artist name, and which is a song title [20:52:04] lol [20:53:19] rsterbin1: mail sent, I haven't filed a bug yet, you may want to do so if we assume the fallback will need to be implemented before next week's deployment [20:53:52] thanks [20:53:57] in the meantime I'll go ahead and create preliminary clicktracking specs as if we had the fallback already in place [20:54:02] will ping you when I'm done [20:54:48] the bug shouldn't be necessary; i should be able to take a stab at it on monday even if fabrice doesn't finish with the specs [20:55:42] cool [21:02:37] rsterbin1: even without the full specs, I expect that we won't display the Option4E fallback with a feedback link at all, is that a reasonable assumption? [21:02:49] yeah [21:03:05] but we will still display it at the bottom of the page [21:03:47] * DarTar trying to figure out the implications on the data we collect  [21:05:27] the feedback link will need to be activated depending on protection status only for users in bucket 1E, not for those in 4E, and we need to capture impressions for the fallback separately [21:05:47] wow, it's getting complicated [21:06:23] init events will be the same for Option4E regardless of the protection status, correct? [21:06:57] (i.e. the fallback will still generate an init event for Option4E) [21:08:19] tfinc, you wanted to hear about the joys of custom a/b tests with mw extensions didn't you? :) [21:10:14] ok, rsterbin1, I think I'll set up the clicktracking specs based on a number of semi-arbitrary assumptions I make and we'll get Fabrice and the rest to discuss them on Monday [21:10:34] ok [21:14:16] sumanah kaldari looking at the bug now [21:14:26] great [21:14:30] sorry, gotta go for the day [21:48:56] rsterbin1: ct specs completed, with a list of assumptions and several inline comments http://meta.wikimedia.org/wiki/Research:Article_feedback/Clicktracking#Stage_3_.28Impact_on_engagement.29 [21:49:16] great, thank you [21:49:18] I want to talk to Aaron to make sure he's aware of these limitations [21:50:07] it particularly annoys me that we don't have actual impressions for the direct CTA, only a sample, but I don't think there's an easy way to get those counts [21:54:11] sorry, I meant inits [21:54:29] we *do* get impressions [22:17:51] kaldari: are you gonna come to the Berlin Hackathon ? [22:18:11] probably not this year [22:20:56] ohh ok [22:21:48] btw kaldari, where are you located now? [22:21:58] Oakland/SF [22:22:22] where are you at? [22:22:29] Spain [22:22:50] I thought you were in SF, but you then confused me on writing that gsoc comment in European morning [22:23:55] Platonides: Spain is a beautiful place, i really want to visit it once [22:24:43] drecodeam, where are you from? [22:24:49] India [22:25:07] that's an interesting country [22:25:31] Spain will probably end up hosting a Wikimania sooner or later [22:25:36] (but don't hold your breadth, not too soon) [22:25:42] very diverse and vibrant, the culture here is great [22:25:46] I've never gone out of Europe [22:25:59] ohh, i am looking forward to Wikimania Europe [22:42:47] * RoanKattouw wonders what the bids for 2013 are [22:42:52] I think Bristol put one in [22:43:01] Spain is one of the few places in Europe I would actually like to hang out [22:43:14] maybe Italy or Greece too [22:43:30] the rest of it is too cold [22:43:56] and the food is bland :) [22:44:27] but don't tell Foundation-l I said that :) [22:45:20] xD [22:45:33] India and Spain have good food though [22:47:39] true that kaldari, india does have great food. [23:18:23] kaldari: if you are free, then take a look at this : https://bugzilla.wikimedia.org/show_bug.cgi?id=11142. The patch does not seem to be valid now as that message does not exist [23:22:38] You're not Tomer A., right? [23:23:29] wonder who that is [23:25:37] kaldari: see this, https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/UploadWizard.git;a=blobdiff;f=UploadWizard.i18n.php;h=327448363c4f68a5ed973413d1594ffde30f60ff;hp=32bb094a0c7f152c8af53165693afad3f5990cae;hb=989d18720289aa47d4d0949494c5b9b6a968febc;hpb=b5d699ff016d3dc6428b1d8264b08d301d31935d [23:26:09] this was the revision in which the message class were removed. I wanted to ask, what should i do now to the bug [23:26:52] i mean what should be the keywords i should add or comment i should make ? [23:28:41] probably best to ask Siebrand [23:30:05] although he may be asleep [23:31:47] ok i will ask him if i find him around, awake that is :D [23:32:41] siebrand: What messages should be used for those UploadWizard error messages now? [23:45:44] Oh wow [23:45:50] I did my first -1 [23:46:07] And gerrit messed up my comment by making it single-line