[00:25:28] robla: are you guys doing a deployment tomorrow? [00:25:47] asking for fundraising. they are planning a test [00:52:03] Ryan_Lane: no [00:52:25] 16th is the next one [00:58:28] Reedy: thanks [03:08:34] petan: ping [03:31:17] If you or a MediaWiki developer you know is interested in improving watchlists with grouping and usability enhancements, please let me know. I have submitted a clear and practical project proposal for the 2012 Google Summer of Code and I am seeking a mentor. I will, of course, do all of the heavy lifting (coding) to make it happen. All I need from a mentor is knowledgeable guidance and occasional assistance with debugging. [03:31:56] Potential mentors can view the project here: http://www.mediawiki.org/wiki/User:Blackjack48/GSOC_proposal_for_watchlist_improvements [03:34:27] I realize it is very short notice but I've had some trouble finding a mentor. I really think MediaWiki could benefit from my proposed improvements. Feedback is appreciated too - thanks. [05:31:21] blackjack48: Hi. [05:31:39] I was just about to post to the mailing list about you. [05:31:43] But now you're here. [05:31:45] So I don't have to. [05:31:50] You should post to the mailing list. [05:31:52] wikitech-l [05:32:09] https://lists.wikimedia.org/mailman/listinfo/wikitech-l [05:32:17] I did, however I think the post fell a bit back. [05:32:27] So, I'll post again [05:32:45] Did you talk to Sumana? [05:32:50] I think this is what she does all day. [05:33:03] She should be able to find you someone to be a mentor. [05:33:26] Yes, I've been in touch with her and she seems very interested in my proposal. [05:33:35] She can't find you someone? [05:33:54] How married are you to this idea? [05:34:45] I've already submitted the application but I can change details if the community has ideas. [05:35:11] However, I need to find a mentor this week if the idea is to live on. [05:35:19] I was just thinking that if you weren't very attached to it, there aer other projects that Wikimedia would be intersted in. [05:35:29] are [05:35:34] But it's a fine idea. [05:35:39] Better watchlists would be great. [05:35:49] There are plenty of bugs and brainstorming pages on mediawiki.org, I think. [05:35:55] If you haven't found them already. [05:36:09] Watchlist grouping in particular has been endlessly discussed, I think. [05:36:16] Anyway, Sumana should be able to find you someone. [05:36:28] Did you ask her specifically? What was her respose? [05:36:32] response [05:37:22] I'm going to shoot her a quick email, asking if she's found anyone possibly interested. [05:38:48] Okay. [05:39:01] She should be able to find someone. [05:39:11] There are like a million tech staffers now. [05:39:21] Though some are already signed up. [05:39:28] How much hand-holding do you need? [05:39:56] Not much - I learn fast. My work style is outlined briefly in my application. [05:40:09] But basically I check in frequently [05:40:23] and ask for help when I need it. [05:40:31] Frequent check-ins usually mean more work for mentors. ;-) [05:41:50] Sumana is trying to encourage better communication this year... so I don't know whether checking frequently is good or bad :/ [05:42:32] http://www.mediawiki.org/wiki/Summer_of_Code_2012/management [05:51:31] Checking-in is probably good. [05:51:43] Most past GSoC projects haven't amounted to anything. [05:51:51] I'm not sure if they tell you that in the application process. [05:52:40] I don't have exact stats on that, but the general rule is that the larger the project, the more likely it is to fail. People have a tendency to bite off more than they can chew, I think. [05:53:14] No, but I /really/ want the watchlist improvements to amount to something... even if it becomes more of a long term project after GSoC. [05:53:38] (I do realize it'd be a sizable project.) [05:58:18] Anyway thanks for the support, Joan. I'll be logging out shortly. [07:46:09] varnent: . [07:46:13] hi [07:48:48] petan: greetings - how difficult would it be to add support for outreach and some other project wikis to the wm-bot @recentchanges feature? [07:53:30] very easy [07:53:43] it needs to be reported to wikimedia feed [07:53:59] if that wiki has own reports there I can set it up now [07:55:33] where is the easiest place to check that [07:55:44] irc.wikimedia.org [07:56:00] let me check [07:56:19] yeah - it doesn't appear they're in the bot's code or on the IRC page's list [07:57:36] there is a channel for that [07:57:44] however I don't know if works [07:57:58] list these project somewhere and I will check it [08:00:22] I checked in here - http://svn.wikimedia.org/svnroot/mediawiki/trunk/tools/wmib/RClogs.cs - looks like commons, outreach, meta and maybe labsconsole would be helpful additions? we were specifically thinking of a commons and outreach page when this came up [08:03:35] varnent: http://pastebin.com/T5nubaKg [08:03:46] there is config page, links aren't inserted to source code anymore [08:03:50] config file [08:04:19] expand it with wikis you want and I will update it on labs [08:04:29] great - ty :) [08:04:41] however labswiki doesn't have rc feed [08:05:40] it's configured by hand by Ryan and it doesn't use standart setup [08:05:53] makes sense [08:09:08] does it work http://pastebin.com/T5nubaKg [08:09:15] just expand this page [08:19:34] hi [08:26:59] petan: http://pastebin.com/U1TjsAus [08:46:23] varnent: ok [08:47:09] petan: thank you! :) [08:49:24] @recentchanges+ outreach_wiki [08:49:24] Wiki inserted [08:49:27] :o [08:49:28] loading... [08:49:31] ok seems to work [08:49:48] @recentchanges+ commons [08:49:48] Wiki inserted [08:49:58] @recentchanges+ wikitech_wiki [08:49:58] Wiki inserted [08:50:39] fantastic - thank you! :) [08:51:06] you need to set up feed for a list of various pages for it to work [08:51:34] doing that now - working great [08:51:50] ok, let me know if it didn't work [08:56:21] petan: hmm - seems to be having issues on initial tests - adds the items okay - or says it does - but doesn't post changes to the new entries [08:58:21] @RC+ outreach_wiki User:Varnent/Sandbox [08:58:22] Permission denied [08:58:30] oh - ha - right - that's channel specific :) [09:07:16] @RC+ outreach_wiki User:Varnent/Sandbox [09:07:16] Inserted new item to feed of changes [09:08:07] hm... [09:08:24] are you sure there is any activity in that channel on wikimedia irc [09:08:51] @RC+ en_wikipedia User:Petrb/Sandbox1 [09:08:51] Inserted new item to feed of changes [09:09:14] wikimedia-outreach? I believe so - we're looking at using it in wikimedia-lgbt as well [09:09:23] Change on 12en_wikipedia a page User:Petrb/Sandbox1 was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=486973838 edit summary: blah blah [09:09:56] I guess it doesn't work for outreach, eg nothing is reporting changes to that channel on wikimedia server [09:10:39] had the same problem with commons [09:10:41] when you join #outreach.wikipedia on wikimedia you see any changes there? [09:15:34] ok I found it [09:15:35] it's wikipedia, not wikimedia :) [09:15:37] outreach.wikiP [09:15:38] yeah - odd label for that one [09:15:39] Change on 12en_wikipedia a page User:Petrb/Sandbox1 was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=486974480 edit summary: [[WP:AES|←]]Blanked the page [09:15:46] hm, but still doesn't seem to work [09:15:52] @recentchanges+ outreach_wiki [09:15:52] Wiki inserted [09:15:54] @recentchanges+ outreach_wiki [09:15:54] This channel is already watched [09:15:58] ah [09:15:59] that's it [09:16:19] there must be something wrong [09:16:38] it's showing up in the wikimedia irc channels [09:20:26] configuration needed fix [09:20:27] @recentchanges+ commons [09:20:27] This channel is already watched [09:20:28] @recentchanges+ outreach_wiki [09:20:28] This channel is already watched [09:20:30] @RC+ outreach_wiki User:Varnent/Sandbox [09:20:30] Inserted new item to feed of changes [09:20:40] Change on 12outreach_wiki a page User:Varnent/Sandbox was modified, changed by Petrb link https://outreach.wikimedia.org/w/index.php?diff=?diff=33183 edit summary: [09:20:46] works [09:20:50] excellent! [09:21:04] you need to insert it again in your channel [09:21:50] wikitech doesn't exist [09:21:53] so I removed it [09:22:02] ok [09:22:15] it would be nice to have it in feed though [09:22:48] Change on 12outreach_wiki a page User:Varnent/Sandbox was modified, changed by Varnent link https://outreach.wikimedia.org/w/index.php?diff=?diff=33185 edit summary: Blanked the page [09:22:53] yay but link is fucked a bit [09:23:00] https://outreach.wikimedia.org/w/index.php?diff=?diff=33185 [09:25:00] Change on 12outreach_wiki a page User:Varnent/Sandbox was modified, changed by Petrb link https://outreach.wikimedia.org/w/index.php?diff=33189 edit summary: [09:25:27] that's better [09:25:28] there we go :) [09:27:06] works well in the other channel - but not the same luck with commons [09:27:25] @recentchanges- commons [09:27:25] Wiki deleted [09:27:29] @recentchanges+ commons [09:27:29] Wiki inserted [09:27:47] @RC+ commons User:Petrb [09:27:47] Inserted new item to feed of changes [09:28:20] indeed [09:28:42] channel is commons.wikimedia [09:30:27] Change on 12commons a page User:Petrb was modified, changed by Petrb link https://commons.wikimedia.org/w/index.php?diff=69698743 edit summary: [09:30:29] wm2012 works fine [09:30:38] it works on commons too [09:40:59] ty for setting up outreach and others [09:41:08] not sure what's up with commons..but it works somewhat for now :) [09:41:18] I will try to debug it a bit [09:41:26] ty [09:41:32] sorry I gotta dash [09:42:05] right [11:26:59] New patchset: Hashar; "target to take MediaWiki screenshots" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4752 [11:28:31] New review: Hashar; "> Where is `${builddir}` defined? Is that a ./tmp directory created by ant? Or is that the directory..." [integration/jenkins] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/4752 [11:30:40] New review: Hashar; "Patchset 3:" [integration/jenkins] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/4752 [12:59:44] vvv: Hey there [12:59:53] vvv: I noticed your nightly toolserver page is breaking a little bit [12:59:57] Krinkle: hi [12:59:59] do you want help in using resoruceloader on it ? [13:00:09] Krinkle: you mean ~vvv/nightly? [13:00:20] I haven't gitified it yet [13:00:25] yeah [13:00:25] or other tools if you use the same css there [13:00:45] I used to fetch MW CSS/JS [13:02:51] yeah, but as of mediawiki 1.17 (so for a while now), mediawiki uses resoruceloader for css/js [13:02:57] not direct .css files anymore [13:03:14] which means they have version numbers in the url and thus change after each version or even more often if you try to link them directly [13:03:35] all you have to do is instead of embedding vector/screen.css embed the startup module and use mw.loader.load [13:03:45] can work on a toolserver page as well, doesn't need mediawiki :) [13:09:11] vvv: Oh, it's not citified yet [13:09:18] gitified* [13:09:22] gitified? [13:09:22] the documentation suggested that it is [13:09:36] Well [13:09:36] I was citing your sentence [13:10:24] mw [[Download]] says somewhere "Download from Git master or [[tools:vvv/nightly|nightly]" [13:10:25] I suppose that was kept from the svn version, without checking [13:11:13] vvv: wow, ./skins-1.5/monobook/main.css [13:11:30] Yeas [13:11:32] Monobook [13:11:59] That's an old and venerable tool [13:12:31] well, as a quick fix you could use this [13:12:32] https://www.mediawiki.org/w/skins-1.20wmf1/monobook/main.css [13:12:40] instead of http://mediawiki.org/skins-1.5/monobook/main.css [13:13:04] even // relative if you like [13:13:15] so that people don't get warnings when using https toolserver [13:16:36] I still have to gitify it [13:22:32] vvv: Do you know how to do it? Or is it just finding the right time [13:22:50] Well, I assume it should be simple [13:36:55] vvv: ok :) [13:37:10] vvv: btw, there is an issue with using git to clone wikimedia repos on toolserver [13:37:19] What issue? [13:37:24] toolserver has their ssl certificates fucked up again [13:37:28] incomplete paths [13:37:40] so it won't let you do it unless you import the CA manually from firefox or something [13:37:47] Ive bugged them about it but no response so far [13:38:11] since gerrit is only available over https it needs that [13:38:26] <^demon> Just clone over ssh? [13:38:30] https (or ssh, but ssh requires private key and that's not recommended and would still need the certificate) [13:39:09] afaik gerrit uses https for anonymous and ssh for authorized, I'm not sure if ssh requires the CA but it would require the ssh key to be on toolserver [13:44:46] <^demon> You could make a separate public/private key pair rather than putting your normal key on TS ;-) [13:45:05] <^demon> Although anonymous clones are nicer and less scary :) [13:45:17] yeah I know, but that's not something I'd like to document on mw.org [13:45:42] "if anonymous checkout isn't working, please sign up for a Gerrit account and create a separate ssh key for it so that attackers can only commit stuff on your name to gerrit" [13:46:03] :P [13:46:06] <^demon> There's also supposedly a way you can clone over https with a user/password for auth, but I haven't tested it really well yet. [13:46:28] which reminds me, I'll bump that bug [13:46:46] still blocking my toolserver tool from automatically doing git stuff [13:47:19] tools like wmfCodeSearch [13:47:33] (aka wikimedia-svn-search but I had to rename it) [14:46:50] https://www.mediawiki.org/w/index.php?title=Extension:Drafts&oldid=524368&debug=true [14:48:58] <^demon> Magic? [14:49:00] <^demon> Heh [14:51:29] re; http://lists.wikimedia.org/pipermail/wikitech-l/2012-April/059989.html [15:04:25] <^demon> Nikerabbit: Can you commit changes to core? I've got some extra debugging things in place and I've already eliminated 2 of the possible points of failure. [15:12:23] New patchset: Hashar; "Install MediaWiki for testswarm usage" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4752 [15:12:45] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4752 [15:12:47] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4752 [15:18:07] hashar: Hm.. 2 questions [15:18:28] hashar: backend uses mediawiki-git fronted says ./mw/master which is correct? [15:18:44] I'll ask in -operations where the convo is [15:24:46] New review: Krinkle; "(no comment)" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4752 [15:29:10] New patchset: Hashar; "rm MediaWiki jobs that used subversion" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4788 [15:30:29] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4788 [15:30:31] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/4788 [15:30:50] ^demon: FYI I have deleted from Jenkins the Mediawiki jobs that used subversion ( change 4788 ) ^^ [15:30:57] <^demon> ok. [15:31:06] Krenair: ^ [15:44:23] (ok) [16:36:27] ^demon: in about 30 minutes [16:37:07] <^demon> Ok, just ping me then. [16:50:07] wikimedia-e3 [16:50:09] whoops [17:03:00] I can't find a create account from the API. Does anyone know if it is there? [17:04:41] i don't believe it's in there [17:08:47] <^demon> Probably because our account creation API is so awful ;-) [17:09:20] * RoanKattouw looks around for a Fabrice [17:11:41] Morning fabriceflorin [17:12:46] Hi RoanKattouw, auroraerose, rsterbin: Sorry for being a bit late, had a SCRUM meeting with the E2 team that just wrapped up. What did I miss? [17:13:26] Not much, just me looking for you [17:14:31] OK, then. So what do you think of the deployment plan I sent you all by email? Does it seem reasonable? Or should we aim to do less for today's deployment? [17:15:25] hi preilly, how are you today? [17:16:08] fabriceflorin: Looks good although I don't know (or maybe don't remember) what Dario's stuff is [17:16:20] preilly: I have a question for you [17:17:55] hi folks [17:18:07] Cool. To sum up our AFT5 plan for the record, here's what's on our plate for today: [17:18:07] • the two revisions from Elizabeth which we couldn't deploy last time: [17:18:09] • the new icons on the feedback page (courtesy of Reha?) [17:18:10] • the upgrade of emails to oversighters to the main mediawiki email system (RT ticket per our emails with Ryan) [17:18:11] • the switch of oversighter emails to their main email account (a simple variable switch, once we confirm speedier delivery) [17:18:12] • Dario's two requests for AFT5 and AFT4, if completed and tested (Dario, can you give us an update on that?) [17:19:26] RoanKattouw, I will dig up the email thread with Dario to figure out what he wanted from us. He said he would be in the office late today, so don't know if we can get him in the loop in time, but will try. [17:19:42] ^demon: ping [17:19:44] hi robla [17:19:53] <^demon> Nikerabbit: Pong. You ready? [17:19:54] robla: looking for Aaron, waiting for preilly [17:19:59] ^demon: export running [17:20:05] takes some minutes [17:20:24] sumanah: how may I help you? [17:20:57] auroraerose and rsterbin, is there anything special that's needed on your end for deployment? Or should we simply wait for RoanKattouw to deploy your new revisions, then test them on production? [17:20:59] hey preilly! so, not sure whether you saw the recent thread on the developers' list about extensions review -- did you? (checking whether you have the background) [17:21:49] Sorry, I meant to say auroraeosrose -- I always forget to add the 'os' part ;o) [17:22:50] * robla pings Aaron irl [17:23:03] sumanah: I didn't read it [17:23:03] fabriceflorin: You can tab-complete nicknames, you know [17:23:11] !tabcompletion | fabriceflorin [17:23:11] fabriceflorin: Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line. This avoids misspellings. Just make sure it's the right person! [17:23:24] preilly: understood. ok, let me sum up [17:23:32] AaronSchulz: hi! 20% checkin day - already have plans, or need stuff? [17:23:41] hehe [17:23:53] * ^demon adds another ignore rule for mw-bot. [17:23:59] preilly: Tim suggested that it's reasonable & efficient & possibly more pleasant for people to have actual 20% projects [17:24:10] preilly: instead of just doing a bunch of one-off patch reviews of patches by volunteers [17:24:49] preilly: do you think you would prefer to do something like working with a specific community-written extension to review it for possible deployment (which might take multiple 20% days), or continue with 1-off patch review of contributions from volunteers? [17:24:51] small db changed - there is an sql addition (one field) and the script to update the counts fabriceflorin and RoanKattouw [17:24:52] * AaronSchulz can look through extension commits [17:25:03] I've been tailing core all week [17:25:18] AaronSchulz: "tailing"? sorry, don't understand [17:25:21] Yeah [17:25:23] Thanks RoanKattouw and sumanah, what a cool feature! Really appreciate it ;o) [17:25:28] sumanah: I'm not sure [17:25:36] sumanah: I'd need to think about it a bit [17:25:36] sumanah: refreshing and reviewing stuff [17:25:51] preilly: makes sense. ok, so in the interim, here are some patches to consider reviewing today: [17:25:59] preilly: https://gerrit.wikimedia.org/r/#change,4540 [17:26:02] RoanKattouw: I need your help today at 4 pm [17:26:04] preilly: https://gerrit.wikimedia.org/r/#change,4550 [17:26:10] preilly: https://gerrit.wikimedia.org/r/#change,4746 [17:26:27] and preilly are you comfortable with UploadWizard code review? [17:26:29] RoanKattouw: I've got to push a new version of both MF and ZRMA to production [17:26:59] Thanks, auroraeosrose, I appreciate your update about the db change. Is there anything else on your end we need to watch out for? [17:27:00] AaronSchulz: it would also be nice if you could help with reviewing a few patches that have been submitted to BZ [17:27:07] AaronSchulz: that queue is still growing [17:27:15] fabriceflorin: nope, everything else should be good [17:27:17] AaronSchulz: or even just taking a bunch of the most recent ones and sticking them into Gerrit branches [17:28:17] preilly: to help you think about whether you'd prefer a larger 20% project, check out https://www.mediawiki.org/wiki/Review_queue and https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment -- we're trying to be more systematic in doing both user experience and technical/code reviews of community-written projects [17:28:56] RoanKattouw: did https://gerrit.wikimedia.org/r/#change,4601 make into production branch? [17:28:59] preilly: you'd be doing either initial technical reviews of proposed architectures/features, or code reviews of extensions [17:29:07] preilly: let me know your thoughts. [17:29:38] AaronSchulz: does this work for you? https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=MW%20extensions%20with%20patches%20that%20need%20review&list_id=106944 [17:29:55] AaronSchulz: Don't know offhand but I can check [17:29:59] AaronSchulz: I shared that search in BZ. 51 patches awaiting review re extensions we deploy [17:30:02] 'There is no saved search named 'MW extensions with patches that need review'. ' [17:30:08] so, I guess no ;) [17:30:29] * AaronSchulz justs uses the link from the sidebar [17:30:30] AaronSchulz: :/ go into your user preferences/shared searches and you can checkbox that one, shared by me [17:30:32] ok [17:31:09] Yoni just emailed me and said that Reha will be available shortly, to look over the deployment of the icons, so we can minimize the risk of binary files (icon images) being mis-deployed (or having the wrong mime-type etc.) [17:31:17] AaronSchulz: 2 for AntiSpoof, 3 for CentralAuth, 4 for ConfirmEdit... [17:32:07] ^demon: okay, export done [17:32:31] <^demon> Ok, fire away. [17:33:08] Thanks auroraeosrose, glad we're all set on your end. RoanKattouw, let us know what you need from us and when you have the code ready for testing. Is anything special needed for moving over the icons for Reha's revision? [17:33:19] AaronSchulz: you see those? [17:33:26] ^demon: done [17:33:35] <^demon> A-ha! I've got it. [17:33:50] AaronSchulz: git tells me it's in there yes [17:33:56] preilly: so maybe next week (when I'm in town) you can let me know what kind of 20% experience you would prefer and I can help get you that :) [17:34:03] preilly: sound good? [17:34:07] sumanah: hi, hope you are doing well. I'm working on a bug, how can I know if there's already a patch for it? [17:34:12] hi davidpardz [17:34:25] sumanah: sure [17:34:27] davidpardz: usually, if you are looking at a bug in Bugzilla and there is already a patch for it, there are a few signals. [17:34:32] thanks preilly, thanks AaronSchulz [17:34:35] RoanKattouw: ok [17:34:38] davidpardz: example: https://bugzilla.wikimedia.org/show_bug.cgi?id=28850 [17:34:43] davidpardz: take a look at that [17:34:47] it would suck if that regressed again [17:35:05] AaronSchulz: For reference I did git checkout wmf/1.20wmf1; git log | grep e82c2cc7eef7d0d58101f43b5fdba289b2c3967e [17:35:16] davidpardz: under all the metadata at the top, you see an attachment, and it's labeled as "(733 bytes, patch) " [17:35:36] davidpardz: also, someone's added the keywords "need-review, patch" to indicate that this is a patch awaiting code review [17:36:05] fabriceflorin: Thanks for reminding me of the icons, I do need to do special things for those [17:36:20] davidpardz: those are accurate like 90-99% of the time, but just to make absolutely sure you are not wasting effort, you scroll down in the bug comments and you read them and see whether anyone says "here is my patch LINK" or something like that [17:37:05] davidpardz: because sometimes, especially recently, the patch is in Gerrit, and not attached to the bug. [17:37:10] davidpardz: does that help & make sense? [17:37:17] davidpardz: so, if you show me a specific bug, I can help you check it [17:37:40] RoanKattouw: My pleasure. When rsterbin gets back, she can provide more info about the icons, but it should be pretty straightforward. If need be, I can send you a Zip file with the PNGs from heatherw. [17:38:09] sumanah: got it, Thank you! yes that makes sense. I think I can still looking at the bug :) - https://bugzilla.wikimedia.org/show_bug.cgi?id=35702 [17:38:33] No worries [17:38:34] I have the files [17:38:42] I just need to explicitly copy them because they're non-text files [17:39:17] davidpardz: there you go. So, you see that there is the bug description + 1 comment, and neither of them mentions nor links to a patch. [17:39:18] <^demon> Nikerabbit: https://gerrit.wikimedia.org/r/#change,4792 should fix it for the last time. [17:39:23] RoanKattouw: can't you do git show --status-only or something [17:39:27] meh, whatever [17:39:40] davidpardz: No patch is attached in the Attachments section, and the Keywords don't indicate any patch is attached, [17:39:51] davidpardz: so I think this one is clear for you to work on. [17:40:03] * AaronSchulz struggles to get gnome3 working properly [17:40:44] sumanah: thank you, yeap, I've been working on the bug but I can't still figure it out [17:40:51] ^demon: need ryan to merge? [17:40:56] davidpardz: UploadWizard doesn't have that many experts who REVIEW patches. As you can see here https://bugzilla.wikimedia.org/buglist.cgi?keywords=patch%2C%20need-review%2C%20&keywords_type=allwords&list_id=106953&resolution=---&query_format=advanced&component=UploadWizard&product=MediaWiki%20extensions there are a few patches that have been awaiting review for a little while. [17:41:10] davidpardz: what's the specific problem you're having, if you can articulate it? [17:41:21] <^demon> Nikerabbit: Or any ops person. I'm going to run out and get some lunch, maybe I'll be back and it'll be successfully merged :) [17:41:43] * Nikerabbit pokes ops [17:42:32] RoanKattouw: Thanks, glad you've got this under control. Give us a shout if you need anything else from us. [17:43:35] Nikerabbit: Ryan just walked in [17:45:00] davidpardz: i am quite familiar with the code, what is the problem you are facing ? [17:45:35] drecodeam: if you have a bit of time to review these patches https://bugzilla.wikimedia.org/buglist.cgi?keywords=patch%2C%20need-review%2C%20&keywords_type=allwords&list_id=106953&resolution=---&query_format=advanced&component=UploadWizard&product=MediaWiki%20extensions and tell the authors what might need fixing, that would be great [17:45:56] drecodeam: https://www.mediawiki.org/wiki/Code_review_guide#Review_checklist is the checklist to follow [17:46:30] sumanah: one of them is mine, i will check the other one. [17:46:48] sumanah: also i have submitted 4 patches on Gerrit, can i only go about reviewing them ? [17:46:58] sumanah: I see your point, and thak you for your help. It has to do with the deeds but It seems like drecodeam can help, thanks again [17:47:08] davidpardz: glad to help [17:47:35] hi [17:47:36] drecodeam: you should ask Ryan Kaldari whether he might be able to review them (probably tomorrow) [17:48:09] sumanah: ya i would do so. [17:48:10] drecodeam: the purpose of code review is to get someone else's eyes checking your code for errors and familiarizing themselves with what you are changing [17:48:30] drecodeam: within Gerrit, when you look at your changeset, you see the "add reviewer" field? [17:48:47] drecodeam: put in Ryan Kaldari's email address, and he'll be notified by email that you want him to review it [17:49:33] sumanah: ya i will do that, although he did tell me that he would look at them as soon as he gets some time. I think he is already aware of it [17:49:33] Also, drecodeam, if you have submitted the patch you mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=32247 into Gerrit, please link to the changeset in a comment on that bug [17:50:08] sumanah: no i have not, actually i would remove that patch, because it needs much more work then i imagined when i worked on it. [17:50:10] Hi yoni_omniti ! RoanKattouw is getting things ready now for AFT5 deployment to testing. He knows about the icons and is uploading them separately. auroraeosrose told him about the SQL change to the db. So I think we are all set for the items listed on my email plan -- exept that I'm still checking to see what DarTar wanted us to do this week. Will report back on that once I locate his last email about this. [17:50:25] drecodeam: ok. you can do that by looking at the details for the patch and checking the Obsolete checkbox [17:50:41] thanks, fabriceflorin! [17:50:47] drecodeam: congratulations on learning -- seeing what you did wrong means you're a lot more skilled than you were when you wrote the patch originally :D [17:52:34] fabriceflorin, auroraeosrose, yoni_omniti, rsterbin: OK we should be live on testwiki now [17:52:43] ok [17:52:48] yoni_omniti: My pleasure. Sorry for the misunderstanding about today's deployment. I want us to get in the habit of deploying weekly now, even if it's small revisions, so we don't get further behind on our backlog. When rsterbin joins this chat, we can discuss any open issues which you guys might have, in lieu of our Skype call. [17:53:09] ok [17:53:20] fabriceflorin: i've been here; can you not see me? [17:53:25] sumanah: true that. I had to ask you one more thing. I wanted to start writing documentation for Upload Wizard now that i am getting comfortable with the code, but i am new to it? any starting points or process i should know of ? [17:53:52] drecodeam: a few things, yes [17:54:28] drecodeam: hi, the problem is with the deeds, actually I'm debugging createInputs function [17:54:28] drecodeam: first: you know that the code is commented [17:55:06] drecodeam: for now I gotta go, (school duties) hope see you around [17:55:21] davidpardz: cool, ping me if you are around [17:55:29] drecodeam: | sumanah thank you both [17:55:40] glad to help davidpardz! [17:55:54] drecodeam: the comments also lead to autogenerated documentation [17:56:10] Thanks, RoanKattouw, I am testing all this now. I believe the correct link for the feedback page is: http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow [17:56:11] davidpardz: glad to help ! [17:56:26] sumanah: ya, it does. Helped me a lot in understanding the code. [17:56:42] drecodeam: so, commenting the code in the same fashion is a fantastic way to improve documentation [17:58:28] sumanah:and then i should submit the changes as patches ? [17:58:54] rsterbin: Reha, I'm sorry, I saw you were there, but didn't hear from you, so I thought you were away. Any questions on your end? [17:59:26] drecodeam: sure [17:59:30] sorry, phone call, back in a moment [17:59:42] yoni_omniti rsterbin auroraeosrose : The new features on testing seem to be working for me on Safari. Do they work for you too? [18:00:29] so far so good... [18:01:29] I tested the feedback page both in oversight mode and in logged out mode, and they application works as intended. The permalink is visible to oversighters, and the Go back button from permalink is corectly redirecting to the whole feedback page, for both oversighters and logged-out users. [18:04:18] looks good to me [18:07:34] Ryan_Lane: are you aware of https://gerrit.wikimedia.org/r/#change,4792 yet? [18:07:37] fabriceflorin: dario knows the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=35590 isn't going up in this release, right? [18:07:45] unless someone has told me, no [18:09:11] Thanks, auroraeosrose -- yoni_omniti and rsterbin, is there any testing issues on your end? Or are we ready to ask RoanKattouw to deploy to production? [18:09:32] i don't see any [18:10:18] Hi, rsterbin, what is causing the hold back of DarTar's ticket? Is it that we didn't have time to test it on prototype? or that RoanKattouw hasn't reviewed the code yet? Or both? https://bugzilla.wikimedia.org/show_bug.cgi?id=35590 [18:10:37] Nikerabbit: I'm confused as to how this helps anything [18:10:51] it removes two log messages and adds an email address to the bot name? [18:10:57] isn't this just going to break? [18:11:13]