[12:46:01] hi JeroenDeDauw [12:46:47] i was interested in working on UploadWizard for my GSoC project, i am having some trouble in running the campaigns feature, your name was there in the developers in the comment [12:46:51] can you help me in this [12:46:52] ?? [12:51:09] drecodeam: sure [12:51:18] drecodeam: what is your problem? :) [12:52:50] it shows a Database error [12:53:06] "SpecialUploadCampaigns::displayUploadCamaigns". Database returned error "1146: Table 'mwtrunkdev.uw_campaigns' doesn't exist (localhost)" [13:19:15] drecodeam: you need to run the database update script [13:19:18] of mediawiki [13:19:37] JeroenDeDauw: ohh, ok i would do that [13:26:27] drecodeam: so what do you want to do with the UW? :) [13:26:59] JeroenDeDauw: i was discussing this with kaldari few days back [13:27:11] i wanted to implement flickr and geolocation in it [13:27:41] but before that, there are some issues with the current version, and a lot of open bugs, i also want to tackle as many of them as i can [13:28:44] also when i was talking to kaldari, i discussed implementing drag drop feature of HTML5. But that i am almost done with, in fact i am committing that change only right now [13:31:54] JeroenDeDauw: he had asked me to look into campaigns feature also, but i could not make it work. I asked about it yesterday also, but no one had an idea about it [13:39:08] drecodeam: right, not many open bugs on the campaigns stuff AFAIK though [13:39:32] JeroenDeDauw: ya i could not find any [13:41:55] i guess i would be working on the UplaodWizard only. I will try running the campaigns once i am done with the commit [13:42:24] would see if i can find something. Also what do you think about the project ? [13:43:33] is there anything else that needs more attention in UploadWizard, i have found some minor things in the design specification and some problems people are facing as given in the village pump [13:43:53] but those are minor issues and most of them are covered through the open bugs [15:22:29] Reedy: I noticed you don't have a global user page or something like that, I imagine they'll revert you since there was no edit summary. Is there a template for this kind of issue we can stamp on the talk page? [15:23:08] I've never been questioned... [15:23:22] You can leave an english talk page message [15:23:26] most wikis have people that read en [15:25:18] ok [15:26:47] I suspect I should create some new wikis later on [15:27:24] ? [15:28:55] I think there are 4 or 5 outstanding requests [15:30:56] Reedy: oh, okay [15:31:05] it seems they also overwrote the Privacy policy link [15:31:09] Not sure about that [15:31:33] links to a local page, last updated in 2008 [15:36:51] Reedy: Any suggestion for talk page where I direct them for discussion? [15:37:00] thinking some talk page on mneta [15:37:01] meta* [15:37:15] Yeah, or IRC I guess [15:41:15] Reedy: done, see si:MediaWiki_talk:Common.js [15:58:05] Reedy: took a while to flush from all cached, but looks like this one script also made the other 3 connections to google-ajax and google-analytics and that other domain [15:58:05] so Solved :) [16:50:45] hey alolita [16:51:01] sumana: hey! [16:51:47] alolita: just sent you a note about http://opensourcebridge.org/events/2012/proposals :-) [17:12:30] Hello! [17:15:21] huh [17:15:35] hexmode: yeah, it looks like rmoen, Trevor, and Brion aren't here [17:15:39] oh, right channel. [17:15:39] hexmode: :-/ [17:15:44] No prob hexmode [17:16:03] I'll catch up with trevor when I see him... unless he is out? [17:16:06] * hexmode checks [17:16:23] I'm thinking, hexmode, https://www.mediawiki.org/wiki/Wikimedia_engineering_20%25_policy#Status -- the Gerrit merge queue is the place for them to concentrate 20% time, right? [17:16:30] hexmode: I think he's back in, recovered [17:17:02] I think you're right about merge queue [17:17:22] Trevor was working on half (1) of the blocking bugs [17:17:33] hexmode: there are changesets in there from MrBlueSky, saper, drecodeam, Sid, Jarry, etc [17:18:09] sumanah: link for queue? [17:18:29] hexmode: https://gerrit.wikimedia.org/r/#q,status:open,n,z [17:18:58] tyvm [17:29:24] siebrand: ping. [17:37:12] sumanah: Are you able to add me to the 'mediawiki' group on gerrit so that I can review frontend stuff? [17:37:23] (and other stuff, just like I could with svn) [17:37:36] Krinkle: you can file a request in https://www.mediawiki.org/wiki/Project:Gerrit_project_ownership [17:37:46] Krinkle: the request has to go round to the other Gerrit project owners [17:37:54] Krinkle: trying to treat everyone equally here [17:38:04] ok [17:38:07] thanks Krenair [17:38:10] I mean, thanks Krinkle [17:49:04] sumanah: done :), also added a /New section/ tab and edit notice :) [17:49:12] thanks Krenair [17:49:14] aiee [17:49:15] thanks Krinkle [17:49:23] I get that a lot since Krenair is on IRC [17:49:26] hehe [17:49:44] I used to own the K*-Kr namespace [17:49:46] Auto-complete :D [17:49:53] Kri* even [17:50:03] You can press tab twice in XChat to get the second name [17:50:12] Same for Colloquy [17:50:22] but power users don't look where they type :P [17:50:22] Tab completion in most IRC clients is weird [17:50:26] thanks for moving that, Krinkle [17:50:27] Mine follows the bash convention [17:50:40] https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership makes sense [17:51:00] as in, it refuses to autocomplete an ambiguous match [17:51:09] I didn't move..? Or I did, but that was a few days ago [17:51:25] I'm a fool, never mind [17:51:38] https://www.mediawiki.org/w/index.php?title=Git/Gerrit_project_ownership&action=edit§ion=new [17:51:47] I just hit enter a fraction of a second before I realize "wrong name!" otherwise I'd hit tab a second time [17:52:17] Krinkle: "Extension repository - wether" should be "whether" and there's an extra period at the end [17:52:58] RoanKattouw: aren't you in holidays this week ? :D [17:53:02] I make that mistake all the time, I know the difference between whether and weather, but I typo it half-ways a lot [17:53:10] hashar: I have today and Friday off [17:53:40] sumanah: thé, fixed [17:53:49] RoanKattouw: I just love how your corrected my typos in git-review repo by using references to my native language :-D [17:54:01] hehe [17:54:11] I don't know all that much about French but I know enough [17:54:14] whether the weather is withered..... [17:54:34] haha [17:54:36] RoanKattouw: I should really have used a spell checker before committing that fix :/ [17:54:40] what about the one described as "DELETE - CHAD CAN'T SPELL" [17:54:46] xD [17:54:49] :) [17:55:08] IIRC at least 90% of that would've gotten through [17:55:23] There's lots of ways you can make typos that are still valid words [17:55:34] Like the weather/whether thing above [17:55:48] RoanKattouw: is there a command to pull for all extensions? [17:56:00] * hashar takes english lessons from a dutch teacher [17:56:06] (and google) [17:56:10] AaronSchulz: Ask ^demon [17:56:20] Oh, did you do a submodule checkout? [17:56:28] Then I think it's git submodule update or something [17:56:51] AaronSchulz: Jarry1250 submitted a change about the SpamBlacklist extension. I have added you as a co-reviewer [17:56:54] yeah, that seems to do nothing [17:57:09] * AaronSchulz was messing around with stackoverflow suggestions [17:57:54] I'm resorting to cross all channel spam here, sorry about that, but I'm hitting dead ends everywhere. I think 210.55.215.173 is a good candidate to have its XFF headers trusted. But the XFF mailinglist seems abandoned, the XFF wikiproject on meta seems dead, the oldest bugzilla I can find on adding something to the trusted list is from 2009, and I'm out of doors to knock on [17:58:19] anyone knows where I can take this? [17:58:23] FooBarMartijn: I recommend pinging Tim when it's not 5am his time [17:58:28] AaronSchulz: did you see Brion's email about that? [17:58:43] hashar: um, going to pm you [17:58:50] hmm [17:58:54] can these things just be documented rather than based on random emails? [17:59:06] * AaronSchulz tries to reset some stuff [17:59:12] RoanKattouw, thanks [17:59:22] AaronSchulz: go ahead and add some documentation, I cannot keep it up all on my onw [17:59:24] own* [18:00:02] any progress on git issues? [18:00:58] Nikerabbit: we're adding more issues and tracking them in Bugzilla at https://bugzilla.wikimedia.org/showdependencytree.cgi?id=22596&hide_resolved=1 [18:01:03] * AaronSchulz likes how we got rid of 'phase3' en passant [18:01:08] Nikerabbit: hashar's priority right now is https://bugzilla.wikimedia.org/show_bug.cgi?id=35469 [18:01:37] Nikerabbit: and hexmode is setting up a git/gerrit bug triage for this Thursday [18:01:58] sumanah: too bad, I'm already traveling on thursday [18:02:02] Hey all! :-) [18:02:06] hi tewwy [18:02:25] Nikerabbit: then perhaps you can send someone from i18n on your behalf, alolita or siebrand [18:02:35] Time for the weekly features engineering meeting: http://etherpad.wikimedia.org/FeaturesTeam2012-W13 [18:02:46] Let's try to make this quick. You snooze, you lose. [18:02:53] sumanah: it's me who has done almost all work related to this [18:03:10] Nikerabbit: let's shift to #mediawiki to avoid conflicting with their meeting [18:03:32] * RoanKattouw hides behind his day off [18:04:15] Okay first things first. Some discussion on my end. [18:04:32] OH NO [18:04:37] please not the l10nupdate!!!!! [18:04:44] that sounds like the movie Scream 10 to me [18:04:47] :-D [18:04:50] The first thing is that engineering goals for next year's budget is almost due. [18:04:52] http://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals [18:05:15] RoanKattouw: are you the author of l10nupdate ? If so do you have any wiki doc about it ? [18:05:27] So be sure to check that and fix anything on your project that you think is wrong. If you don't want to make an edit, ask me to via e-mail or something. [18:05:43] hashar: The CLI script or the MW extension? What's wrong with it? [18:06:01] Second thing: I want to minimize the impact of this meeting. It hogs too many engineering resources and besides, attendance sucks. [18:06:02] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=35469 looks like I need to migrate LocalisationUpdate to use git :-D [18:06:11] RoanKattouw: which is great, this way I will learn about l10nupdate [18:06:13] hashar: There's a change lined up in puppet [18:06:41] hashar: Mark -1ed it pending the git migration but obviously the migration has happened now. Search for is:open owner:catrope project:operations/puppet [18:07:49] Please check the "=== Meeting restructure ===" section http://etherpad.wikimedia.org/FeaturesTeam2012-W13 and send me any input on how 1) you want your project to provide status and me to be updated; and 2) handle non-project stuff and cross-functional crap. [18:08:05] Maybe we can get rid of this meeting entirely if we have an adequate substitute in place. [18:08:48] I like the daily standup idea [18:09:01] I think we should start doing those once Inez and Christian have moved [18:09:26] If Trevor has been or will be successful in wheeling in a whiteboard, we can summarize what we said on that [18:09:50] Okay, that sound good. as long as it's not at 10:30 during my EPM, I can attend one a week, in place of VE being at the features meeting. [18:09:52] And we can get someone to update you, or you can attend once per week, or you can just wander over, read the whiteboard, and talk to someone [18:10:16] Sounds good. Also consider how you want to handle status updates on the project wiki [18:10:40] I can turn the features meetings into an office hours if there is any other non-project stuff. Yeah! [18:10:47] Morning TrevorParscal , you should read some of the backscroll here (will send in gchat) [18:10:55] He's on the phone right now. [18:10:56] Hmm, that sounds like a good idea [18:11:27] Any other updates from VE? (Probably not, Trevor is on the phone)>. Rob? [18:11:42] i'm here [18:11:43] Nothing except what I wrote in the Etherpad [18:11:47] (sorry to have disturbed during what is apparently a feature team meeting :D ) [18:11:49] my update is, I'm back [18:11:55] Also, general notice: I have taken today, Friday and next Tuesday off [18:11:58] hashar: It's fine. [18:12:14] I'm also off on Friday, signing papers to buy a house [18:12:21] I should have a new visa on Friday, and I'll be back in the office on Wednesday (in 8 days) [18:12:32] TrevorParscal: Yes, I left :under heavy sedation" in your last week section http://etherpad.wikimedia.org/FeaturesTeam2012-W13 [18:12:46] tewwy: seems accurate [18:13:09] Yes, I marked you off for the 30th. :-) [18:13:11] * TrevorParscal is still coming out of the fog, but feeling sharper now [18:13:11] Congrats on the house! [18:13:17] thanks [18:14:20] Okay let's move on to Editor Engagement (ACW and PT) [18:14:30] TrevorParscal: did you see my email about that ie/rtl bug? [18:14:59] hexmode: looking [18:15:40] * TrevorParscal has no idea what hexmode is talking about yet [18:15:48] TrevorParscal: 1s [18:16:12] rain drift? Any updates not on the ether pad? http://etherpad.wikimedia.org/FeaturesTeam2012-W13 [18:16:17] raindrift [18:16:18] New review: Hashar; "Thanks Diederick for the patch. I am not sure when I am going to integrate it though. Let s keep th..." [integration/jenkins] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/2289 [18:17:29] bsitu? [18:18:04] Okay, I'll talk things over with Ian today. [18:18:15] hi tewwy, sorry, I forgot to update the pad [18:18:27] You still have some time. :-) [18:18:42] BTW, is Timo online? [18:19:06] Krinkle is away apparently [18:19:14] I'm here [18:19:23] RoanKattouw: Tell Timo that his name is in multiple places, he can put the RL2 updates in its section and platform updates in the misc section at the bottom [18:19:37] Wait, there's an RL2 section? [18:19:39] * RoanKattouw missed that [18:19:53] No, there's not [18:19:57] Hm.. we used to have only 1 section per person, and the per-project updates are on-wiki on the corresponding mw:Project_name/status pages [18:20:31] (FeaturesTeam-Preload is still structured that way) [18:20:49] Yes, we explicitly moved away from that a while ago [18:20:54] We're now back to a per-project structure [18:21:07] Yes, I changed it, as part of my massive quest to get rid of this meeting [18:21:25] tewwy: That involves not using etherpad anymore? (I'd support that) [18:21:28] Krinkle: I'll update Preload after this meeting to reflect the new structure [18:21:49] Krinkle: Good idea, I'll see what I can do about moving from Etherpad to something else. [18:22:01] or maybe having Etherpad be option with something else [18:22:11] I mean, updating on the project status pages directly and any person-to-person communication on IRC [18:22:11] optional [18:22:32] but that's just a rough untoughtthrough idea :D [18:22:55] Krinkle: Well think about it and get back to me. Your suggestion makes sense and it's one of my possibilities. [18:22:57] tewwy: I got your mail(s) yesterday and from others related to Berlin, going through them in a moment and will answer per mail [18:23:14] Doesn't make sense for me to be updating project status… it's like a bad telephone game. [18:23:23] Krinkle: No matters. :-) [18:24:59] The upshot is I want to get rid of this meeting as a requirement down the road. So I'm looking into more sensible ways to do what this meeting does: updates status wiki, address cross functional/platform stuff, and still allow some radiation of information. Without the crap of having to have you guys waste your time updating me. [18:25:28] At the top, of the ether I have suggestions. Choose some and propose your own and I'll implement them. [18:25:39] tewwy: fwiw, for teams that are using Mingle, we may be able to extract a lot of useful info from the mingle API [18:26:09] raindrift: THat's a great idea. It'd be pretty cool if we can update the status directly from Mingle for them. [18:26:23] tewwy: … we can dream. :) [18:27:05] Yeah, worst case scenario, just create a view that has the last week's finished cards. and just hand copy that to the project wiki [18:27:49] On to Multimedia: It's blocked on commons.beta being way to slow. They can't even figure if they can run the test plan because all the javascripts hang at random moments. [18:28:26] Since RyanL is on vacation, I'll ping some labs people via e-mail to see what I can do. (Roan, I'm putting you on the cc: just in case it's not actually a config issue). [18:28:39] tewwy: What is ACW and PT ? [18:28:45] That's probably not a labs-specific issue [18:28:54] article creation wizard, page triage [18:28:54] I mean... let me rephrase [18:29:02] It's probably not something where Ryan can be of much help [18:29:05] Ah, I see [18:30:05] Hmm, Brett and Erik seem to think that beta simply doesn't have enough resources [18:30:30] That's possible [18:30:50] beta is slow, other labs instances are not. but beta is a very complex multi instance setup [18:30:52] You think otherwise? If so, then can you unblock Chris McMahon? [18:31:07] Unblock Chris? [18:31:11] What are you talking about? [18:31:27] Chris is trying to see if the test plan can be run on commons.beta [18:31:48] Right now he can't even upload a video because resource loader times out (seemingly randomly) [18:32:06] I wonder if they have caching set up right [18:32:11] But hmm, that's strange [18:32:21] You can go to any page http://commons.wikimedia.beta.wmflabs.org/ and open firebug and see it. [18:33:01] There are also some plain .png requests timing out [18:33:05] Not sure it's necessarily RL-related [18:33:37] I don't think it is. Brett seems to think it is because too many instances are being run on too lithe physical hardware [18:33:47] little [18:34:08] It's not always RL that times out, sometimes it's some extension [18:34:24] http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Special:BannerController&cache=/cn.js&303-4 This timed out on my talk page just now [18:34:44] * RoanKattouw casually wonders who Brett is [18:35:06] lol [18:35:08] good question [18:35:22] I meant Ben [18:35:23] haha [18:35:23] It's definitely true that we have too many instances per node [18:35:37] My brain crossed a wire somewhere [18:37:02] So after this meeting, I'll send an e-mail to Andrew and Petr about this, but I'll have you on just in case. [18:37:06] on the cc: [18:37:58] you = RoanKattouw. Just run as a point of contact on the off chance it's not a beta is overloaded thing [18:38:35] OK [18:38:47] I would recommend that anyone watch 'top' on beta for a while before trying to rope me in though [18:38:49] If we can get TMH to the point where ChrisM can actually run the test plan on it (when he gets unstick), then we'll have some movement. Yeah! [18:39:25] I don't have access to beta. But if top is high, that's probably a labs problem right? [18:39:40] Yes, then it's probably a labs capacity problem [18:39:45] Or some problem in the beta setup [18:39:48] Or something else [18:40:04] Okay I want to zip through the rest of the meeting. We're way over. [18:40:19] Education: JeroenDeDauw. Updates? [18:41:09] tewwy: see the stuff with strike-through here: http://education.wmflabs.org/wiki/Roadmap [18:41:15] That's what I did last week [18:41:22] Plus asting a lot of time on git+gerrit [18:41:25] got to run now [18:42:02] srry, dinners ready, I'll brb in ~ 40 minutes [18:42:06] Now Fundraising? [18:43:01] k4-713 and jpostlethwaite I noticed you both updated the etherpad, so if there isn't anything else you'd like to add then the meeting is over. Hurrah! [18:43:14] Hey, awesome. Yeah, I got all mine in there. [18:43:25] i am covered in the pad [18:43:28] Nothing else to report. :) [18:43:30] thanks :) [18:43:50] Okay I'm copying this stuff over, updating the preload, and be sure to look into ideas on making this meeting take less load on yourselves. [18:54:10] K4-713 [18:54:20] is it better to have watchdog [18:54:32] do 'rg' or recurring_globalcollect [18:54:34] crg [18:54:42] will be changed [18:54:45] to rg [18:54:50] or the long version [18:54:52] Yeah, we need to know what module it's having issues with. [18:55:04] Oh, I see, for all of them. [18:55:09] right [18:55:14] You can go ahead and use the long module name to avoid confusion. [18:55:18] ok [18:55:35] Drush alias might not be immediately clear to people looking at the drupal logs anyway. [18:55:41] Might be end-user types. [18:55:45] agreed [18:56:06] Next question: Is your local whitescreening now too? [18:56:26] i have not updated today [18:56:30] will check [18:56:52] Ah, I see the issue. [18:57:12] good [18:57:18] because mine is fine [18:57:25] That's peculiar. [18:57:30] It's in the code. [18:59:26] Oh, I see. You must have uninstalled the old modules before you updated. [19:03:45] oh right K4-713 [19:03:59] i had a to move stuff around [19:04:42] All those "require once"s should probably be wrapped in something that checks to see if it can find the files first. I'll take care of it. [19:09:14] Reedy: JFYI, I reopened ruwiki namespace bug because you protected talk namespace as well (I am not sure you follow that bug since you are not cc'd) [19:09:30] vvv: you could've just asked me to remove that ;) [19:09:57] Reedy: I thought you did not like on-IRC shell requests [19:10:13] Personally, I don't really care [19:10:21] Bugs give a paper trail [19:13:27] Reedy: thanks [20:53:23] * jorm invokes Raindrift [20:53:39] who is not in the room. [20:53:54] oh, i'm wrong. wrong list. [20:55:12] hey [20:55:20] jorm: i'm here… was just watching another window. [20:55:28] emailed. [20:55:31] k. [20:55:33] just do you want assets first, or mocks? [20:56:10] probably mocks… assets are easy to fill in, but if the overall design changes i'll want to know that first. [20:56:56] here's where i'm at now, fwiw: https://skitch.com/raindrift/8pwnc/page-triage-wikidev [20:57:08] currently working on date formatting. [20:58:12] the design is changing with the filter mechanisms and the footer. [20:58:29] heh. good thing i haven't implemented those yet. :) [20:58:34] okay. we've got some breathing room, then. [20:58:43] build in the space for them, and how they work? i'm just goofing with controls. [20:58:52] i've asked andrew to work on filtering, so make sure to loop him in on the new designs. [20:58:57] the current mock has "primary" filter controls visible, with advanced hidden. [20:59:05] that makes sense. [20:59:18] we're changing it so that it just shows you what filters you have active, and putting all filters in a dialog. [20:59:27] note, also, that since this is all js, we can do some of the filtering and sorting client-side, rather than pulling in new lists from the api. it's much faster. [20:59:47] (well, faster assuming we have the data in the client) [21:00:18] i'm not talking implementation, just interaction. [21:02:05] heh. sounds good. [21:28:01] I just tried to push my first commit to gerrit, but it done exploded :( [21:28:04] remote: ERROR: missing Change-Id in commit message [21:28:15] ! [remote rejected] HEAD -> refs/for/master/master (missing Change-Id in commit message) [21:28:40] what's that mean? [21:30:08] i can't even check out, so you're head and shoulders above me. [21:30:30] yeehaw! [21:36:46] apparently I'm supposed to do some kind of tagging and cherry-picking or something [21:37:30] are you using git review? [21:37:34] yeah [21:37:36] and/or should you be? [21:37:44] did you do git-review -s already? [21:37:47] yeah [21:38:02] But you did that after committing the patch that you're now trying to submit, right? [21:38:09] yes! [21:38:17] that's probably my problem [21:38:21] If you do git commit --amend then I think it'll insert the chance id. [21:38:28] Should be obvious. [21:38:32] *change [21:41:39] oh, I think that worked! [21:43:02] andrewbogott: Thanks! [21:43:11] np [21:43:42] this is almost fun [21:49:27] kaldari: be warned, fun is not allowed in the collab space during business hours, make sure you are at your desk [21:49:48] I'm actually sick at home :) [21:49:58] ah, well fun is allowed at home [21:50:03] nope :) [21:50:11] that's why regular wfh days are so hard to get [21:55:34] hi kaldari [21:56:26] hello [21:57:54] i saw the UplaodWizard campaigns feature... it does not have much of work in it... i talked to Jeroen de Dauw about it too [21:58:07] i also submitted a patch for drag and drop feature [21:58:13] today itself [21:58:54] https://gerrit.wikimedia.org/r/#change,3808 [21:59:55] I forget, did you say you are going to work on UploadWizard for GSOC or pass it along to someone else? [22:00:10] no i am going to work on it [22:00:26] awesome [22:00:50] I'll try to take a look at your patch if I have time this week [22:00:58] i have already been going through the code, and i am gonna work on integrating flickr and geolocation in it. [22:01:16] what's the bug # that the patch is attached to? [22:02:31] kaldari: it is not attached to any bug, i had discussed with you the other day of implementing it [22:03:31] How to change destination of Home Wiki fron one lnaguage to another language wikipedia? [22:06:21] drecodeam: Where did you submit the patch? [22:08:06] https://gerrit.wikimedia.org/r/#change,3808 [22:08:19] i just got a comment on it, looking into it [22:16:54] * drecodeam taking a coffee break [22:49:52] New patchset: Diederik; "Replaced all strtok with strchr." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/3222 [22:57:49] one more git question: So should I do a 'git rebase' after each 'git review'? [22:58:46] git review does rebase unless you use --no-rebase [22:58:48] New patchset: Diederik; "Removed exotic for/loop Replaced all strtok with strchr." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/3222 [22:59:11] so I would assume that there would be no point in doing a rebase after git review [22:59:22] ah ok [23:00:36] how do I get 'git review' to only submit the commits since my last 'git review' (instead of all of them)? [23:03:01] if the parent commits are already in gerrit then they won't be added again [23:03:04] git review lies to you about that [23:03:30] but the rebase that git review does could change the parent commits and make them show up as separate changesets [23:03:55] so I reckon "git review --no-rebase" should do what you want [23:04:13] I haven't tried it yet myself, I'll be interested to know if it works [23:04:13] ah good to know [23:04:21] the feedback from git review was confusing [23:09:19] erg, it made my 2nd commit dependent on the 1st commit, although they have nothing to do with each other [23:12:49] right, well you should have used different branches [23:13:19] https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch [23:13:30] see how it says "first create a branch"? [23:13:38] you do that separately for each independent set of changes [23:13:58] ah [23:29:00] is the wmf group in gerrit being used? [23:29:15] I notice I'm not in it, and that seems like an error [23:36:48] poor Trevor, left out in the cold [23:42:11] it's an LDAP group, I think you have to ask Ryan about that [23:43:17] either that or you can make the LDIF yourself and I can run it for you [23:51:32] Hey. Can anyone please tell me how you can delete your account and everything that has to do with it on wikipedia, wikimedia and so on, so that you can start all over again? [23:54:28] Anyone? I can't find any option for it. [23:55:08] If you want to start all over again, why don't you just create a new account? [23:56:43] There's also http://en.wikipedia.org/wiki/Wikipedia:RTV#How_to_request_a_courtesy_vanishing [23:57:44] Sure, just wanted to delete this one first, but don't know how yet.. Just wanna start all over, and not with the same nickname. [23:57:59]