[00:03:43] Ooooh [00:03:44] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [00:03:54] 14 Feb 2012 - 29 Feb 2012 [00:04:11] IE6 is 1.53% of all requests [00:05:26] is the magic number 15? [00:05:31] *1% [00:36:27] Hello [04:14:52] Reedy: It's .01%, I thought. [04:15:59] .1$ [04:16:02] .1% [10:20:23] @recentchanges-on [10:20:23] Feed is enabled [10:22:51] @RC+ mediawiki OAuth [10:22:52] Inserted new item to feed of changes [10:34:32] Change on 12mediawiki a page OAuth was modified, changed by 90.183.23.27 link https://www.mediawiki.org/w/index.php?diff=510710 edit summary: /* Relevant bugs */ ++ [10:35:13] Change on 12mediawiki a page OAuth was modified, changed by 90.183.23.27 link https://www.mediawiki.org/w/index.php?diff=510711 edit summary: /* Relevant bugs */ fix [10:41:52] hm [10:42:03] @RC+ mediawiki WMF_Projects* [10:42:04] Inserted new item to feed of changes [13:50:51] 10min to 1.19 blocker triage [13:52:19] "1.19 tarball blocker" [14:01:06] anyone here for the triage? [14:01:58] I kinda am, but I'm not sure what the issue even is [14:02:20] JRWR: k, 1min [14:08:07] JRWR: http://etherpad.wikimedia.org/119triage [14:08:21] http://etherpad.wikimedia.org/119triage [14:08:31] anyone else? [14:11:28] * saper sits quietly. [14:13:27] saper: yeah, If it is just you two, then I'm not sure how this is gonna go [14:13:32] hi [14:13:54] petan|wk: hey, stick around, I have questions for you after [14:14:26] fine, 4 people, I say that is a quorum ;) [14:14:56] ok [14:15:01] how is https://bugzilla.wikimedia.org/show_bug.cgi?id=34889 possible [14:15:09] I mean was in normalized ever before [14:15:17] * hexmode looks [14:15:51] did someone rewrite it? [14:16:16] oh, yes it did [14:16:23] petan|wk: micheal m. seems to think it was before... I'm kind of ignorant. [14:16:24] we should create a 1.18 wiki on labs [14:16:33] yes it was [14:16:40] petan|wk: exactly what I wanted to talk to you about ;) [14:16:43] it's hard to check though [14:16:47] ah [14:16:54] it's no problem [14:16:57] werdna: hi [14:17:01] I think [14:17:09] petan|wk: I used hetdeploy to check out 1.17 and 1.18 [14:17:11] but I need to understand this het - stuff :p [14:17:34] hexmode: we need to update the db of wikis and recompile it [14:17:41] no idea how [14:18:00] but yes, getting regressions checked would be [14:18:03] 1s [14:18:04] there is a file to specify which version you use on each wiki in db [14:18:17] hexmode: what's hetdeploy? [14:18:19] petan|wk: yes, file is updated [14:18:34] saper: that's some uber thing no one really understand :) [14:18:42] saper: a way to run different versions of mw on one installation [14:18:56] and what petan said [14:18:58] ;) [14:19:04] hexmode: like, shared parts of LocalSettings.php on one database? [14:19:09] not really [14:19:11] that's wiki farm [14:19:15] we understand that [14:19:16] or a mega-express-installer [14:19:35] it's way to configure wiki farm to use different version for certain db [14:19:55] so if you have a farm of 5 wikis, you can specify a version of mw, you want to use for each of them [14:20:39] while regular wiki farm, uses one mediawiki folder which contains php code, het deploy enables you to have multiple and assign version to various db's [14:21:09] in wiki farm, you use same LocalSettings.php for all wikis, only difference is in db's [14:21:37] saper: make account on labs and I show you how it work [14:21:46] petan|wk: I have "saper" on labs wiki [14:21:54] labsconsole.wikimedia.org [14:22:06] and someone broke my gerrit access, but there is no shell [14:22:10] ah [14:22:17] 1s while I set up a 1.18 wiki -- should have done this sooner :( [14:22:18] petan|wk: one thing I've asked hashar for help with is to make deploying to labs cluster a regular event by way of Jenkins [14:22:27] petan|wk: I have a running MediaWiki 1.7.3 instance on PostgreSQL on my box ;-) [14:22:57] chrismcmahon: hello :-) [14:23:01] saper: ok, that is good to test heh [14:23:11] petan|wk: is there are a fast database-populating script, like some articles, some recentchanges, some watchlist, blocks etc.? [14:23:20] chrismcmahon: with the git migration, I will not be able to handle that anytime soon :-( [14:23:24] chrismcmahon: I don't know how jenkins work, but I am willing to help [14:23:32] petan|wk: what do I need more from labs? [14:23:45] saper: yes [14:23:58] there is addwiki script which populate data [14:24:02] petan|wk: it would be useful to build some hetdeploy options into Jenkins builds I think [14:24:29] I think werdna is likely better person to ask :) [14:24:37] because he understand het best [14:24:41] werdna: are you [14:24:44] good [14:25:58] hashar: can you check gerrit permissions for test/mediawiki/extensions/examples.git for mere mortals like myself or beau? [14:26:27] hexmode: link me to 1.18 wiki you made [14:26:51] petan|wk: 1s has turned into 1m [14:28:54] saper: any registered user can push a ref there [14:29:15] saper: http://imgur.com/bQJgp [14:29:34] got it [14:29:44] not really [14:29:49] http://ee_oldprototypewiki.wikipedia.beta.wmflabs.org/ [14:29:50] ? [14:29:51] saper: refs/for/refs/* is for gerrit review. Push and Push Merge Commit probably mean you can do what ever you want [14:30:12] hashar: getting permission denied since some time (it used to work) [14:30:52] hexmode: disable global blocking before you run addwiki [14:30:57] or database will be fucked [14:31:04] saper: would need the exact command being used as well as a paste of the full message :-] [14:31:09] it's a bug [14:31:32] hexmode: if u want I can set up that wiki [14:31:51] ive got some full XML dumps if you want to use them [14:31:59] only about 1k pages [14:32:07] JRWR: for test? [14:32:11] yep [14:32:18] its from my other project [14:32:18] hm... we could use it [14:32:31] http://pcgamingwiki.com/dumps/ [14:32:36] in fact it would be easier to switch come existing wiki temporary to 1.18 [14:32:43] like simple.wikipedia [14:32:44] on labs [14:32:47] it already has db [14:32:56] hashar: http://tools.wikimedia.pl/~saper/fail/gerrit-fail-01 [14:34:47] petan|wk: http://winkyfrown.com/wiki118/index.php/Main_Page [14:35:06] but please do it on labs :) [14:35:08] ok [14:35:19] hexmode: what if we switch existing wiki [14:35:42] or you want to create a new db for it [14:36:00] petan|wk: talk to chrismcmahon [14:36:10] I mean existing wiki on labs [14:36:18] like simple.wikipedia.beta [14:36:21] to 1.18 [14:36:28] petan|wk: sounds fine if it works [14:36:40] let me check [14:37:38] hexmode: another one, this time "pure" git, no git-review http://tools.wikimedia.pl/~saper/fail/gerrit-fail-02 [14:38:00] s/hexmode/hashar/ [14:38:16] saper: I have no idea how all those references works [14:38:17] saper: 'bout to say [14:38:25] git-review push to refs/for/master/master [14:38:28] hashar: I figured them out [14:38:33] and you are not allowed since refs/for/refs/* [14:38:37] is allowed [14:38:56] refs/for/master you mean? [14:39:13] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version [14:39:15] problem [14:39:17] well it pushes to refs/for/master/master [14:39:22] Failed opening required 'geshi/geshi.php' [14:39:23] but we only allow you in refs/for/refs/* [14:39:34] refs/for/refs/* ???? [14:39:36] hexmode: there are some extensions enabled which aren't in 1.18 [14:39:46] I'm working on reproducing http://bugzilla.wikimedia.org/31755 [Regression] Styling in headers breaks sortable tables [14:39:47] I think we could copy them [14:39:57] gerrit docs say it's refs/for/ [14:40:05] or disable [14:40:35] ! [remote rejected] HEAD -> refs/for/refs/master (branch refs/master not found) [14:41:44] saper: try again :) [14:43:06] ! [remote rejected] HEAD -> refs/for/master (prohibited by Gerrit) [14:43:21] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version [14:43:24] does this thing have ... logs? [14:43:27] hexmode: ^ [14:43:34] saper: where [14:43:51] ok, en.wikipedia is 1.18 [14:43:54] petan|wk: gerrit [14:44:01] saper: yes [14:44:06] ah [14:44:21] \o/ [14:44:28] petan|wk: who can see them? :) maybe there lies secret of my $fail$ [14:44:38] saper: I think you need to ask ops [14:44:51] saper: Ryan and Roan are good with it, afaik [14:44:53] saper: sorry I have no idea what might be wrong :-/ [14:45:12] maybe ^demon knows more, he's git master [14:46:01] it's too early 7:45 am in SF [14:46:09] yes [14:46:27] ^demon is on vacation, he will be back tuesday [14:46:44] I am is back up but I am busy with the git migration :-/ [14:46:49] compare: http://winkyfrown.com/wiki118/index.php/Bug_31755 [14:46:54] http://winkyfrown.com/wiki/index.php/Bug_31755 [14:47:11] ^demon is closer to DC than SF [14:47:16] hashar: I wanted to check out the possibility to use refs/change/* branches would be cool for colab on small projects [14:47:18] other coast, same time as me [14:47:39] right, he is in Va. or something [14:48:47] hashar: isn't having commit access working for gerrit an essential part of git migration? :) [14:48:49] Reedy: http://winkyfrown.com/wiki/index.php/Bug_31755 vs http://winkyfrown.com/wiki118/index.php/Bug_31755 [14:49:35] saper: yup [14:49:44] saper: that is just the test repos which is broken somehow [14:49:57] saper: the new repo does not even have a matrix right for now :-]] [14:51:11] hashar: ah so I am not the only one fixing their git problems with rm -rf && git clone ... ? [14:51:18] :D [14:51:20] saper: no [14:51:47] in fact I usually have like 3 copies of repository as backup [14:51:52] so I don't need to wait for clone [14:52:16] petan|wk: recently learned to nuke my "master" by checking out older commit, nuking master branch with -D and making new master, so other commits disappear from view [14:52:26] heh [14:52:42] but they will haunt me there one day I'm sure [14:54:13] rm -rf repo should not be needed really [14:56:30] you are missing skills then, I can make it needed :) [14:57:15] hashar: there is an error in this http://imgur.com/bQJgp -> refs/for/refs/* should be refs/for/*, can you fix it? [14:57:27] saper: nop sorry [14:57:33] saper: you will have to wait for someone sosrry [14:57:52] I have changed that and it did not fix the issue [14:57:55] so that must be something else [14:58:12] hashar: what's the current value? [14:58:59] refs/for/refs/* [15:01:17] got some good regressions going... filling out the etherpad with urls [15:01:26] hashar: so it's impossible to change that to refs/for/* ? [15:01:42] I did and you were still rejected [15:01:53] so it is something else and I don't have the time to investigate that any further sorry [15:02:01] try with the test/mediawiki/core repository maybe [15:02:04] https://etherpad.wikimedia.org/119triage [15:24:40] MaxSem: is http://bugzilla.wikimedia.org/35051 fixed? [15:25:03] looks like it [15:26:17] * MaxSem svn ups [15:26:56] hexmode, still broken for me [15:27:30] MaxSem: wfm here: http://winkyfrown.com/wiki/index.php?title=Bug_35051&action=edit§ion=1 [15:27:40] hexmode: 34841 is fixed [15:27:46] it was fixed even before [15:27:58] http://hub.tm-irc.org/test/w/index.php?title=Main_Page&diff=3085&oldid=3084 [15:28:16] this is latest revision [15:28:23] if you open any other edit links aren't there [15:28:30] however 1.19 seems to be broken there [15:28:36] hexmode, the bug is about summary not being preloaded with /* section title */ [15:28:40] petan|wk: svn upping now [15:28:43] so it's still broken [15:28:47] MaxSem: oh, yeah, sorry [15:28:49] :P [15:29:08] poor hexmode, too many bug falling on you [15:29:52] mwaahahaha [15:29:56] he asked for it [15:30:59] what I mean is that this bug is already fixed in trunk [15:31:07] fix isn't merged to 1.19 only [15:31:25] petan|wk: is it tagged 119? [15:31:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=34841 [15:31:44] this? [15:32:05] how do I tag it [15:32:26] oh you mean in svn? [15:32:30] let me check [15:32:30] petan|wk: which revision, yes [15:33:29] eeh [15:33:44] we need to be able to search through commit logs [15:33:47] :D [15:34:13] * MaxSem bisects for [15:34:15] 34841 [15:34:26] bisect? [15:34:31] what does it mean in simple english :D [15:34:40] petan|wk: part of git sweetness! [15:34:45] heh [15:36:12] I think it's faster to fix it than find a fix [15:36:39] btw the way they fix it in trunk is quite sucky [15:36:57] I would rather append oldid to edit url [15:37:12] so that you see edit links but they lead to old revision of page [15:37:45] question is if it's useful or not :D [15:38:12] maybe it would let you to revert vandalism and fix typo's from previous non vandal users in one revision XD [15:38:38] hm... [15:39:21] okay, you opened a section from an old revision and changed it. what next, into which version of page will you merge it - current or old? in either case, why? [15:39:37] old, of course [15:39:47] why? that's a better one :) [15:39:50] Y???????????? [15:40:06] I don't really know why it should work [15:40:17] but people don't have to click on that [15:40:26] for example [15:40:35] you want to copy a source code of section from old revision [15:40:38] any one want to look at http://bugzilla.wikimedia.org/34889 [15:40:54] MaxSem: ^^ [15:41:09] that's usefull I guess [15:41:22] * hexmode doesn't want to disturb MaxSem's bisecting [15:41:23] how would you copy a source code of section now? [15:41:33] you would need to open whole page [15:41:45] and search through code to find where it is [15:42:02] mediawiki support that function but there is no link to use it [15:42:25] http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&action=edit§ion=3&oldid=478913156 [15:42:28] look [15:48:37] fun stuff: close to the end of bisect, I see neither edit link nor the section itself. is it "good" or "bad"? :P [15:48:49] where [15:49:11] link I gave you is where the link would point to [15:53:43] hexmode, tracked down 34841 [15:53:59] !b 34841 [15:53:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=34841 [15:54:15] MaxSem: awesome... tagged? [15:54:21] yup [15:56:35] investigating 34889 [16:33:38] hexmode, I've fixed 34889 [16:33:57] \o/ [16:43:08] MaxSem: confirmed fixed [16:56:40] hi Zaran [17:14:39] Nikerabbit: you around? [17:14:48] RoanKattouw: 20% [17:14:55] * robla sees RoanKattouw just got back [17:14:55] where is raindrift?? [17:15:05] hexmode: he's at the product retreat [17:15:28] Just added the still-unclosed 1.19 tarball blockers to http://etherpad.wikimedia.org/20percent [17:15:35] robla: ah [17:15:44] hexmode: I did some pruning to the list in BZ [17:15:57] we fixed a few of them today [17:16:13] robla: any that had "regression" in the title? [17:16:33] yeah, at least one, because it was a 1.17 regression [17:16:55] at least, hexmode, we think he is at the product retreat. Slightly worrying since I know he is also giving a talk in Oakland tomorrow afternoon [17:17:08] robla: barely awake [17:17:14] (I should dismiss my nagging feeling that there's a conflict) [17:17:15] Yeah, they know about that [17:17:20] oh good [17:17:40] robla: this one https://bugzilla.wikimedia.org/29277 -- makes sense, I took it off my etherpad just before the triage [17:18:02] hexmode: I took 31755 off the list too [17:18:37] k [17:19:16] Nikerabbit: what do you want to focus your 20% time on tomorrow? [17:19:26] * RoanKattouw starts doing some code review in the meantime [17:19:42] * sumanah thanks RoanKattouw  [17:20:56] Nikerabbit: one suggestion would be to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=34885 . Trevor started it, but it needs finishing [17:21:11] is trevor on the retreat? [17:21:14] Yes [17:21:31] Only 1 day, but that's because he's on medical leave on Thursday and Friday [17:21:53] and the entire week after [17:23:19] Nikerabbit: another good one to you to fix or close WONTFIX is https://bugzilla.wikimedia.org/34961 [17:24:00] robla: you may have some insight into that one, but it looks like a lot of bikeshedding [17:24:08] * hexmode goes to ask siebrand [17:24:32] hexmode: he's gone too [17:24:35] robla: I'm at w3c conference, so no focusing on anything [17:24:35] product retreat [17:24:41] +tomorrow [17:24:43] at least, I would if he were here ; [17:24:48] ;) [17:24:55] oh....which one? [17:24:57] hexmode: Product retreat! [17:25:00] Nikerabbit: ^ [17:25:11] http://www.multilingualweb.eu/documents/luxembourg-workshop/luxembourg-program [17:27:24] hexmode: re 34961: all the solutions I consider good are rather big to implement, can't do that on normal bug fixing time [17:27:45] Nikerabbit: k, ty [17:28:33] robla: I'm taking it off of 1.19 so we can keep track of it and fix it for 1.20 [17:29:50] hexmode: I will keep that bug in mind if I figure out a solution that is easier to implement [17:30:25] :) [17:30:32] down to 4 tarball blockers [17:30:41] RoanKattouw convinced me that his focusing on code review is a higher priority [17:31:05] I would argue that you convinced me of that just last night, but whatever :) [17:32:25] I've been doing less CR than usual this sprint, but I aim to make up for it next sprint which focuses on bug fixing [17:33:07] hrm... are krinkle and/or Aaron out, too? [17:33:21] Aaron is here [17:33:53] ah, he wasn't when I checked earlier [17:34:47] AaronSchulz: Any time to follow up on https://bugzilla.wikimedia.org/35047 ?? [17:35:32] AaronSchulz: and should that be fixed before we release the tarball? Seems like it is WMF-centric [17:39:16] AaronSchulz: also, they've updated the bug in the last week since your comment... do you think something could have fixed this? [17:40:06] possibly [18:12:04] hexmode: is http://www.winkyfrown.com/coverage supposed to be up to date? [18:12:37] AaronSchulz: hrm... don't think so... let me check [18:13:22] AaronSchulz: no, that should be on jenkins, isn't it? [18:13:37] * AaronSchulz is looking [18:15:45] AaronSchulz: def should be, but I can't find it. Creating a bz request now. [18:15:49] * AaronSchulz gives up [18:19:27] AaronSchulz: already there https://bugzilla.wikimedia.org/31518 [20:40:27] Ryan_Lane: I would need a review of a simple script to list mediawiki extensions we are hosting [20:40:33] that is change https://gerrit.wikimedia.org/r/#change,3149 [20:42:49] or let me know if someone else can review it :-] [20:44:04] Hmm [20:44:08] I would beef that PHP script up a bit [20:44:24] why is this on the gerrit server? [20:44:32] Trim the .git , HTML-escape the extension names [20:44:37] Maybe format as an HTML list [20:45:02] ah. I see why [20:45:18] this means the gerrit server needs to have php installed [20:45:20] the git repos are on gerrit and ls-project is not publicly available [20:45:39] ohhhh no php there :/ [20:45:51] we could do it in perl :-] [20:45:53] It could be some other CGI-like thing, but then you'd have to install that [20:46:08] why not just have a cron that runs on the system that generates a static file? [20:46:24] RoanKattouw: I just need an up to date list. Any processing will be done by another script. [20:46:42] No it won't, not if you're exposing this to the web [20:46:42] I think regenerating a file every minute is up-to-date enough [20:46:47] and then it's a simple bash script [20:46:53] hell, it isn't even a script [20:46:54] HTML-escaping and setting a Content-Type is the very very least you need to do [20:47:01] But yeah updating a static file works too [20:47:39] ls −1 > /var/www/mediawiki-extensions.txt [20:47:51] RoanKattouw: why should we need to HTML escape / content type that list ? Are you afraid that someone create a repo whose name can be interpreted by internet explorer as a .exe ? [20:47:55] RoanKattouw: I am confused :) [20:48:03] Ryan_Lane: yeah that would do it [20:48:05] Not a .exe but HTML/JS [20:48:33] RoanKattouw: that would need someone to create a repository named [20:48:37] Yes [20:48:40] which is veryyy unlikely to me [20:48:49] Well it shouldn't be allowed [20:48:54] of course [20:49:00] But you should defend against that close to the output [20:49:18] I know that IE will still interpret Content-Type: text/plain as HTML if it wants to [20:49:26] Ryan_Lane: I am abandoning the change and making it a cronjob. will be wayyy easier [20:49:28] not sure if that still happens if it's also got .txt as its extension [20:50:01] ok [20:50:08] though... [20:50:15] you don't *have* to abandon it [20:50:26] you can git reset —hard origin/production [20:50:29] then make your changes [20:50:35] then commit, and use the same change-id [20:50:48] then it'll push it into this change [20:50:56] yeah amending [20:52:45] Fuck you IE [20:53:04] Even if you create foo.txt and serve it with Content-Type: text/plain ,