[00:16:32] Reedy: is there anything about REL1_19 particularly risky? [00:17:23] I don't think so [00:17:30] In comparison to 1.18, it's a relatively small release [00:17:42] (not that that actually means anything) [00:18:09] Ouch [00:18:21] The release notes file is half the size (in number of lines) [00:20:01] Reedy: I installed trunk+an extension+a gadget today and poked around. Tomorrow's busy but I can poke at 1.19 some as well. [00:21:23] You'll probably need 4 or 5 dev installs at minimum [00:21:40] trunk, wmf, current release, last release [00:22:23] Krinkle: hey, what do you know about addEvent? MediaWiki:Edittools.js on ar.wikipedia.org is trying to use it, and it's failing [00:22:47] That's probably an ancient thing that should be replaced with jQuery event binding [00:22:55] yeah, that's the easy answer [00:23:17] ok, just isolating this [00:23:30] Could be that they have a local function defining it [00:23:36] but it's no longer a global [00:23:45] or maybe it was in core once and got removed [00:23:55] I don't remember removing such function from wikibits though [00:57:03] Alphabet soup. [00:57:16] Do you all talk like that in-person? [00:58:15] What's alphabet soup? [00:58:45] https://en.wikipedia.org/wiki/Alphabet_soup_(linguistics) [00:58:51] I was skimming scrollback. [00:59:00] I appreciated some of your clarifications. [00:59:04] But it was still a bit of headache to read. [00:59:24] <^demon> Joan: You mean you don't use WP:SHORTCUTS in everyday speech? [00:59:42] VE, EE, ACW, NPT (now PT?), etc. [01:00:00] ^demon: Only WP:DICK and WP:OKAY. :-) [01:00:28] <^demon> I use WP:ILIKEIT, but not in the traditional sense :) [01:00:44] <^demon> Oh, and WP:NOT. That's very very important or I'd never get anything done. [01:00:45] I use {{like}} for that. [01:01:14] Joan is WP:NOT#NICE. [01:19:59] brion: just to make sure that I'm thinking right: How close is MathJax to deployment? [01:20:31] hexmode: in theory we could probably merge & deploy it as an experimental option any time now. i'd want a little more testing first though :) [01:21:05] k... [01:21:21] and then we've got the whole next product cycle to decide to make it default / improve it etc [01:23:47] how can i let users of my extension implement their own custom css? [06:58:02] hashar: Hi [06:58:39] hashar: question, testswarm still only has 1 tag in github (v0.1) how did you get Firefox 10 on integration.wm.o/testswarm ? that was added in v0.2pre and not released yet [07:27:47] Krinkle: :) [07:27:52] Krinkle: sorry was not really there earlier [07:28:08] Krinkle: I guess I have manually added Fifefox 10 in the database [07:28:31] ok [07:28:40] http://testswarm.wmflabs.org/testswarm/ [07:28:47] I just did apt-get install testswarm a minute ago [07:28:49] seems it's failing [07:28:52] the .ini file isn't read [07:29:02] do you remember having changed anything after apt-get? [07:29:08] or is the package good as it is [07:29:43] I suspect the .ini file might not be readable thus the override here: https://github.com/jquery/testswarm/blob/master/index.php#L6 isn't happening [07:30:12] I tried var_dumping it and indeed $swarmConfig is not being changed from the defaults [07:31:19] during 'apt-get install testswarm' there was 1 warning in the output: chown: invalid user: `testswarm:www-data' https://labsconsole.wikimedia.org/wiki/Nova_Resource:I-0000017b#Config, is that related? [07:31:40] It's probably very simple but I'm not sure what to do [07:35:07] hashar: [07:35:56] sorry [07:36:44] that chown: invalid user: `testswarm:www-data' is bad [07:36:53] yeah [07:36:59] the package should create the testswarm user [07:37:27] I didn't use puppet for most of the stuff though. As you can see on the nova resource page #Config I tried to do most stuff that the puppet manifest does. [07:37:33] oh the package should do that? [07:38:09] I am looking at what you did [07:38:54] * hashar looks at puppet conf [07:39:11] hashar: https://toolserver.org/~krinkle/tmp/psty/_out3/ [07:41:14] ok that was bug 33276 [07:41:43] fixed in testswarm-0.1.0-5 :-/ [07:41:51] we need to have the package updated on apt.wikimedia.org [07:42:26] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107118 [07:49:22] didn't you do this already? [07:49:27] oh, it's from 2011-12 [07:49:37] so… you did this by hand on the production server? [07:50:40] I think puppet did it [07:50:58] at the start I had lot of configuration being done by puppet [07:51:17] then moved some bits to the testswarm package so we can eventually release it [07:51:37] Krinkle: the https://integration.mediawiki.org/testswarm/?state=wipe has been fixed this night :-) [07:51:46] pinged CT about it and someone fixed the innodb issu [07:51:48] issue [07:51:49] the puppet does it before or after installation of the package? [07:51:57] it depends [07:51:59] because I already ran apt-get and now it doesn't work [07:52:12] I have to check the puppet dependency, I think by default it is kind of a random order [07:52:16] so can I just create the user now and chown the file by hand? [07:52:30] yeah that will fix the issue you are facing [07:53:07] ok [07:53:13] can you help me with the exact commands? [07:53:28] sure sure [07:53:39] I can understand some of the debian language, but not enough [07:54:20] just before we do that, is the ?state=wipe testswarm URL supposed to output anything else than "done" ? [07:54:25] no [07:54:29] it's fine now [07:54:32] great :) [07:54:45] hashar: Hm.. I see you added the fetcher files to the debian package [07:55:16] I find that a little strange, what do you think? [07:55:52] hu [07:55:55] oh nevermind [07:56:01] I was looking at tag/ci [07:56:24] I thought I was looking at /debs/testswarm but this is tools/testswarm/debian [07:56:26] sorry I had two other conversations to handle. Now finished and I am fully available. [07:57:45] the fetcher is deployed by puppet [07:58:17] the code is in operation/puppet git repository in files/testswarm/ directory [07:58:47] yeah, its fine [07:59:08] It looked like you added files to the debian package for it, but I saw it wrong [07:59:17] so for the chmod issue [08:00:46] so you need two fix: [08:00:51] 1) create the testswarm user [08:00:54] 2) do the chmod :-)) [08:00:58] yep [08:01:22] testswarm user and group creation are in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107118 [08:02:02] what matter is the postin script : https://svn.wikimedia.org/viewvc/mediawiki/trunk/debs/testswarm/debian/testswarm.postinst?&pathrev=107118&r1=107117&r2=107118 [08:02:13] it is run by debian package manager after file copying [08:02:22] much like MediaWiki hook system [08:02:23] Hm.. I thought that was special debian code, but it's just plain sh ? [08:02:28] yeah [08:02:45] but I can't paste it in the terminal right ? since it does " if " [08:02:48] and debian offers some function to ease tasks. They are known as debian helper [08:03:13] the "getent group testswarm" is used to verify if a group exist [08:03:27] I know sh/bash a little bit, I just didn't realize this was it [08:03:38] that might be confusing [08:03:39] I'll create a file for in my home and then sh it? [08:04:02] you can just copy paste the diff from viewvc and then run that in shell [08:04:04] that should work [08:04:14] or just copy paste the relevant part [08:04:17] addgroup --system testswarm [08:04:23] right [08:04:33] adduser --system --ingroup testswarm --home /var/lib/testswarm testswarm [08:04:33] usermod -d "/var/lib/testswarm" testswarm [08:04:33] usermod -g "testswarm" testswarm [08:04:34] usermod -G "www-data" testswarm [08:05:40] Warning: The home dir /var/lib/testswarm you specified already exists. [08:05:41] Adding system user `testswarm' (UID 115) ... [08:05:41] Adding new user `testswarm' (UID 115) with group `testswarm' ... [08:05:41] The home directory `/var/lib/testswarm' already exists. Not copying from `/etc/skel'. [08:05:41] adduser: Warning: The home directory `/var/lib/testswarm' does not belong to the user you are currently creating. [08:05:42] usermod: no changes [08:05:42] usermod: no changes [08:07:14] doh [08:07:37] so all is OK ? [08:08:11] /var/lib/testswarm is the user home directory [08:08:14] seems to belong to someone else [08:08:32] I created it [08:08:33] https://labsconsole.wikimedia.org/wiki/Nova_Resource:I-0000017b#Config [08:08:46] cd /var/lib; mkdir testswarm; chmod 0755 testswarm; chgrp www-data testswarm [08:09:19] I guess chown is still me or root [08:09:47] Weird do, I didn't get warnings about missing users back then [08:09:54] verify who it belong to though [08:09:59] stat /var/lib/testswarm [08:10:14] drwxr-xr-x 4 root www-data 4096 Mar 5 19:55 testswarm/ [08:10:19] ( ll ) [08:10:37] Access: (0755/drwxr-xr-x) Uid: ( 0/ root) Gid: ( 33/www-data) [08:10:53] so just: chown -R testswarm:www-data /var/lib/testswarm [08:11:00] ( -R for recursive ) [08:11:15] ok [08:11:28] just curious though, why didn't the other script do that? [08:11:29] then I will award you the [ I hack using shell ] badge :-)) [08:11:48] the postinst script does it [08:11:51] when creating the user [08:11:58] chown: changing ownership of `/var/lib/testswarm/scripts/.git/refs': Operation not permitted [08:12:00] hehe [08:12:16] it probably belong to root :-D [08:12:30] I changed that to be a git clone of the new gerrit repo instead of puppet://files/testswarm [08:12:41] anyway rest looks good [08:12:56] http://testswarm.wmflabs.org/testswarm/ is still off though [08:13:05] chmod on /etc/testswarm as well? [08:13:10] or chown? [08:13:15] all files or just config.ini [08:13:23] (there's 4 files) [08:13:47] that part is a bit messy [08:13:53] hm.. none of the chown's succeeded [08:14:02] chown: changing ownership of `/var/lib/testswarm': Operation not permitted [08:14:05] I didn't scroll down yet [08:14:12] were you root? [08:14:27] I was but not when I pasted that [08:14:34] re-doing [08:14:57] * hashar awards the [ only root change ownership ] badge to Krinkle [08:15:07] yay :) [08:15:08] drwxr-xr-x 4 testswarm www-data 4096 Mar 5 19:55 testswarm/ [08:15:24] ls /etc/testswarm/ apache.conf config.Debian.ini config.ini fetcher.ini [08:15:50] all root/root [08:16:09] the site is installed in /usr/share/testswarm/site/ [08:16:12] yes [08:16:17] the config file is loaded from /usr/share/testswarm/site/index.php [08:16:21] yep [08:16:21] a [08:16:22] nd [08:16:22] de [08:16:22] b [08:16:27] and debian patched index.php [08:16:34] exactly [08:16:47] so chown on /etc/testswarm/config.ini, but also on fetcher.ini ? [08:16:52] not sure from where that one is used [08:16:55] so the file /etc/testswarm/config.ini is read by Apache [08:17:05] on gallium it is : -rw-r----- [08:17:10] testswarm www-data [08:17:19] this way only testswarm is allowed to alter the configuration [08:17:24] but apache is allowed to read it [08:17:34] so that's 640 ? [08:18:01] obviously :-] [08:18:13] it already is 640 on labs [08:18:26] make sure it belong to testswarm:www-data [08:18:29] k [08:20:07] congratulations Krinkle :-))))))) [08:20:19] brb, charger [08:20:23] * hashar awards the [ I fix mad stuff ] to Krinkle [08:21:23] thx [08:21:46] well I should have written a bit more documentation about it [08:22:33] * Krinkle updated https://labsconsole.wikimedia.org/wiki/Nova_Resource:I-0000017b#Config [08:22:54] great [08:23:07] I am still denied from connecting to the labs instance :/ [08:23:57] hashar: If I create a new tag on github (v0.2) how to update? [08:24:11] I want the new user agents in there on labs "the right way: [08:24:11] we [08:24:57] debian package management system comes with a way to detect upstream changes [08:25:02] I never manage to make it work though [08:25:22] supposedly when you tag a new version, some magic command will make the package to auto update :-] [08:25:50] because testswarm only has 2 main sql files, no patch [08:25:54] so how does it figure out the database? [08:26:20] so far the testswarm instructions are: if you want to update to new database, just wipe them and re-populate from scratch [08:26:38] that is not supported by the package [08:26:39] losing existing data, but nobody cares [08:26:52] so debian just assumes database never changes? [08:27:01] indeed [08:27:06] but that is not debian fault [08:27:10] ok [08:27:38] on each upstream release we will have to figure out what changed [08:27:44] then add some SQL script to alter the db [08:28:07] those scrips can be given to dbcommon (a debian helper to manage database) so it can runs the alter [08:28:50] ok, so in the debian package you created would be an sql file somewhere tagged like "run this sql if previous version is < 0.2" ? [08:29:22] exactly [08:29:24] doc: http://people.debian.org/~seanius/policy/dbconfig-common-using.html/ch-develguide.html#s-updates [08:29:45] you just put the SQL script in somepath/testswarm/upgrade/mysql/0.2 [08:30:26] k [08:30:41] I'll create a bug for that [08:30:53] just gonna use v0.1 for testing [08:30:57] not important :) [08:31:35] I just insert the user agents manually from time to time [08:32:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=35027 [08:32:58] sure, but there've been a few other minor changes [08:33:04] nothing important for swarm-specialpage [08:33:24] but we will need those new changes in order to start browserstack VMs for needed browsers [08:33:32] (there's a new getneeded api) [08:33:42] but pretty much untested y et [08:33:46] not in v0.2 [08:33:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=35027 [08:33:53] oops, twice [08:34:24] hashar: do you know if it's hard to monitor testswarm db in some way? perhaps figure out the slowest queries? [08:34:25] https://github.com/jquery/testswarm/blob/master/config/testswarm.sql#L127 [08:34:34] probably insufficient indices [08:34:37] we will have to log them somewhere [08:35:22] there is a mysql command to log them [08:35:39] wmf uses that? [08:35:49] I have no idea [08:35:53] probably not [08:36:08] I guess domas just launch gdb :-) [08:36:33] here are the relevant parts: [08:36:34] #log_slow_queries = /var/log/mysql/mysql-slow.log [08:36:34] #long_query_time = 2 [08:36:34] #log-queries-not-using-indexes [08:36:58] asher would be able to told us [08:39:33] 2 seconds I suppose ? [08:39:39] yup [08:39:46] that logs any queries that takes long than 2 seconds [08:39:49] wow that looks magical, those 3 lines doing it all [08:39:57] the last setting additionally logs anything not using index [08:40:11] that is also a good way to fill your disk [08:41:35] hehe [08:41:40] yeah, we better not keep it in there [08:41:52] just for 2 minutes will give a good amount of data to start with [08:42:38] basically the only queries that matter are the ones triggered by getjob and submitresults [08:42:52] any other actions are rarely viewed [08:43:22] I'm even considering to implement a mode in testswarm where all html serving pages are removed (except /run/) [08:44:07] although right now it's more of a conceptual goal than a plan, there's no point to remove those for those that want to look at it [08:44:46] is there anyone using testswarm beside mozilla and us ? [08:44:58] Is mozilla using it? [08:45:18] (confusingly, it's no longer a Mozilla Labs project, the logo needs updating :D ) [08:45:26] it's a jQuery foundation project now [08:45:30] but that aside [08:45:50] I don't think any other major players are using it [08:46:01] other than us and all regions of jQuery [08:46:41] q [08:47:24] https://www.google.com/search?q=%22Welcome%20to%20the%20TestSwarm%20Alpha!%22 [08:47:30] guess who's on top :P [08:47:32] it's not fair [08:47:37] integration.mediawiki.org/testswarm/ [08:59:17] hashar: thanks :) Gonna be back later [09:49:08] how can i let users of my extension implement their own custom css? [10:22:57] how can i add tag arguments as javascript parameters using ResourceLoaderGetConfigVars? [10:37:48] Nikerabbit: :) [10:37:56] I think scap clear the cache too [10:39:09] and I am afraid of scap nowadays [10:40:07] hashar: did you change channel? [10:40:11] ah I see [10:40:32] as far as I know scap is the only thing rebuilding also l10n cache [10:40:42] I've asked a way to do that manually [10:40:44] but meh [10:41:57] we could extract that part out of the scap script [10:42:22] it is in operations/puppet ./files/misc/scripts/scap [10:44:14] March 6 20:32 logmsgbot: reedy synchronizing Wikimedia installation... : Rebuild message cache stuffs for r113129 [10:44:22] Nikerabbit: looks like reedy did it yesterday [10:46:00] so there might be an other issue :-/ [10:46:56] hmph [10:47:03] check if the message exists locally? [10:47:17] if not it might be a bug in l10ncache and that is mostly roan's area [10:48:23] no message http://sa.wikipedia.org/wiki/MediaWiki:pagetitle?uselang=en [10:49:40] $ mwscript eval.php sawiki [10:49:46] > var_dump( wfMessage( 'pagetitle' )->text() ); [10:49:46] string(0) "" [10:49:48] \o/ [10:55:36] argh.. Im scratching my head like crazy. Anyone know how i can output javascript variables from within the tag hook function? [10:55:55] Nikerabbit: I have just reopened bug 34938 [10:56:18] i've tried $wgOut->addJsConfigVars() with no luck.. [10:56:26] I have no idea sorry :/ [10:56:36] maybe ask on wikitech-l / mediawiki-l lists ? [10:58:20] hashar: poke roan? [10:58:59] have you been able to reproduce the issue ? [10:59:26] because the issue only appear on certain pages IIRC [10:59:41] and your fix in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113039 would have applied on any page [11:03:27] hashar: it's cached of course [11:03:43] sure [11:03:54] but I can't find out how to check the cache [11:06:18] Nikerabbit: how can we get the raw content of a message key ? [11:06:36] hashar: what do you mean? [11:06:48] wfMessage( 'foo' )->plain() ? [11:06:53] will try [11:07:17] yeah!!!!!!!! [11:10:51] hashar: yeah what? [11:11:05] ->plain() was what I was looking for [11:12:58] Nikerabbit: maybe the 'pagetitle' key is still set to empty in translatewiki.net ? [11:13:14] thus l10nupdate would still apply the empty string [11:14:38] hashar: l10nupdate takes it directly from svn [11:15:05] hashar: and I think I removed the key from trunk... has it been readded? [11:16:00] repeating what i said in #mediawiki: i suspect that it may have something to do with the fact that this message existed there in the past and was deleted. [11:16:10] i can't see its history, because i'm not an admin. [11:16:26] it happened to me a few times that deleted local messages were still seen, although i couldn't reproduce this consistently. [11:16:39] might be a bug in l10nupdate so [11:16:54] the script ran this night and it seems page title is still set to "" in the cache file [11:19:21] yeah 'pagetitle' => '', [11:19:23] great [11:25:17] hashar: in trunk? [11:25:34] that is from the output of l10nupdate [11:25:41] oh it has output too? [11:25:43] which ran at 2am [11:25:55] well not really, but it generates a serialized cache file [11:26:10] so you can download the file, unserialize the content and see the cache :-) [11:26:11] I would just rm -rf everything and regenerate it, but that might unstabilize the site ;) [11:26:53] Updating LocalisationCache for 1.19... [11:26:56] waiting now [11:27:12] preparing lunch [11:27:21] spam some beep if there is any trouble. I am not far [12:28:08] ahh we have a new drama thread on wikitech-l ! [12:28:11] about git and gerrit [12:28:13] * hashar reads [12:34:42] * hashar wonders if he should start trolling [12:52:35] * hashar thinks is going to fly around europe to train people :-]]] [12:55:54] Nikerabbit: GiGeGa for Git/Gerrit/GatedTrunk is a great find! [12:56:40] hashar: siebrand wanted GiGeGat [12:57:37] I am sure that git / gerrit thread is going to be a very long one [13:13:25] hashar, the most hardcore trolling is to switch to Gerrit ;] [13:14:12] it's kind of collective insamity [13:14:34] I do like Gerrit [13:14:53] epic, epic [13:16:48] You've gotta appreciate this community - the people on that thread are still not calling each other idiots. (Unless i missed it.) [13:17:24] I am seriously considering a road trip across europe to evangelize people about git/Gerrit ;) [13:24:01] hashar, you're concentrating on "oh, Gerrit allows us to have a gated trunk and merge with one click", while Nikerabbit concentrates on "its UI sucks, and it actually makes some stuff slower". just two ends of the same stick [13:24:23] I actually don't like either of those "features" [13:24:47] git is a great tool that the use of gerrit totally undermines, afaict [13:24:55] yep [13:25:14] naaaa [13:25:15] we might as well move to github for a while [13:25:23] NO FOR GOD SAKE!!!!!!!!!! [13:25:24] so we can be hacked? :-P :-D [13:25:25] pleasE? :) [13:25:40] seriously [13:25:58] we could have used github. that would be a great way to get patches from ton of people [13:28:02] MaxSem: yeah nike moved off topic :-] [13:28:11] MaxSem: I guess that disqualify him as a good troll [13:28:59] hashar keeps slowly gaining troll points meanwhile XD [13:30:37] ah bite me gdb + fedora [13:30:57] it's almost enough to make me switch to gentoo. [13:30:59] almost. [13:32:02] smewhere...there is a bad interaction with python, open2.poen4, php readline and gnu readline and pipes. [13:32:45] guess I'll get dessert, this download of alll the symbols is gonna take awhile [13:38:27] MaxSem: I think i will summon Jidanni to assists us in the git migration [13:39:26] nope, his lynx doesn't support tabs so he's screwed too [13:39:32] ohhh [13:39:34] <^demon|zzz> gerrit won't work in a text browser. [13:39:48] good morning Chad [13:39:54] * hashar sends Chad a donut [13:39:58] that's a potential problem [13:40:06] chad or the donut? [13:40:16] no [13:40:19] gerrit [13:40:31] I'll take an extra donut if you have one and they aren't stale [13:40:37] <^demon> You can use the command line interface, but that's totally unintuitive. [13:40:47] ugh [13:40:55] <^demon> (yes, gerrit has a non-interactive shell you can use via the 29418 port) [13:41:28] ok 117 mb of the libc symbols downloaded so far [13:41:29] grumble [13:41:55] https://www.mediawiki.org/wiki/File:Gerrit_under_lynx.png [13:42:14] <^demon> Heh, at least it does that rather than not returning anything. [13:42:15] please note it actually get a cookie from code.google.com !! [13:42:18] +1 for privacy [13:42:22] <^demon> Or returning something that doesn't work. [13:42:36] I like the IFRAME: javascript:'' [13:42:40] what cookie? [13:43:04] when browsing gerrit.wikimedia.org , we are asking to allow a cookie for code.google.com [13:43:11] <^demon> Not for me. [13:43:19] <^demon> I don't see a code.google.com cookie [13:43:30] <^demon> And if so, that's Totally Evil and we need to stop that now. [13:43:40] https://www.mediawiki.org/wiki/File:Gerrit_under_lynx.png <-- -bottom of lynx window [13:43:49] <^demon> Yeah I see it. [13:43:55] <^demon> Chrome's not showing any cookies. [13:44:02] ahahaha [13:44:18] Chrome does not know cookie. Chrome already knows everything it needs to know about you. [13:44:32] * hashar opens a bug report [13:44:34] <^demon> I'm inspecting the cookies, kthnx. [13:44:49] <^demon> I'm installing lynx. [13:45:17] I can't, rats [13:45:27] cause I'm busy installing debugging symbols for a bunch of crap :-( [13:45:51] <^demon> lynx isn't prompting me for a cookie. [13:45:55] <^demon> You sure that was gerrit.wm.o? [13:46:00] yeah because you have Chrome [13:46:10] the loading splash screen has Loading Gerrit Code Review ... [13:46:11] he says lynx doesn't prompt [13:46:12] it silently sniff all your ethernet traffic to auto accept cookies [13:46:19] so if your browser has prefetching enabled [13:46:26] code.google.com would send a cookie. #fyi [13:46:27] the loading splash screen? mmm [13:46:45] au: awesome! thanks :-)))))))) [13:46:53] <^demon> Seriously? That's totally evil. [13:47:42] >

Loading Gerrit Code Review ...

[13:47:49] here's some of the stuff from the index.hml [13:47:53] (using wget to grab) [13:48:05] I imagine it'd be quite easy to change the splash screen so it doesn't refer to an external host, though. [13:48:08] so I can believe that a splash screenmight do that [13:48:43] oh I reproduced it [13:48:49] I pressed the "right key" [13:48:55] wich makes lynx follow the above URL [13:49:06] hence I was actually asking to browse to code.google.com [13:49:25] yes you would [13:50:16] but that's if you go to the site with the source code for gerrit [13:50:22] not if you go to our instance [13:50:24] au: is http://en.wikipedia.org/wiki/Audrey_Tang your bio ? [13:50:51] one of my bios, yeah :) [13:50:54] cool [13:50:58] the world is so small [13:51:03] glad to meet you online :-)) [13:51:10] glad to meet you virtually as well! [13:52:15] I am mostly an autodidact myself. Not as smart as you though :b [13:52:18] so re prefetching, in Firefox it needs an explicit rel="prefetch", so it probably won't take effect on the loading screen. [13:53:00] isn't prefetching disabled by default anyway? [13:53:35] network.prefetch-next defaults to true on FF11 here [13:54:43] but it was a false alarm on my part - there's no rel="prefetch" link so it's not neccessary to adjust the reference to code.google.com on splash page, I guess. [13:55:29] good. so we are safe. [13:56:44] I think so [13:58:03] ^demon: are we really considering migrating to phabricator ? [13:58:18] <^demon> We're going to evaluate it around June-ish. [13:58:53] hmm [13:59:02] that let me enough time to troll it properly for the Berlin hackaton [13:59:07] how is phabricator different? [13:59:16] the UI does not sucks :-] [13:59:21] <^demon> It's pretty. [13:59:24] <^demon> But it lacks ldap support. [13:59:29] it comes with some easy linting [13:59:34] <^demon> Advanced acls (per-project, per-branch) [14:02:32] it has or doesn't hav them? [14:02:47] ^demon: are you available today to brain dump your git conversion script ? [14:02:58] note: I am not working friday [14:03:07] so that would leave us only tomorrow [14:03:24] <^demon> Tomorrow's bad. I could get it in today. [14:03:49] <^demon> http://www.mediawiki.org/wiki/Git/Conversion/Mirror - docs I wrote [14:04:33] which lead me to ask about https://gerrit.wikimedia.org/r/#change,2821 [14:04:40] on formey, your account is not declared [14:04:46] you are just listed as a sudo_user [14:05:17] <^demon> I *think* that's because of ldap? [14:05:36] <^demon> Yeah, ldap would make sense. [14:05:54] do you mean that I should be granted access through ldap ? [14:06:06] <^demon> Probably I need to change your default shell from sillyshell to bash [14:06:23] <^demon> IIRC that's what Brion or Tim did for me way back when [14:06:56] <^demon> Yep [14:07:02] <^demon> loginShell: /usr/local/bin/sillyshell [14:08:17] <^demon> Ok, changed your shell to bash. Should be able to login now [14:08:22] good thanks [14:09:22] <^demon> For that patchset, I'd say just give yourself those sudo rights I have (if you need them) or abandon it. [14:10:16] https://gerrit.wikimedia.org/r/#patch,unified,2821,4,manifests/site.pp [14:10:17] done [14:10:25] <^demon> And actually, everything is demon:svn, so you should be able to access it. [14:13:19] <^demon> Ok, so your working directory for this stuff is /svnroot/git-dumps. The scripts are in software/svn2git/scripts and the dumps themselves are in mediawiki/ [14:13:28] <^demon> Do *not* delete the log-* files [14:14:30] * hashar tries [14:16:38] <^demon> If you'd like, we could do a screen-sharing session later today and I can walk you through it. [14:16:51] sure [14:17:13] though I have to get my daughter in 3 hours [14:17:28] <^demon> Well I'm busy for the next few hours anyway--I have some errands to run and then a class. [14:18:25] hashar: "pick your favourite project" doesn't apply to me... most of the time I read everything that comes in and take an action if I have something to say [14:18:25] <^demon> I'll be out around 3pm EST. It's that too late for you? [14:18:49] <^demon> You can do partial project matching (which is totally undocumented afaict) [14:19:07] <^demon> If you just type "mediawiki" in the box it'll match all projects with that in the name. [14:20:03] let me check what 3pm EST is in my timezone [14:21:58] so we have a six hour shift [14:22:12] <^demon> Yep. [14:22:14] which mean 9pm for me, would be fine [14:22:37] I get a meeting from 2pm-3pm EST (8pm to 9pm) whith hexmode and chris mac mahon [14:23:37] Nikerabbit: pick your favourite project ? [14:23:54] hashar: yes, didn't you write that to me [14:24:00] Nikerabbit: what is the context ? Are you referring to the git/gerrit thread on wikitech-l ? [14:24:06] yep [14:25:02] Nikerabbit: you could also subscribe to any changes submitted to a given project [14:25:29] or you can just browse changes at the gerrit main page [14:29:16] hashar: with email it's easy to keep track what I have already seen [14:29:42] ^demon: I have sent you an invitation in our calendar [14:29:54] <^demon> mmk [14:30:06] Nikerabbit: yeah that makes things easier [14:30:23] <^demon> Oh, you'll get plenty of e-mail. Gerrit spams the hell out of you :) [14:30:36] ^demon: hopefully not too much [14:30:40] Nikerabbit: you could use tag the last revision reviewed. Then when ever you want to review again you could git diff that_tag origin/master [14:31:07] <^demon> Nikerabbit: At the very least on: new patchset, new comments, reviewed, merged. [14:31:14] <^demon> And on any push, if you're watching a project. [14:33:28] ^demon: looks like I can abandon my change to get sudo rights on formey. [14:33:41] ^demon: they seem related to adding svn users [14:34:02] <^demon> Yep, if you don't need to edit the ldap database you can skip those sudo rights [14:34:39] done thx [14:35:16] I have submitted my jenkins rewrite yesterday [14:35:20] well a base for it [14:36:08] https://gerrit.wikimedia.org/r/gitweb?p=integration/jenkins.git;a=shortlog [14:44:55] <^demon> hashar: Time to run errands and go to class. I'll be back this afternoon. [14:45:20] guess [14:45:24] I am going to go cooking [15:15:11] Now [15:15:22] I wonder if it's time to jdfi and tag and build 1.19.0beta1 [15:27:35] hashar: fancy spending 10 minutes or so poking and testing the REL1_19 branch? [15:28:17] I am moving out to get some food for tonight [15:28:23] then grab my daugther [15:28:23] :-( [15:30:45] It seems to be in reasonable shape [17:04:47] is there a straightforward way to modify the query portion of a URL rendered by a Mediawiki [[ ]] link? [17:04:56] via an extension, that is [17:07:54] what is the php version wikimedia is supporting? [17:08:53] netbrain: do you mean mediawiki? if so, installation requirements for the current release can be found here: http://www.mediawiki.org/wiki/Manual:Installation_requirements [17:09:10] mediawiki will run on PHP >= 5.2.3 [17:12:35] though 5.3 is recommended [17:13:23] indeed - there is some talk of bumping the php minimum requirement to 5.3 for the next release [17:14:07] awjr, try various hooks in Linker.php such as LinkBegin [17:14:28] MaxSem: I tried LinkBegin, although it doesn't appear to affect [[ ]] links [17:14:36] but maybe I'm just doing it wrong :p [17:15:30] we discussed adding more hooks to linker at the NOLA hackathon, probably it's time [17:15:47] MaxSem: so all [[ ]] links go through Linker? [17:15:59] if so then it seems using BeginLink should work... [17:15:59] yup [17:16:04] i must be doing something not right. [18:12:49] 3 minutes till 20% checkin [18:14:40] 20% bugs: http://bugzilla.wikimedia.org/35011 - Global lock seems to affect a different user from the its target [18:15:01] 20% bugs: http://bugzilla.wikimedia.org/34961 - Edit summary for moves should not include username [18:15:10] ping [18:15:19] (raindrift, Nikerabbit) http://bugzilla.wikimedia.org/34987 and https://bugzilla.wikimedia.org/34929 are the high-priority [18:15:21] 20% bugs: http://bugzilla.wikimedia.org/34947 - Incorrect SVG text rasterization [18:15:51] Nikerabbit: :) thanks for looking at that GENDER bug [18:15:56] sumanah: thanks! [18:15:59] it should mostly be fixed [18:16:47] hexmode: I wanted to ask about deployment-prep.. can I use that project to test my new features? [18:16:50] Nikerabbit: looking at https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113223 now [18:17:16] Nikerabbit: ok, seems in progress [18:17:27] raindrift: what will you be working on today? Code review to get the backlog down would be good [18:17:32] Nikerabbit: lots of interest in people doing that. I think chrismcmahon is going to be using it mostly, though [18:17:41] raindrift: but so would fixing any of the bugs mentioned. [18:17:51] raindrift: perhaps https://bugzilla.wikimedia.org/show_bug.cgi?id=34929 [18:18:21] hexmode: well, I need some place to test my ttmserver, and deployment-prep seems to be closest what I need to do that [18:18:31] Nikerabbit: and I think it really shows that we need to puppetize the environment so anyone can throw something like that up in labs [18:19:19] hexmode: how long is that going to take? [18:19:37] sumanah: i'll take https://bugzilla.wikimedia.org/show_bug.cgi?id=34929 since i've poked around in that code before anyway. [18:19:48] Great, thanks. [18:19:55] it might as well do it on my own comp if labs is not ready yet [18:20:12] sumanah: however, beware that i have a dr. appointment this afternoon, so i won't be around for a couple hours while i take care of that. [18:20:15] OK. [18:20:15] Nikerabbit: I don't know. but yes, for now, your own computer is best. [18:21:44] hmph [18:22:17] Nikerabbit: ask again in a few weeks maybe? :-) [18:24:14] Nikerabbit: so the next step for you, for your 20% day, is? [18:24:17] * sumanah reads backscroll [18:24:28] sumanah: it's for task in this sprint. I can't wait few weeks [18:24:42] understood. [18:25:47] I only have one hour tomorrow, some more on friday... but because my graduation getting near and other stuff I'm somewhat busy [18:27:32] Got it. Happy graduation! [18:27:43] * sumanah looks at https://toolserver.org/~robla/crstats/ [18:28:23] Aaron is always doing a lot of code review so I won't bother him with his 20% day. preilly? today's your 20% day, what will you tackle? [18:28:50] sumanah: sorry, I can't today [18:28:56] sumanah: yeah, if it wasn't so much paperwork... have to spend half of tomorrow fetching and carrying paper from on office to another [18:28:57] sumanah: I did code review yesterday [18:29:28] https://www.mediawiki.org/w/index.php?limit=500&title=Special%3ACode%2FMediaWiki%2Fstatuschanges&author=Preilly -- so you did, preilly. Great. [18:30:00] ok, I think that's it for this particular checkin, thanks all. [18:30:21] * sumanah is playing RobLa for the day since he's ill [18:33:23] anything else for me? [18:43:20] Nikerabbit: CR! :) [18:47:05] RoanKattouw: Got a minute to look at the caching issue ext.wikiLove.local is having? its still at cacheEpoch [18:48:25] Hrmph [18:48:27] In a minute [18:48:44] Strangely one of the CustomUserSignup modules didn't update properly either [18:49:42] RoanKattouw: since you have 20% today, could you ping me when you get a sec? [18:50:01] That was yesterday [18:50:09] I should update the wiki I guess [18:50:15] ah [18:50:25] I've moved my 20% to Tuesdays so it aligns with the rest of the VE team [18:50:28] yeah, that would help :) [18:50:30] Krenair: RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=35036 [18:51:23] I'll take a look in a minute. I just walked in 20 minutes ago, still reading e-mail [18:51:36] ok [18:51:44] Me too I guess :P [18:57:37] hexmode: chrismcmahon : hello :-) [19:08:40] hashar: chrismcmahon: let me know if you want me to come in. I'm going to leave you guys to it otherwise. :) [19:09:08] just fighting the stupid technology right now :/ [19:10:38] grrrrr, mailman [19:11:50] that's 1.19.0beta1 out [19:15:56] Reedy: Which wiki are you seeing the WikiLove timestamp bug on? [19:16:01] ... [19:16:20] I've tried to sleep since then [19:16:27] hexmode: chatting with Chris now :-) [19:16:28] Link to bug or whatever? [19:16:30] RoanKattouw: So you have a rekonq browser? [19:16:39] holy crap [19:16:43] (Yes, I do) [19:16:46] I just found the bug [19:17:02] The logic for message change invalidation is in ResourceLoaderFILEModule [19:17:05] * RoanKattouw bangs head against wall [19:17:13] aaaaah [19:17:26] Nikerabbit: want to CR r112479? [19:17:27] This seems to have been broken since the introduction of RL [19:18:25] AaronSchulz: can you give a link to that? /me lazy [19:18:36] !r 112479 | Nikerabbit [19:18:36] Nikerabbit: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479 [19:18:44] RoanKattouw: In a little while, can you point rekonq to your mw-trunk and verify $.client.profile() is detecting it as rekonq? [19:19:29] (probably doesn't have a console, but mw.loader.using('jquery.client', function(){ alert(JSON.stringify($.client.profile())); }) or something should work [19:19:42] e.g. from site/user scrip [19:20:05] Krinkle: rekonq wfm [19:20:12] AaronSchulz: how urgent? It's probably fine, I've had few quick looks on it and haven't seen any issues on production [19:20:32] It does have a console, it has WebKit's developer tools, similar to Chrome's [19:20:39] ok [19:20:57] so "name":"rekonq","layout":"webkit" ? [19:21:01] Yes [19:21:04] aight [19:21:44] OK, gonna do some surgery here to fix this RL bug [19:21:51] Brion also reported a security bug against RL, will fix that next [19:21:53] Krinkle: do we maintain our own testswarm debian package? [19:22:01] hexmode: Yes [19:22:25] hexmode: it's basically to avoid having to run on github/testswarm trunk [19:22:31] Krinkle: have you looked at filing an RFP for that? [19:22:40] hexmode: a what? [19:23:07] Krinkle: Request For Package: http://www.debian.org/devel/wnpp/ [19:23:24] hexmode: It's a basic wrapper around: Get latest tag from github, create 'testswarm' user, check it out into the appropriate directory and add the apache rules to the conf and restart apache. [19:23:33] hexmode: We need to stabilize it first [19:23:50] AaronSchulz: I can only find minor issues with indendation and missing @since tags [19:23:57] Krinkle: actually, I could ITP it :) [19:24:13] since you have already done a lot of work it looks like [19:25:07] hexmode: looking for definition of ITP [19:25:25] Krinkle: intent to package [19:25:32] ah, I see [19:26:02] hexmode: anyway, right now it's not stable yet. there's some post-install hackery that isn't in the package yet [19:26:21] hasher committed something in 2011-12 that should've fixed that, but ops haven't updated the package yet so we can't test it [19:26:28] right now both the live install and the labs install do it manually [19:27:17] Krinkle: is the post-install hackary documented somewhere? [19:27:53] hexmode: yes, in 2 places. hashar's commit to the debian package, and on labswiki where I've documented what I did [19:28:39] Krinkle: URL? [19:28:42] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107118 [19:28:54] https://labsconsole.wikimedia.org/wiki/Nova_Resource:I-0000017b#Config [19:29:09] the latter is a mess, the rev is what you want [19:30:01] k, making a TODO for myself [19:30:28] how can i get my extension translated? [19:30:59] is there somewhere i can flag the need? "the extension xxx needs translations!" [19:31:04] netbrain: is it in SVN? [19:31:15] hexmode: yes [19:32:21] netbrain: does it have .i18n.php files? [19:32:25] netbrain: the after that you need to talk to translatewiki people -- siebrand or Nikerabbit [19:32:35] hexmode: yes it does. [19:33:19] hexmode: what about peer review and testing of the extension? [19:34:23] i see from the wiki, that the extension should be reviewed by several developers before i try to publish the extension by creating a bug report with certain flags. [19:35:03] netbrain: are you trying to get this deployed to Wikipedia? [19:35:32] no, i guess not.. [19:36:34] netbrain: still, maybe you can get it reviewed [19:37:15] Nikerabbit: siebrand: can you flag netbrain's extension for translation? [19:38:20] RoanKattouw: Hm.. since the 'messages' property is in all modules (inherited via the base ResourceLoaderModule.php), perhaps the max() for this can be central too? [19:38:37] I can imagine there being classes out there not doing this as well [19:38:40] Ideally it would be [19:38:52] But it's hard to change that retroactively without breaking the interface [19:39:03] And it's designed to give modules the freedom to disregard things [19:39:09] ok [19:39:18] so it wasn't in the file module? [19:39:23] the logic [19:39:23] It was [19:39:25] Well [19:39:27] No, not all of it [19:39:36] getMsgBlobMtime() was in RLModule [19:39:36] the max() was, but getMsgBlobMtime is central [19:39:38] ok [19:40:01] Yeah, the $timestamp = max( $timestamp, $this->getMsgBlobMtime( ... ) ); code had to be in each subclass that has messages [19:40:06] So I added it to RLWikiModule [19:40:15] The other core subclasses don't have messages (UserOptionsModule etc) [19:40:25] And there are no extensions that directly subclass RLModule [19:40:58] ok [19:41:21] I'm trying to find how it gets the page_touched for those mw pages [19:41:48] getMsgBlobMtime doesn't contain it [19:42:10] That should be in MessageBlobStore [19:42:25] It doesn't retrieve page_touched directly [19:42:46] ah, makeModuleResponse() [19:42:50] it's done on-demans [19:43:01] Instead, MessageCache calls it when an MW: page changes, then MessageBlobStore regenerates the blob and caches it with a timestamp [19:43:40] Man I should really document the backend architecture some time [19:43:47] Especially the caching and invalidation parts [19:43:55] ah, it's not ResourceLoader specific, mediawiki has last mod timestamps for each message? [19:43:56] nice! [19:44:08] MessageBlobStore is RL-specific [19:44:17] okidoki [19:44:23] There are no per-message last mod timestamps, only per-module [19:44:43] ok [19:44:43] so when LocalizationUpdate runs, this is also updated correctly? [19:45:04] Yes [19:45:31] Running LU or changing the .i18n.php files causes LocalisationCache::recache() to be run, which calls MessageBlobStore::clear(), which clears the entire cache [19:45:46] RoanKattouw: and lastly, custom messages are also taken care of? (for RL2), or is that a todo still [19:45:48] On WMF, ::clear() is disabled and instead we have a script that clears the MBS that's called from scap [19:45:53] ah, nice [19:45:57] That's probably no longer needed with Tim's manualRecache change [19:46:14] Custom messages work, those are supported by MessageCache already so we get them just fnie [19:46:27] ok, you added that last year for RL2, right? [19:46:39] Actually no, that was already there [19:46:45] What I added was code to list custom messages, IIRC [19:46:52] yeah, indeed. [19:46:54] from the API [19:46:57] ok, dinner's ready [19:46:58] bbl [19:46:59] For autocompletion purposes [19:47:02] Alright, enjoy [19:56:23] * AaronSchulz gives r112918 to RoanKattouw [19:56:43] !r 112918 [19:56:43] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112918 [19:56:55] Will poke in a minute [19:57:55] hexmode: it will happen soon enoguh in any case unless there is something special on it [20:00:52] Nikerabbit: you're talking about twn? [20:04:58] hexmode: the extension [20:05:10] looks like siebrand is already ahndling it [21:50:35] what's the proper way of handling this: https://bugzilla.wikimedia.org/show_bug.cgi?id=35039 ? [21:52:06] <^demon> Really anytime a group is removed everyone should be removed from it first. [21:52:24] <^demon> You could possibly script up some kind of maintenance script that drops all user_group entries that refer to non-existing groups [21:53:10] * Ryan_Lane twitches [21:53:31] that group would have needed to be added to InitializeSettings to exist, right? [21:53:34] since it's a local group? [21:53:37] <^demon> Yeah [21:53:44] so, technically, I could add it back, remove the members, then remove it? [21:53:50] <^demon> Probably, yeah [21:54:01] <^demon> That's the first case, which is pretty trivial and totally harmless. [21:54:15] <^demon> The second case is a user being given a group that never seems to have been created. [21:54:29] <^demon> That's a little more interesting. [21:54:32] heh [21:54:41] would I do this via "groupOverrides" ? [21:54:50] <^demon> groupOverrides2, iirc. [21:54:53] ah. right [21:55:00] <^demon> Reedy: Amirite? ^ [21:55:08] or AddGroups? [21:55:14] wtf are all of these for? heh [21:55:16] <^demon> No, not addgroups. [21:55:32] <^demon> AddGroups/RemoveGroups is the "you can add/remove these groups from users" [21:55:52] ah [21:56:17] wait, isn't that I want, though? [21:56:27] to remove the group from users? [21:56:59] maybe it shouldn't check group existance before allowing you to remove it [21:57:28] that would likely be difficult [21:57:34] since it's the config file that defined it [21:57:47] though apparently the stewards are saying global groups have the same issue [21:57:58] you can remove a group without removing the members [22:00:35] well, either way, I think this is beyond my capabilities :) [22:02:56] the whole group configuration need to be refactored [22:02:59] it is a mess [22:03:18] every time I have to handle a shell request there I have to spend like an hour figuring it out [22:03:26] <^demon> Config mgmt overhaul is on the roadmap for this summer. [22:03:32] <^demon> :) [22:03:33] would be great [22:04:09] at one point I was considering using one .ini file per wiki then use some script to generate the PHP file [22:05:04] anyway, bed time for now ) [23:02:08] TimStarling: Remember that annoying magic-words-treated-as-missing-templates bug that you traced down to CDB issues or whatever? Apparently it's resurfaced in 1.19 , see https://www.mediawiki.org/wiki/User_talk:Catrope#Problems_with_magic_words_considered_as_.28non-existing.29_templates [23:02:25] It's being reported on my talk page for historical reasons but I don't have time to dig into this again [23:02:26] yeah, well the bugfix wasn't applied [23:02:30] heh, ok [23:02:35] apparently no patches were reapplied in 1.19wmf1 [23:02:38] It wasn't merged over from 1.18wmf1 to 1.19wmf1? [23:03:02] the MessageBlobStore::clear() patch wasn't reapplied was it? [23:04:11] Yes, it was [23:04:23] I reapplied it while you were in the middle of doing the manualRecache stuff [23:04:37] yeah, after it brought down the site [23:04:42] Oh, heh [23:04:46] Yes, that's right [23:04:46] I mean it wasn't reapplied by make-wmf-branch [23:05:01] You're saying we've missed other things, we could've missed this too [23:05:10] yes [23:05:40] anyway my first job today is to fix a bug which hexmode marked highest priority [23:06:01] it's very minor and not in my code, but I figured I may as well fix it since it's a one-line patch [23:06:23] OK [23:06:54] Let's see, it looks like both https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105964 and https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106137 might be relevant [23:07:08] ok maybe I can't even do that, sumana is pinging me [23:07:12] hehe [23:07:23] She's calling into something looks like [23:07:27] TimStarling: thanks for letting me know it wasn't "HIGHEST" priority. I wasn't sure and that helps me learn. [23:07:49] TimStarling: Anyway, if those two revs are safe to apply to 1.19wmf1 (looks safe to me), then I'll just do that now [23:08:11] And I have a cleanup script somewhere [23:08:16] * RoanKattouw reads the bug [23:17:38] RoanKattouw: TimStarling: May be related to the issue with magic words. https://nl.wikipedia.org/w/index.php?title=Speciaal:GevraagdeSjablonen&limit=500&offset=0 the ones with a colon are currently ghosts in the wantedtemplates-cache, when going to whatlinkshere there is nothing there. The ones without a colon (e.g. {{PAGENAME‏‎}} ), however are showing up in whatlinkshere, and also underneath the edit page of such article [23:17:39] https://nl.wikipedia.org/w/index.php?title=Welling_(Duitsland)&action=edit#editform [23:17:53] and when re-saving it, it's gone (simple purge does not fix it) [23:18:55] Yes, that's one symptom of it [23:33:05] hexmode: Meeting? [23:33:18] RoanKattouw_away: 1s [23:33:32] Trevor's on the phone anyways