[13:19:36] <siebrand>	hashar: Trying to find out why some URLs in code review e-mails are not https.
[13:20:03] <siebrand>	hashar: I'm seeing 			$url = $this->mRev->getCanonicalUrl( $commentId );
[13:20:04] <siebrand>	(in ui/CodeRevisionCommitter.php)
[13:24:17] <hashar>	siebrand: sorry connection is flappy
[13:24:42] <siebrand>	hashar: Is there a way to have CR always spit out https in e-mails/
[13:24:44] <siebrand>	?
[13:25:06] <hashar>	if it use getCanonicalUrl, I guess that means it will always use http
[13:25:45] <siebrand>	hashar: okay, that explains what's going wrong, then.
[13:25:50] <hashar>	we could force it to HTTPS but then people using only HTTP will scream
[13:26:04] <hashar>	ideally we should have some kind of per user preference for HTTPS
[13:26:07] <siebrand>	hashar: you think there actually are devs that do?
[13:26:23] <hashar>	send as a canonical (http) per default, but as a HTTPS one whenever a user opted in
[13:26:32] <hashar>	I have no idea :/
[13:26:33] <hashar>	OR
[13:26:40] <hashar>	we could just mod_rewrite http to https
[13:26:43] <sumanah>	if you force https then sometimes if https falls down then you have a really broken situation, IIRC
[13:27:16] <siebrand>	sumanah: well, me having to change from not logged in http to logged in https is also a really broken situation, isn't it?
[13:27:34] <sumanah>	sure.
[13:27:45] <siebrand>	I need to manually change the URL all the time; it's very annoying.
[13:27:51] <siebrand>	especially on tablets.
[13:27:54] <siebrand>	(or phone)
[13:28:56] <siebrand>	Oh well...
[13:29:01] <hashar>	siebrand: talk about it on wikitech-l
[13:29:09] <hashar>	cause we probably all have the same issue
[13:29:09] <siebrand>	I guess I'd just stop whining about dev things.
[13:29:18] <siebrand>	GIT will dove it all.
[13:29:19] <hashar>	then we could just make that site https only
[13:29:21] <siebrand>	solve
[13:29:31] <hashar>	or wait for gerrit yes :O)
[13:29:35] <siebrand>	at least, if you're using an OS that has apt-get
[13:29:59] <siebrand>	C:\mediawiki\extensions\CodeReview>apt-get
[13:30:35] <siebrand>	SM-LT6-2:Desktop siebrand$ apt-get
[13:30:35] <siebrand>	-bash: apt-get: command not found
[14:06:30] <hashar>	cant we install git-review on windows platform ?
[14:20:16] <apergos>	hey kids, what's still running 1.17?
[14:20:33] <apergos>	I ask because on (random host) mw61 I see a bunch of these:
[14:20:41] <apergos>	mw61 apache2[7296]: PHP Warning:  filemtime() [<a href='function.filemtime'>function.filemtime</a>]: stat failed for /usr/local/apache/common-local/php-1.17/extensions/WikiEditor/modules/./images/toc/close.png in /usr/local/apache/common-local/php-1.18/includes/resourceloader/ResourceLoaderFileModule.php on line 380
[14:20:57] <apergos>	I guess that RL needs some hardcoded stirng changed...
[14:24:45] <apergos>	or some cached something cleared somewhere
[14:25:09] <siebrand>	apergos: I see the fundraising team back porting to 1.17.
[14:25:24] <siebrand>	apergos: possibly donate.wikimedia.org
[14:25:50] <siebrand>	apergos: nope. That says 1.18wmf1 (r109351)
[14:25:51] <apergos>	really? meh but then we shouldn't be seeing tons of this sort of activity
[14:25:55] <apergos>	yup
[14:27:34] <siebrand>	apergos: don't know where it runs, but this may help: https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki&path=%2Fbranches%2Ffundraising%2Fdeployment%2Fpayments_1.17
[14:27:59] <apergos>	well the log over these is *full* of those
[14:28:04] <apergos>	errors.  so I really doubt it's fr
[14:28:15] <apergos>	as in hundreds of mb worth
[17:28:36] <Krinkle>	@quit
[17:55:02] <hexmode>	Reedy: https://bugzilla.wikimedia.org/34728
[17:55:15] <hexmode>	Reedy: last two comments
[18:01:17] <guillom>	hexmode: Sam Reed, or Reedy, but not Sam Reedy :)
[18:04:20] <hexmode>	guillom: ugh
[18:04:23] *hexmode 	sighs
[18:04:32] <hexmode>	sorry, reedy
[18:05:09] <hexmode>	I had typed "Reedy" but then said "I should call him by his name" and added "Sam" without removing the y
[18:07:29] <Nikerabbit>	Reedy: are you around?
[18:10:33] <Nikerabbit>	or AaronSchulz?
[19:12:54] <hexmode>	robla: lots of revs tagged 1.19 :(
[19:13:03] *robla 	looks
[19:13:10] *hexmode 	starts looking for people to review
[19:14:18] <hexmode>	robla: also see http://etherpad.wikimedia.org/119triage which has some new bugs
[19:15:22] <hexmode>	werdna: there is a 1.19 LQT bug if you get a chance
[19:31:52] <hexmode>	Krinkle: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/110988 -- does a string of @imports at the top work?
[19:32:40] <Krinkle>	hexmode: technically yes, but in practice I'm not sure if it's good
[19:32:49] <Krinkle>	it means re-ordering and thus affecting cascading
[19:33:31] <Krinkle>	If we load module A, B and C, and C/style.css starts with @import foo.css, then the order should be A/style.css, B/style.css, C/foo.css, (rest of) C/style.css
[19:33:32] <hexmode>	Krinkle: ah, so how hard is the last bit of that fixme?
[19:33:44] <Krinkle>	That is the case when creating 1 <style> tag per module and keeping them in that order
[19:34:05] <Krinkle>	but when merging it all into 1 <style>, the order is still the same, except that @import's only work when on the top
[19:34:06] <hexmode>	gotcha
[19:34:22] <Krinkle>	on the top of a <style>
[19:34:24] <hexmode>	yeah, seems problematic
[19:34:37] <Krinkle>	I haven't figured out how to handle this yet
[19:34:47] <Krinkle>	Maybe RoanKattouw_away has some ideas
[19:35:07] <Krinkle>	If we can't figure it out we can always revert it and re-open bug 31676
[19:35:21] <Reedy>	Nikerabbit: I am now
[19:35:58] <hexmode>	Reedy: https://bugzilla.wikimedia.org/34728
[19:36:10] <Krinkle>	bug 31676 is a bit of an edge case in that most installs won't trigger it. But it's not hard to trigger it. Install a dozen extensions that have style modules, a couple of gadgets with styles (most gadgets don't have stylesheets today), and you're there at the 31 limit of internet explorer
[19:36:32] <hexmode>	IE is lame
[19:41:34] <Krinkle>	I've also thought about to what extend we can forbid use of @import
[19:41:53] <Krinkle>	however that doesn't appear to be a viable option because there is a lot of stuff using that, more then one may realize
[19:42:31] <Krinkle>	many stewards and other cross-wiki editors use @import from their common.css to load a central .css file from their user space on Meta-Wiki
[19:42:48] <Krinkle>	same for centralizing gadgets (a 1 line gadget that does @import for css)
[19:43:13] <Reedy>	I should just mark all my emails and delete them
[19:43:18] <Reedy>	it's the end result usually anyway
[19:43:44] <hexmode>	inbox zero!
[19:45:39] <Nikerabbit>	Reedy: my Q was how to trigger l10n cache rebuilt nowdays
[19:47:05] <Reedy>	Nikerabbit: scap
[19:47:18] <Nikerabbit>	Reedy: sounds scary
[19:47:35] <Nikerabbit>	it should be runnable stand alone
[19:47:52] <Reedy>	There are other scripts that ultimately run scap if you really want
[19:48:18] <Reedy>	I suspect you can, then sync-dir
[19:50:23] <Reedy>	Nikerabbit: you can manually run l10nupdate too... but I'm not sure if it rebuilds the messages
[19:50:40] <Reedy>	Tim (recently) before said just to use scap when you have message changes
[19:50:43] <Reedy>	takes an age though
[19:52:02] <Krinkle>	RoanKattouw_away: http://john.albin.net/css/ie-stylesheets-not-loading funny read for when you're back. How IE is able to load 961 stylesheets actually
[19:52:19] <Krinkle>	But the method is unacceptable though, funny regardless
[19:52:21] <Krinkle>	insane
[19:52:33] <RoanKattouw_away>	I'll catch up after lunch, thanks for the link
[19:52:42] <Krinkle>	"What I discovered is that IE will load the stylesheets in the first 31 <link rel="stylesheet" /> or <style></style> tags it encounters. And inside each of those <style></style> tags it will only load the first 31 @import stylesheets.
[19:52:43] <Krinkle>	So theoretically you could use 31 style tags with 31 @import each and load 961 stylesheets into Internet Explorer. But, for god???s sake, don???t do that!"
[19:52:45] <Krinkle>	</unquote>
[19:52:55] <RoanKattouw_away>	bwahah
[19:53:25] <Krinkle>	However implemented that must be laughing their ass off by now.
[19:53:28] <Krinkle>	in IE
[19:54:36] <Krinkle>	also, there's a short KB article on how the limits were caused (long url, short content) http://blogs.msdn.com/b/ieinternals/archive/2011/05/14/internet-explorer-stylesheet-rule-selector-import-sheet-limit-maximum.aspx
[19:55:05] <Krinkle>	lunch? Oh right.. you're in SF
[19:57:42] <RoanKattouw_away>	Krinkle: Actually it says @import nesting goes 4 levels deep
[19:58:08] <Reedy>	I'd best have a look at the merge queues
[19:58:09] <RoanKattouw_away>	So in theory you could load 31^4 = 923,521 stylesheets :D
[19:58:35] <Krinkle>	RoanKattouw_away: There's also the selector/rule limit per stylesheet
[19:58:44] <Krinkle>	But I don't think we're hitting that yet
[19:58:53] <Krinkle>	but we might when everything is squashed into 1 <style>
[19:59:13] <Krinkle>	Anyway, I'll let you have your lunch before I mention http://blesscss.com/
[20:08:11] <hashar>	Krinkle: hi :)
[20:08:31] <hashar>	Krinkle: how is that Special:CodeReview styling going on ?
[20:18:25] <Krinkle>	hashar: should be fine now
[20:18:39] <Krinkle>	hashar: or were you asking how it works?
[20:18:47] <Krinkle>	it was broken yesterday
[20:18:49] <hashar>	I still have some &#160; showing in the line numbers
[20:18:58] <Krinkle>	ah, I blame ^demon|away for that
[20:19:05] <Krinkle>	well, I'm to blame
[20:19:08] <hashar>	anything that need a merge / deploy?
[20:19:10] <Krinkle>	but I've fixed it
[20:19:11] <Krinkle>	yes
[20:19:13] <^demon|away>	I merged it, but I couldn't deploy it.
[20:19:19] <^demon|away>	Ryan told me not to since bits was down :p
[20:19:29] <hashar>	o'really!?
[20:19:33] <Krinkle>	yeah, but that's all good now, right ?
[20:19:33] <^demon|away>	Last night
[20:19:51] <hashar>	so you merged to 1.19wmf1 but did not sync?
[20:20:26] <Krinkle>	!r r112458
[20:20:26] --elephant--	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/r112458
[20:20:31] <Krinkle>	!r 112460
[20:20:31] --elephant--	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112460
[20:20:33] <Krinkle>	those two
[20:20:47] <Krinkle>	hashar: I added an inline element so that the text background can be styled
[20:20:50] <hashar>	r112459 r112464
[20:20:57] <hashar>	the 1.19wmf1 changes :D
[20:20:59] <Krinkle>	yeah
[20:21:01] <Krinkle>	sorry
[20:21:05] <^demon|away>	I sync'd the first one, but not the second.
[20:21:09] <hashar>	 svn log -rBASE:HEAD   helps
[20:21:15] <^demon|away>	But it's the same file, so a single sync-file will do it
[20:22:06] <Krinkle>	hashar: I added a <span | del | ins> inner wrapping to <td class=" ins | del "> so that the background of the text (without affecting the entire line) can be styled.
[20:22:18] <hashar>	syncing
[20:22:21] <Krinkle>	thx
[20:22:44] <hashar>	btw, why have you replaced the HTML entities / rawElement() call ?
[20:22:57] <hashar>	is rawElement() too evil ? :-)
[20:22:59] <Reedy>	damnit
[20:23:03] <Reedy>	I just lost my bug
[20:24:54] <hashar>	Krinkle: now I guess you can mark https://bugzilla.wikimedia.org/show_bug.cgi?id=27375  as FIXED
[20:25:05] <Krinkle>	hashar: No, not yet
[20:25:19] <Krinkle>	these revisions didn't fix that, they only restored the ability to fix it
[20:25:28] <Krinkle>	the css is still in mediawiki:common.css
[20:25:32] <Krinkle>	committing now..
[20:25:53] *Krinkle 	gets hard-attack of number of !important in ext.codereview.css
[20:25:55] <Krinkle>	WHY!
[20:25:57] <Krinkle>	hart*
[20:26:06] <hashar>	just ignore them :-D
[20:26:21] <hashar>	we are going to abandon that software anyway
[20:27:47] <Krinkle>	Afaik it will still be used a fair bit for stuff that isn't primary wmf-centric (i.e. code that isn't maintained by wmf)
[20:28:14] <Krinkle>	and unless we're going to import all statuses and comments from CR, all revisions up to now will be primary viewed via CodeReivew
[20:30:56] <Krinkle>	!r 112511 | hashar
[20:30:56] --elephant--	hashar: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112511
[20:31:21] <hashar>	whitespace is wrong :-)
[20:31:41] <Krinkle>	weird
[20:31:42] <hashar>	you are mixing spaces and tabs again 8)
[20:32:03] <Krinkle>	No, not me. The gadget that hijacked MediaWiki:Common.css edit action did that
[20:32:38] <Krinkle>	My editor shows tabs as 4 spaces so couldn't see it. grrr. fixing
[20:32:50] <hashar>	4 spaces?
[20:32:56] <hashar>	use 3 spaces!!!!
[20:33:12] <hashar>	this way you detect any spaces inserted by people using 2,4 or 8 spaces :-)
[20:33:42] <Krinkle>	hashar: what if I get a file from you?
[20:34:05] <Krinkle>	or you from me
[20:34:09] <hashar>	or set tab size to 0, then reindent the whole file in vim with:  ggVG=
[20:34:36] <hashar>	Krinkle: then we are screwed :-(
[20:34:48] <hashar>	will need a third party using 5 spaces for tabs
[20:35:13] <Krinkle>	I'll keep 4 for now. And add a hook at some point to warn me about it
[20:35:46] <hashar>	in your  commit messages, I noticed you always use a prefix such as:   [ext.codereview.styles]
[20:35:53] <hashar>	are you doing that manually?
[20:36:00] <Krinkle>	hashar: yes and no
[20:36:28] <Krinkle>	It's not added by any application or script, but the way I create my commit message force me to (I choose to thoguh)
[20:37:02] <Krinkle>	I use a little mini-widget to create commit messages as .txt files and then "svn commit -F path/to/thatfile" is done by my alias "dosvncommit"
[20:37:12] <Krinkle>	I write my commit messages while/before I code.
[20:37:21] <Krinkle>	and then evaluate when diffing
[20:37:41] <Krinkle>	the widget I use for that has a topic, summary and long-msg field
[20:38:04] <Krinkle>	also helps me when entering my hours into ODesk
[20:39:25] <hashar>	I keep a log on office wiki
[20:39:47] <hashar>	!r 112513 |??krinkle
[20:39:47] --elephant--	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112513
[20:39:56] <hashar>	!r
[20:39:56] --elephant--	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/`e1
[20:40:10] <hashar>	!r is https://www.mediawiki.org/wiki/Special:Code/MediaWiki/$1
[20:40:10] --elephant--	You don't have permission to do that.
[20:40:11] *Reedy 	waits for hashar to finish  mergning stuff
[20:40:23] <hashar>	k
[20:40:26] <hashar>	I am merging r 112513
[20:40:43] <Krinkle>	hashar: Why did you ^H^H^H, ah https
[20:40:58] <Krinkle>	should be `e1 instead of $1 I think ? Or does it support $# as well
[20:41:09] <hashar>	Reedy: done
[20:41:23] <Reedy>	!botbrain
[20:41:23] --elephant--	I don't know anything about "botbrain".
[20:41:28] <Reedy>	You forgot.
[20:42:40] <Krinkle>	hashar: I keep my log on meta: https://meta.wikimedia.org/wiki/User:Krinkle/Log
[20:42:53] <Krinkle>	Reedy: Confused with mw-bot ?
[20:43:02] <Krinkle>	@dump
[20:43:11] <Reedy>	I thought it was running the same software
[20:43:23] <Krinkle>	yeah..
[20:43:27] <Reedy>	lols
[20:43:52] <Krinkle>	I saw ditch elephant and add support (or just configure if already) to mw-bot to run in more than 1 channel
[20:43:56] <Reedy>	ARRGH
[20:43:58] <Krinkle>	it supports it already
[20:44:01] <Krinkle>	#mwbot
[20:44:02] <Reedy>	IT'S RUNNING ON PROTOTYPE
[20:44:04] *Reedy 	glares at RoanKattouw_awa
[20:44:05] <Krinkle>	yeah
[20:44:08] <Krinkle>	I knew that
[20:44:28] <Krinkle>	!log
[20:44:28] --elephant--	Wrong channel!
[20:44:30] <Krinkle>	!logs
[20:44:30] --elephant--	I don't know anything about "logs".
[20:44:39] <Krinkle>	http://prototype.wikimedia.org/logs/%23wikimedia-dev/
[20:44:53] <Krinkle>	okay
[20:45:14] <Krinkle>	here's the plan, some with with access to elephant: Kill it and send me a zip of the logs dir, I'll upload it to mwbot toolserver logs
[20:45:18] <Krinkle>	and then re-start mwbot to be in this channel
[20:45:31] <Reedy>	Toolserver?
[20:45:37] <Reedy>	Why don't we get them both moved to labs?
[20:45:40] <Krinkle>	yeah, mw-bot runs on toolserver
[20:45:43] <Reedy>	Better stability than TS is having
[20:45:48] <hashar>	+ elephant seems to be on prototype
[20:45:56] <Krinkle>	it is
[20:46:03] <Krinkle>	Reedy: Why both, we only need one
[20:46:06] <hashar>	and prototype will be killed "soon"
[20:46:07] <Krinkle>	we can move mwbot to Labs, yes.
[20:46:28] <Krinkle>	On Toolserver mwbot is a shared project
[20:46:43] <Reedy>	I don't really care ;)
[20:46:45] <Krinkle>	if I do it on Labs now it would be under my account (or whoever's account)
[20:46:58] <Krinkle>	we need to make sure that multiple people can start/configure mwbot
[20:47:26] <Reedy>	mmm
[20:49:15] <Krinkle>	I've added #wikimedia-dev to mwbot/conf
[20:49:27] <Krinkle>	TrevorParscal: You have access to elephant, right ?
[20:49:41] <Krinkle>	(he's probably out to lunch)
[20:49:55] <Krinkle>	!quit
[20:49:55] --elephant--	I don't know anything about "quit".
[20:49:58] <Krinkle>	@qut
[20:50:00] <Krinkle>	@quit
[20:50:03] <Krinkle>	shit
[20:50:07] <Krinkle>	:P
[20:50:20] <Krinkle>	dbbot-wm is in SGE though, it'll auto start in a minute
[20:50:56] <TrevorParscal>	Krinkle: elephant is Roan's beast is it not?
[20:51:11] <TrevorParscal>	I'm wfh/sick/taking care of 2 kids with flu
[20:51:17] <Krinkle>	aha
[20:51:19] <TrevorParscal>	!out to lunch
[20:51:19] --elephant--	I don't know anything about "out". You might try: !mwbot !vectorspans 
[20:51:27] <TrevorParscal>	lolz
[20:51:31] <TrevorParscal>	!lolz
[20:51:31] --elephant--	I don't know anything about "lolz".
[20:51:34] <Krinkle>	!mwbot
[20:51:34] --elephant--	Hi! I'm mwbot, a bot that was quickly whipped up by Daniel Cannon (AmiDaniel) to help out around #mediawiki. There's not much documentation on me, but you can find all my source code at http://amidaniel.com/viewvc/trunk/MWBot/?root=svn
[20:51:40] <Krinkle>	Liar!
[20:51:59] <Krinkle>	uh ? MWBot source code is stored *there* ?
[20:52:15] <Krinkle>	well, it's not there anymore at least
[20:52:23] <Krinkle>	"This page is parked free, courtesy of ISAS"
[20:55:33] <robla>	RoanKattouw_away: are you back to working on https://bugzilla.wikimedia.org/show_bug.cgi?id=34542 ?
[20:57:33] <robla>	brion: do you have time to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=34667 ?
[20:58:44] <Krinkle>	robla: Anything you need from me? I've got unexpected vacation this week (it was on the calendar but I forgot about it), got all week off from school.
[20:59:07] <Krinkle>	meaning more time to work on mediawiki
[20:59:15] <robla>	Krinkle: is the bot problem pretty much resolved at this point?
[20:59:43] <Krinkle>	I haven't heard any more complaints, but let me check the checklist on the etherpad
[20:59:53] <brion>	RobH, i'll take a peek
[21:00:03] <RobH>	wrong rob ;]
[21:00:06] <brion>	bah
[21:00:09] <Krinkle>	https://etherpad.wikimedia.org/IRCBot-Messages
[21:00:12] <brion>	damn you tabcomplete
[21:00:19] <RobH>	i blame robla.
[21:00:20] <brion>	robla, ^
[21:00:27] <robla>	yeah RobH, you are the wrong Rob :-P
[21:00:28] <RobH>	;]
[21:00:45] <brion>	we need better namespacing
[21:00:51] <brion>	com.h.rob
[21:00:53] <brion>	com.la.rob
[21:00:59] <brion>	like in java
[21:01:22] <robla>	because the world needs to be more like ja...wait, what?
[21:01:58] <brion>	or we could do php namespaces with backslashes
[21:02:06] <hashar>	Noooo
[21:02:09] <hashar>	plz
[21:02:24] <hashar>	That\Look\Retarded
[21:02:55] <Krinkle>	robla: protect/* still fails
[21:03:05] <Krinkle>	you were working on that?
[21:03:11] <Krinkle>	"RobLa working on this one"
[21:03:39] <TrevorParscal>	hashar: tbh, you get used to the \ over time, it was a dumb syntax, but really so is $var
[21:03:47] <robla>	I started it, and then I thought Nike's fix was going to be the cure-all
[21:04:12] <hashar>	Krinkle: I have added very basic test in tests/phpunit/includes/RecentChangeTest.php  , might help to add one for protect/* in there
[21:04:17] <robla>	hashar: mind if we start a few minutes late while I do some traffic control here?
[21:04:26] <hashar>	robla: I am fine
[21:04:52] <hashar>	TrevorParscal: and array()  :-b  and  $this->
[21:05:09] <hashar>	TrevorParscal: hope your kids will feel better soon!
[21:05:14] <TrevorParscal>	hashar: yes, all of those too
[21:05:24] <vvv>	Hi. I have a fairly random bug which I think is somehow related to 1.19 deployment
[21:05:29] <Krinkle>	hashar: From what I saw that test tests the exact that that doesn't matter and fails the test what does, but I'll check it out
[21:05:33] <TrevorParscal>	hashar: thanks man
[21:05:50] <robla>	Krinkle: can you confirm that upload is working now?
[21:05:51] <Krinkle>	hashar: the message value does NOT matter, what matters is it matching the message-key and the $1 vars
[21:05:55] <brion>	robla, so 34667 looks like it's just that the drop target is small and non-obvious (a button), so if you drop elsewhere on the page the browser loads the image up instead of passing it to UW
[21:06:00] <Krinkle>	robla: upload is working
[21:06:02] <vvv>	The problem is that it seems to be undeterministic and I am not even sure whether it appears
[21:06:18] <hashar>	Krinkle: yeah I figured out that the test should really just look at the parameter order
[21:06:30] <hashar>	Krinkle: I have added a note about it in the test file
[21:06:46] <Krinkle>	hashar: I'll see if I can make the test better
[21:06:46] <robla>	Krinkle: ok...so it looks like we're going to have to do old-school brute force rather than relying on the omnibus fix Nikerabbit made
[21:07:06] <Krinkle>	I'll simply extend the test hashar refers to, that should do it
[21:07:15] <hashar>	Krinkle: just add the protect/* test
[21:07:32] <hashar>	Krinkle: I don't think it is worth a refactoring. Those i18n messages do not change that much
[21:07:32] <Krinkle>	hashar: I will, but I think it might pass due to the way that test is set up right now
[21:07:43] <hashar>	ohh
[21:07:45] <hashar>	:-(
[21:07:53] <Krinkle>	it's not hard to fix though
[21:07:54] <Krinkle>	lets see
[21:08:01] <Nikerabbit>	??
[21:08:11] <hashar>	Nikerabbit: you broke the IRC bot !!! 8-))))
[21:08:28] <Krinkle>	hashar: Hm.. phpqunit/suites is empty ???
[21:08:34] <Krinkle>	(near empty)
[21:08:44] <Krinkle>	phpunit*
[21:08:50] <Krinkle>	oh, it's in ./includes
[21:09:26] <robla>	brion: ah, I see.  well, that's kind of a usability fail I guess.  we probably shouldn't encourage drag and drop
[21:09:27] <RoanKattouw_away>	robla: Grumble, right, that bbug ....
[21:09:38] <Krinkle>	!b 34508
[21:09:38] --elephant--	https://bugzilla.wikimedia.org/show_bug.cgi?id=34508
[21:09:42] <Krinkle>	RoanKattouw_away: Can you kill elephant ?
[21:09:46] <RoanKattouw_away>	Sure
[21:09:47] <Nikerabbit>	hashar: among other things, yes
[21:10:03] <hashar>	Nikerabbit: so we were merely referring to a fix you sent or something:-)
[21:11:07] <robla>	brion: that's probably a 1.18 problem, then too, isn't it?
[21:11:24] <brion>	whenever it got changed to say 'drop media file' yeah
[21:11:28] <Krinkle>	RoanKattouw: :D auto-start ?
[21:11:38] <brion>	r110506
[21:11:42] <Nikerabbit>	RoanKattouw: should I try the touch startup.js fix or something?
[21:11:52] <Nikerabbit>	all other changes I did worked immediately
[21:11:52] <brion>	https://www.mediawiki.org/wiki/Special:Code/MediaWiki/110506
[21:11:59] <brion>	robla, let's undo that?
[21:12:03] <brion>	changed february 1
[21:12:08] <RoanKattouw>	Nikerabbit: Yes, try that
[21:12:15] *robla 	looks
[21:12:33] <robla>	oh, yeah, let's nuke that
[21:13:27] <chrismcmahon>	brion yes, click/select always worked, but I'm not 100% sure that drag'n'dropping didn't get bypassed even when hitting the target area (I could be wrong though)
[21:16:01] <robla>	we still have a few other 1.19 deploy issues to get through: https://bugzilla.wikimedia.org/buglist.cgi?resolution=---&target_milestone=1.19wmf%20deployment&list_id=94783
[21:18:41] <robla>	brion: another one for you possibly: https://bugzilla.wikimedia.org/show_bug.cgi?id=34708
[21:19:06] *robla 	goes into belated 1:1 with hashar
[21:19:20] <brion>	i'll look it over
[21:20:25] <Reedy>	https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/1.19wmf1
[21:20:38] <Reedy>	If anyone is interested in doing some CR.... Aarons can sit for the moment
[21:21:21] <AaronSchulz>	Reedy: r112383 	 is trivial
[21:22:04] <Reedy>	I hadn't actually started reviewing them
[21:22:10] <RoanKattouw>	robla: FYI I'm working on that ruwikisource ProofreadPage issue nwo
[21:22:27] <Reedy>	Though I meant your oldest 3
[21:24:28] <vvv>	Nikerabbit: ping. A have a nasty logging bug
[21:24:42] <Krinkle>	!mwbot
[21:24:42] --elephant--	Hi! I'm mwbot, a bot that was quickly whipped up by Daniel Cannon (AmiDaniel) to help out around #mediawiki. There's not much documentation on me, but you can find all my source code at http://amidaniel.com/viewvc/trunk/MWBot/?root=svn
[21:24:42] <mw-bot>	Hi! I'm mwbot, a bot that was quickly whipped up by Daniel Cannon (AmiDaniel) to help out around #mediawiki. Some quick help is at http://www.mediawiki.org/wiki/Mwbot, you can find all my source code at http://amidaniel.com/viewvc/trunk/MWBot/?root=svn
[21:24:44] <vvv>	Stuff gets truncated when moving pages with long titles
[21:24:49] <vvv>	https://upload.wikimedia.org/wikisource/ru/5/50/%D0%9E%D1%88%D0%B8%D0%B1%D0%BA%D0%B8_%D0%B2_%D1%81%D0%BF%D0%B8%D1%81%D0%BA%D0%B5_%D0%BD%D0%B0%D0%B1%D0%BB%D1%8E%D0%B4%D0%B5%D0%BD%D0%B8%D1%8F.png
[21:25:29] <robla>	!b 34538
[21:25:29] --elephant--	https://bugzilla.wikimedia.org/show_bug.cgi?id=34538
[21:25:29] <mw-bot>	https://bugzilla.wikimedia.org/show_bug.cgi?id=34538
[21:25:31] <Krinkle>	RoanKattouw: Can you kill it entirely?
[21:26:25] <RoanKattouw>	I killed it!
[21:26:31] <RoanKattouw>	Oh, maybe there's a restart script somewhere
[21:26:34] <Krinkle>	yeah
[21:27:03] <Reedy>	Krinkle: fancying reviewing a 1 line css diff? https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112384 Thanks!
[21:27:10] <Nikerabbit>	vvv: uselang=en would help
[21:27:16] <robla>	Krinkle: can I assign 34538 to you?
[21:28:10] <RoanKattouw>	I think so yeah
[21:28:14] <Krinkle>	!b 34538
[21:28:14] --elephant--	https://bugzilla.wikimedia.org/show_bug.cgi?id=34538
[21:28:15] <mw-bot>	https://bugzilla.wikimedia.org/show_bug.cgi?id=34538
[21:28:51] <Krinkle>	robla: That's ok, although I'm not sure what's left to do. TimStartling has scanned all extensions and I've looked into core.
[21:29:18] <Krinkle>	robla: Tim mentions in the bug comment he did half of ./extensions but in the mean time he's done the other half as well
[21:30:13] <vvv>	Nikerabbit: https://upload.wikimedia.org/wikipedia/mediawiki/d/db/Long_title_move_logging_fail.png
[21:31:48] <Nikerabbit>	hmm I wonder how watchlists format those
[21:33:02] <vvv>	Nikerabbit: it's recent changes
[21:33:04] <vvv>	IIRC
[21:37:12] <Nikerabbit>	vvv: WFM on trunk
[21:44:33] <brion>	RoanKattouw, here's teh bug link: https://bugzilla.wikimedia.org/show_bug.cgi?id=34708
[21:45:10] <RoanKattouw>	brion: Does reverting https://www.mediawiki.org/wiki/Special:Code/MediaWiki/110045 locally fix it?
[21:46:02] <brion>	lemme try it
[21:46:09] <brion>	that looks suspicious though
[21:47:05] <brion>	ok it.... hasn't but i suspect the bad data's still cached
[21:47:19] <brion>	there we go
[21:47:25] <brion>	cleared cache and now the links show fine
[21:53:43] <brion>	i've applied a revert on trunk
[21:58:59] <Krinkle>	hashar: Do you know where the &quot; comes from ?
[21:59:11] <Krinkle>	That's not outputted on IRC, nor is it in the raw message .
[21:59:24] <Krinkle>	https://www.mediawiki.org/w/index.php?title=MediaWiki:Deletedarticle/en&action=edit
[22:00:45] <hashar>	Krinkle: some sanitization process? :-/
[22:00:53] <Krinkle>	It's causing the test to fail
[22:01:03] <vvv>	Nikerabbit: well, you checked it with long non-ASCII title, right?
[22:01:19] <Krinkle>	locally that is
[22:01:31] <Nikerabbit>	vvv: ascii though
[22:03:08] <Krinkle>	hashar: Hm.. 		$msgOpts = array( 'parsemag', 'escape', 'replaceafter', 'content' );
[22:03:23] <Krinkle>	that makes no sense for an IRC comment, afaik those are outputted raw
[22:03:29] <Krinkle>	so my test is failing, and it makes sense
[22:03:40] <Krinkle>	the question is,  how come &quote; doesn't end up on iRC
[22:05:13] <hashar>	Krinkle: I am not sure the test actually test what is going to be sent to IRC
[22:05:19] <hashar>	there must be a post process pass after
[22:05:28] <hashar>	maybe the bot itself?
[22:07:05] <vvv>	Nikerabbit: well, WFM as well for the given case
[22:07:10] <Krinkle>	hashar: well, that's a bug then. There is no reason for messages to be html-unescaped between UDP-push and IRC-privmsg
[22:07:16] <vvv>	Any ideas when it was fixed?
[22:07:25] <Krinkle>	I'll see how it goes
[22:08:22] <vvv>	Nikerabbit: reproduces well on 1.19
[22:10:10] <hashar>	Krinkle: I am testing getIRCActionComment() call which is used by RecentChange
[22:10:34] <Reedy>	robla1: you've seemingly a tonne of packet loss
[22:11:13] <Krinkle>	hashar: the unit test asserts that the "patrol" irc comment ends in ": user_comment", however patrols never have a user comment and in reality ": comment" is not appended. There's something wrong here
[22:11:26] <Krinkle>	I fixed the test but now it fails
[22:13:18] <hashar>	Krinkle: cause the log entry is forged with a user comment
[22:13:26] <Krinkle>	Ah
[22:13:29] <hashar>	Krinkle: at the bottom of the test file in assertIRCComment
[22:13:32] <Krinkle>	I see
[22:13:54] <hashar>	probably want to add a comment only when it is actually needed
[22:14:31] <hashar>	Krinkle: that test suite is really hacky. Did it just to catch the obvious issue
[22:24:27] <Nikerabbit>	vvv: doesn't ring a bell
[22:32:31] <hashar>	Krinkle: don't spend too much time on 34508 (the IRC log issue)
[22:32:53] <hashar>	Krinkle: you probably are busy with the resource loader already
[22:33:09] <Krinkle>	not right now
[22:33:18] <hashar>	k )
[22:34:01] <hashar>	make sure to send your changes before you get to bed
[22:34:11] <hashar>	so I can continue tomorrow
[22:36:20] <Krinkle>	ok
[22:36:34] <Krinkle>	hashar: I'm also working through email backlog from the 2 weeks I was away in the mean time
[22:36:43] <Krinkle>	not on the irc bug entirely
[22:38:14] <hashar>	Krinkle: ok so I will work on the IRC bug tomorrow :-)
[22:38:38] <Krinkle>	ok
[22:38:49] <Krinkle>	hashar: I am working on it right now though, refactoring the test suite to match how the bots use it
[22:39:05] <Krinkle>	nothing major, mostly research, not much editing
[22:40:15] <hashar>	thus I will review your code tomorrow morning and build upon if you did not fix it this night :-D
[22:41:06] <Krinkle>	yeah
[22:41:21] <Krinkle>	hashar: robla send me an email with a python file to use as udp listener
[22:41:28] <Krinkle>	however it appears it's only writing to a file, not to standard-out
[22:41:29] <hashar>	\o/
[22:41:32] <RoanKattouw>	hashar: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112534
[22:41:40] <RoanKattouw>	(see bottom of commit summary for lols)
[22:41:49] <Reedy>	Krinkle: python script.py &
[22:41:58] <Reedy>	tail -f /tmp/log.txt
[22:42:25] <hashar>	RoanKattouw: well done :-)
[22:42:30] <Krinkle>	Reedy: I guess "-f" makes it watch live ?
[22:43:07] <RoanKattouw>	Krinkle: -f = --follow yeah
[22:43:22] <Krinkle>	OK
[22:43:25] <Krinkle>	I'll do that then
[22:43:42] <Krinkle>	robla's mail said "Run the attached listener, and watch standard output"
[22:43:48] <Krinkle>	I was like "help it doesn't work"
[22:43:54] <robla>	oh...sorry  :-/
[22:44:11] <Krinkle>	and then looked at the .py and saw it writing it a file, the file was written to. I was about to find out how to echo from python
[22:44:14] <Krinkle>	but this works too
[22:44:33] <robla>	print works fine
[22:53:33] <Krinkle>	hashar: Found it
[22:53:37] <Krinkle>	RecentChange::cleanupForIRC
[22:53:43] <Krinkle>	that undo's some html entities
[22:53:57] <Krinkle>	Via Sanitizer::decodeCharReferences
[22:54:13] <hashar>	see! we are sending secure text to bots 8-)))
[22:54:33] <hashar>	so feel free to call cleanupForIRC in the assertion helper
[23:02:07] <robla>	tfinc: I may need your help...see https://www.mediawiki.org/wiki/MediaWiki_1.19/Communications#Phase_4
[23:02:30] <tfinc>	lolz
[23:02:58] <tfinc>	robla: where is the english text?
[23:03:20] <robla>	actually....I think I've even got the pl text: https://meta.wikimedia.org/wiki/CentralNotice/Generic_maintenance_notice#pl
[23:03:29] <robla>	probably just need a code review adapting it
[23:03:49] <robla>	https://meta.wikimedia.org/wiki/CentralNotice/Generic_maintenance_notice#en
[23:03:59] <tfinc>	k, will look at later today