[00:46:19] <awjr>	robla: i think im about as far as i can get for now on bug 34653. it would probably be good to get someone more familiar with logging (and in particular the changes to logging in 1.19) to look at my changes and do some more thorough testing. ultimately, it seems like the API for log events did not keep up with changes to logging elsewhere in core.
[00:47:04] <robla>	awjr: thanks for the update, and spending some serious time on this
[00:47:22] <robla>	!b 34653
[00:47:22] --elephant--	https://bugzilla.wikimedia.org/show_bug.cgi?id=34653
[00:49:25] <awjr>	robla: np. i made a note of it in my commit message, but jfyi i'm a little concerned about the backwards compatibility of my changes (although it looks like DatabaseLogEntry::getParameters() should help deal with that) and I couldn't reliably test against 'rights' and 'block' log types so I'm not sure what kind of impact my changes have on those, or other generic log entries
[23:36:13] <hexmode>	swift or 1.19? https://bugzilla.wikimedia.org/show_bug.cgi?id=34718
[23:41:45] <qchris>	I just noticed that the fix for the SHA1 bug https://bugzilla.wikimedia.org/show_bug.cgi?id=34373 has not been backported to REL1_19. Is 1.19 supposed to have SHA1 working?
[23:42:18] <qchris>	(And there is no blocker / tracker bug reference to this bug for 1.19)