[00:02:15] hiya folks.... bsitu, TimStarling, hexmode, rmoen [00:02:20] hello [00:02:31] Hello [00:02:44] dunno where kaldari is. is he in the office today? [00:02:59] I think kaldari is out all week, not sure what he's up to [00:03:04] hi [00:03:47] so...just checking in on 20%, which is really a 1.19 checkin [00:04:11] I think this was generated fairly recently: http://www.mediawiki.org/wiki/MediaWiki_1.19/Revision_report [00:04:21] I'm reviewing r106752 [00:04:46] robla: I'm kinda iffy-here right now [00:05:20] bsitu: rmoen: what are you guys working on right now? [00:05:34] we have one unassigned blocker: https://bugzilla.wikimedia.org/show_bug.cgi?id=33989 [00:05:50] robla: last week I was ill and didn't get to do any code review. Though, since I'm now on the ve team, would like to move my 20% day to Tuesday so that I may pair code on Friday's with Trevor. I'm not currently assigned anything. [00:06:03] I am working on a new extension, tomorrow is my 20% time [00:06:44] yup, this is in prep for tomorrow. I had to find a time that Tim and you all would be online that was before you all got started [00:06:45] Since I'm full time at the moment, I'll sync my 20% day up with benny's [00:06:49] so that means tomorrow [00:07:06] rmoen: I'm fine with you moving the day, just change the 20% page [00:07:18] I'm liable to spend it doing maintenance on old extensions of mine. Reviewing patches etc [00:07:19] Hexmode: will do [00:07:30] I can probably also test LQT on 1.19 to save you the trouble [00:07:41] werdna: I think that would be best [00:07:58] also, I found a problem with LQT and sig length if you have time [00:08:47] robla: since my browser isn't working, the bug # looks familiar, which one is it? [00:08:59] hexmode: Solution is to shorten your signature? :) [00:09:25] werdna: yes, that works, but lqt sig length limit should match mw, shouldn't it? [00:09:39] hexmode: that's the CategoryTree bug [00:09:59] probably, depends on what the respective lengths are [00:10:07] ah, johnduhart still hasn't looked at that. :( [00:10:20] well...hmm, I guess it's off the fixme list [00:10:26] bsitu: how are you with jquery? [00:11:05] robla: but it is still open, right? [00:11:18] I am not very good at javascript, but I can take a look at it [00:11:27] if it wasn't assigned to him, how would he even know to close the bug? [00:11:31] hexmode: ^ [00:12:06] robla: point taken, I thought I had talked to him about it AND assigned it [00:13:13] hexmode: does beta.labs have the very latest code on it? [00:13:42] I can update it now, but I think it has been updated pretty regularly [00:15:52] it would be good to test if it's actually fixed [00:18:29] hrm... forgot to switch to the branch [00:18:33] 1m [00:19:58] chrismcmahon: are you still around? [00:23:33] hi robla [00:23:42] was just about to sign off, what's up? [00:25:12] a couple of things: [00:26:03] 1. I was thinking of getting you involved in testing bug 33989, but we can talk tomorrow about that it's still something that needs attn [00:26:16] !b 33989 [00:26:16] --elephant-- https://bugzilla.wikimedia.org/show_bug.cgi?id=33989 [00:26:41] 2. this may be a good chance to check in on the message work that you started today, since Tim is around [00:27:45] hmm, 33989 had been the last blocker, but I see there are new ones. I have a query out to Niklas about the Message stuff and how to approach it. [00:28:21] chrismcmahon: we added other blockers yesterday directly for deployment actions [00:29:17] they shouldn't be sw bugs to be fixed, I don't think [00:30:34] hexmode: got it [00:31:07] bbl, rebooting [00:36:08] chrismcmahon: please keep TimStarling in the loop on your questions, since he has a pretty good idea of how to work this, too [00:37:41] yep [00:37:46] hi TimStarling [00:37:51] hi [00:38:04] (sorry I am late robla) [00:38:31] TimStarling: my immediate concern is one of scale. I checked MessagesDe.php and that one alone has ~250 significant changes between 1.18 and 1.19 [00:38:58] presumably they are mostly in $messages [00:38:59] TimStarling: although I did spot-check a few files for correct PHP syntax, and I don't think that's the big risk. [00:39:27] it's very unlikely that php -l will tell you anything [00:41:31] I know there are a lot of changes, but what I'm interested in is the list I gave you, e.g. changes to $namespaces [00:41:55] chrismcmahon: one way to prioritize: http://stats.wikimedia.org/EN/Sitemap.htm <-and sort by usage [00:42:08] you can read the files with PHP and compare them logically rather than as text [00:43:38] LocalisationCache::readPHPFile() shows how to read these files, unfortunately it's protected but you can copy the code [00:43:48] !r 110909 [00:43:48] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110909 [00:44:46] yeah, the relevant files there are vi, eo, gu and ksh [00:45:24] for example gu had: "$1 {{????????????: $2 | ???????????????}} ?????? ????????????????????? {{??????????????????: 5 ????????? $ | ????????? ???????????? | $5 ?????????}} $3 ??????????????? ?????? $4" [00:46:16] for some reason $5 has been replaced by "5 ????????? $", google translate didn't enlighten me much on that but I assume it's some sort of currency notation [00:46:49] and the translator has translated the parser function names, e.g. gender -> ???????????? [00:46:57] but without actually adding aliases [00:47:06] lol [00:47:11] ok [00:47:24] and in another message: '$1 {{????????????: $2 | ???????????????}} ?????? ????????????????????? {{??????????????????: 5 ????????? $ | ????????????????????? ??? | $5} ????????????????????????}: $4 $3 ??????????????? ??????' [00:47:31] see, the braces are broken [00:47:41] double brace should be matched with double brace [00:48:02] TimStarling: which file is that from? [00:48:06] gu? [00:48:10] MessagesGu.php [00:48:20] checking something... [00:48:35] I fixed it, I'm just saying this is a category of error I'd like to search for more rigorously [00:53:09] hmm, just hunting around in Gu I can see some suspicious strings [00:53:28] [[{{MediaWiki:Grouppage-sysop}}|????????????????????? ]] ?????? [00:53:42] actually that one is OK [00:55:13] I see what you mean. I'll think about a good way to do that. Seems like there should be some sort of mechanical check for that sort of thing. [00:58:00] chrismcmahon: have you shown TimStarling your charter(s) draft? [00:59:18] you mean http://www.mediawiki.org/wiki/Mediawiki_1.19_Feature_Test_Charters ? [00:59:23] yes [00:59:24] TimStarling: I've been reviewing 1.19 features and bug fixes, made a list of things I think would worth investigating http://www.mediawiki.org/w/index.php?title=Special%3ASearch&search=feature+test+charters [00:59:42] subject to review and time constraints [01:00:05] mostly just figuring out what 1.19 actually is [01:00:11] reviewing that will take quite a while, I'll add it to my to do list [01:03:58] TimStarling: you're in Australia, yes? so it is mid-day there? [01:04:57] yes and yes [01:07:46] TimStarling: can we pick up this conversation during your morning hours tomorrow? it's been a long day for me. :) [01:08:19] sure [01:08:35] actually no [01:08:41] tomorrow is saturday here [01:08:51] oh, of course. [01:08:56] I have some other things that I might want to do with my weekend ;) [01:09:07] I have some ideas, but at least one of them is not a very good idea. [01:09:38] if you send me an email, I can reply monday my time, which will be sunday your time [01:09:50] I can handle the timezone difference, but the days-of-the-week difference really throws me off still [01:09:51] then we'll be able to discuss it monday your time [01:10:17] that sounds reasonable. by early next week we should have some empirical information as well [01:10:34] TimStarling: I think a quicker thing to review in that test charter is whether the top part covers the essentials [01:11:07] basically, what are the things that always break, and we say "wish someone would have tested that..." [01:11:31] that IE7 crashing bug would have been one during the 1.18 cycle [01:11:33] for sure. +1 information I'd like to have robla [01:12:35] whether or not the list of release note bugs is complete is something that is much, much lower priority [01:12:44] IIRC that one was quite tricky to reproduce, but yes, we should at least do some cross-browser testing [01:12:52] maybe on selenium, maybe by hand [01:13:38] oh....right I forgot about that [01:13:53] TimStarling: I want to automate cross-browser smoke tests definitely, but for now I just want to check those by hand. [01:14:02] chrismcmahon: this was crazy....it only crashed IE7 when the user came in via search engine [01:14:11] that is strange [01:14:16] chrismcmahon: perhaps someone told you that we have an account on an automated service for crossbrowser testing? [01:14:39] of the type "give it a URI and it will show you a grid of screenshots" [01:14:41] who on earth gets to wikipedia by search engine? I've never heard of that [01:14:58] *sumanah needs a moment, then laughs aloud [01:15:02] sumanah: yes, I was exploring crossbrowsertesting today [01:15:06] oh ok! [01:15:38] seriously though....how the heck do you test for that? [01:15:43] robla, is there an easy place to check for the bugs that got reported immediately after certain previous rollouts? 1.18, 1.17, etc.? [01:16:01] sumanah: probably village pump tech archives [01:16:04] someone with bugzillaAPI fu [01:16:12] ok, or that [01:16:41] actually, Mark did copy a bunch over to bugzilla, so that would be a pretty good thing to look at [01:16:42] there was also https://www.mediawiki.org/wiki/MediaWiki_1.17/Release_postmortem [01:16:54] but that was release, not deployment [01:19:03] chrismcmahon: so you could do a BZ query for the bugs reported on certain dates in Sept/Oct 2011, just on/after deployment [01:20:31] actually, the week right after the enwiki deployment is probably the most interesting [01:20:42] yeah. [01:29:27] this is a reasonably interesting list: https://bugzilla.wikimedia.org/buglist.cgi?type0-1-0=lessthaneq&list_id=87271&field0-1-0=creation_ts&field0-0-0=creation_ts&resolution=FIXED&resolution=DUPLICATE&chfieldto=Now&query_format=advanced&chfield=%5BBug%20creation%5D&value0-2-0=2011-10-31&value0-1-0=2011-10-15&field0-2-0=resolution&type0-0-0=greaterthaneq&value0-0-0=2011-10-04&type0-2-0=changedbefore&product=MediaWiki&product=Wikimedia [01:29:56] it's everything reported between Oct 4 (deploy day) and Oct 15, that we fixed before Oct 31 [01:31:01] there's some stuff that we happened to get to in there, but there's several of the problems we had to fix [01:32:25] chrismcmahon: so, I had this on my TODO list: [01:32:26] * Prepare for 1.19 beta testing by compiling a list of people who reported problems in 1.17.0, 1.17.1 & 1.18.0. Ask them to be on-call to test. [01:32:26] ** Mark to compile the list -- Amgine, et al. [01:32:26] ** Sumana to possibly ask them to test trunk versions, definitely ask them to test the 1.19 branch. [01:32:26] ** Discuss testing community stuff with Mark & Ashar (testing mailing list? meetings?) [01:32:59] chrismcmahon: but we can talk about it tomorrow, if your brain is dying right now :-) [01:35:40] that's a good TODO :) [01:36:01] ok, chrismcmahon, shall I email that to you, or what's your preferred capture method? [01:36:22] sumanah: I'm kind of fond of wikis :) [01:36:28] less fond of email. [01:37:09] what? no! ;-D so, would you consider this part of your Charter work, or a larger 1.19 release thingy? I think the latter, in which case maybe I'll put this somewhere in the 1.19 page or subpages.... [01:37:20] I like that [01:38:18] *hexmode looks at backhistory [01:39:23] sumanah: it might be helpful to link to yours from the 1.19 Charters page [01:40:16] chrismcmahon: check out https://www.mediawiki.org/wiki/MediaWiki_1.19/Roadmap#Testing_and_release_planning [01:41:33] chrismcmahon: and now it is no longer mine! It is ours, verging on yours! [01:43:54] ok, chrismcmahon, you don't know how grateful I am to have the opportunity to introduce you to a bunch of people with varying interests in volunteer testing. When would be a good time for me to give you that handover? Unfortunately it will have to be semiprivate, email or GDoc or the like, because I will be sharing their contact info and so on [01:44:00] probably GDoc [01:44:09] actually, I just answered my own question [01:44:14] sure [01:44:33] that's on my list as well, but I figured to have a working test env before that happened [01:44:43] in the next few days I will try to put summaries of my personal communications histories with them (maybe 15 people?) into the volunteers spreadsheet, and then let you know, and walk you through it [01:44:54] sounds good [01:45:03] ok. [01:45:44] I figure, you are concentrating on release management tasks right now and so mustering the volunteers must take a back seat to that [01:46:14] but I can at least take this opportunity to put this info where you'll be able to grab it when you are ready to spam them and say "hey we'd love it if you'd join us for a party! a breakin' stuff party!" [01:46:19] or however your style goes. [01:46:38] I assume you will provide jazz music for the party [01:46:39] something like that :) [01:49:22] sumanah: my thought was to have a working 1.19 in place (probably) on test2 before inviting volunteers. otherwise it looks a little like spam I think. [01:49:29] Sure. [10:56:16] here we go, some fun with ant [10:56:17] http://imgur.com/0LhfA [15:18:22] sumanah,will you please help me out how to get started mediawiki , I have programming experience in PHP and mysql [15:18:27] hi bharath! [15:18:43] bharath: have you already looked on mediawiki.org ? [15:18:53] also, bharath, tell me more about why you're interested in MediaWiki specifically. [15:21:01] sumanah: first of all it is an open source org and all the code written is in php which I think I've fair knowledge [15:23:28] sumanah: i have checked the mediawiki.org website [15:24:05] bharath: OK, so that's "first of all" -- go ahead and continue your answer :-) [15:27:24] sumanah: and I want to contribute to media wiki [15:28:15] bharath: right, but, there are a lot of LAMP-based web apps out there that are open source, including Drupal and WordPress. I'm happy to point you to https://lists.wikimedia.org/mailman/listinfo/wikitech-l and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker but I'm curious, why MediaWiki specifically? [15:36:49] sumanah: yes we have ,but I want to start my journey of coding from mediawiki [15:37:11] bharath: ok, you don't have to answer my question if you don't want to, but it's pretty amusing [15:45:47] I wonder whether he was interested in GSoC, or was at the Pune hackathon, or just heard through a friend, or what. I rarely get that level of stonewalling when I ask that question [15:50:01] sumanah, hi; do you have any more information on that ResourceLoader IRC workshop? [15:50:18] guillom: no, not since you talked to varnent last. [15:50:22] He's really the one organizing it. [15:50:30] Ah, ok; I didn't know that. [15:50:38] Thanks. [15:59:16] i'm going to branch 1.19wmf1 later today, so if people are wanting to commit stuff to be merged into REL1_19, I'd prefer it's done earlier and saves the double merge! [17:15:40] ialex: a few pages you might hit: https://www.mediawiki.org/wiki/Manual:Global_object_variables https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture https://www.mediawiki.org/wiki/Manual:Wiki.php and https://www.mediawiki.org/wiki/Deglobalization [17:15:46] just to celebrate your triumph :-) [17:27:05] robla: hello :) do we do the 20% IRC checkins in this channel ? [17:27:36] hashar, we do [17:28:37] *robla wonders if he accidentally didn't put one of these on his calendar [17:29:03] heh! [17:29:05] Friday! Casual-about-code-review Friday! [17:29:19] <^demon> And lots of git conversions [17:29:28] <^demon> robla: I fixed my bug with extension and tag exports. [17:29:29] we don't need no steenking calendars! [17:29:38] ^demon: "conversion" makes it sound like you are an itinerant preacher [17:29:45] he is [17:29:54] <^demon> Apparently trailing slashes in rules matter, and svn2git explodes with a totally unhelpful way when you mess up. [17:30:00] praise be to rebase! [17:30:43] actually, praise be to debugging [17:31:23] I am definitely going to buy some more monitors. .. I keep losing my browsers windows on this laptop :)) [17:31:43] so, today is Reedy, Amir, gwicke, and hashar [17:31:56] <^demon> robla: Basically svn2git doesn't do any kind of sanity checking before it starts chugging away. [17:32:07] <^demon> So you can get halfway through a conversion and get some bizzare error. [17:32:51] ^demon: it kinda stands to reason that these tools never get the love, since it's a one time thing [17:33:12] once you figure it out, it's not like it's worth the investment to fix it [17:33:36] anyway, hashar...what 20% stuff you have planned for Monday? [17:34:14] since there is not that much to review for me, I wanted to pick one of the 1.19 deployement blocker [17:34:41] there are, what, 70 revs to review on trunk right now? [17:35:02] <^demon> 82. [17:35:12] some of them are post branching aren't they? [17:35:17] we need to update the tools to only factor in 1.19 at this point [17:35:35] though having 82 revs already is a bit alarming [17:35:36] <^demon> 78. [17:35:58] <^demon> Well that's counting nodeploys and everything. [17:36:00] hexmode: did you get a chance to update the revision report script? [17:36:09] <^demon> I'm usually just looking at Special:Code/MediaWiki/status/new [17:36:43] robla: I did, let me push it [17:37:11] cool...so http://www.mediawiki.org/wiki/MediaWiki_1.19/Revision_report should have pretty close to the real number [17:37:23] here is the link I am using : http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/status/new&offset=110996&path=/trunk/phase3 [17:37:37] that show any new revision before the REL1_19 branch point [17:38:00] <^demon> hashar: Take r39787 off my hands :p [17:41:04] so we have 8 revisions to review, all of them mostly recent [17:41:43] hashar: need to look at extensions, too [17:45:23] sure sorry [17:45:47] the most worrisome on the list is bug 33989 [17:45:50] !b 33989 [17:45:50] --elephant-- https://bugzilla.wikimedia.org/show_bug.cgi?id=33989 [17:46:01] list of blockers that is [17:46:30] Reedy: looks like this may not have been caused by johnduhart's work then? [17:47:11] Maybe, maybe not [17:47:20] it would seem we need some javascript/jquery fu in order to fix that one [17:47:38] *sumanah types Kr, tab, nothing, darn [17:48:10] He's supposed to be on holiday [17:48:25] Daniel say it uses action=ajax instead of the API [17:48:35] I'm sure he came onto irc not so long ago [17:48:37] <^demon> robla: http://p.defau.lt/?robCcbNiBzPODTXCBlaMtQ \o/ [17:49:03] ^demon: \o/ indeed [17:49:19] ^demon: you rocks :))) [17:49:22] <^demon> Lemme repack this and we'll get it pushed to gerrit. [17:49:31] |sort -n [17:49:32] yay! [17:49:46] ^demon: have you create the repo in gerrit yet? [17:49:56] <^demon> Yeah, it's already there. [17:50:42] <^demon> And I figured out how to create projects in gerrit earlier :p [17:50:47] Reedy: can't we revert CategoryTree to some old revision? [17:51:23] no [17:51:32] revert to the one before RL'ification and it doesn't work well either [17:51:53] so we need a sprint to migrate it to API usage and fix it up [17:52:33] that would seem to be the case [17:56:03] robla: Reedy maybe I can give a shot at the CategoryTree extension [17:59:48] hashar: that'd be useful [18:01:32] robla: merge req sent [18:01:40] hashar: please! [18:01:50] hexmode: a votre serv [18:02:14] hexmode: were you referring about the CategoryTree extension? [18:02:32] yes [18:02:38] sorry :) [18:05:06] I have assigned bug 33989 to me [18:05:10] will look at it monday [18:07:41] ahhh [18:07:52] https://gerrit.wikimedia.org/r/2506 :) [18:08:03] submitting non sense to test/mediawiki/core [18:09:18] ^demon: I have submitted a gitreview conf file with https://gerrit.wikimedia.org/r/#change,2507 [18:09:30] you might want to add it somewhere in your svn / git migration script [18:10:57] <^demon> Just add 'em manually :) [18:11:01] <^demon> Easier than hacking this script. [18:12:14] :-D [18:12:31] robla: do you need me anymore ? [18:12:56] we're good [18:12:59] thanks [18:13:07] have a nice week-end [18:13:11] :-) [18:14:19] robla: it's still codereview time more than patchreview time, I assume I will speak up more next week :) [18:14:38] sumanah: I can do patches :) [18:15:09] hexmode: so is today your "respond to all the 3-week-old patches with the sorry msg" day, hexmode? [18:15:19] <^demon> Ok, this is my biggest annoying bug in gerrit to date. [18:15:23] <^demon> You can't delete projects. [18:15:26] sumanah: :) guess so [18:15:33] ^demon: is this in the list of gerrit-bugs-to-fix on labsconsole? [18:15:40] <^demon> I just added it. [18:15:44] <^demon> It's the most-requested bug. [18:15:46] hexmode: oh, I was hoping you'd already done it this week [18:16:43] sumanah: it was my intention, but it is happening now instead of earlier [18:16:54] nod [18:19:24] 29 bugs w/ patches from the last month [18:19:35] <^demon> I think I'll have to make a test/mediawiki/core2 :p [18:19:39] <^demon> Since you can't delete. [18:20:25] ^demon: could you look at a parser patch? [18:20:33] *hexmode is scared of it [18:20:44] <^demon> Parser? :\ [18:20:47] <^demon> I can *look* [18:21:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=1310 [18:21:04] last comment [18:21:28] <^demon> Ha, no way! [18:21:34] hey ^demon, look who the author of r1111111 is :) [18:21:47] oo! it has a test case! [18:21:48] <^demon> werdna: I saw. You sent me an e-mail about it. [18:21:56] actually r111111 [18:21:57] :) [18:22:00] thought you ought to know [18:22:01] <^demon> hexmode: He could add 30 testcases. That's still too scary. [18:22:14] <^demon> I'd defer to newparser guys rather than changing this (ages old) behavior now. [18:22:27] ^demon: I know, but it is the thought that counts! [18:23:06] who is supposed to be working on newparser? I've lost track. Is that the same as VE guys? [18:23:19] brion is, fo sho [18:23:22] maybe gwicke [18:23:56] ^demon: how's life anyways [18:24:12] <^demon> Good, just been busy. [18:24:20] <^demon> Classes + git unicorns. [18:24:22] brion: around? [18:25:55] wot [18:26:21] gwicke's been in the thick of it, i have ot catch up :) [18:26:27] been playing in mobile land lately myself [18:26:27] brion: new parser work: how would this fit? https://bugzilla.wikimedia.org/show_bug.cgi?id=1310 [18:26:47] brion: yeah, was wondering if your focus had changed [18:27:00] I'll try to ping gwicke, too [18:27:09] we have parserfunctions for recursive stuff [18:27:18] tag hooks are .... or should become.... obsolete perhaps [18:28:15] k, I'll ask gwicke to comment unless you want to [18:29:24] brion: If you read the comments, it sounds like the problem is that bar bar baz doesn't recognise the inner set of [18:29:57] that is, it interprets it as (bar bar ) plus the plaintext baz [18:30:22] right [18:31:07] <^demon> It's been that way forever :p [18:32:12] yeah [18:33:31] hey pgehres [18:33:39] hey werdna [18:33:54] wassup [18:34:02] ^demon: git unicorns? [18:34:18] <^demon> making mediawiki into a git repo :p [18:34:19] werdna: not much, just got into the office [18:34:21] Don't you know that it's a lot easier to convince a rhinoceros to stand behind a horse? [18:34:28] werdna: https://www.mediawiki.org/wiki/Berlin_Hackathon_2012 [18:34:33] and then look at it from the right angle [18:35:16] sumanah: yay berlin! [18:35:31] That's an awkward week for me though, that's generally my last week of classes [18:35:53] <^demon> Compressing objects: 85% (446072/519804) [18:35:56] *^demon twiddles thumbs [18:36:01] hey hexmode, when you mention the code slush, maybe you could link to an explanation, like Brion's post on wikitech-l initiating it? [18:36:09] people might not know what that phrase means [18:36:40] sumanah: I did say "like a code freeze" but I like your idea better :) [18:36:40] (thank you for doing this getting-back-to-patch-authors, hexmode, I appreciate it) [18:39:32] Anyone with more revisions to go into 1.19 before I make 1.19wmf1? [18:43:58] To 1.19wmf1, and beyond! [18:44:04] sumanah / hexmode: It's 20% day! Is there anything in particular either of you is after from me [18:44:26] all of your tiem! [18:44:41] werdna: can I give you some patches to look at and comment on? [18:45:10] *sumanah seconds hexmode [18:45:21] hexmode: Nod, I'm mostly asking for stuff that needs me specifically [18:45:34] werdna: that AbuseFilter patch? [18:45:53] werdna: also is it reasonable to ask you to look at LQT stuff? [18:46:00] werdna: Let me see... what areas should I look at? AF, LQT, and ? [18:46:00] (back in a moment) [18:46:35] sumanah: which one? [18:46:46] I'm pretty sure I've applied anything current [18:46:51] anything with the 'patch' keyword anyway [18:47:22] werdna: one LQT one: [18:47:22] https://bugzilla.wikimedia.org/buglist.cgi?keywords=reviewed&type0-1-0=changedafter&keywords_type=nowords&list_id=87601&field0-1-0=attachments.ispatch&field0-0-0=attachments.ispatch&columnlist=bug_severity%2Cpriority%2Cassigned_to%2Cbug_status%2Cproduct%2Ccomponent%2Cchangeddate%2Cshort_desc&resolution=---&query_based_on=Week%20old%20patches&chfieldto=Now&query_format=advanced&chfieldfrom=-1m&value0-1-0=-1m&bug_status=UNCONFIRMED&bug_status [18:48:02] I could've posted the link: https://bugzilla.wikimedia.org/show_bug.cgi?id=32040 [18:48:26] hexmode: https://bugzilla.wikimedia.org/buglist.cgi?keywords=patch%2C%20need-review%2C%20&query_format=advanced&keywords_type=allwords&list_id=87602&component=LiquidThreads&resolution=---&product=MediaWiki%20extensions [18:48:40] werdna: hexmode - there are 5 patches awaiting review on LQT. [18:49:04] sumanah: I was just looking at those in the past month, still [18:49:10] werdna: if something is way too old to work, then please tell the authors that, mark the patch obsolete, and change the keyword "need-review" to "reviewed". [18:49:33] sumanah: oh on LQT [18:49:41] hexmode: I figure, we have Andrew, let's have him clear out the LQT backlog and let's see if any of these patch authors might actually be good to start working on it more [18:50:02] sumanah: makes a ton of sense :) [18:50:27] reducing the bus factor would be nice especially if there is ever gonna be a hope for LQT to get more traction and momentum [18:50:32] which I would like [18:50:37] make sense, werdna? [18:50:47] LQT won't get any momentum until there is active WMF development effort [18:52:20] werdna: you have more experience on this than I do, but there are extensions that thrive on non-WMF wikis, and if I can encourage chapters, other wikis, and volunteers to adopt and work on it, that might help [18:53:46] basically the necessity to move forward seriously is that the rewrite is finished, and before that happens I need some product-level attention on a few issues [18:53:50] it's not far off technically [18:54:12] hrm... more than one parser patch... I will look at all the patches before sending gwicke another email [18:54:42] just needs some thinking before I plough through and waste my time reimplementing the same crap I had before without any understanding of what should actually happen to a couple of features/requirements [18:54:46] anyway... [18:55:03] hey Reedy, have a sec? [18:55:06] ok, I understand, werdna .... do you think maybe Ironholds could help liaise on this? [18:55:11] that's part of his job [18:55:22] also werdna we have some more product managers around WMF now so maybe they could help [18:55:38] sumanah: I think it needs attention from the product team itself, but it needs more than community liaison [18:58:13] werdna: is there a ready-made list of those open product questions anywhere? [18:58:40] werdna: if there is, I'd be happy to push to get them answered by product people [18:59:09] I had one lying around somewhere, I think I mailed it to Erik a few months ago [19:03:00] werdna: put it up on wiki, on the extension page or the talk page or something? [19:03:21] that's what I'm thinking [19:03:29] thanks! [19:04:05] werdna: wassup? [19:05:20] Reedy: is this an abuse of the API or not? [19:05:21] http://bug-attachment.wikimedia.org/attachment.cgi?id=7509 [19:05:23] seems kinda icky [19:05:52] brb, my laptop is playing up [19:06:04] Reedy: tell it to behave itself [19:07:15] That's sorta what the hook is there for.. [19:07:22] I wouldn't do if( $module->getModuleName() == 'info' ) { though [19:07:34] use instanceof ApiQueryInfo or whatever [19:10:03] Reedy: okay [19:15:22] thanks a lot Reedy [19:37:58] right hexmode, those are all reviewed [19:37:59] :D [19:40:08] werdna: could you make sure the keyword "needs-review" is changed to "reviewed"? and leave any comments from your review? [19:40:40] *hexmode goes to check #mediawiki in case he missed that happening [19:42:42] hexmode: I applied them all [19:42:50] so they're all just FIXED now [19:43:29] :) :) [19:43:47] that should make sumanah really happy, too [19:45:52] sumanah: so them AbuseFilter and LQT bugs are done [19:46:22] thank you werdna [19:50:20] sumanah: https://bugzilla.wikimedia.org/show_bug.cgi?id=33545#c7 -- seen bawolff? [19:51:54] hexmode: not in the past 4 hours or so. [19:52:16] werdna: ok! so, Nikola Kovacs is someone to encourage. [19:52:23] ^demon: you mentioned David McCabe/ [19:52:23] ? [19:52:54] <^demon> I was being facetious, he's not been around for 5 or 6 years. [19:52:54] werdna: anyone else that I should take a look at? [19:53:12] ^demon: do you know whether anyone has reached out to him? was he a good engineer? [19:54:11] werdna: I've added https://www.mediawiki.org/wiki/LiquidThreads to my watchlist, so if you add the list of open questions there or on its talk page I can jump on it [19:54:43] <^demon> That's a werdna question as to whether he thinks David was any good. [19:56:12] I didn't really like his code [19:56:19] He hasn't worked on MediaWiki for years [19:56:39] just a GSoC student that ended up following the money here because Erik had a particular interest in the project he had to be working on [19:56:46] worked for us for a bit, then left [19:57:16] werdna: I will avoid reaching out to him, then [19:57:18] or try to [19:57:26] :) [19:57:53] Nikola Kovacs is doing some good work, definitely worth having him around [20:00:36] werdna: so you'll respond to that email I send you & Nikola? [20:00:40] sent* [20:01:01] which one? [20:01:36] there's only been one, werdna - "AbuseFilter & other patches, and encouraging volunteer development" [20:01:43] the one in January? [20:01:47] you responded on the 14th [20:01:48] yeah [20:02:11] but something more substantive like "you are doing good work" etc would probably make Nikola more likely to stick around [20:02:34] nod [20:02:40] can do [20:02:56] thanks werdna [20:03:32] sumanah: http://www.mediawiki.org/wiki/LiquidThreads_3.0/Design_issues [20:05:59] <^demon> https://gerrit.wikimedia.org/r/gitweb?p=test/mediawiki/core2.git;a=summary [20:06:01] <^demon> Woo :D [20:06:23] werdna: aha, thanks [20:06:51] ^demon: :D [20:06:55] but where are the branches? :) [20:07:42] <^demon> Oh, whoops. [20:07:44] <^demon> I botched that. [20:08:20] <^demon> Under "heads" at the bottom. [20:13:30] <^demon> Hrm, some tags seem missing :\ [20:55:36] <^demon> sumanah: Dan's right...things in core will be under the same access policy generally, there's not an easy way to separate different parts of the project. [20:56:49]