[00:48:05] TimStarling, AaronSchulz, ^demon|away, I'm in x2003 [01:01:15] ^demon|away, AaronSchulz, TimStarling, I need your input on one commit access requester [01:01:37] ah, looks like someone took care of that one [01:01:45] yep [01:02:20] Aaron and I had a phone meeting [01:02:46] ok. I'll reply to Binaris, Christian, and hashar then [01:03:09] *sumanah ends 15-min silent call with the conference call line [01:04:08] TimStarling: how are you enjoying the gerrit review UI? [01:04:30] still getting used to it [01:04:45] I wish it had URLs for more things [01:05:19] TimStarling: I see you have Sascha's ticket locked atm, let me know when you finish with it? I'm prepping the New Committers email [01:05:51] unlocked [01:15:34] AaronSchulz: you've done some sort of performance testing on SwiftFileBackend haven't you? [01:17:35] I haven't tried to slam it, which I'd want to do on labs or something (otherwise the testing would be slow and useless) [01:18:10] but you've checked things like request counts? [01:19:37] not recently (aside from some quick debugging) [01:20:28] ok [01:21:30] heh, I'm doing that right now [01:24:00] *AaronSchulz hmms [01:32:09] TimStarling: anyway, I do already have the text profiler on [01:36:32] *Aaron|away sees stuff to optimize [15:02:48] I'm helping plan https://wikimania2012.wikimedia.org/wiki/Hackathon -- GrafZahl_ do you think you'll be coming to Wikimania? [15:05:36] guillom: may I pm? [15:07:35] sumanah, in 15 min or so? [15:07:39] ok! [15:07:45] great [15:19:03] sumanah, ready when you are [17:32:41] ^demon: I added some of the communications stuff to https://www.mediawiki.org/wiki/Git_conversion#Timeline and am working my way through the rest of our notes :) [18:02:43] Amgine: my head is swimming a bit as I try to figure out from that meetings thread when the actual meetings are for the UCOSP team - could you put the times on https://www.mediawiki.org/wiki/UCOSP_Spring_2012 ? [18:05:49] Hello yoni_omniti ! Are we the only two AFT5 team members here? I see that [18:06:01] hi fabrice [18:06:05] greg is here as well [18:06:09] fabriceflorin: thanks! [18:06:09] I see that RoanKattouw is away. [18:06:23] I'd leave in protest but I'm not sure anyone would notice ;p [18:06:36] Oops, sorry Ironholds, I didn't see you there, behind the bush ;o) [18:06:45] that's no way to talk about my router [18:06:58] What's Greg's handle? [18:07:13] gregchiasson [18:07:36] and reha is here too (rsterbin) [18:08:19] Thanks! Hello gregchiasson and rsterbin! [18:08:23] Howdy. [18:08:26] hey [18:08:45] so we're all here for the AA meeting, right, or did I get the wrong calendar slot again? [18:09:11] Article Afeedback? :) [18:09:21] ...yes, lets say it's that [18:09:49] What do you guys think of the question I just posed on email? Do we need a second 'user rights' for oversighters and aft user groups to delete feedback posts, besides the 'aft-hide' user rights? would we need an 'aft-delete' user right as well? [18:10:02] fabriceflorin, yes. [18:10:20] if we are going to be sticking it quasi-live we *need* some way of deleting information [18:10:38] http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/ - ugly bug is bug. Has this been fixed but not patched yet, or...? [18:10:39] Hello Sumanah, yes, we are hoping to deploy the new feedback page for AFT today -- but this will be a non-public page for testing purposes by our team only. [18:10:53] and also anyone who has participated in the AFT5 development discussion [18:10:59] There already are aftv5-hide-feedback and aftv5-delete-feedback permissions, fwiw. [18:11:04] and, theoretically, anyone any of us decides to give the URL to. So... [18:11:30] we definitely need to include delete-feedback in the aft user group and the OS usergroup [18:11:34] Oversighters can delete/see deleted, and oversight/rollback/sysop can hide/see hidden [18:11:43] you don't need to stick hide-feedback in the oversighters group; all OSers are admins :) [18:11:51] (if you've already done it, no worries, obviously) [18:11:54] Ironholds, can you send us an email detailing how you got the bug you report above? Please list every step you took to get it. [18:11:56] fabriceflorin: so, that'll make a nice new status for https://www.mediawiki.org/wiki/Article_feedback/status :-D [18:12:09] fabriceflorin: Okay; I went to http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/. Done ;p [18:12:28] that's the entirety of the details. If you remove the page-specific URL from the AFT5 page link, it breaks. [18:12:34] Looks like you get that bug just going to the page without a pagename in the url. [18:12:37] yeah [18:12:39] That's an easy fix. [18:12:43] cool :) [18:12:47] Thanks, Gregchiason, you are three steps ahead of us! So does Roan know about these user rights? [18:13:00] Which I suppose raises the question of why I didn't fix it in the first place, but that's neither here nor there. [18:13:46] how are we controlling who can get to it, btw? [18:14:00] because one interpid user is currently fiddling through the source code looking for how access is permitted [18:15:16] OK, http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/ shouldn't be erroring horribly anymore. [18:15:59] woah! [18:16:03] gregchiasson: fast fix! :D [18:16:21] What I lack in doing things right, I try to make up for in fixing problems quickly. [18:17:00] hehe [18:17:28] you're getting no complaints from me :). So, how are we stopping any bozo from finding the page? [18:20:06] ...anyone? [18:20:50] We aren't. Far as I'm aware the requirements were just for not linking or publishing anything - security through obscurity, basically. [18:20:56] ahh, gotcha [18:21:08] Thanks, gregchiasson. Ironholds, I believe we cannot prevent bozos from finding the page, I'm afraid. That's why it's labeled 'BETA.' [18:21:10] balls [18:21:15] fabriceflorin: indeed [18:21:52] fabriceflorin: just finishing up the report [18:22:03] Dario didn't manage to get a final round of stats to me until midday today GMT, so... [18:23:08] OK, thanks. Let's try to do as much as we can for the report, and review with Howie at 4pm PT. It will be an informal meeting. [18:23:33] 4pm PT? [18:23:50] you mean the presentation slot? [18:27:50] Sumanah, thanks for the reminder. I just updated our status page for Guillaume's report. https://www.mediawiki.org/wiki/Article_feedback/status [18:28:07] Thanks, fabriceflorin! [18:28:39] You're welcome, Summanah, and thank you for keeping us honest! [18:28:56] fabriceflorin: :-) in that case, https://www.mediawiki.org/wiki/Article_feedback/Log is looking a little stale too.... [18:29:25] Ironholds, yes, the only time we could get to review both the slides and the hand-out with Howie is 4pm PT today, sorry. [18:29:26] fabriceflorin: and you can let me and chrismcmahon know when you have test plans + a page you want to be available to volunteer testers [18:30:05] sumanah: fabriceflorin agreed, I've been lurking on this conversation, if there's anything I can help with about testing, I'd be glad to [18:30:22] fabriceflorin: you may have heard that chrismcmahon is our new QA lead [18:30:25] :D [18:30:38] fabriceflorin: okay. I only got to sleep at 2am and woke at 4, so you should be aware that I may be about as useful as a marzipan sledgehammer [18:30:44] although substantially less delicious [18:30:47] *chrismcmahon has been drinking from the firehose yesterday and today, learning a lot quickly [18:30:57] Thanks, Sumanah, will update the log too, after this launch. And will let you and chrismcmahon know when we have test plans. Our target date is Feb. 15 for pre-deployment testing on en-labs, then full deployment on Feb. 22. [18:31:38] *sumanah updates status [18:31:40] Chrismacmahon, nice to meet you here. What's your email address, so I can forward some of our QA plans to you? [18:32:10] fabriceflorin: ping me if feedback on the test plans early on would be useful, also. [18:32:10] Hey, has anyone heard from RoanKattouw_away ? or the real RoanKattouw? [18:32:25] fabriceflorin: I'm cmcmahon at wikimedia [18:33:04] fabriceflorin: I'm here, I was having dinner [18:33:56] fabriceflorin: btw, you may enjoy tab completion in IRC. Works like on the UNIX command line. [18:36:09] sumanah: that may not help. fabriceflorin is a dedicated mapple user ;p [18:40:08] Welcome back, Roan! From your perspective, are we ready to deploy AFT5, with the new feedback page? [18:40:12] Ironholds: fabriceflorin I'm using Colloquy on Mac and tab completion works just fine :) [18:40:24] fabriceflorin: I still have some CR to do [18:40:31] And I see unresolved fixmes [18:40:44] chrismcmahon: sure; I more meant the point of reference may not work [18:40:47] oh, wait, this one is resolved [18:41:28] Thanks, RoanKattouw. GregChiasson, can you give us an update about which of Roan's requests were addressed yesterday? [18:46:08] ChrisMcMahon, I just sent you our QA plans by email, and look forward to your feedback when you get a chance. And yes, I'm on a Mac, using Colloquy. [18:46:43] thanks fabriceflorin reading those [18:47:18] chrismcmahon: i am currently leading the QA efforts from the omniti side, so feel free to cc me on your feedback [18:47:33] thanks yoni_omniti will do [18:48:08] Hi Ironholds, I'm pretty sleep-deprived as well, so we will try to make that meeting short and sweet. If you need more time for the report, we may be able to only release the slides tomorrow, since they are easier to put together -- and easier to discuss one page at a time. Then we could release the longer report later in the week, with all the detailed narrative, if you like. There is no big time pressure on our end. [18:48:27] Most of the fixmes were fixed, there are just a couple left: 110407 is about not escaping a Linker argument (which I think might be, I left a note on Roan's comment there), and a lingering one on 109971, about an asset URL. [18:49:06] There's also an issue with the way the pagination works when sorting by helpfulness/rating, that I'm looking at now. [18:49:11] Yes, and I want to congratulate yoni_omniti for his excellent Master Test Plan, which is included in the email I just sent to ChrisMcMahon. Let's plan to all get together by phone next week ... [18:49:28] fabriceflorin: good idea [18:49:30] fabriceflorin: whoo! any reason we cannot put that testplan up on mediawiki.org? [18:49:39] yoni_omniti: ^^ [18:49:43] for use by the volunteers? [18:50:01] sumanah: the main reason for now being that I'm looking for a convenient way to convert docs into wikiformat [18:50:16] it takes me forever to author a simple document in wiki itself.... [18:50:25] guillom: maybe you know of an easy way to convert from .doc or .docx into wikitext? [18:50:30] Sumanah, we're still getting up to speed on using wikis for this, the wiki tables are nasty to implement, so it's faster to start with email. But we will put all this on a wiki shortly. [18:50:42] uploaded PDF also works [18:50:45] just to start with [18:50:48] converting is done by a bunch of tools, images are more of a problem [18:50:52] sumanah, there are scripts / plug-ins to convert ODPs to wikitext [18:50:57] I'm looking forward to the visual editor [18:51:04] so if you can open your doc / docx in LibreOffice, you should be able to [18:51:14] uploading a pdf has the (dis)advantage of other people not being able to modify it [18:51:18] True. [18:51:45] But right now I just want the test plan avail for people to follow - that should be a pretty 2-min thing to do and then we can work on making a reasonable wikified thing [18:52:01] guillom: libre messed up my ms office install, found something more lightweight - trying it out [18:52:23] sumanah: ok, can do [18:52:34] you can also fwd to someone with lbreoffice and ask them to do it for you -- guillom seems to have volunteered (just kidding) [18:52:43] heh [18:52:52] chrismcmahon: you with me? your opinion is going to be more important than mine on these matters pretty soon [18:52:54] another question: who handles SVN commit access accounts in WMF? [18:52:58] I do [18:53:13] expect requests :) [18:53:14] you might have seen "sincerely, Sumana Harihareswara" on some emails from the commit access address [18:53:24] yoni_omniti: understood. [18:53:36] sumanah: ^^ seen it :) was making sure I'm not wrong [18:53:39] we generally run through those requests in a queue processing meeting on Tuesdays [18:53:45] No prob :) [18:53:55] yoni_omniti: if anything's more urgent than that, feel free to ping me [18:54:05] cool, thanks [18:54:25] I live in New York City and if I'm not around, often Tim Starling or Sam Reed can help you, as they are in Australia and England respectively [18:54:40] (in case anything is very urgent) [18:54:45] I'm in MD so our timezones match [18:54:58] Cheers! [18:55:20] https://www.mediawiki.org/wiki/Developers is a directory you may find useful. [18:55:38] great [18:55:41] needed that [18:56:01] yoni_omniti: http://toolserver.org/~krinkle/wikimedia-svn-users.php is more informative on names and addresses but doesn't tell you what people work on [18:56:34] yoni_omniti: I assume you've also been pointed to https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture and http://www.mediawiki.org/wiki/Roadmap [18:56:41] to the extent that you want or need them [18:56:42] sumanah: it does include what people filled in on "project" in there USERINFO file under "Work" column [18:56:56] (never mind) [18:57:06] Krinkle is superiour, all hail Krinkle! [18:57:07] (links overload)... [18:57:14] :) [18:57:16] *Krinkle Dinner [18:57:18] dinner time! [18:59:21] Bon app??tit, Krinkle! [18:59:32] thx [19:00:18] Hey Roan, how are things coming along on your end? Can we help you with anything? [19:00:25] I'm almost done CRing [19:00:33] so guillom, for https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/January the ones you're missing are Upload Wizard, TimedMediaHandler, ResourceLoader, SOPA stuff, and a bunch of mobile updates? [19:00:35] Cool, thanks. [19:01:23] Hello HowieF, Roan is still reviewing code. We're all here to help him with any questions, with three OmniTI developers on this IRC channel. [19:01:43] hi howief ! [19:02:08] sumanah, yes; currently discussing it in the monthly review session with tech directors [19:02:31] oh ok! [19:02:32] nm [19:03:05] hey everyone [19:03:07] thanks for the update! [19:04:25] You're welcome, HowieF. We have been using the last hour productively, by discussing our QA plans with Sumanah and ChrisMcMahon, who is also here. [19:04:49] great [19:05:27] I would also like to thank Guillom for his patience and guidance in helping me update the status page for AFTv5. [19:05:44] fabriceflorin, you're welcome :) [19:07:01] ;o) [19:12:00] fabriceflorin: on two servers now I've seen an article feedback widget entitled "rate this page" that I don't think is mentioned in the docs you sent me. is the "rate this page" widget in its final form, or is it still being worked on? [19:12:55] Hi Chris, good question! There is an earlier version of the Article Feedback Tool, called v4, which is still running for another month or so, until AFTv5 is ready for wide deployment. [19:13:30] got it [19:13:32] You can read about AFTv5 here: http://www.mediawiki.org/wiki/Article_feedback/Version_5 -- and read about AFTv4 here: http://www.mediawiki.org/wiki/Article_feedback [19:14:56] And here is the feature requirements link for the feedback page which we hope to launch today, when Roan is ready (this is for a limited, non-public release, for testing by our team and community workgroup only): http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_page [19:15:29] <^demon> fabriceflorin: http://www.mediawiki.org/wiki/Article_feedback/Version_[1-4] don't seem to exist ;-) [19:16:07] ^Demon, here's the link to AFTv4 info: http://www.mediawiki.org/wiki/Article_feedback [19:16:32] I seem to have been seeing Version 2 in the places I've been hanging out. (labs mostly) [19:16:59] If you want to preview AFTv5, go to this sample page on en-wiki: http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=1&debug=true [19:17:20] <^demon> Oh I don't go to enwiki anymore :) [19:17:51] <^demon> fabriceflorin: I was just giving you a hard time ;-) [19:17:56] To switch between the 3 options we are testing for AFTv5, simply change the bucket number in the URL to be 1, 2 or 3. Here's Option 2: http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=2&debug=true [19:18:07] ^demon hehe! [19:18:27] And here's Option 3: http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=3&debug=true [19:19:29] You can read up about the three different forms here: http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Option_1 [19:20:22] OK, CR is done [19:21:00] I'm gonna go to the bathroom real quick, and then I'll prep the deployment [19:21:16] Yeah, Roan! [19:21:36] <^demon> RoanKattouw: You don't have to give us the play-by-play ;-) [19:22:02] *RoanKattouw dumps some TMI on ^demon [19:23:12] Feels good not to be on top of the Wall of Shame for once. [19:24:19] <^demon> Well I named it that for a reason. Glad to see it had the desired effect :) [19:24:19] sounds like it's safe to take a short break, back in a few... [19:26:58] Hey Greg and Yoni, from your standpoint, what are the next steps for Roan before deployment? Should he first set up the 'aft' user group? Then assign user rights to it and to all the other user groups? Then deploy the code? Or do you recommend another sequence? [19:28:47] aft user group? Are we not just using Rollback, Reviewer, sysop and oversight? [19:28:59] Also, Yoni_omniti, can you please email us all your English Wikipedia user names, so we can put you guys in the 'aft' user group? [19:29:16] There's supposed to be an AFT group that has the same rights as oversighters on the AFT page. [19:29:32] Yoni_OmniTI, gchiasson, rsterbin [19:29:37] err [19:29:38] <^demon> Wait wait wait....a new group that has oversight permissions? [19:29:41] scratch that [19:29:43] I'm actually Gregchiasson [19:29:46] will email correct ones [19:29:51] ^demon: yes [19:30:08] Have we concensus for that? [19:30:09] it's a temporary test group for the staffers and contractors dealing with AFT5 before the feedback page is deployed publicly [19:30:14] ^demon: Not actual oversight, only for AFT comments [19:30:15] ^demon: it's only oversight on the AFT5 page, IE, they can delete posts, they're just regular joes outside of the AFT5 context. [19:30:16] at which point actual oversighters will be asked [19:30:18] Hi Jamietw, we need to give our team special permissions so we can test the software for the next couple weeks, during this limited, non-public testing period. But this will NOT give us oversight rights, just the right to 'delete' feedback posts during the testing period. [19:30:30] <^demon> RoanKattouw: Then why the connection with oversighters? [19:30:31] Ok. [19:30:35] <^demon> Rights should be separate... [19:30:38] Thanks for that. [19:30:50] ^demon: because when the feedback page *is* publicly deployed, OSers will need to be able to delete comments [19:30:50] It's conceptually the same thing as oversighting, except it's for comments rather than page edits [19:30:55] We discussed this in IRC chats with the community, and they understand that this is just a temporary user right, for testing purposes. [19:30:57] Don't blame me for the confusing nomenclature :) [19:31:10] It'd be more confusing to keep calling it "delete" [19:31:15] <^demon> Confusing names are confusing. [19:31:21] ever tried explaining to a group of admins why we're saying they won't be able to delete stuff? [19:31:22] it's not fun [19:31:36] <^demon> RoanKattouw: As long as you're on top of it. I just saw 'oversight' group and did a double-take. [19:31:55] ^demon: trust me, we know all the community pitfalls :) [19:32:07] Thanks, Ironholds, we can discuss this in coming days, during the non-public testing period. Right not, the compromise is to call this feature 'Delete (oversight)'. [19:32:14] ...right. [19:32:22] so we will successfully confuse *everyone*. [19:32:27] OK, I'm gonna start merging stuff into the branch and deploying it to test [19:32:41] Let me know which users should be put in which group and which rights that group should have [19:33:19] <^demon> 'Delete (oversight)' is so completely confusing to me it's not even funny. I really hope that gets fixed. [19:33:23] *^demon wanders off to find lunch [19:33:25] Thanks, Roan. I will send you the user names by email. [19:33:38] ^demon: agreed. I'm sure we'll discuss it at our meeting at 4 [19:33:39] Yes, ^demon, this will get fixed. Be patient. [19:40:14] Hi Roan, I just sent you the user names for the AFT group and Cc:d all the folks who would get these temporary user rights. Please let me know if you have any questions. Thanks! [19:40:33] OK, thanks [19:40:54] There's a couple of other permissions, actually. [19:41:37] I split aftv5-see-hidden-feedback and aftv5-see-deleted-feedback out - I can make them one permission if that makes sense. [19:42:30] fabriceflorin, the list of user names you sent through contains personal accounts rather than staff accounts [19:42:37] we do not cross the streams [19:43:13] you need Okeyes (WMF) and Jorm (WMF) instead of Ironholds and Jorm, at least. I know some staffers don't have staff accounts, which makes legal rather antsy, but que sera. [19:43:19] OK, could you please respond to the email and suggest office accounts instead? [19:43:24] sure [19:44:05] done [19:44:33] But let's try not to hold up launch with technicalities like these, which can be fixed tomorrow, if need be. We're already approaching the end of our scheduled deployment window. ;o) [19:46:14] fabriceflorin, the "technicality" is "we are not allowed to conflate our actions as volunteers and our actions as WMFers, or legal gets finnicky" [19:46:32] and given that switching two usernames will take approximately 5 seconds, it's hardly a big time-sink [19:47:05] Got it. I will aim to create a WMF account when I catch my breath. [19:48:05] For now, let's launch this puppy, so we can test this puppy! Also, please do not share the URL to the feedback page on this IRC chat, so that it remains non-public for now. Use email instead. [19:51:31] OK deploying to test now [19:52:30] Thanks, Roan. Let's share the URL by email, so we can test it there. [19:52:42] Oh, hah [19:52:47] I guess I need to make the special page unlisted [19:53:04] That would be a good idea. [19:53:26] :P [19:54:31] Yes, please. [19:56:36] sumanah: Will do. [19:56:46] thanks Amgine [19:56:53] I just emailed the URL to the A [19:57:03] ??? to the AFT team. [19:57:40] OK so what I have is this [19:57:42] $wgGroupPermissions['afttest']['aftv5-delete-feedback'] = true; [19:57:43] $wgGroupPermissions['afttest']['aftv5-hide-feedback'] = true; [19:57:45] $wgGroupPermissions['afttest']['aftv5-see-deleted-feedback'] = true; [19:57:46] fabriceflorin: erm. it's broken for me ;p [19:57:47] $wgGroupPermissions['afttest']['aftv5-see-hidden-feedback'] = true; [19:57:57] the first piece of feedback is distorted and moved to the right [19:58:37] Ironholds, can you send us a screenshot by email, and let us know what browser you are using? I cannot reproduce on my end. [19:58:49] 9.0.1, as with the other 3 bugs I reported, and am doing so now [19:58:57] fabriceflorin: are you & your team interested in using the crossbrowsertesting site that we have a license to use? [19:59:05] works on safari, with a few minor glitches [19:59:10] What browser? [19:59:20] and mouse-over on the flag as abuse button *still* produces the text-typing cursor [19:59:23] which is tiny but frustrating [19:59:54] there also appears to be an error with the yes/no buttons; if I unselect "no", it moves the number of nos *up* [20:00:35] Ironholds: there is a bug??? it updates, but lags 1 action behind [20:00:54] yoni_omniti: ahh [20:00:57] oh dear [20:00:58] Now putting people in the aft group on test [20:01:01] Ironholds, let's get in the habit of reporting bugs more formally, rather than piecemeal in IRC. Can you send a detailed email with a paragraph for each bug, describing how you got these results? Thanks, [20:01:24] Ironholds: or just file it in BZ, and we get the eamil automatically [20:01:28] *email [20:01:28] Thanks, Roan. [20:01:33] you want a paragraph on how I found a mouseover bug? [20:01:33] There is no user by the name "Yoni OmniTI". Check your spelling. [20:01:36] I moved my mouse over it. [20:01:45] RoanKattouw: with an underscore [20:01:48] Who's Epochfail? [20:01:48] a paragraph can be one sentence long :-) [20:01:57] yoni_omniti: Underscores and spaces are the same thing in MW usernames [20:02:06] I entered it with an underscore, no difference [20:02:09] EpochFail is Aaron, who is working on the research for feedback evaluations. [20:02:21] Oh, I'm doing this on test, your account would be on en only, maybe, I guess [20:02:28] Ditto for rsterbin [20:02:44] RoanKattouw: just logged in to test with this account [20:02:58] You are now logged in to Wikipedia as "Yoni OmniTI". [20:03:03] AH, yes [20:03:05] Now you exist [20:03:13] Accounts on other wikis are lazy-created [20:03:21] good to know [20:03:40] Thanks, Roan, I am able to get access to the tools now and they work as intended. [20:03:50] rsterbin, gregchiasson : ^^ FYI [20:04:00] Yup, I have all the admin stuff. [20:04:25] i do not [20:04:49] Your account didn't exist when I tried [20:04:51] Let me try again [20:04:55] thx [20:05:21] all please flag fabric's last post as abuse - so i can test autohide ;) [20:05:22] And the tools are correctly hiding or deleting/oversighting the posts, apparently. [20:05:28] fabrice's * [20:05:51] ooh [20:05:55] mine auto-hid it [20:06:05] *undoes so yoni can do it* [20:06:10] the "all visible" bug is still there [20:06:15] I'm on Firefox 9.0.1 and the first feedback item is inverted to the right of the others. [20:06:18] lol, maybe not [20:06:21] ack. I'll report now [20:06:24] Yes, auto-hide seems to work. My post was hidden after we reached 5 flags. [20:06:41] May I unhide it now, to see if that works? [20:06:45] Ironholds: thats a new one. the previous one was about the counter in abuse flag [20:06:57] fabriceflorin: please do [20:07:01] yoni_omniti: that was the issue i sent you a screencap of [20:07:06] the one that only i could make happen [20:07:16] you're special [20:07:17] ubuntu/firefox [20:07:18] rsterbin: the showing: bug with the infinite number of comments? [20:07:24] awesome, I don't have to submit my screenshot :P [20:07:27] FWIW I'm on FF9.0.1 on a Mac, and it looks fine - it's apparently unique to Windows or Linux FF? [20:07:33] no, the one jamietw just reported [20:07:36] I'm getting the same one on windows/firefox, and on xubuntu/firefox [20:07:38] ahh [20:07:39] damn! New bug. [20:07:41] rsterbin: please open a BZ bug if there isn't one already [20:07:45] OK, I just showed that post again, even though it had been flagged 7 times. [20:07:47] will do [20:08:01] fabriceflorin: is that not the intended behavior? [20:08:03] It's visible nagain. [20:08:11] I'm on Windows [20:09:05] actually, jamietw, can you report it? it was fixed for me a couple of revisions ago [20:09:17] Thanks, Jamietw. Sadly, I cannot reproduce on a Mac. Can you please email a screenshot to me at florin@wikimedia.org? [20:09:17] so my screencap is out of date [20:09:26] Sure. [20:09:45] fabriceflorin, I've already sent a screenshot through for the same bug [20:10:02] thanks [20:10:21] RoanKattouw: thanks, i've got access to tools now [20:11:19] yay [20:12:42] I apologize for using foul language for my last post, but wanted to show examples of feedback that should be hidden right away. [20:12:49] fabriceflorin: are we missing the Zoom meet, btw? [20:13:00] nobody has bothered to skype me in. was it moved, or has howie forgotten I exist again? [20:13:27] Yes, we are. Duty first. We have a major milestone to launch, and I warned Howie that I might not be able to attend. He understands. [20:13:32] yup [20:13:44] I was more thinking "I'm meant to present a community engagement plan and can't" [20:14:23] I know, we are all over-stressed, with unrealistic deadlines. Let's get this puppy out the door, then we can move on to next steps. [20:15:52] sure, but I can't really do anything useful in deployment. I'm not a 10.times do print "coder", but I am a community liason. I should be liasing. [20:16:07] you actually know what you're talking about, and are thus useful here. I don't and therefore aren't ;p [20:16:13] fabriceflorin: I have sent the screenshot. [20:16:35] Oh, well in that case, you are welcome to go to the meeting, then. But I can't. [20:17:00] Thanks, Jamie and Oliver, for sending the screenshots. Yoni, do you want me to file that bug, or will you? [20:17:12] i will take care of that [20:17:36] i am aggregating them all, later today i will sort them out, verify duplicates and file bugs [20:17:44] fabriceflorin: So, what's up with the deploy timing? I hear there are some bugs? [20:17:52] Thanks, Yoni, much appreciated! [20:18:39] Hi Roan, there are minor bugs, but none of them are show-stoppers for this limited, non-public release. Yoni, do you know of any serious bugs that might affect performance on en-wiki? [20:18:56] nothing here [20:19:13] for a beta release were ok [20:19:16] OK, well if and when I'm good to go to deploy to enwiki, tell me [20:20:02] I think we are ready to deploy to en-wiki, based on the testing we did so far. Yoni, are you comfortable with this recommendation? [20:20:11] i am [20:20:26] Good. So Roan, you have our go-ahead to proceed. [20:20:32] best way to test further is to have actual users to use this [20:20:39] OK [20:22:06] Yes, I agree. Roan, if we need to update any patches tomorrow, would that be an option? If not, when is our next opportunity for updates? Next Wed. Feb. 8? Or the the following Wed. Feb. 15? [20:22:19] Tomorrow is fine [20:22:26] After that, Wed Feb 8, yes [20:22:30] i would advise against planning for tomorrow [20:22:36] I'm traveling on Monday and am taking the day off on Tuesday [20:22:47] Feb. 8 sound reasonable time to gather bugs, fix them properly, and test again [20:23:09] Thanks for your flexibility, Roan. We will aim for Feb. 8, unless we find anything critical overnight. [20:23:30] Yoni, we will follow your lead on the testing plan. [20:23:39] Code is now live on enwiki [20:23:39] ok [20:23:51] lets do q quick sanity test on enwiki [20:23:52] 1 PHP Warning: Invalid argument supplied for foreach() in /home/wikipedia/common/php-1.18/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5Utils.php on line 199 [20:23:54] 1 PHP Warning: Invalid argument supplied for foreach() in /home/wikipedia/common/php-1.18/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5Utils.php on line 180 [20:24:08] I haven't promoted people into the aft group on enwiki just yet, do you want me to? [20:24:09] Thank you, Roan! Everyone, I will send you the URL by email. [20:24:26] gregchiasson: please take a look at the code [20:24:55] Apparently that happens if aft_article_filter_counts is empty. [20:25:09] aft_article_filter_count, actually, singular. [20:25:16] It shows up in the search box. Any way around that? [20:25:36] No [20:25:48] The page is there, so it's in the search results [20:26:13] also, i'm getting "not enabled" message for pages in AFTv5 category [20:26:19] Hey, guys, I can't access the Golden sparrow page on en-wiki, even though it is part of the correct category. [20:26:25] Same. [20:26:49] Same. [20:26:50] What's the name of the golden sparrow page again? [20:27:02] It does work for Bluetooth however. [20:27:06] Golden-crowned_Sparrow [20:27:30] fabriceflorin: It's in the additional articles category [20:27:35] $wgArticleFeedbackv5DashboardCategory = 'Article_Feedback_5'; [20:28:15] I also want to point out that we apparently did not launch the revision that switches the CTA from Survey to [20:28:28] We didn't not launch any revision [20:28:29] ??? that switches the CTA from Survey to Edit. [20:28:35] I deleted the AFTv5 extension and copied it from trunk [20:28:51] There is absolutely no way anything was left out [20:28:59] fabriceflorin: that is now a config variable [20:29:05] i did not change the default [20:29:09] That was the revision that Reha prepared for us a couple days ago. rsterbin, was it not included in this release? [20:29:22] It was, I just didn't configure it [20:29:55] Aaah, that explains it. Do you need help from Reha to configure it? [20:30:14] RoanKattouw: to switch from survey to edit, make $wgArticleFeedbackv5SelectedCTA = 1 [20:31:06] done [20:31:12] thx [20:33:32] Meanwhile, I figured out why the Golden Sparrow Feedback page still doesn't show up for me for me. It's in the "additional" category, not the main random article category. [20:33:59] I am sending you a URL by email now to the Drew Barrymore page, which is in the AFT5 category. [20:34:26] drew barrymore doesn't have feedback page for me, for some reason [20:35:52] I just sent you the exact URL, and tested it on several browsers. Works for me so far. [20:37:28] yoni_omniti: fwiw, I see the feedback page on drew_barrymore FF/OSX and Chrome/OSX (although it took a second or so to load, esp. for Chrome) [20:37:33] And thanks, Roan and Reha, the CTA works fine now. [20:37:51] yay [20:37:55] ok now works for me too [20:39:02] Please forgive my foul language in my last post on Drew Barrymore -- I am trying to replicate actual use cases. ;o) [20:39:32] Can you guys post more comments on this page, please? en.wikipedia.org/wiki/Drew_Barrymore?bucket=1&debug=true [20:40:14] Can a user from editing Wikipedia completely just for posting offensive feedback but not actually making any offensive edits? [20:40:16] *AaronSchulz want's to see the language now [20:40:31] Note that you have to use Option 1 (bucket=1), because we do not accept Option 2 or Option 3 for this test. (I verified that we don't) [20:40:35] *wants [20:40:49] RoanKattouw: i don't have the tools box on en [20:41:17] Yeah I didn't actually promote anyone on en yet [20:41:29] Lemme do that in a second, I'm dealing with another (non-AFT related) issue nwo [20:41:58] Hey Chris, I am so glad you are testing alongside with us! Way to go on your first week ;o) [20:44:33] I don't think that we have a thorough test plan for this feature yet, so just try to make things break for now. For example, multiple clicks on the same link, weird use cases, etc. We are all filing bugs on Bugzilla, under 'Article Feedback 5' then sub-category 'aft5-1.5'. [20:45:26] Hey Aaaron, I think I included you in the email with the URL. Did you not see the foul language? Let's all flag it, to see if auto-hide works as intended. [20:45:50] Is the toolbox working for rollbackers yet? [20:49:29] Not yet, Jamietw. At least not for me. Are you a roll backer, reviewer, admin or overnighter? [20:49:59] Sorry, I meant to say 'overnighter', but my spell check program always says 'oversighter' [20:50:40] heh [20:51:53] fabriceflorin: Rollbacker, Reviewer, File mover, account creator. [20:52:32] Awesome, Jamietw. So glad you are here to help us test this, it's really nice of you! [20:52:56] fabriceflorin: sent you 3 comments with strange inputs [20:59:24] Thanks, Chris. It was great of you to try all these different use cases, with really long comments and special characters. They all display well for me. Be sure to email us any bugs at florin@wikimedia.org and to Yoni Shostak . I am also adding you to the test email list for this launch, so you will be part of that thread going forward. [20:59:34] Sorry about that. [21:00:09] No worries, Jamietw. Welcome back. Are you still experiencing the same issue on Firefox for Windows? [21:01:05] thanks fabriceflorin . is it correct that the "What's this?" info box persists after submitting text? that seems odd, but not actually wrong. [21:01:23] chrismcmahon: hi! Welcome! [21:01:25] Should they be fixed? [21:01:54] hi alolita nice to be here! [21:02:13] glad to see you join the team :-) [21:02:22] when are you in sf [21:02:58] alolita: not sure. my understanding is that I'll establish a little context for myself before visiting SF, so as to make the most of the visit. [21:03:17] makes sense :-) we've got lots to do [21:03:19] Good bug, Chris! No, the What's this box should close when you post feedback, you are right. [21:05:04] well good :-) [21:05:06] Do we have any plans for tablet support? [21:06:06] Jamietw, so far we are not supporting mobile for this limited test. Here are the platforms we now support for AFT5: http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Platforms [21:07:06] Ok, just I am now using my iPad rather than my computer. [21:08:45] fabriceflorin: another odd thing. is is correct that text may be submitted without the user having clicked "Yes" or "No"? the "Post your feedback" button is enabled only upon entering text in the textarea [21:08:49] Yes, we hope to add IOS support in a month, once we get all the kinks out of the desktop platforms. But unofficially, IOS seemed to work well before we disabled AFT5 for unsupported platforms. So we don't expect iPads to be hard to support. [21:09:27] Yes, Chris, we purposely wanted to allow people to post text only for this test, to see what they naturally want to do. [21:10:05] fabriceflorin: also, add text to textarea, then make textarea blank again, "Post" button remains enabled. [21:10:20] that's probably really minor [21:11:34] If a lot of people use that feature, we may keep it, Chris. [21:12:01] aha, but the blank comment doesn't go through, it just re-loads the widget. works for me. [21:12:14] Hey Yoni, are you capturing all these little bugs for Bugzilla, or should I? [21:13:25] reloads the widget with new msg "Please enter your feedback", so that's probably by design. [21:13:39] chrismcmahon: hm, that may be a bug. do you have firebug / console / whatever on your browser? [21:14:00] everything that gets emailed to me will be entered in BZ [21:14:29] rsterbin, yeah, firebug etc. are available [21:14:57] Chris, we are mostly focused on the feedback page right now, and will turn back to feedback forms once we have selected a winner between the 3 options we are testing now. You are welcome to take our survey for which feedback form you think we should use: https://www.surveymonkey.com/s/aft5-4 [21:15:15] do you see a xhr request when you do that? [21:16:08] and/or any error messages [21:16:41] OK, yoni, I didn't realize you wanted this emailed to you. I will comb the IRC chat log later today to send you items that I think should be bugs. I can also send you notes for the most critical items. I assume you already have the problem with the Yes / No buttons not incrementing the counters properly, rights? [21:16:55] yup [21:18:10] Which of the bugs you have now do you think are most critical to fix first? Should any be pushed to production tomorrow? [21:19:15] rsterbin: yes, I'm seeing X-Requested-With XMLHttpRequest for the Request Headers on the POST, no error msgs. [21:19:24] maplebed: can set up a swift user besides mw:thumb for MediaWiki itself to use? [21:20:06] chrismcmahon: what's in the post for that request? there should be a clicktracking one, but not an articlefeedback one [21:20:07] sure, I suppose. what for? [21:20:25] maplebed: so that SwiftFileBackend::setContainerAccess() can be used as new containers are made [21:20:35] Wikipedia Chooses Lua As Its New Template Language [21:20:36] the user would need to be admin though [21:20:43] http://developers.slashdot.org/story/12/02/01/1429229/wikipedia-chooses-lua-as-its-new-template-language [21:20:45] otherwise it can't set ACL [21:20:53] that made it to the Slashdot home page [21:21:10] AaronSchulz: the mw:thumb user can set access permissions on containers it creates. [21:21:21] (see http://wikitech.wikimedia.org/view/Swift/Setup_New_Swift_Cluster#make_the_containers_readable_by_anonymous_users) [21:21:39] maplebed: I wan't to restrict stuff *from* mw:thumb [21:22:55] hrm...that might work if some mw:mediawiki user or something created the accounts [21:23:03] AaronSchulz: yes, that's possible and a very good plan. [21:23:08] I mean "containers" [21:23:14] I'm busy for several hours, but maybe you can play on the eqiad cluster to make it work? [21:23:29] all the bits on how to create users are in the link I just tossed in here. [21:23:29] rsterbin: http://pastebin.com/bgC1Y66q helpful? [21:24:25] chrismcmahon: yep, that's the clicktracking call [21:25:06] so you're getting no error message when you try to submit an entirely blank form -- no buttons clicked, no text? [21:25:14] hmm [21:25:28] rsterbin: yep. headers look normal, and that's the only contents of the post, and no errors... [21:25:53] there should be a dark red message appearing just under the title telling you that you need to put *something* in [21:26:10] on the form, i mean [21:26:14] the xhr request is fine [21:26:43] rsterbin: upon submitting an empty textarea, user sees a *new* message in a new widget saying "Please enter your feedback". so I figure that's by design. [21:26:55] oooh [21:27:26] so the error message is there, it's just randomly reloading itself? [21:27:36] that is all kinds of weird [21:27:56] not randomly, only upon entering a completely empty message. otoh, entering a message with all spaces succeeds :) [21:27:59] Thanks, Roan, awesome! I can access all the tools now, and they work as intended. [21:28:20] how do you know it's reloading the whole widget? [21:28:31] because it really should not be able to do that [21:29:28] (btw, entering all spaces is considered acceptable right now. just sort of pointless.) [21:29:33] rsterbin: the message makes sense in context: 1) tricky user tries to enter empty msg. 2) "Post" button goes back to disabled and red msg. appears. 3) user must enter text to post [21:30:30] disabling the form != reloading the widget [21:30:48] rsterbin: true, I misspoke. [21:30:49] so i think we're cool [21:31:10] rsterbin: agreed [21:31:26] except for the bit where we wasted time tracking down a feature ;) [21:31:35] fabriceflorin: Which user groups can do what in the testing phase? [21:31:54] rsterbin: well, I'm new here, I'll get better fast I'm sure. :) [21:32:19] no worries -- it was my bad, jumping on wording [21:32:46] One more thing, guys: could we add the 'Additional Articles' category to the authorized article list for the feedback page? These would be the articles on this page: http://en.wikipedia.org/wiki/Category:Article_Feedback_5_Additional_Articles [21:33:23] Sure [21:33:26] rsterbin: just btw, I'm a fanatic about making great bug reports, do let me know if I say something unclear or imprecise, I'm all ears. [21:33:31] I seem to recall Howie convincing you not to do so though [21:33:41] awesome :) [21:33:46] I'd like to start testing this tool right away on the Obama and Mitt Romney pages, to see how the tools work with controversial content. [21:34:02] is there a way to disable a user's mediawiki account with a maintenance script or something? [21:34:12] OK well whatever [21:34:20] You're in charge here :) [21:34:29] Oh, hmm [21:34:38] The code isn't written to allow for multiple categories [21:34:41] fabriceflorin: right now the special page can only do one allowed category at a time. greg will have to update to allow multiples. [21:34:48] I'll fix that, yeah. [21:35:01] Wait, no, it is [21:35:03] No worries [21:35:10] It's all good [21:35:44] Yeah, I guess if you put an array in there, it'll accept that? [21:36:29] yeah [21:37:57] Thanks, Greg, that would be great, if it's not too much trouble. [21:38:25] Done [21:39:16] Roan, as per my last email, I think we are going to need a second 'AFT-hiders' user group, which would only give hide privileges, not delete/oversight. Would it be possible to set that up, for testing purposes? [21:39:59] Otherwise, we are only testing the overnighter view, not the roll backer view, which is much more important, given the much larger number of users affected by this. [21:40:02] Sure [21:42:49] fabriceflorin: can you not just let rollbackers hide like it will be when it is public? [21:43:44] Thanks, Roan. Once that second group is created, who could we ask to add/remove names on either group? Or could you grant that right to one of our team members, in your absence? [21:44:31] Jamietw, it's not practical for us to rely on roll backers to do the testing for us. We need that right to debug the feedback page in coming weeks. [21:44:47] True. [21:45:41] That said, we would love to get your impressions of the feedback page in this pre-release stage. Are you able to access the Hide tools? Do they work for you? [21:46:12] fabriceflorin: How about you create one test account that i [21:46:28] then put in that group? I don't want people's group membership to change all the time [21:46:37] This isn't a test wiki after all, it's production [21:47:26] I understand, but the only way we can test this fully is with actual content, in an environment that completely mirrors the encyclopedia. This would only be for a few weeks. [21:47:48] Sure [21:47:56] Fabriceflorin: I. Ant [21:48:11] So how about setting up a shared account that you use for testing the can-hide-but-not-delete stuff? [21:48:13] But I will create a new user account now, if I understand your request correctly. [21:48:20] Fabriceflorin, sorry I meant I can't seem to. [21:48:27] Yeah, and just share the password with the others [21:48:30] So you can all use it [21:48:41] Then all the group memberships can remain fixed [21:49:06] Ok, Roan, I will do this now and email you the info. [21:49:27] Does this not violate WP policy? [21:49:46] Explicitly declared sockpuppets are allowde [21:49:54] Especially if they don't edit [21:49:58] Jamietw, it is concerning that you are not getting access to the Hide tools, even though you are a roll backer. You definitely should have that access. [21:50:07] I didn't set up perms for rollbackers yet [21:50:16] That explains it. [21:51:18] Aaah, that explains it. Yes, we want roll backers, reviewers, administrators, oversighters, aft and aft-hide to have the aft-hide-feedback user rights. [21:51:41] OK [21:51:46] And who should have the delete rights? [21:51:53] And what about view-deleted and view-hidden? [21:55:28] Roan, we would like oversighters and aft only to have the aft-delete-feedback user rights. [21:55:54] And the view-deleted would also be only for oversighters and aft. [21:56:25] While the view-hidden right would be available to the same larger group as above: roll backers, reviewers, administrators, oversighters, aft and aft-hide [21:56:35] Does this make sense? [21:58:11] I don't really know or care what makes sense policy wise, I just wanna know what to configure :) [22:08:59] Hi Roan, these are the configurations we would like you to set up please, as outlined above. [22:09:11] Yeah, I just finished them [22:09:17] Will PM the config to you before I put it live [22:09:30] Also, I have created a new user account, so you can add that account to the aft-hide user group: http://en.wikipedia.org/wiki/User:Aft5hide [22:10:13] Ok [22:10:20] I emailed you all the relevant access info for this shared account, which will allow us to test only the hide features of the feedback page. [22:10:33] Once you OK my config and it's live, that'll create the aft-hide group and I can put the user in it [22:10:50] Splendid, thanks! [22:11:41] fabriceflorin: So please read and approve the config that I sent you in PM [22:14:15] Thanks, I am reviewing right now, forgive me for being a bit slow. [22:14:24] Sure [22:14:35] Just wanted to make sure you hadn't missed the PM, sometimes people don't see it [22:17:19] Yes, I had missed it, so thanks for reminding me. It appears to make sense, but I want to make sure that the afttest group can also hide, not just delete/oversight. I think that's what it does, just want to make sure. I am also sending that code via email to Yoni_omniTI and gregchiasson, just in case, and Cc:ing you. [22:17:53] Yes [22:20:10] OK. I just sent the email to you, Yoni_omniti and gregchiasson. Can you guys confirm that config makes sense? [22:20:17] I just deployed it [22:20:29] And put the test account in the right group [22:20:33] Thanks, Roan. [22:21:22] greg will take a look at it in a minute [22:21:28] Looks legit. [22:22:12] Thanks, guys. I can confirm that the new aft5hide account works as intended, only showing the hide tool, but nothing else. [22:22:43] Jamietw, are you still here? Can you see the hide tools now? [22:24:13] yoni_omniti: should I submit a BZ ticket for the "What's this?" info box persisting after submitting text, or is that in your list? [22:24:51] chrismcmahon: yes please, and attach a screenshot if possible. if its easily reproducible, please write down the steps [22:24:58] OK, I am able to access both the reader view, the roll backer view and the overnighter view on 3 different browsers, and they appear to work as intended. [22:25:02] yoni_omniti: will do [22:25:21] chrismcmahon: also, when you submit the bug, add aftv5-1.5 keyword so it appears in our filters [22:25:44] Thanks, Chris! Don't forget the category is 'Article feedback5' and the keyword is 'aft5-1.5'. Much appreciated! [22:26:03] oops [22:26:24] chrismcmahon: sorry, colloquy quit on me??? [22:26:39] just as i was going to thank you :) [22:27:40] Roan, thanks for all your hard work today! I'm sorry we kept you up past your bedtime ;o) [22:27:52] Sure, no problem [22:27:59] It's always a pleasure to work with you, you're a role model! [22:28:46] Krinkle: ping [22:28:56] Hi [22:29:21] i am making my first central notice banners [22:29:34] it's not difficult i know but... [22:29:41] *aude doesn't want to break wikipedia! [22:29:47] http://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Wikimania2012Scholarships [22:29:47] aude: where ? [22:30:01] aude: Please start on test.wikipedia.org, especially if you're new to it :) [22:30:04] it is a one line notice [22:30:26] My only remaining question is who could we ask to add anyone to the afttest group while you are away? [22:30:27] except for french and some languages on small screens will overlap, so a little javascript to make it size properly [22:30:36] fabriceflorin: Any enwiki bureaucrat [22:30:48] is that reasonable? is there some way i should do it better? or is it a bad idea? [22:31:03] *aude wants the banner smallish [22:31:09] I don't know any of those people but I'm sure Ironholds does [22:31:13] Cool. Do we know any enwiki bureaucrat on the WMF team? [22:31:53] Oh, if Ironholds can do this, then it's fantastic! [22:31:55] aude: This fails if one resizes the browser, I don't think javascript is needed here. at least worth a try in css [22:32:03] ok? [22:32:04] yeah [22:32:10] aude: are you making any changes right now ? if not I'll move it to test.wp for a sec [22:32:13] no [22:32:21] fabriceflorin: No, I don't think he's a bcrat [22:32:25] I'm saying he probably knows some [22:32:47] the text overflowing has been a long standing problem (at least for me) with fundraising banners [22:32:51] Anyway, you only need this on Friday [22:32:59] I'll be back by start of business PST on Monday [22:33:04] *aude would like it to be smarter [22:34:02] Got it. I wanted to add ChrisMacMahon to the afttest group, since he is helping us with the QA. Would it be possible for us to add him tomorrow, once I get his Wikipedia user name? [22:34:28] Either today (in the next 5 min) or tomorrow is fine [22:35:11] Thanks, everyone, for a job well done. Now let's start testing this new feature! Howie and I just looked at the Obama page and it's looking pretty scary. Glad we have these hide and delete features. [22:36:16] yoni_omniti: is there a trick to adding a keyword to a BZ page? I'm not seeing a field for that. [22:36:39] chrismcmahon: after you file the bug it takes you to the bug page, where you can add many more details, incl. keywords [22:36:47] yoni_omniti: ok, thanks [22:36:48] I want to ask anyone who has the hide and delete tools to USE THEM RESPONSIBLY. We are no longer testing our own gibberish, so we should only hide content that deserves to be hidden, and only delete illegal content, like personal contact info, email addresses, phone numbers, etc. [22:36:54] also, assign to me (yoni@omniti.com) [22:37:45] chrismcmahon: oh, btw, check for duplicates because i'm filing bugs too [22:38:22] having descriptive titles really helps because when you type your title for a bug it shows all similar bugs already there [22:38:32] Yoni, can you email us a quick list of the bugs you have already filed -- and the ones you are planning to file? We could also talk by phone if you prefer. [22:38:43] sure [22:39:07] i just finished going through my notes and the email threads, next in line is this IRC log [22:39:29] Yes, I have gotten in the habit of typing 'Article Feedback Page - ' in the title before the actual description of the bug, to make it easier to find them all together. [22:41:02] Here's a short URL that shows all current bugs for AFT5, phase 1.5: http://bit.ly/Aabg9s [22:41:40] yoni_omniti: https://bugzilla.wikimedia.org/show_bug.cgi?id=34134 , I don't seem to be able to change Assigned To [22:41:54] click (edit) [22:42:05] if you don't have the button, you need permissions [22:42:11] fabriceflorin: ^^ [22:43:15] yoni_omniti: I can only edit the Summary. [22:43:34] Then someone needs to give you permissions [22:44:03] that someone would be mark? [22:44:15] Mark Hershberger, yes [22:44:17] sounds reasonable, I'll check [22:44:21] hexmode: ---^^ [22:44:40] me peask in [22:44:47] just emailed you list of bugs i submitted/updated [22:44:48] oops [22:44:55] now I learn to spell, too [22:45:35] chrismcmahon: let me know if there are others i missed. we continue testing on our end, on test.wp.o [22:45:51] hexmode: I only just now created an account in BZ, let me know what you need to give me permission to alter fields other than Summary [22:46:03] I'll give it now, 1s [22:46:22] hexmode: please give chrismcmahon all permissions i have (yoni@omniti.com) [22:47:39] chrismcmahon: should have it now [22:47:47] thanks hexmode [22:47:49] checking [22:47:59] hrm... you're the new QA guy, right [22:48:00] ? [22:48:05] welcome! [22:48:16] hexmode: I am, thanks, it's my 2nd day [22:48:26] making you bz admin [22:49:45] Krinkle: any luck with the banner? [22:49:53] yep, testing now [22:49:55] ok, success, assigned 34134 to yoni_omniti [22:50:18] ok [22:50:23] :) yay [22:51:58] small request - can some1 who has been here since about 2pm email me the IRC log? i lost mine [23:00:16] aude: https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Wikimania2012Scholarships [23:00:23] tested in Chrome and Firefox [23:00:28] looking [23:01:49] Krinkle: it's not perfectly centered vertically but i think good enough [23:03:26] https://test.wikipedia.org/w/index.php?banner=Wikimania2012Scholarships [23:04:45] Krinkle: okay it works :) [23:04:48] *aude had it like that before [23:08:51] http://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=wikimania_reg [23:08:55] is what they did last year [23:09:00] *aude could be less wordy [23:09:54] aude: Im increasing the click area of the (x) [23:10:07] I've had too many times that I clicked a little next to it and had it take me to the target page [23:10:16] a little 3px padding around it [23:10:26] 16 px taller [23:10:32] Krinkle: ok [23:10:39] 16 px more than last year [23:11:45] jimmy wales banner is 172px tall! [23:11:54] ours is 65px and maybe ok [23:18:09] aude: okay, moved back to meta-wiki http://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Wikimania2012Scholarships [23:18:14] ok [23:19:25] hideBanner() is built into the central notice extension? [23:19:38] what does e.preventDefault() do? [23:20:47] aude: hideBanner is indeed from CentralNotice itself [23:21:18] ok [23:21:20] aude: e.preventDefault tells the browser not to go to '#' but instead do something custom [23:21:38] ??? which I now see is redundant since I removed [23:22:14] yeah [23:22:15] aude: in old scripts one would do onclick="foo();return false" [23:22:20] either would work? [23:22:23] right [23:22:30] e.preventDefault() is like return false, but cleaner and less argressive [23:22:35] with [23:22:52] onclick="foo();... [23:23:10] sure [23:23:15] probably the non-js way is better [23:23:21] in case somebody has js turned off [23:23:34] then central notice wouldn't work though [23:23:35] there is a natural around the div and instead use .click(), this has the advantage of not causing weird lines in places where there is no text. [23:26:01] ok [23:26:02] I still left the so that the text looks and behaves like a link [23:26:11] i see [23:26:19] *aude is happy [23:26:26] thanks for helping! :) [23:26:54] without having to emulate the link, it can just perfectly be a real normal link :) and then we use the cllick-handler on the surrounding div so that non-text area is clickable as well [23:27:02] you're welcome [23:27:03] Krinkle: are you familiar with the CN settings? [23:27:13] makes sense [23:27:40] i might ask kaldari but don't see him around [23:27:47] aude: depends on what you mean by setings [23:28:49] the campaign is set for all projects, but some like korean don't have translations yet [23:28:58] *aude thinks they will get english banners by default then [23:29:15] is that okay? [23:29:34] I don't know [23:29:39] ok [23:29:46] I don't deal with internal issues like that. I just develop :) [23:29:55] *aude doesn't want people angry at me [23:30:06] i can check with people [23:30:09] kaldari sounds like a person that would know that [23:30:16] to be safe [23:30:17] or know someone that does [23:31:12] ok, thanks! :) [23:31:24] i'll check back later