[00:13:38] Is there a _portable_ way to get the stderr output of wfShellExec()? [00:22:01] GrafZahl_: there are several instances in core of doing 2>&1, so you're probably fine using that [00:22:34] bawolff: OK, thanks [00:23:03] btw, i left some comments on your last commit: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28269 [00:23:31] *GrafZahl_ heads to his browser [00:24:18] if you have your email address in your prefs, MediaWiki will (eventually) spam you any time someone leaves a comment [00:37:21] Yes, I see it [00:37:32] Is there a good filter rule? [00:39:36] I'm not sure what you mean? [00:39:40] OK, I'm filtering for the various mail subject headers [00:40:01] So it goes in the Code Review folder, not my inbox :) [00:40:46] oh, well they're all from "MediaWiki Mail" (but so are other enotif things) usually they have subjects like [MediaWiki rXXXX] [00:41:15] BTW, do you have core commit access? You could change includes/Message.php:158 to the effect that it also accepts arrays [00:44:51] ok [00:45:54] does: @param Varargs: parameters as Strings, or a single argument that is an array of Strings [00:45:56] sound good? [00:47:36] perfect [00:50:30] oh, I should probably do that for other similar methods too [00:51:09] Thanks [00:51:53] r107023 [00:53:21] Good night, folks! [13:49:37] Platonides: ping [13:50:20] I have a question about template use in the wild that you might be able to answer [14:11:15] siebrand: hoi dit is diederik, heb je mijn mail ontvangen? [14:20:33] gwicke, pong [14:21:18] ah- I'm trying to figure out if tables and lists are the main structural wiki constructs that are commonly distributed across multiple templates [14:22:06] I guess headings where the start of the heading line is in one template, but the end in another would be rare [14:22:23] ugh, I think so too [14:22:33] they are often formatted in one line [14:22:35] or opening brackets for a link in one template, end brackets in another [14:22:41] seems odd to split it [14:23:03] I'm trying to figure out if we could get away with no longer supporting that [14:23:09] probably [14:23:55] the biggest problem would be things like open/close brackets that change the correct tokenization [14:24:21] but anything that can be expanded by just concatenating tokens should be doable [14:25:58] those constructs are unfortunately not very well greppable on a dump [14:26:04] why would people do that? sigh.. [14:26:24] maybe there are some odd constructs related to external links, though [14:26:58] there's maintenance/compareParsers.php [14:27:11] but that isn't fast, precisely... [14:28:21] template expansion is not yet implemented, I'm just trying to sanity check the design before realizing it was all doomed right from the start [14:29:18] re external links- do you mean a url broken up into separate templates? [14:29:59] these are the design notes so far: https://www.mediawiki.org/wiki/Future/Parser_development/Token_stream_transformations [14:32:49] right now I have a feeling that I don't fully understand the problem, so if you see anything insane in there let me know! [14:59:17] hat does "WIP" mean? [14:59:40] *what [15:00:15] work in progress [15:01:04] just expanded that in the text [15:01:51] it's ambitious, I'm not convinced its the final solution [15:02:32] eg. running the transformations in separate cores, wouldn't the communication overhead be greater than the benefits? [15:02:44] what about the php implementation [15:03:01] it mentions bold/italic is already done? [15:03:31] italic/bold is done following the MW spec [15:03:54] including the handling of l' etc [15:04:12] it seems a hard transformation with that method [15:04:31] does it buffer all tokens of each line? [15:04:45] no, just the quotes [15:05:04] but the tokens are buffered indirectly [15:05:17] until a newline is reached, at which point things get converted [15:05:30] it can't know what to convert something into until the end of line [15:05:50] yep, especially with the rebalancing [15:06:30] https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/VisualEditor/modules/parser/ext.core.QuoteTransformer.js?revision=106023&view=markup [15:06:45] that is the current (rough) quote handler [15:08:57] I share the feeling that this won't be the big final solution btw [15:09:28] I'm especially scared about templates and parser functions [15:10:20] re multiple cores- some batching would certainly be needed to cut down on synchronization overhead [15:10:42] it looks like the neat encapsulation that won't work in real world [15:11:52] so I hope somebody finds the flaw in it before I spent too much time on it ;) [15:12:02] hehe [15:18:21] drdee: ja, heb ik. [15:18:50] drdee: en ik heb heel veel interesse in het onderwerp. Alleen nog geen tijd gehad er iets mee te doen, en de materiedeskundige is Maarten Dammers (multichill ) [15:20:14] siebrand: okay, wil graag het onderwerp op de radar krijgen :) zodat we resultaten kunnen boeken in 2012, en wil graag de exacte use cases begrijpen, we kunnen op korte termijn skypen (deze week) of tussen kerst en oud&nieuw, en anders in de eerste week van januari. [15:28:40] drdee: wat mij betreft wel. Ik zal Maarten nu even proberen telefonisch te bereiken, dan staat het vast sneller op te rit... [15:28:57] perfect! [15:29:12] drdee: als ik zijn nummer had gehad??? *grr* Dacht dat ik dat had... [15:30:52] drdee: toch iets gevonden in de ledenlijst van WMNL :) [16:01:37] siebrand: Nu zie ik je pas ;-) [16:16:12] drdee: Heb je ook al met anderen gesproken? [16:22:51] *drdee met daniel kinzler [16:23:10] me t daniel kinzler [16:23:23] ha, kleine bug in colloquy [16:29:46] drdee: Dus nog niet echte "glam" mensen? [16:35:41] multichill: nee, ik heb wel liam ge-emailed [16:36:09] Ik moet even gaan spitten, volgens mij hebben we wel eens requirements opgesteld [16:36:25] dat zou super zijn! [18:17:42] rmoen: Re MoodBar revision list: are these all revisions since the last deployment, or are there any revs that are excluded? [18:24:54] bsitu: ---^^ ? [18:25:32] Roan, these are revisions since last deployent [18:25:50] All of them? [18:25:55] Like, nothing excluded? [18:25:55] yes [18:26:21] I really wish Rob would send me instructions like "all changes to MoodBar and MarkAsHelpful since the last deployment" rather than a list of dozens of revision IDs [18:26:42] you can just ask him. [18:26:52] you want a diff patch? [18:26:54] anyone know enough about the api to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=33318 ?? [18:28:00] No, I just want to know when it's safe do to an update to trunk state [18:28:14] That's much easier than merging a list of revs, or sending patches around [18:28:29] jorm: I would ask him if he were responding to my IRC pings [18:28:43] *RoanKattouw doesn't mean to be grumpy but he's hungry after spending 12 hours moving stuff [18:30:38] RoanKattouw: Sorry, yes its safe to use trunk state for both [18:30:57] Good [18:31:18] RoanKattouw: Though, i'm making one small change to MarkAsHelpful [18:31:21] ;/ [18:31:23] OK [18:36:34] rmoen, bsitu: MoodBar changes look good except for https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106402#c28341 [18:36:45] Now moving on to a complete review of MarkAsHelpful [18:40:14] RoanKattouw: I followed up to your comment r106402 [18:40:19] Yeah I just replied [18:43:52] RoanKattouw: awesome, thanks for the tips on pre and nowiki . I realized I could just inspect element right as you responded :) [18:44:11] Heh, that too [18:44:15] Also, there's a preview button [18:44:24] Generally, the code comments field takes wikitext [18:44:42] This is deceptive for stuff like "you should use $foo !== '' because blah blah" [18:44:53] because '' means "start italics" [18:45:09] This is good to know [18:49:49] Hey everyone - does anyone know where where is auto confirm status listed in the database? [18:52:16] It's not [18:52:31] Autoconfirmedness is determined dynamically based on configurable criteria [18:52:45] "Autoconfirmedness"...heh [18:56:32] ok thanks RoanKattouw - Jonathan is trying to fiddle with a query :) [19:05:47] RoanKattouw: we have a bug with MarkAsHelpful [19:06:09] Yes [19:06:22] Any anon can unmark any other anon's helpful-thingy [19:06:44] Even if their IPs don't mathc [19:07:07] (Even if their IPs *do* match, it's shaky ground) [19:08:17] response doesn't allow anon, this is really for future enhancement, we can take this out [19:08:30] Hmm there's an isAnon==isAnon check [19:08:42] So that should be cleaned up then [19:10:35] Oh [19:10:48] I think the fact that marking as helpful doesn't allow anons is an accidental feature, maybe? [19:11:14] There is an issue with calling User::newFromName on an IP address, this is in my review notes which I will post shortly [19:19:15] *rmoen testing new JS in ie7 [19:19:49] : ( [19:26:09] rmoen, bsitu: OK, I'm gonna grab dinner now, I'll be back after. In the meantime, review notes for MAH are at https://www.mediawiki.org/wiki/Special:Code/MediaWiki?path=/trunk/extensions/MarkAsHelpful [19:27:20] Thanks Roan [19:28:47] Added another commit and a CR comment [19:28:50] Really away now [19:30:04] RoanKattouw_away: ha [19:53:35] Alright, I'm back [19:58:07] :) [19:58:11] RoanKattouw: I've resolved my JS problems in ie7 :) [19:58:14] welcome back [19:58:24] Yay [19:58:56] I removed that ;) [19:59:10] Array.prototype :) [19:59:22] We are going upstairs to eat lunch, brb [20:29:24] RoanKattouw: Question for ya, remember last summer in San Francisco at some day during lunch we went some place and Trevor had a list of questions about CSS and JavaScipt. [20:29:35] Yes [20:29:38] RoanKattouw: Did he create those himself ? I'm wondering if it's online somewhere [20:29:49] I think he did create them himself, yeah [20:29:54] ok [20:30:04] (I was already prepared to tell you where that restaurant was :D ) [20:30:13] hehe, next time Roan, next time :) [20:30:33] I'd definitely will want to go there next time I'm in SF. [20:31:00] RoanKattouw: Anyway, when updating my score on Smarterer it reminded me to that, seemed similar kind of questions [20:31:12] You haven't been to Flames, though, have you? [20:31:16] I wonder if that place has reopened yet [20:31:24] doesn't ring a bell [20:31:32] One day it will [20:32:23] I spent last weekend filling in in my profile and going through a bunch of tests there, http://smarterer.com/TimoTijhof - pretty good site. Nice questions and all user feedback based (experts can create new questions and one can always give feedback on new questions, and they throw newly created questions at random in the mix which won't up or down your score [20:32:39] I knew php better than I thought I did. [20:32:56] not as good at Gmail as I thought though, there's many tricks in there I didn't know about [20:33:17] heh [20:40:32] in case you're signing up, beware, it's adicting [20:41:02] Not yet [20:41:06] ok :) [20:41:09] Maybe if I'm bored on a plane and have wifi [20:41:23] Unless and until that happens, I've got plenty of real-life stuff to do [20:41:33] yeah [20:41:35] me too :0 [20:41:51] but it's a nice distraction while waiting for code to compile [20:41:57] or whatever [23:21:18] It would be very nice if someone could deploy r107120 :) (It's only two lines but it fixes MoodBar/WikiLove which are currently broken on Incubator) [23:27:04] SPQRobin: taking a look [23:40:32] rmoen: thanks.. Is it ok to deploy? [23:41:52] SPQRobin: I've looked at it and it seems fine. Though, I'm not very familiar with WikimediaIncubator. I've asked Roan to take a look and deploy if he can. I know hes very busy this week though. [23:43:50] Ok, thanks. [23:58:51] SPQRobin: what does it mean when a hook return false? :)