[00:02:36] hm [00:02:46] it looks like some of our changes didn't make it into labs [00:02:54] e.g. the vertical tab [00:03:17] Thanks, Roan, that's fantastic! I just tried it with an iPhone, and it worked on the first try, even though it's an unsupported platform. [00:03:25] Well done you guys! [00:03:40] I am going into a short meeting, but will be right back in about 10-15 mins. [00:43:22] we are seeing this a ton in the logs: [00:43:23] Dec 15 00:13:29 10.0.2.249 apache2[7546]: PHP Warning: filemtime() [function.filemtime]: stat failed for /usr/local/apache/common-local/php-1.18/resources/mediawiki/mediawiki.debug.css in /usr/local/apache/common-local/php-1.18/includes/resourceloader/ResourceLoaderFileModule.php on line 380 [00:43:59] Strange [02:14:47] kaldari: To get a labs account (for gerrit access) I need the following: 1. your preferred wiki user name 2. your svn account name 3. your preferred email adress [02:15:31] can I sent them to you on IRC or does email work better? [02:15:34] send [02:16:09] either or [13:36:32] do we have statistics on who does review? [13:38:55] I think you can work it out from the CR tables [13:57:52] the easiest thing I found was gmane search :-/ [14:57:30] TimStarling: I just replied to your email on wikitech regarding the deployment, actually I am little bit concerned about the current process, and that it's so complicated for community devs to contribute some code which is ever deployed, isn't there a way to make this process little bit easier? [14:58:30] because I don't think that employed programmers by wmf are willing to review anything since they overtake the responsibility by doing that, or that's how I understood it [14:58:49] FYI it's 2am for tim [14:58:58] WMF employees definitely review stuff [14:58:59] ah... [14:59:01] Or at least they should [14:59:04] I review stuff in my 20% time [14:59:13] ok [14:59:43] petan|w: if you want something deployed, you can bring it up on list and file a bug [14:59:54] file a bug and then bug the bugmeister [15:00:03] that is what the shorturl people are doing [15:00:20] and they got their code reviewed [15:00:46] from his email: A champion is usually a WMF staff member, so the champion will need to convince their manager that spending time on the extension is a good idea, and that the extension will be useful to deploy [15:00:52] petan|w: also https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment [15:01:18] petan|w: working with community to get stuff deployed is part of my job [15:01:19] hexmode: I already filled a ticked for both like weeks ago [15:01:25] so I can spend time on it [15:01:39] petan|w: filing a ticket is only a part [15:01:49] there are 10s of tickets a day [15:01:53] I meant this convincing of manager etc. seems pretty pointless to me [15:02:09] hexmode: which part am I missing then? [15:02:15] not getting lost in the tsunami is the bit about pinging the bugmeister [15:02:32] I got a consensus on wiki to deploy it, I got even one of extensions reviewed by WMF employee, althought there is probably stuff to fix [15:02:36] petan|w: you haven't pinged me [15:02:41] regarding last review from bawolff [15:02:51] I'd like to think people have freedom in what they do in their 20% time; although for platform eng people like Tim that's a bit different [15:02:54] I didn't know I have to ping you [15:02:56] *have some freedom [15:03:05] My whole life seems to be 20% time [15:03:19] petan|w: you don't have to, but it helps [15:03:25] That's because you're in platform eng ;) [15:03:42] I need to find some 20% time to do API stuff.. [15:03:43] :D [15:03:50] heh [15:03:53] Well -- [15:03:58] I think that I have less free time than you guys :D I have a full time job, I work as operation eng. just as you, and in free time I do stuff for wikipedia [15:04:00] "My life is the 1%" [15:04:07] arguably even platform eng people should spend ~20% of their time on "community" stuff [15:04:34] petan|w: you do realize that this isn't "free time" for us, right? [15:04:41] at least for me, it isn't [15:04:45] I am talking about the 20% :P [15:05:02] google employees have 20% time, too [15:05:10] definitely I didn't want to say that working on code for wp is a free time activity for you [15:05:16] That's different from our 20% policy though [15:05:23] so, of course, google people have plenty of time ;) [15:05:26] maybe I just didn't get your point [15:05:39] in the end my english is not that good [15:05:44] RoanKattouw: no, I know, just saying [15:06:10] Yeah, it's not unheard of [15:06:12] And we stole their idea [15:06:37] anyway, petan|w where is your bug? [15:06:54] petan: and have you looked at https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment [15:07:12] yes, https://bugzilla.wikimedia.org/show_bug.cgi?id=32128 https://bugzilla.wikimedia.org/show_bug.cgi?id=32819 [15:07:24] anyway what I wanted to say is: [15:07:37] I don't think it's necessary to get code reviewed only by wmf employees [15:08:04] I believe there are community devs who are participating on development of mediawiki for longer time that employees and maybe know enough to do that [15:08:08] sure, we have experienced volunteers who could do it [15:08:21] that's something Tim didn't mention in the mail then [15:09:21] I don't understand why there are so many activites which needs to be done only by WMF employees while they could be done even by others, that was my point [15:10:14] it seems to me that some people are considered trustworth to do something only when they get paid for that etc. that's how does it look to me [15:10:18] I guess right now, though, there aren't that many (if any) people with enough experience that aren't WMF employees [15:10:27] No, it's more like the other way around [15:10:35] that makes a lot of sense [15:10:36] :) [15:10:44] They were hired /because/ they were experts :) [15:11:05] There are some non-employee experts [15:11:26] Like Domas for DB things, rainman for search, and BryanTM for image/file things [15:11:39] hm... [15:11:42] Of course they all have very little time to spend on MW stuff :( [15:12:42] Nikerabbit was another one (i18n) but then when he graduated, we hired him [15:13:34] ? [15:13:49] Reedy: I'm not familiar with CR tables [15:13:49] :) [15:14:54] I like this image of the big family "we" hiring Nikerabbit [15:15:12] Nikerabbit, code_prop_changes table [15:18:09] hexmode: I am wondering why you inserted one extension as blocker for other one [15:18:15] :) [15:18:37] they are separate but maybe there is some reason for that? [15:19:19] petan|w: sorry, I think I haven't had enough coffee. Thought one was the bug for review and the other was a bug for deployment [15:19:22] *hexmode sighs [15:19:30] yafu [15:23:28] Reedy: I'm bad at making graphs [15:27:08] sorry :) [15:27:16] these are two extensions heh [17:37:40] ahh testswarm is finally running in the labs :-)))))))))) [17:37:43] took me a while [18:04:08] Krinkle around by any chance? [18:14:54] OH CRAP [18:15:00] siebrand: I just found out what causes this LU bug [18:15:09] LU *overwrites* the cache file *for each extension* [18:15:13] RoanKattouw: w00t! [18:15:27] now to fix it. [18:15:37] Yeah I probably caused this [18:16:44] Blame is unimportant. Solving is more important. Glad you found the root cause. [18:17:27] Yeah [18:17:35] I removed a line I thought was stupid [18:17:39] haha [18:17:40] Turns out it was really quite crucial [18:17:44] Adding it back with a comment :) [18:21:13] Reedy: can you look at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106128 [18:22:06] this check-in: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106349 [18:42:55] damn [18:42:56] svn: warning: Error handling externals definition for 'extensions/SyntaxHighlight_GeSHi/geshi': [18:42:57] svn: warning: PROPFIND of '/svnroot/geshi/!svn/vcc/default': could not connect to server (https://geshi.svn.sourceforge.net) [18:44:28] svn up --ignore-externals [18:45:36] Reedy: I understand how to do that [18:45:46] Reedy: my damn was to that external repo is down [18:45:52] oh [18:45:56] it's on sourceforge [18:52:22] Reedy: can you take a look at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106349#c27769 again [18:52:34] the fix is in: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106353 [18:53:26] Reedy: thanks! [23:07:46] switching to the PHP version of CDB has gotten us quite a haul of read error exceptions