[01:47:43] jorm: ping [01:47:59] preilly: pong. [01:48:03] jorm: you posted a picture of a check on FB that has the account number visible [01:48:40] no; there are digits hidden. [01:48:59] jorm: well, the first part is a generic routing number [01:49:41] goddammit. you're right. [01:49:59] 121042882 is the California routing number [01:50:45] *jorm deletes. [01:51:00] jorm: wait I'm still in the middle of my check order [10:08:22] @search test [10:08:22] --elephant-- Results: [] [10:08:22] No results found! :| [10:08:30] @part [10:09:11] @trusted [10:09:11] --elephant-- [mediawiki/Catrope, 216.38.133.254] [10:09:11] I trust: petan|wk.*wikimedia/Petrb, [10:18:05] http://www.mediawiki.org/wiki/Special:VisualEditorSandbox \o/ [10:18:24] people will hopefully test it and report bugs :-D [10:19:05] wow [10:19:35] hashar: ie is transparent combo box for heading [10:19:53] so I see the text behind which make it hard to read [10:20:43] try it in internet exploere [10:20:53] blog post says it does not work in IE8 / IE7 [10:20:54] :| [10:20:56] http://blog.wikimedia.org/2011/12/13/help-test-the-first-visual-editor-developer-prototype/ [10:20:58] ah [10:20:59] ok [10:21:01] then it's ok [10:21:02] I have a Mac so no IE there :-D [10:25:33] RoanKattouw: let me know if you thought that we should insert the new bot to some other channels for test, like #wikimedia-tech etc. I don't know where else it could have use [10:26:20] It's currently only used in #mediawiki and #wikimedia-dev , I think that's fine [10:26:45] -tech and -operations don't really need a factoid bot I think [10:27:10] hm... ok [10:27:27] I don't think it's ready for #mediawiki now [10:27:51] maybe this channel :) but I don't know how we should handle the logs? [10:27:57] should I copy all existing logs to labs? [10:28:12] new log is logging in same fashion so people wouldn't see any difference [10:28:18] new bot [10:28:28] That's probably a good idea yeah [10:28:47] there is nearly unlimited space on labs [10:34:10] bah I can't connect to prototype from labs :( [10:34:23] darn firewall [11:00:49] Inez: are you around? [11:13:11] hello there [11:13:48] does anyone remember the Etherpad for the visual editor meeting on Wikimania? [12:08:39] odder: are you looking for one of those linked in https://www.mediawiki.org/wiki/Berlin_Hackathon_2011/Notes? [12:10:00] (not wikimania, but might get you further) [12:10:55] gwicke, I've found that, thanks for the link anyway [12:11:08] it was the Etherpad from the "Ask the Devs" session on Wikimania [12:12:02] np [12:58:46] odder, does it have info not included on the wiki? [12:58:54] should be moved in that case [13:02:42] Nemo_bis, I was looking for a very specific information which doesn't need to be put on the wiki [13:02:51] I was looking for a quote from Brion, in fact :) [13:05:06] ok [14:07:42] Wikibugs (1,295) [14:07:45] Mark all as read [14:07:47] *RoanKattouw waits :) [16:05:47] RoanKattouw: hah and hi [16:06:05] Ohai [16:06:15] I'm almost done with LU [16:06:22] I moved it off of /home so it should be way faster now [16:06:30] (Once puppet runs, anyway) [16:06:45] And fixed lots of perms issues of course [16:09:24] should talk about visualeditor in this channel, or #mediawiki or something else? [16:09:59] Here is fine [16:10:42] Hmm [16:10:58] in the example doc "Formatting" how is "term definition" inserted? [16:11:13] I have been primed to go "oh, look, Ryan is here, now I can ask him stuff" every time he joins, but I think I actually have nothing to poke him for today :D even though I spent half my day in puppet [16:12:17] Ahm, you mean like :foo ? [16:12:22] :D [16:12:27] no way [16:12:42] I'm used to being pounced by everyone by now. it's ok. :D [16:13:09] Now I am feeling underprepared! I don't have a question for Ryan! [16:14:16] liangent: What do you mean exactly? [16:15:52] RoanKattouw: at the end of the example doc there's "Term Definition" [16:15:59] how can I insert it manually? [16:16:14] I don't see it [16:16:33] Oooh [16:16:36] The second example [16:16:38] gotcha [16:16:41] I don't think you can insert that ydt [16:16:43] *yet [16:17:35] well by the way wikitext generated for definition misses a colon [16:30:18] Oh, hmm [16:30:20] Well that's a bug [16:58:17] preilly: I've been asked to poke you about https://bugzilla.wikimedia.org/show_bug.cgi?id=32624 [17:25:34] hi yuvipanda [17:25:38] how was the day? [17:25:47] sumanah: ah [17:26:03] sumanah: pretty good, I think we might get one contributor out of that group of ~16 [17:26:40] yuvipanda: and the rest have at least been awakened [17:26:42] seeds planted [17:26:57] sumanah: true that [17:27:12] sumanah: it was a bit too formal for my tastes [17:27:19] I can imagine! [17:27:27] the kind of people who put together a ppt to ask you questions [17:27:33] sumanah: half of them were devs [17:27:44] sumanah: pm? [17:28:15] yuvipanda: I just wrote something relevant to the wikimedia India list - marketing, you have to get the message to the recipient three times in three different ways before you have a good chance they've noticed it. So today you were one of those 3 times. For some people, the 1st, for some people, the 3rd [17:28:17] sure, yuvipanda [17:41:22] Hallo. Can anybody with a Mac please test the following page in the *Opera* browser? - https://ne.wikipedia.org/wiki/Nepal?uselang=en [18:00:19] hi [18:03:27] Hi. [18:03:55] I'll try this again: Can anybody with a *Mac* please test the following page in the *Opera* browser? - https://ne.wikipedia.org/wiki/Nepal?uselang=en [18:05:27] so what's the plan? [18:06:14] <^demon> aharoni: What should I be seeing? (or not seeing?) [18:06:46] <^demon> Most of the page content looks fine, but the sutitle and parts of the sidebar are showing boxes. [18:07:25] ^demon, which Opera version is it? [18:07:37] <^demon> 11.01 [18:09:08] Do you see any links in English in the left sidebar? [18:09:17] 11.01 is pretty old. [18:09:25] <^demon> Yeah, I don't use it often :p [18:09:32] <^demon> aharoni: No english, no. [18:09:37] 11.60 (11.1 and 11.5 were before that) [18:09:56] Aha. So it probably is a problem with a fallback font. [18:10:49] *siebrand sighs relieved. [18:11:41] . [18:11:53] Not much of a feature meeting going on here apparently [18:12:07] we're talking features... [18:12:07] there is one English word "Contents" in the Contents box. (Mac, Opera 11.60) [18:12:13] a bit [18:12:25] I read first part the long email siebrand send [18:12:53] Yeah, it was pretty long and no tl.dr possibilities that I saw... [18:13:24] But I'm fine with only 15 people reading through to the signature, and 5 below it :) [18:13:36] for obvious reasons I skipped the rest [18:13:45] I understand ;) [18:17:09] is alolita going to elaborate how this is supposed to happen? [18:17:11] <^demon> siebrand: Imagine a world in which everyone can use the same freely licensed font. [18:17:21] Hi Nikerabbit: [18:17:24] ;) [18:17:26] ^demon: that would be a pain to deliver with webfonts :) [18:17:27] I pinged everyone earlier [18:17:32] Comic Sans for all! [18:17:54] <^demon> Nikerabbit: Well hopefully your distro would include it :) [18:17:56] and would like everyone in the features team to just give a brief status of their projects (current, ongoing) [18:18:07] the I18n team can start first [18:18:08] :D [18:18:11] nikerabbit [18:18:20] http://lists.wikimedia.org/pipermail/mediawiki-i18n/2011-December/000359.html . Done. [18:18:30] siebrand :-) done indeed [18:18:36] if that counts as a brief... :D [18:18:45] Anyway... [18:18:50] any other updates on the bug fixes in progress. [18:18:57] We've had an interesting two days after the web fonts deployment. [18:19:06] Some ops involvement was -- and still is needed. [18:19:29] Woha, looooooongcatislooooooong email [18:19:30] We needed cache headers changed, and still need purging to make new JS availabl to anonymous users. [18:19:43] in the long run we should solve the cache problems with resource loader if possible [18:19:56] There's been some serious and sometimes rather harsh feedback on the wikimediaindia-l list. [18:20:18] We can stand that, though, and we're working with the bug reports we have so far. [18:20:27] IE6 and Windows XP really suck. [18:20:31] siebrand: i concur [18:20:50] The many, many browsers and versions, and different operating systems are a bitch. [18:21:01] are we disabling on ie6 [18:21:09] The hard core JS developers of course already knew that. We've experienced it first hand too now. [18:21:17] alolita: we already have. [18:21:24] also for IE8 on XP [18:21:31] ok great - thanks! [18:21:55] Furthermore we deployed a major update to Narayam, with the input methods added during the Mumbai hackathon. [18:22:11] yay! [18:22:13] We're now focusing on feedback mechanisms. [18:22:27] as well as documentation being reachable. [18:22:37] Want to get into contact with the ArticleFeedback and MoodBar teams. [18:23:00] Please let us know who to best talk to -- we already know of NielK -- but there may be more people. [18:23:11] We want to re-use as much code and interfaces as possible. [18:23:18] -- really done now --- [18:23:42] so- who's next? [18:23:50] good evening btw ;) [18:24:17] siebrand: thanks [18:24:30] gwicke: parser update next :-) [18:25:09] well, apart from what is on etherpad- we have basic HTML DOM to WikiDom conversion since today [18:25:42] templates are not yet done [18:26:11] ok; please also track the page where v-ed issues are being posted [18:26:15] the tokenizer and the general structure feels quite solid [18:26:48] do you mean bugzilla? [18:27:32] bugzilla and the wiki page where feedback is being collected for the v-ed [18:27:52] ok [18:28:14] there a lots of comments there already [18:28:35] will have to flesh out a few WikiDom things with Trevor or anybody in the editor team [18:29:03] I'm also worried about the timeline [18:29:08] nikerabbit: yes; gwicke: yes - the local sf team is still crawling into the office [18:29:21] gwicke: we are syncing-up on next steps later this week [18:29:28] ok [18:29:33] on friday - will pull you into that discussion [18:29:48] gabriel: if you;re done with your update; let's move to krinkle [18:29:53] krinkle: ? [18:29:56] yes, I'm done [18:30:00] thanks [18:30:09] Hi [18:30:16] we're almost out of time - 3 more minutes [18:30:26] so timo - want to give a brief update [18:30:31] yes [18:30:36] go for it [18:30:42] URL for VE feedback, please? [18:30:52] I've finished the harvard banner last week [18:31:01] and planning to pick up ResourceLoader2 this week [18:31:18] further: Dario approached me with what looks like a follow-up to the banner development [18:31:49] and alolita mentioned two projects yesterday although I'll ask for more info as the conversation was left unfinished from both ends. [18:32:11] krinkle: i will follow up with you on both; [18:32:23] alolita: okay, to my wmf mail ? [18:32:28] siebrand: i had asked krinkle to help on the UI work for Narayam [18:32:47] can you both coordinate on this work [18:32:55] alolita: cool. We need jorm 's designs, though, before we can start on that. [18:33:19] siebrand: i have pinged jorm - he has committed to completing these by the 15th [18:33:21] alolita: 1st up is a language selector, and from there we'll be adding input methods and font choice. [18:33:24] *siebrand nods [18:33:29] ok [18:33:32] just as a planning thing :) [18:33:36] yup [18:33:53] Krinkle: Yay RL2! [18:33:57] timo: are you done; Roan? [18:33:59] *RoanKattouw apologies for mistiming his dinner and missing most of this meeting [18:34:13] alolita: yes [18:34:14] RoanKattouw: we're still tuning [18:34:16] Fortunately IRC has a scrollback, phones don't [18:34:20] :) [18:34:24] Roan: :-) [18:34:55] I like Krinkle 's idea of picking up RL2, I'll do that too [18:35:03] I spent today beating LocalisationUpdate into submission [18:35:08] It should now be in a working state again [18:35:17] And, save for one edge case, it should handle fallbacks correctly now [18:35:44] I'll be helping out the VE people on request, and other than that I'm doing CR stuff for various projects (AFTv5 mostly), and RL2 [18:36:49] RoanKattouw: Let's talk later tonight, about 10 or 11 PM our time ? [18:37:04] Just a quick planning chat, nothing big. [18:37:35] Actually, it looks like I might have broken LU [18:37:37] The saga continues [18:37:41] Krinkle: sure [18:37:44] Not sure when I'll be home [18:37:55] I gotta help transport some stuff to the new house later [18:37:58] hmm [18:38:42] RoanKattouw: just to be sure: there's still no successful recent LU run? [18:39:15] Jeroen: any updates [18:39:33] sorry - we're having problems with the wi-fi here in sf [18:39:39] siebrand: Well, "successful" [18:39:50] looks like jeroen is mia [18:39:50] There is a successful LU run in the sense that it didn't explode [18:40:05] It was not successful in the sense that I'm now getting a report that some messages are out of date [18:40:22] "successful" defined as a run that has updated trunk HEAD translations into the live Wikimedia cluster. [18:40:48] SF office network issues? [18:40:57] yes [18:41:16] anyone else we haven't covered in our features update? [18:41:45] we're out of time so if most folks are done; let's sync up later again - [18:41:52] let me know if this format works [18:42:05] i will send out an agenda for this meeting [18:42:09] comments are welcome :-) [18:42:16] alolita: The separation between SF and non-SF strikes me as very strange [18:42:38] goes to have the first 20m+ break since the day begun 13 hours ago. [18:42:45] RoanKattouw: I would rather have everyone together; our audio problems have made things worse [18:43:01] siebrand - thanks for your work! [18:43:13] I also don't like the separation [18:43:23] makes it harder to get hold of the SF cabal [18:43:26] agreed [18:43:27] Why don't we do the IRC format but for everyone [18:43:56] I too liked the format Trevor proposed last few weeks [18:43:57] Roan: We can definitely do that but we will still continue the face to face meeting for the local team also [18:44:17] i will ask everyone to join online based on trevor's format [18:44:41] 5 seconds for a pint. I'm slow when it's warm... [18:44:45] but i will also work on getting better av in sf so that everyone can join in [18:44:50] easily [18:44:58] http://www.youtube.com/watch?v=_oqhgXUTJsc&feature=youtu.be Luckily tfinc and I had Barbie Girl after that... [18:45:26] siebrand: this i have to see [18:45:28] tfinc: rachel is going to put that up too! [18:45:28] :D [18:45:42] i haven't watched either of them yet [18:45:45] yes rachel is going to [18:45:58] siebrand++ [18:45:59] so this will be real fun - part 2 coming up in february [18:46:01] :D [18:46:14] We need a karaoke bar in Pune... [18:46:25] siebrand: we'll find one [18:46:27] :-) [18:46:29] haha [18:46:33] or in goa [18:47:01] ok ttyl then - thanks everyone :-) [18:47:11] thx [18:47:21] see you [18:47:26] alolita fading away to status meeting now :-) [18:47:28] thx. it's been useful to hear what you all have been up to. [18:48:30] *gwicke still hasn't found a wiki page with VE discussion [18:48:52] Nikerabbit: do you have a link? [18:49:07] www.mediawiki.org/wiki/Visual_editor/Feedback# [18:49:31] ahh, thanks! [18:52:25] rmoen: So, MoodBar deployment. Is the code in SVN right now deployment-ready, or should we wait a bit longer? [18:52:40] (I have to do review anyway, but I'd like to know what your view on it is) [18:59:58] rmoen: I gotta step out for about an hour, so the MoodBar review&deploy will have to happen after lunch [19:04:01] lunch? [19:04:06] dinner surely? [19:04:13] Or Roan is on Reedy time... [19:14:27] hehe, I meant SF lunch [19:14:49] *RoanKattouw_away is now actually leaving [19:57:12] @logon [19:57:13] Channel is already logged [20:29:41] RoanKattouw: you've added some logging to LU. Would that be public-ish somewhere? [20:29:57] RoanKattouw: obviously I/we are very interested in the errors :) [20:30:37] It's in a log file on fenari [20:31:00] RoanKattouw: I've heard about it before, but I'm pretty certain I don't have access :) [20:31:29] raindrift: hey [20:31:39] the discussion on wiki is closed [20:47:41] hurrrrgh. [20:48:29] hey RoanKattouw [20:48:37] Hey [20:48:51] how long are you going to be awake for? [20:48:59] A couple more hours [20:49:03] ok [20:49:03] I'm now reviewing MoodBar code [20:49:09] great! [20:49:12] after you're done with that [20:49:17] can we bug you about deployment of aft to labs? [20:50:42] Well, no [20:50:45] There are still outstanding issues [20:50:52] Which OmniTI seems to have been ignoring [20:51:13] I've pointed them out a couple times but I haven't had the time to actively kick them into gear (and that's not my job anyway) [20:51:45] that's too bad [20:51:51] maybe we should make it your job :) [20:52:00] so i'll ask fabrice to bug them [20:52:13] Hah, no thank you, I don't need more jobs [20:52:18] Specifically, these points: [20:52:19] Line 89: a COUNT(*) query on an unbounded number of rows is unacceptable in production. Doesn't the rollup table have this information? Sort of, but that would break the counts when a filter is active - hidden, visible, etc. [20:52:21] Line 123: don't use OFFSET-based paging. Instead, page with WHERE af_page_id >= $params['continue'] and set a query-continue for the next page ID. Grep the core code for query-continue for examples, or ask me [20:52:24] (fabrice -- roan says that Omniti has a list of outstanding issues that they haven't resolved) [20:52:29] Hi Roan, thanks for listing these issues. [20:52:40] I will open tickets for this right now. [20:52:52] We also have windows IE7 issues. [20:53:15] ay others? [20:53:17] any [20:53:32] And I haven't really tested that the non-supported platforms disable AFT5 [20:53:47] I guess the COUNT issue is gone now [20:54:10] We are also waiting to hear from Reha whether they can do the clicktracking for all the fields that Dario asked for [20:54:11] Or, no, it's not [20:54:14] There's just a //TODO comment [20:54:23] Other than that, the main issues on my end have been addressed [20:54:56] Yoni at OmniTI recommends that we pre-deploy today, even with these known issues, so Erik can look at the overall experience today [20:55:13] What do you guys think? [20:55:15] Code with COUNT(*) queries and OFFSET queries cannot be deployed to the cluster [20:55:30] If we do not pre-deploy today, we will not be able to launch tomorrow as planned. [20:55:41] I believe that's Greg's code [20:55:49] i'd be in favor of pre-deploying today [20:56:21] this is labs, so there shouldn't be a significant risk if the open issues aren't resolves [20:56:23] resolved [20:56:37] we would need a way to test once omniti resolves RoanKattouw 's issues [20:57:03] Yes, we can still push to prototype to test if we resolve Roan's issues later today [20:57:07] is that correct, or am i just making stuff up? [20:57:14] hey guys. [20:57:21] hey jem- [20:57:26] sorry jorm [20:57:28] Hi Brandon [20:57:32] too many j's in this channel [20:57:39] Hope you feel better soon. [20:58:26] i'm feeling much better now, actually. [20:58:43] i think i ate something bad bad bad. [20:59:38] howief, just over 4k articles left to tag, but enwiki have blocked my bot for a stupid reason [21:00:02] Reedy: thanks for the update [21:00:11] 6k are tagged, though [21:00:17] so we have those at a minimum [21:00:17] over 7 [21:00:20] cool [21:00:28] en.wikipedia.org/wiki/WP:ANI at the bottom [21:00:30] worse case scenario we have 7k articles [21:01:01] let me send a note to oliver just so he knows [21:01:59] I'm somewhat amused that it has been blocked essentially for a whitespace change it's making [21:05:25] petan: sorry, was grabbing lunch.i saw you updated the bug. thanks! now all that's left to do is wait for it to get through the deployment backlog... [21:05:32] that's ok [21:05:39] I mean Reedy had some concerns I dunno what [21:05:49] that it needs some review or something [21:07:26] Interesting. Reedy, can you clarify for me what additional review usually happens for community-contributed code prior to deployment? I'm new to this part of the process... [21:07:40] Someone with authority signs it off [21:07:48] wow, drama at ani. [21:07:53] you want me to comment? [21:07:59] Please feel free [21:08:01] Usually Tim or Roan.... [21:08:03] jorm: ani? [21:08:13] admin noticeboard/incidents [21:08:14] reedy's bot got blocked; there's an AN/I [21:08:16] ah [21:08:25] is it unblocked? [21:08:30] Not yet [21:08:31] jorm: do you have the background? [21:08:38] on the bot? [21:08:43] Reedy: Cool. Is that something that happens in an interface someplace that's visible, or is the process less formalized? [21:08:53] i could unblock it, but doing so would cause. . . much drama. [21:09:03] We have a page on MW.org.. [21:09:13] Review sometimes happens on a wiki page if I do it [21:09:17] Or at Special:Code [21:09:26] raindrift, purely I don't know if you are "trusted" to sign off code. No offence meant [21:09:41] In theory, as staff you should be [21:09:45] But this is a grey area [21:10:15] Reedy: can you fix the bot? [21:10:24] i don't want to go wading in if it's going to happen again. [21:10:31] I can just stop running the pywikipedia version [21:10:37] That'll fix the problem [21:10:48] we shouldn't unblock [21:10:49] and I can get pywiki folks to investigate it [21:10:50] Reedy: makes sense??? I mean, I do it pretty regularly for code that we write in-house before it gets deployed by Neil or Roan. At this point I'm actually spending about 30% of my time here on code review. [21:10:52] too much drama [21:10:53] at this point [21:10:57] i think we just leave it be [21:11:09] we have 7k articles that are currently categorized [21:11:11] which i think is good enough [21:11:23] i'd rather not stir up all this drama just for the remaining 3-4k articles [21:11:39] It works as we have no pages between G and P [21:12:06] is dario going to be okay with a reduced dataset? [21:12:11] well, there's no reason to believe articles that begin with G and P are different in character :) [21:12:36] jorm: unfortunately i think he'll need to be, at least for now [21:13:19] jorm: how bad is the drama now? [21:13:29] sorry, I haven't had a chance to read through the thread [21:13:34] People are now going OMG WMF [21:13:43] is it the normal omg wmf [21:13:50] or is it a particularly acute omg wmf? [21:14:04] it's not bad. [21:14:10] yeah, "why aren't you using tested code".. [21:14:13] Well, I am [21:14:14] it's just acute omg? [21:14:17] shit like that. [21:14:25] Pywikipedia bot is very mature [21:14:29] AWB similarily [21:14:47] i want to say "it's not untested code. it's the process that's weird." [21:16:39] hmmm [21:16:48] (reading through the thread) [21:16:58] it actually doesn't sound that bad [21:20:26] Reedy: so are you planning on running the AWB version? [21:20:31] it seems like that's the easiest solution [21:20:41] Yeah, I can do that [21:20:50] It was getting upto 20 edits per minute alone [21:20:52] yeah let's do that [21:20:54] which was higher than expected [21:20:57] nice [21:21:11] that seems like the best thing to do [21:22:46] RoanKattouw: back to AFT5 -- alolita fabriceflorin and i chatted and we'd like to deploy to labs today [21:22:53] Yeah [21:22:55] That's fine [21:22:58] great [21:22:59] But there are two buts [21:23:22] ? [21:23:38] 1. I'd really like for issues that I raise that I explicitly call out as deployment blockers to actually be resolved before I'm asked to deploy code. There was 1.5 weeks between the review and now [21:24:00] yup [21:24:01] 2. The issues are only really issues if there's a lot of data in the DB. So it'll be OK on labs but still unacceptable on enwiki [21:24:21] so the initial deployment will be to 10k articles [21:25:04] i'm not sure whether the amount of data 10k articles generates will cause an issue [21:36:19] howief: hello ! [21:36:49] hi srikanthlogic! [21:37:37] howief: wanted to check if you had sometime for the sitenotice management thing ? [21:38:08] Sorry, I have not. I've been terribly busy for the past few weeks [21:38:14] Can i get back to you next week on that? [21:38:23] I apologize [21:38:47] howief: okay.. no issues [21:38:55] thanks for your understanding [21:39:23] howief: It might, actually. If those articles get rated even 10 times each, that's 100k ratings [21:42:12] RoanKattouw: I missed the beginning of the conversation, what's up [21:42:39] 100k ratings? [21:42:56] Howie was suggesting that with "only" 10k pages, inefficient queries wouldn't be a big deal [21:43:08] But 10k articles is easily 100k ratings, if not a millio [21:43:10] n [21:43:25] that's a random sample [21:43:42] last time we deployed to 10K articles it was a stratified sample [21:43:56] RoanKattouw: DarTar we're asking omniti to make the changes before deploying to labs [21:44:01] and even then we didn't get a lot of data, because of how visits are skewed [21:44:05] so can we table this? [21:44:10] also RoanKattouw [21:44:16] yoni from omniti is going to hop on the channel [21:44:19] OK, coo [21:44:21] l [21:44:22] great [21:44:33] If they fix it prior to enwiki deployment, it's fine [21:44:34] they seem to think your points are related to the feedback page, which is not going to be included in the deployment to labs [21:44:45] Hi Roan, I just discussed your requests with Yoni at OmniTI, and he says that they are related to the feedback page, which will be disabled before we launch [21:44:50] RoanKattouw: when you say enwiki deployment, do you mean production deployment and NOT labs? [21:45:04] Oh, aha [21:45:13] howief: labs is on the production servers [21:45:27] yes, I'm aware [21:45:28] Heh, I hadn't considered that particular detail, lemme verify that real quick [21:45:51] Yoni should be able to join us shortly, but if indeed he is correct, than that should not be a show-stopper for predeployment to en-labs [21:45:52] I see you're right [21:45:57] I humbly retract my objections [21:46:09] Let's disable the API module too, though [21:46:32] Thanks, Roan, I really appreciate that. I can ask OmniTI to disable the API module too. [21:46:37] hi [21:46:41] this is yoni [21:46:43] is this yoni? [21:46:46] welcome! [21:46:46] ] [21:46:57] The nickname "yoni" is probably reserved by someone else [21:47:09] Hi Yoni, Roan just said that you are correct, the issues he raised are related to the feedback page. [21:47:19] that was my assumption [21:47:33] But he would like you to disable the API module too. Not just the feedback page. [21:47:36] Yeah, I glossed over that [21:47:49] Glad we were able to clear that up. [21:47:59] roan, is there any quick way to disable the api? [21:48:27] Comment it out from the extension setup file [21:48:30] Just like the special page, really [21:48:36] So would it be possible to pre-deploy to en.labs.wiki if we can disable API module? [21:48:41] Only the viewfeedback module [21:48:46] Yes, again with two buts [21:49:01] 1 is I have another extension I'm reviewing right now, and which I'll be deploying when I'm done [21:49:03] commenting out from autoload works? [21:49:08] so you're next in line after that [21:49:16] yoni_omniti: You need to comment out the $wgAPIModules line [21:49:31] will do [21:49:39] 2 is I'll need to check if there's any new revs and review those [21:50:15] sounds good [21:50:18] OK, these seem like reasonable requests. How can we help you with the second task? [21:50:33] You can't, really [21:50:58] You're now in "wait for the single-threaded Roan to get to your thing" mode :) [21:51:02] OK, sounds good. Thanks for going the extra mile on this. ;o) [21:51:26] we'll gladly take a number [21:51:39] and yes, thanks for doing this -- i know it's getting late over there [21:51:48] Yoni, can you keep the IRC chat open, so you can quickly answer any questions from Roan in the next few hours? [21:51:55] i am here [21:52:01] thanks yoni_omniti [21:52:16] Thank you both! [21:52:37] so are the visual ie7 issues a blocker? [21:52:54] tabs' just been fixed [21:53:00] the vertical tab i mean [21:53:00] I will stay on too, but please elevate any serious issues to us via email. [21:53:30] The vertical tab graphic fixes for all platforms is still a must-have for launch. [21:53:42] But you can stop working on any IE7 issues for now. [21:53:52] in my humble opinion, the option3 stars not showing properly is the only major issue [21:54:30] so the decision is that we should rule out IE7 same way we rule out other unsupported platforms? [21:54:56] Yes, the stars on Win IE7 are a serious issue, but your code should disable that option since it is now an unsupported platform. [21:55:07] yoni_omniti: one question [21:56:24] We also need to test that your code is in fact disabling itself on unsupported platforms like IE6, IE7, etc. [21:56:56] we're testing by forging user-agent strings [21:57:06] howief: whats the question? [21:57:34] yoni_omniti: (sorry, i'm discussing with dario now) [21:57:39] oh ok sorry [21:57:52] I can also test that it works by using my IE7 machine. If AFT5 shows on that machine after you 'unsupport' IE7, then it's not working. I can also test Firefox 2. [21:58:11] Can you explain how agent-strings work? [21:58:28] fabrice - good point, i need to add firefox < 3 to unsupported list [21:58:55] user-agent is a string that a browser reports to the web page [21:59:03] what are our actual numbers wrt ie7 penetration? [21:59:20] 7-9% [21:59:23] it's a big chunk [21:59:31] but option 3 is a broken experience [21:59:57] and dario would rather have all options disabled for ie7 than to have options 1 and 2 enabled [22:00:18] Here is the list of supported platforms (I am removing IE7 now): http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Platforms [22:00:21] if options 1 and 2 are enabled, then the numbers will be all weird since those will have 7-9% more data than option 3 [22:00:34] it will be a little trickier to do comparisons across the options [22:00:54] we'll need to work on getting ie7 to work in the coming week since it is such a large chunk of users [22:00:59] I agree that it would be weird (and risky) to only disable option 3 for IE7. There are other issues for that platform that affect other forms. [22:01:24] Losing 7% of the user base is not the end of the world for this first test, IMHO. [22:01:29] agreed [22:01:33] fabrice, disabling a single option on a specific browser is a problem [22:01:36] Cool. [22:01:48] i was assuming you want to disable IE7 as an unsupported platform [22:02:19] I agree, Yoni. I thought you would say that ;o) Yes, we want to disable IE7 as an unsupported platform. [22:02:37] ok [22:03:04] For 1.0 only, though. For 1.5 and later, we will want to support it. But we want to launch this app now, so we are pulling IE7 to make the date. [22:03:16] so for the sake of excruciating clarity and at the expense of being annoying [22:03:21] Option 1: disable for IE7 [22:03:25] Option 2: disable for IE7 [22:03:28] Option 3: disable for IE7 [22:03:47] And Feedback button: disable for IE7 [22:04:02] yes, for all options [22:04:06] Does this work for you, Yoni? [22:05:02] anybody know anything about setting up cron jobs for maintanance scripts on the cluster? [22:05:39] it can be done? :p [22:05:50] heh [22:05:53] I need to puppetize that some day [22:06:03] Ideally new cron jobs would be puppetized [22:06:36] kaldari, what are you wanting to do? [22:07:12] fabriceflorin: yes. i'm going to put IE7 and FF2 on the list of unsupported browsers, so the entire feature will be disabled for them. [22:07:12] run a maintanance script to populate a couple data summary tables for ContributionReporting [22:07:56] So the top priorities for OmniTI today are: 1) work with Roan to pre-deploy to en.labs; 2) disable IE7; 3) test that AFT5 disables itself on ALL unsupported platforms; 4) check that clicktracking is working for all of Dario's requests; 5) finish the new vertical button graphic; 6) push latest changes to protoype [22:07:59] are those db tables on restricted fundraising servers? [22:08:24] no, they are on the regular db servers... [22:08:39] at least the tables that will be touched by the script [22:09:12] fabriceflorin, yoni_omniti: I'd like to hear first on the feasibility of clicktracking, I posted two different options to bugzilla and I need to hear which one we are going for before I prepare a list of event labels [22:09:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=32992 [22:09:34] kaldari: You can just run it on hume [22:09:41] Writing a puppet manifest for it isn't hard [22:09:44] oh hang on [22:09:48] I just see Reha's reply [22:10:20] we have implemented almost all items on the short list. Reha is adding a few hooks for edit attempt/save, and we should be done shortly. the id's are in the BZ ticket [22:10:25] weird that I didn't get an email notification [22:10:26] Are there any instructions for that anywhere. I haven't used puppet before. [22:10:39] yoni_omniti: awesome [22:10:39] Yeah, it's kind of a learn as you go thing [22:10:50] fun [22:10:52] Talk to the ops people, I guess, I'm kinda busy right now [22:10:58] no problem [22:11:06] kaldari: ops people are going to be your best friends :p [22:11:20] is Reha around? I have a few thoughts on the naming scheme [22:11:25] yoni_omniti: ^^ [22:11:30] kaldari: I have my personal dedicated ops myself. Could give you some informations if you want. [22:11:58] I can has informations? [22:12:05] in particular vertical-link should be per option [22:12:14] that was not clear from my initial list [22:12:17] just asked her to join [22:12:21] cool [22:13:04] kaldari: The first step would be to get access to the puppet repository. https://labsconsole.wikimedia.org/wiki/Git [22:13:16] kaldari: Ryan in SF could help with that [22:13:35] kaldari: then you have to fetch the puppet repo and write some kind of magic ruby stuff to have the cronjob added [22:13:40] DarTar: what's up? [22:13:46] hey reha [22:14:00] yoni says you have a question? [22:14:01] I just saw your reply, sorry for some reason I didn't receive an email notification [22:14:02] yes [22:14:12] a few points about the naming scheme [22:14:28] 1) can we prefix all labels with aft5- [22:14:38] hashar: Cool, I'll try to track down Ryan Lane then [22:14:40] they're all prefixed already [22:14:45] oh are they? [22:14:48] yep [22:14:51] cool [22:14:52] one sec, let me get it... [22:14:59] just pushed to prototype again, not including click tracking changes yet [22:15:20] 'ext.articleFeedbackv5@' + version + '-' + key; [22:15:22] kaldari: probably the best way cause the whole process need some learning. So if you need a cronjob setup quickly, you don't want to start learning all that stuff now :-) [22:15:35] rsterbin: excellent [22:15:37] version's pulled from the config [22:15:48] it's what aftv4 does [22:15:54] and it's like a single digit, right? [22:15:59] yeah [22:16:02] k [22:16:06] right now, 0 [22:16:10] second thing [22:16:23] vertical-link should be *per option* [22:16:33] sorry if that was implicit in my list [22:16:34] kaldari: overall the idea is to change the cluster configuration just like we change software code :D code / send / review / deploy [22:17:02] option1-vertical-link, option2-vertical-link, option3-vertical-link [22:17:22] hashar: makes sense [22:17:23] that's really critical as it's going to give us a baseline for impressions for the overla y mode [22:17:38] ok, no problem [22:17:42] great [22:18:15] and the last one [22:18:51] is there a way to track CTA events per option ? [22:19:19] i can do that [22:19:38] e.g., option1-cta-edit-button-click-overlay? [22:19:43] yep [22:19:51] ok, will do [22:20:01] rsterbin: BTW, are the clicktracking event names namespaced (i.e. prefixed with articlefeedbackv5-) ? [22:20:06] oh and since you're at it ;) [22:20:10] RoanKattouw: they are [22:20:23] yes, 'ext.articleFeedbackv5@' + version + '-' + key ??? just like v4 does [22:20:28] Excellent [22:20:48] the positioning (bottom vs overlay) should be in the same order across labels [22:20:59] nice to have, not a showstopper [22:21:09] hm, i thought i'd got all of those :-/ [22:21:36] oh so position is the last field? [22:21:45] yeah [22:21:48] you're right [22:22:13] I was expecting it to appear before the event type, but that's a matter of aesthetic [22:22:16] overlay-close is the only one that doesn't have a position in the last spot [22:22:23] right [22:22:30] because closing the overlay only makes sense when you're in one ;) [22:23:15] right, I was actually expecting to have the placement before the action, but if it's too much work to changed that let's keep it as it is [22:23:31] (i.e. option3-overlay-impression) [22:23:37] i think i got them all to [option/cta identifier]-[event]-[bottom/overlay] [22:23:48] ok no worries, let's stick to that then [22:23:55] ok [22:24:37] for the cta ones, we want [option identifier]-[cta identifier]-[event]-[bottom/overlay], right? [22:24:47] correct [22:24:53] ok, cool [22:25:10] any specific issues with edit save attempts/completed? [22:25:22] or just not implemented yet [22:26:08] the most important thing as the moment is that we have the feedback button and CTA click tagged with the option id [22:26:39] the rest is less critical [22:27:16] (but it would be awesome to have it in time for the deployment, so we can start measuring the effects on edits) [22:27:23] no, it's just that i haven't had a chance to make the hooks yet [22:27:34] ok [22:27:49] i'll check in these changes, then go back to edit hooks :) [22:28:03] cool, thanks [22:32:02] I am going to prep the pre-deployment to labs now [22:32:16] However, it won't include today's changes because I haven't reviewed those [22:34:48] rsterbin: minor thing, if you haven't committed yet: should we use a hyphen in learn-more? That sort of breaks the naming scheme [22:35:02] as we use - as a separator [22:35:08] i've already committed [22:35:13] ok np :) [22:35:14] but i take your point [22:35:21] will fix [22:35:26] thanks [22:35:43] learnmore or just learn should do it (as long as we know what it refers to) [22:36:54] all set [22:38:44] btw, i need to catch a train in a few minutes here, so i won't get done with the edit tracking tonight [22:39:33] i can pick it up tomorrow morning, though (assuming there's nothing more pressing) [22:40:22] yoni_omniti: I'm sorry, when I said disable the API I didn't mean the entire API. Just the view-feedback module [22:40:35] If you disable all API modules like you did in r106250, the extension will break [22:40:53] ok [22:41:40] ApiArticleFeedbackv5 is still in [22:41:58] i just removed the view ratings, view feedback and flag [22:42:15] Oh, right [22:42:25] On the cluster I'm only commenting out view-ratings, and the special page [22:42:42] ok, so my commit is good? [22:43:12] No, it comments out too much, probably [22:43:15] well - [22:43:19] Yes, it does [22:43:34] You should fix your commit but it's not urgent [22:44:05] view ratings is for bucket #5 - not for this phase [22:44:13] view feedback should be disabled per your request [22:44:27] flag is for feedback page as well [22:44:40] es [22:44:48] At least flag should be reenabled probably [22:45:48] i can bring it back, but i don't see where it is required for the current phase [22:45:57] what am i missing? [22:46:07] Flag is for hiding, right? [22:46:12] Oh, is that on the special page too? [22:46:18] rigt [22:46:22] Riiight [22:46:24] right* [22:46:24] Yeah then it's all good [22:46:30] i tested :) [23:06:09] preilly: Some guy e-mailed me about https://bugzilla.wikimedia.org/show_bug.cgi?id=32624 , could you take a look at that feature request? [23:08:10] yoni_omniti: Has Greg been out of the office or something? [23:08:17] yes [23:08:32] Riht [23:08:42] RoanKattouw: I'm confused [23:08:49] That explains why he hasn't been replying to any of my CR comments [23:08:56] preilly: I'm also not exactly sure what he's requesting [23:09:14] because you can get a json version of the page just fine [23:09:23] How? [23:09:38] http://en.wikipedia.org/wiki/Main_Page?useformat=mobile&format=json [23:10:59] Ah, cool [23:11:10] Could you post that on the bug then? [23:11:38] RoanKattouw: but, that bug already says that [23:12:21] huh [23:12:25] Yeah, I'm not sure what he's looking for [23:12:38] okay, well ??? I'll try to figure it out [23:12:55] maybe he just wants to be able to call the api.php page and get back the mobile version [23:13:32] I've sent an e-mail CC you [23:37:11] yoni_omniti: AFTv5 is now live on enlabs [23:37:13] fabriceflorin: --^^ [23:37:53] alolita: AFTv5 just went live on enlabs [23:39:06] Cool, Roan, that's wonderful! I will start testing right away! [23:39:42] Thank you so much for staying up late to make that happen, Roan! [23:39:52] Sure [23:40:32] url(s)? [23:43:17] http://en.labs.wikimedia.org [23:43:25] Still needs pages to be categorized before it'll show up though [23:46:30] Cool. I just created a test page at this URL: http://en.labs.wikimedia.org/wiki/Golden-crowned_Sparrow [23:47:34] I gave it the same category name as on prototype: [[Category:Article Feedback 5]] [23:47:52] But it is not displaying the feedback form. Any ideas why? [23:48:40] That should work [23:49:09] Here is the corresponding prototype page: http://prototype.wikimedia.org/release-en/Golden-crowned_Sparrow [23:49:34] Oh, rawr [23:49:36] I got it [23:49:42] The main difference is that prototype has this '/release-en' in the URL. But I thought it might not be needed for en.labs. [23:50:22] No, that's not it [23:50:26] I forgot to enable ClickTracking [23:50:47] OK, let me know if there is anything we can do on our end. [23:51:10] Just wait ~5 mins [23:52:24] thanks Roan, I was AFK, saw your message just now [23:54:28] OK [23:54:41] fabriceflorin: Press Ctrl+F5, that should make it appear