[00:00:32] I'm ok for now, actually. [00:00:47] but thanks for the offer. [00:01:12] *AaronSchulz wants to actually *have* python-fu...time for more book-learnin ;) [00:01:16] I'll keep you in mind; it's good to know who the python people are. [00:40:50] *jeremyb is back with his python sign on forehead :) [00:51:33] AaronSchulz: upload-style urls are working on swift for any that match /wikipedia/commons/thumb/ [00:51:38] \o/ [00:52:15] jeremyb: it's not a big change, but it is python... want to review https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105499 for me? [00:52:40] maplebed: can a non-commiter do so? or just as an extra review? [00:52:48] I have no idea. [00:52:52] I don't interact with svn much... [00:52:55] :P [00:53:09] You can comment/sign off [00:53:17] need coder right to mark ok/fixme etc [00:53:18] i mean, i know i can comment (or at least i'm under the impression i can) [00:53:29] it's really not a very interesting diff though. [00:53:45] anyway, looking [00:55:28] maplebed: so, not part of a changed line but why do this: url = req.url[:] ? [00:55:45] no idea. [00:55:54] I don't really know what it's doing... [00:56:04] I'm not even sure what kind of object req is. [00:56:24] probably request? :) [00:56:42] what I do know is that url was turning into http://127.0.0.1/path, which didn't work (because the thing listening is running on port 8080) [00:57:00] I was hoping it had a 'port' attribute, but no dice. [00:57:12] ahh [00:57:13] (req.port = self.bind_port would have been much nicer) [00:58:35] *AaronSchulz either gets Regexp failed or a blank page [00:58:37] when I put in a self.logger.warn("req is %s" % req"), I got req is GET /v1/AUTH_a6eb7b54-dafc-4311-84a2-9ebf12a7d881/wikipedia-commons-thumb/3/3f/Karl_Mack_von_Leiberich.jpg/8px-Karl_Mack_von_Leiberich.jpg HTTP/1.0#015#012Accept: */*#015#012Content-Type: None#015#012Host: 127.0.0.1:8080#015#012User-Agent: plain#015#012X-Cf-Trans-Id: txabfbcb36-d2ba-41d2-85b2-34a7244294c7 [00:58:48] AaronSchulz: what's the URL you're trying? [01:00:02] should I be hitting http://copper.wikimedia.org:8080 ? [01:00:11] yeah. [01:00:21] like http://copper.wikimedia.org:8080/wikipedia/commons/thumb/0/0c/McDonnell_XF-85_Goblin_USAF.jpg/100px-McDonnell_XF-85_Goblin_USAF.jpg ? [01:00:33] *maplebed tries that [01:01:01] http://upload.wikimedia.org/wikipedia/commons/thumb/0/0c/McDonnell_XF-85_Goblin_USAF.jpg/100px-McDonnell_XF-85_Goblin_USAF.jpg [01:02:32] weird. changing the size makes it work for me. but 100px doesn't. [01:02:57] eg http://copper.wikimedia.org:8080/wikipedia/commons/thumb/0/0c/McDonnell_XF-85_Goblin_USAF.jpg/120px-McDonnell_XF-85_Goblin_USAF.jpg [01:04:34] wfm [01:04:48] I just deleted it and re-requested [01:04:50] it worked that time. [01:05:03] I had just rebooted copper; maybe you hit it while it was still partially booted or something. [01:06:37] maplebed: why aren't you using python-requests.org ? [01:07:40] I didn't write most of what's there; I'm just trying to make it work. [01:07:48] there might be some reason, but I don't know it. [01:07:54] maplebed: also, is this file part of some swift middleware? [01:07:59] yes, it is. [01:08:24] ok, http://localhost/MW_trunk/phase3/wmf_swift_test.php is working via cURL on my wiki [01:08:27] *jeremyb resumes reading :) [01:08:38] AaronSchulz: woohoo!!!! [01:08:41] that's fantastic. [01:08:45] I think it's time for pie. [01:08:46] brb [01:12:45] Uncaught exception 'AuthenticationException' with message 'Invalid username or access key.' [01:12:56] maplebed: now I can't do the other tests ;) [01:15:20] eh? [01:15:40] AaronSchulz: can you point me to the other test? [01:15:46] or do you need the auth tokens? [01:15:57] did you change any auth stuff? [01:16:15] I don't remember what I told you so probably. pming you the password. [01:17:12] (not that they're actually secret; they're in wikitech already...) [01:17:44] Uncaught exception 'InvalidResponseException' with message 'Invalid response: (curl error: 7) couldn't connect to host: Failed to obtain valid HTTP response [01:19:30] would you pastebin the entire exception for me? [01:20:16] http://pastebin.com/0a3hzvA6 [01:21:23] AaronSchulz: are you sure it's using port 8080 the entire time? [01:21:33] and not throwing in port 80 somewhere? [01:22:01] all 8080 afaik [01:22:02] would you try again? [01:22:12] i just threw up tcpdump on port 80 [01:22:17] so I'll see any attempts. [01:22:37] nope nothin. [01:22:48] could you tcpdump 8080 too? [01:22:55] so i can see the actual reqs? :) [01:23:30] sure. [01:24:16] to avoid too much chaff though, let's coordinate. i'll say as soon as it's running and you say as soon as you've made a request (or a few) then I'll kill it. [01:25:13] ready? [01:25:26] sure [01:25:39] set? [01:25:46] go [01:26:40] *AaronSchulz hopes something showed [01:26:50] *maplebed is still waiting for the 'I'm done"... [01:27:05] *AaronSchulz is done [01:27:12] jeremyb? [01:27:23] erm? [01:27:36] I thought you were going to be throwing a few requests in there too. [01:27:41] oh, no [01:27:42] ok, it's stopped. [01:27:47] idk if that's even a public box [01:27:53] and i don't have a swift client handy [01:28:05] you didn't click on aaron's URLs earlier? [01:28:11] http://copper.wikimedia.org:8080/wikipedia/commons/thumb/0/0c/McDonnell_XF-85_Goblin_USAF.jpg/100px-McDonnell_XF-85_Goblin_USAF.jpg [01:29:10] ok, one sec while I make sure the cap is clean. [01:39:30] AaronSchulz, jeremyb: http://copper.wikimedia.org:8080/wikipedia/commons/thumb/tmp/swift-noauth.cap is getting a file like the one pasted above. http://copper.wikimedia.org:8080/wikipedia/commons/thumb/tmp/swift.cap is what AaronSchulz just tried. [01:40:02] and yes, I know they have the password in plaintext in there. it's ok. [01:40:18] (/me is splitting time with the otrs channel atm btw) [01:41:11] AaronSchulz: it looks like whatever you're running is successfully authing but then not doing anything with the token it gets. [01:45:30] so, one of the dumps is just hitting /wikipedia/commons/thumb... and one is just hitting /auth/v1.0 [01:46:58] the thumb one is succesful; I'm not sure what's up with the other yet. [01:50:22] they are both 200... [01:50:31] yeah, the auth attempt is successful. [01:50:41] AaronSchulz was saying that something after that timed out [01:51:02] I didn't see that on either port 8080 or 80, so I'm not sure what it is. [01:51:03] *AaronSchulz wonders why get_container fails now [01:51:45] I wonder if this is it: [01:52:01] X-Storage-Url: http://127.0.0.1:8080/v1/AUTH_... etc. [01:52:07] lemme change something. [01:53:17] (there are two spots that specify 127.0.0.1 in the config; I'm going to see which one is populating that and change it to copper.) [01:54:14] maplebed: is it listening on cooper? [01:54:28] yeah, it's listening on 0.0.0.0 [01:55:11] maplebed: well "something after that" isn't in the dump then [01:55:32] yup. I think this is probably it. [01:56:15] are php and python the same box? [01:56:23] it fails about instantly, wherever it happens [01:56:41] instant doesn't sound right for timeout [01:56:53] jeremyb: the only PHP is on my own box [01:56:59] no - aaron's tests are off-host. all of mine so far have been on localhost. [02:00:51] AaronSchulz: try again. [02:03:17] *AaronSchulz makes a commit to something else [02:03:19] ok, back [02:03:30] hooray! [02:03:34] looks like that worked. [02:03:39] *maplebed is watching logs [02:04:07] http://pastebin.com/SNCstphv [02:04:45] yup, that's it! [02:04:55] ok. I think I'm gonna end on a good note. [02:05:04] wtf are the last three files? :) [02:05:18] the placeholder I just threw in there cuz I wanted something to play with, [02:05:29] ok, as long as there is an explanation, heh [02:05:31] and the two .cap files are the tcpdumps I just got for you. (and jeremy-b) [02:05:44] I guess you didn't look at them. [02:05:44] :P [02:05:48] ahh, write, I didn't expect them to be *there* [02:05:50] heh [02:06:00] I looked at one cap file [02:06:02] right* :P [02:06:05] on pastebin [02:06:22] heh... "Hmm, I need a web-accessible filesystem to store these cap files so folks can download them. Oh, I know, I'll use Swift!" [02:06:23] :P [02:06:32] hehe [02:06:55] ok, nice...I'm glad to see the etag being set [02:08:05] *AaronSchulz should do some on-cluster perf testing [02:09:55] AaronSchulz: here are the rest of the details about two random files, just to see what swift's storing: http://pastebin.com/6LTs7KtF [02:11:10] ok, I'm heading out for real. [02:11:13] see you tomorrow. [02:11:14] same here [02:11:20] AaronSchulz: are you going to be in the office tomorrow? [02:11:36] all week [13:46:08] bugzilla is DOWN [13:46:16] perhaps here someone is online :D [13:58:12] hello, anybody there?? [13:59:06] i hav a suggestion to make for wikipedia.....anybody there?? [14:00:23] hey santhosh and multichill.... [16:06:05] yuvipanda: hashar: Inez_: thedj: a student is asking me, what's a good book to help him learn PHP? [16:06:08] any recommendations? [16:06:42] sumanah: no, sadly [16:06:44] get in class? [16:06:58] I myself learned it by looking at www.php.net documentation [16:07:00] sumanah: I do know that most of the online ones are pretty bad (atleast the ones i've checked) [16:07:12] hashar: "get in class"? The reason this student is asking me is because his coursework does not include PHP. [16:07:20] I had a background as an ASM / pascal / basic developer though [16:07:23] I learnt by diving in, looking up surprises as I hit them [16:07:33] sumanah: do let me know if you find something good [16:07:56] yuvipanda: :( This is one of the people you passed to me, btw. Argh. OK, I'll do what I can [16:08:01] sumanah: for tech matters, I usually grab a book from O'Reilly [16:08:09] and start a little and simple project just to play with the language [16:08:47] http://rosettacode.org/wiki/Rosetta_Code is a funny site. They list various algorithms and volunteers are implementing them in differents languages [16:08:50] hashar++ [16:08:55] so it is a good way to look at some PHP code [16:09:01] also the php doc is "good" enough [16:10:11] <^demon|away> The docs are usually pretty good. [16:10:20] <^demon|away> The comments below the docs are usually awful and should be ignored. [16:12:16] ^demon|away: hashar why does the mw docs have 'call graphs' anyway? [16:12:24] do they serve any purpose other than bloating up the page? [16:12:33] <^demon|away> Someone thought they'd be useful :) [16:12:38] who? [16:12:41] I guess it is me [16:12:45] <^demon|away> Don't remember. [16:12:47] <^demon|away> Or hashar. [16:12:48] <^demon|away> :) [16:12:50] hashar: why? [16:12:53] the idea was to eventually find out which functions were the most called [16:13:07] but that is probably useless [16:13:27] hashar: plus the images are huuugeee [16:13:32] hashar: can we please get rid of them? [16:13:41] edit maintenance/Doxyfile [16:13:51] look for CALL_GRAPH or CALLER_GRAPH and set that to false [16:14:04] I already have a local copy without the images ;) [16:14:24] was talking about copy at http://svn.wikimedia.org/doc [16:14:39] do you have any example of a bloated page? [16:14:51] oh, every page. let me find one [16:16:07] augh [16:16:12] not very linkable, the default frame based doc [16:17:09] right click the frame and choose "open in new tab" or something like that :D [16:17:16] hashar: linker, for example [16:17:41] hashar: http://svn.wikimedia.org/doc/classLinker.html [16:18:29] more than two screens of horizontal scrolling [16:19:22] brb [16:20:24] maybe there is a way to make the graph morecompact [16:20:27] and to filter out some methods [16:20:59] <^demon|away> We already filter wfMsg & friends iirc. [16:21:19] wfWarn wfDebug could use some filtering too [16:21:33] <^demon|away> wfWarn() is used like 5 places. [16:21:38] <^demon|away> wfDebug() perhaps [16:22:13] not sure how to filter them out though [16:22:52] <^demon|away> hashar: I have a git repo of phase3 now :) [16:23:01] awesome [16:23:11] <^demon|away> You don't want it just yet, still 4.2G ;-) [16:23:18] git gzip [16:23:27] <^demon|away> I'm doing some repacking now. [16:23:29] and get ride of all the languages files /D [16:23:53] with raymond doing commits every day on thases, that must takes a lot of space [16:23:57] thases/thoses [16:23:57] <^demon|away> But yeah, with a bit of luck we'll have a test phase3 repo up today for people to start playing with. [16:24:13] <^demon|away> The i18n commits made exporting take a long time ;-) [16:24:25] *hashar hands brion a donut [16:24:27] *brion smells a git repo [16:24:35] om nom nom nom [16:24:38] <^demon|away> brion: A very very smelly 4.2G phase3 repo :) [16:24:46] <^demon|away> Trying to remove some of the smell now [16:24:53] \o/ [16:26:25] <^demon|away> brion: http://www.mediawiki.org/wiki/Git_conversion/Rules/phase3 [16:26:36] <^demon|away> Those were the rules I ended up using. [16:30:00] is your tool able to detect svn copy? [16:30:15] <^demon|away> Yes [16:30:33] still 4G is a lot [16:30:46] <^demon|away> That's totally uncompressed. [16:30:57] <^demon|away> A raw SVN dump is something on the order of 10G, so I'm not totally surprised. [16:31:08] yay a test repo [16:31:39] fun fun [16:32:19] hopefully it will be much much less mess in it than in the current svn one [16:32:43] <^demon|away> We have over 337k objects over the course of the phase3 path, so yeah, definitely needed some efficient repacking :) [16:32:52] the current one messes up various unrelated things [16:33:07] has weird nonintuitive names etc [16:33:26] <^demon|away> Danny_B|backup: Well we're breaking our huge svn repo up into smaller git repos :) [16:33:34] <^demon|away> And we're dropping the phase3 name ;-) [16:33:40] oh rilly!!!! [16:33:51] apergos: for phase4 [16:33:52] phase4 [16:33:52] <^demon|away> I've been planning on mediawiki/core.git [16:33:54] I knew it :-D [16:33:59] <^demon|away> Unless you guys really want phase4. [16:34:02] <^demon|away> We can do that instead. [16:34:02] nooooo. [16:34:04] no. [16:34:07] mediawiki/phase4.git [16:34:08] no no no no and NO. [16:34:11] plizZZzzzz [16:34:16] *apergos glares [16:34:23] <^demon|away> How about mediawiki/2.0.git? [16:34:24] <^demon|away> :) [16:34:37] hmmmm :-) [16:34:41] or we might as well rename MediaWiki to something people will not mistake with WikiMedia or WikiPedia [16:34:58] something like BrioTim [16:35:04] <^demon|away> hashar: LDCWiki? [16:35:06] there is no 2.0 [16:35:20] I think brion reserved 2.0 for the new parser [16:35:32] mediawiki/core.git is fine anyway [16:35:45] core sounds confusing [16:36:00] or mediawiki/AAA_main.git so it get listed at the top [16:36:04] <^demon|away> mediawiki/mediawiki.git just sounds redundant. [16:36:12] i just don't care about version numbers that much [16:36:14] meh :D [16:36:18] I'm ok with core [16:36:25] <^demon|away> core would sort before extensions too. [16:36:27] why is there mediawiki/...? [16:36:27] we use that language plenty for exactly that part ofmw [16:36:33] <^demon|away> So that works with my planned repo layout: [16:36:36] <^demon|away> mediawiki/core.git [16:36:37] you can always git clone .../core.git mediawiki ;) [16:36:40] <^demon|away> mediawiki/extensions/foo.git [16:36:43] like i svn co ???.phase3 trunk [16:36:53] uh huh [16:36:58] or use it in french : mediawiki/C??ur.git [16:37:20] no, use czech! mediawiki/j??dro.git :-P [16:38:09] <^demon|away> We could give it an Esperanto name ;-) [16:38:17] you won [16:38:31] ^demon|away: so where is your structure available to see? [16:38:48] <^demon|away> Danny_B|backup: If you can read my mind! [16:38:54] <^demon|away> But I basically said it a second ago. [16:38:59] <^demon|away> mediawiki/core.git [16:39:01] that's all? [16:39:04] <^demon|away> And mediawiki/extensions/foo.git [16:39:11] there is bunch of other things in svn [16:39:27] <^demon|away> We'll migrate them a bit at a time as we find proper homes :) [16:39:41] <^demon|away> For example, trunk/debs was already moved to git, but ops didn't want the svn history [16:39:44] why not start with small thingies? [16:39:55] <^demon|away> Because phase3 is the important one :) [16:39:58] :-P [16:40:08] it could wait until 2.0 :-P [16:40:53] mediawiki/koro.git :) [16:41:19] ^demon|away: what else will be in 'mediawiki' folder anyway? [16:41:33] <^demon|away> Nothing that comes to mind other than core and extensions. [16:41:39] tools? [16:41:50] where's the "random stuff that doesn't deserve to be a maintenance script but I need to be able to put it somewhere" folder? [16:42:02] <^demon|away> /trunk/tools [16:42:14] <^demon|away> Danny_B|backup: We can probably split the tools off to various locations. [16:42:16] in git? [16:42:21] <^demon|away> Ah, in git. [16:42:24] <^demon|away> Not sure. [16:42:30] ^demon|away: yeah, that was my plan [16:42:45] <^demon|away> Pretty trivial to do, we just need to write some rules. [16:43:05] <^demon|away> tools is a very misc. folder, so they can probably find different homes. [16:43:32] ^demon|away: another scheme would be : wmf/mediawiki.git wmf/extensions.git and have extensions not on live site in a different directory extension/socialprofile.git [16:44:03] <^demon|away> I want core and extensions in the same base mediawiki/ [16:44:13] ahhhh a big bag of stuff [16:44:38] <^demon|away> And I'm not 100% sure how we'll do wmf branch yet. [16:44:53] <^demon|away> Maybe a wmf/mediawiki that's a fork of mediawiki/core with the various extensions imported in. [16:44:57] <^demon|away> We'll have to figure that out [16:45:39] <^demon|away> Although presumably, if core's going to a gated trunk model we could go back to doing deployments from master rather than maintaining a different branch. [16:46:10] obviously it's definitely necessary to discuss the structure befor migrating and find some solution comfortable for everyone [16:46:33] <^demon|away> Well we can do the conversion before we put them up. [16:46:44] <^demon|away> This naming convention is largely just bikeshedding. [16:48:53] wmf branches could be in the same core.git [16:49:04] then use submodules to get the extensions we care about? [16:49:14] <^demon|away> Perhaps something like that. [16:49:25] git clone bikeshet.git [16:49:35] <^demon|away> bikeshet? [16:49:40] heh [16:49:43] git clone speling.git [16:49:46] that can go nowhere good [16:50:25] <^demon|away> "I can't do any work right now, my repo's repacking" [16:50:41] :) [16:50:46] :-D [16:51:27] <^demon|away> I mean heck, the repo has almost 9 years of history :p [16:51:47] well see you later. Dad on duty [16:51:57] 5 million images with orientation info in the exif [16:52:03] ugh. how many of them are problems... [16:52:49] apergos: this isn't new; the rotatebot guys brought this up a couple months ago [16:52:53] and started on fixing them :) [16:52:56] no [16:53:03] the problem is that I am purging thumbs [16:53:08] but yeah there's still some cleanup to go [16:53:11] heh [16:53:14] because we are gonna run out of space if we don't [16:53:19] like next month [16:53:52] oww [16:54:30] yeah. ow indeed. hurry up swift! [16:54:50] <^demon|away> Too bad we don't use MongoDB, MongoDB is web scale. [16:55:02] <^demon|away> NFS is not web scale. You cannot use NFS for web scale applications [16:55:11] <^demon|away> MongoDB is made for web applications, because it is web scale. [16:57:03] it's still funny. every time... [16:58:21] <^demon|away> Compressing objects: 89% (302711/337395) [16:58:24] *^demon|away twiddles his thumbs [17:00:30] I purge my thumbs, you twiddle yers... hmmm [17:01:01] <^demon|away> You have many more thumbs than I. [17:01:07] <^demon|away> Millions, even [17:06:51] hexmode: FYI, one reason i didn't see your mail about the funcom triage until i got awjr's was because it was in teh spambucket [17:27:05] <^demon> How about 142M for a phase3 repo? ;-) [17:27:13] <^demon> 164, even [17:27:15] <^demon> But still :D [18:13:30] DarTar: I'm on now. [18:13:37] hey Krinkle [18:13:39] getting workflow started [18:13:43] fabulous [18:13:57] it looks like we need to find a dev who can deploy [18:14:20] Roan being on vacation, alolita suggested we ask Sam [18:14:27] and review [18:14:35] but I don't see him around [18:14:47] Roan's on vacation ? I didn't knew that, I was wondering where he was [18:14:55] Reedy: round ? [18:15:26] I need to send an urgent email after which I'll be working on CentralNotice [18:17:11] I'm just about to go AFK for dinner [18:17:15] I shouldn't be too long [18:17:42] hey Reedy [18:18:28] Reedy: hope we can have your help for a time-critical deployment scheduled for today [18:19:46] *apergos peeks in [18:29:56] Krinkle: re [18:30:05] let me see if I find Jerome [18:30:24] Krinkle: shall we copy your todo list to an etherpad so we can track its progress? [18:30:30] ok [18:30:51] btw the announcement went live on the WMF blog last night [18:31:05] http://blog.wikimedia.org/2011/12/08/experiment-decision-making/ [18:31:31] Eating dinner now, will be keeping an eye in the background [18:31:55] sure, I'll go through the latest updates from Philippe in the meantime [18:39:43] DarTar: Hi Dario! [18:41:32] hey Jerome_ [18:41:45] sorry, preparing an etherpad with Krinkle's todo list for the deployment [18:42:06] Reedy should be able to help us with the actual deployment once he's back from dinner [18:42:24] Great. [18:42:55] So I received the urls of the new backgroud image and banner button from Philippe. [18:43:04] I'll be sending the new banner code to you shortly. [18:43:09] yeah I have just quickly scanned through it [18:43:10] thanks [18:43:43] How much time do you expect the deployment and testing to take before we can actually go live? [18:44:21] I am just thinkinh that I would be nice to still have Anne around if we want to check that everything is going fine indeed after the launch... [18:44:38] it depends on the dependencies (code review, finalization of the design) [18:44:45] definitely [18:44:58] and I won't be around between 11.30-ish and 2pm today [18:45:16] so I want to do as much as possible in the next 45 mins [18:45:39] Okay. I'll make myself available anytime today if needed. [18:46:38] We still have to send you the banner code, beyonf that, is there any technical point that we still have to work through from our side? [18:46:55] Per you yesterday message, I assume that the answer is no, but want to make sure [18:47:44] Jerome_ Krinkle Reedy - here's the todo list: http://etherpad.wikimedia.org/HarvardBannerDeployment [18:48:18] Jerome_: as long as we have the final images and CSS nothing else (other than availability for testing) is needed on your end [18:49:37] Ok. I expect this will be done within the next hour at the very last. [18:50:05] maplebed: btw, how did you change swift to make it work via coudfiles again? [18:50:08] Do we have a sense of when Timo is going to be available online? [18:50:13] you'll need to get someone with staff access to save the CSS if I am not around [18:50:19] he's online but having dinner [18:50:24] should be back shortly [18:50:28] Okay. Cool. [18:50:40] AaronSchulz: by 'via cloudfiles' do you mean authenticated or unauthenticated URLs? [18:50:44] I think authenticated, right? [18:50:51] yes [18:51:17] in swift, when you create an account, you assign an authentication URL. I had assigned that URL to 127.0.0.1. I should have assigned it to $proxy-address. [18:51:17] We, I guess I can ping Philippe about this if you're not around? Is is just about replacing the old banner code with the new one... What do you think? Is that possible? [18:51:35] yes [18:51:37] while it was set to 127.0.0.1, cloudfiles obeyed it and tried to authenticate against your localhost. [18:51:40] which obviously didn't work. [18:51:43] let me see if I can find him [18:51:46] heh [18:51:52] Okay. [18:52:34] AaronSchulz: I documented that (at least noted it) here: http://wikitech.wikimedia.org/view/Swift/Hackathon_Installation_Notes#using_swauth [18:53:38] Philippe is joining [18:53:45] he should be able to back me up if I am not around [18:54:08] Nice :) [18:54:57] So Anne is coming back online in a moment. I e-mail you guys as soon as we updated the banner code. [18:55:45] Right, so [18:57:41] great, I just sent around the link to the etherpad [19:00:28] Jerome_: regardless of the CSS, are the graphics I see here the final ones? [19:00:33] http://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_small_linebreak [19:00:44] it looks like the RCom tagline hasn't changed [19:01:37] I thought Anne wanted to add the text to the image itself? [19:02:09] No. We add the text ourselves to the image. [19:02:29] The button will also be different. [19:02:55] Smaller so that the layout is nice in small screens. Same thing with the Berkman and Sciences Po logos. [19:03:02] ach, I thought we had the final version of the images ready? [19:03:29] let me mark this as not done in the etherpad then [19:03:38] Yes. I sent the latest versions of the images to Philippe, but we now have to include their urls in the modified banner code. [19:04:13] So the images are ready, we just need to call them in the banner code! [19:04:26] right, ok, that's reassuring [19:05:16] DarTar: I thought we agreed on the no_linebreak version, the one you linked to has the line break issue [19:06:06] Yes. We will use the no_linebreak version. [19:06:35] Can you link me the latest version of what you want to be in the banner ? [19:06:42] then I can try it out first on test.wikipedia [19:06:51] I do have banner access there, not on meta [19:07:02] https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_prototype [19:09:19] Jerome_: No changes since yesterday ? [19:10:01] Wait a minute I am updating the code myself to send it. [19:10:11] ok [19:11:52] This will be done in 10 minutes. [19:12:58] (really sorry to put you on hold guys...) [19:15:33] Krinkle: sorry, my bad [19:16:06] I heard graphics are uploaded ? [19:16:16] yes [19:19:47] Krinkle: nice checkboxes :) [19:21:23] thx [19:22:33] Jerome_: Krinkle I expect to go offline in about 10-15' from now, is there anything I can immediately help with? [19:23:15] No, not right now. as soon as the final banner version is ready I'll update the prototype so that it;s ready for testing as soon as deployment happends [19:24:00] Krinkle: one general note, it looks like the name we chose for the settings is specific to the Harvard campaign, I am wondering whether we shouldn't use something more generic? [19:24:17] $wgNoticeBanner_Harvard2011['enable'] = true; [19:24:17] $wgNoticeBanner_Harvard2011['salt'] = "14"; [19:24:46] for future campaigns, that is [19:25:14] I know what you mean, but I think this way makes sense for now. Also because different campaigns will need different kind of settings. [19:25:49] ok, fine with me as long as we document them in the CN help page [19:25:53] and allows to prepate/develop multiple compaigns at the same time. [19:25:58] prepare* [19:26:03] fair enough [19:28:13] so Jerome_ can we mark the upload final graphics as done? There is not other image dependency still missing, correct? [19:29:00] Mail for you, Dario, Philippe and Timo. [19:29:43] Got it [19:31:04] test.wikipedia banner updated [19:31:04] excellent, this is what we are using, correct? https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_small_no_linebreak [19:31:14] latest version is now here: https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_prototype [19:32:05] we'll update the meta-banner once everything is confirmed to work on test.wiki [19:32:24] I'd say between deployment to test-wiki and en-wiki [19:32:26] looks good to me, the text of the button is not correctly vertically aligned though [19:32:38] Jerome_: ^ [19:33:20] other than that, the design looks fine and avoids the overlap problem [19:33:48] Jerome_: Alright if I change line-heigtht for button text from 1.6em to 1.9em ? [19:33:51] that seems to make it centered [19:34:01] Yep. Okay. [19:34:06] jh #wikimedia-commons [19:34:07] maplebed: yeah, swift still works [19:34:14] whoops [19:34:31] Jerome_: DarTar updated: https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_prototype [19:34:32] better now ? [19:34:46] way better [19:34:51] Looks fine. [19:35:08] maybe subject to cross-browser/platform font differences [19:35:24] yeah, testing right now on a few diff browsers on Mac OS [19:35:28] note that there is no font enforced on MediaWiki, just "sans-serif" [19:35:37] Hey DarTar :) [19:35:44] hey Philippe [19:35:45] Jerome_: What brwoser/OS you got at hand ? [19:36:01] Philippe: we are looking at: https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_prototype [19:36:19] That's the same version I just uploaded to meta? [19:36:25] Krinkle: on FF the vertical alignment is still not perfect [19:36:33] I'm use Firefox 8.0 / Windows 7 [19:36:46] Philippe: Except that the one on test.wiki has the javascript included [19:36:52] Ah, 'kay [19:37:22] Ah, I see, the script section [19:37:26] https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=HSP_final [19:37:30] gotta go, bbl [19:37:36] Philippe: can you delete the old two on meta ? [19:37:42] Sure. [19:38:00] The old versions (in case we really want them) are in http://grebdioz.sciences-po.fr/limesurvey/services/wikipedia/13/banner.php [19:38:06] 13, 12, 11, 10, 9, etc. [19:38:48] OK, they're gone from Meta [19:39:06] thx [19:43:06] So where are we, overall? [19:47:59] Banner design is final [19:48:23] Front-end javascript is final but only tested on prototype, not on a wmf wiki yet. [19:48:50] General todo: CodeReview and deploy to cluster, then test one more time and then push to meta-wiki ->central notice ->enwiki [19:48:54] see etherpad for full details [19:49:25] OK, sound good. Is there anything I can do to support at this point, or basically stay out of the way? [19:50:29] assuming Sam is indeed going to do code review and deployment, then we've for everything assigned, just waiting for it to happen [19:50:46] Excellent. I'll stay out of the way, let me know when you need me. [19:51:14] thx, will do [19:51:22] Krinkle: one naive question: is it normal that when I click on the Meta banner it does not redirect to our server? [19:51:26] I used to do so... [19:51:30] It* [19:52:00] Jerome_: test this instead: https://test.wikipedia.org/w/index.php?banner=Harvard_prototype [19:52:07] or rather, https://test.wikipedia.org/w/index.php?banner=Harvard_prototype_hardcoded_demo [19:53:37] does that work okay ? [19:54:45] Yep. It works, and I'm not eligible, as expected :) [19:55:03] actually, the hardcoded demo uses values for a test account I created [19:55:12] tfinc: examples of more "Wikimedia & Wikimania are cool" videos: https://www.youtube.com/watch?v=C1-MzHGA6fc https://www.youtube.com/watch?v=LuMRAijPu5I example of more dev-focused video for reference: https://www.youtube.com/watch?v=4zlGo-hrnt8 [19:55:13] it can't use your user details yet as the code for that isn't live yet [19:55:44] that needs support from server side, which is why I wrote last weekend and is going to be deployed today [19:55:57] I get a warning pop up before being redirected though [19:56:12] But I guess this is imbedded within my browser [19:56:21] popup? [19:56:40] "Although this page is encrypted, the information you have entered is to be sent over an unencrypted connection and could easily be read by a third party." [19:56:50] oh, aha [19:57:09] yeah, your using the https gateway from wikipedia [19:57:18] http://test.wikipedia.org/w/index.php?banner=Harvard_prototype_hardcoded_demo [19:57:31] if you go from there (not the difference with the previous one, https -> http) [19:57:38] from that one should be no popup, correct ? [19:57:57] note * [19:58:14] Krinkle: did you hardcoded non eligible metrics also, so that I cannot access the survey when I click on the banner? Is that correct? [19:58:39] Krinkle: correct! :) [19:58:50] "The token you have provided is either not valid, or has already been used." [19:58:55] the latter is most likely the case [19:59:23] Krinkle: so most users will not get the pop up? [19:59:43] do you get the popup when clicking the banner from http version ? [19:59:52] nope! :) [19:59:55] okay [20:00:24] then most people will not get a popup, only those aware and purposely choosing to connect through https (which isn't broadly promoted yet right now) [20:00:36] Cool. [20:01:01] it is indeed something the browser puts up, nothing we can do about it. [20:01:27] Krinkle: so why is it that I don't get logged in the survey upon clicking on the banner? You hardcoded non eligible metrics? [20:02:33] Jerome_: Where are you taken to when you click the banner ? [20:02:39] what does it say ? [20:03:05] Krinkle: "The token you have provided is either not valid, or has already been used. For further information contact Harvard SciencesPo (berkman_harvard@sciences-po.fr)" [20:03:21] The metrics submitted upon clicking the demo banner are totally valid [20:03:30] but we already submitted it during testing [20:03:36] Standard screen if user metrics are *not* eligible or if the user has already completed the survey... [20:03:36] users can't participate twice [20:03:40] They're one-time use tokens, right? [20:03:42] yeah [20:04:46] when entering a second time, the server will look if there's a session open. Science Po made it so that if users exit the survey they can pick up again within 30 minutes [20:05:02] So either someone has completed the survey with those hardcoded metrics or he has experienced a very long logout which resulted in his "token" being locked... [20:05:07] Exactly!! [20:06:06] Krinkle: so according to those rules, does the fact that I'm refused by LimeSurvey makes sense? [20:06:41] Yes, because many of the us on the team have clicked that banner from time to time and did everything to it we can think it [20:06:59] we can think of* [20:07:04] Okay. Then that's cool. :) [20:07:44] Krinkle: I would need to know precisely when the testing is over so that Anne can clean our database up before the study goes live. [20:07:50] This is a very important point. [20:08:03] ah, good point. [20:08:06] I'll let you know. [20:08:09] Thanks! [20:08:52] Krinkle: so are you gonna code the actual Meta banner so that it redirects to our server now? [20:09:42] Sorry but the meta-banner isn't relevant right now. Deployment will first go to test.wikipedia.org, that's where the latest version of the banner is right now. Once deployment is done I will remove the hardcoded values and test that it will auto-populate based on the current user. [20:09:50] if needed some adjustments to the banner will be made [20:10:02] Okay. [20:10:04] and then when deployment goes to the real cluster, we'll sync everything with meta [20:10:28] i'm afk for a few [20:10:31] I hope that makes sense :) [20:10:50] I assume that you know what we need and know what you're doing. I may get out of your way now, right? [20:10:59] I stay around just in case [20:11:20] sure. I got nothing else to do right now. [20:12:12] Krinkle: Ok. Great. Please keep me posted is something does not seem to go well or if any input from me is needed! [20:12:23] is=if [20:12:27] will do! [20:13:01] Krinkle: Thank you so much for all your hard work, also trying to understand what we implemented on our side! [20:13:07] You're great! :) [20:13:14] Thx! [20:26:20] Reedy: done ? [20:26:25] done? [20:26:29] eating [20:26:42] oh, yeah [20:26:52] Hence messing up jquery in core [20:27:06] and crying at SF [20:27:31] ..right [20:27:49] ahm, you got time now to check out the codereview/deploy for the harvard notice ? [20:28:38] 4 revs [20:29:13] yep [20:30:12] you may wanna review them as a whole (diff between before first and at last revision within ./extensions/CentralNotice/CentralNotice.php) [20:30:19] whatever you prefer [20:30:22] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/harvardbanner-deploy [20:41:49] Krinkle, would look fine [20:42:33] but ? [20:42:40] no buts [20:42:52] okay:) [20:43:01] ^5 [20:44:46] Reedy: So this can be merged to 1.18wmf1 for a spin on test.wikipedia.org? [20:44:59] just doing the merging now [20:45:00] http://etherpad.wikimedia.org/HarvardBannerDeployment [20:45:01] oh you're there already [20:45:03] awesome! [20:46:51] CN could do with a reorganisation post fundraiser [20:47:10] yep, for sure [20:49:17] Probably get beaten up if I tried it now ;) [20:49:53] You would, indeed. [20:50:06] hihi [20:50:08] But everyone up here agrees with you. [20:50:58] Krinkle, 105267 looks needed also? [20:51:08] !r 105267 [20:51:08] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105267 [20:51:18] yep [20:51:26] forgot to tag that one [20:51:34] it's only a style change though [20:51:51] yeah, might aswell clean it up to prevent any conflicts in futur [20:51:52] e [20:52:01] yep [20:59:25] Krinkle: Is everything shaping nicely on your side? I have a tab open with the banner deployment etherpad and things do not seem to get updated there... [21:00:38] most of them are small things, that will happen soon after another when deployment is done [21:00:54] Reedy: can you update the few things you did just now ? [21:01:14] Hmm? [21:01:28] Okay. Sweet. [21:01:34] http://etherpad.wikimedia.org/HarvardBannerDeployment [21:01:41] wrong window [21:03:46] grr. s [21:03:56] something is wrong with the phone lines; i can't call into any rooms. [21:04:15] can someone ping howie or whoever is in R1 that they'll probably have to call *me*? [21:04:38] he said, realizing that everyone currently active in the room is in europe. [21:12:59] Reedy: Looks like nothing crashed, good :) [21:13:11] Now for the configuration on testwiki ? [21:13:18] since it's disabled by default [21:14:37] CN is enabled on test [21:15:01] I don't think your echo is write Krinkle [21:15:14] using the ?banner= writes serialised php to the top [21:15:24] yeah [21:16:04] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105450 [21:16:05] + echo $salt . serialize( $hashData )."\n\n"; [21:16:09] debugging? [21:16:11] *Krinkle is fixing [21:16:13] indeed [21:17:25] !r 105591 [21:17:25] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105591 [21:17:53] that looks better and working [21:17:59] who did the portal esk drawing? :D [21:18:28] Jerome_ might know [21:19:15] WFM [21:19:27] https://test.wikipedia.org/wiki/Main_Page?banner=Harvard_prototype [21:19:34] where does the banner click take you ? [21:19:56] grebdioz.sciences-po.fr..... [21:20:04] error_01 ? [21:20:12] yup [21:20:18] shit [21:20:27] me too [21:22:39] jorm, phone errors reported. [21:24:13] Reedy: the background image was designed by our designed at Sciences Po Medialab. [21:25:04] Philippe: danke [21:25:25] Reedy, Krinkle: Please tell me if you need me to bring Anne in the discussion if that can speed up the process at some point. We need her to be still awake for the launch... [21:25:45] Jerome_: I'm skyping Anne now [21:26:04] *Reedy has nfi who Anne is [21:26:11] although I think she missed by message as Anne just quited Skype [21:26:20] Reedy: Anne is the dev at http://grebdioz.sciences-po.fr/ [21:26:43] the banner is a cross-domain form, not just a [21:26:48] Krinkle: Do you need her right now? [21:26:51] Yes [21:27:02] Okay. Let me see what I can do. [21:29:38] brb, for when she joins: "enable debug mode on login.php, I suspect the hashes don't match up" [21:30:17] Krinkle: I'm pinging her so that she joins us here. [21:31:54] Hi! [21:32:04] Hi [21:32:06] Hi Anne! Welcome to the (late) party! [21:32:14] Anne__: Can you re-enable debug mode ? [21:32:28] ok [21:36:56] debug mode enable [21:37:00] Thx [21:37:08] I can't test coz I don't see the banner [21:37:20] my user is not eligible? [21:37:29] i guess [21:37:29] could be a good reason? [21:37:32] oki [21:37:34] thanks [21:37:38] so I let you test it [21:37:46] and warn me if I can help [21:38:04] can you echo the string that goes into md5() ? [21:38:23] yes [21:38:27] just a question [21:38:28] $wgNoticeBanner_Harvard2011['salt'] = "14"; [21:38:34] is that our salt? [21:38:38] oh, 42 ? [21:38:43] should be another number not? [21:38:47] yep [21:38:47] yes [21:38:51] indeed [21:38:58] Reedy: Can you update CommonSettings.php ? salt is "42" [21:39:01] ya [21:39:49] and in CentralNotice.php we'll probably have to change line 275 v1 to v2 due to cache [21:39:54] ok I echo the string to md5() [21:39:57] done [21:40:04] memcached that is [21:40:27] wheeee [21:40:27] or can you clear memcached for that prefix ? [21:40:41] if you know the whole key i can purge it [21:40:56] wfMemcKey( 'CentralNotice', 'Harvard2011', 'v1', $wgUser->getId() ) [21:40:59] my id is 11903 [21:41:40] so mediawikiwiki:CentralNotice:Harvard2011:v1:11903 [21:41:53] testwiki I guess, but yes [21:41:59] klol [21:45:20] done [21:45:25] Anne__: I tested locally, the difference is indeed the salt. This will fix it. [21:45:47] nice [21:45:51] it's a good news [21:45:54] Yep, error_01 is gone now [21:46:29] Reedy: Can you confirm ? (perhaps clear the memcached for your testwiki userid as well, you can easily find that id by clicking the banner and seeing "login" userid [21:47:41] I'm getting text dump on a white page [21:47:47] yep [21:47:49] the last line [21:47:58] should say something that's not error*.php [21:48:01] yeah [21:48:03] url : /limesurvey/index.php?sid=... [21:48:09] awesome [21:48:18] Anne__: Can you disable the debug mode again? [21:48:26] ok [21:49:10] Philippe: ping [21:49:12] done [21:49:18] yes? [21:49:41] copy paste https://test.wikipedia.org/w/index.php?title=Special:NoticeTemplate/view&template=Harvard_prototype https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=HSP_final :) [21:49:51] {{doing}} [21:49:52] Research! [21:50:15] Krinkle, done [21:50:38] https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-HSP_final&diff=prev&oldid=3134785 [21:50:39] Awesome [21:52:02] Philippe: Alright, looks like it's all working [21:52:19] Reedy: disable testwiki and enable for enwiki ? [21:52:25] (the config lines) [21:52:39] mhmm [21:53:29] left enabled on test too atm [21:53:54] done [21:53:59] awesome [21:54:04] http://en.wikipedia.org/w/index.php?banner=HSP_final [21:54:08] it shows up [21:54:21] Indeed :) [21:54:25] (if mw.config wgNoticeBanner_Harvard2011 does not exist or is false, it does not show up) [21:54:39] Banner forwards me through okay. [21:54:45] me too [21:54:51] me too [21:55:08] just one last precision [21:55:15] clear database [21:55:24] i have to clean the database at the end of our tests [21:55:27] oki [21:55:39] Reedy: you heard it, delete enwiki database :P [21:55:55] our tests finished? [21:56:04] yeah tests are finished [21:56:12] will now the right experimentation begin? [21:56:17] Krinkle, that will probably take a while [21:56:17] Reedy: jk of course, it's working prefect. Thank you so much for the help! [21:57:18] Philippe: Jerome_ Anne__ okay so after you have reset the database (at which point we should no longer be clicking the banner for testing) [21:57:44] yes [21:57:53] i'm resting the db [21:57:55] I'll let it over to you (Jerome_ Philippe ) to decide how/when to create the campaign on meta-wiki and launch it for en.wiki [21:58:02] so no more test please! [21:58:13] reseting* [21:58:22] The campaign is created; it's just holding for a "go" [21:58:35] cool [22:01:00] Anne__: DarTar Philippe Jerome_ I'll be back online in about 2 hours -I gotta go for now [22:01:29] Reedy: just wanted to ask you for clarification, is it important to svn copy rather than svn move libraries into core? [22:01:38] Nope [22:01:47] Reedy: k [22:01:47] svn move is just a svn copy && svn delete [22:02:08] I know, but maybe there's some thing that makes svn copy easier to roll back than putting both together [22:02:14] not AFAIK :) [22:02:27] the history is all we really care about [22:03:14] it's ok for me [22:03:23] i'm ready :) [22:06:52] Okay. So everything seems sorted out and tested. Awesome guys! :) [22:07:05] hey people [22:07:10] Philippe: when do we start? Shall we ping Dario before we go? [22:07:13] Ah... [22:07:22] just came back from the talk [22:07:26] I want Dario to sign off on it, yes [22:07:26] how are things going? [22:07:27] But the campaign is set and ready [22:07:38] link? [22:07:59] *DarTar looking at the todo list, wow [22:08:40] Philippe: what should I sign off on? [22:09:02] Just let me know that the banner as it stands now is correct and good, and you're ready to go??? and I'll flip the switch. [22:09:20] (what is that scary "Tell Anne to clear the ..." ?) [22:09:34] So I understand the database is cleared now. [22:09:47] Yes, the tests we submitted until now are wiped [22:09:52] do you have a link handy to display it on enwiki? [22:10:44] ok got it from Philippe's email [22:10:56] Sorry bout that, was moving furniture, missed the request [22:12:17] Philippe: it'd be running on, say, Main_Page for logged-in users or are there blacklisted pages? [22:12:33] It'd be running everywhere but the Special: namespace, I believe [22:13:01] ok, the banner looks good to me and if you guys have tested it already I am happy to go live [22:13:08] Yes. Is there any reason why we shouldn't run it everywhere? [22:13:27] no, I was just asking [22:13:28] We can't really effectively blacklist by page anyway, so???. :) [22:13:39] OK, then, I'm going to send the campaign live. [22:13:41] we can for AFT, but not for banners [22:13:50] cool [22:14:10] did we update the CN calendar? [22:14:18] checking right now [22:14:22] not yet [22:14:36] ok let me do it [22:14:37] Campaign enabled. [22:15:00] yo [22:15:09] enwiki only; logged in only; until 12/12/12 unless I'm told otherwise [22:15:15] Wow. Big moment! :) [22:15:26] ha, I am not eligible [22:15:39] Philippe: correct [22:15:52] Me either :) [22:15:55] Philippe: yes, correct. [22:15:59] Lemme check my vol account [22:16:22] The banner is supposed to run right now? [22:16:23] Philippe you should be keeping an eye on how many responses you get so we can notify the Global Dev people over the weekend [22:16:26] thanks guys [22:16:40] DarTar, I don't think you meant me :) I can't check responses. [22:16:52] oops, I meant Jerome_ [22:17:27] Yes. I will report on the response rate periodically! :) [22:18:03] I don't see the banner, but maybe I am just not eligible [22:18:21] I created a new account today for the purpose of testing and I don't see it either. [22:18:31] This account should be eligible indeed... [22:18:49] It's definitely a live campaign ... [22:19:04] Getting 100% of the traffic [22:19:20] http://meta.wikimedia.org/wiki/Special:CentralNotice (green shaded ones are live) [22:20:27] Jerome_: did you and Timo test whether the eligibility check was working correctly? [22:21:07] DarTar: I did not do that. [22:21:09] I've got someone double-checking my campaign. [22:21:12] To be sure I didn't set it wrong. [22:21:32] I understand you tested the communitcation with your server, but not whether eligible users would actualy see the banner, am I right? [22:21:55] I think that's right. Anne can you confirm? [22:21:57] *DarTar trying with a different account [22:22:14] But it seems we already have 9 people connected... [22:22:21] Who are those people! :) [22:22:33] ha [22:22:45] are you sure they don't come from the override URL? [22:22:56] sorry, just trying to think of the worst case scenario [22:23:20] DarTar, I just logged out, cleared cookies, and logged back in and got it. [22:23:29] Ah. Really? [22:23:30] ha interesting [22:23:50] could that be because you had already dismissed the banner in the test phase? [22:23:55] Confirmed, the campaign setup is correct. Eliminate that from the list of possibilities. [22:24:03] No, I didn't dismiss it, but I followed it???. if that dismisses [22:24:15] I did the same [22:24:20] does that dismiss it? [22:24:27] Shouldn't from our side. [22:24:42] Unless there's something magical in their javascript [22:25:08] I understand that the specs required it should stick and not disappear after you click [22:25:14] correct? [22:25:34] Krinkle left, did he? [22:26:01] It appears so [22:26:44] Interesting???. from the banner allocations, (and I'm sure this is a result of our hacking), the banner doesn't even show on. [22:27:03] Reedy: did you review the code? [22:27:39] This is feeling like we missed something.... [22:27:40] Indeed [22:27:48] It seemed to work fine on test [22:27:49] Philippe: can you explain? [22:27:50] what [22:27:59] I should be seeing the banner in Special:Centralnotice's allocation screen [22:28:11] http://meta.wikimedia.org/wiki/Special:BannerAllocation?project=wikipedia&language=en&country=US [22:28:11] I now have 25 participants in the db [22:28:19] Reedy: do you know if after clicking once the banner sets a cookie to hide it to the user? [22:28:21] And I'm only seeing one banner running and it's not ours. [22:28:21] our banner should appear [22:28:48] participant number increases! [22:29:00] Yeah, we're obviously serving it to someone???. but who? :) [22:29:04] Philippe: any chance this will only list banners that are active for all logged in users? [22:29:10] No. [22:29:14] Well [22:29:16] I don't know. [22:29:20] We've never subset it before. [22:29:30] Ya'll wrote the code. :D [22:30:03] I think we need to double check with Timo as I understand one of the requirements is that the banner sticks after clicking to allow you to resume the experiment [22:30:31] There's a db that's polled to provide the allocation - I bet the banner isn't posting some flag there, and that explains the allocation thing. [22:30:36] if this is not the case Jerome_ may be losing completed responses for people who think they can resume [22:30:41] Yeah. I confirm, the banner should stick unless disabled to allow participants to log in again anytime. [22:30:44] should I see the banner on http://en.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal [22:30:44] oh I see [22:30:45] ? [22:30:57] Anne__: if you are logged in and eligible I presume [22:31:03] There is no code to set cookies [22:31:31] Reedy: so what happens when I dismiss it using the x? [22:31:49] normally you'll never see it again I guess [22:32:07] If we're using the Centralnotice functionality, that's added to the cookie. [22:32:23] We have a switch in central notice that adds that "hide" button [22:32:43] I presume it'll dismiss it for that time, but will come back on next page refresh [22:32:45] right, so Reedy you mean no cookie set except when the x button is clicked? [22:33:17] [22:33:29] not directly added, unless some other part of CN adds one [22:34:22] OH yeah, the Centralnotice hide functionality adds different code. [22:34:29] Close [22:34:58] ha [22:35:09] that was our mistake? [22:35:14] I can create a copy of the banner, add that code, and enable it and see if that fixes... [22:35:42] that would be really useful, sorry for bothering you with this Philippe [22:35:42] Philippe: now that you're doing dev stuff, I want to talk about some Liquid Threads bugs I want to see fixed. [22:35:52] Forget that, jorm [22:37:07] so assuming this is an issue that can be easily fixed in the banner itself with no change in the code, the other one is that the banner should advertise itself in the banner allocation table, correct? [22:38:14] Yes, once I enable it. [22:38:19] :) James is checking my code [22:38:29] (by which I mean, Kaldari's code) [22:39:03] Seems like you learn very quickly and efficiently how to be a great technical resource, Philippe. Thank you! [22:39:11] ok, I created a new account and I don't see anything, Jerome_ what were the eligibility conditions for new users? [22:39:13] (and to Kaldari and James also) [22:39:13] Please don't start that rumor. [22:39:20] a few days after registration? [22:39:22] They'll expect me to work. And I've got a plum deal here. [22:40:02] So if you create an account *after* the beginning of the campaign you should not be eligible... [22:40:13] ok as expected then [22:40:22] 49 participants [22:40:25] ?banner=HSB_final_2 [22:40:25] but my newbie sockpuppet DarTar2 should see it [22:40:28] But your regular account should work Dario, right? [22:40:30] I'm going to enable it. [22:41:11] shall you have 300+ edits and 20+edits in the last 180 days, then you should see the banner! [22:41:17] I don't see it as DarTar (an account that I presume falls in your experience editors segment) or as DarTar2 (newbie alias predating the campaign) [22:41:17] Still not showing up in Banner allocation. [22:41:45] and these are enwiki edits, not global contribs, right? [22:41:55] all en:wp edits [22:41:56] We're currently running two banners on this campaign, split at 50% each. Neither is showing up in banner allocation. [22:43:07] I wonder???. if the reason is because the other campaign is running preferred. [22:43:37] Jerome_: I definitely have 300+ global edits and 20+ in the last 180 days so if we are not sampling eligible users I should see it [22:43:49] If so, it would be pushing out everything but the US edits (and not displaying in the US) [22:43:50] I'm confused about that: which other campaign, Philippe? [22:43:57] Yeah, james confirms, We're going up to priority. [22:44:03] Jerome, the fundraising campaign that's running to anonymous. [22:44:08] OK, I think we found the bug [22:44:14] Ah! Ok. [22:44:19] oh hang on [22:44:36] I see it now on a clean browser (no cookies left) [22:44:45] and on a Special page [22:45:01] OK, the way it works: "Prefered" campaigns push out everything else. The fundraising campaign is preferred and - even though not serving to anon - was pushing out any other campaigns within the US. [22:45:04] and it's sticking across multiple pages [22:45:17] Philippe: good catch [22:45:18] So preventing ours from running. Everything OUTSIDE the US was working fine, which explains the connections. [22:45:20] We are sampling eligible users. We double check the metrics on our end before letting users in. If they are not eligible, they would not be allowed in. Still, we have participants... [22:45:36] So we were serving fine, just not in the US. [22:45:49] ok [22:45:55] Okay, so we are serving the World but USA, right? [22:45:59] can that be corrected or not? [22:46:10] Jerome_: what I mean is we are not sampling users after the eligibility check, we display it to 100% of the eligible logged in population [22:46:26] Now, we're serving everyone who fits your criteria. We fixed the problem. [22:46:26] correct? [22:47:23] DarTar: yes that sounds like the way it should be done: display it at 100% to 100% of eligible logged-in users. [22:47:44] interesting I have two sessions opened in two different browsers, same user name, only one browser gets the banner, I guess that's because of my banner-dismissed cookie [22:47:58] OK, configuration wonkiness with the CN system. Noted for next time Kaldari is bored. [22:48:00] on the first browser [22:48:24] Philippe: that was really fast [22:48:37] Service with a smile. :D [22:48:59] eh, whad I miss? [22:48:59] *DarTar trying if the banner sticks after clickthrough [22:49:25] kaldari, a campaign set as preferred but anon only was forcing a logged-in-only campaign to not show. [22:49:35] ok, I am eligible and I do see the landing page [22:49:40] It would be ideal if those were separated (logged in versus anon) [22:49:50] So I'm testing it now with an eligible account (Mako's account). The banner is displayed. [22:49:53] and the banner sticks after clicking as expected [22:50:04] cool [22:50:05] campaigns aren't targeted to logged in users, only banners are [22:50:07] no problem on my end then [22:50:17] Right, but the only banners on the campaign were logged in. [22:50:31] other than the cookie that I probably set while we were testing [22:50:33] So, one campaign is only showing logged in. (Ours). Another is only showing anon (fundraising) [22:51:30] For the record, the allocation feature made all the difference in tracking that one down. I owe you a bottle of something. :D [22:52:27] w00t, i've got the banner too. [22:52:30] Philippe: is that something Krinkle should tweak so that it shows up there? [22:52:35] hey lucky you [22:52:47] Okay. I confirm: the banner sticks after a logout and when you relog in the study you end up exactly where you experienced the logout in the first place. [22:52:47] DarTar, nah. It's fixed by just sending our campaign to preferred. [22:52:54] That's very good news. [22:53:02] you can take the survey, earn money and donate it to Wikimedia :D [22:53:09] nice [22:53:21] Or to the "keep Kaldari full of booze" fund.... [22:53:27] Jerome_: same as what I experienced, good to hear [22:53:29] Yep. Please take our research money. That's why it's there for!! :) [22:53:39] how'd you fix it? Did you just mark them both as preferred? [22:53:44] Yep [22:54:15] Jerome_: how are you handling the donation options? You ask participants to trust you will transfer the donations? [22:54:25] to WMF or RedCross? [22:54:42] exact [22:54:51] should I trust you? :) [22:55:00] but we'll send an email at the end of the experimentation [22:55:11] DarTar : no you don't [22:55:25] The PCs were suggesting we add multiple levels of "preferred", but I actually think that would lead to more problems like this rather than fewer. [22:55:33] 223 particpants [22:55:35] Jerome_ looks a little shift to me???. he might keep my booze money. [22:55:38] WMF will have access to the whole anonymized logs anyway as per the agreement you signed so you guys can't cheat :p [22:55:44] kaldari: I agree with you [22:55:52] Well, take the survey, Dario: trust is part of the story, and you'll get a chance to tell us whether you trust us with the money or not! [22:56:17] just teasing ;) [22:56:27] Wow!! 223 is impressive! [22:56:40] but funny how we didn't formalise the donation requirement in the agreement [22:56:44] Yeah, I imagine the jump happened because we went live within the US [22:57:00] we'll come and chase you down in Paris or Cambridge or wherever you are [22:57:15] Jerome_: these are not completed responses yet, right? [22:57:29] if they are you really owe us some booze [22:57:45] and we can shut this down in a couple hours, if those are completed :P [22:58:05] Philippe: that's actually the understanding with Global Dev [22:58:19] yup [22:58:45] DarTar : you're right [22:58:49] I'll be happy to shut it down tonight if we get our target number of responses! :) [22:58:58] that' just starting participants [22:59:00] What's the number again? 2K or something? [22:59:06] if you have a high completion rate (and considering it's too late for Europe) I am confident you'll reach the target by Monday [22:59:21] min 1300 responses right? [22:59:39] 265 participants now [22:59:56] Among experienced users yeah! [23:00:09] Yeah, thats gotta be US, and the European late folks. [23:00:23] guys - someone just mentioned you're running a banner offering money for people to fill out a survey for Harvard... [23:00:27] that's interesting ??? can you already see the breakdown by category ? [23:00:45] (should now come from #wikimedia-fundraising) [23:00:50] yep, sure! [23:00:54] Nemo_bis: tell Jerome_ he should be available 24/7 to answer those questions [23:01:04] See you guys [23:01:09] bye Anne__ [23:01:18] keep up posted on how you are doing [23:01:22] I have to go to sleep [23:01:32] OK, I'm out too???. I have a meeting. [23:01:37] see you tomorrow for the first email checkpoint [23:01:37] BarkingFish, Nemo_bis: tell Jerome_ he should be available 24/7 to answer those questions [23:02:12] My quote of the day: "For each wrongly rotated image you find, you may slap a MediaWiki developer of your choice." https://commons.wikimedia.org/?curid=45008 *spamming since it matches the channel topic* ;-) [23:02:39] Nemo_bis: ok, cheers, If it's only a localized banner to the US, seems a bit of a downer... I could do with $50 coming up to christmas :) [23:05:19] Nemo_bis: I'll be around as much as I can to answer to Wikipedians. [23:05:35] I hope my mailbox will handle this!!! [23:06:09] Jerome_, I think BarkingFish wants to know whether this banner is only for USA and why [23:06:25] *Nemo_bis has no questions [23:07:30] not the why, just the whether it's for USA only [23:07:43] I never say no to free money, regardless of where it comes from :) [23:10:17] No. It's for *enwiki* [23:10:22] no geo targeting. [23:10:45] WHOO! [23:10:49] Thank you :) [23:11:06] When someone mentioned "Harvard" - I thought it would be geotargeted to USA only [23:11:07] I see it from Italy indeed [23:11:19] and Chromium complains about unsecure content [23:12:14] What do you mean by "unsecure content"? [23:13:31] more complaints in wikimedia-rcom [23:13:39] Jerome_: shall I just redirect people here? [23:14:09] the two logos should be protocol-relative [23:14:53] Yes you can. or you can tell them to email us directly so that we can take the time to answer properly to each... [23:15:20] The central notice currently running - http://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail¬ice=Harvard+Sciences+Po - appears to be an advert for two non-wikimedia organizations. Can it be taken down please? [23:16:03] *aude wonders what happened to simple, smaller text notices for stuff like this? [23:16:33] The page at https://en.wikipedia.org/w/index.php?title=Special:UserLogin&action=submitlogin&type=login&returnto=Septimus+smith&campaign=ACP1 displayed insecure content from http://upload.wikimedia.org/wikipedia/en/8/89/Berkman_Center_logo.png. [23:16:50] Fae: Jerome_ from Harvard is here to answer specific questions on the project [23:16:52] and from http://upload.wikimedia.org/wikipedia/fr/thumb/d/d5/Institut_d%27%C3%A9tudes_politiques_de_Paris_%28logo%29.svg/300px-Institut_d%27%C3%A9tudes_politiques_de_Paris_%28logo%29.svg.png. [23:17:31] Should be easily fixable [23:17:33] I don't want to ask specific questions - I don't want to see a CN that appears to advertize other organizations whether they are charities or not. It runs against our values. [23:17:48] it does seem rather unprofessional [23:18:09] on WMF's side the project has been reviewed by the Research Committee and we announced on the blog why we are supporting this research, have you read the post? [23:18:15] It gives me an immediate headache for the WM-UK charity. It breaks our understanding of the fundraiser agreement. [23:18:33] Fae: a few clarifications, [23:18:51] Fae: the basic gist of this is not to advertize any organization. The banner features our logos so that people don't actually get wrong expectations about who is running this study. [23:18:53] Supporting the research and carrying other people's logos in a banner ad, are different things. [23:19:07] especially if over HTTP! [23:19:09] j/k [23:19:34] It appears to be an advert, it will be read that way despite good intentions. [23:19:35] the banner is only displayed to (1) logged in editors, for whom the fundraiser is already disabled and (2) a subset of these editors who are eligible [23:19:55] Can it be taken down now, while this is discussed please. [23:19:56] Fae: I would expect many people to get mad if they thought this study was run by WMF and eventually get redirected to a third party website. [23:20:08] So we want to be transparent from the very beginning. [23:20:11] someone have a link to the WP:AN discussion on this? [23:20:19] there was one, I read in the blog [23:20:44] brb [23:20:45] <^demon|away> At the very least, upload the images to commons. [23:20:53] <^demon|away> Rather than remote loading them. [23:21:25] To repeat, this notice should be removed now. This is a press disaster in the making. [23:21:54] ^demon|away, they're already on Commons, they just need to be protocol-relative [23:22:10] very easy to do, but I'm to lazy to look for the string to be fixed :-p [23:22:28] " and extensively discussed on the English Wikipedia Administrators? noticeboard" [23:22:32] does someone have a link to that? [23:22:34] I cannot find it [23:22:42] Jerome_, does "an open access license" mean OA gold? [23:22:52] <^demon|away> Nemo_bis: Ah ok. [23:23:11] I've just moved the 2 images to https [23:23:20] Reedy, thanks :) [23:23:40] protocol relative ones are used for the background [23:23:44] I wonder how well they work in links [23:24:31] Okay, I have left a message for Philippe at http://en.wikipedia.org/wiki/User_talk:Philippe#Central_notice_for_Berkman_and_SciencesPo [23:24:32] Nemo_bis: we will release our paper under an open access licence, yes [23:24:34] could someone answer my questions? [23:24:35] SciencesPo prefix:Wikipedia:Administrators' noticeboard [23:24:39] http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Search_banner_Wikipedia_Research_Committee [23:24:39] returns nothing [23:24:46] Protocol rel ones work fine [23:24:54] changed to prot rel [23:25:15] ha, I made a null edit, you edit conflicted me :) [23:25:44] my summary was "protocol-relative is better I guess, someone said the secure servers could melt if they receive all banners requests", I wonder if someone can say whether such worries are justified [23:28:05] Can I confirm that nobody is prepared to take down the current central notice that advertizes SciencePo and Harvard? [23:28:26] If that is clear then I can take up a position with the WM-UK board. [23:28:28] Nemo_bis: they are [23:28:46] Prodego, even for protocol-relative versions? [23:28:53] relative no [23:29:06] Fae: you may want a more formal response from dar then, but I doubt it would be a problem [23:29:09] it just looks bad [23:29:24] Prodego, see https://meta.wikimedia.org/wiki/User_talk:MZMcBride#Re:_Special:AbuseFilter.2F42 [23:30:01] Prodego: Sorry it does not just "look bad" it contravenes the basis on which the UK charity passes funds to WMF. That is why it is an issue for my chapter board. [23:30:18] Fae, Prodego - I am back [23:30:20] Fae: ok [23:31:00] Fae I appreciate this may be causing problems on WMUK end, can I ask you to mail Philippe and myself so we can address this? [23:31:33] Nemo_bis: relative is good, http only is ok but not great [23:31:37] https only.... [23:31:38] I have left a message at http://en.wikipedia.org/wiki/User_talk:Philippe#Central_notice_for_Berkman_and_SciencesPo - not sure it need an email saying the same thing. [23:32:11] While you think about it, can you please take down the advert. [23:32:17] Prodego, so could you tell Jseddon ? [23:32:29] he is not available right now, but I told him about this [23:32:32] Nemo_bis: that filter is ok [23:32:42] I'm not sure it is worth it, but there isn't anything wrong with that [23:32:56] at least the way I understand it [23:33:21] It's not an advert, it's a survey by two universities. [23:33:37] Fae: I don't think we can as we have a signed agreement with the team that we will support them in recruiting participants as approved by the RCom and discussed in community fora [23:33:56] DarTar: could I please get a link to that AN discussion? [23:33:58] If it looks like an advert (it carries their logos) it will be seen as an advert by the public. [23:34:00] I cannot seem to find it [23:34:09] Jerome_: do you have the link handy? [23:34:15] Fae: but it only shows to a subset of logged in editors... [23:34:22] Not "the public" [23:34:28] DarTar: which link? [23:34:44] the banner displays the logos for transparency to identify the teams that we are supporting [23:34:55] I see two logos with "Please help" under it. That only logged in editors can see it does not stop it being public or an advert. [23:34:58] Jerome_: Prodego: DarTar: could I please get a link to that AN discussion? [23:35:17] It is hardly an advert, it is giving people money, not asking for it. [23:35:18] Sorry, it still appears like a press disaster for our critics. [23:35:53] Fae: have you read the blog post, the project description on Meta and the discussion? [23:36:00] well it might be better if it only appeared for editors with more than 10 edits or something, or was a watchlist notice [23:36:03] Fae: Please consider what would happen if we didn't say the survey is run by Harvard. You would assume it's WMF and get directed against your will to third party web-site... This, in my view, is what would be wrong from an editor's perspective... [23:36:08] What's the real issue here? Two universities doing a research project. [23:37:00] DarTar: let me find the link to the AN discussion! [23:37:12] No, I saw the advert. That the project is a good one is not really the point, or that you think Harvard is worthwhile. I have a stack of UK universities that would love this free publicity. [23:37:27] whether it's an advert or not, it loads resources from a third-party, and that violates our privacy policy [23:37:38] did someone else already mention this? [23:37:42] Ryan_Lane: well that you can fix [23:37:49] Ryan_Lane: it's been reviewed entirely by Legal [23:37:57] My chairman has been contacting me by email, he has exactly the same problem with this advert. [23:38:26] Sorry, that the advert is "legal" does not mean it meets our values or gives the impression of meeting our values. [23:39:01] I am also seeing tweets from other chapters noticing this advert as being a problem. [23:39:06] So here is the AN thread about whether and how we should advertize this study on en:wp: http://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard/Archive222#Researchers_requesting_administrators.E2.80.99_advices_to_launch_a_study [23:40:34] I see the AN thread, where is there agreement to put promotional logos for other organizations in a central notice? [23:41:21] seems like everyone actually opposed that AN thread [23:41:28] ignore me. I was misunderstanding the situation [23:41:33] the discussion has been closed immediately after the proposal, apparently [23:41:34] Right, well that worked out quite well. That's a very useful little piece of fun [23:41:41] That's not discussed here. What is discussed here is the way by which we should invite people to participate in this research endeavor(i.e. CentralNotice) [23:41:41] I was being told we were *loading* resources from a third-party site [23:41:50] and that apparently isn't the cae [23:41:52] *case [23:41:56] So, can we take down this advert now? [23:41:58] Thanks for having that enwiki wide, that's just gone towards my christmas fund :) [23:42:19] Ryan_Lane, no, only hard-coded HTTP Commons URLs :) [23:42:29] yeah. that's totally fine [23:42:50] Prodego: the original proposal in the thread was to have a bot deliver talk page invites. That's what they were opposing at the time. [23:42:51] well, almost; protocol-relative is [23:43:00] :D [23:43:01] heh [23:43:06] well, at least that should be fixed [23:43:11] if it's causing mixed-content [23:43:51] Prodego: actually, if you read the AN discussion, you'll notice that we initially proposed another way to bring this study to Wikipedians. [23:44:11] it isn't like this is the first time a project ran a sitenotice about a wikimedia related research project, or some wikimedia related thing [23:44:29] That's what Wikipedians were unconfortable with, and they suggested CentralNotice instead. [23:44:42] when I talked in japan they put information about it in the sitenotice for like 3 weeks, linking to the conference's site [23:44:47] on jawiki [23:44:56] the community did that, not wmf [23:45:04] This was back in march. We were ready to launch at that time and changed the overall process to meet those requirements. [23:45:05] DarTar: Raised the same comment as per Philippe's page on yours asking for the CN to be taken down. [23:45:07] I don't see how this is much different [23:46:02] Which basically took us until now to do, in what is in my mind a beautiful example of a research collaboration between research universities, the Wikimedia community and WMF... [23:46:54] Fae: thanks, as I said above we are not in a position to take it down as their is an executed agreement between WMF and the research teams, supported by an approval of the RCom, but if there are concerns on how this legally affects WMUK I strongly recommend you post an OTRS request so we can address it [23:47:58] Okay, it's my bedtime here. I'll send an email out to trustees and ask what our next step ought to be. If necessary we can seek legal advice tomorrow. I will point out that my request to remove the notice in the meantime was rejected. [23:48:07] Jerome_, https://meta.wikimedia.org/wiki/Research_talk:Dynamics_of_Online_Interactions_and_Behavior#Open_access_license [23:49:41] Thanks Nemo_bis. I'll answer that! [23:50:46] DarTar: Presumably by OTRS request you mean the legal email address? [23:51:29] Fae: correct, but if you just send to the standard email address it will be triaged so the appropriate people at WMF can deal with the request [23:51:57] Okay, writing up an email for my trustees and the CEO now. [23:54:06] Apparently Roger has independently complained to Zack. [23:54:29] As you can imagine, even though it's 5 mins to midnight here, it's a hot issue for us. [23:55:04] Fae: I'm really sorry that you take this as an ad indeed... [23:55:17] Let me repeat, I am very uncomfortable that the response from the WMF is to leave an advert in place rather than taking in down whilst being contested. [23:56:15] Fae, I think it's too late [23:56:15] We developed that project in coordination with the community and WMF. The choices we made were always centered around community compliance and respect. [23:56:52] Which was the key thread that demonstrated community support for carrying logos in a banner ad? [23:56:53] We are not here to advertize ourselves, but to advertize the Wikimedia community, I would say! [23:57:26] The Wikimedia community is not Harvard or SciencePo [23:58:38] Sure, I agree Fae. What I want to say is that the purpose of this is to do research that will benefit the community + taking an opportunity to spend our research money in a way that possibly helps the project. [23:59:13] If I have some favourite institutions, can I set up a research project and get them free advertizing in this way too? [23:59:37] If I find some commercial organizations, can I then do the same thing? [23:59:44] If feature Berkman and Sciences Po's names on the banner, it is to make sure that people don't get wrong expectations or misunderstanding about who is runnin this. [23:59:55] I'm sure Glaxo would be interested.