[01:21:52] new view on the revisions: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.19/Revision_report#New_revisions_by_author [07:46:17] meta not adjusting link for https connection. what do? [08:09:23] meta not adjusting link for https connection. what do? [08:50:23] meta not adjusting link for https connection. what do? [10:33:04] good morning [10:34:00] hashar: the following also prints an indented view of an object o: JSON.stringify(o, null, 2); [10:56:17] ohh [10:56:23] didn't know about that [10:56:40] I added until.inspect because I have not been able to find the documentation for JSON.stringify() :D [10:56:46] looks like they use the same args [12:57:37] Reedy: hello :) Is there any point reviewing the Context extension or should I just mark those revisions deferred ? [12:58:05] Contest you mean? ;) [12:58:13] yes sorry [12:58:25] It's deployed on WMF.. but I'm not sure if they are likely to be pushed to site [12:58:28] as it's not being used atm [12:59:12] wasn't it used for the code contest in november? [12:59:28] there might be another contest set up one day though [13:00:33] yup, it was [13:00:34] <^demon|away> Maybe we'll review it then ;-) [13:00:40] yeah [13:20:41] is there an easy way to mark one's own commits to a particular path as deferred in bulk? [13:27:00] <^demon|away> gwicke: You can append ?author=gwicke&path=/trunk/foo to the url [13:28:32] ^demon|away: ok, that gives me the list- how do I perform the action in bulk? [13:28:50] <^demon|away> You should see checkboxes on the left and a status changer at the bottom. [13:29:27] <^demon|away> Oh, you don't have +coder, lemme fix that. [13:29:32] ok- then I am either in the wrong tool or don't have the rights for it [13:29:43] ;) [13:29:48] <^demon|away> Ok, gave you the group, you should see it now. [13:30:07] thanks! [13:30:30] <^demon|away> You're welcome. [17:05:03] hi yuvipanda [17:23:35] sumanah: heya [18:16:35] Nikerabbit: ping [18:16:48] Nikerabbit: what is wrong with http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104518 now? [18:19:52] Don't use empty if the variable is always set. getLocalUrl accepts also an array of parameters and does the escaping for you in that case. [18:20:04] Nikerabbit: it's NOT always set [18:20:19] and in includes/specials/SpecialUserlogin.php: it is done this way $returnto = '&returnto=' . wfUrlencode( $this->mReturnTo ); [18:20:33] so, that is the example I followed [18:20:59] mediawiki is full of bad code :) [18:21:03] Nikerabbit: so, I don't feel that it is a fixme [18:21:53] $userlogin = $this->doc->getElementById( 'userloginForm' ); [18:22:02] as far as I can see that variable is defined always [18:22:15] Nikerabbit: defined yes has value no [18:22:25] Nikerabbit: it only has a value on the login page [18:22:28] the problem with empty() is that it suppressed typing errors, and considers things like '000' as invalid [18:23:05] Nikerabbit: but, that isn't an issue in this case [18:23:25] looks like in this case checking if ( $userlogin ) would be enough, since it is an object or null it seems [18:23:55] Nikerabbit: I really don't think it needs to change [18:24:52] well [18:25:04] then leave a comment saying so and wait for someone else to mark it ok [18:26:27] okay? [18:36:21] What's so hard about using `( array( 'action' => 'submitlogin', 'type' => 'login', 'returnto' => $returnToVal ) )`? [18:36:44] Dantman: nothing it's here http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105324 [18:37:21] mmm... what happened to type => login? [18:38:41] Dantman: it's here http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105325 [18:39:20] Hmmm.... [18:39:35] :/ want code modification to wfCgiToArray [18:39:46] Dantman: why Hmmm... [18:40:00] 'foo' => null should ommit the key [18:40:14] doesn't it do that already [18:40:36] Nope, it looks like it doesn't [18:40:40] Hence why I said that [18:40:50] > echo wfAppendQuery( '/', array( 'foo' => 'bar', 'baz' => null ) ); [18:40:58] /?foo=bar&baz= [18:42:04] Same after a svn up [18:42:48] ^demon: so, it should be: - if ( !empty( $returnToVal ) ) { [18:42:49] + if ( !$returnToVal ) { [18:42:59] <^demon> Something like that. [18:43:05] <^demon> I'm going through MobileFrontend now. [18:43:16] <^demon> And trying to remove all of the empty()s [18:44:08] ^demon: well, if you are going to do that make sure you test everything really well [18:48:53] Nikerabbit: everything should be corrected as of r105329 [18:49:09] Nikerabbit: see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105329 [18:49:34] looks good [18:49:42] I'll let ^demon nitpick about the whitespace [18:50:15] Nikerabbit: where? [18:50:43] get_class( $userlogin ) [18:52:14] Nikerabbit: fixed in r105332 [18:52:40] good [18:53:01] ^demon: are you going to review those? [18:53:55] ^demon: I thought that we wanted to stay away from isset? [18:54:12] <^demon> Only when checking for null. [18:54:24] <^demon> For checking if an array key exists and is set to some non-null value, it's fine. [18:55:07] ^demon: okay, just clarifying [18:59:52] Hey [19:00:04] <^demon> preilly: Something that would be super helpful in those views files...perhaps a comment at the top of the file saying what file/function/etc is calling the view in question. [19:00:04] Hey, Timo! [19:00:13] <^demon> Right now there's no context and things like self:: make no sense :) [19:00:24] indeed, no context [19:00:28] what's this about :P [19:00:49] we have context? [19:00:57] <^demon> The line right above it before jorm went and interrupted me :) [19:02:02] ^demon: okay [19:02:32] i am in two meetings at once with this, just fyi. [19:02:49] why is there a meeting double booked? [19:02:57] what meeting are you also in? [19:03:30] hehe, yeah with IRC we can have double meetings without bumping into each other in the same room :P [19:03:45] hey everyone [19:03:52] A San Francisco hackathon discussion. [19:04:35] good evening [19:05:06] it's not a big thang, though. [19:06:31] surrur [19:07:46] So, things in the docket, overall: many discussions about Moodbar/Feedback dashboard, plus enhancements on that. [19:08:08] Discussing revamping the notification system [19:08:30] (Don't forget to add to the etherpad too) [19:08:36] Working on Narayam design stuff but haven't gotten very much work done over what happened in India [19:08:47] DarTar: I'm currently in email back/forth with Anne from Science Po. It appears there implementation we both have of the communication protocols don't match. The banner doesn't "talk" properly and the server doesn't' process it properly. Working on getting it into sync now (I think it's something on their end, but we'll find out for sure soon) [19:09:35] Krinkle: sorry to hear that, is jerome around on IRC? [19:09:46] not sure [19:09:58] I'm just going to make a section, "This is what brandon is working on" because only about 1/2 the projects are there and I don't like having to search for everything. [19:09:59] where does jerome work again ? [19:10:29] he's currently at Harvard [19:10:43] he's online on skype, just pinged him [19:10:51] http://etherpad.wikimedia.org/FeaturesTeam20111206 [19:11:14] DarTar: Does/Can he do development on the survey server ? [19:11:40] the email thread between me and Anne@science-po is without any CC [19:12:06] I thought the developer on their end was Paul [19:12:18] Paul Girard [19:16:22] DarTar: Want me to CC him ? [19:16:35] yeah [19:17:24] meta not adjusting link for https connection. what do? [19:17:39] splatree, where? [19:17:48] there are some rogue admins not using protocol-relative links [19:17:57] user namespace [19:18:06] oh well, that's not our fault [19:18:30] <^demon> Those rouge admins, and their lack of protocol-relativeness [19:18:43] it adjusts on pedia [19:18:52] splatree, crappy JS magic IIRC [19:20:03] crappy javascript magic something internet relay chat? [19:20:18] it is very quiet for a staff meeting ;-) [19:20:18] splatree: $('a').attr('href', function(i,val){ return val.replace( some regex, '//' ); }); [19:20:19] splatree, uh? I mean on en.wiki [19:20:28] iirc, if I recall correctly [19:20:33] TrevorParscal: do you have some time to chat about the parser integration? [19:21:07] DarTar: done [19:21:08] I will after lunch time - when are you done for the day? [19:21:33] TrevorParscal: maybe one more hour [19:21:42] so around 12 your time [19:22:00] or 12:30 [19:22:05] i added some updates to the Internationalization and localization tools part. [19:23:07] splatree, if you find the JS script used by en.wiki (which last time I checked was broken, btw), check it etc. you can request it to be added to the relevant system message with {{Edit Protected}} and patiently wait [19:23:30] more common english, please. I'm not that informed [19:23:42] gwicke: got time tomorrow? [19:23:52] "iirc"? [19:24:16] splatree: iirc= If I Recall Correctly [19:24:29] TrevorParscal: only until 9:30 (18:30 here) [19:24:51] but I can stay up a bit longer today [19:24:54] :facepalm: oh [19:24:56] splatree: The english wikipedia community developed a script for/by themselves that looks on the page after it is loaded and changes http:// to // for some links. it doesn't edit the pages, just changed it in the display [19:25:02] one could create a similar script for meta [19:25:03] Krinkle: jerome is joining in a moment [19:25:08] DarTar: oke [19:25:14] or he's already here ? [19:25:24] Jerome___: [19:25:30] I see you've grown a tale :) [19:25:38] Krinkle: I'm here! [19:25:56] Jerome___: Did you get my email just now ? [19:26:10] TrevorParscal, did you get a chance to take a look at https://www.mediawiki.org/wiki/Visual_editor/Bidirectional_text_requirements ? [19:26:25] The sample Anne provided causes a Fatal error in php. Can't add an array to an integer. [19:26:46] I know how to make it work, but it needs to match what you have on your end. [19:27:25] Krinkle: didn't get your e-mail yet. [19:27:31] aharoni: yes, we aren't able to work on that stuff yet though [19:27:46] Jerome___: eh, sorry. I sent it to Paul [19:27:47] gwicke: I can do early tomorrow morning [19:27:52] don't bother staying up tonight [19:28:01] Jerome___: Are you a developer on the survey server too ? [19:28:14] TrevorParscal: ok, I'll be around [19:28:28] Krinkle: Nope, I am not managing the server. [19:28:32] ok [19:28:53] Krinkle: I can help you as far as the "big picture" is concerned only I fear... [19:29:25] Jerome___: yeah [19:29:46] Anne and Paul are based in France (which is not my case), so this is a useful information to keep in mind for coordination matters. [19:30:11] Jerome___: I think that (big picture) is what we got matching in harmony right now. It's just a few technical matters left. [19:30:17] Krinkle: I would suggest that you write to them directly to solve all pending technical banner issues while keeping me in the loop... [19:30:23] Jerome___: I'm based in the netherlands. [19:30:33] Jerome___: I'm based in the netherlands. [19:30:39] Krinkle: oh, that's cool then... [19:30:59] although I only work outside office hours [19:31:11] I see... [19:31:26] so my schedule matches more that of San Fran :P [19:31:34] So I'm really sorry it appears that I cannot help you out right away on this one... [19:31:43] ok?? [19:31:59] :) [19:32:04] krinkle: one, but probably not me; what can i do to relativise links on meta? [19:32:32] in the meantime [19:32:48] interwiki [19:33:23] Krinkle: so did you make a precise summary of all technical pending issues to Paul already? [19:33:38] splatree: Adress the issue on a public place on meta and wait for a developer or sysop to help you. [19:33:41] Jerome___, Krinkle: how long do you guys think it will take to address these issues? [19:33:51] (i.e. it is normal if I don't see any exchanges going through my mailbox? Don't have to worry? :) ) [19:33:52] Jerome___: yes, I sent it to Anne and Paul a few minutes ago. [19:34:26] The sooner we launch, the lower the risk of overlap with the editor survey (as we only have a few days to run Harvard at 100%) [19:34:28] oh we have a meeting? [19:34:35] Krinkle, DarTar: I think now we are pretty close as far as login process is concerned. The problem now is coordination, right? [19:34:36] Jerome___: I'm pretty much done at this point, they are too. but it appears we both implemented the connection protocol in a different way. We'll have to make sure they match, otherwise the banner and the server can't "talk". [19:35:17] they're both talking now, but in different languages, so to speak. [19:35:34] ok, so I assume it's not a major blocker, right? [19:35:44] I also have Tilman ready to help with the blog post. Jerome___ what news from your legal team? [19:36:46] DarTar: So Yann Algan at Sciences Po is the principle investigator of the European Research Council research grant that funds this project. [19:37:37] DarTar: so as the European Commission sets the privacy requirements and all related issues, Yann Algan at Sciences Po should be the one signing the agreement. [19:37:56] DarTar: does that makes sense? [19:37:59] aharoni, awesome, thanks for writing that up! (the bidi stuff) [19:38:45] sounds good to me, as long as he has the authority to sign on Sciences Po's behalf (which I think he has if he is PI on this grant) [19:38:49] DarTar: Well, it's a major blocker in that without it the banner will point to a page full or errors. [19:38:58] but it's not hard to fix. [19:39:35] Krinkle: right, I mean the main blocker is just the French timezone right now [19:39:59] Krinkle: due to the fact that you guys are not working on the same schedule, I think we should try to minimze back and forth exchanges and try to write very precise messages. [19:40:08] Krinkle: exactly! :) [19:40:10] in worst case, it means we have a 16 hour delay between each mail loop) [19:40:29] I've been very elaborate in my mail because of that. [19:40:38] so that I can cover for most likely answers etc. [19:40:41] Krinkle: What you could do also is to write to Paul and Anne and interact directly with them on IRC to be sure that we all are on the same page, right? [19:41:17] Jerome___: Well, the schedule issue is involved there as we would have to be online at the same time for that to work. [19:41:27] perhaps they can join IRC from home ? [19:41:38] it's 8.41 PM now for us/them [19:43:00] Krinkle: I don't know, but you can surely try and propose some time that fits your schedule most. Of course, if it can overlap as much as possible with working hours, it's better. [19:43:30] Jerome___: I get home at 7PM every day, can work anytime between that and midnight [19:44:30] Krinkle: so maybe try to tentatively propose 7p.m. and see if it works for them... [19:44:39] ok [19:45:05] Krinkle: you may have resolved all pending issues by then, but it will not hurt to talk before the launch in any case if possible. [19:45:52] Jerome___: When is that exactly ? [19:46:31] DarTar: So about the agreement: I will get back to Yann Algan and see if he can sign it and send it to you as of tomorrow morning, okay? [19:48:05] yes please do [19:49:02] Krinkle, DarTar: I think we should try and target a launch tomorrow night at the earliest, thursday night at the latest. This should be our goal according to the editor survey constraints that we have, right? [19:49:21] It would be a pity to cause delays because of communication issues... [19:49:44] Now that we are so close... [19:50:27] yes, Friday is not an option and pushing to next week will cause major conflicts with the editor survey [19:50:53] Jerome___: okay [19:52:05] Krinkle: so I think that you should definitely try to connect to Anne and Paul quickly. Is it impossible for you to do a quick talk on mornings, or lunch time? [19:52:33] Krinkle: just to be sure about the plan and then just have to resolve them and not the other way around... [19:53:02] Krinkle: (just trying to think through what could be most efficient...) [19:54:35] Jerome___: I can check e-mail during lunch, no problem. [19:55:02] So I can answer regarding my IRC proposal if they have questions or other proposals [19:55:14] but can't join IRC from my workplace [19:55:48] Krinkle: actually I was thinking about the IRC chat: you could propose right away to do it quickly tomorrow during lunch time, and then both of you still have time to figure it out... [19:56:09] Krinkle: Oh I see. Maybe Skype or some other means could do the trick? [19:56:40] Skype will work (no audio though) [19:59:27] Krinkle: I would suggest that you write a mail to them (put me in cc if you like) asking if any one of them can join you on Skype or through any other convenient means for you with all relevant contact info some time during your lunch time tomorrow then... [19:59:57] (sorry for the long French-sounding sentence! :) [20:00:17] actually, IRC works fine. I can access freenode through webchat proxy [20:01:05] Jerome___: reviewing the latest banner code that you sent me, I haven't heard from Legal on the logo issue but I'll ping them again [20:01:08] Krinkle: okay, sounds good! [20:01:31] DarTar: sure, thanks! Does it look good to you at least? [20:01:54] loading the files right now [20:03:32] Jerome___: banner_without_line_break looks the best option to me [20:04:10] and it doesn't conflict with the RCom tagline when it's resized [20:04:21] let me ask jorm some quick feedback [20:04:54] DarTar: okay. Thanks. Can you send us the links so that we can see both? [20:06:23] jorm suggests as a possible tweak: go for banner_without_line but move all the logos to the bottom (on the same line as the RCom tagline) [20:07:07] off to get some lunch, bbl [20:07:29] What's RCom ? Can't figure out the right definition [20:08:22] Krinkle, [[m:RCom]] [20:08:27] https://meta.wikimedia.org/wiki/Research:Committee [20:08:32] right [20:08:33] Thx :) [20:08:52] http://www.google.nl/search?q=wikipedia+rcom didn't help :) [20:09:03] because it's not wikipedia [20:09:07] *Nemo_bis slaps Krinkle [20:09:16] well, now that I know it, it was listed, but hey.. [20:09:30] well, it's about a banner to be ran on English Wikipedia only [20:09:40] so Rcom in that context made sense to be somewhat related to wikipedia [20:10:13] I don't think Wikipedia has committees [20:10:21] except ArbCOm [20:10:29] I was about to say! [20:10:37] and *cough*the cabal*cough* [20:10:47] *Nemo_bis hides [20:12:07] Krinkle, DarTar: okay. So wrapping up: (i) we will see if we want to modify the banner further depending on how it looks in context and your above suggestions (ii) Krinkle, you can send a mail to Anne and Paul asking if a coordination chat is possible tomorrow during lunch time (I would suggest that you give several contact options if possible) and (iii) I see with Yann Algan if he can sign the research agreement for tomorr [20:12:47] The goal being: a launch tomorrow night at the earliest, Thursay night at the latest. [20:12:54] Sounds good? [20:13:05] (ii), [marked as done] [20:16:27] Krinkle: received your message! Sounds perfect! I hope that this way we can make it work fast! [20:16:43] yeah :) [20:16:50] Okay. So let me know if there's anything else I can do! [20:16:56] aight, while Dario is off to lunch, I'm heading downstairs to dinner [20:17:03] sure, will do [20:17:12] Thx! [20:17:39] Thanks to both of you, Timo, Dario. And see you soon! :) [20:17:45] Bon app??tit! :) [20:24:09] <[Haekchen]> Did I already miss the feature team office hour or is it just that quiet? [20:25:11] missed it [22:10:15] hashar: 169 tests are passing now- should make it to 200 this week ;) [22:15:33] hashar isn't here [22:15:44] I wanna talk to thin too [22:15:48] him* [23:12:16] Krinkle, cause Hashar keeps "sane" european hours :p [23:12:38] yeah, some ppl do. [23:13:22] *Krinkle learns about soundex and levenshtein in PHP.