[18:40:34] <sumanah>	hi Waldir!
[18:42:19] <Waldir>	Hey sumanah :)
[18:42:23] <sumanah>	how goes it?
[18:42:36] <sumanah>	Waldir: your studies & your extracurricular software development endeavors :-)
[18:42:48] <sumanah>	Waldir: in a few hours we're having a 1.18.0 bug triage that hexmode`` is leading
[18:43:15] <Waldir>	I'm here mostly to see how these things go :) Not really back on track with my schedule...
[18:43:47] <sumanah>	right
[18:43:59] <sumanah>	Waldir: best of luck with the thesis
[20:58:34] <sumanah>	hexmode: hi -- for the bug triage, we're looking at https://bugzilla.wikimedia.org/32711 right?
[20:59:05] <hexmode>	sumanah: yes, and I just noticed I said :30 but the link points to :00
[20:59:08] *hexmode 	sighs
[21:00:02] <sumanah>	hexmode: I think on the various Google calendars, the WMF calendar and the triage calendar, yeah, it says 00
[21:00:06] <hexmode>	Reedy: here?
[21:00:24] <hexmode>	well, lets start at 00 :)
[21:00:37] <Reedy>	mmm
[21:00:49] <sumanah>	hexmode: up to you, but it seems odd to start 30 min early unless you are ok with it being a 90 min meeting
[21:01:28] <hexmode>	Let's start now and go on if anyone pops up at 30 thinking it is starting then (and if we need to)
[21:01:52] <hexmode>	Reedy: any general opinion on the bugs?
[21:02:07] <Reedy>	bugs are bad, mmmkay?
[21:02:21] <hexmode>	heh
[21:02:54] <hexmode>	yes, but re: tarball what is your impression of doing a point release? is it necessary?
[21:03:08] <hexmode>	but maybe we should cover these first
[21:03:31] <hexmode>	http://bugzilla.wikimedia.org/32633 - Special:ExtensionDistributor for REL1_18 version does not include svn:externals
[21:03:34] <Reedy>	yeah, i think it's worth looking at what we've got to deal with first
[21:03:50] <Reedy>	That's just a shell bug, need to get ops to do a svn update with externals
[21:03:55] <hexmode>	right
[21:03:58] <Reedy>	trivially enough fixed
[21:04:06] <hexmode>	so I'll tag it ops and make a note
[21:04:07] <Reedy>	i can't sudo to the extdist user though
[21:04:20] <sumanah>	robla, AaronSchulz, brion, johnduhart, Platonides, thedj, ^demon -- you might want to give your opinion on these
[21:05:29] <hexmode>	http://bugzilla.wikimedia.org/32652 - [[Special:Nuke/USERNAME]] no longer works, chucks user back to main entry poin
[21:06:10] <hexmode>	maxsem says we need to backport on that one
[21:06:23] <hexmode>	(and that is for wmf and tarball)
[21:06:52] <hexmode>	hrm... probably the followups
[21:07:16] <robla>	(sorry, a little late getting back...catching up on backlog)
[21:07:29] <hexmode>	hey, robla
[21:08:04] <hexmode>	so, on 32652, I'll just tag any necessary ones and bug reedy :)
[21:08:26] <hexmode>	http://bugzilla.wikimedia.org/32709 - Private Wiki users are always taken to Special:Badtitle on successful login
[21:08:50] <hexmode>	checking fix in r101345
[21:08:59] <Platonides>	I haven't seen it on trunk
[21:09:03] <hexmode>	doh
[21:09:06] <Platonides>	oh, it was fixed in the meantime ?
[21:09:08] <hexmode>	that was our spammer
[21:09:16] <hexmode>	EVIL GUY
[21:09:49] <robla>	any word on deleting comments rather than marking them private?
[21:09:52] <brion>	Platonides, it does happen on 1.18wmf1 at least, i see it on office.wikimedia.org
[21:09:54] <hexmode>	ok, so Platonides hasn't seen that
[21:10:05] <hexmode>	robla: I figured out how to delete them
[21:10:23] <hexmode>	robla: but I do need ops to deploy a piece of code
[21:10:36] <robla>	k...sorry for the interruption.  back to the show!
[21:10:44] <brion>	hmmmmmm not seeing it now on office. did it get fixed or does it only sometimes happen?
[21:10:48] <Platonides>	I didn't really try to reproduce it
[21:10:55] <brion>	ah!
[21:10:56] <robla>	I get it on officewiki as well
[21:11:00] <brion>	of course i see why
[21:11:00] <hexmode>	brion: I've seen it at least once
[21:11:02] <Platonides>	just didn't see it on a private install I used :)
[21:11:06] <brion>	if you start at a page that's private
[21:11:11] <robla>	yeah, that's it
[21:11:15] <brion>	you internally end up viewing Special:BadTitle
[21:11:21] <brion>	so that gets saved as the returnto link
[21:11:46] <brion>	https://office.wikimedia.org/w/index.php?title=Special:UserLogin&returnto=Foobar <- on top bar
[21:11:51] <brion>	https://office.wikimedia.org/w/index.php?title=Special:UserLogin&returnto=Special%3ABadtitle <- in body
[21:12:27] <robla>	so...we have to figure out how to fix without reintroducing the security problem
[21:12:28] <Platonides>	oh, I was only using the top bar
[21:12:49] <Platonides>	and not making that link red/blue
[21:13:12] <hexmode>	any clue on how hard that would be?
[21:13:28] <robla>	anyway, it's pretty annoying.  not worth a dot release, but high priority, worth a patch, and getting into the branch so we pick it up next dot release
[21:13:31] <brion>	lemme see what displays the msg
[21:14:10] <Platonides>	it seems like a matter of setting the given title in the context
[21:14:28] <robla>	relevant rev: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/104505
[21:15:00] <hexmode>	http://bugzilla.wikimedia.org/32702 - Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17
[21:15:28] <brion>	ok, so the 'You must log in to view other pages' message comes from OutputPage::showPermissionsErrorPage()
[21:15:51] *hexmode 	backs up
[21:16:25] <hexmode>	brion: could you add that bit of info to the bug with the note that it is "from triage"?
[21:16:26] <brion>	i think this gets called from... PermissionsError:report()
[21:17:15] <hexmode>	everybody ready to look at 32702?
[21:17:21] <hexmode>	http://bugzilla.wikimedia.org/32702 - Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17
[21:17:27] <brion>	will do
[21:17:32] <robla>	yeah, let's look there
[21:18:47] <robla>	so... Reedy filed 32702 based on complaints on some public forum (mediawiki-l or IRC, I don't recall which)
[21:18:59] <Reedy>	on IRC
[21:19:10] <robla>	Reedy: there were multiple complaints, right?
[21:19:27] <robla>	or was it just one rather obsolete-ish skin?
[21:19:28] <Reedy>	Yeah, there were a couple of people with custom skins
[21:19:33] <hexmode>	oh, I think I ran into this one!
[21:19:40] <Reedy>	I'm not sure how far out of date they might've been...
[21:19:59] <robla>	how tough is it to restore backwards compatibility?
[21:21:49] <robla>	if it's hard, then I think this becomes a documentation issue.  if it's easy, we should at least provide a patch, I think
[21:23:48] <robla>	hello?
[21:23:52] <hexmode>	k, updated bug, moving to next one
[21:24:11] <hexmode>	maybe Reedy fell asleep ;)
[21:24:56] <hexmode>	http://bugzilla.wikimedia.org/29102 - Upgrade fails "Unknown character set: 'mysql4"
[21:26:26] <robla>	why did ^demon say it was low priority?  not that I disagree, but it'd be nice to see the documentation
[21:26:38] <brion>	robla, hexmode -- on 32709 it looks like there's simply part of the fix that didn't make it into the backports, which is causing the bug
[21:26:41] *robla 	just doesn't have an opinion yet
[21:26:57] <Reedy>	It's not really MW's fault
[21:27:12] <Reedy>	It's just people haven't updated their configs when they've updated their db servers
[21:27:17] <Reedy>	probably cause we've not told them to
[21:27:22] <hexmode>	right
[21:27:29] <hexmode>	so it could be another doc issue
[21:27:38] <Reedy>	indeed
[21:27:49] <robla>	how hard would a more helpful error message be?
[21:28:01] <Reedy>	probably as easy just to find the correct place for the string replace
[21:28:02] <hexmode>	though, I wonder why the ^demon's fix didn't work
[21:28:34] <hashar>	lo
[21:28:41] <hexmode>	hashar: !
[21:29:50] <hexmode>	so for 29102, do we want to fix the string replace or give an error message?
[21:29:59] <hexmode>	or should we decide later and move on?
[21:31:17] <robla>	Let's take it off the blocker list and move on
[21:31:33] <Reedy>			$vars['wgDBTableOptions'] = str_replace( 'TYPE', 'ENGINE', $GLOBALS['wgDBTableOptions'] );
[21:31:33] <Reedy>			$vars['wgDBTableOptions'] = str_replace( 'CHARSET=mysql4', 'CHARSET=binary', $GLOBALS['wgDBTableOptions'] );
[21:31:42] <Reedy>	We should probably reassign them back to the variables
[21:32:47] <hexmode>	Reedy: add that to the bug, please?
[21:32:50] <hexmode>	moving on
[21:33:11] <hashar>	doing post 1.18.0 bug triage?
[21:33:25] <hexmode>	http://bugzilla.wikimedia.org/32760 - wfprofilein Errors on upgrading to 1.18
[21:33:28] <hexmode>	hashar: yep
[21:33:45] <hexmode>	couple of mediawiki-l complaints about this one
[21:33:59] <robla>	hashar: there was a scheduling snafu, and what time you showed up depended on which source you used to figure out what time the meeting was
[21:34:11] <robla>	we're about halfway through
[21:35:07] *hashar 	learns a new acronym (snafu)
[21:35:26] <hexmode>	situation normal!
[21:35:43] <hexmode>	fix for 32760 is trivial
[21:35:52] <hashar>	yeah. Figured that out on a  little site I am using that have lot of references
[21:36:50] <hashar>	hexmode: 32760 looks like a support issue
[21:37:18] <robla>	just curious, was that bug introduced between rc1 and final?
[21:37:38] <hexmode>	Reedy: ^^ ?
[21:38:01] <Reedy>	No
[21:38:07] <Reedy>	It's from the profiling refactoring
[21:38:11] <Reedy>	Again, a documentation issue
[21:38:28] <Reedy>	It' usually very trivially fixed
[21:38:40] <hexmode>	we're gonna have a 1.18 FAQ from these bugs ;)
[21:38:52] <AaronSchulz>	yep
[21:39:01] <hexmode>	http://bugzilla.wikimedia.org/32762 - invalid magic word errors on canonicalurl after upgrade to 1.18
[21:39:18] <hexmode>	looks like most of this one is a support issue, too
[21:39:28] <robla>	for 32760: we should lob a fix in trunk and REL1_18, but not release 1.18.1 over it
[21:40:25] <hexmode>	someone modifying their skin in wonky ways
[21:41:02] <hexmode>	finally: https://bugzilla.wikimedia.org/32754 - Blocked user trying to edit gets an error
[21:41:48] <hexmode>	looks like another patch that could be backported
[21:42:20] <robla>	hexmode: was there a decision on 32762?
[21:42:41] <hexmode>	robla: I think it was just a support issue
[21:42:56] <robla>	hexmode: you'll be resolving then?
[21:43:05] <hexmode>	iow: someone modifying their skin in weird ways
[21:44:04] <hexmode>	robla: I'll let Daniel Friesen resolve since he is helping out on this one, but take it off the blocker list
[21:44:23] <sumanah>	Dantman: ^^^^
[21:44:24] <robla>	k...please lower priority too, then
[21:45:26] <hexmode>	will do
[21:46:34] <hexmode>	finally: https://bugzilla.wikimedia.org/32754 - Blocked user trying to edit gets an error
[21:47:26] <AaronSchulz>	easy
[21:47:27] <Krinkle>	Reedy: re: 'wgDBTableOptions', that would leave $vars['wgDBTableOptions'] with only charset replaced, not TYPE, or isn't this actual code ?
[21:47:29] *AaronSchulz 	does that now
[21:47:51] <hexmode>	AaronSchulz: you're talking about 32754?
[21:48:21] <robla>	he says "yes"
[21:48:27] <robla>	assign to him  :)
[21:48:38] <hexmode>	robla: ok, I'll write up a report and you guys can make a decision
[21:48:47] <hexmode>	an FAQ is needed, at least ;)
[21:48:48] <robla>	?
[21:48:53] <Reedy>	Krinkle, oh yeah...
[21:49:15] <robla>	oh...make a decision about needing a 1.18.1 right away
[21:49:18] <Reedy>	I blame hexmode then. I think he added hte line after :p
[21:49:31] *hexmode 	sulks
[21:50:20] <hexmode>	lol collision with AaronSchulz :)
[21:50:29] <hexmode>	I'm too slow :P
[21:50:42] <Reedy>	Krinkle, though, I think the problem was with the 2nd one anyway (those setting mysql4)... But good point
[21:50:51] <Krinkle>	Reedy: yeah
[21:50:56] <Reedy>	Fixed in trunk
[21:51:20] <Reedy>	The use of wgDBTableOptions seems rather obfuscated
[21:51:21] <robla>	I think I can make a decision now.  no need to rush 1.18.1.  we should post patches for the high+ priority issues when they're done, and backport fixes to REL1_18, but then keep an eye out for critical mass of issues
[21:51:45] <sumanah>	rock
[21:52:07] <hexmode>	robla: kk
[21:52:20] <Reedy>	yeah
[21:52:25] <Reedy>	no harm in starting a 1.18.1 changelog
[21:52:26] <hexmode>	will still write something brief up
[21:52:35] <sumanah>	thanks hexmode
[21:52:44] <hexmode>	tyvm all!
[21:52:54] <hexmode>	and sumanah for calling people...
[21:53:02] *sumanah 	curtseys
[21:53:06] <hexmode>	heh
[21:53:19] <Reedy>	I'll see about poking at the bugs over the weekend
[21:53:30] <Reedy>	when i've got my new desktop dev env setup
[21:53:43] *hexmode 	loves new desktops
[21:53:52] <Reedy>	6 core cpu and 24GB Ram? :D
[21:54:48] <hexmode>	dang... and I only got 8gb
[21:55:13] <hexmode>	oh, well.... emacs only takes 8 mb
[21:55:25] <hexmode>	eight megs and continually swapping
[21:55:34] <hexmode>	the acronym no longer works
[21:55:51] <brion_>	if it does, you really need to upgrade
[21:58:54] <sumanah>	Ryan_Lane: your inbox now includes an introduction to YET ANOTHER volunteer systems administrator!
[21:59:03] <Ryan_Lane>	awesome :)
[21:59:07] <sumanah>	yes!
[21:59:09] <sumanah>	o/
[21:59:12] <Ryan_Lane>	we *really* need to get a wishlist going
[21:59:21] <sumanah>	https://www.mediawiki.org/wiki/WMF_Projects/Wikimedia_Labs#Proposals is something to start with at least
[22:00:23] <Ryan_Lane>	yeah