[03:37:07] <jpostlethwaite>	hello
[03:37:23] <awjr>	hi jeremy
[03:37:34] <jpostlethwaite>	so we have a problem with radio buttons for amount
[03:37:41] <awjr>	it seems that the way things were written in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101874
[03:37:48] <awjr>	and http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101560
[03:38:03] <awjr>	are causing problems in certain situations
[03:38:13] <awjr>	K4-713, can you explain the issue?
[03:39:16] <K4-713>	So, we're seeing issues where there is an explicit default of '0', particularly in the 'amount' field.
[03:39:43] <K4-713>	The problem with that, is that if 'amount' is anything, it will take precedence over any of the other amount-related values.
[03:39:43] <jpostlethwaite>	ok
[03:40:00] <jpostlethwaite>	do you know if it is a javascript or a PHP problem
[03:40:38] <K4-713>	Well, it's predictably a little hard to search for 'amount' in the DonationInterface extension... still trying to nail the whole thing down.
[03:40:59] <jpostlethwaite>	ok
[03:41:05] <K4-713>	But, we did find a couple instances where there did appear to be an explicit zero being set.
[03:41:07] <jpostlethwaite>	do you have a way to replicate it
[03:41:13] <kaldari>	it's sort of a combination of both, but mainly due to the amount field receiving a default value in the forms it looks like.
[03:41:16] <jpostlethwaite>	i am pretty familiar with that code
[03:41:22] <K4-713>	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101874 is one.
[03:41:40] <K4-713>	Which seems to be a bit of a re-write of http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101560.
[03:42:06] <K4-713>	Have you been defaulting 'amount' (or any of the other numeric values) to an explicit zero anywhere else?
[03:42:31] <jpostlethwaite>	maybe in the js
[03:42:53] <jpostlethwaite>	there is a click and focus event
[03:43:44] <jpostlethwaite>	i have:
[03:43:45] <jpostlethwaite>	setAmount = function( e ) {
[03:43:45] <jpostlethwaite>		$('input[name="amount"]').val(e.val());
[03:43:45] <jpostlethwaite>	};
[03:44:08] <kaldari>	that's probably fine
[03:44:23] <jpostlethwaite>	here is more:
[03:44:28] <jpostlethwaite>			// Check to see if the element exists
[03:44:28] <jpostlethwaite>			if ( $("input[name='amountRadio']").length ) {
[03:44:29] <jpostlethwaite>				amountSelector = "input[name='amountRadio']";
[03:44:29] <jpostlethwaite>				$( amountSelector ).click(function(){ setAmount($(this)); });
[03:44:30] <jpostlethwaite>				$("#other-amount").focus(function(){ $('#input_amount_other').prop('checked', true); });
[03:44:30] <jpostlethwaite>				$("#other-amount").change(function(){ setAmount($(this)); });
[03:44:31] <jpostlethwaite>			}
[03:44:45] <jpostlethwaite>	looking right now...
[03:44:57] <K4-713>	Do we know what form we were getting these errors on?
[03:45:04] <jpostlethwaite>	no idea
[03:45:17] <kaldari>	I don't think the js in DonationInterface matters in this situtation though. The problem occurs when we are going to DonationsInterface from a first step page
[03:45:20] <jpostlethwaite>	does arthur or james?
[03:45:25] <awjr>	james likely knows, although he seems to have disappeared
[03:45:53] <kaldari>	In those cases, an amount isn't necessarily passed
[03:45:57] <jpostlethwaite>	so does anyone know how to replicate it?
[03:46:19] <awjr>	james is in the bathroom
[03:46:23] <kaldari>	James does
[03:46:32] <awjr>	yeah, james should be able to tell you how to reproduce it
[03:46:48] <jpostlethwaite>	cool
[03:46:59] <jpostlethwaite>	i can work on that when he gets back
[03:47:52] <awjr>	looking quickly through the code, it seems that you should be able to always rely on $this->form_data['amount']
[03:48:33] <jpostlethwaite>	i made the radio form always populate the hidden amount field
[03:48:46] <jpostlethwaite>	that is done by javascript
[03:48:56] <jpostlethwaite>	repeating for james
[03:48:57] <jpostlethwaite>	i made the radio form always populate the hidden amount field
[03:49:02] <jpostlethwaite>	that is done by javascript
[03:49:38] <jpostlethwaite>	hi jamesofur
[03:49:56] <jpostlethwaite>	what form is not working?
[03:50:21] <jpostlethwaite>	for the radio button form
[03:52:07] <Jamesofur>	jpostlethwaite, the big one is https://payments.wikimedia.org/index.php/Special:GlobalCollectGateway?uselang=en&masthead=none&form_name=RapidHtml&ffname=webitects2nd . It appears to be happening when you have a session in place at some point. When I was on a first step (such as  https://donate.wikimedia.org/wiki/Special:FundraiserLandingPage?uselang=en&country=AT&template=Lp-layout-default&appeal-template=Appeal-template-default&appeal=Appe
[03:52:07] <Jamesofur>	al-Alan&form-template=Form-template-default&form-countryspecific=Form-countryspecific-control&utm_medium=sitenotice&utm_source=B11_Donate_Alan_Control&utm_campaign=C11_1107 ) and entered an 'other' amount it would not get the amount fully passed
[03:54:22] <jpostlethwaite>	ok, i will need a few minutes to test this out
[03:55:15] <Jamesofur>	latest test I entered an amount (from that 1st step). Started the transaction and got an iframe then bailed (went back to 1st step).
[03:55:55] <Jamesofur>	If I select a radio button it gets passed as 'amount' and overwrites the old one. If I type something in the other box it does not overwrite the amount (and the 2nd step still has the old session amount from earlier)
[03:56:57] <awjr>	jpostlethwaite: we're chatting irl about a potential solution
[03:57:27] <awjr>	basically, on all of our forms on payments, we have javascript that will /always/ set a the 'amount' field
[03:57:38] <awjr>	that however is not the case on some of the forms on wikimediafoundation.org or donate.wikimedia.org
[03:57:53] <awjr>	but if we can potentially get that JS in use on wikimediafoundation.org/donate.wikimedia.org  might solve the problem
[03:58:12] <awjr>	since the logic inside of DonationData:setNormalizedAmount() will /always/ give preference to the 'amount' field
[03:58:59] <jpostlethwaite>	ok
[03:59:07] <jpostlethwaite>	i am seeing a problem with amount
[03:59:18] <jpostlethwaite>	that seems unrelated
[03:59:44] <jpostlethwaite>	https://payments.wikimedia.org/index.php/Special:GlobalCollectGateway?uselang=en&masthead=none&form_name=RapidHtml&ffname=webitects2nd
[03:59:55] <jpostlethwaite>	that page is missing the amount section
[04:00:01] <jpostlethwaite>	Donation amount ()
[04:00:04] <pgehres>	jpostlethwaite: yes, it is a second step form
[04:00:09] <jpostlethwaite>	okay
[04:00:17] <jpostlethwaite>	which is the first step?
[04:00:24] <pgehres>	we are going to add some fallback, but it expects a passed value
[04:00:30] <pgehres>	some form on donatewiki
[04:00:33] <jpostlethwaite>	i see
[04:00:59] <jpostlethwaite>	the stuff that was pointed out in changes I made does not touch RapidHtml does it?
[04:01:20] <jpostlethwaite>	referring to:
[04:01:21] <jpostlethwaite>	http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101560
[04:01:26] <jpostlethwaite>	generateAmountByRadio()
[04:01:29] <pgehres>	RapidHTML is an extension of the form RapidHTML which extends Form
[04:01:36] <jpostlethwaite>	ok
[04:01:59] <pgehres>	but, that is as deep as I have gotten into DonationInterface due to lack of time
[04:02:07] <jpostlethwaite>	ok
[04:02:58] <jpostlethwaite>	this form is the first:
[04:02:59] <jpostlethwaite>	http://tinyurl.com/c3pq5k5
[04:03:26] <jpostlethwaite>	I do not have this special page:
[04:03:27] <jpostlethwaite>	Special:FundraiserLandingPage
[04:03:45] <jpostlethwaite>	does anyone know how to get that on my local machine for testing?
[04:03:46] <awjr>	jpostlethwaite: sorry, lots of IRL convo going on here
[04:03:53] <jpostlethwaite>	ok
[04:04:12] <awjr>	but i think we've determined that your radio button generating stuff in Form.php is not the problem
[04:04:25] <jpostlethwaite>	ok
[04:04:37] <jpostlethwaite>	what does IRL mean? :)
[04:05:14] <jpostlethwaite>	in real life :)
[04:05:15] <Jamesofur>	in real life :)
[04:05:18] <jpostlethwaite>	ok
[04:05:24] <jpostlethwaite>	though so :P
[04:05:27] <jpostlethwaite>	haha
[04:09:49] <awjr>	jpostlethwaite: we're trying to identify whether or not the theory about broken JS being the culprit is correct
[04:09:56] <awjr>	and if it getting fixed will solve the problem :p
[04:10:01] <jpostlethwaite>	i see
[04:10:31] <jpostlethwaite>	feel free to pull code from the validate.js
[04:10:35] <awjr>	the gist of what we just discussed is that it should be expected that DonationInterface will expect consistent data - it should only have to expect 'amount'. not amountOther, amountGive AND amount
[04:10:48] <jpostlethwaite>	right
[04:10:50] <awjr>	no, the JS in question is on foundation wiki and/or donate wiki
[04:11:20] <awjr>	anyway, even though we had the code in DI to handle amountOther, amountGive AND amount, the way we had things written in our forms last year was such that the only thing ever coming into DI was 'amount'
[04:11:26] <jpostlethwaite>	i meant just pull the methof
[04:11:37] <jpostlethwaite>	i see
[04:11:44] <awjr>	we just never cleaned the cruft out of DI
[04:12:02] <awjr>	and we think the JS already exists on foundation/donate wikis but is likely incorrectly scoped
[04:12:25] <jpostlethwaite>	any reason that amountRadio cannot just be amount?
[04:12:47] <awjr>	anyway, i think we can take a deep breath and know that we're close to getting this sorted
[04:13:01] <jpostlethwaite>	i only did it with amountRadio because that is what was done before
[04:13:06] <awjr>	yeah, i think that's fine
[04:13:10] <jpostlethwaite>	you just then need to verify that one is checked
[04:13:12] <jpostlethwaite>	cool
[04:13:27] <jpostlethwaite>	will you have more issues to solve tonight?
[04:13:33] <awjr>	like i said, im pretty sure the stuff you added in Form.php is not the problem.
[04:13:43] <jpostlethwaite>	right
[04:13:47] <awjr>	because im pretty sure the only thing using that method anyway is your TwoStepAmount form :p
[04:13:59] <awjr>	which is not live in production
[04:14:00] <jpostlethwaite>	right, that is what I thought
[04:14:18] <awjr>	are you going to be around for a bit?
[04:14:21] <jpostlethwaite>	yes
[04:14:23] <awjr>	ok cool
[04:15:25] <awjr>	cool - sounds like james has confirmed that the problem is busted JS on donate wiki
[04:15:41] <awjr>	which means, SEP
[04:15:49] <jpostlethwaite>	what is SEP?
[04:15:51] <K4-713>	:)
[04:15:56] <awjr>	Somebody Else's Problem
[04:15:59] <jpostlethwaite>	haha
[04:16:07] <awjr>	:p
[04:16:39] <awjr>	jpostlethwaite: thanks for hopping on, apologies about the confusion
[04:16:47] <jpostlethwaite>	no worries
[04:17:02] <awjr>	the problem is an edge case, but kinduva big edgecase
[04:17:27] <awjr>	concerning enough that all the forms were taken down until we got this solved, so there was some panic
[04:17:58] <jpostlethwaite>	i see
[04:47:48] <kaldari>	jpostlethwaite: I think we have the amount issue fixed for now
[04:48:09] <kaldari>	fixed it in the donation wiki templates