[00:00:29] johnduhart: npm is there now too [00:00:38] yay [00:00:55] Ryan_Lane: Will they be put into svn? [00:00:57] johnduhart: please add the debian directories to trunk/debs/ [00:01:04] Oh okay [00:01:13] so, npm/debian [00:01:22] not the source :) [00:01:24] So my copies are fine? Nothing else was changed by you? [00:01:38] oh. let me slightly change node [00:02:29] oh. that one is actually perfect [00:02:39] cool [00:02:48] yeah, can commit them as is [00:03:12] Great [00:04:59] Reedy: I'm gonna cry: --scriptpath on the cli installer isn't working [00:05:03] oh well [00:05:10] not a show stopper. carry on [00:05:27] I should make a build node that is meant to be a build node [00:06:55] hexmode, missing merges? [00:07:22] Reedy: maybe, but no big deal atm [00:07:35] was sure I had that fixed [00:10:01] Reedy: r93834 but don't worry about it tonight [00:10:25] *Reedy tags 1.18 [00:11:03] verified the install works otherwise [00:11:32] let me run through a quick web install with mysql and psql and sqlite [00:12:49] fuck [00:13:01] imported npm as nodejs, hold on http://svn.wikimedia.org/viewvc/mediawiki/trunk/debs/nodejs/debian/control?revision=101924&view=markup [00:13:40] :D [00:14:45] Hmmm [00:14:58] When I commit from the labs the post-commit hooks don't run [00:15:19] Oh, nope [00:15:22] CIA.vc is slow [00:16:15] Let's try that again [00:16:31] UGHHHHH [00:16:37] Now I committed the .git [00:17:20] Ryan_Lane: Get rid of the .git folder form svn? [00:17:46] yep [00:17:54] why does the svn server even accept .git directories? [00:19:14] 'cause no one told it not to [00:19:38] why should a grandfather guess the name of his grandson when he himself is just a child [00:20:05] *hexmode amuses only himself with obscure references [00:20:12] because git has been around for a while now, and we occasionally import from other places [00:20:29] hence the current issue [00:20:49] Okay so now that the svn debacle is over [00:21:05] Puppet time or etherpad package time? [00:21:13] I'd say let's package etherpad first [00:21:52] Reedy: web-based upgrade of 1.17 sqlite installation is taking forever [00:21:57] I'll come back to that [00:23:46] Ryan_Lane fun. [00:24:21] Ryan_Lane: Would you mind talking me through this or would you rather do it? [00:24:29] I'll walk you through it [00:24:43] http://etherpad.wikimedia.org/1180beta1ReleaseNotes [00:24:46] I try to never make them from scratch [00:24:52] Ryan_Lane: Awesome. [00:25:01] johnduhart: let's swtich to #wikimedia-tech or #wikimedia-labs [00:25:26] sure [00:26:26] oh... the sqlite upgrade finished ... no errors [00:27:28] hexmode, update is slow from me fixing the localisation cache bug [00:27:35] it regenerates it all [00:27:49] yeah, saw that last night from cli update.php [00:27:56] wasn't expecting at first [00:29:32] wouldn't that patch I commited yesterday (making non-db localisation cache possible) fix it? [00:29:42] not that it is going in [00:29:47] still needs some work [00:33:32] I wonder if we should rename the release-notes file to drop the version suffix in the releases... Is it supposed to be in a set location/name? [00:34:24] yes, we should, I think [00:34:34] people may be expecting the old name [00:34:59] s/people/some script/ [00:35:30] In SVN, or just at tarball building? [00:35:41] There was a specific reason for appending the version number IIRC [00:35:50] just tarball [00:36:03] they've had plenty of time to complain about svn [00:36:17] but maybe robla will have a reason to keep it [00:36:18] heh [00:36:38] what's the question? [00:37:21] I wonder if we should rename the release-notes file to drop the [00:37:21] version suffix in the releases... Is it supposed to be in a set [00:37:21] location/name? [20:33] [00:37:22] [00:37:28] robla ^^ [00:37:33] sorry for the spam [00:37:36] ie RELEASE-NOTES-1.18 => RELEASE-NOTES [00:38:21] that may be more of a TimStarling question [00:39:06] I don't think there's any need to do that [00:39:47] oh, the installer should probably point to the right file though [00:39:52] class WebInstaller_ReleaseNotes extends WebInstaller_Document { [00:39:52] protected function getFileName() { return 'RELEASE-NOTES'; } [00:39:53] } [00:39:55] hah [00:40:17] that's broken whether or not you use a release tarball [00:40:58] needs to be RELEASE-NOTES- $wgVersion major.minor only [00:41:31] I noticed the make-release script linked to http://svn.wikimedia.org/svnroot/mediawiki/tags/REL1_18_0beta1/phase3/RELEASE-NOTES, hence the original comment [00:43:13] in the email? [00:43:25] that should change to the release notes page on mediawiki.org [00:43:56] I just hadn't gotten around to changing it [00:45:10] it looks like the method for creating the mediawiki.org page isn't documented on the checklist [00:46:53] you have to use maintenance/formatInstallDoc.php [00:47:16] reedy: we're bundling these extensions? Should be that be in http://etherpad.wikimedia.org/1180beta1ReleaseNotes ? [00:47:23] Good idea [01:18:55] What's the plan then? I wanted to go to bed reasonable.. ;) [01:19:51] Reedy: i agree ... [01:19:56] release now and send email [01:20:07] sanity tests check out [01:20:33] Reedy: maybe get TimStarling to put this on upload [01:20:34] ? [01:20:34] it'd be best retagged to fix the versioning information, and gets a few minor release note updates [01:21:22] *Reedy wonders if the email draft is enough [01:21:26] Reedy: also, I think you're way past going "to bed reasonable" [01:21:32] Reedy: for today, yes [01:21:40] retag it and release it tomorrow [01:22:00] no kittens will die [01:22:04] heh [01:22:11] *hexmode defers to tim's kittens [01:22:16] ;) [01:34:16] I'm off to bed then. Will finish up the release email and retag and release tomorrow [01:34:26] (before I drive down to London) [01:34:27] Night all [12:25:38] Right... I think I'll retag, rebundle then can get someone to upload it.. [12:29:57] RoanKattouw, about? [12:30:11] Yeah? [12:30:11] tarball? [12:30:20] Wheee [12:30:22] 2 people ;) [12:30:25] I have to leave to catch my train in 45 [12:30:26] :-D [12:30:31] I'll be here [12:30:36] Thanks [12:30:40] I'm just waiting for it to upload to fenari now [12:30:49] hand me a tarball when yer ready, please ping or I may not notice [12:30:55] thanks [12:30:57] sure [12:31:00] this is a beta is it? [12:31:05] yup [12:31:08] cool [12:32:57] http://etherpad.wikimedia.org/1180beta1ReleaseNotes [12:34:19] Arrgh, Etherpad keeps disconnecting me [12:34:40] extensions with the release [12:34:42] fricking yay [12:35:10] 12 lines of python [12:35:13] Most of which were copy paste.. [12:37:27] oh so I had some commits I tagged a couple days ago, I guess they have had a bunch of comments (which I did not look at yet), anyways when they get the "ok" mark, if you want to let me merge em in that's fine [12:37:40] just poke me about it [12:37:58] they are export.php and the backups stuff [12:38:27] great [12:39:07] Seems my upload speed is nearly dead today [12:39:46] ugh [12:42:26] *troubled gives everyone the morning eye O_o [12:42:39] Reedy: time to get out and push! :D [12:44:12] Reedy: btw, I had disconnect problem with etherpad too, they told me it was ssl. stopped doing it soon as I switched to regular http. hope that helps [12:45:22] i'm using it on non https [12:46:37] *shrug* worth a shot mentioning :) [12:46:47] <^demon> https is for squares. [12:46:49] <^demon> :) [12:47:05] *troubled slaps ^demon around a bit with a large square trout :) [12:47:11] Right, md5 for both files match [12:47:26] <^demon> Reedy: Is there a tar without extensions bundled? [12:47:30] No.. [12:47:33] Do we need one? :/ [12:47:47] <^demon> I don't want WikiEditor to increase my tarball size :( [12:48:03] lmfao [12:48:09] though, probably very true [12:49:42] so is it up? [12:49:55] it's in my ~/public_html on fenari [12:50:06] I'm just wondering if we need to do what ^demon just suggested... [12:50:32] <^demon> I was being somewhat sarcastic :) [12:50:33] it's only 17m [12:50:36] it's teeeeeny [12:50:48] <^demon> ./languages/ is already huge, stripping out extensions wouldn't improve that. [12:50:59] Well... If people complain after the first beta, we can do it for the next ones [12:51:28] <^demon> Wtf is this supposed to mean? [12:51:36] What [12:51:36] ? [12:51:45] <^demon> weird local svn error. [12:52:37] payback for being sarcastic! ) [12:52:46] <^demon> svn: E155000: Failed to mark '[/path]' absent: item of the same name is already scheduled for addition [12:53:03] never seen that one before, neat [12:53:31] Anyone think http://etherpad.wikimedia.org/1180beta1ReleaseNotes needs anything else adding? [12:53:53] does this get added to an index.hmtl file someplace? [12:53:54] <^demon> Hmm, stack overflow says do a revert && cleanup before updating [12:53:56] <^demon> Let's see. [12:54:08] *apergos clicks around some on dumps.wm.o [12:54:22] http://dumps.wikimedia.org/mediawiki/1.17/ [12:54:24] grr, that etherpad is frustrating. Anyone else unable to scroll with leftmouse without it trying to resize in chrome? [12:54:25] Don't seem to.. [12:54:35] no I know the individual dirs don't have em [12:54:45] seems it wants me to scroll wheel only [12:54:48] <^demon> Have the old files not been moved over yet? [12:55:02] nope [12:55:20] ah you just need to update... [12:55:27] http://www.mediawiki.org/wiki/Download [12:55:34] so go to town, yer all set [12:55:54] Great, thanks [12:55:58] <^demon> hmm, did a revert -R && cleanup. [12:56:02] <^demon> Still getting the same error. [12:56:05] Do we add betas to the /Download.. [12:56:26] <^demon> History page says yes [12:56:28] why not? [12:56:30] mhmm [12:56:35] <^demon> http://www.mediawiki.org/w/index.php?title=Download&diff=401391&oldid=382226 [12:57:37] *Reedy sends the email [12:58:37] Arrrgh [12:58:47] The password TimStarling gave me for mediawiki-announce doesn't work [12:59:25] <^demon> If apergos knows the mailman password, he could change it for you. [12:59:36] I don't though [12:59:42] they changed it a while back and I didn't get it [12:59:46] Well, it's gone to wikitech-l and mediawiki-l aswell [12:59:51] I can see if it's in /home/wp/docs or something [12:59:55] So I don't think it's worth texting Tim at midnight [13:00:08] I'll just email him and ask him to deal with it in his morning [13:00:33] <^demon> How about mark? [13:00:35] <^demon> :) [13:00:46] huh, I have one [13:00:51] it miiiight be current [13:01:24] do I pm you or is that considered not safe enough? [13:02:15] I am SSL'd to freenode. Tim wrote it to my terminal on fenari [13:02:33] <^demon> Good morning sumanah [13:02:33] http://lists.wikimedia.org/pipermail/mediawiki-l/2011-November/038172.html [13:02:37] Well, the spacing on that is terrible [13:02:41] hi ^demon! [13:02:46] Reedy: thank you and congrats [13:03:14] wonder if that got to you [13:03:27] apergos: ? [13:03:33] to reedy [13:03:44] apergos, yeah, exactly the same as Tim gave me [13:03:49] bah [13:03:50] https://lists.wikimedia.org/mailman/admin/mediawiki-announce [13:03:53] Does it work for you? [13:03:54] well that's what is in the file [13:04:10] <^demon> Does he need to also be in the moderator's list for it? [13:04:14] yes [13:04:16] so try again [13:04:25] <^demon> Silly mailman. [13:04:31] that was yes to reedy [13:04:53] Reedy: release notes doesn't have the bundled extensions? [13:04:59] no, you don't have to be in a list or anything, you just have to know the password [13:05:06] mailman is set up like that for some weird reason [13:05:16] Authorization failed. [13:05:25] seriously [13:05:33] try another browser with cache and cookies cleared [13:05:37] Reedy: I shall edit the MediaWiki News template [13:05:44] I've just done it [13:06:08] Stupid Chrome [13:06:09] That worked [13:07:09] ok, never mind, I had to hit refresh to see that you'd done it [13:07:21] heh [13:07:41] <^demon> F'ing svn. [13:08:13] Reedy: (and then correct the wording/link, np) [13:08:14] "Posting to the announcements mailing list is restricted. To ask questions about MediaWiki, please subscribe to mediawiki-l, by [13:08:14] visting: [13:08:14] " [13:08:16] haha [13:08:32] :-D [13:08:33] maybe *I* should be on the can-post-to-announce list [13:08:58] <^demon> Wonder if it's because I'm running a different client. [13:10:20] It would seem like it has eaten my email [13:10:31] <^demon> Held in moderation? [13:10:48] Thats what I guessed [13:10:49] "There are no pending requests. Click here to reload this page." [13:11:02] what?? [13:11:08] <^demon> sumanah: Unless you're releasing the actual releases, not sure why you'd need it :) [13:11:48] ^demon: you are right [13:13:04] "Action to take when a moderated member posts to the list." Reject [13:14:32] I was hunting for that [13:14:44] but mailman's ui is so friendly I couldn't find it [13:15:13] Privacy options -> Sender filters [13:15:34] I'm not supposed to set it to hold, send the email, moderate it, and then set it to reject again am I? [13:15:50] I have no idea [13:15:58] I bet there are a few unmoderated members of the list [13:16:21] but damned if I can find them without going through the whole list of 28403 people [13:17:11] for mediawiki-announce you need a password, I have it set up in a paranoid way [13:17:11] I don't really like the idea that anyone who can put my name in the From header can spam 10,000 people [13:17:11] so I have it on "emergency moderation" permanently, which means nobody can post, not even me [13:17:22] great [13:17:32] is that anywhere other than in yer notes? [13:17:45] so yeah he's not moderated as a member [13:17:58] but if emergency moderation means all mail gets tossed, then. phhtt [13:18:13] I would make sure you are not moderated [13:18:18] then turn off emergency mod [13:18:20] send yer mail [13:18:29] Nope... Tim sent it in PM last nigth [13:18:30] wait for it to go through, then turn emergency mod on again [13:20:24] *apergos waits for the mail [13:24:00] Doesn't seem to have made any difference [13:24:09] nope.. [13:25:03] you're not subscribed? [13:26:29] I am now.. [13:26:38] you should be subscribed, unmoderated [13:26:45] then to the handwaivin witht he emergency mod [13:26:50] handwaving [13:26:52] with [13:26:53] the [13:26:59] sorry for the zillion typos. [13:27:38] right, ok now.. [13:28:29] Subscribed, emergency off, "Action to take when a moderated member posts to the list" to hold [13:28:46] *Reedy reverts config changes [13:29:05] Yay [13:29:06] http://lists.wikimedia.org/pipermail/mediawiki-announce/2011-November/000102.html [13:29:20] excellent [13:29:25] Thanks! :) [13:29:32] and now I can close that tab :-) [13:29:36] heh [13:29:46] better finish packing and set off for london [13:30:18] ooohhh nice [13:30:21] have a good trip! [13:30:31] Fucks sake [13:30:40] now I'm being spammed by message queues [13:30:47] [rt.partio.net #1797] AutoReply: [MediaWiki-announce] MediaWiki 1.18 beta 1 [13:30:53] [SUPPORT #ABN-170277]: [MediaWiki-announce] MediaWiki 1.18 beta 1 [13:30:59] I don't want dutch emails sending! [13:31:10] Or german [13:31:13] hahahaha [13:31:53] We'll see how nice london is, going for the Mozilla conference, so most of the weekend working, but I get to wear a lab coat [13:33:14] Your message was sent from an address which is not on the list [13:33:14] of people who are authorized to post to this mailing list. [13:33:26] Why have people subscribed to a mailing list with a damned mailing list? [13:33:47] team-security-announce-request@w3.org [13:33:53] I would've hoped they would know better.. [13:35:49] <^demon> wikitech-l used to be subscribed to php-announce or w/e they called it. [13:35:52] <^demon> It can be useful. [14:06:40] yeah. [18:20:54] is CloneDatabase.php in active use? [18:29:10] blobaugh, it's used by the tests [18:30:32] jorm, want to try live-streaming the brown bag or just record & upload video after? [18:30:47] i wasn't aware that we were recording anything. gulp. [18:30:50] ustream is kinda covered in spammy ads but seems to work [18:31:00] heh [18:31:46] i have no opinion about it. [18:50:26] Any reason why DatabaseTest.php cannot be filled in with tests for all of the methods and then used by itself to test the running db instead of creating a new test file per db type [18:55:53] Hello out there [18:56:02] h jpostlethwaite [18:56:05] I need to override a title on a special page [18:56:12] what is the best way to do that? [18:56:24] Hi sumanah [19:00:15] I see {{DISPLAYTITLE:xyz}} [19:00:20] can be used [19:00:32] but I need to change it in the code [19:00:45] It's a Krinkle 1 [19:00:47] *! [19:00:54] I'm fixing bugs [19:00:54] RL2 [19:01:16] Cool [19:01:23] Maybe I could convince you to fix a presentation instead? [19:02:05] Yep [19:02:07] :) [19:02:19] Hence I'm joining the communication services [19:02:22] hexmode: did you need to chase Krinkle down regarding a FIXME? [19:02:33] for lo, he is here [19:02:34] behold [19:03:15] Krinkle: yo! [19:03:19] Popular guy [19:03:37] fixme time: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report [20:59:51] triage time... [20:59:52] surrur [20:59:57] in 5 [20:59:59] 4 [21:00:05] ... 3 2 1 [21:00:28] http://etherpad.wikimedia.org/1-18-milestone-bugs [21:00:51] Nikerabbit: think I've got one for you if you can help [21:00:52] hi all [21:02:07] *sumanah looks at the 7-10 bugs in the Etherpad, is glad [21:02:15] Nikerabbit: http://bugzilla.wikimedia.org/31627 ... is this something you could look at in 1.18? [21:03:43] *troubled pokes hexmode [21:03:45] :D [21:03:50] troubled: heh [21:03:53] ok [21:03:53] just noticed the chat thingy [21:04:18] First bug: http://bugzilla.wikimedia.org/31060 -- [Regression] Sortable tables: "unsortable" should also work for rows outside the table heading [21:04:26] anyone else here for triage? [21:04:30] hexmode: possibly [21:05:22] Krinkle: bug 31060 -- you had some thoughts on that [21:05:26] Nikerabbit: you could possibly look at 31627? I'll put that in etherpad [21:05:38] yes [21:05:40] *Krinkle is invisible [21:05:41] is there a test case? [21:06:10] I think brion gives one, doesn't he [21:06:25] something I could copy paste [21:06:30] and you could just use that page with the diff [21:06:33] Nikerabbit, hexmode, *which* bug are you talking about? this gets confusing fast if we bring up multiple bugs at once. [21:06:40] but ok, I'll get you something like that [21:06:54] sumanah: 31627 [21:07:14] Krinkle is evidently willing us to ignore him :P [21:07:24] I could write a script to generate that [21:08:03] Nikerabbit: to generate crashing code? so I don't have to do anything? [21:08:05] :) [21:08:08] bonus! [21:08:55] for i in `seq 1 1000`; do echo "[[$i]] "; done [21:08:56] sorry I'll read my bugmail and reply. gotta work on tomorrows presentation now :) [21:09:14] hello [21:09:15] Krinkle: np [21:09:18] ialex: ! [21:09:20] hey! [21:09:35] so moving on: http://bugzilla.wikimedia.org/31060 -- [Regression] Sortable tables: "unsortable" should also work for rows outside the table heading [21:09:36] I think https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101858 and its follow ups should be merged [21:09:56] workarround is already in 1.18wmf1 [21:10:23] ialex: which bug is that for? [21:10:31] hexmode: humph, I did that and it doesn't crash for me [21:11:00] hexmode: https://bugzilla.wikimedia.org/32027 [21:11:05] Nikerabbit: lame. try more? [21:11:23] Nikerabbit: are you using 1.18? [21:12:29] I assume other people have the ability to see bug 32027 [21:12:31] ialex: ok... thanks for pointing that one out. I'm sure it won't be a problem to get it merged [21:12:31] trunk [21:12:38] sumanah: I do [21:12:51] sumanah, nope [21:12:51] Nikerabbit: maybe it is fixed in trunk? [21:13:16] eliding the private data... [21:13:22] it's 13 minutes into the hour and we've only looked at 1 bug. let's continue with http://bugzilla.wikimedia.org/31060 [21:13:35] hexmode, Nikerabbit, you can follow this up offline [21:14:47] Comment from ialex's bug: Checkuser results using "get edits" for [USER] show multiple edits with IP address and no user agent. Some but not all of these UA-less edits were made using Twinkle. Some but not all edits in a given editing session are missing UA. This user is editing from three ranges located in [COUNTRY]; however, no pattern seems to be associated with the ISP ranges. Earliest appearance of this seems to be 9 October. [21:15:16] continued: Similar bug has been reported through other channels relating to absence of UA associated with Wikilove edits. [21:15:16] [21:15:33] so, UA in JS problem (reported elsewhere, too) [21:15:56] hexmode: I might have fixed it already: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97815 [21:17:01] Nikerabbit: try that against 1.18 [21:17:21] is merging r101858 (plus its followups) in the scope of this triage? [21:17:23] member:hexmode: problem is that I changed wfGetIP and wfGetAgent to use $wgRequest and $wgRequest is overridden in ApiEditPage with a FauxRequest, headers were not accessible anymore while executing EditPage stuff from the API [21:17:44] *ialex stabs Colloquy [21:17:55] sumanah: I think I need to get 31060 followed up with krinkle [21:18:40] hexmode: ok. is ialex's suggestion in the scope of this triage? if so, let's talk about it, get brion in. Otherwise let's talk about bug 31511 -- Unable to add/remove buttons from (classic) toolbar from a gadget after MW update [21:19:01] sumanah: I think it is, yes. I wasn't able to find consistent reports of UA-less JS but if he has it there, then yes. [21:19:06] ok [21:19:56] sumanah: but merging that is basically finding someone to do it [21:20:01] so lets ove on [21:20:24] http://bugzilla.wikimedia.org/31511 -- Unable to add/remove buttons from (classic) toolbar from a gadget after MW update [21:20:25] ok. [21:20:49] RoanKattouw says needs a toolbar stuff needs a rewrite [21:21:00] Oh yes please [21:21:04] *hexmode tries to bring RoanKattouw into the room [21:21:08] it worked! [21:21:43] RoanKattouw: so, is that something that should be in the REL-NOTES? "Toolbar mods might not work" [21:22:01] I... don't know [21:22:13] I'm busy with something else right now that needs to be done by tomorrow morning [21:22:20] And I would like not to distract myself from that right now [21:22:30] RoanKattouw: it seems like a redesign right now is out, though, right [21:22:31] ? [21:22:53] No, the interface could still be changed in a backwards-compatible way [21:23:05] (By interface I mean API for manipulating toolbar buttons) [21:23:37] ah... so I understand you don't have time, but is it resonably something to do in a weekend? [21:24:19] Possibly [21:24:26] But not one of my weekends [21:24:35] hexmode: you do know that Timo and Roan are busy *this* weekend? [21:24:38] giving a speech? [21:24:47] I spend my weekends preparing applications to universities and preparing an intercontinental move [21:25:19] sumanah: yes, but I'm trying to think if I can find *someone* besides them [21:25:34] but that is probably a vain hope [21:25:41] hexmode: so it sounds like here we need for someone to decide among (a) fixing for 1.18 (b) leaving unfixed for 1.18 but noting something in README/Release notes. [21:25:45] what about Trevor? [21:26:01] Platonides: I was just thinking that [21:26:06] I'll follow up with him [21:26:22] ok, so, conclusion: we actually want to fix this for 1.18, and hexmode will follow up with Trevor. [21:26:23] Trevor's trying to get VE deployable within a month [21:26:24] right after this if I can [21:26:41] I find it unlikely Trevor will be avilable to fix this by 1.18 release [21:26:46] *hexmode wants a time machine [21:26:47] but he's somewhere to start. [21:27:12] VE? [21:27:30] Visual Editor [21:27:34] oh [21:27:36] next? [21:27:52] http://bugzilla.wikimedia.org/31682 -- MW1.18 broke Edittools for Special:Upload [21:28:05] DJ has a suggested solution [21:30:02] this looks like it might have a simple solution: https://bugzilla.wikimedia.org/show_bug.cgi?id=31566#c3 [21:30:49] thedj: you could provide a patch? [21:32:08] Hrm... [21:32:26] if thedj is silent, too, then lets move on [21:32:43] I'll ask Trevor about the above when I talk to him [21:32:57] next: https://bugzilla.wikimedia.org/show_bug.cgi?id=31691 [21:33:22] I think this is not reasonable to have as a target for 1.18 [21:33:54] Gonna move it to 1.19 unless there is an objection [21:34:33] "Don't send javascript to incompatible browsers" [21:34:43] "On de.wikipedia there is a report that javascript crashes an Opera 9.10.521." [21:34:55] so that should be fixed [21:35:05] but I think the bigger request is too much [21:35:21] and would require something like WURFL [21:36:21] Blacklisting the specific Opera version is easy [21:36:44] RoanKattouw: is that something they can do on-wiki? [21:36:57] No [21:36:59] :( [21:37:03] But it's easy to do in the code [21:37:12] ok [21:37:35] resources/startup.js [21:37:41] Code blacklisting old IE versions is already there [21:37:47] We'd probably want to ditch Opera < 10 [21:38:13] RoanKattouw: I'll poke at it, unless you can do it in, like, 5min. [21:38:18] Provided that's rare enough according to Erik Z's browser stats [21:38:21] You do it [21:38:30] k [21:38:52] conclusion: hexmode to attempt a fix to the smaller issue [21:39:07] right [21:39:21] ok, next [21:39:23] this one bawolff has chased quite a bit http://bugzilla.wikimedia.org/31732 -- Category count of file numbers is wrong on first page [21:39:24] we have 20 min left [21:39:31] wait, wait, wait [21:39:38] hexmode: before that [21:39:39] http://bugzilla.wikimedia.org/31694 -- During installation, tabbing order (cursor focus) goes to logo instead of "continue" [21:39:39] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/102027. Review and merge? [21:39:49] let's get some opinions on r102027 [21:40:52] AzaToth: DanielFriesen: does r102027 look ok to you? [21:41:35] ialex, Platonides ^^ [21:41:35] sumanah: if nothing else I'll get reedy to merge it tmw [21:42:01] If nextTabIndex is implemented correctly, I guess? [21:43:24] hexmode: I figure, let's try to get this codereviewed [21:43:30] as part of our reviewmeistering. [21:43:37] DanielFriesen: while I have you looking at code: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101464 [21:44:35] ok, let's move on [21:44:36] http://bugzilla.wikimedia.org/31732 -- Category count of file numbers is wrong on first page [21:44:36] In the last two comments Bawolff seems to have tracked down the issue. Any ideas on a solution? [21:44:41] sumanah: np... [21:45:14] on trunk the taborder is not good: "continue, start from beginning, language selectors" [21:45:27] (15 minutes left, 3 bugs to cover in this triage.) [21:45:39] Nikerabbit: so is r102027 an improvement? [21:46:25] sumanah: probably yes, otherwise you would have to tab zillion times to get to the language selector [21:46:57] sumanah: I can test, then apply and test then mark ok ;) [21:47:40] *DanielFriesen lacks enough quick context so say much about 101464 [21:47:57] and then chase down Reedy to make sure these merges go through on Monday [21:48:06] ok, hexmode. [21:48:11] next, then: 31732 -- Category count of file numbers is wrong on first page [21:48:15] DanielFriesen: thanks anyway ;) [21:48:23] sumanah: that one looks weird [21:48:45] there are a couple places were the page displays 200 images, some where it shows 201 [21:49:03] bawolff did a bit of tracking on it. [21:49:08] this does not seem important enough for us to try to fix it for the release [21:49:26] sure, another to add to the notes [21:49:36] moving on... [21:49:57] conclusion: remove the 1.18 tarball release milestone for 31732. [21:50:05] DanielFriesen already looked at this one [21:50:13] http://bugzilla.wikimedia.org/31770 -- Allow URL parameter wpCCMe on Special:EmailUser [21:50:13] Regression. Review https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101464 and merge? [21:50:38] right, anyone besides DanielFriesen here? [21:50:49] *hexmode looks around for someone to poke [21:51:39] hexmode: johnduhart, thedj, ialex, Platonides, saper? [21:51:46] hexmode: I unexpectedly have to go now. [21:52:09] sumanah: np. cya [21:52:35] hexmode: grab MaxSem from #mediawiki, or gicode? [21:52:46] johnduhart: could you poke at https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101464 [21:52:52] sumanah: will do [21:53:35] I don't really understand why it does what it does [21:53:50] heh [21:53:52] so I'm not confortable oking that revision [21:54:06] ok, Platonides, same here. [21:55:19] hexmode: should be good [21:55:47] ialex: could you sign off on it or ok it? [21:57:11] Finally: I put this one on, but Maybe we just need some sort of release notes for it:https://bugzilla.wikimedia.org/show_bug.cgi?id=31990 [21:57:33] *hexmode really wants a "known issues" list [21:57:58] Platonides, ialex, johnduhart ^^ [21:58:59] *hexmode prepares to make a unilateral decision [21:59:57] hexmode: done [22:00:14] *hexmode thanks ialex profusely ;) [22:02:11] what was https://bugzilla.wikimedia.org/32027 mentioned earlier? [22:02:28] Platonides: 1s and I'll look [22:03:32] Platonides: essentially it is a no-ua-in-js-requests bug [22:04:23] Platonides: fixed with https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101858 [22:04:29] ah [22:04:38] that one [22:04:50] silly hidden bugs [22:05:07] it has sensitive user info in it!! [22:05:31] it shouldn't [22:05:50] Platonides: has to do with a report on user blocking and such [22:06:01] that's a bit nastier, then [22:06:32] but mostly the focus is on UA-and-JS [22:06:57] I pasted the redacted first comment above [22:06:59] 1s [22:07:21] Platonides: here ya go: Checkuser results using "get edits" for [USER] show multiple edits with IP address and no user agent. Some but not all of these UA-less edits were made using Twinkle. Some but not all edits in a given editing session are missing UA. This user is editing from three ranges located in [COUNTRY]; however, no pattern seems to be associated with the ISP ranges. Earliest appearance of this seems to be 9 October. [22:07:50] ok, ok [22:09:08] the fact that we would be losing CU data is enough to hide it [22:09:19] (until we found the reason) [22:09:37] but I understand that the CU resutls shouldn't be published [22:09:57] although if it's only the country, it's not that secret [22:10:07] k, I gotta go... kids are calling [22:10:37] Platonides: yeah, but the core is problem looks solved. [22:10:39] cya [22:10:56] a good thing :) [22:10:57] bye [22:23:12] hi hexmode - how did the end of the triage go? [22:23:45] I think he's away now [22:23:51] k, I gotta go... kids are calling [22:23:57] ok [22:24:00] thanks Platonides [22:24:21] Platonides: have you had time to try to review any of https://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report ? [22:26:16] I did a few yesterday [22:26:33] thank you