[09:09:48] Hey RoanKattouw, good morning. [09:10:00] Morning [09:10:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=31096 [09:10:26] Can you please tell me who deals with this kind of bugs? [09:11:33] RoanKattouw ^ :) [09:11:55] Ah, wiki creations [09:12:08] Looking at the tracking bug (bug 16976) those are backlogged a bit again [09:12:10] Yeah, do you fix this kind? :) [09:12:14] I'm not sure who deals with these now [09:12:17] No, not me [09:12:22] Ah, okay. [09:12:32] Creating a wiki means messing with DNS which I stay away from [09:12:39] I don't know how long it will take.. but it is really needed. [09:12:47] We have no sites at the moment. :/ [09:13:03] The Belgians and Mexicans are in the same situation (re chapter wikis) [09:13:10] Yeah. [09:14:06] To coordinate among volunteers, we desperately need a site. [09:15:33] RoanKattouw, can you tell me who to ask about this (I mean as you have no clue who deals with it, you may have a clue about who to ask)? :) [09:15:57] The usual suspects for wiki creations are robh and JeLuF [09:16:51] Okay, thanks a bunch! Rob is here, but I think he is in sleep now. [09:17:50] *Tanvir just found JeLuf on #mediawiki. Hope he is awake! [12:49:29] werdna: You around? [20:54:01] ox [21:20:05] RoanKattouw: Currently implementing the 'create' dialog. Wondering what validation I should apply. [21:20:37] The backend should validate page title against module-name-validation in NS_GADGET_DEFINITION, right ? [21:20:57] Ah, what now? [21:21:05] module name validation/ [21:21:06] We're having double constraints on what a gadget id can be. [21:21:17] the id must be a valid page name and a valid module name [21:21:37] I didn't think there were constraints other than /^Gadget_definition:(.*)\.js$/ [21:22:19] right now there aren't, but there should be, right ? When editing a page, don't create/update a gadget row if the page name is not a valid module name [21:22:46] Oh, right [21:22:52] Well, which characters are blacklisted [21:22:55] Pipe is no problem [21:23:06] Right now ResourceLoader->register checks against [21:23:07] preg_match( '/[|,!]/', $name ) [21:23:22] Yeah [21:23:27] Just found it [21:23:34] So in a title, we need to check for , and ! [21:23:47] | is already checked by just validating it as a title in the first place [21:23:55] right [21:24:07] But I'd like to do client side validation when entering an id [21:24:20] I'm having trouble finding the forbidden characters in a title [21:24:34] $wgLegalTitleChars or something [21:24:42] Anyway, you should need to check those [21:24:49] mw.Title() should do that for you [21:25:07] (And if it doesn't, action=edit will of course refuse to save the page) [21:25:12] yeah [21:25:48] Ah, I see. The internal clean() function of mw.Title is pretty much Title::getTitleInvalidRegex [21:26:19] I'll pull it through mw.Title, and if it's not the same, it's inv alid [21:31:06] ai??? [21:31:16] Original exception: exception 'MWException' with message 'ResourceLoader module name 'gadget.askmskf23i7r194,.; ' is invalid. Names may not contain pipes (|), commas (,) or exclamation marks (!)' in /Users/krinkle/Sites/mediawiki/trunk/phase3/includes/resourceloader/ResourceLoader.php:241 [21:31:35] oh, right. That's because the backend doesn't do that check yet. [21:33:02] crap, I can't edit the wiki anymore. need to nuke it from the db [21:33:03] :P [22:30:44] Cave Mode: Activated. [23:15:33] i wish erik would log into aim more often.