[12:18:36] RoanKattouw, FYI, don't push to the site and leave :P [12:18:58] Grah, sorry about that [12:19:03] heh [12:19:06] wasn't a big deal [12:19:16] I saw the followup to that whole thing, yeah [17:02:12] RoanKattouw: Regarding Memcached keys in RL2. I thought for a second, perhaps drop the prefixes 'local' and 'foreign' in the keys, that would solve the need to override them (it's per-wiki right ? And ForeignDBGadgetRepo already specifies that it should use wfForeignMemcKey() instead of wfMemcKey(). [17:02:33] Or must keys be unique across both wfForeignMemc and wfMemc ? [17:02:34] There is a cache pollution issue there [17:02:37] No [17:02:44] The thing is, the following thing happens [17:03:04] Say wiki A uses wiki B as a foreign repo [17:03:09] ok [17:03:12] Then A will attempt to pull B's gadget list from B's memc [17:03:28] If that misses, it will query it from the database [17:03:43] using WHERE gd_shared=1 because it's only looking for shared gadgets, because it's a foreign repo [17:03:49] ok [17:03:58] Then it will write the names list, *without the non-shared gadgets*, back to B's memc [17:04:05] oh, right. [17:04:24] So they do share the same cache ? [17:04:25] So the list for foreign consumption needs to be cached separately from the list for local consumption [17:04:30] Well, yes [17:04:37] B goes to its own cache using wfMemcKey [17:04:45] A goes to B's cache using wfForeignMemcKey() [17:04:47] In that wfForeignMemc for wiki B from wiki A, is the same as wfMemc locally from/for wiki B [17:05:15] Yes [17:05:22] I thought the foreign cache was separate or something, but it's accessing the 'local' (or rather, 'only') cache of the other wiki. [17:05:25] Basically, memcached doesn't have separate caches [17:05:27] Alrighty, makes sense. [17:05:45] So wfMemcKey() is implemented as $wgDBname . ':' . implode( ':', $args ) [17:05:53] roughly [17:06:35] And wfForeignMemcKey( $wiki, $tablePrefix, ... ) is $wiki . ['-' . $tablePrefix .] ':' . implode( ':', $args [17:07:04] In practice, it means your cache keys look like enwiki:gadgets:localreponames [17:07:04] Oh, so all wmf wikis share one memcached ? [17:07:07] Yup [17:07:18] And the wikis' caches are segregated using key prefixes [17:07:20] Not just local/foreign together, across wikis as well. [17:07:35] So yeah, foreign memc access is easy [17:07:40] Does have nice advantages, but can be weird when unexpected. [17:07:55] Normal code just uses 'enwiki:' . $key , you just have to work around that deliberately to get it to use $someOtherWiki . ': ' $key [17:09:02] Hm,, there is no wfMemcVal( $key ) ? [17:09:06] Oh that's $wgMemc [17:10:00] Yeah [17:10:07] You can put arbitrary keys into that, theoretically [17:10:19] In practice you're supposed to use either wfMemcKey() or wfForeignMemcKey() [17:10:47] hehe, we could get evil and put cache into Context. Kinda useless though since it's globalness rises above MediaWiki [17:10:56] $this->getMemc() [17:11:33] Graaaah I just discovered a bug [17:11:35] Fix incoming [17:12:12] RoanKattouw: btw, we've got a bit of a low priority issue that's bugging right now. Rename from 'name' to 'id' is not in 1.18 [17:12:26] Perhaps just drop the APIs in 1.18 ? [17:12:27] I just put it in trunk today, and tagged it for 1.18 [17:12:36] oh, okay. [17:12:41] Sam merged my original API forward-compat rev to 1.18 today [17:12:49] If you could review my other trunk API rev [17:12:49] I should put extensions/Gadgets in trunk on my watchlist. I forget to look at that, again. [17:12:53] *RoanKattouw looks up numbre [17:13:00] !r 96833 [17:13:00] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96833 [17:13:20] And r96832 for good measure [17:15:34] RoanKattouw: Did you only do the rename in the public facing code on purpose ? [17:15:40] ie. $g->getName() [17:15:40] Krinkle: BTW, I'm already successfully loading UTCLiveClock cross-wiki [17:15:41] Yes [17:15:53] OK [17:15:56] I had to put in the gadget-UTCLiveClock=1 preference manually in the DB, of course [17:16:04] Because there is no UI in preferences for shared gadgets [17:16:07] right [17:16:14] But once you do that the rest Just Works (TM) [17:16:18] I made the first ajax edit yesterdauy [17:16:27] wiki page, recent changes and DB are updated perfectly [17:16:44] will commit later today [17:17:24] Also, I killed ApiGadgetRepo [17:17:26] That was unused, right? [17:17:53] I honestly didn't know it was in svn [17:18:08] Ahm [17:18:10] I'm sorry [17:18:15] ApiGadgetRepo is vaporware at this point [17:18:19] I meant ApiGadgetManager [17:18:26] Yes, unused. [17:18:43] at least unused in my local copy, it might still be called in the current branch. [17:18:56] but the doModifyGadget in gadgetman.api.js uses ApiEdit [17:19:12] OK [17:19:15] RoanKattouw: btw, just quickly looking over your recent commits regarding caching [17:19:19] IIRC that function is empty in SVN [17:19:25] Yeah figured you were [17:19:28] it seems loadData gets json and timestamp. Should it get title and description as well ? [17:20:16] Those things are in the blob, aren't they? [17:20:25] No, you keep thinking that ;-) [17:20:36] Oh, right, they're messages [17:20:45] Whose keys are inferred from the gadget ID [17:20:53] I guess we could cache those somewhere [17:20:57] Yes, keys are peanuts. The values is the issue. [17:21:09] Not sure how much sense that makes since the i18n system itself also has caching [17:21:10] due to cross-wiki ness. [17:21:17] Oooh [17:21:19] Right [17:21:20] even more with the ApiRepo [17:21:33] Well, yeah [17:21:36] I hope we can avoid server-on-server api requests, not sure we can though. [17:21:47] We might have to once in a while. [17:22:00] It looks like you can currently do things with the Gadget class that will produce confusing results [17:22:16] Like, if you load a Gadget object from a blob that came from a foreign DB, and then call getTitleMessage() [17:22:35] Those things shouldn't be done, and AFAIK aren't being done right now [17:22:44] Maybe it should actually prevent you from doing that [17:22:57] From what I remember, title/description values are only needed in ApiQueryGadgets, which is always 'local'. [17:23:06] And SpecialGadgetManager [17:23:27] Which, BTW, does not have a 'create' option in SVN [17:23:34] No, we ran into this earlier on the plane and realized it wasn't the case in SpecialGadgetManager [17:23:41] Yes [17:23:42] it's confusing, but it's obvious. No remote gadgets in the manager :D [17:23:43] That's what I meant [17:23:53] SpecialGadgetManager uses i18ned messages but only for local gadgets [17:24:03] yep [17:24:06] I don't think we need i18n-ed titles/descriptions for foreign gadgets anywhere on the server [17:24:15] The only place you need it is the preferences tab for foreign gadgets [17:24:21] which is ajax-made. [17:24:24] Ye [17:24:25] s [17:24:26] is/will be [17:24:45] (That'll need JSONP, BTW) [17:24:57] Yep [17:25:31] jQuery does that transparently though. I don't even notice whether it's Xhttp-JSON or script-tag-JSONP-callback [17:25:50] You may need to put in ?callback=? in your URL, though, right? [17:25:50] That's a bit scary though, as it breaks when a site doesn't support JSONP. [17:25:58] I think the default behavior is ?_=? [17:26:02] jQuery just assumes it supports it when it's not local by appending ?callback= [17:26:10] Or is that for cache busting [17:26:14] hmm, so callback is the default param name? [17:26:16] underscore is for cache busting [17:26:18] In that case we're good [17:29:07] RoanKattouw: by the way, I've been showing some nlwiki users screenshots of our branch to get some feedback. To spare the report, I think we should keep Special:Gadgets [17:29:15] Perhaps under a different name though [17:29:40] By that you mean "some sort of interface that shows the same thing"? [17:29:45] (Which is what, again?) [17:30:05] basically a special page listing all gadgets by section with titles and descriptions. In addition to that for users that can 'editinterface' edit-links to NS_MEDIAWIKi + links to Special:Export. [17:30:25] Can't we integrate this with the gadget manager somehow? [17:30:40] I guess each gadget could have an [edit metadata] link or something [17:30:52] Yeah [17:31:12] I don't really see why this can't be the primary interface to the gadget manager rather than the table that we have now, except maybe that the latter is simpler [17:31:23] (Takes less space, easier to find stuff etc) [17:31:42] difference being that SpecialGadgets is split by ==category==, and GadgetManager a for all gadgets. [17:32:23] Yeah [17:32:31] I'll see if I can make a replacing interface. Although it'll get funky if the logged in user is a manager + editinface [17:32:38] to crowded imho [17:32:42] We'll see [17:36:20] RoanKattouw: "wasn't documented that I know of. Besides, enwiki didn't even use it :)" , wow amazing [17:36:43] That's thanks to the syntax though, which is ==category== on MW:Gadgets-definition [17:36:57] although??? wikitext does generally work in section headers in mediawiki [17:36:58] :O [17:37:07] Yeah I figured links would be used [17:37:22] But surprisingly, they're not [17:39:19] syntax that didn't get used on enwiki? i find that hard to believe [17:39:25] hehe [17:39:36] ssst, not so loud [17:43:41] RoanKattouw: A nice win: Previously the instructions for manual exporting/importing included "copy and paste the definition to ???.". That can now be nuked. [17:44:04] The SpecialExport link can now include everything :) definition, resources and (if present) messages. [17:44:09] Yeah :) [17:44:24] Well, does Special:Export have multi-page syntax? [17:44:32] of course we want to encourage repo-sharing. But it's a nice touch [17:44:36] I guess you could emulate it with ?param=Foo%0ABar%0ABaz [17:44:41] I don't know how it does it currently [17:45:23] RoanKattouw: $this->getTitle( "export/{$gadget->getId()}" ) [17:45:28] interesting [17:45:39] Eh? [17:45:42] How can that even work? [17:45:44] SpecialGadgets.php [17:45:46] Dunno [17:46:26] Ah [17:46:30] Special:Gadgets/export/id [17:46:47] RoanKattouw: SpecialGadgets::showExportForm [18:01:29] neilk_, raindrift: #52 {main}[12-Sep-2011 17:45:37] Catchable fatal error: Object of class LocalFile could not be converted to string at /usr/local/apache/common-local/php-1.17/includes/Html.php on line 447 [18:01:32] And I know why [18:01:39] $sessionKey = $this->mUpload->stashSession(); [18:02:08] Hmm, that is supposed to return a string [18:02:21] Reedy: joining us for 1.18 daily? [18:02:25] RoanKattouw: hm, again?! [18:02:31] Ya [18:02:35] I thought they fixed that last week. :( [18:04:24] Grah [18:04:27] That DOES return a string [18:04:31] I don't understand why this error occurs [18:04:40] I can quite clearly see a LocalFile object being passed into HTMLForm [18:04:40] hexmode: you there? [18:04:48] As the value for a type=hidden in fact [18:04:50] But I can't see WHERE [18:04:53] robla: yep [18:07:01] JeroenDeDauw: hey please see my comment here http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96575#c22390 [18:08:07] neilk_: sure [18:08:24] JeroenDeDauw: Let's discuss it in #mediawiki [18:11:57] rawr [18:12:09] I can't figure out that error [18:12:15] Even with a backtrace [18:12:24] Hopefully it was a fluke [18:14:44] neilk_: OK so you're doing the deploy today? [18:16:49] neilk_: yes, sorry, I am just realizing now that I need to do it a bit piecemeal as there are changes I don't want to deploy. Unless we are comfortable reverting changes made to the API in the next deploy? :( [18:16:56] er, ^^RoanKattouw [18:17:17] OK [18:17:24] Well it's your party [18:20:24] RoanKattouw: actually can you review a change for me: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96591 [18:20:27] 3 lines [18:20:57] neilk_: Ok [18:21:01] OK'ed [18:23:16] RoanKattouw: thanks [18:47:26] hey, anybody messing with XFF files on fenari? [18:47:30] see us on #mediawiki... [19:08:38] RoanKattouw: Looking at r96884 diff, i see my comment about sorting '' key at the end. You mentioned using a sort-callback filter. What about unsetting it and re-adding it to the array (after ksort() ), that would put it at the end, right ? [19:08:56] Yes, that'd work [19:08:59] !r 96884 [19:08:59] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96884 [19:09:02] I know it's a bit ugly but feels faster performance wise then checking every key against a callback [19:09:18] It's at the bottom of the diff in the grey [19:09:27] Ah yes [19:09:31] Yeah, it makes sense [19:09:41] Just add explicit comments explaining what you're doing [19:09:46] Sure [19:12:04] hi Krinkle [19:13:27] Nikerabbit: I just filed an RT ticket to get you deployment access. Will probably take a while (~1 week usually) since someone needs to approve it [19:17:36] RoanKattouw: who is going to coach me? [19:17:46] Me [19:18:02] If you wanna get a head start, read http://wikitech.wikimedia.org/view/How_to_deploy_code [19:30:22] Cool, very few changes schema needed to push 1.18 out [20:54:19] RoanKattouw: https://bugs.php.net/bug.php?id=55495 wow, it's that bad in PHP land ,uh [20:54:41] Yup [20:54:45] Oh, BTW [20:54:48] Now that you're here [20:55:04] Yes ? [20:55:14] 1) Did you end up submitting your expense report? [20:55:21] <^demon> RoanKattouw: Brought it up on internals yet to try and convince people it's actually a bug? [20:55:29] Nah [20:55:34] It's not that serious [20:55:36] Workaround was easy [20:55:42] <^demon> Awww [20:55:50] *^demon was looking forward to watching Roan dive into internals. [20:55:53] Convincing PHP developers is not a valuable use of my time unless the bug is serious enough [20:55:57] 1) I did not finish it, I got distracted Friday night and stopped half-way. Thank for the reminder, will finish now. [20:56:03] OK. Alolita asked about it [20:56:47] Said that you should submit it soon "if you want your money", and that it would help cover that laptop :) [20:57:20] 2) Alolita told me she wants me to work on the MoodBar dashboard. I looked at the designs and it looks like 10% backend API stuff, 10% CSS stuff, and 80% AJAXy JS [20:57:44] Given that you're in school, I figured I should take what I can and do both the backend and the JS, but I'll still need you or Trevor for the CSS (and HTML) [20:58:17] I'm gonna approach Trevor about this too, there's probably a horse trade there involving visual editor stuff [20:58:30] But what's your situation right now? Still working on the gadget manager? [20:58:58] RoanKattouw: Yes. That'll take about 2-3 more weeks given the number of hours I can work on it. [20:59:16] Ofcourse I could drop those hours and work on moodbar instead. [20:59:43] So you mean MB would take 2-3wks if you splice it with RL2? [21:00:14] I'm thinking it might be more productive to get Trevor to do the MB stuff and let you focus on RL2, then both things will probably be done faster [21:00:29] We don't need the guy who works 8-10 hours a week to be our bottleneck :) [21:01:57] RoanKattouw: I don't mind working on MB instead of RL, but I don't think working on both is an option as that would do neither good. (splitting up 2 hours into two single hours is not very productive given the few minutes needed to start up and close up) [21:02:14] and switching the mindset :) [21:02:20] Ah, an e-mail with details from alolita just materialized [21:02:38] Apparently it's a 2-wk sprint, daily calls at 7:15pm CEST starting tomorrow [21:03:24] Krinkle: Do you have a quick estimate of how much time it would take you to get me the HTML and CSS skeletons I need (the minimum I need to continue on my own) given that design page? [21:03:26] *RoanKattouw links [21:03:44] https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Feedback_Dashboard/design [21:04:27] <^demon> Can we turn https on for mw.org so I can stop getting secure.wm.o links from Roan all the time? [21:04:34] Haha [21:04:40] +1 [21:04:43] Ryan_Lane, ^ [21:04:45] gogogogo [21:04:52] :D [21:05:05] maybe. gimme a sec [21:05:08] hahaha [21:05:26] It'll need a config change that I will not make today [21:05:31] I think there's a reason we were going to do it last [21:05:39] yep [21:05:47] we ran out of addresses in esams [21:06:00] I'm replacing text.wm.o with mediawiki-lb.wm.o [21:06:09] <^demon> Aww, poor mw.org [21:06:10] heh [21:06:27] they can probably both point at the same IP without any issues [21:06:33] Whoa oops [21:06:37] *RoanKattouw shakes fist at IPv4 [21:06:38] RoanKattouw: The current design, I'd say 4-5 hours. (2-3 days). However I heard that the design might change soon since the design is still for the "Moodbar dashboard" whareas the project got repurposed for "Feedback dashboard". Also some interaction states seem to be missing, although those may be in the PSDs (which I would also need to get from jorm) [21:06:50] <^demon> Ryan_Lane: Figures its the only wmf site I use regularly :p [21:06:53] Right, hence my e-mail just now [21:06:57] heh [21:06:57] ("How final is this?") [21:07:02] ok [21:07:05] Krinkle: Hmm, OK [21:07:14] Well don't spend any time on it then until that settles down [21:07:18] yep [21:09:51] the designs are current with the exception of the "notification" system, which we can talk about. [21:10:18] I am somewhat leaning towards getting Trevor to do it all [21:10:40] hrm. there needs to be a "Set filter" button. so I'll add that. [21:10:49] Ryan_Lane: So you're setting up https for mw.org now? Can we schedule the config change for tomorrow? [21:10:57] I don't know [21:11:07] OK [21:11:10] I'm going to talk with mark about reusing the text.wm.o address [21:11:18] I'll just wait for your cue then [21:11:26] I want to make sure it won't cause problems [21:11:28] ok [21:11:41] well, the protocol-relative stuff can happen without the domain change [21:11:45] https just won't work :) [21:12:55] Sure [21:23:32] RoanKattouw: Did you deploy new upload wizard? [21:23:46] I see lot's of crap coming in [21:24:33] Oh, neilk_ , you seem to have deployed something [21:25:04] neilk_: The category: part in [[Category:bla]] is missing and something is looping, see for example https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=File:Bermeo_-_Iglesia_y_Convento_de_San_Francisco,_claustro_05.jpg&oldid=59323381 [21:25:26] {{self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|self|cc-zero}} [21:25:47] [[Uploaded with UploadWizard]] [21:25:54] Reedy: Exactly [21:26:19] So you probably want to revert that deploy and see what went wrong [21:26:35] i want to do a master switch on one of the db clusters, which requires putting its wikis in read-only mode briefly. should i schedule this on the deployment calendar? [21:27:02] More cases at https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=Special:WhatLinksHere/Uploaded_with_UploadWizard&limit=500 [21:28:08] I know a simple way to fix the category issue [21:28:44] binasher, I don't think it usually happens, but that isn't to say you shouldn't [21:28:58] hiddenCats.push( mw.UploadWizard.config.autoCategory ); [21:31:37] Anyway, really have to go to bed now. Please fix/revert/whatever this. Thank you :-) [21:31:39] Topic @ https://secure.wikimedia.org/wikipedia/commons/wiki/Commons:Village_pump#Upload_wizard [21:31:49] did neilk_ deploy something then disappear? [21:32:21] can we start to have some form of tar-and-feather for devs that do this? [21:32:26] Heh [21:32:33] it *really* isn't ok [21:32:38] Is he away from his desk? [21:32:49] I don't see him [21:33:08] He's rebranched [21:33:10] maybe we need a formal rule for this [21:33:15] so it's not even a simple revert [21:33:28] "if you deploy, you need to be around to support it for a minimum of 4 hours"? [21:33:30] <^demon> Ryan_Lane: You'd *think* common sense would prevail, yes? [21:33:37] you'd think so, but it doesn't [21:34:03] *RoanKattouw pours tar and feathers over self for last Friday [21:34:09] RoanKattouw: heh :) [21:34:30] <^demon> You never deploy + flee, unless you're handing it off to someone who's agreeing to watch it for you [21:34:39] multichill: I believe that issue is not new, people have been complaining about {{self|self|self for longer. Maybe it's more common now [21:34:41] you deployed something, then immediately left, 10 minutes later there was a problem, and someone said "wait, did Roan just deploy something and leave?" [21:34:47] hehe [21:34:50] ON A FRIDAY [21:34:54] on a friday. yeah [21:34:58] *Ryan_Lane stabs [21:34:59] Yeah, bad me [21:35:05] It was deployed about 2 hours ago [21:35:06] :) [21:35:16] I was like, OK, fuck work, it's Friday night and I'm tired [21:35:20] :D [21:35:29] best to decide that before deploying ;) [21:35:30] we should have paged you [21:35:30] It's not so bad when other people are about and have some clue what just happened ;) [21:35:35] brion: indeed [21:35:42] I was going to text him, but it fixed quickly [21:35:55] <^demon> Should've texted anyway, just to harass ;-) [21:36:00] If Neil isn't at his desk, look up his cell number on office wiki and call him [21:36:07] A bot can easily clean up the mess [21:36:13] My phone has 3 numbers for Roan now, I've nfi where from [21:36:15] Reedy: Would've been totally justified [21:36:19] haha [21:36:24] 3? That's impressive [21:36:32] I see where you got two... oh never mind [21:36:50] Most likely that's my cell, my old landline and my new landline [21:37:09] Hopefully there's only one number that starts with +316, that's my cell [21:37:21] I've 2 316 numbers [21:37:26] Hmm [21:37:34] I wonder what the other one would be [21:37:43] It might just be my mother's cell I guess [21:37:50] *^demon is the only +1804 number that most people around here have :) [21:38:12] Is one of them +31640 and the other one +31610 ? [21:38:23] The 10 one is mine [21:38:36] I'll +31610, +31517, +31640 [21:38:41] Ah, yes [21:38:43] 610 is my cell [21:38:46] 640 is my Mom's cell [21:38:51] 517 is one of the landlines [21:39:00] How have I got your moms cell? :/ [21:39:06] Have you borrowed it at some point? [21:39:39] Maybe as emergency contact info? [21:39:54] Also that number is so deeply ingrained in my brain that I will sometimes give people the 640 number instead of my own cell [21:40:06] ok. paged neil [21:40:23] The 517 number you have is probably 51785, right? [21:40:33] *RoanKattouw tries harder and harder not to make his full phone number public :D [21:40:51] yup [21:40:53] <^demon> Well you've given us enough of it that figuring it out should be fairly trivial ;-) [21:41:06] Yeah you only have about 4 unknown digits left [21:41:12] Call 10,000 people, not that much work [21:41:50] <^demon> Well my computer can iterate over those pretty quick ;-) [21:42:24] *RoanKattouw makes mental note not to answer calls from Richmond area codes on his landline [21:42:39] Anyway, the 51785 number is defunct [21:42:47] The new one is on the contact lis [21:42:49] t [21:43:26] Oh [21:43:32] My phone might have imported it from Google/Gmail [21:43:35] Oh and now Erik has discovered another UW bug [21:43:36] Ah, right [21:43:40] Forgot to update it there probably [21:43:50] hrm. his coat and computer are here. [21:43:53] i've only got one numberactually saved on my phone [21:43:54] Apparently some [[Category:]] tags are missing the category: prefix [21:43:55] <^demon> I'd prefer people call me on my cell anyway. My SIP line is pretty much offline except when I'm calling to a meeting. [21:44:00] <^demon> And I have zero clue how to check my voicemail. [21:44:04] RoanKattouw, which multichill reported earlier [21:44:04] My SIP is on line the whole time, at my house [21:44:07] he and ian had a friend and they left earlier. to lunch presumably. [21:44:22] Svetlana tried to call me earlier when I was in SF, and she reached my Mom in the late evening :D [21:44:31] Simplest hack for that bug [21:44:38] is 'autoCategory' => 'Uploaded with UploadWizard', to 'autoCategory' => 'Category:Uploaded with UploadWizard', [21:44:42] Oh OK [21:44:51] Rather than messing with JS [21:44:56] Someone go ahead and do it then [21:45:06] I won't because I don't want more tar and feathers [21:45:52] *jorm gets some tar. [21:46:22] <^demon> I want some pie. [21:46:29] *^demon thinks he will run to the store real quick [21:46:32] tar pie. [21:46:42] <^demon> No, like real pie. [21:46:44] <^demon> That you eat :D [21:46:46] <^demon> nom nom nom [21:46:57] Reedy: That's not the only faulty category link [21:47:01] Yeah [21:47:05] I didn't realise that first [21:47:24] It's just the only one that always happens [21:47:31] var wikiText = _getCats().map( function() { return '[[' + this.getMainText() + ']]'; } ) [21:47:36] JeroenDeDauw: ^^ [21:47:47] Easily fixed [21:52:58] multichill: so the issue is that you end up having [[foo]] instead of [[category:foo]] ? [21:53:08] Yes [21:53:28] Meh [21:53:36] And this worked before right? [21:53:36] JeroenDeDauw: Reedy is syncing up some stuff right now [21:53:52] I hax0red it [21:53:54] It's the deploy neil did about 2 1/2 hours ago [21:54:42] multichill: I probably broke it when making the underscores in categories go away [21:54:54] http://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.17wmf1/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js?view=markup#l211 [21:54:55] That's what I thought too [21:55:01] IT was there in the old version [21:55:08] So I've only reinstated previous handling... [21:56:09] Hack is not so hacky [21:58:01] Fixed on trunk [21:58:21] How the fuck did I not spot that? I tested it >_> [22:00:03] JeroenDeDauw: getMainText == page without namespace? [22:00:13] multichill: yeah [22:00:42] multichill: so I changed it from slightly wrong to more wrong :p [22:00:51]