[00:03:54] http://code.google.com/p/mediawiki4intranet/source/diff?format=unidiff&path=/includes/MimeMagic.php&r=8ba23841e4b9f26056436d3ec60f9b677b5508a6&spec=svn8ba23841e4b9f26056436d3ec60f9b677b5508a6 [00:04:28] http://code.google.com/p/mediawiki4intranet/source/list?name=all [00:05:42] Stuff to upstream? [17:30:13] !status [17:30:13] --elephant-- I don't know anything about "status". [17:30:27] that bot is dumber than codur [21:08:16] Hey Roan [21:08:24] wanna do some deploying? [21:08:45] I was in another channel, sorry [21:08:55] RoanKattouw ^ [21:08:58] Sweet, you're here [21:09:01] Thanks Arthut [21:09:06] pleasure [21:09:28] *RoanKattouw grabs list of revs to deploy and starts merging [21:09:57] As I mentioned in the email, all the WikiLove revs up to the current trunk version are reviewed and good to push out [21:10:24] and then there are also a couple of jQuery UI tweaks in Resources/ [21:10:29] Oh so I can merge to trunk state? [21:10:36] They can be deployed in any order or all together [21:10:45] yes, you can merge to trunk state [21:10:51] in WikiLove/ [21:11:15] Alright [21:11:19] Lemme do the core revs first [21:11:35] not sure about the trunk state of the jQuery UI skin though, so best to do those revs manuallys [21:12:07] Yeah it's only two of them so that's what I'm doing [21:16:22] kaldari: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94947 [21:16:31] Please glance over that as a sanity check [21:16:35] looking [21:17:40] looks good [21:18:23] OK, will push that out then [21:20:01] neilk_: We should check UploadWizard after this and make sure all the buttons still look normal [21:20:24] kaldari: actually, trunk UW has some odd-looking buttons now [21:21:00] kaldari: at least now I know where to look, thanks ;) [21:21:04] kaldari, neilk_: Please check test.wikipedia.org now [21:21:14] It should have the new JUI CSS [21:21:42] neilk_: the changes I'm putting in place are in resources/jquery.ui/themes/vector/jquery.ui.button.css [21:22:29] they are mostly to make our jQuery UI skin formatting closer to the standard skin so that things like icons in buttons work as expected. [21:22:54] looking at test... [21:23:39] WikiLove looks good on test [21:23:46] And UW? [21:23:51] looking at UploadWizard... [21:25:27] well, the UW buttons are extra big now. [21:25:53] we may need to remove some of the UW's custom CSS [21:26:19] as I think it's padding is being compounded with the new way that the skin is adding padding [21:26:42] Yeah, but actually, they started out being super padded like that [21:27:10] The only thing I'm worried about is if the clickable area doesn't match the button (there is some CSS trickery there) [21:27:23] and it looks okay in FF and Cr - trying IE [21:29:52] neilk_:well, I'll leave it up to you if we should push out the CSS changes or not. I can push out the rest of the WikiLove fixes without it, it just won't look quite as nice. [21:29:58] kaldari: I think it's good [21:30:04] kaldari: trying IE8 now [21:32:10] eh, the vm for IE8 seems to have crashed [21:32:24] kaldari: I pronounce it good anyway. I tried IE6. [21:32:34] OK [21:33:02] There is one oddity, the categories buttons look small now. I'll just mark it as a bug. [21:34:22] I can help fix those afterwards [21:34:59] Kaldari -- I'm redoing the category widget in this next release anyway (Monday) [21:35:12] if you want to fix it, go ahead though [21:35:29] yeah, all it takes is deleting a padding override in the UW css [21:36:13] hi devs [21:36:18] I have a question [21:36:25] I have upgraded an apache to 10.04 [21:36:27] for testing [21:36:35] I need a good sample of pages to test [21:36:38] suggestions? [21:36:47] 'pages to test'? [21:37:01] It's not like the HTML output is magically gonna be different between different Ubuntu versions [21:37:07] You just need to test feature completeness [21:37:16] RoanKattouw: I'm going to curl the 10.04 box and a 8.04 box and diff the results [21:37:43] RoanKattouw: ok. I'm open to better test methods :) [21:37:47] suggestion? [21:37:49] You can do that [21:37:59] But don't expect to find subtle differences; you'll find large ones instead [21:38:10] Maybe srv193 can be your upgrade guinea pig? That's the testwiki box [21:38:52] RoanKattouw: but there's only 1 testwiki box, so nothing to compare against... [21:39:17] True [21:39:31] But I don't think you'll find subtle differences. Things will either work or explode [21:40:10] how different is 193 from apaches? [21:40:17] &from the other apaches [21:40:19] ** [21:40:25] man, I can't fucking type [21:40:29] I'm not entirely sure [21:40:37] also, is it fully puppetized? [21:41:06] Hmm I guess you can pick another Apache but you'd have to depool it just in case it breaks somehow [21:41:19] that's what's I've done [21:41:21] 155 [21:41:24] is depooled [21:41:55] Oh, cool [21:42:02] kaldari: What's the status on the WL deployment? [21:42:27] I think we're going to move ahead with all of it [21:42:29] notpeter: Yeah I guess your curl plan sounds sane, but it would be convenient if it were accessible through a web browser somehow. But maybe that's too difficult [21:42:36] Or we just install links on fenari [21:43:01] kaldari: OK so I can push the CSS changes sitewide? [21:43:01] it's installed, but need headers... [21:43:08] ? [21:43:24] like, we'd have to change /etc/hosts [21:43:26] RoanKattouw: yes [21:43:27] for fenari [21:43:31] which I don't really want to do [21:43:52] but, generally, my plan was to do the curl/diff thing [21:43:53] Oh, right, crap [21:43:59] and then put it into the pool [21:44:04] and watch the error logs closely. [21:44:05] Because URLs will refer to en.wikipedia.org [21:44:08] Hmm, that might work [21:44:26] I expect that, if Apache&PHP work at all, any problems will be with external applications we shell out to [21:45:40] The only ones I can think of are ImageMagick (but that's only on the scalers) and diff3 [21:46:08] kaldari: CSS deployed [21:46:10] Now for WikiLove itself [21:47:19] RoanKattouw: ok, cool. I'm going to stick to the plan I had. and yeah, after testing this, I'm probably going to actually go through and do the scalers first, as I've heard that that is more pressing [21:49:03] Alrigth [21:49:23] You'll want to do curl tests for diffs and thumbnails too I guess [21:49:51] <^demon|away> Has wikidiff2 been compiled for Lucid yet? [21:49:59] Good point [21:50:00] <^demon|away> I'm less concerned about diff3. [21:55:45] kaldari: OK the new WikiLove version is live on testwiki, please test [21:55:52] looking... [21:57:52] RoanKattouw: Everything looks good as far as I can tell. Do you know of any way to actually test the rtl functionality on test? [21:58:28] *RoanKattouw changes the content language to Hebrew on test [21:58:47] what's the var? wgContentLang? [21:59:10] $wgLanguageCode [21:59:15] Try now, it should be in Hebrew [22:00:24] it seems to only be partially flipped [22:00:55] even outside of the WL interface [22:01:07] Well many things are still in English [22:01:13] http://test.wikipedia.org/w/index.php?title=Main_Page&action=edit looks good to me [22:01:29] now it's working [22:01:56] everything looks great in rtl [22:01:57] Oh, also your user lang will probably be English [22:02:07] *RoanKattouw lols at his Dutch-in-RTL WL interface [22:02:19] I think I just had to hard refresh [22:02:28] OK [22:02:33] I'll set it back to English [22:02:36] Then push the changes site-wide [22:02:40] everything in lrt and rtl is good, so push it out [22:03:03] before I get too dizzy :) [22:04:49] Sync done [22:04:51] neilk_: 15 PHP Fatal error: Call to a member function getId() on a non-object in /usr/local/apache/common-local/php-1.17/includes/upload/UploadFromStash.php on line 32 [22:05:07] neilk_: 1 PHP Fatal error: Call to undefined method LocalFile::getFileKey() in /usr/local/apache/common-local/php-1.17/includes/api/ApiUpload.php on line 145 [22:09:32] roan: hm. that's not so good. I'll check it out. [22:14:39] RoanKattouw_away: could I get you to look at something? [22:15:10] Reedy: yh? [22:15:27] since RoanKattouw_away is away :P [22:15:34] ? [22:16:07] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=30440 [22:16:21] could you see if something there jumps out at you [22:16:40] They are the exact same for me [22:17:00] you mean browser settings? [22:17:23] <^demon|away> WFM too. [22:17:28] Was it as anon? [22:17:35] they don't say... [22:18:30] wfm, too, I'm just trying to figure out wtf is going on :P [22:19:50] ty Reedy [22:19:55] :) [22:27:17] Reedy: found that email about wikia diff: in my gmail spam :P [22:36:51] That's not the first time