[16:23:16] evenin [16:23:26] I have a patch to help debugging https://bugzilla.wikimedia.org/show_bug.cgi?id=28613 [16:23:32] anybody here to apply it? [16:30:07] you can't commit it yourself? [16:33:52] more as in "deploy it to the cluster" [16:34:40] it would need to be committed first [16:34:58] besides, US staff is celebrating holidays [17:31:00] omg, July 4th [19:55:55] When doing code review, if everything in a rev was eventually reverted except for some comments, should you mark the rev "reverted" or do you need to mark it "resolved" (or something else) since the comments were not reverted? [19:59:12] kaldari: I'd say it depends on how/why it was reverted. ie. "this rev is bad, revert" or "can be done better this way, undoing rev in the process" [19:59:55] It was partially bad, partially redone in a better way [20:00:27] eventually all of it got reverted though, except for some whitespace changes in a comment [20:00:43] I'd say use a random number generator. Whichever you prefer :D