[05:01:56] hi Ryan_Lane [05:02:03] howdy [05:02:29] food is done. back in a bit :) [05:04:34] okay [05:04:52] just wondering what happened to the cldr thing? [15:55:18] anyone here? [15:57:02] mornin' howief [15:57:08] hey there [15:57:16] i just sent you a msg on gchat [15:57:35] are we still on for deployment? [15:57:37] ah yes [15:57:39] afaik [15:57:50] i haven't heard from roan yet [15:57:53] ok [15:58:26] or trevor for that matter [15:58:33] Morning folks [15:58:39] there he is! [15:58:40] speak of the devil [15:58:41] Sorry for being slightly late [15:58:44] heya RoanKattouw [15:58:45] no worries [15:59:57] RoanKattouw: thanks for those last additional fixes [16:00:04] Sure [16:00:14] The thing with the special page class is it's just generally bad practice [16:00:22] Special page classes are for UI/display purposes [16:00:24] deployment of AFT 3? [16:00:37] yes guillom [16:00:38] what would be the best practice way to handle that scenario? [16:00:41] Putting reusable logic in such classes is usually a bad idea [16:00:44] Especially if non-static [16:00:46] copy [16:00:47] ok [16:00:55] howief, do you have a blog announcement ready? [16:01:00] is the latest on prototype? [16:01:01] Well in this case it's just one function [16:01:09] So you just say "meh", make the function static, and live with it [16:01:12] howief: Let me update prototype [16:01:19] guillom: we haven't finalized the blog post [16:01:27] ok, just asking [16:01:30] but i figure we can just use what erik sent to wiki-en [16:01:38] thanks RoanKattouw [16:04:19] Alright, prototype updated [16:05:04] great [16:05:30] *RoanKattouw waves at TrevorParscal [16:05:34] howdy [16:05:41] whattup TrevorParscal [16:05:43] I just merged that $.appear rev you asked for, and updated prototype [16:06:00] cool [16:06:00] so has the dashboard page not been updated? [16:06:00] thanks [16:06:13] i'm still seeing the old copy [16:06:37] http://prototype.wikimedia.org/release-en/ArticleFeedbackTest is working [16:06:59] http://prototype.wikimedia.org/release-en/Special:ArticleFeedback - i see 2 tables... [16:07:21] no colors - i guess the default sort never got... sorted [16:07:56] nor is any of the additional messaging present [16:08:05] would it possible to make the changes prior to deployment? [16:08:47] quick poll [16:09:15] what do people think of the new messaging in the green, which appears upon the first click of a star? [16:09:17] Depends on their magnitude [16:09:25] would that make you click on "submit ratings"? [16:10:34] i'd like RoanKattouw guillom awjr and anyone else on the channel to respond [16:10:48] (since TrevorParscal and i were the ones working on it) [16:11:10] I'll just say that such design decisions should be considered more than -18 minutes before scheduled deployment [16:11:11] howief: i like it, it definitely grabbed my attn [16:11:21] agreed with RoanKattow [16:11:24] *RoanKattouw [16:11:30] RoanKattouw: i wasn't able to see this on prototype until now [16:11:38] hmm [16:11:42] but otherwise, i agree with you [16:11:43] howief: when I used a non-green color, it looked like you did something wrong [16:11:44] Oh, cool [16:11:46] like an error or warning [16:11:50] Yeah that looks useful [16:11:54] TrevorParscal: yes, that was very clever :) [16:11:54] howief, I think it's less ideal than being saved automagically, but it's better than nothing. [16:11:59] And good call on the green, Trevo [16:12:01] r [16:12:08] plus, i tend to not be the best person to ask about these kinds of things since my preferred UI is the terminal... [16:12:12] hehe [16:12:21] I'm with guillom , it's just a patch for bad UX, the fundamental issue isn't fixed [16:12:21] awjr: would it have compelled you to click on "submit"? [16:12:24] And +1 on awjr [16:12:31] howief: yes [16:12:32] ok [16:12:37] let's roll with it then [16:12:44] and i do agree with guillom [16:12:56] this was just a last minute thing we discovered from the UX testing erik did [16:12:57] Oh, crap [16:13:03] (topic is ArticleFeedback?) [16:13:04] I did not look at the Squid stuff from Trevor at all [16:13:18] brion reviewed it a bit [16:13:23] and I responded with a patch [16:14:24] It's incomplete [16:14:36] The URL, both in JS and in PHP, needs smaxage=somenumber added [16:14:42] Otherwise Squid won't cache it at all [16:14:49] RoanKattouw: yes, I know [16:14:57] that's the area I was hoping you could help... [16:15:16] should be trivial [16:15:25] Add &smaxage= an appropriate number to the query strings on both ends [16:15:37] Said number should probably be configurable [16:15:43] what about maxage? [16:15:51] That's for client-side caching [16:15:54] yeah [16:16:00] Shouldn't be set too high [16:16:03] i'm asking, do we need that in the URL too? [16:16:05] We're using on-demand purging here [16:16:05] both right? [16:16:09] yup [16:16:13] Not if you don't want that [16:16:25] For on-demand purging of articles we use maxage=0 and smaxage=25920000 [16:16:30] ok [16:16:38] so, we always ask squid [16:16:51] and squid gets purged when someone rates [16:17:05] Ah, sans one zero [16:17:06] Yes [16:17:34] Can you implement this like right now so we can push it along with the rest? [16:17:44] morning all [16:17:48] yes [16:17:53] should have a patch in 1 min [16:17:55] sup brion [16:18:11] *TrevorParscal is also doing some digital packing so he has enough data to survive his trip [16:18:30] file transfers.... even over fw800 are slow [16:19:57] ugh, eclipse is also slow [16:20:31] it crashed... arg! [16:21:10] *RoanKattouw hands TrevorParscal a vim [16:21:16] hahaha [16:21:16] srsly [16:29:34] RoanKattouw are you discussing getting UploadWizard live ? [16:29:49] No, this is the next version of ArticleFeedback [16:29:52] v3 or v3.5 or whatever [16:29:55] ah [16:30:01] v4 [16:30:04] is UW on the roll [16:30:20] going by the bucket version [16:31:20] RoanKattouw: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87730 [16:31:46] GerardM-: At 9pm our time [16:33:02] RoanKattouw, TrevorParscal: smaxage should = 2592000, not 25920000, correct? [16:33:13] Yes [16:33:19] RoanKattouw Ah, sans one zero [16:33:46] <^demon> I love that we've hit v4 of UW and it's taken !10 years & we don't even have MW 2.0 ;-) [16:34:04] <^demon> ~10 years [16:35:13] Fixed in r87732 [16:35:32] Alright, let's go to test [16:36:36] howief: are we ok to launch the dashboard without the additional messaging? [16:38:47] hmmmm [16:38:52] i'd really rather not [16:39:09] but objectively, it's not a showstopper [16:39:37] sorry for my ignorance, but can the text of a special be edited while in production? [16:39:41] (special page) [16:40:10] i can easily and quickly add in the messaging but i dunno how you want it to look and am not the best person to have handle styling [16:40:25] Can we do that, at least for the "Experimental" bit? [16:40:38] I think a line of text above the title of the first table is good enough [16:40:46] and to answer your question, no, at least not like a regular wiki page [16:40:52] Lies [16:40:54] You can edit it [16:41:05] what?! [16:41:09] At [[MediaWiki:Articlefeedback-blah-blahblah]] [16:41:52] if that's the case, can someone edit post-deployment? [16:42:03] just to reduce the number of moving parts right now [16:42:11] We can also just edit the source and redeploy it [16:42:15] Deploying msg changes is trivial [16:42:38] whatever you think would be easiest [16:43:40] yeah, if you just want a line of text, no big deal [16:43:54] cool [16:44:02] RoanKattouw: im totally not seeing how you edit copy on a special page through the mw ui [16:44:51] You edit the i18n message(s) [16:44:58] ... [16:45:00] well yes [16:45:03] Through the MediaWiki: namespace [16:45:18] maybe i just dont have permissions to do that [16:45:39] You need to be a sysop to edit MediaWiki: pages [16:45:52] ah right [16:46:44] Wow, is it me or is AFT insanely slow on testwiki ? [16:46:55] Takes almost a minute for it to pop up. [16:50:01] Yeah it was slow the first time [16:50:10] Probably because its doing XHR, twice, and it's testwiki [16:50:26] Also, TrevorParscal , we overlooked something [16:50:31] Dashboard ? [16:50:34] There should be no smaxage for logged-in users [16:50:44] That'll just pollute Squid to bits [16:51:30] oh [16:51:30] Dashboard is part of this deployment, right ? [16:51:45] Wait, I *am* an anon and jQuery is doing the anti-cache thing [16:51:48] That's also bad [16:51:52] Krinkle: Yes [16:51:55] >_< [16:51:55] k [16:51:59] But... I guess it's disabled in the config [16:52:02] It's currently disa~^ [16:52:12] howief: i updated the special page to have the copy on it [16:52:16] great [16:52:18] it's live on prototype [16:52:32] Oh, cookie [16:52:33] it's ugly but it's there [16:52:35] looks great [16:52:45] :p [16:52:51] can we add another line break after the message? [16:53:02] RoanKattouw: patch in [16:53:12] you added the description of the averages too -- awesome [16:53:13] hey howief - morning folks, dario here [16:53:20] hey DarTar [16:53:30] hi DarTar [16:53:32] Dude, great minds [16:53:35] I wrote the exact same patch [16:53:37] hi awjr [16:55:06] I don't know if this has already been discussed but there was another comment yesterday regarding backward-compatibility with classic: http://www.mediawiki.org/wiki/Talk:Article_feedback#Broken [16:55:55] yes, i sent a note to trevor and timo about this [16:56:22] i think we should try to suppress the tool for classic if possible [16:56:41] RoanKattouw: are you on the hook for the UW deploy in an hour? [16:57:01] but i'm not sure that should block deployment [16:57:06] Yes, but we can push it back [16:57:08] Neil knows that [16:57:14] k [16:57:24] awjr: is carrie in the office right now? [16:57:31] TrevorParscal: she just walked in [16:57:42] i need you to get something in my desk, and give it to her, to give to me [16:57:48] k [16:58:09] any hints as to what it is? [16:58:22] Weapons. [16:58:25] in the bottom or 2nd to bottom drawer, there will be a box that looks like this http://www.myservice.com/blog/wp-content/uploads/2009/06/Picture-24-300x291.png [16:58:32] awjr, pick something at random [16:59:03] Bah [16:59:06] *RoanKattouw glares at TrevorParscal [16:59:09] cache: userrating is wrong [16:59:15] Should be cache: !userrating [16:59:16] also, a half eaten piece of gum, paperclip and a small box of mint flavored dental floss... that's critical for when I have to create a hang glider and escape the russians [16:59:29] arg! [16:59:38] Committing fix [17:00:31] just beat you [17:00:32] so on IE8 [17:00:36] Dammit [17:00:50] *TrevorParscal is a bug sniper [17:01:04] I submitted a rating, clicked knowledgeable, submitted an email, then created an account. when I went back to the page I rated, my ratings didn't appear [17:01:20] Were you an anon with no prior ratings? [17:01:32] i was previously anon [17:01:33] The logic for "cache or don't cache" was backwards [17:01:42] not sure if i had prior ratings [17:01:46] ok [17:02:19] TrevorParscal: found it, i'll see if i can convince carrie to bring it for ya [17:02:33] howief: You are testing on test.wikipedia.org , right? [17:02:39] yes [17:03:01] thanks man! [17:03:20] without that, I will be visiting an apple store in the netherlands [17:03:33] where you pay with cookies... [17:03:38] precious, delicious cookies [17:03:56] Oooh [17:04:00] I find it works better with colourful money that isn't all green. [17:04:03] And the AFT module doesn't specify a caching mode [17:04:18] So the caching isn't working [17:04:20] *RoanKattouw fixes [17:05:23] TrevorParscal: i believe she's emptying the box and just bringing the contents [17:05:35] Think of the apple box! [17:05:40] heh [17:05:49] is the daily meeting still on for today ? [17:05:51] also, isn't only the eu adapter useful? [17:06:13] Krinkle: i think we're postponing on account of the deployment [17:06:31] awjr: I only need the 2 adapters [17:06:40] actually [17:06:53] the euro plug tips, right? [17:07:03] other query from the AFT talk page, [17:07:12] so far we've been tracking the list of AFT-powered articles via the hidden category, we are not going to display a public list of all articles with AFT enabled from now on, are we? [17:07:28] could you ask her to just bring me the 2 ones that look sorta like this: http://m2.sourcingmap.com/smapimg/en/n/09a/apple-adapter-30360n.jpg [17:07:34] DarTar: No [17:07:51] k [17:09:20] krinkle: we're not planning to do a standup today since deployment is underway :-) [17:09:25] k [17:11:25] TrevorParscal: message relayed [17:14:05] cool beans [17:14:48] OK, I am reasonably convinced Squid caching is working now [17:16:20] huzzah [17:16:35] RoanKattouw: awesome [17:16:58] howief: Any objections to taking what's on test now to production? [17:17:01] howief: are you satisfied with how things look on prototype? [17:17:03] jinx [17:17:25] can we each do a quick run through on some browsers? [17:17:27] i'll do ie8 [17:17:35] Why is #catlinks on top of the page in useskin=standard/classic ? [17:19:49] howie: ok [17:20:43] my daughter is crushed that I'm not brining her with me on the airplane [17:20:45] :( [17:20:51] haha [17:20:58] Well she wants to go on the plane /now/ [17:21:00] TrevorParscal: aaw [17:21:05] looks good on IE8 [17:21:15] *Reedy blinks [17:21:16] chick, modern, monobook, and vector work [17:21:16] If and when you do bring her on a plane some time, you should remind her of this when she gets bored after an hour :) [17:21:23] cologneblue seems to just not show it [17:21:42] TrevorParscal: It's all dependant on #catlinks [17:22:00] FF 3.6 and 4.0 look good on os x [17:22:01] of course - I'm just saying, the ones that I see it working [17:22:09] $( '

' ).articleFeedback( config ).insertBefore( '#catlinks' ); [17:22:17] how about we use mw.util.$content ? [17:22:21] great [17:22:31] i'll check chrome on xp [17:22:32] Hm.. that would put it after catlinks though [17:22:38] can someone check safari on osx? [17:22:48] Krinkle: if you use mw.util.$content it will move it below the catlinks [17:22:52] you should fallback to that [17:22:54] I'm not sure browsers matter related to the positioning/absence of AFT in skins. [17:23:07] use catlinks if you can, otherwise use mw.util.$content [17:23:14] k [17:23:23] are you patching that now? [17:23:30] I need to start getting on my way [17:23:46] have to grab something at a store on my way to the airport [17:24:24] howief: safari looks good [17:24:34] yeah, I'm fixing the fallback now Trevor [17:24:34] awesome [17:24:43] firefox and chrome look good on xp [17:24:56] dashboard page isn't showing though [17:25:14] "Page has been disabled" message [17:25:22] howief: where are you testing? [17:25:26] Hm.. TrevorParscal if ( $( '#catlinks' ).length ) { isn't a reliable way to check it. Since that is present in useskin=standard as well, it's just that in standard #catlinks is on top instead of on the bottom [17:25:27] test.wikipedia.org [17:25:43] try prototype [17:25:50] http://pastebin.com/u4X1nWTX [17:25:53] i dont think code's been updated on test yet [17:25:55] Krinkle: you can special case that skin? [17:26:16] check if #catlinks is at the top somehow? [17:26:40] RoanKattouw: do you have enough of a grasp on how to ramp up AFT on the cluster to do w/o TrevorParscal around? [17:26:44] what's the default sort? [17:26:46] Yes [17:26:49] great [17:26:54] is it average, lowest to highest? [17:27:19] if catlinks directly following subtitle? [17:27:54] howief: i believe so [17:28:03] ok [17:28:15] we'll need to change that soon [17:28:20] but everything else looks good [17:28:33] let's go fowrard [17:28:48] okay, the pasttebin'ed code fixes it for skin=cologneblue (previously: not inserted in DOM due to no #catlinks; now: Appended to mw.util.$content) [17:29:12] What pastebinned code? [17:29:25] http://pastebin.com/u4X1nWTX [17:29:39] Oh. My. God. [17:29:46] The BZ autocomplete thing uses a JSON RPC thing [17:30:00] Apparently it POSTS a JSON object explaining what it wants or something [17:30:38] ok, I am switching to irc on my phone [17:35:03] RoanKattouw: what's the status, are we ready to start pushing things to the clusteR? [17:35:11] I am [17:35:16] Waiting on green light from Howie [17:35:24] howief gave the go-ahead [17:35:29] Oh, right [17:35:32] I missed that [17:35:40] I'm sorry, I'll go right ahead and push [17:36:10] k, lmk if there's anything i can do to help [17:36:32] are we pushing to 100k all at once? [17:36:44] i believe the plan was to slowly ramp up [17:36:47] k [17:37:03] but i dont think the plan was much more detailed that than [17:37:06] er, than that [17:37:12] ok [17:37:13] We are going to ramp up [17:37:20] We've spent the past hour and a half just doing the software change [17:37:33] sweet [17:37:49] if i'm calculating correct, the target is about 2.9%? [17:37:58] I.... don't know? [17:38:03] I guess [17:38:16] 100,000/3,500,000 [17:38:46] Well it's all main namespace pages, not just 'articles' [17:39:03] ? [17:39:08] We can safely exclude redirects [17:39:19] ah [17:39:23] howief: The number of 'articles' in the statistics page counts according to more stringent rules [17:39:32] that's right [17:39:33] good catch [17:39:59] Alright, sync done [17:40:03] New AFT version is live on production [17:40:28] Toolserver query for # of eligible pages still running :) [17:41:17] 3663178 [17:41:21] So that's not far off [17:41:28] k [17:41:33] let's go with 3% then [17:41:34] 2.7% [17:41:37] Yeah [17:41:50] That'll be ~110k, good enough [17:41:54] cool [17:42:51] Alright, so how many articles are we currently on/ [17:43:20] 3k i believe [17:43:24] yeah [17:44:01] 4,203 [17:44:26] Alright, so let's start with... [17:44:39] adding 22k, one-fifth of our target [17:45:07] drum roll. . . . [17:45:29] Or 18k, rather, that's 0.05% [17:45:45] do we have someone from ops here? [17:45:46] neilk_: Good morning. Our UW deployment is gonna have to wait a little while, probably until noon [17:45:59] RoanKattouw: okay [17:46:01] howief: mark is around and talking at the very least [17:46:09] As is Ryan_Lane [17:46:10] k [17:46:16] mark , Ryan_Lane : We're doing that ArticleFeedback ramp-up thing now [17:46:32] ok [17:46:39] i'm in meetings but can drop out if necessary [17:46:44] RoanKattouw: ok [17:47:10] TrevorParscalMob: Does $wgArticleFeedbackLotteryOdds still work? [17:47:16] Or did the way to specify that change too? [17:48:39] Ahm, not 0.05%, 0.5% [17:49:17] Alright, here we go, to 0.5% of all articles [17:50:35] Now live on 0.5% [17:50:40] w00t [17:50:50] nice! [17:50:57] Well [17:50:58] wheee [17:51:00] In 5-10 minutes [17:51:08] As the RL cache timeout runs out [17:51:43] So now we just sit around and wait for a bit while I figure out which articles I just deployed AFT to [17:51:43] RoanKattouw: as a side note, i see the dashabord is not enabled yet? [17:52:04] No idea [17:52:07] Is there a config var for it? [17:52:11]