[11:25:35] Reedy: OHAI I CAN HAZ REVU r86257 PLZ KTHX [11:26:00] Pfft [11:27:10] I was just doing a batch of 1.17wmf1 merges, will deploy that set now [11:58:25] RoanKattouw, looks good [11:58:35] Thanks [12:00:57] I'm sure that guy barely knows what LDAP is [12:14:13] http://ultimategerardm.blogspot.com/2011/04/translatewikinet-is-six-years-of-age.html [14:07:17] hi RobH! [14:07:31] hello [14:07:39] can you give me some rough numbers on the new datacenter? how many boxes will go there? [14:08:35] also, can i run some numbers about the old datacenter past you, and you tell me if they are correct? i'm (forced into) writing a chapter on ops for a book wmde is going to publish about the history of wikipedia... [14:16:17] hi aude [14:16:21] RobH: ? [14:16:29] sorry in an outage [14:16:35] cannot really work on non outage stuff at the moment [14:17:31] oh, sorry. never mind me, then. i'll shoot you an email. [14:18:46] hi Daniel_WMDE [14:19:00] do you know yet if you can come to the hackathon? [14:19:22] 50% sure [14:19:30] i might be able to start my job when i come back [14:19:38] or say i had this thing already planned [14:20:03] Daniel_WMDE: no problem, shoot me over an email and I will get you the info =] [14:20:44] aude: any idea when you will know? [14:20:46] sounds like it would be just me and kolossos working on maps, but if krinkle helps too, that's awesome [14:21:03] Daniel_WMDE: absolutely not later than end of this week [14:21:08] otherwise, i won't come [14:21:20] ok, please tell cornelius as soon as you know [14:21:28] ok, thanks [15:42:30] sumanah, is there any arrangements for this meeting? [15:42:32] Reedy: how are you? [15:42:33] is/are [15:42:35] meh [15:42:36] hospital! car! [15:42:39] Haha, indeed [15:42:47] Reedy: I just emailed Aigerim [15:43:04] Car is ?180+ to fix, and that's with the prices at cost [15:43:09] Could've done without the 4.40am wakeup [15:43:15] But I've got a nice courtesy car this time [15:45:06] well, that's something. [15:46:51] Put some mileage on someone elses car again :P [15:47:12] Reedy: I should have phrased it more strongly when I said "Feel free to contact [her] yourself to set up a call or IRC chat -- you know more about what she needs to fix ... than I do!" [15:47:42] also I should have just given her my phone number [15:47:48] and asked for hers [15:48:41] I'm not in the best of states to be arranging stuff [15:48:54] right [15:49:02] and I don't know where Chad is [15:49:09] He said he'd be about in a couple of hours [15:49:32] Among other things, I'm not allowed pain killers at all for the next 6 to 8 weeks [15:49:33] it's past 11 East Coast time now; do you know when he said he might be back? [15:49:36] oh WOW [15:49:36] This may prove interesting [15:49:58] Reedy, were you in an accident? and was this separate from your car being broken into? [15:50:08] it's a seperate longer standing issue [15:50:15] no accident, thankfully [15:50:17] oh [15:50:36] 6 months of almost constant headaches [15:50:39] wow [15:51:30] Ug, ubuntu has eaten my clocks [15:51:39] Chad said after 11, I'm guessing that's SF time... so it's 9 there [15:51:41] Maybe 2 hours? [15:51:57] blergh. [15:52:40] he's in the SF time zone? [15:52:46] Nah, he's in your time zone [15:52:50] he's in Virginia [15:53:53] *sumanah emails again [15:54:40] thanks Reedy [15:54:45] my sympathies on your troubles [15:55:51] Heh, cheers. Hopefully we get some movement, as good as the NHS is, for other treatment (acupuncture, physio etc), it's a 3 month waiting list, which is oh so useful [15:56:13] :/ [15:56:55] So pay some money and get it started myself [15:58:00] ouch Reedy that sounds furstrating, but good to hear you'll be getting some treatment soon [15:58:04] no diagnosis? [15:58:31] It seems to be a combination of migraine and other headaches [15:58:48] They think the pain killers might be causing more problems, hence the lovely 6-8 week with naff all [15:59:08] At least, they don't think it's anything too serious, which I suppose is some relief [15:59:19] oh good [15:59:26] tentative yay [15:59:36] I wanted an MRI though :P [15:59:46] [16:00:11] Reedy: I'll be surprised if they don't do one [16:00:30] here they do an MRI for *everything* [16:00:56] That's cause it's all insurance and stuff I'd guess [16:01:08] Apparently I won't see the neurologist again.. Just one of the nurses in 3 months or something (~20th July?) [16:01:20] pdhanda, you're biased, obviously. They want to do MRIs for you, because you're nuts :P [16:01:26] :D [16:01:48] Though, I could end up on Anti epilepsy medication, seems quite worrying [16:02:00] :/ [16:02:00] hehe. "hmm you have a sore throat? remove all your jewelry and get into the MRI room." [16:02:19] Reedy: wow [16:02:39] that does seem pretty intense [16:03:24] Indeed [16:03:30] aha! I DO have her number because I have her CV [16:03:59] I'd guess it'd all come down to a similar thing, migraines, epilepsy etc [16:07:00] my friend used to have pretty bad and regular epileptic seizures. He has been a *lot* better since he got on some regular medication, if that makes you feel better [16:07:07] Reedy: I rang the student and she says she'll be getting on IRC in a few minutes [16:07:49] It's just after 6 months, it gets just a bit tiring [16:09:04] i bet [16:09:52] Reedy: here's aigerim_ of the extension management proposal [16:10:14] I've been up 12 and a half hours, and it's only 17.17 here [16:10:35] Ugh [16:10:56] This morning I woke up at 8ish without the alarm clock, I was mighty impressed with myself [16:11:00] But 4:50, geez [16:11:08] I was woken at 4.40 by someone stealing the radio from my car [16:11:12] lol [16:11:13] so had the police out etc [16:11:20] They got away? [16:11:33] Yeah, they'd gone before I'd finished the 999 call [16:11:34] aigerim_: so Chad isn't here yet but maybe you could talk about how you envision narrowing down your project goals [16:12:05] So you're out a radio, that sucks [16:12:15] The radio was free [16:12:23] It's from my brothers last car that was written off [16:12:27] Ha [16:12:28] As his replacement had a better radio [16:12:35] Do you use the car radio at all? I know I don't [16:12:40] I do [16:12:43] It's more the ?180+ it's gonna cost to fix the door etc [16:12:57] aigerim_: And if you're working on any MediaWiki fixes/patches, could you post a link to your work-in-progress? [16:13:28] Oh, right [16:13:29] You insured? [16:13:51] ah, I just got a note from Chad saying he'll be on shortly (I imagine maybe 20 min?) [16:14:20] RoanKattouw, excess is ?500+ [16:14:34] Might've been lower on the radio, but it's not worth the hassle [16:14:39] Didn't smash a window etc at least [16:14:59] sumanah: Sure, let me find my proposal. | About working on bugs - I wasn't able to find something that I could fix, as I am not familiar with MediaWiki now. I spent some time playing with it instead. [16:15:29] If you've got any proof of "progress" working with MW, that'd be cool [16:16:30] also, we can talk about this in #mediawiki if you think it's better, Reedy [16:17:51] aigerim_: here's ^demon (Chad) [16:18:37] ^demon: Hi Chad [16:18:49] <^demon> Hi aigerim [16:20:11] aigerim_: last week, I saw you said "I did talk to Chad and Jeroen. They suggested that I narrow down the project goals while keeping the long-term purpose of it similar to Jeroen's GSoC'10." [16:20:47] <^demon> Right, and that's what I've outlined for this years GSoC. [16:21:24] Yes, I based it on Chad's proposal [16:21:38] aigerim_: so your current deliverables are the ones you aim to deliver by 22 Aug? [16:21:54] Required deliverables [16:21:54] * Tracking of extension releases [16:21:54] * Tracking of MediaWiki core releases [16:21:54] * Checking compatibility of extension releases with MediaWiki core releases [16:21:54] * Displaying this information through special pages, e.g. Special:Extensions, or API [16:21:55] If time permits [16:21:56] * Displaying infoboxes on extension pages that are autopopulated with information about release, etc. [16:22:13] Yes [16:22:45] Sorry, just had police ringing me back [16:23:03] <^demon> Really, the core of this is the database tables for mediawiki.org that will track this info. [16:24:37] Yeah, it seems so. [16:28:41] Sorry I'm a bit slow - I just came back from classes at another college, I need some time to gather my thoughts [16:31:31] aigerim_, Do like ^demon and I do, attend classes, ignore them, and sit on irc ;P [16:33:27] haha :) Classes aren't bad, commuting is. I have to take a bus there [16:33:43] So my main concern now is that there is still so much I should learn about MW. [16:33:58] Reedy, aigerim_, ^demon -- I need to head to lunch myself -- please do discuss, I'll be back in about an hour. My personal concern is that the proposal as submitted to Melange just seemed skimpy on details and it was unclear whether it had incorporated feedback [16:34:22] aigerim_: I've enabled proposal modifications for your proposal in Melange so you can update it even though it's past the Apr 8th deadline [16:34:29] Thank you Sumana [16:35:03] (I may do this for a couple other students where we have similar questions) [16:37:37] My project goal is to create some mechanism of tracking extension information, which as Chad said comes down to creating database tables [16:37:53] I'm guessing you've seen what/how wordpress do it? [16:38:33] You mean how WP tracks release information? [16:39:03] Yeah [16:39:26] Oh, no. I'll look it up now. [16:39:56] That's probably not exactly what we're wanting, but certainly something towards that [16:43:07] <^demon> Sorry, was afk for a moment. Reading backscroll. [16:44:45] <^demon> So, I think we're all on the same page here as far as the project outline. [16:45:21] ^demon, you agree with something like wordpress, yes? [16:45:28] *like how wordpress does it [16:45:37] Yep. I guess what I need to do now is to understand how to do it [16:45:51] Couple of parser functions, and some tables? ;) [16:45:56] <^demon> aigerm: I wouldn't be too concerned about "learning mediawiki." The two main things you'll be working with are the database and special page classes, which there is ample documentation for. [16:45:59] Do you know where I can find something about WP's way of doing it? [16:46:24] I haven't seen how they do it actually [16:46:26] Okay, otherwise it seemed so overwhelming [16:46:36] aigerim_, ignore the parser and it's not so bad ;) [16:46:39] <^demon> Writing a special page extension is very straightforward, and there's lots of examples out there. [16:46:54] I know they use mediawiki for some of the documentation pages.. Not sure for those downloads [16:47:33] <^demon> Ok, IRC is killing my phone battery right now. Any last questions you have of me? [16:47:45] Nope, not at this moment [16:48:18] I'll look at it. Could I contact you if I have questions? [16:48:31] <^demon> Absolutely. [16:48:41] Thanks a lot. [16:48:51] <^demon> My main e-mail address is innocentkiller@gmail.com [16:49:19] Okay, I'll email you if I am stuck [16:49:30] Or catch us on IRC [16:49:36] <^demon> Reedy knows a lot too :) [16:50:01] <^demon> Ok, time to go. Have a great day. [16:50:32] aigerim_, if you're sending stuff back and forth, can you include me on reedy@wikimedia.org? [16:51:21] Sure. I'm not leaving yet, are you going to be here? [16:52:05] I'm about to eat, but I'll leave my laptop on, I'll be back within an hour [16:52:31] Yeah, great. Thanks [17:11:19] RoanKattouw, Krinkle: have you heard anything from TrevorParscal? I'm working from home and tried calling into the conf room but no one seems to be there for our standup [17:11:57] Are you in 2003? [17:12:04] i'm in my kitchen [17:12:09] haha [17:12:25] You have to call ext 2003, not the ext of the conference room (x6654 or similar) [17:12:38] oh? [17:12:40] lemme try that [17:13:12] However Krinkle and I are the only ones in here [17:15:04] RoanKattouw: http://eiximenis.wikimedia.org/ArticleFeedbackV3 [17:15:30] howief: Is Alolita around? She's supposed to be in this AFT scrum with us in -7 minutes [17:15:52] no she's not [17:15:55] but we're still having the scrum [17:16:00] can you dial in x2003? [17:16:08] sorry x2004 [17:16:12] We're all in 2003 already [17:16:16] oh ok [17:16:24] (me, Timo, Arthur) [17:20:12] extensions/EmailCapture/api/ApiEmailCapture.php [17:22:51] howief http://eiximenis.wikimedia.org/ArticleFeedbackV3 [17:22:53] awjr: [17:44:31] RoanKattouw: action=emailcapture, do I need to send something in the 'info' field ? [17:44:46] Nooo idea [17:44:47] (it's not technically required, but does it have a use yet ?) [17:44:49] Ask Trevor [17:45:09] He should be in here in a bit [17:45:11] aigerim_: Reedy: I shall check the log [17:45:51] Krinkle: howdty [17:46:02] : RoanKattouw: action=emailcapture, do I need to send something in the 'info' field ? [17:46:07] TrevorParscal: [17:46:16] RoanKattouw: sorry about the AFT deployment calendar thing - I had just moved my own calendar item rather than the WMF engineering item. i still struggle with google calendar :( [17:46:21] we want to capture all kinds of stuff, its in a google doc [17:46:37] and we want to put it into that field, as encoded JSON probably [17:47:26] http://pastebin.com/a0GUdBzn [17:48:00] Piped list? [17:48:04] You don't need that in JSON :) [17:48:33] TrevorParscal: Hm.. Not sure if that's possible on short term and via client side. IP-address may be tricky for one. [17:48:53] whatever we can't do, fine - it's a wish list [17:49:09] also, this is all being shouved into 1 column [17:49:09] anon token is probably more useful [17:49:16] it's a grab bag of stuff [17:49:22] Or user name for a logged-in user [17:49:24] TrevorParscal: toJSON() isn't in-core yet. [17:49:35] they will never be shown this if they are logged in [17:49:38] That's what the AFT tables actually use for identifying users [17:49:42] we can add it [17:50:17] TrevorParscal: EmailCapture field should be hidden for logged-in users ? [17:50:29] yes [17:50:32] okay [17:50:35] hello [17:50:37] we already have logged in user's emails :) [17:50:57] sure, but how would they say "I want to get emails" [17:51:09] Or are they only interesting to anons ? [17:51:21] yeah, just anons [17:51:23] k [17:51:30] it's supposed to be a way to funnel in newbies [17:51:35] the -1's [17:52:17] this could also be encded as csv [17:52:29] csv is the final format anyways [17:52:52] and it would be simpler than adding JSON encode to the client [17:53:18] then we can just cat it on the end :) [17:54:13] Krinkle: https://docs.google.com/document/d/1bGkzM6375sFXBYqwp-x-veGvWsvV-i7cJUUmE6zMFIE/edit?hl=en&authkey=CJbfpP0C# [17:54:25] that's the document i'm reading from [17:56:11] So, leave info field empty for prototype tonight ? [17:57:08] you won't have time to do this? [17:57:13] I could do it [17:57:42] I wont have time to finish that in 1.5hour. Need to fix other things first (right now it's a front-end dummy) [17:57:52] understood [17:58:06] it's in similar posititino though, commit conflicts ahead. [17:58:20] ok [17:58:37] why are we pushing to prototype tonight if we're that far from being done? [18:00:12] Because we thought we were closer to being done? [18:00:38] howief: ? [18:01:15] Krinkle: I will do the additional info gathering right now [18:01:28] we're not as close to being done as we thought? [18:02:17] I'm not sure we need to push anything back yet, but I'm going to be writing the info collection stuff today because timo is in bed in 1.5 hours [18:02:33] and he's still working on making the front end talk to the back end [18:02:39] Well, I didn't have as much info now as I had two days I ago. I didn't know EmailCapture was a seperate extension or that it was loggin-on only and needed to be hidden after once filled in. [18:03:11] eh. the other way around. I was missing some info monday regarding emailcapture. [18:03:18] Obviously I can help with this stuff, just wanted to make sure howief knew where we were at [18:03:40] anway, going back on it now. I'll see how far I can get. It maybe less then I think. It's just connecting the right dots. [18:03:52] right on [18:03:56] thanks guys [18:04:09] just go for it, I will pick up where you leave off (to avoid complex diffs) [18:04:33] thx [18:32:09] TrevorParscal: [18:32:11] var a = $.post( wgScriptPath + '/api.php', {format:'json', action:'emailcapture', 'email':'t@t.t'}, function(a){ console.log(a) }); [18:32:21] error: Object * code: "internal_api_error_DBQueryError" info: "Database query error" [18:32:54] trying on my host [18:33:08] It's not a blocker for me to continue, just letting you know. [18:33:50] success for me [18:34:01] Take a day off, for SCIENCE [18:34:27] did you run update since you enabled emailcapture? [18:34:27] ah, I guess I didn't run update.php after installing that additional extension [18:34:31] ha ha [18:35:40] Adding user_email key to table user... A database query syntax error has occurred. The last attempted database query was: "ALTER TABLE `mw_user` ADD INDEX ( `user_email`, `user_name` ) " from within function "DatabaseBase::sourceFile( /svn/mediawiki/trunk/phase3/maintenance/archives/patch-user_email_index.sql )". [18:35:41] Database returned error "1170: BLOB/TEXT column 'user_email' used in key specification without a key length (127.0.0.1)" [18:35:57] That's core, not an extension [18:35:59] rest went okay [18:36:05] yeah [18:36:24] Who added that one? [18:36:30] no idea [18:36:40] somewhere in the last 48 hours [18:38:30] *Reedy blames Happy-Melon [18:38:35] He seems to be at fault most of the time ;) [18:38:58] Aha [18:38:59] It is [18:39:00] http://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fphase3%2Fmaintenance%2Farchives%2Fpatch-user_email_index.sql&title=Special%3ACode%2FMediaWiki%2Fpath [18:40:00] Bleh, natty has broken my VPN. I'm still not sure what I think of it [18:40:39] TrevorParscal: Does EmailCapture does it's stuff automatically on update.php ? [18:40:42] still getting the same error [18:40:57] Or not [18:41:22] it should [18:41:35] there's a schema update hook and SQL patch [18:42:11] Krinkle: Comment out all lines in patch-user_email_index.sql temporarily [18:42:26] right, it's aborting the rest of update [18:43:18] perfect [18:44:04] {"emailcapture":{"result":"Success"}} [18:44:05] yay [18:45:38] whee [18:47:18] Alright, emailcapture is going to be domainwide, right TrevorParscal ? [18:47:18] I've fixme'd the revision adding that index [18:47:28] atleast wiki wide [18:48:16] Krinkle: yeah [18:48:28] we are using it on a per-wiki basis [18:48:54] we cookie would be wgScriptPath [18:49:03] instead of current path or '/' [18:49:29] using "/" will work great [18:49:58] TrevorParscal: Sure ? [18:50:19] Well it'll be a bit weird on secure [18:50:22] what about multi-wiki domains (translatewiki/w/ and /sandwiki, secure.wikimedia) [18:50:39] wgScriptPath doesn't work, because /w and /wiki are different paths [18:50:44] secure is being used by an anon now? [18:50:47] arg. [18:51:22] you should use the same path the other cookies are using, it will have the same downfalls they have [18:51:52] TrevorParscal: We had a bug with the TOC-toggle [18:51:59] Krinkle: sandwiki uses different wiki_id [18:52:16] ie. when using purge it would not be detected (different path), or if done from a subpage [18:52:26] anyway, using '/' for now [18:53:36] Nikerabbit: yes, but non-core cookies dont use that (yet) [18:53:52] wiki-id? [18:54:52] yes [18:56:02] Ideally we'd just use the dbname as cookie prefix [18:58:32] okay, email is properly saved and error handling is good. [18:58:46] checking code for TODO/FIXME and going to commit [19:01:42] The ClickTracking-requests I see return HTML code, although the return is ignored for the client it looks odd (perhaps it needs format=json) [19:01:46] saves bandwidth too [19:02:33] action:clicktracking & eventid:ext.articleFeedback@2-pitch-edit-show & MediaWiki API Result token:cMHt33a0PNwPpFu5DYC1XU0uiDfj6esSe [19:34:29] Krinkle, RoanKattouw, TrevorParscal: how are we looking for 1pm push to prototype? [19:34:54] 1pm today? [19:35:05] yes [19:35:06] Yeah like 15 mins from now [19:35:11] right [19:35:16] It's no biggie if we slip, lots of people can push to prototype [19:35:18] well, looks like Krinkle checked a few things in [19:35:22] Including Trevor and Priyanka [19:35:25] In 5minutes I'll be to a piont where I would say "it should work" [19:35:33] heh cool [19:35:48] I'm going to be adding some of the extras, like additional info gathering and bucketing [19:35:53] which can happen later [19:36:13] TrevorParscal: perhaps those should not be added for tmrw's deploy [19:36:32] depends on what howie wants [19:36:40] we need to have the extra info gathering for sure [19:36:49] because it's part of the data we are giving to the community dept. [19:36:52] oh, by 'extras' i thougt you meant nice-to-haves [19:36:53] Okay, I'm at that point now. [19:36:57] it's not a complex change [19:37:00] I'll brb for a short foodbreak. [19:37:04] k [19:37:13] the bucketing is a nice to have [19:37:17] ok, well then we should wait to push to prototype til you're done since that's what howie et al will be testing [19:37:20] it's a way to compare approaches [19:37:54] TrevorParscal: do you have an eta for the must-haves? [19:41:00] oh, today, couple hours [19:41:21] that is, the stuff I'm working on [19:41:33] the info capture and bucketing [19:41:48] we can do browser testing prior to that stuff [19:42:07] but it should be done soon [19:42:22] ok so you're saying we should deploy to prototype w/o the stuff you're working on? [19:45:12] seems reasonable to me [19:46:07] k [19:50:54] *Krinkle back [19:51:21] *Nikerabbit front [19:54:52] RoanKattouw: shall we push to prototype? [20:02:41] RoanKattouw: ^^ [20:10:46] TrevorParscal, Krinkle: know where RoanKattouw is? i'd push the AFT updates to prototype myself but i dont know how yet :( [20:10:59] Dunno where Roan is [20:11:00] I'm back, sorry [20:11:09] hi roan [20:11:12] no worries [20:11:34] On prototype, /srv/org/wikimedia/prototype/wikis/rc-en/extensions/ArticleFeedback is on trunk [20:11:36] Just svn up it [20:11:50] I guess you'll also need to install EmailCapture, that'll be more involved [20:12:09] TrevorParscal, Krinkle: Does a clean separation between EC and AF exist currently or does one just assume the other is there? [20:12:14] oh i didnt realize deploying to prototype was so complicated :p [20:12:40] Not very [20:13:00] Adding new extensions is always slightly more involved, but thinking about it won't be any trouble [20:13:18] Just checkout EmailCapture from trunk in /srv/org/wikimedia/prototype/wikis/rc-en/extensions/EmailCapture [20:13:54] Then add a require_once() for it in /srv/org/wikimedia/prototype/wikis/rccommon/PrototypeSettings.php [20:14:02] hmm i do not have permissions [20:14:04] RoanKattouw: Well, the resource hook in ArticleFeedback lists it as a module dependancy. [20:14:08] awjr: sudo [20:14:16] Krinkle: OK [20:14:16] RoanKattouw: no sudo :( [20:14:16] front-end silently skips that module entirely with a line to console if it a dependancy doesn't exist. [20:14:21] Bah [20:14:24] awjr: Let me give you sudo [20:14:28] RoanKattouw: That is, for jquery.clickTracking [20:14:32] \0/ [20:14:47] sorry, lemme check how it assumes EC [20:14:56] awjr: What's your username [20:15:00] awjrichards [20:15:14] RoanKattouw: ^ [20:15:28] Alright [20:15:30] You now have sudo [20:15:41] yay ty [20:16:08] RoanKattouw: There's no mention of EmailCapture in ArticleFeedback that I could find with grep [20:16:22] OK [20:16:25] Krinkle, TrevorParscal: is head what we want for AFT on prototype or is there a specific rev? [20:16:32] So how does its UI work then? [20:16:50] RoanKattouw: Untill a few hours ago AFT didn't need EmailCapture [20:16:56] Does it just submit to api.php?action=emailcapture ? I guess that'd work if it handles the error for unknown module semi-gracefully [20:17:03] I just introduced the firs and only reference to ir with that api call [20:17:12] first* [20:17:13] it* [20:17:14] OK that'll be fine then [20:17:36] I check "if ('error' in obj )" [20:17:41] that should work [20:18:26] Yes [20:18:41] http://prototype.wikimedia.org/rc-en/api.php?action=whee&format=json [20:18:43] indeed [20:18:43] So per Arthur's question do you want to update to the latest rev (HEAD) or to a specific one? [20:18:43] meh looks like commits up to r68533 are good [20:19:01] er r86533 [20:19:06] proto runs 1.17wmf1 ? [20:19:14] I'm not sure mw.user.anonymous() is in 1.17 [20:19:28] Lemme see [20:19:39] Yes it is [20:19:43] it's in there [20:19:45] >>> mw.user.anonymous() [20:19:46] false [20:19:48] On mediawikiwiki [20:20:01] if there's anything else we'll catch the js problems in proto. [20:20:05] just svn up'd to r86533 for AFT on prototype [20:21:06] Which configuration does AFT have on proto ? [20:21:28] Error: Unknown dependency: jquery.clickTracking [20:21:30] http://prototype.wikimedia.org/release-en/AricleFeedbackTest [20:21:48] Ugh [20:21:53] Gotta enable ClickTracking too [20:21:55] I'm on it [20:22:19] require_once( "$IP2/extensions/PrefSwitch/PrefSwitch.php" ); require_once( "$IP2/extensions/EmailCapture/EmailCapture.php" ); require_once( "$IP2/extensions/ClickTracking/ClickTracking.php" ); require_once( "$IP2/extensions/ArticleFeedback/ArticleFeedback.php" ); $wgArticleFeedbackLotteryOdds = ..; [20:22:19] $wgArticleFeedbackCategories = ..; [20:22:31] that's the minimal stuff it needs [20:22:51] SimpleSurvey too (in the extensions directory) but PrefSwitch loads that automatically [20:25:23] Enabled ClickTracking [20:26:40] RoanKattouw: i co'd EmailCapture - where does it need to be enabled? [20:27:05] oh i see this is like the cluster setup with CommonSettings etc [20:27:07] RoanKattouw Then add a require_once() for it in /srv/org/wikimedia/prototype/wikis/rccommon/PrototypeSettings.php [20:27:11] Not entirely [20:28:18] indeed [20:28:26] ok, EmailCapture enabled on prototype [20:28:50] sweet! [20:30:33] ( ! ) Notice: Undefined variable: UsabilityInitiative in /srv/org/wikimedia/prototype/wikis/rccommon/PrototypeSettings.php on line 88 ...... [20:30:47] wow what's this wall or warm coloured errors. [20:30:47] Hmph [20:31:14] oh i see what it is [20:31:37] Try now [20:31:52] w00t [20:32:11] yay [20:34:09] awesome [20:34:10] Krinkle: It's called xdebug [20:34:39] awjr: Alright so who of us is gonna review the new AFT code? : [20:34:41] * :_ [20:34:43] * :) [20:34:46] *RoanKattouw can't type anymore [20:34:50] This is a sign, I should go to sleep [20:35:55] lol i'm happy to do it so you can get some sleep [20:36:05] Well, I'd like to get more active in codereview in the near future, but I can't review my own stuff :D [20:36:22] i suppose i should wait til trevor's done? [20:36:45] What's he doing ? [20:36:56] adding some bells and whistles [20:37:09] awjr: Doesn't really matter ,you can do it while I sleep (later this afternoon) or I can do it while you sleep (my morning) [20:37:27] TrevorParscal and Krinkle should probably also cross-review their JS stuff [20:38:01] are you guys seeing emails on the backend? [20:38:03] RoanKattouw: if you wouldn't mind doing it while i sleep, it would be appreciated - i'm on the hook for another project that i need to finish by eod [20:38:13] OK that's fine [20:38:14] but if you're swamped too i can fit it in [20:38:25] I'm not, really [20:38:30] ok thanks :) [20:46:57] can someone check the db to see if email addresses are coming through? [20:47:08] Will do [21:25:48] so a few questions [21:26:06] is there an engineering call today? in 27 min? [21:26:10] i guess this would be for TrevorParscal [21:28:39] <^demon> sumanah: On mumble :) [21:28:57] ok [21:29:32] <^demon> Just wait until we rotate the times again and we get the nice 1 or 2am engineering call ;-) [21:45:27] RoanKattouw: did you have the chance to check if email addresses are showing up in the db on prototype? [21:53:28] He's zzz [21:53:48] heh yeah i figured [21:54:12] howief: dunno if Roan had the chance to check emails in the db before falling asleep [21:54:22] ok [21:54:25] i'm in the middle of something right now but i can look in a bit [21:54:29] ok great [21:54:39] we should verify before tomorrow morning [21:54:47] also can someone look into the windows test cases? [21:54:55] I don't have vmware set up on my mac [21:55:57] maybe Krinkle or TrevorParscal ^? [21:56:08] i have no windows :( [21:56:13] actually, i have no windows :) [21:56:23] howief: I just read your mail, when did you last update your svn ? [21:56:54] The helpimprove-email field is being hidden after submission, so when you go back to rating it should be gone. [21:57:06] In addition, it sets a cookie, so on refresh/reload it will stay hidden [21:57:15] Krinkle: i believe he's testing on prototype [21:57:19] howdy [21:57:23] Krinkle: you still up? [21:57:29] i'm testing on http://prototype.wikimedia.org/release-en/AricleFeedbackTest [21:57:55] TrevorParscal: Yeah, waiting for something to finish on TV. [21:57:59] hexmode: hi [21:58:07] right on [21:58:17] cool documentary on Sweden politics. [21:58:48] that's a combination of words i wouldn't normally expect to see [21:58:54] in the mean time checkout some old revs in AFT. [21:59:13] hah [21:59:17] :p [22:01:58] also, are we still planning to have an email CTA (in addition to the field in the tool)? [22:02:41] as far as I know, it's just not implemented yet [22:03:14] k [22:03:25] the release schedule seems a little too aggressive given the pace of progress [22:03:42] but, i guess that depends on what needs to be released when [22:04:07] +1 [22:04:43] that testing matrix is going to take a bit of time to fill, and when things are encountered, where's the time built in to deal with them? [22:05:05] howief: where's the release schedule, other than "as much as possible as fast as possible" :) [22:05:28] i think it's in the google doc [22:05:31] let me see if i can find it [22:05:34] lookin [22:05:51] https://docs.google.com/document/d/1aAjm374ZKPLG5aG_c9POP6oLnWrz8N5QWNF5XLVCo9E/edit?hl=en&authkey=CNGb4NQP&pli=1# [22:06:49] the important thing is that we wrap this up by the time people leave for berlin [22:07:00] k [22:07:01] if we need to cut features, let's talk about that [22:07:18] e.g., i'm happy to cut the email CTA [22:07:18] i'm sure we can do all this and then some before then [22:07:31] don't forget there's the dashboard stuff [22:07:39] ... grrr [22:07:44] yes, looking at schedule [22:07:47] I'm going to try to keep that as simple as possible [22:08:24] i think the features being deployed to production tomorrow are going to be less than you were hoping [22:08:37] what do you think we'll have for tomorrow? [22:09:10] we don't *have* to deploy tomorrow, but if we don't, that's just more in the hopper for next week's deployment [22:10:13] yeah [22:16:19] nn [22:24:05] TrevorParscal: do you think we should still go foward with deploying tomorrow? [22:24:40] I'm trying to figure out what will be the state of the software tomorrow [22:24:46] k [22:24:56] and it sort of depends on what time of day we deploy [22:25:03] we're scheduled for 7:30am [22:25:08] that's a mistake [22:25:33] awjr: is there are reason why the planned deployment is scheduled so early? [22:25:38] we should deploy later in the day than that [22:25:54] it was the only time Roan and I both had avaialble [22:25:58] ah [22:26:07] ok - well that makes sense... [22:26:08] i wouldn't normally do that to myself [22:26:24] when does QA take place? [22:26:30] while we sleep? [22:26:43] well [22:26:54] i think we're doing qa now :) [22:27:09] which is kind of frightening [22:27:37] well, I'm still coding things that are in the spec [22:27:46] I'm not sure who's doing the QA right now [22:27:50] what specific things are you working on? [22:28:01] (I guess I'm the one identifying bugs) [22:28:04] info collection and bucketing [22:28:17] how far are you? [22:28:23] I'm wondering if it makes sense to pivot [22:28:31] and work on making the core set of features solid [22:28:34] nearly done with bucketing, about to start on info collection [22:28:37] ok [22:28:51] sorry, when you say info collection, what do you mean? [22:30:53] all that extra info you want to collect along with the email address [22:31:58] can you chat for a few minutes on the phone? [22:32:21] this might be easier to figure out by talking [22:33:02] sure, give me a sec [22:33:07] k [22:33:18] ping me when you're ready [23:19:51] TrevorParscal: you there? [23:19:57] sorry - yeah... [23:20:05] I'm just trying to write software! :) [23:20:07] no worries [23:20:08] yeah [23:20:15] lemme know what you can chat [23:20:54] if it's gonna be a while, i'm gonna reboot and run some test cases in windows [23:21:22] yeah, give me a few [23:21:27] i'm almost done with something [23:21:29] k