[00:33:23] anyone around? [00:33:38] have a javascript thingy I'd like to try out with someone [00:38:55] ? [00:39:38] https://hackpad.com/5hKs [00:39:48] a FOAF made an etherpad clone for FB accts [00:39:54] was interested in talking to us re: RTE. [00:40:02] But, I don't think there's a lot of there there. [00:40:06] after a few mins of testing. [00:40:46] are you able to join the pad? [00:41:17] requesting access... [00:41:57] interesting, it pops up in my screen [00:42:44] You're in, according to my screen, can you type stuff? [00:44:18] eh, fuck this, it's contenteditable [00:44:28] doom doom doom [00:48:51] thanks reedy [00:49:53] doooooooooom [00:58:29] neilk_, see the emails it sent out? [00:58:35] yes [00:58:43] sorry if I'm spamming you with them [00:58:49] heh, no worries [01:01:04] closing the windows now [12:16:57] hexmode: I am on the East Coast, like you. Remind me, when is the triage meeting? [12:38:02] Reedy: can you remind me when the triage meeting is? Like, how long from now? [12:38:43] sumanah, 10 hours, 15 minutes [12:39:43] Reedy: really? Not, say, 6hrs 15 min? ok [12:39:54] It's listed as being Midnight my time [12:39:58] It's 13.46 currently [12:41:23] ok, thanks [16:45:56] Reedy: [16:46:00] Morning [16:46:07] Thanks for the review! [16:46:26] um, so the 1.17 back compat thing - could you elaborate? [16:46:33] I can see what you mean about the updater [16:46:50] + if ( !isset( $params['email'] ) ) { [16:46:50] + $this->dieUsageMsg( array( 'missingparam', 'email' ) ); [16:47:09] Actually, I didn't read it all [16:47:11] + 'email' => array( [16:47:12] + ApiBase::PARAM_REQUIRED => true, [16:47:30] So the top part of the "if ( !isset( $params['email'] ) ) {", won't ever be reached [16:47:30] ah [16:47:36] makes sense! [16:47:38] if it's not set, the API will have already died [16:47:47] ok [16:48:01] so I should leave the definition of the error text though? [16:48:48] in the parent::getPossibleErrors [16:48:59] Nope, API adds that in too [16:49:04] ok [16:49:06] or it should, from memory :) [16:49:06] Capturing e-mails? [16:49:10] SPAM [16:49:11] *briom is curious what this is for :) [16:51:54] Reedy: should I also do away with the back compat in the schema updater? [16:52:00] it's a little annoying to have around [16:52:09] as long as I'm targeting 1.17+ [16:52:16] Yeah, I would [16:53:40] Hi sumanah, have you reviewed my GSoC updated profile? [16:54:10] actually, now that i look at my schema updater, it doesn't make any sense... fixing now [16:54:27] heh [16:58:42] Hi jorm [17:13:22] akshayagarwal: sorry, on the phone, will respond as soon as I can [17:16:38] ok sumanah [18:11:54] Reedy: do you know how to do a database update query and get the number of affective rows [18:12:09] *affected [18:12:24] apparently it returns boolean, even when it does nothing [18:12:45] db->affectedRows() ? [18:12:49] That ^ [18:13:05] return (bool)$this->query( $sql, $fname ); [18:13:17] I think true means it executed [18:13:23] ah [18:13:23] ok [18:13:57] affectedRows() works for update/delete/insert. [18:14:27] i always forget that one [18:54:47] does anyone recall how to change the title of a special page to be something other than it's name in the URL? [18:55:06] display title? [18:55:29] yeah, i guess, like what ends up in the heading [18:55:49] I know how to use aliases... but that affects the URL as well [18:55:59] i just want to tweak the title [18:56:06] *Reedy shrugs :P [18:56:16] Email Capture is a little aggressive to a user [18:56:52] Email stealing? :P [18:56:59] it's descriptive to a developer, and it's not a big deal in the url, but H1 text saying "Email Capture" may as well say "I CAN HAZ YOUR PERZONAL DETAYLS!" [18:57:04] ha ha [19:37:18] That was a long time [19:37:18] Hi [19:41:27] hexmode: BugTriage in 15 minutes ? Or 1 hour after that ? [19:41:54] BugTriage is in about 3 hours [19:41:57] Krinkle: ^ [19:42:03] Krinkle: it switches, every other week [19:42:28] Ah, I thought both every week. [19:42:30] I see [19:42:38] Makes more sense :) [19:42:43] to have it switching [19:43:42] sumanah: I corrected http://eiximenis.wikimedia.org/BugTriage, is the top part correct now / [19:43:43] ? [19:44:10] *sumanah looks [19:45:09] Krinkle: I think so. hexmode knows all the permutations. [19:45:54] *hexmode checks [19:46:36] Evidently I've made triage as hard to keep track of as Bin Laden. [19:47:13] Hey as long as you don't run triage like Bin Laden [19:48:23] Where In Time Is Triage Sandiego [20:06:39] sumanah, awjr, ping. I think 'mentors' have to be paired up with 'students' by today on melange (not sure). Thought i'll remind you :) [20:06:40] ? [20:06:55] Reedy: can you give me a cite on that? [20:07:08] It seemed short to me [20:07:11] It's just from #mediawiki [20:07:11] http://www.google-melange.com/gsoc/events/google/gsoc2011 [20:07:13] *sumanah looks at http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/timeline [20:07:52] Reedy: April 22nd, "All mentors must be signed up and all student proposals matched with a mentor - 07:00 UTC" [20:08:51] hrh [20:08:54] *heh [20:08:58] I was getting scared for a bit [20:09:09] sumanah, on that note though, when are we having a meeting to discuss projects etc? :) [20:09:20] Reedy: I am setting that up today of course [20:09:27] not that the meeting will be today [20:10:07] heh [20:10:09] I've had meetings/phonecalls all day [20:10:14] 1 meeting at midnight is enough for me ;) [20:10:55] heh [20:12:23] Reedy: remind me of your working hours over in the UK so I can attempt to make the meeting time not suck for you? [20:13:40] Over the next 3 weeks I'm at home most of the day [20:14:16] I'd rather not have a meeting starting later than 4pm pacifit time, as that's midnight... [20:14:22] got it. [20:14:29] pacific, even [20:14:42] Saying that, I am usually about most of the west coast working day anyway [20:14:46] OK [20:14:48] thanks [20:18:12] Is Ariel signed up as a mentor? [20:19:56] lemme see [20:20:13] As that's +2 on me [20:20:21] But similarily, keeps antisocial hours anyway :P [20:20:45] Ariel is not, and I think is not interested in mentoring unless there are data dumps proposals [20:20:59] ok [21:12:01] hi RoanKattouw_away [21:12:24] Ohai [21:21:22] TrevorParscal: Did you mean to ask me something? [22:17:10] back in 30 min... [22:18:49] hey TrevorParscal [22:19:00] how's it going? [22:19:12] good [22:19:13] you? [22:19:50] i'm ok - I wfh today cause Aurora has the flu, wanted to be safe and not get other people sick at work [22:19:56] so far though, only she has it [22:20:17] poor aurora [22:20:25] yeah it's no fun [22:20:34] hope she doesn't get you sick [22:20:50] yeah, Im just playing it safe [22:20:54] good idea [22:20:54] neilk_, did you say TitleBlacklist worked locally? [22:20:55] lots of sanitizing going on here [22:20:58] haha [22:21:07] Reedy: seems to [22:21:20] Doesn't for me atm :/ [22:21:26] Reedy: argh [22:21:28] so i just sent zack an email about the stuff we talked about last week [22:21:30] ffs [22:21:39] Reedy: how are you testing it [22:21:53] uploading an image called DSC90241.jpg as a non sysop user [22:21:56] Reedy: with Commonist or just plain old Special:Upload [22:22:02] plain old upload [22:22:05] hm [22:22:13] I guess you are testing on Linux? [22:22:17] howief: ok [22:22:18] server is, yeah [22:22:22] not that it should matter, but that's the obvious distinction [22:23:23] anything else you need from me? [22:29:07] that shoud be good, I will poke you tomorrow if I need something else [22:29:28] I have the email backend done today, so i'm going to implement the UI tomorrow [22:29:40] Reedy: now I can't get it to work either. At least this is consistent [22:29:46] lol [22:29:59] I swear I was getting "senselessfilename" errors on Friday [22:30:16] if ( isset( $this->mParams['reupload'] ) && $action == 'upload' ) { [22:30:21] That doesn't seem to make sense [22:30:39] hmm, it reckons I'm trying to edit [22:30:42] stupid thing [22:31:27] if( !isset( $this->mParams['noedit'] ) && $action == 'edit' ) { [22:31:27] return false; [22:31:28] } [22:31:31] I guess mines kicking out on that [22:32:36] yeah, it is [22:32:44] why does it think an upload is an edit? :/ [22:38:11] neilk_, string 'edit' (length=4) [22:38:20] Mine seems to think all uploads are edits for some daft reason... [22:38:47] well [22:39:08] If i comment out that rule, I get [22:39:11] Which is right [22:40:33] yeah, I can't find any case where an upload is really an edit [22:40:39] except, reupload? [22:41:15] I suppose, to some extent, creating the page is an edit [22:41:25] Reedy: no [22:41:31] it's an upload, with wikitext attached [22:41:38] at least as far as the API is concerned. [22:41:48] We're not using the API [22:41:48] 0 => &string 'edit' (length=4) [22:41:53] Special:Upload creates the upload in other ways, I know [22:43:30] $permErrors = $nt->getUserPermissionsErrors( 'edit', $user ); [22:43:54] That's the only place I can see 'edit' coming from [22:45:26] Why is it doing !isset noedit && action == 'edit' [22:45:36] well, that mParams is supposed to be like the lines in MediaWiki:TitleBlacklist right? [22:45:48] it is yeah [22:45:49] and all the lines about uploads start with "reupload" for whatever weird reason [22:46:03] so I'm not sure why you are looking at the previous clause? [22:46:14] cause that's where mine is escaping through [22:46:23] does not compute. [22:46:24] and getting the false negative [22:46:34] unless, for some reason we are now passing edit && noedit. [22:46:34] *hexmode is set to triage some parser bugs... testing my mike [22:46:41] File:DSC.[\d\s]+\.JPG [22:46:48] *sumanah will phone in soon [22:46:52] so, when we hit [22:46:56] if( !isset( $this->mParams['noedit'] ) && $action == 'edit' ) { [22:47:03] noedit is not set, but the action is edit [22:47:08] and it returns false, as non match [22:47:36] if i comment out that if block, it seems to work "as expected" [22:48:03] so why is action == edit?! [22:48:08] I'm not sure [22:48:14] it's seemingly been like that a while [22:48:46] ok so that comes from isBlacklisted() [22:48:52] which defaults to action=edit [22:48:57] if action is missing [22:49:14] It's been the same since 28362 [22:49:26] ah, yeah [22:49:29] but perhaps someone upstream isn't passing along action [22:49:58] userCannot [22:50:04] hrm... tim is still away :( [22:51:06] neilk_, it's seemingly edit when it's come in from the hook [22:51:18] yeah, I'm like a step behind you :) [22:51:23] $permErrors = $nt->getUserPermissionsErrors( 'edit', $user ); [22:51:55] it does edit, upload and createpage [22:53:13] hang on.. [22:53:31] neilk_, i think that's a non issue [22:53:58] yeah? [22:54:05] bug triage meeting now! [22:54:06] Oh.. Not quite [22:54:15] don't get the error out [22:54:16] Reedy, neilk_, robla, et al. [22:54:21] doesn't help when we call a function 3 times [22:54:36] Reedy: ttyl after triage [22:56:56] robla: where'd ya go? [22:57:15] alolita, brion, everybody -- is R1 having trouble connecting or something? [22:57:39] oh my is that now? [22:57:42] be over in a sec [22:58:02] *hexmode starts kicking butt [23:00:18] sorry for being late....I'm on the call now [23:00:54] http://etherpad.wikimedia.org/BugTriage [23:15:17] <^demon> Grrr. [23:24:43] if ( isset( $this->mParams['reupload'] ) && $action == 'upload' ) { [23:24:58] neilk_, with conditional dying, for the rule that stops DSC123456 [23:25:09] It's falling through there, when it's not actually a reupload [23:25:45] Do I just not understand what titleblacklist is for? [23:25:52] No, you're write [23:25:54] It seems broken [23:25:59] But I can't work out for the life in me, why it is [23:26:12] why should we only care about reuploads, and isn't it the other way around, that reuploads should be protected & blacklist applied to uploads? [23:26:23] i.e. we grandfather in old stuff [23:26:26] That's what I'm thinking [23:26:48] If it's a reupload, we're gonna allow newer versions of a bad title [23:26:50] that's kind of what I thought reading it but I thought I must be misunderstanding it. [23:27:09] I can't work out why it's broken again though [23:29:18] is there any way to turn off the wikitext formatting on bugzilla? [23:29:21] it seems really broken [23:29:29] I don't know what this is about: https://bugzilla.wikimedia.org/show_bug.cgi?id=468 [23:29:30] So Patrick Reilly is the mobile site rewrite guy? [23:29:32] tomaszf: ^ [23:29:32] I think there's a bug logged against it [23:29:53] against bugzilla? [23:30:08] or against upload? [23:30:15] There's numerous seemingly regressions in BZ4 [23:30:30] neilk_: The title blacklist allows reuploads in order to fix the images, presumably. It makes sense to block new uploads. [23:30:37] Fix --> update. [23:30:38] Yes, we know that :P [23:30:49] I assume the wikilinking is some patch that we did [23:30:59] Reedy: He asked. [23:31:08] I answered [23:31:46] Problems with wikilinking in BZ are that [[mw:foo]] links don't work properly (easily fixed) and links over line breaks don't work (still?). [23:32:05] I'm sure we had a brion written patch/addon that does wikilinks [23:32:06] Oh, the behavior has changed. [23:32:14] It used to have the literal [[ ]]s. [23:32:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=28490 [23:33:33] I wonder if someone removed the brackets intentionally, not realizing their value.