[18:19:51] RobH: The sekrit channel isn't letting me in [18:19:58] Oh wait [18:20:04] *RoanKattouw identifies to services [18:20:16] RobH: Never mind, I'm stupid [18:21:42] :-P [18:21:51] what sekrit channel? [18:22:25] shhh [18:22:30] can't tell you, it's a s33krit [18:22:36] gorrammit. [18:26:02] ^demon: So, 1.17 merges [18:30:26] ^demon: How exactly can I help? [18:40:07] <^demon> Sanity checking the ones I've already done would be helpful. [18:40:48] OK [18:43:07] <^demon> (I just sat down to eat myself, hence the delays) [18:45:35] don't eat yourself! :) [18:46:07] Ah ok [18:46:15] You cannibal! [18:46:37] Only REL1_17 right? [18:46:51] Autocannibalism [18:48:41] <^demon> I merged a few other things from 1.17wmf1 to trunk, but it's mostly merges to REL1_17, yeah [18:49:17] OK [18:50:56] food [18:51:02] how does this happen??? [18:51:07] no lunch *again*? [18:51:44] ^demon: In r84548 the installTables->createTables changes seem to be missing [18:52:05] All changes to includes/installer in fact [18:52:39] <^demon> How did I miss those? [18:52:46] svn merge .... includes/db [18:52:58] I'm thinking they may or may not have been introduced by future merges [18:53:18] The one I'm talking about now was on Mar 22 [19:05:26] <^demon> That seems likely. Wonder if we shouldn't just revert and start over. [19:06:07] Is REL1_17 borked now? [19:07:05] <^demon> Reedy fixed some things I borked already. MessageCache is still wrong, need to de-merge the adaptive stuff [19:13:13] OK [19:13:19] So you still need me to go over the rest of the merges? [19:14:11] I don't think it's in that bad of a shape [19:14:17] I tried to install 1.17, but found a bug, so didn't carry on for the moment :P [19:16:17] <^demon> Let me finish eating, then I'll a) sort out the message cache things I messed up, and b) see what shape the installer is (could've sworn I got that one right...) [19:16:21] <^demon> Then we'll move from there. [19:25:12] ^demon: Is the 5.2.3 requirement supposed to be in 1.17 or 1.18? [19:25:26] Tim added it for 1.18 iirc [19:26:01] Well at least part of it crept into 1.17 [19:26:08] + // This is the absolute minimum PHP version we can support [19:26:10] + const MINIMUM_PHP_VERSION = '5.2.3'; [19:26:49] <^demon> I added the 5.2.0 to trunk, and Tim bumped it to 5.2.3 [19:26:54] <^demon> For 1.17, that should be 5.1.something [19:26:59] OK [19:27:01] Noting on commit [19:31:51] <^demon> Installer is fine, only differences between REL1_17 and trunk are i18n and the removed 1.18 update. [19:32:24] Foos [19:32:26] *Good [19:32:34] Well, not good with respect to the 5.2.3 req [19:33:08] <^demon> Right, I just need to pick a version in 5.1.x [19:33:21] <^demon> We could just put 5.1.0, but I dunno if that's actually true. [19:38:38] i'm bored so i think i'm going to just start designing shit. [19:39:03] Designer dog turd? [19:40:31] exactly. [19:41:03] i have some ideas on how to do UX for template editing in an RTE. [19:56:41] I need to figure out a better way to handle the massive file sizes in LQT photoshop files. [19:56:59] Faster computer? [19:59:58] ram, mostly. [20:00:17] the problem is that the LQT file has about 5,000 layers in it. most of those are combination sets that make up single elements. [20:00:51] for example, a single "Reply Button" is 3 layers: background, "Reply", and plus icon. So multiply that by, oh, 100. [20:01:11] better to have a single "reply button" object i can insert and such. but i was lazy when i started on this file so i didn't set it up right. [20:01:14] now i'm going back into it. [20:04:18] hmm? the new version? [20:27:53] yeah. [20:28:05] there are other things i've been thinking about since the last pass i made, too. [20:28:13] interface smidgens. behaviors. [20:28:19] like "maximum comment depth" [20:28:20] etc. [20:56:55] <^demon> RoanKattouw: I skipped merging some Javascript distiller fixes r82340, 44, 84 and 99. They wouldn't merge cleanly at all. [20:57:16] Hmm OK [20:57:28] Just pull in the trunk version of that file [20:59:45] *^demon makes a note [21:24:43] *^demon rebranches REL1_17 from trunk and calls it a day ;-) [21:24:58] haha [21:25:09] Oh, reminds me [21:25:30] A newspaper in these parts had a small article about March Madness, and I notice VCU had made the final 4 [21:25:37] How did they fare? [21:25:44] *noticed [21:25:52] <^demon> Tip off for the semifinal is in 30 minutes. [21:26:08] <^demon> I was hoping to have this merge clusterfsck sorted by then. [21:26:12] <^demon> But that seems unlikely. [21:27:02] Well by all means go watch your game [21:27:19] I'm reviewing your merges while occasionally wrestling with my attempt to upgrade a 32-bit system to 64-bit in-place [21:27:30] And I'm pretty sure I'm screwed now [21:27:53] <^demon> Whether or not I get back to it tonight will depend entirely on whether we win or not [21:28:02] <^demon> If we win, all bets on me coming home at a decent hour are off. [21:33:46] Understood [21:34:01] I'll see how far I get digging through your merges [21:34:04] As it's almost midnight [21:37:51] <^demon> I've got all day tomorrow to work on it, so I can finalize things then [21:41:07] fingers: thrashed.