[00:44:16] hey everyone. Is unified login automatic for new accounts? [00:45:56] say, if I create an account on a WMF wiki and try to login on another, does that give me a "no such user" error or does it attempt merging (if the credentials are correct)? [06:29:41] neilk_: Good morning [06:40:01] ah the deployment's comgin up isnt it? [06:42:02] hi RoanKattouw [06:42:20] morning apergos [06:42:26] morning [06:43:47] So did you have any luck running that patch on prototype? [06:45:00] RoanKattouw: Well the diff seemed almost too trivial [06:45:56] RoanKattouw: but then I got called into a longer meeting with Erik & Alolita [06:48:39] RoanKattouw: hang on a minute [07:01:03] my brain is not functioning [07:01:25] why is svn.wikimedia.org asking me for a password when I connect from commons.prototype.wikimedia.org [07:01:34] is this to do with the cert expiry [07:02:56] No, probably not [07:03:04] Let me take a look [07:03:33] i'm sorry, I really feel very slow right now [07:04:02] What's the command you're running, and in which directory are you running it? [07:04:27] just an svn checkout [07:04:40] With an svn+ssh:// URL? [07:04:52] If so, use an http:// URL instead [07:05:29] in in /home/neilk [07:06:09] RoanKattouw: ah that makes sense. [07:06:14] RoanKattouw: thanks [07:17:52] RoanKattouw: sorry, I had this working locally, am just realizing that 1.17wmf1 LocalSettings is rather different... [07:18:27] No worries, I'm reading a 15-page The New Yorker article [07:19:47] what's it about? [07:22:34] Some elaborate conspiracy in Guatemala [07:22:47] tell me the US isn't involved :-/ [07:25:45] No, not really [07:25:49] It's a good read [07:29:20] almost there [07:31:15] RoanKattouw: ok uploadwizard deployment branch seems to work on prototype [07:31:26] Cool [07:31:28] http://commons.prototype.wikimedia.org/uwd/Special:UploadWizard <-- note /uwd/ [07:31:33] sorry I should have had that ready for you [07:31:48] I got sidetracked with that meeting for a long time, then came home ate dinner & fell asleep [07:32:11] It doesn't look like my patch is applied though [07:32:21] I didn't commit... wasn't sure if I should [07:32:32] or what alarm bells would go off if I did [07:32:55] the patch is just applied straight to 1.17wmf1, no modifications. [07:33:15] locally for me, and then again on commons.prototype.wm.o/uwd/ [07:33:51] Then which fs path is this at? [07:33:59] fs ? [07:34:01] I ran svn diff in wikis/uploadwizard-deployment , no results [07:34:57] filesystem [07:37:03] i'm dumb, try again [07:37:14] Ah yes [07:37:22] I was just visiting Special:UploadStash to confirm [07:37:26] did everything except apply the patch :( [07:37:43] but it worked on my local machine too, and the patch really was applied there. Just did another runthrough. [07:37:49] anyway, applied now. [07:39:37] *neilk_ peeks at New Yorker article [07:39:39] Testing [07:40:12] should we try running the test suite(s) ? [07:41:42] also, I find it interesting that deploy branches don't seem to have the test suites... I guess one is supposed to branch from a known good revision [07:41:59] Well [07:42:14] At the time of the branch point, the test suites were still too broken to be usable [07:43:46] neilk_: I'm getting an infinite spin upon completing the wizard [07:43:48] {"servedby":"commons.prototype.wikimedia.org","error":{"code":"permissiondenied","info":"Permission denied"}} [07:43:58] RoanKattouw: you used a file from Wikimedia Commons [07:44:03] 'permissiondenied' sounds like an error that should be handled by the wizard [07:44:05] Yeah, I did [07:44:11] Sorry, forgot you couldn't do that [07:44:22] Still, lack of error reporting is bad [07:44:35] RoanKattouw: this is one of the bugs Erik wants fixed before we launch, and yes, I totally agree. [07:44:57] Of course this particular bug cannot happen on Commons [07:45:02] right [07:45:04] Because it has no foreign file repos [07:45:19] still, though. [07:45:35] OK and "clear statshed files" in the stash list doesn't work [07:45:37] other such errors can occur at that moment for similar reasons. [07:45:59] oh right, that's a bug that was reported. Shall we fix that with this push too? it [07:46:02] it is easy [07:46:10] there was an unmerged change [07:46:30] wait a sec [07:47:27] I thought you meant the file listing didn't work. This surprises me. [07:49:50] Yay upload worked [07:50:09] Also, are filed unstashed after a successful uppload? [07:50:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=28236 [07:50:42] Let me answer my own question [07:50:43] RoanKattouw: yes [07:50:51] They stay in the stash list, but requesting them 404s [07:50:54] if you saw green checkmarks they are reals [07:51:07] see the bug I just posted, that might be why [07:51:25] I merged that specific rev [07:51:28] huh [07:51:30] *Because* of that bug [07:51:45] Otherwise the entire list wouldn't have shown up at all [07:52:00] Fatal error and all [07:53:09] right, that's why I said that surprised me [07:53:15] now there is some other kind of bug. [07:53:21] okay, time to put thinking caps on. [07:53:40] clearly it's the lack of clear() working [07:54:19] but I'm looking right at it and it's there [07:54:27] There's a difference though. Clearing the stash doesn't remove the stashed file, but completing an upload does. Neither operation removes the entry from the stash list [07:55:32] Oh, I got it [07:55:33] I'm not sure if I ever remove the stashed file off the filesystem. [07:55:41] It's the way it's constructed I think [07:55:45] *apergos glares at neilk_ :-P [07:55:46] No, I don't think you remove the files ever [07:56:22] $this->stash = RepoGroup::singleton()->getLocalRepo()->getUploadStash(); [07:56:28] But the old code for clearing the stash has [07:56:32] right [07:56:40] the repo is passed as a param instead [07:56:43] $stash = new UploadStash(); [07:56:52] So clearly something didn't get merged there [07:56:55] yeah [07:57:19] $stash = RepoGroup::singleton()->getLocalRepo()->getUploadStash(); [07:57:21] in trunk [07:57:27] *RoanKattouw svn blames [07:58:02] !r 81401 [07:58:02] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81401 [07:58:26] apergos: re stashed files, I know I didn't change any existing policies on removing or not removing them... [07:59:20] well that's a discussion for another day then (sometime they do have to be tossed) [07:59:36] *apergos butts back out of the conversation [07:59:40] Well there are temp files from 2009 on ms4 as we speak [08:00:33] neilk_: Alright I'm gonna try and merge r81401 and r81638 into the code running on prototype [08:00:44] thanks [08:01:56] where? ( RoanKattouw ) [08:02:17] apergos: The temp dirs [08:04:21] Alright that's done [08:04:41] Clearing the stash works now [08:04:52] works for me too [08:07:00] OK one remaining bug is that uploaded files are removed from the stash in the filesystem (renamed, probably) but remain in the stash metadata [08:07:08] But that's hardly urgent [08:07:22] This stuff seems to work fine so I'll start preps to push this to testwiki [08:08:42] RoanKattouw: thanks [08:10:53] RoanKattouw: I still don't know what dir you mean (sorry) [08:12:02] apergos: For instance /mnt/upload6/wikipedia/nl/temp/0/01/20081019002510\!800px-Nagorno-Karabakh_Occupation_Map.png [08:12:36] ah I was on ms4 [08:12:39] of course that's wrong [08:13:42] Oh I'm sorry [08:13:44] I misspoke [08:13:46] I meant ms7 [08:14:02] Due to all the recent troubles I automatically map msN to ms4 [08:17:25] well these aren't very many files on here for an almost 3 year period... if I were slightly more motivated I would look at the logic to see when we wind up with them [08:17:26] actually, the stashing code does have the possibilty to remove the stashed file when done, but for whatever reason, this is specifically turned off. [08:17:35] not my doing IIRC [08:18:04] the bad thing about zfs snaps: removing em doesn't. [08:18:22] we'll never get the space back... not til russ gives us the new architecture [08:18:36] apergos: Well we already stash files for upload warnings, that's eben in core since forever [08:18:46] right [08:18:55] I guess you could get a warning and run away screaming [08:18:59] I didn't invent stashing, I just horribly abused it. [08:19:02] And the stashed file would stick around forever [08:19:09] I imagine it's something like that [08:19:18] you abuser you :-P [08:19:35] anyways, can overhaul that later [08:21:15] At least you implemented a proper interface for stashing [08:22:55] I am not sure about proper [08:23:16] Well it's at least half-decent [08:23:19] It's an interface to begin with [08:23:31] you know that feeling you get when you see your old code and ask "who wrote this?" I am getting a similar feeling now like "I can't believe this guy managed to get anything to work with this system" [08:24:44] anyway it's hard to figure out who decided that stashed files should be immortal, it was all branched in by mdale at some point in 2009 [08:25:50] s/branched in/merged/ [08:26:13] OK, you said something about config changes [08:26:19] neilk_: "We are also planning on moving the configuration of these licenses to LocalSettings.php" [08:26:36] *neilk_ braces for impact [08:26:44] neilk_: bryan has a branch where he's trying to move the licenses into the database. have you seen that work ? [08:27:07] thedj: I wasn't aware anything had been done recently [08:27:12] RoanKattouw: right [08:27:25] look at LocalSettings.php in /uwd/ [08:27:36] neilk_: well not since the hackaton i believe, but the basis is there. [08:27:46] there is a global, $wgUploadWizardConfig -- that's what is needed [08:27:57] ^ RoanKattouw [08:28:05] OK [08:28:12] I'll omit debug=>true [08:28:46] hmm, thumbnail generation seems slow again [08:28:48] yes [08:29:22] neilk_: my license picker for WikiSnaps: http://commons.wikimedia.org/wiki/Special:NewFiles [08:29:28] eh. http://commons.wikimedia.org/wiki/File:Wikisnaps_licensepicker.jpg [08:30:39] thedj: I am not sure what you are showing me there [08:31:06] wikisnaps, I guess is a mobile tool to upload stuff w/geotags ? [08:31:44] neilk_: Can I copy the license stuff verbatim? [08:32:26] yes, as long as the i18n files are coming over at the same time. which they are. [08:33:18] *neilk_ reads http://www.mediawiki.org/wiki/WikiSnaps [08:34:35] OK it's now live on test [08:35:31] Whoa whoops [08:35:35] SVG thumbnailing ail [08:35:37] *fail [08:35:38] http://upload.wikimedia.org/wikipedia/commons/thumb/a/a3/Licensing_tutorial_nl.svg/720px-Licensing_tutorial_nl.svg.png [08:35:48] (top right frame) [08:37:01] RoanKattouw: what's the url for test? [08:37:25] http://test.wikipedia.org/wiki/Special:UploadWizard [08:37:46] Does not work though the secure gateway, you will have to turn off Wikipedia in your HTTPSEverywhere preferences if you use that [08:38:33] OK I don't mean to insult anyone but I have to say I find this slightly aggrevating [08:38:43] The spin-forever-on-duplicate-upload bug is still not fixed [08:39:25] no, it was fixed, but then the API was changed, and that unfixed it [08:39:34] just determined this today [08:39:49] ? [08:40:21] the api returns errors differently, I think, since a change by btongminh a couple of days ago. I was fully aware of this so I have no excuse though. [08:40:28] in any case [08:40:34] yes it is super frustrating [08:40:49] D'oh, fail [08:40:50] i would drop this software off the edge of the earth if I had a choice, personally [08:41:08] The final screen with the links and wikitext and all [08:41:13] Trieds to show a thumb from the stash [08:41:15] Which 404s [08:41:23] I swear this was fixed before [08:41:26] yes are thumbs working at all? I got nothing [08:41:34] thumbnail server is very slow atm [08:41:34] They take 7 seconds to load [08:41:47] Roan - what happened to you? [08:41:59] what are you referring to when you say "which 404s" [08:42:21] ? [08:42:33]

[08:42:44] are you saying it completed, but showed broken images for previews, or that something else happened. [08:42:47] The href of the link is correctly referring to the newly uploaded file [08:43:01] The src of the img is trying to get the thumb from the stash [08:43:13] But the stashd file has already been moved to be a main upload, so it's no longer there [08:43:18] ugh [08:43:34] This happened before, and I think it was fixed before [08:43:46] In fact I think I filed a bug report about this [08:44:08] Or maybe it was something similar [08:44:12] I think the problem might be if it thumbnailing failed for the final upload, it won't replace the old ones [08:44:13] nasty [08:44:27] Like the URL text box referring to the stashed file [08:44:41] No, it shouldn't be referring to the stash thumb at all [08:44:47] Because the stashed file is gone [08:45:14] i'll file a bug [08:45:17] It's unstashed and become a for-real upload [08:45:22] OK [08:45:33] yeah, but it's the same upload object in javascript land [08:45:55] it does try to fetch a new thumbnail but that might fail. I guess I should clear the old thumbnails first. [08:46:09] Meanwhile, nothing seems to be more broken than before, at least [08:46:18] So I'll go ahead and deploy to commons [08:47:55] thanks [08:51:25] OK looking good [08:59:23] https://secure.wikimedia.org/wikipedia/commons/wiki/Special:UploadStash/thumb/7hjndjhkozmdkpfgc157xguqilj46ii.png/60px-7hjndjhkozmdkpfgc157xguqilj46ii.png [08:59:27] Internal Server Error [08:59:27] Fetching thumbnail failed: Array [09:00:05] got that on the releasing rights tab. [09:01:51] RoanKattouw: thanks for this. Do you think you have time to do this again next week, same time? [09:02:12] we want to do weekly pushes. There might be some more core changes :( [09:02:19] mostly UploadWizard only changes [09:02:25] Yeah should be able to [09:02:35] Just make sure to tag core changes with uwdeploy as you go [09:02:54] tagging in Special:Code? [09:02:57] never used that [09:03:05] It's easy [09:03:23] ok, just had to check [09:03:25] https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/tag/uwdeploy is the list of tagged revs [09:03:28] I'll clear it in a sec [09:03:46] You just go to a rev like https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84762 and use the add tags field [09:03:53] You can also mass-tag using checkboxes in a rev list [09:14:57] ok [09:15:14] would you object to me rewriting all the upload code in mediawiki? [09:15:24] just saying. [09:16:12] UploadBase is exhibit A in "why inheritance sucks" [09:16:28] Bryan rewrote the upload backend not too long ago [09:16:30] Maybe 2 years [09:16:46] You guys should talk [09:17:00] i now feel like that might have been the saner path, rather than trying to work with it as is. [09:29:51] neilk_: if you can rewrite it relatively quickly, it's all you :-P [17:44:14] hey RoanKattouw [17:44:28] Hey [17:47:17] so, I guess we wanted to deploy some AFT stuff at some point [17:47:31] Yeah [17:47:34] but also Howie wanted to get some preliminary click data from the aft stuff [17:47:42] Can we do this when I'm done debugging my c++ matrix algebra stuff? [17:47:49] It has to be in by 3pm [17:48:16] yes [17:48:22] no rush [17:48:28] the data isn't going anywhere [19:47:16] http://www.mediawiki.org/wiki/Extension:UploadWizard/2011Q2_Design_Pass [22:23:02] <^demon> robla: What time were you wanting to meet today, was it 6:45 or 7:45 my time? [22:24:10] ^demon: 7:45 your time [22:24:14] however.... [22:24:45] Tim does appear to be up and about, so if you're eager to do it earlier, we might be able to [22:25:17] <^demon> I was hoping for the latter actually, I'm rather hungry and wanted to grab an early dinner before we started :) [22:25:42] okee doke....talk to you in 75 min :) [23:31:36] so we have a meeting soon? [23:36:33] <^demon> So I'm told. Not sure where yet. [23:38:55] hey there...how about x2003 [23:39:25] TimStarling: ^demon: ^ [23:40:09] hmm, wait while I install ekiga [23:40:35] <^demon> It said "I'm sorry" and kicked me :( [23:40:55] did it sound sincere? [23:40:57] :) [23:41:05] well phooey [23:41:24] <^demon> Slightly more sincere than the Mumble voice. [23:42:36] ^demon: are you calling in via PSTN? [23:43:05] <^demon> I'm using skype, been having trouble getting my SIP line setup. [23:44:01] skypeout? [23:44:35] <^demon> Just making an outgoing call with it, yeah. It's not tied to a real number or anything. [23:46:59] <^demon> Lemme try my cell, maybe it'll work fine.