[14:24:04] good afternoon RoanKattouw [14:24:16] Morning TrevorParscal [14:25:41] this probably needs to make it back to trunk http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83749 [14:25:46] could you merge that in? [14:26:26] Sure [14:27:08] i guess the documentation online is out of date [14:27:21] I copy-pasted the hook function sig from mw.o [14:27:56] Yeah that's not always a good idea :D [14:28:03] Still though [14:28:09] Oh of course [14:28:13] 301 --> no warnings displayed in browser [14:30:00] TrevorParscal: I've been fixing RL bugs today, and incorporated Paul Copperman's minifier [14:30:12] oooh [14:30:16] how's it working? [14:30:20] It's working great [14:30:24] Is it as fast as he measured? [14:30:38] I haven't benchmarked it but it seems to be slower for jquery.js [14:31:05] Oh, it's not that bad [14:31:07] 1.45s [14:31:14] Faster than JSMin at least [14:35:05] And it's better in terms of correctness [14:35:07] right on [14:35:17] I tweaked it to allow max line length and each statement on one line [14:35:37] all we need is compatible license + faster than alternatives + reliable [14:35:54] we have 2/3 with the hacked together version I made, but this sounds like it gets us 3/3 [14:35:58] so, well done! [14:36:11] * License: choose any of Apache, MIT, GPL, LGPL [14:40:01] wheee [15:01:21] am I really online? [15:02:03] You are indeeed [15:05:37] damn! [15:12:40] TrevorParscal: I added a bunch of stuff to your review queue https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/tag/trevor [15:12:56] (Basically most of the things I did yesterday and today) [15:13:25] *hexmode is happy that someone ELSE said review queue [15:13:32] *hexmode hugs RoanKattouw [15:13:54] haha [15:14:15] TrevorParscal: Also, we should do a review trade today where you review Narayam and I review ArticleFeedback :) [15:14:27] (So I can then deploy both late this morning) [15:16:02] I feared taht [15:16:38] Apparently the office internet is totally screwed up today [18:11:13] TrevorParscal: So we were supposed to start deploying ArticleFeedback 15 mins ago. If you could review r83919 and r83924 I'd be good to go [18:11:22] roankattouw: have you synced-up with Trevor [18:11:31] In the process of doing so [18:11:34] roankattouw: he's gone bagel hunting :-) [18:11:42] At 11? *sigh* [18:11:48] Oh [18:11:49] Monday [18:11:51] 11 [18:11:52] Of coures [18:12:06] roankattouw: :-) yes monday at 11 is bagel time here [18:12:15] I know, I forgot when scheduling this [18:12:39] roankattouw: np - he should be back shortly [18:13:03] OK [18:22:13] RoanKattouw: all looks good [18:22:20] Thanks [18:22:40] I'd just taken the first step of "screw this, it's taking too long, I'm not waiting for you anymore" :) [18:23:26] But per scrollback I'd stupidly scheduled this to conflict with bagel time [18:29:29] TrevorParscal: I need help configuring this [18:29:37] ok [18:29:37] Does ArticleFeedback still require PrefSwitch? [18:29:48] no, just SimpleSurvey, which may [18:29:54] at least not directly [18:30:35] OK [18:30:45] As far as config goes I just need the categories array and the lottery odds, right? [18:30:59] yeah, let me show you mine [18:31:14] well [18:31:16] nevermind, yes [18:31:17] that's it [18:31:46] What should the lottery odds be set to? [18:32:12] 0 [18:32:30] howie is going to use a bot to set categories [18:32:36] the random thing is not being used [18:33:01] so, technically you can not set the lottery odds since they are 0 by default [18:33:17] but setting them is safe, so if someone changes the default, it doesn't slip through the cracks [18:33:55] I'll set default => 0 [18:34:07] Was gonna do testwiki => 50 but if we're not gonna use it I won't bother [18:35:22] right [18:43:15] OK I deployed it on testwiki [18:43:19] But why the hell isn't it loading [18:46:42] mw.loader.load('ext.articleFeedback') returns true but doesn't do anything [18:47:18] Aha [18:47:20] missing ) after argument list [18:47:22] [Break On This Error] },'pitch-join-signup'); [18:47:28] My fault [18:51:03] Now I'm getting somewhere: http://test.wikipedia.org/wiki/Main_Page [18:51:08] The messages are still broken, fixing that [18:52:29] speaking of messsages [18:52:39] let me double check that I updated the i18n before we push [18:53:00] howie sent some updates, I think i applied them but I'm going to be sure :) [18:53:16] OK [18:53:48] hmm, ok, one patch coming [18:53:52] Oh and I have to clear stuff in msg_resource too of course [18:55:28] OK now I have some messages in but not others [18:55:33] Let's see if they are defined and if they are exported [18:56:15] ok, see r83945 - sorry about the late commit there [18:56:17] Oh, jquery.articleFeedback [18:56:19] No worries [18:56:31] I will pull that in now [18:59:04] OK, test looks good to me now [18:59:10] You may need to Shift+Refresh [19:00:16] TrevorParscal, alolita: If you guys could check out AFT on test and give me the green light to go to enwiki, I'm ready when you are [19:00:36] lookin [19:00:39] RoanKattouw: Ok [19:01:26] i found a bug hold on [19:02:15] the tipsy gravity is supposed to be sw [19:02:24] it was se, and that's a mistake [19:02:33] Is there a tech-meeting tonight ? [19:02:46] Yes [19:02:52] 9pm CET [19:03:09] k, I remembered right, although I can't find any proof of it. [19:03:38] Ah, got it :) [19:03:46] Invitation: 1.17 post-deployment blocker triage @ Mon Mar 14 9pm - 10pm GMT [19:03:48] RoanKattouw: r83947 [19:04:10] Krinkle: You found a bug in Gcal :D [19:04:30] He created the event before the DST switch in the US but the event takes place after [19:05:04] haha, indeed [19:05:16] so, it's at 8 PM GMT ? [19:05:36] Yes, which is 9pm CET [19:05:54] (and 1pm PDT and 4pm EDT) [19:07:07] TrevorParscal: Shift+Refresh and try again [19:07:55] looks good [19:08:00] I give it a go [19:08:08] well [19:08:16] you need to also push the changes to tipsy [19:08:24] or brandon will probably throw a fit [19:08:30] we had a big meeting about the styling [19:08:36] it's changed in the svn [19:08:40] let me get you the rev # [19:09:22] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83496 [19:09:26] this is also a critical commit [19:09:37] because it adds the blue red and green buttons to our jquery styles [19:10:32] Do I just need that one? [19:10:47] yes [19:10:56] it was all done in that one commit [19:11:00] Krinkle inspected it [19:11:18] OK [19:13:16] Deployed on test [19:14:00] yup [19:14:08] blue button, white tooltips [19:14:11] we're in business [19:14:22] Alright [19:14:33] I'll scap this out to the cluster [19:15:10] sweet [19:17:01] RoanKattouw: i tossed my work on narayam, it was getting away from me [19:17:17] basically it's not the most awesome looking thing [19:17:20] and I have some ideas [19:17:24] but there is a bug [19:17:39] What's the bug [19:17:46] hmm [19:17:54] you fixed it between my update this morning and now [19:17:59] it was in setScheme [19:18:12] you used "scheme" instead of "name" when setting the cookie [19:18:20] which was not defined [19:18:59] Junaid fixed that [19:19:06] Earlier than this morning [19:19:07] ah [19:19:09] looking at commits [19:19:22] yeah, so it was between me updating this morning and just now [19:20:26] the other things were organizing the module files better [19:20:38] and line 13 of Narayam.php [19:20:43] What's on line 13? [19:20:45] as mentioned before [19:20:51] um, [19:20:53] * require_once("$IP/extensions/Narayam.php"); [19:20:57] Oh [19:20:58] D'oh [19:21:04] that seem off to anyone else but me ? he he [19:21:04] How did I not see that :P [19:21:11] I didn't see it [19:21:18] you probably didn't write it in the first place [19:21:19] Seriously, I pasted that line in Gtalk and I still didn't see it [19:21:23] I didn't [19:21:35] it burned me because I actually copy pasted it [19:21:36] But you said "line 13" and I said "line 13 is this [paste] what's wrong with it" [19:21:45] I didn't notice it as I copy pasted it [19:21:49] so, don't feel too bad [19:21:52] haha [19:21:56] I actually added that to my localsettings [19:21:57] ha ah [19:22:01] lol [19:22:11] Lazy bastard [19:22:17] Either way [19:22:20] let me mockup something for the UI [19:22:21] You have to reorg done locally, right? [19:22:34] I was playing with a few ideas, but Monobook was pissing me off [19:23:03] so, yeah your rewrite seems good to me [19:23:08] I just want to rev the UI a bit [19:23:19] I gotta go get some food, I will be back [19:23:36] we should probably take a snapshot of SEL today too [19:23:46] if you are bored and want something to do :) he he [19:23:49] heh [19:23:51] BTW [19:23:54] yes? [19:24:04] Mark H has another 1.17 bug triage meeting at 1 [19:24:14] ok [19:24:17] i'm going to be there [19:24:18] cya [19:24:20] And we were all kind of frustrated when you weren't around for the last one, TBH :) [19:24:22] Cool [19:25:28] alolita, jorm: ArticleFeedback is now live on enwiki, see http://en.wikipedia.org/wiki/True_Grit_%282010_film%29#External_links [19:29:58] Wow, it's been improved a lot since I've last seen it [19:41:24] RoanKattouw_away: You're at home ? (Will you join via Skype ?) [19:47:27] I'm at home, will join via SIP [19:48:13] k [19:48:47] RoanKattouw: when you can, I need r83953 pushed out - there's some margin issues I'm seeing now that I see the tool on a few pages... [19:48:52] it's a 1 line patch [19:49:01] Saw the notif, already on it [19:49:06] :) [19:49:37] cya in the meeting in 5 [19:51:34] Which extension ? [19:51:48] 2003 usually [19:53:56] k [19:59:53] TrevorParscal: Meeting starting, call into 2003 [20:07:38] http://eiximenis.wikimedia.org/Bug27339 [20:13:47] http://i.imgur.com/q1g5g.png [20:15:04] Ohai [20:17:46] etherpad link? [20:22:20] Krinkle-meeting, etherpad link please? [20:22:23] http://eiximenis.wikimedia.org/Bug27339 [20:22:46] ta [20:22:47] "Roan-meeting" == "Krinkle-meeting".replace("Krinkle", "Roan") [20:22:52] :D [20:23:05] Hey you're the copycat if anyone :D [20:23:10] true [20:23:26] Krinkle-meeting, if you're like me, you should be fixing/replying stuff that's on Roan-meetings todo list :P [20:38:23] what's up [20:40:07] #wikimedia-commons [20:51:17] Krinkle-meeting: who's Timo? :o [20:51:17] Reedy: Just put some var_dumps() in the source in fenari:/home/wikipedia/common , then ssh into srv193 and run /home/catrope/sync-common , then your var_dumps will be live on test [20:51:28] Oh whoops you don't have access I see [20:51:46] Nikerabbit: Timo == Krinkle [20:51:53] yep [20:52:37] Hulk smash IE6! [20:52:40] he's going to ask who's Chuck Norris soon... Then I will have to reveal my name [20:52:55] who's Chuck Norris? [20:53:26] ha ha [21:05:53] is Chuck a new developer? [21:05:56] I dont get it [21:12:22] kaldari, hashar, http://www.google.co.uk/search?sourceid=chrome&ie=UTF-8&q=chuck+norris [21:37:03] instead of having English lessons, I should get a course about American "culture" [21:37:18] hahaha [21:37:30] those sohuld be part of the lessons I guess [21:38:16] was someone impersonating chuck norris on the etherpad? [21:42:19] woof