[05:57:30] Mark Herzberger is Mah on IRC right ? [05:57:58] no, he's hexmode [05:58:03] mah is his commit name [06:18:48] that explains why I never found him here [16:54:17] make test for wikidiff2 fails for me [17:58:00] what's nelson bugzilla email? [17:59:22] rnelson@wikimedia.org did not match anything [18:00:07] found: russnelson@gmail.com [19:29:31] anyone around on a saturday morning/evening that can say why we now have metadata in the image table for images with no frame count and no looping? [19:29:31] i.e. [19:29:46] a:3:{s:10:"frameCount";i:0;s:9:"loopCount";i:1;s:8:"duration";d:0;} [19:30:18] I'm not going to try to do anything about it, just flagging it cause that's well a bunch more stuff in the table if we don't actually need it [19:32:33] Its needed so that the code doesn't repetitively try to extract the frame count [19:32:59] (I think anyways, its been a while since i last looked at the relevent code) [19:34:01] it also allows us to say that the file is definitly a static png, and not an apng definitively, instead of wondering if perhaps the metadata extract failed. (and same for gif) [19:37:17] whereas if we set it to some much shorter value like 0 that wouldn't suffice? [19:37:35] I suppose it's a text string so we don't save on it that wat [19:37:36] way [19:38:01] that way has trouble if we want to extend the list of properties later [19:38:15] if say we start extracting "author" information from png's, etc [19:40:45] that's true [19:41:57] *bawolff notes as an aside i do have code written to start extracting author info from png's [19:50:58] commit commit commit! [19:53:36] its in a branch. I'm waiting for 1.17 to be released before looking into merging it in [19:54:11] *cough*trunk*cough* [19:54:31] of course I'm a fine one to talk but I do intend actually to get my crpa into trunk and well before the next review cycle starts [19:54:50] because after commit commit commit it's merge merge merge! [19:55:29] somewhere there is a pardoy waiting to get out: merge merge merge your code, listen for the scream ... [19:57:35] You know, if we went back to the theoretical release once every 3 months schedule [19:57:45] It'd be time for 1.18 to come out soon [20:02:38] yes it would [20:02:45] well only after 1.17 comes out [20:02:48] which it still isn't