[16:23:16] is someone able to help with an annoying bug? [16:23:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=27453 [16:23:23] especially {{ns:file}} [16:28:10] It was already fixed by Roan a few days/weeks ago, will be deployed soon hopefully Romaine [16:28:20] (assuming it's the same issue, can't find the bug report of that right now) [16:39:47] Krinkle: ok thanks [16:39:55] any idea when it will be deployed? [16:40:15] When what will be deployed? [16:41:30] Do I understand correctly that we are going to branch 1.18 soon and use it for a continuous deployment model? [16:41:42] I don't think that's been decided yet [16:42:29] RoanKattouw: Recently you or Trevor fixed a bug in which {{ns:file}} was litterly outputted, and changed it to use wgFormattedNamespace instead. [16:42:35] Yeah [16:42:44] Romaine just told me in PM [16:42:57] I thought pushing the LU cache files would've fixed that [16:43:27] RoanKattouw: BUt it's in WikiEditor's js files, right ? [16:43:48] We changed the messages too [16:43:55] I'll investigate later [16:50:03] RoanKattouw: Alright if I assign it to you ? [16:50:11] Yes [16:50:22] I'm almost done with this thing, that'll be next [23:20:54] RoanKattouw: http://toolserver.org/~krinkle/tmp/mw-legacy-js-finder.php [23:21:16] Nice [23:21:26] Live [23:21:36] Atleast, with one wiki it can be live :P [23:21:53] I'll remove the limit 1 wiki, put it outside public_html and leave it running for the night. [23:22:18] The first tool to make use of the new BaseTool() class I wrote. [23:22:42] Wanted to move away from 'collection of functions' to a new class system for tools but never got around doing it [23:22:42] Hey do you have time for a Skype meeting with Trevor and me at 22:00-23:00 on Tuesday? [23:22:57] Sure [23:23:10] 22PM GMT +1 ? [23:23:15] Yes, our time [23:23:28] I wanted to talk about tasks for "ResourceLoader 2.0" [23:23:39] Alrighty, noted. [23:24:01] Trevor's gonna be spending more than half of his time working with Zack on something to do with account creation and login for the next little while [23:24:24] And you're apparently supposed to be starting work soon, so I figured I'd claim your time for this [23:24:24] k [23:24:44] I'm assuming you're set up for Skype? [23:24:56] Yep, had a 2-hour interview 2 weeks ago to SF already. [23:25:04] :D [23:25:04] (We normally use the WMF phone system, but I don't think we can get you on it on such short notice; tomorrow's a holiday) [23:25:09] Oh that's right [23:26:50] Working on RL 2.0 right away is fine by me, although I don't know if the head of feature development will plan something else for me or how the organisation works. I expect to hear from alolita/Danese/HR soon regarding the contract and what projects I'll be assigned to. [23:27:28] Head of feature development is Alolita, pretty much [23:28:07] So yeah you may or may not be assigned to this project, and Alolita (like everyone else except me about a week ago) has probably forgotten about RL 2.0 [23:28:25] RoanKattouw: Do you think the method used to 'get' MediaWiki:Common/skinname.js/css and User:Name/common/skinname.js/css is easy to extract to a re-usable thing is it is (currently) hardcoded for it's purpose ? [23:28:27] It's her call, really, but I think it's useful to have you there whether or not you end up working on it rightaway [23:28:50] It is, see ResourceLoaderWikiModule.php [23:28:57] ResourceLoaderUserModule and ResourceLoaderSiteModule extend it [23:29:21] ie. to introduce 'wikistyles' and 'wikiscripts' as possible arrays when registering modules. [23:29:43] I guess I can also bring this up in the weekly features team meeting which is right before ours, at 20:00-21:00 [23:30:02] Can we talk about RL 2.0 design things like these when it's not past midnight and Trevor is around? :P [23:30:19] I think things like ['ext.Foobar'] => array( 'wikistyles' = array( 'MediaWiki:Foobar-custom.css' ) ) can be quite useful I think. Much better than the hacks currently around. [23:30:37] Sure, I was just flushing my buffer to the irc log :D [23:30:44] No worries [23:30:57] Yeah that shouldn't be too difficult to implement, at least not server-side [23:31:28] Read e.g. ResourceLoaderSiteModule.php to see what kind of infrastructure we have right now [23:32:10] registering modules client side could bring a few problems though, due to maximum get query length. (passing scripts/styles/message/dependancies to PHP, probably a urlencoded json-string in a single query parameter) [23:32:50] Yeah [23:34:10] My Tour de WIki is going very slow. I was hoping other people would join, although the bar is kinda high with my perfectionistic guidelines. We should/could ignore most deprecated stuff and just keep it to fixing actual broken things. But that would be stupid since then it's fixed only to have it broken again when wikibits is removed. [23:34:46] I hope to finish the tour by december :P Just slowly in the background. Full wiki reviews. [23:34:49] heh [23:35:08] I guess you could try to sell this to Alolita as a 20% time project or something [23:35:20] Maybe get Kaldari on board [23:35:39] I don't know what he's doing these days [23:36:36] Yeah, I think it sells good though. I learned a lot from the dozen reviews I did so far. Although on average I think I know what the community wants very good, but in the last week I learned a lot about what people really want. Some great extension ideas, some obvious things that should be fixed in core, some problems with RTL/foreign languages. People do crazy and awesome stuff in their site scripts and styles. [23:37:01] It's a fixing proces but also hervesting problems that people don't know how to report. [23:37:18] Yeah, the unfortunate thing is that awesome things are sometimes implemented in crazy ways [23:39:12] Snippets is doing fairly well now: http://www.mediawiki.org/wiki/Category:All_snippets . [[mw:RL/MGU]] is getting more complete as well. Basically that guide is just what I follow for each wiki, together with the checklist: http://meta.wikimedia.org/wiki/User:Krinkle/Le_Tour_de_Wik%C3%AD#2011_Resource_Walker:_Checklist [23:39:20] So I was gonna list things I wanted to talk about at http://eiximenis.wikimedia.org/RL2 , but I'm pushing that back until tomorrow. You're welcome to add your own stuff before or after I get to it, though, and generally edit boldly :) [23:39:24] On most wikis it's just copying and pasting snippets. [23:39:45] updating gadgets to load from mw.org/metawiki. etc, anyway, nuff about that,. [23:39:50] *Krinkle bookmarks [23:39:52] Yeah, I've been fixing about a dozen document.write() calls this week, it's very methodical. [23:40:02] Either mw.loader.load or jQuery('body').append or jQuery('head').append [23:41:50] Your earlier statement reminds me, do you even have a contract yet? :D [23:42:03] could be done with a regex, even [23:42:39] Sometimes $.getJSON is appropiatte as well. [23:42:53] but takes more time to convert, mw.loader.load would get the job done. [23:43:11] ie. document.write api.php?callback=FunctionName [23:43:39] RoanKattouw: It's being made by HR, so, officially I don't. [23:43:58] Right [23:44:27] Most of the document.write()s I fixed were index.php?action=raw&ctype=text/javascript [23:48:53] indeed [23:48:59] I bet it has dontcountme=s in it as well :D [23:49:02] hadD* [23:54:38] for Webalizer, which was like a million years ago [23:54:45] Some did, yeah [23:55:05] RoanKattouw: By the way, is it worth it to append things like (s)maxage to that ? [23:55:19] I don't know if index.php even obeys that [23:55:36] Hm.. [23:55:53] But I wouldn't bother with it and aim to replace this stuff with RL 2.0 (or 3.0, for cross-wiki loading of gadgets and user scripts, maybe) instead [23:56:30] Right, they'd be minified and go through load.php anyway. [23:56:42] And be cached for a month, yeah [23:57:46] Hm.. I think I'll postpone the tour untill RL 2.0. And for now just fix broken things.