[00:43:27] anyone with shell wanna do [[bugzilla:26126]]? [03:25:34] *SDrewth has put in a bugzilla request (enWS) for change of Template ns to have subpages. Would there be anything that would need to be altered or managed by admins on site? (beyond any specific template amendments) [05:22:25] :-/ [18:17:19] werdna: So for the short time you're in our little 1.17 group, I've added you to http://eiximenis.wikimedia.org/1-17 , it's got a link to your 'review queue' (i.e. all revs tagged with 'andrew') [18:20:53] | fixme | 62 | [18:20:53] | new | 250 | [18:20:58] Pre branch, all paths [18:21:05] Nice [18:21:11] I'm going through the 1.17 queue nwo [18:21:28] From memory, a good % of the fixme's are on extensions we don't care about [18:21:37] the new should only be phase3 + extensions we do care about [18:21:56] and with the fixme's, that's why I started the list on etherpad [18:23:40] RoanKattouw & Reedy: go ahead and assign some sections to me if y'all see anything relevant; i'll run a couple hours of review per evening this week to help catch up [18:23:51] brion, awesome :) [18:23:59] (i'll be mostly working on statusnet stuff during the day so can't do full-blown review this minute :D) [18:24:29] damn 10th anniversay thing gettng me all energized again ;) [18:24:46] heh, as you can see the queue is getting there, but it's also getting to more "difficult" stuff [18:24:47] <^demon> Oh I've got one for Brion I didn't want :) [18:24:51] :D [18:24:56] d'oh [18:25:19] brion: We'll use /tag/brion on CR, OK? [18:29:23] RoanKattouw: I see in the "port monobook to vector" commit (that is reverted in 1.17 afaik but live in trunk) - you commented out some imported in Monobook.php to load some IE-fixes. At the same time, wikibits.js has some lines that conditionally (IE and monobook) load some browser specific fixes. [18:29:37] RoanKattouw: super [18:29:39] I think one of those sections should go. Either both in php or both in wikibits. [18:29:55] Perhaps we can eventuaally survice with neither though... [18:30:03] Krinkle: Yes, we need to sort out the per-browser fixes CSS situation [18:30:10] Trevor just wants to use CSS hacks and put it all in the main CSS [18:30:24] Either way, it's not in 1.17 so until 1.17 has been deployed I don't care :) [18:30:27] what's cracking fellas? [18:30:42] hey Trevor [18:31:11] RoanKattouw: thanks [18:31:22] I will probably have to just dedicate a couple of days to rewriting much of Monobook so it's not such a mess [18:32:02] TrevorParscal: should rewrite the skin code generally [18:32:02] it's really inefficient to load the fixes the way they are done right now [18:32:06] Apparently we are alike in terms of our capablities. (Roan told me) - I didn't know you designed the graphics of Vector. (I'm a graphic designer, currently in next to lase year of college) [18:32:06] yes [18:32:09] :D [18:32:17] last* [18:32:18] I did [18:32:23] You're alike in more ways than that, I believe I've told you both [18:32:29] I haven't met Krinkle [18:32:35] oh - you said I didn't not I dont... [18:33:09] werdna: Perhaps in Berlin or Haifa (if I get the scholarschip) [18:33:15] Krinkle: we need more of us - graphic artists, UI designers and engineers - wrapped together in a shell of tollerance for MediaWiki and topped with a open-source loving glaze [18:33:20] Berlin's been moved to May :( [18:33:32] TrevorParscal: You took the words right out of my mouth [18:33:32] orly? [18:33:38] berlin! [18:33:45] TrevorParscal: Yeah, check wikitech-l [18:34:01] There's going to be a hackathon in Berlin and 2 hacking days in Haifa [18:34:06] omh - 250 messages over the weekend [18:34:07] owch [18:34:47] if the berlin thing ends up opposite my anniversary, i think my wife might be annoyed :) [18:35:44] RoanKattouw: I subscribed to wikbugs-l xD just checking what the load really is [18:36:01] It's managable actually (search for keywords with gmail, not bad at all) [18:36:55] Yeah it's not too bad [18:36:59] And I skip a lot of it [18:37:52] brion, hasn't MW been in your life longer? P [18:37:54] *:P [18:38:19] a man has needs that mediawiki cannot fill ;) [18:39:24] speaking of which, you know what would be awesome? a svn keyword search on CodeReview [18:45:23] TrevorParscal: Have you heard about the License integration project Bryan, Roan and me have started during the hackathon by the way [18:45:49] If you speak of the devil [18:45:51] Hi Bryan [18:46:21] brion, hmm. That would be somewhat interesting... [18:46:22] yes, I'm here to burn your souls! [18:47:36] Krinkle: I just told him about it [18:47:49] k [18:48:01] brion, log a request on BZ? :P [18:48:07] double points for being able to search by class/method/function name and get anything that changed its definition or usage [18:48:14] :D [18:48:49] Do points mean prizes in this case? [18:49:12] brion: Sounds awesome. [18:49:35] mmm, prizes [18:49:37] perhaps I can get a quarter point for an online grep search through Wikimedias SVN ? [18:49:42] http://toolserver.org/~krinkle/wikimedia-svn-search/ [18:49:52] (I hate to checkout /extensions) [18:50:04] So, this features team meeting is in 5 minutes, right? [18:50:06] Krinkle: Someone already has checked out /extensions in user-store, I think. [18:50:13] *Shirley bites guillom. [18:50:26] Shirley: I'll check that out (and see if it's updated regularly) [18:51:05] Shirley, don't bite your elders. It's considered impolite in most countries. [18:51:46] Another cool thing is ofcourse permalinks for IRC to search results of grep and not having to leave terminal open for several minutes. [18:52:22] license integration - interesting [18:52:28] eg. http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=73&hash=2b7dc3d581c46613e69c42cc003cbf3a#F2L2788 [18:52:45] TrevorParscal: I'm in the proces of thinking through some mockups at the moment [18:53:10] I need to send out a mail to wikitech-l about it [18:53:31] but need to check a bit of documentation first [18:53:36] especially editing file properties will involve some smart php and javascript enchancement (ie. mapping usernames to user-id and fallback for custom attribution to real name to user name) [18:54:33] Krinkle: nice! [18:54:40] guillom: Yeah the meeting is in a few minutes [19:03:03] flipzagging, guillom: ping [19:03:05] we're in 2003 [19:03:20] jorm, can someone skype me in? I don't have an extension yet. [19:03:42] can you skype out? [19:03:55] yes, if you give me an ID :) [19:04:26] sure. jormosaurusrex [19:04:30] ok [19:06:17] jorm, thanks, I'm in [19:06:24] i'm in too [19:06:58] although I'm not sure what is being discussed [19:07:37] editor trends studies. [19:07:42] can you hear okay? [19:07:46] yes [19:07:47] thanks [19:30:51] people laughing over skype sounds like seals [19:32:12] do you have video? perhaps they are [19:41:54] <^demon> robla: maintenance/minify.php, as well as the resource loader. [19:42:44] TrevorParscal_: resource loader uses JSMin? [19:45:52] <^demon> http://wonko.com/post/jsmin-isnt-welcome-on-google-code is a good read. Especially the comments. [19:46:17] <^demon> Apparently the python version in v8 is under a free license now and could possibly be ported to php. Not sure though. [19:46:53] yeah, I saw that [19:47:14] <^demon> http://code.google.com/p/v8/source/browse/trunk/tools/jsmin.py - header doesn't sound very free [19:47:15] <^demon> but maybe [19:47:42] Looks like standard 3-clause BSD [19:47:48] that's fine [19:48:23] <^demon> I thought http://wonko.com/post/jsmin-isnt-welcome-on-google-code#comment-5724 was a good comment [19:48:24] Crockford is being a pita on this one [19:48:30] <^demon> Describes my opinion [19:48:48] <^demon> "I really don???t care if my code is ???free??? to roam around and be developed without being ???enslaved??? into a commercial product, what I care about is if PEOPLE are free to reuse my code in their own work; building a body of freely available, reusable code and systems to make programmers??? lives easier and advance technology." [19:50:44] I hate dealing with these issues [19:50:58] ...but I know that we have to [19:51:09] it sucks, but we really shouldn't use it [19:51:23] it's SO dumb [19:51:30] I agree, but I'm gonna pretend that I don't care [19:52:53] <^demon> Quite a few bytes wasted on bashing the guy (who is being unreasonable, I agree) [19:53:03] <^demon> Somebody should've just rewritten it under a new license by now [19:56:23] Yeah. It's not like it's a complicated program. [19:58:03] robla: yes - RL uses JSMin, we are looking at alternatives that are GPL friendly, they mostly are really slow [19:58:11] like 4x the time to do the same work [19:59:56] <^demon> We could fork one of the alternatives and make it better :p [20:01:20] btw werdna thanks for reminding folks I was here =) [20:03:13] is the meeting over? [20:03:16] guess so [20:04:04] Yeah [20:04:11] We have like 8 mins to grab lunch for the next mtg [20:04:25] have fun [20:47:17] I love the public domain. [21:55:31] re ArticleFeedback... [21:55:39] Yeah? [21:56:33] what's needed to backport it to 1.16 apart from http://p.defau.lt/?RQoIbK2aHaIbXIGSLGh5MQ ? [21:58:07] Have you noticed it uses the jQuery localize plugin? [21:58:51] That one would need to be brought along, although I guess that's not a huge problem [21:59:21] Also adding AF on every page is bad, there's a $wg var to control which categories it's enabled on [21:59:29] (i.e. this filtering is done server-side, not client-side) [21:59:46] but there's not like a week of extra work to do that I'm missing? [21:59:53] No [21:59:59] Granted, it's not a huge job [22:00:07] But it's a PITA and it's also the definition of wasted effort [22:00:37] And Alolita has basically said that we're just not gonna backport it and that PPI will have to live with that [22:10:52] RoanKattouw: fyi, we were discussing introducing an authors table [22:11:07] OK [22:11:16] I saw the talk page you linked me to, briefly [22:11:32] krinkle said he would post it to the talk page later [22:11:35] I'm off to bed [22:11:37] But I didn't read it in any sort of detail; I've been in meetings for most of the day and I have quite a bit of work to do here :) [22:11:39] Yeah good ngiht [22:15:21] RoanKattouw: It's probably easier if I'd explain it on IRC and summarize on wiki later. [22:16:17] Explain then, but I gotta leave my desk for a few mins now so I won't read it immediately [22:16:17] RoanKattouw: Right now we have rev_fileprops_id in mw_revision. And mw_file_props has _key, _value_int and value_string [22:17:07] that would allow for authors (either wiki user by id, or non-wiki author by name) [22:17:18] but not for attribution or url [22:18:34] so instead of adding _string2 and string_3... [22:18:59] Bryan thought it'd be a good idea to bring back the authors table from the Hackathon back to the table [22:19:25] so we only need _int and _key (which links to authors table or license table respectively) [22:20:13] authors table would basiclaly have a primary auto-increment and combination of the author_id, author_name, author_attribution, author_url is forces unique in mysql [22:20:28] forced* [22:20:39] so that there are no duplicates. [22:20:50] // end of summary [22:21:31] author_id would be better named "author_user" (which is NULL if author is not a wiki user) [22:21:37] author_id being the primary auto increment [22:21:48] Ah wait [22:22:00] So you've got auto increment on aut_id and unique on (name, attr, url) ? [22:22:15] (Cause having unique on (primary key, other stuff) doesn't make sense) [22:22:27] auto incrment on aut_id and unique on (user, name, attr, url) [22:22:37] OK [22:23:27] The most common case would have name, attr and url empty and only author_user with a user_id [22:23:54] name (nickname), attribution (real name) and url (userpage url) can be filled during the parsing to keep things flexible [22:24:11] like we discussed in the hackathon [22:24:23] if you see no major flaws I'll go ahead and write it down like that [22:24:42] Seems fine [22:24:53] Kinda depends on what kinds of crazy stuff we allow through the UI [22:25:20] Like do we want to allow user ID plus alternate nickname, that kinda stuff [22:26:07] UI would allow author, attribtion and url. if author is found in user table, store userid, in author_user, otherwise NULL and store string in author_name [22:30:31] OK [22:31:00] So it's either 1773,NULL if I use 'Catrope' and 0/Roan if I use 'Roan' , right? [22:31:06] (Assuming my user ID is 1773) [22:31:17] Yes [22:31:49] But you could enter Catrope as user and "Roan Kattouw" as attribution. [22:32:10] or if you have it in Special:Preferences let it fallback to your 'real name' setting [22:34:07] OK but we would allow one user to 'be' multiple authors then [22:34:44] we would one uploader to upload images from more than 1 author (including himself) [22:34:53] ie. upload something from Flickr [22:35:04] Right [22:35:20] But they'd have more than one author associated with their user ID, right? [22:35:24] Or could have [22:35:52] Well if I type Flickrname in author field author_user will be null and author_name will be "Flickrname" [22:35:59] OK [22:36:20] So it's not possible to have 1773,Catrope AND 1773,Roan ? (for userid,name) [22:36:22] unless the flickr user is a wiki user, in which case it's as if I upload images from you, which seems like a fair use case [22:36:36] RoanKattouw: No that would probably not be possible [22:36:40] shouldn't, right ? [22:36:42] OK, cool [22:36:48] (to allow easy username change) [22:36:51] Yeah otherwise the author table could get very cluttered [22:37:00] cool [22:37:03] pdhanda: I can't find those dumps, so I'll just regenerate them [22:39:04] pdhanda: Oh, never mind, found them. They were on the toolserver. [22:39:05] RoanKattouw: thanks [22:39:10] oh ok [22:39:18] I'll copy them to prototype [22:39:32] can you put them somewhere on prototype? [22:39:36] heh thanks [22:40:14] RoanKattouw: TrevorParscal: alolita: pdhanda: you feel like we still need to do the scrum meeting today (since we had our marathon checkin)? [22:40:35] (we can probably just check in via IRC, methinks) [22:40:37] pdhanda: Huh AND they were in my prototype home dir too, glanced over them. Copying them to a saner place [22:40:52] robla: Fine by me [22:41:35] pdhanda: /srv/org/wikimedia/prototype/exports/2011Jan [22:47:03] RoanKattouw: thanks [22:51:37] RoanKattouw: http://www.mediawiki.org/wiki/Talk:Files_and_licenses_concept#Authors_2056 [22:53:06] (refresh for pre-space fix) [22:56:10] RoanKattouw: I wonder if the API is fast enough to do autocomplete/suggest for usernames. Should be fine, right ? [22:56:28] Sure [22:56:35] k [22:56:36] API's also used for autosuggest for search [22:56:52] yeah but wasn't sure about the indexes in mw_user [22:57:08] You [22:57:15] yes, me. [22:57:15] I think you can do prefix searches on user_name [22:57:24] :D [22:57:29] k [22:57:44] *Krinkle tries on toolserver [22:57:53] CREATE UNIQUE INDEX /*i*/user_name ON /*_*/user (user_name); [22:57:57] Yup [22:58:27] ~$ sql commonswiki_p "SELECT * FROM user WHERE user_name LIKE 'Krin%' LIMIT 20" [22:58:36] snaps in a few miliseconds [22:59:20] There's probably an auprefix param in list=allusers [22:59:43] I'm not sure but there's *from, which can be used like that iirc [23:00:22] Sort of [23:00:40] Except it'll happily list Rob after Roan even if you set aufrom=Roa [23:00:51] yeah :D [23:00:54] So it doesn't actually quite obey the prefix [23:00:55] but there's auprefix I see [23:00:57] Yeah, you kinda need a unique index there. ;-) [23:01:01] Cool [23:01:04] Yes [23:01:08] http://www.mediawiki.org/wiki/API:Query_-_Lists#allusers_.2F_au [23:01:08] Always page on a unique index [23:01:18] *RoanKattouw glares at various things in MW that page by things like timestamps [23:01:45] undelete and oldimage ::rolleyes:: [23:01:59] pagehistory :O [23:02:27] But in pagehistory it makes sense due to importing revisions [23:02:46] CategoryPage pages by sortkey [23:02:46] eventhough some revisions can't be seen if there's more reivions than limit in 1 second. [23:02:50] Instead of sortkey|pageid [23:05:55] RoanKattouw: Could you perhaps review http://www.mediawiki.org/w/index.php?title=Manual:Short_URL/wiki/Page_title_--_no_root_access&oldid=372820&diff=cur sometime later ? it changs a little in the existing source that has been like that for quite some time (find it hard to believe it was wrong, but perhaps this way it's "better") [23:06:19] the "/?" in front of the rewriterule [23:06:27] I understand next to nothing about RewriteRules [23:06:31] All my short URL setups use Alias [23:06:45] Ah, me neither :D [23:07:40] Also you may wanna add [[mw:License_integration_MediaWiki/Tasks]] to your watchlist [23:08:26] Done [23:45:07] nn