[09:23:40] <Tanvir>	I just deleted wiki.png in bnwiki. Because it was the previous logo (before vector implemented) and it has a copy on Commons. Do I need to reupload wiki.png with the new logo?
[09:25:12] <Tanvir>	I see no problem yet.
[09:36:01] <Tanvir>	Note: Got the solution on #mediawiki.
[19:08:09] <vvv>	If I am going to load a JS from a foreign wiki, should I load its text and add it to ResourceLoader or add a direct <script> on it?
[19:08:21] <vvv>	The earlier method requires a hack
[19:08:50] <RoanKattouw>	You can do mediaWiki.loader.load( 'http:// .... ' )
[19:09:02] <vvv>	RoanKattouw: in JS code?
[19:09:05] <RoanKattouw>	Yes
[19:09:17] <RoanKattouw>	I think Trevor wanted to separate URL loading from load() though, not sure if that has been done already
[19:09:20] <vvv>	How do I do it on server site?
[19:09:24] <RoanKattouw>	(I'm like 600 revs behind on SVN)
[19:09:32] <RoanKattouw>	Just create a module with that line as its contents? :)
[19:10:08] <RoanKattouw>	You can also add a direct <script>, but that way other modules can't depend on it
[19:10:11] <RoanKattouw>	And it'll be loaded last
[19:10:19] <vvv>	Hm, how do I list mediaWiki.loader as a dependancy?
[19:10:37] <RoanKattouw>	No need
[19:10:44] <RoanKattouw>	Your module will be loaded *by* mediaWiki.loader
[19:10:51] <RoanKattouw>	So it's definitely gonna be around
[19:11:16] <vvv>	If it is a user JS, should it be at the beginning or at the end?
[19:11:29] <RoanKattouw>	If what is a user JS?
[19:11:38] <RoanKattouw>	The JS you're loading? Or just in general?
[19:11:43] <vvv>	JS I'm loading
[19:12:09] <RoanKattouw>	Oh you're doing the global common.js thing
[19:12:13] <vvv>	Yep
[19:12:18] <RoanKattouw>	Maybe you wanna add that to ResourceLoaderUserModule
[19:12:21] <RoanKattouw>	Which loads the local user JS
[19:12:34] <vvv>	It depends upon reading JS page itself
[19:12:40] <vvv>	On the local wiki
[19:12:49] <vvv>	Reading a page on a foreign wiki is a real mess
[19:13:27] <RoanKattouw>	Ah yes
[19:13:31] <RoanKattouw>	So maybe
[19:13:57] <RoanKattouw>	You can create a module ('globaluser' or something) that loads the global user JS only if it lives on that wiki locally
[19:14:14] <RoanKattouw>	I.e. it only works on meta / home wiki / wherever and returns empty everywhere else
[19:15:08] <RoanKattouw>	Then from... somewhere (not sure where yet) you can call http://where.this.stuff.lives/w/load.php?modules=globaluser&otherparams
[19:15:53] <vvv>	RoanKattouw: what's the difference between modules=globaluser and action=raw&ctype=text/javascript if it loads one module anyway?
[19:16:12] <RoanKattouw>	Minification
[19:16:17] <RoanKattouw>	Loading of JS and CSS in one go
[19:16:36] <vvv>	JS and CSS in one go?
[19:16:40] <vvv>	How's that?
[19:17:11] <RoanKattouw>	mediaWiki.loader.implement( 'modulename', function() { code here }, 'CSS string here', { 'i18nmessage1': 'value1', .... } );
[19:17:17] <RoanKattouw>	That's what load.php generates when you ask it for a module
[19:17:41] <RoanKattouw>	You can use &only=scripts (or styles, messages) to get only one part
[19:17:46] <vvv>	Doesn't that make browsers cry and be slow?
[19:18:03] <RoanKattouw>	How so?
[19:18:14] <vvv>	Because of amount of JS to be parsed
[19:18:27] <RoanKattouw>	It's all loaded after document ready
[19:18:36] <RoanKattouw>	So it may take time but won't noticeably slow down the page
[19:18:42] <RoanKattouw>	Because it'll already have loaded
[19:19:01] <vvv>	So vital CSS is still served by means other than resource loader?
[19:19:16] <RoanKattouw>	It's served by load.php?modules=vector&only=styles
[19:19:27] <RoanKattouw>	Which returns the CSS the 'normal' way, with Content-Type: text/css and all
[19:19:34] <RoanKattouw>	But it does automatically flip for RTL, for instance
[19:19:44] <vvv>	How clever
[19:19:46] <RoanKattouw>	If you pass &lang=ar or &lang=he
[19:19:55] *vvv 	loves ResourceLoader
[19:20:46] <RoanKattouw>	It gets better
[19:20:55] <RoanKattouw>	The 'user' module contains special logic
[19:21:03] <RoanKattouw>	It assumes that people on arwiki will write their scripts to assume RTL
[19:21:11] <vvv>	Is minification done within PHP?
[19:21:14] <RoanKattouw>	Yes
[19:21:25] <vvv>	I hope it's cached?
[19:21:39] <RoanKattouw>	So if the content language and user language are both RTL, it doesn't flip CSS. It only does that if user language is one and content language is the other
[19:21:43] <RoanKattouw>	Yes, it's cached in memcached
[19:21:56] *vvv 	loves ResourceLoader even more
[19:21:58] <RoanKattouw>	Or, per a very recent rev by Tim, in wfGetCache( CACHE_ANYWHERE )
[19:22:07] <RoanKattouw>	So initial page loads right after upgrading are slow
[19:22:21] <RoanKattouw>	Because minifying jQuery and the mediaWiki library (with the loader and such) takes like 2 seconds
[19:22:37] <RoanKattouw>	*CACHE_ANYTHING
[19:23:17] <RoanKattouw>	Oh and
[19:23:22] <RoanKattouw>	One last thing before I have to go
[19:23:28] <RoanKattouw>	ResourceLoader does data URL embedding in CSS
[19:23:35] <vvv>	I noticed
[19:23:49] <vvv>	If a user is a JS developer and wants to debug his Wikipedia userscript, is there a way to disable minification?
[19:23:53] <RoanKattouw>	That's one of the things that makes a serious difference
[19:23:57] <RoanKattouw>	?debug=true URL param
[19:24:06] <RoanKattouw>	Disables almost all RL cleverness
[19:24:10] <vvv>	To any script?
[19:24:11] <RoanKattouw>	Except essentials
[19:24:15] <RoanKattouw>	No, just to the page
[19:24:25] <RoanKattouw>	And for JS it'll load the original files
[19:24:46] <RoanKattouw>	For CSS it won't, because RTL flipping is needed, but I think it still loads each module in a separate request
[19:25:20] <RoanKattouw>	There's also a cookie you can set (by hand, for now) to enable debug mode, and there's $wgResourceLoaderDebugMode
[19:25:27] <vvv>	Does it preload wikibits etc for user scripts? Did you test compatibility of most popular gadgets with it?
[19:26:01] <RoanKattouw>	It loads user scripts and all old things (such as Gadgets, which hasn't been ported in trunk (there's a branch by MaxSem for that)) after RL-ified things have loaded
[19:26:19] <RoanKattouw>	So everything that's RL-ified is loaded before everything that's non-RL
[19:26:24] <RoanKattouw>	And wikibits is an RL module now
[19:26:34] <RoanKattouw>	We have not tested Gadget compat, no
[19:26:57] <RoanKattouw>	But since trunk/extensions/Gadgets is not RL-ified (yet) I don't think it should break anything
[19:27:12] <vvv>	RoanKattouw: I mean specific gadgets
[19:27:17] <RoanKattouw>	I know
[19:27:30] <RoanKattouw>	I shouldn't be possible for those to break due to RL
[19:27:32] <RoanKattouw>	But we haven't tested
[19:27:35] <RoanKattouw>	OK I really gotta go now
[19:27:41] <vvv>	OK, bye
[21:56:44] <vvv>	RoanKattouw: how do I get non-null $context->getUser() for a module?
[22:02:37] <vvv>	// Special handling for user-specific groups
[22:02:37] <vvv>	            if ( ( $group === 'user' || $group === 'private' ) && $wgUser->isLoggedIn() ) {
[22:02:40] <vvv>	Hehe
[22:12:42] <RoanKattouw>	Don't trust $context->getUser(), use $wgUser
[22:12:48] <RoanKattouw>	I don't know why Trevor put that in, it's useles
[22:12:50] <RoanKattouw>	s
[22:12:55] <RoanKattouw>	AFAICT
[22:49:11] <vvv>	Would anyone mind if I throw out the "there is no skin warning" on editing any non-skin CSS?
[22:49:53] <RoanKattouw>	vvv: Maybe keep it if strtolower( what they're trying to do ) == strtolower( some existing skin ) ?
[22:50:47] <vvv>	RoanKattouw: I'm not exactly sure what's point of it, especially if we now do the CSS links in preferences
[22:51:41] <RoanKattouw>	Well it seems to be targeted towards people using /Monobook.css
[22:51:50] <vvv>	Are there?
[22:51:59] <RoanKattouw>	Or trying to create it, I should say
[23:12:50] <vvv>	RoanKattouw: how would I load CSS from the client side?
[23:13:58] <RoanKattouw>	You're trying to load CSS from a remote wiki page?
[23:14:03] <vvv>	Yep
[23:14:19] <RoanKattouw>	How are you currently loading JS?
[23:15:30] <vvv>	return "mediawiki.loader.load( '{$url}' )";
[23:15:39] <RoanKattouw>	Ah, yes
[23:15:42] <RoanKattouw>	OK so
[23:15:59] <RoanKattouw>	You can take a unified approach that'll require you to change that, but it'll be nicer overall
[23:16:18] <RoanKattouw>	Actually I think you may be able to keep that part
[23:16:21] <RoanKattouw>	What's $url in this case?
[23:16:56] <RoanKattouw>	Something with action=raw&ctype=text/javascript or something more RL-y?
[23:17:09] <vvv>	The earlier
[23:17:25] <vvv>	The latter is not used because I cannot be sure the user is logged in on Meta
[23:19:08] <vvv>	Btw, that does not seem to work
[23:19:22] <RoanKattouw>	Damn, of coures
[23:19:30] <RoanKattouw>	What doesn't, the .load() call?
[23:19:35] <vvv>	Yep
[23:19:49] <vvv>	Ah
[23:20:17] *vvv 	replaces mediawiki with mediaWiki
[23:20:21] <vvv>	Ok, works now
[23:20:32] *RoanKattouw 	suggests escaping $url for JS if not already done
[23:20:51] <RoanKattouw>	Actually, there's a function to build a JS call somewhere, Tim wrote it to ensure security
[23:21:23] <RoanKattouw>	Xml::encodeJsCall()
[23:21:51] <RoanKattouw>	Xml::encodeJsCall( 'mediaWiki.loader.load', array( $url ) );
[23:23:43] <vvv>	So, I can load CSS with the same method?
[23:24:25] <RoanKattouw>	There is a similar function for it, I think
[23:25:10] <RoanKattouw>	Hm all we have is mediaWiki.util.addCSS( CSSstring )
[23:25:31] <RoanKattouw>	Thing is, adding a dynamic <link rel="stylesheet" src="foo"> doesn't work in all browsers
[23:25:45] <vvv>	Can I use CSS import?
[23:25:48] <RoanKattouw>	Instead, you have to fetch the CSS using AJAX or something, then add a <style>
[23:25:52] <RoanKattouw>	Oh, that's brilliant
[23:25:57] <RoanKattouw>	That might actually work too
[23:26:27] <RoanKattouw>	mediaWiki.util.addCSS( "@import 'my URL'" );
[23:26:36] <RoanKattouw>	No idea if it'll work on older browsers, but it's definitely worth a shot
[23:28:38] <vvv>	RoanKattouw: if I add it to the top, it would most probably work
[23:29:06] <RoanKattouw>	'to the top'?
[23:30:29] <vvv>	"In CSS 2.1, any @import rules must precede all other rules (except the @charset rule, if present)."
[23:30:43] <RoanKattouw>	Is that per-stylesheet?
[23:30:54] <vvv>	I'm not sure
[23:31:03] <RoanKattouw>	Like, would <style>@import foo</style> placed at the end of the <head> work?
[23:31:18] <RoanKattouw>	Well @charset most certainly is per stylesheet, so I would think so
[23:31:28] <RoanKattouw>	Actually, I'm quite sure it'll work
[23:31:32] <RoanKattouw>	UploadWizard uses @import
[23:37:08] <vvv>	RoanKattouw: I think I'll use both $wgUser and $context->getUser() so I can use load.php insead of ctype=text/css
[23:37:54] <RoanKattouw>	$context->getUser() is checked against $wgUser beforehand,r ight?
[23:38:17] <RoanKattouw>	Or wait
[23:38:25] <RoanKattouw>	You want to tackle the "user is not logged in on remote wiki" issue
[23:38:31] <vvv>	Yep
[23:38:40] <RoanKattouw>	Yeah in that case you can use the user ID to serve that user's global JS, as long as that's public data
[23:38:50] <RoanKattouw>	Don't do the same thing in user.options please ;)
[23:39:16] <RoanKattouw>	Using load.php also allows you to put the CSS in with the JS
[23:40:17] <vvv>	By appending mediaWiki.util.addCSS to the generated JS?
[23:40:28] <RoanKattouw>	No
[23:40:33] <RoanKattouw>	By implementing your own module class
[23:40:56] <RoanKattouw>	I think you only need to implement getScript() (to return a JS string) and getStyle() (to return some weird array structure with CSS in it)
[23:41:36] <RoanKattouw>	Then you can do remotewiki/load.php?modules=globaluserstuff&user=123
[23:41:46] <RoanKattouw>	And that'll return that mediaWiki.implement ( .. . ) thing I talked about
[23:41:52] <RoanKattouw>	I'll execute the JS and load the CSS
[23:41:57] <RoanKattouw>	*It'll
[23:42:38] <vvv>	Sounds cool
[23:43:11] <vvv>	Is there a difference between addModules and addModuleScripts + addModulesStyles?
[23:43:59] <RoanKattouw>	Yes
[23:44:14] <RoanKattouw>	addModuleScripts() adds a <script> that only grabs the JS of the module, not the CSS or i18n
[23:44:30] <RoanKattouw>	addModuleStyles() adds a <link> that only grabs the CSS
[23:44:47] <RoanKattouw>	addModules() adds a <script> that gets the entire module (JS, CSS and i18n)
[23:45:08] <RoanKattouw>	So the first two correspond to the &only= parameter I told you about earlier (about 4.5 hours ago)
[23:45:53] <vvv>	Why certain modules (i.e. user) are grabbed by first two functions?
[23:46:42] <RoanKattouw>	I don't know why it's done for user exactly
[23:46:49] <RoanKattouw>	It is typically done for skin styles
[23:46:57] <RoanKattouw>	Which we kinda want to be available even if there's no JS
[23:47:08] <RoanKattouw>	Cause addModules() uses JS to load and add the CSS
[23:47:22] <RoanKattouw>	Maybe that's done for user CSS for the same reason