[00:00:55] *Ashlee gives jorm some more tea. [00:00:59] I read some of your blog today. [00:01:05] My Internet was dead and the page was open. [00:01:19] i've been drinking tea constantly the past couple days, being sick and all. [00:03:46] i don't even remember what the current stuff on my blog is. [03:32:49] I read about Priyanka's card games and your review of Inception. [03:33:00] And something about you hating the mentally disabled. [03:33:16] that sounds like me. [03:36:03] we must have a mole in the office [13:53:31] Heh I see Ryan was asking for the MySQL root password yesterday [16:59:22] RoanKattouw? [16:59:43] Yes? [16:59:59] there is a thing where the feedback tool is showing up on diff pages. [17:00:09] i thought i'd handled that with the 'view' bit. [17:00:31] but i guess not. it only shows up on the second page of diffs, which is weird. [17:01:05] The first has action=historysubmit [17:01:14] Best way is probably to do this JS-side [17:01:19] Detect the presence of #whatever [17:03:54] jorm: table.diff is the telltale selector [17:05:08] wait. it's going to be easier to do on the js side? [17:05:45] Yes and no [17:05:49] What you did is good [17:05:56] But it needs to be supplemented ont he JS side [17:06:01] right. but how come it doesn't catch the diffs? [17:06:32] Because those are also action=view [17:06:43] *jorm screams. [17:06:45] I guess we could detect the &diff param too but meh [17:06:55] yeah, that's what i am going to do. [17:07:15] we're doing all the detection for when to place it on the server side; i'd prefer not to pollute that. [17:07:28] OK go ahead then [17:18:20] adam_miller, Reedy: we're going to 2002 [17:20:21] adam_miller: That's a very weird POST response ^^ anon or logged in? [17:21:26] anon [17:21:28] adam_miller: Could you try hard-refreshing the page with the rating widget on it and try again? [17:21:31] WFM as anon [17:21:49] Getting the same response but with Thank you blah blah in i [17:24:38] still not working for me [17:27:09] RoanKattouw: http://i51.tinypic.com/1417bm0.png [17:27:22] that's what it's posting....anything look odd there? [17:27:48] Wait, there's a token. [17:27:50] Blegh [17:28:01] I'm CSRFing something that has CSRF protection :( [17:28:43] Or wait [17:28:52] That's probably not the problem either [17:29:13] hi RoanKattouw [17:29:16] how's it going? [17:29:18] Morning Trevor [17:29:28] Well I injured a few fingers in a bike crash [17:29:43] <^demon> RoanKattouw: See what happens when you go outside? [17:29:58] I was coming up on a turn, squeezed the brake, and the cable between the brake handle and the rear wheel brake broke [17:30:01] So it didn't brake [17:30:51] is it causing you pain/slowness when typing? [17:31:03] Then I panicked and engaged the front wheel brakes while the front wheel was already in the turn, so I toppled over [17:31:51] A bit, yeah [17:32:07] The injuries are on 3 knuckles of my left hand and the palm of my right [17:33:00] So no direct typing hindrance except for the band-aids around my knuckles [17:33:16] thats no fun [17:34:10] Nope [17:34:31] Try doing stuff like putting on clothes and pulling out your wallet with 7 fingers [17:34:47] RoanKattouw: has danese talked to you about letting me borrow your slides from wikimania? [17:35:02] She has not [17:35:05] ah ok [17:35:10] can I borrow your slides? :D [17:35:13] But they're CC-BY-SA so borrow all you like [17:35:16] cool [17:35:32] I'm giving your talk in kyoto [17:35:45] it'll likely be shorter, since it needs to be translated inline [17:36:48] Kyoto? [17:37:03] kansai open forum conference [17:37:44] they wanted a keynote from us on ops stuff, and danese agreed as long as we can also give a talk on getting an extension accepted [17:37:58] adam_miller: Could you try again and pastebin the result again please? Added some var_dump()s and a die() in one code path [17:38:04] OK [17:38:44] You're free to use and modify my slides to your heart's content as long as they remain under CC-BY-SA [17:38:54] that they will [17:38:54] You're also free to ask for advice at any time :) [17:39:03] I'll be doing that ;) [17:39:07] When is this talk? [17:39:13] November [17:39:24] RoanKattouw: three an error [17:39:24] uncaught exception: Syntax error, unrecognized expression: "articlerating" bool(true) bool(false) AAAARGH [17:39:27] I'm doing a dry run in the office before I leave [17:39:52] adam_miller: Thanks [17:39:59] Cool [17:40:08] As in, in a few weeks? [17:40:16] a couple weeks, yeah [17:41:13] this entire twitter hack bug makes me laugh my ass off. [17:41:21] twitter hack bug? [17:41:23] What's that? [17:41:24] because it's pretty amateur hour crap. [17:41:37] are my twitters in danger? oh noes [17:41:50] so, if you go to the website, there was a thing where when you hovered over a link, it would do . .. something. [17:41:59] (statusnet with twitter importer enabled is not vulnerable, btw ;) [17:42:08] but someone figured out that twitter wasn't escape for onmouseover firing events. [17:42:25] *hint* *hint*, *knudge* *knudge* [17:42:39] so they were putting links up that included javascript, which was getting fired when people moused over the links, which then did shit like open popup windows. [17:44:05] what makes me laugh about this is that i know one of their tech heavies, and he's always been an insufferable prick about this type of bug. he'd literally send out multi-page screeds to people i know who had cross-site scripting vulnerabilities, etc, calling them dumbasses, etc. [17:44:18] adam_miller: Again? (sorry) [17:44:34] they must have handed the new UI to some intern to do :D [17:44:57] RoanKattouw: uncaught exception: Syntax error, unrecognized expression: "57517f90edb060ea8f6e5698150923da" NULL [17:45:18] Grr [17:45:44] since we only allow people to answer the survey once, we shoudl make sure the "leave feedback" link goes away if they've answered it. [17:45:53] he interjected. [17:45:58] OK [17:57:57] ^demon|away: ping [17:58:50] OK for some reason Nimish's $_SESSION code isn't working [17:59:18] is it because the session is from the squids and not the user? [17:59:27] RoanKattouw: ^^ [17:59:36] No, special pages skip Squids [17:59:40] It works for me but not Adam [17:59:50] And I think it's because Adam doesn't have an initialized session [18:05:35] TrevorParscal: Oh BTW, what was up with killing UI.php first, *then* eliminating dependencies? *grr* [18:05:42] SimpleSurvey included it so it broke [18:05:58] Wasn't very difficult to eliminate that dependency but you also removed all kinds of jQuery UI stuff that it depended on [18:06:11] Granted, it shouldn't have depended on that in the first place [18:08:45] alolita1: Did the meeting start yet? Are we gonna do something creative to get me in or shall I just continue prepping the dark launch? [18:08:59] RoanKattouw, we're starting [18:09:02] we're in x2002 [18:09:16] My phone's broken, has been since last week [18:09:23] want me to skype you in? [18:09:27] roan: we 're on x2002 [18:09:28] Rob thinks Jeff and Jon messed this up when they changed the network last week [18:09:46] Then of course they did the 'prefix with 6' thing without telling any non-staff folks :( [18:09:49] guillom: Please [18:09:53] ok [18:10:21] RoanKattouw, call guillaumepaumier (I don't have your ID) [18:10:34] I'm roan.kattouw, for future reference [18:10:37] ok [18:11:53] RoanKattouw, working fine? [18:12:04] Yeah [18:12:06] ok [18:12:09] Muting cause of TV and jitter [18:20:44] OK Skype dropped the call and guillom went offline on Skype [18:23:59] jorm, jorm2: Assuming one of you is looking at this while in the meeting: my call dropped, and apparently Guillaume's connection dropped too [18:24:12] I AM ALWAYS LOOKING [18:24:33] what's up? [18:25:04] Well, as you may have heard, my call got dropped [18:26:03] yeah. [18:26:40] Which seems to be due to Guillaume's connection dying, cause Skype said he went offline about 10 seconds later [18:26:43] And he timed out on IRC just now [18:27:05] I would call back in if I had the means to :) [18:27:39] i think we've moved on. it's fine. [18:27:47] we're into talking about the media upload wizard now. [18:28:56] Oh OK [18:29:14] If there's any questions for me, let me know [18:29:21] I'll be poking at that dark launch now [18:30:49] rock on. [18:35:02] Article Feedback Tool? [18:35:06] It's been renamed ALREADY? [18:35:44] Yeah, it was renamed last week. [18:35:55] No one tells me anything! [18:35:57] *Reedy grumbles [18:36:09] wait, i thought we sent out a thing about that. [18:36:47] Not that I've seen.. [18:37:05] Are we svn mv'ing it? [18:37:38] not that i believe. [18:38:24] NO WE ARE NOT [18:38:28] Not this week at least [18:38:29] Haha [18:38:33] it's kind of a PendingChanges/FlaggedRevs bit. [18:39:31] we went with Article Feedback Tool for a chunk of reasons. [18:40:32] 1) there's already a "Reader Feedback" tool. 2) The PPI is calling their tool "Article Assessment". [18:40:38] even though it's not really a tool. [18:41:32] *Reedy shrugs [18:43:56] <^demon> jorm: Pong [18:44:23] do you have a rather "iconic" image of DC for me? [18:45:12] <^demon> I don't have any, nope. [18:45:22] <^demon> Anything with the Washington Monument is pretty recognizable, though. [18:47:50] yeah. . . the problem with the washington monument is pretty much the entire "here's a giant penis" thing. [18:47:55] but i'll see what I can't do. [18:48:18] hahah [18:48:24] "Washington DC firefighter investigated after naked cooking photos ..." [18:48:26] Thanks google [18:48:40] <^demon> jorm: I don't know anyone who has a penis with a square base to it :p [18:51:08] RoanKattouw: when we turned clicktracking on for the sidebar, were there weird performance issues? [18:51:14] because I think there may have been [18:51:39] I... don't think so [18:55:39] ok, RoanKattouw so if I turned it on on Special:AccountSignup or whatever that page is called, it wouldn't slow things down significantly? [18:56:01] Special:UserLogin? [18:56:09] Or Special:CreateAccount? [18:56:35] That should be fine [18:56:42] As long as you don't do it this week :) [19:01:57] There's no CreateAccount on WMF wikis. [19:01:58] it's both Special:UserLogin, but only if they're trying to create an acct =) we want to see what those rates will be [19:02:00] That's a separate extension. [19:02:09] Special:UserLogin?type=signup [19:02:28] Ashlee, are you sure? I remember using Special:CreateAccount recently [19:02:37] Fairly sure. :-) [19:02:40] ok [19:02:49] Ah, it's a redirect. [19:03:01] oh, ok [19:05:19] Ah, I'm thinking of the RequestAccount extension. [19:06:45] RoanKattouw: action=parse is broken? [19:07:16] Disabled by Tim [19:07:28] See #wikimedia-tech topic, mediawiki-api mailing list post and server admin log [19:07:35] Oh and Ashlee filed a bug [19:07:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=25238 [19:48:51] Oh this is funny [19:49:01] I'm gonna enable AA on testwiki while ReaderFeedback is still running there [19:52:21] jorm: The rating tool appears /above/ the categories box. Is this by design? [20:07:56] yes, that is by design. [20:08:47] RoanKattouw, jorm: The "Submit" button is no localized, even a message 'articleassessment-survey-submit' exists: http://test.wikipedia.org/wiki/Main_Page?uselang=de [20:12:00] RoanKattouw: hey- i'm back from lunch [20:12:34] sorry about doing things with UI.php in a strange order - I sent emails out about my changes suggesting people use the release branches of UI stuff [20:13:14] Raymond_afk: That's because you're using uselang, I'm afraid. Change your language pref and it should work [20:13:27] Yeah I kinda missed all of those :( [20:13:33] Either way, that's all cool now [20:13:37] And AA is up on testwiki, yay! [20:13:59] RoanKattouw: did you get that weirdness i was seeing patched up? [20:14:26] Nope [20:15:58] RoanKattouw: this link is for you only. my user preference language _is_ 'de' already [20:16:17] Now I do have to get Domas or Tim to tell me how I'm gonna pull off an ALTER TABLE on a 147k-row table :( [20:16:21] Raymond_afk: OK, will poke [20:16:35] RoanKattouw: don't hurry. not very important for the moment [20:16:51] Raymond_afk: It might be using prefswitch's submit message instead [20:16:58] Are all other messages localized? [20:17:49] RoanKattouw: yes, looks ok for all other messages [20:18:18] Meh and I need to fix up some messages in TWN too [20:18:31] Old syntax -> new syntax [20:28:33] actually, it looks like it has written directly via javascript. [20:28:46] ? [20:29:10] the submit button. [20:29:45] [20:30:08] Oh please God no [20:32:24] looking at it. [20:39:20] goddit. [20:39:25] i'll have a submitted fix in a second. [20:40:36] committed. [20:41:10] Thanks [20:41:28] Did you use the/an existing message? [20:42:06] yup. [20:42:09] check the diff. [20:42:28] adam just wasn't applying the localization system to it. that's all. [20:42:36] OK [20:51:15] OK so remaining issues are the token edge case that Adam ran into and the persistent feedback link thing [20:53:29] i'm not familiar with the edge case. [20:53:36] jorm: When a user has already filled out the feedback survey successfully in the past, should the feedback link stay hidden using a cookie? Similarly, should the ratings be shown rather than hidden by default when you've already rated the article? [20:53:57] yes to both. [20:54:04] OK [20:54:27] but the second one can't be cookiefied; it has to be done if the js gets ratings. [20:54:34] adam_miller: Please either implement those things before noon EDT tomorrow or send me an e-mail passing the buck [20:54:36] Yes [20:54:49] RoanKattouw: what things? [20:54:54] The edge case is that the survey submission fails if you're an anon without a session cookie [20:55:09] adam_miller: My longish text addressed to jorm, right above "yes to both" [20:55:20] I will poke at that edge case tomorrow [20:55:32] the latter is done [20:55:37] i'll do the former now [20:55:57] Thank you [20:56:08] jorm, adam_miller: You guys are awesome [20:56:11] i'm still seeing the ratings behavior. [20:56:50] You guys may want to know that we're already running on test now [20:56:55] (The PPI folks know this too) [20:56:59] i think it's just a one line fix. [20:57:00] jorm: not yet committed [20:57:05] ah. [20:57:10] trying to do it all in one commit [20:57:17] svnup before you commit, because i made a commit to the js file. [20:59:45] what'd you change? [21:00:25] add localization for the submit button. [21:00:29] 3 lines of code. [21:00:56] errr. 4 [21:04:05] roankattouw: coolness. do you just flip the switch (er... config file) for en.wp tomorrow [21:04:28] Yes [21:04:34] After I get some last-minute fixes and translations in [21:04:53] One of those fixes I'll have to code during my commute tomorrow [21:05:20] roankattouw: you're awesome :-) what last - minute fixes do you have to do on your commute [21:06:08] The survey submission barfs if you're an anon without a session cookie [21:06:15] I never noticed but Adam happened to hit that when testing [21:06:47] RoanKattouw: ok - the problem that Adam was talking about earlier [21:07:21] Yeah [21:07:44] Oh and we're live on test.wp.org already [21:07:49] With said bugs of course [21:08:01] Barfs? [21:08:09] Well it doesn't barf badly [21:08:10] Surely the API goes "lolnomissingparam"? ;) [21:08:19] It just doesn't print the success message [21:08:25] Reedy: hey sam! nice to see you [21:08:29] There's no API involved here, I'm doing evil screenscraping :( [21:08:31] well online [21:08:49] *Reedy glares at RoanKattouw [21:08:59] alolita1, i'm often online. sometimes... [21:09:10] :) [21:09:12] screenscraping ... (eek) [21:09:19] heh [21:09:33] Roan and I have had numerous discussions about this topic [21:09:43] I'm one of the most prolific opponents of screenscraping [21:09:52] Yet I find myself doing it [21:09:57] So, I'm fairly sure there will be a "good" reason to do it [21:10:09] There's a reason, not a good one [21:10:15] Which is lack of time and ease of implementation [21:15:24] RoanKattouw: are you thinking lots of ESI thoughts and dreaming ESI dreams? [21:16:06] *Reedy distracts TrevorParscal with Pizza [21:16:50] *TrevorParscal starts eating and forgets about ESI [21:16:54] I'll have nightmares of falling off my bike while deploying AA [21:17:02] *RoanKattouw just got the bandaids changed [21:17:41] *TrevorParscal continues eating pizza [21:17:43] RoanKattouw, jorm: just committed all my Article feedback changes [21:18:20] Thanks [21:18:45] adam_miller: thanks [21:18:46] I just heard I'm gonna be home two hours early tomorrow, so the AA deployment should work out just fine [21:18:56] Time? [21:19:08] roankattouw: cool - what time? [21:19:26] RoanKattouw: kaldari needs some code review help as well - can we schedule that? [21:19:28] 1:15pm-ish CEST [21:19:45] I'll buy a fire extinguisher in the morning [21:20:17] So that's 3:15am PDT, plenty of time to do the deployment and make kaldari happy, hopefully [21:20:27] TrevorParscal: Not yet. Hoping to get to it tomorrow, if not let's schedule it [21:20:37] k [21:22:01] OK, time for bed. Thanks everyone and good night