[07:19:24] <jorm>	i am out of hello kitty band-aids.  this is a problem.
[07:20:40] <werdna>	oh nooes
[07:20:56] <jorm>	for reals oh noes.
[08:15:15] <EcceNux>	Hi. Is there some quick way to add suggestions to a custom searchbox? We would like to add this on our main new page:
[08:15:16] <EcceNux>	http://pl.wikipedia.org/wiki/Strona_g%C5%82%C3%B3wna/Nowa
[08:25:25] <Ashlee>	You could probably re-use some JavaScript for that.
[18:10:21] <RoanKattouw>	jorm: Can you edit Main_Page five times for me real quick?
[18:10:28] <RoanKattouw>	I'm an anon so I get the damn CAPTCHA every time
[18:10:35] <jorm>	i'm anon, too.
[18:10:42] <jorm>	i fucking hate that captcha.
[18:10:47] <jorm>	but i'll edit for you.
[18:10:50] <RoanKattouw>	Thanks
[18:10:55] <RoanKattouw>	I mean you can log in
[18:10:59] <RoanKattouw>	But I can't, I'll lose my rating
[18:13:48] <jorm>	done.
[18:13:49] <RoanKattouw>	Note BTW that staleness is defined as /more than/ 5 revs (I thought it was >= 5 revs initially)
[18:13:50] <RoanKattouw>	Thanks
[18:14:04] <brion>	haha captcha suckaaaaaaaas
[18:14:20] <jorm>	i'm going to go beg ryan lane to remove it.
[18:14:26] <jorm>	oh. i'll go to 6 revs for you, then.
[18:15:09] <RoanKattouw>	I made one myself
[18:15:16] <RoanKattouw>	You know we can also just create accounts
[18:16:28] <jorm>	yes.  but i, too, have an anonymous rating on there, and want to keep it.
[18:18:48] <RoanKattouw>	OK I'm definitely seeing "stale":"" in the JSON
[18:19:14] <RoanKattouw>						if( data.query.articleassessment.stale ) {
[18:19:20] <RoanKattouw>	Fail
[18:32:41] <RoanKattouw>	jorm: Found and fixed the bug, committing to SVN
[18:40:33] <brion>	heh... http://fundraising.wikimedia.org/ says "foo"
[18:42:35] <Reedy>	brion, you should really stop breaking things :P
[18:42:59] <jorm>	has that fix been deployed to prototype?
[18:43:02] <RoanKattouw>	jorm: Yes
[18:43:09] <RoanKattouw>	You may need to Shift+Refresh though
[18:43:19] <RoanKattouw>	Reedy: Well we took brion 's access away so I guess he's off the blame wheel now
[18:43:32] <Ryan_Lane>	Did we do that yet? :)
[18:43:40] <Reedy>	Well, you reset root password, no?
[18:43:58] <Ryan_Lane>	it takes more than that to take his access away
[18:44:02] <Reedy>	heh
[18:44:12] <Reedy>	it's a step in the right direction..
[18:44:25] <jorm>	and yay! it goes pale.
[18:44:29] <jorm>	thanks!
[18:44:44] <RoanKattouw>	Now let's make it disappear from the edit page
[18:45:19] <RoanKattouw>	TrevorParscal: heh I have your problem now, want to only include a script on a page view as opposed to edit/history/...
[18:45:35] <TrevorParscal>	ha ha
[18:45:36] <Reedy>	hackhackhack
[18:45:55] <RoanKattouw>	$wgRequest->getVal( 'action', 'view' ) == 'view' ? :P
[18:46:14] <RoanKattouw>	Hm oh and the ext only works in NS_MAIN, that needs to be documented too
[18:46:23] <Reedy>	/TODO:Oh fuck it, it displays everywhere, but #cba preventing it
[18:46:44] <RoanKattouw>	?
[18:47:26] <TrevorParscal>	RoanKattouw: do you recall why a wikieditor context's fn.getCaretPosition() is commented saying never call this directly, yet the wikiEditor code calls it directly?
[18:48:16] <TrevorParscal>	my port is breaking because it's saying context.$iframe doesn't exist, and it's breaking at context.fn.getCaretPosition - which should never be getting called cause the iframe is not on...
[18:48:25] <TrevorParscal>	I'm sure this stuff is a bit blury
[18:49:53] <RoanKattouw>	lol that definitely is blurry
[18:50:03] <TrevorParscal>	i think i figured out what happened
[18:50:12] <RoanKattouw>	OK so the never call it directly thing is probably outdated
[18:50:14] <TrevorParscal>	gosh this is allot of code
[18:50:28] <RoanKattouw>	And the functon simply needs to have a textarea mode in addition to an iframe mode
[18:50:39] <RoanKattouw>	This happens when you switch from textarea mode to iframe mode and back in such a huge codebar
[18:50:41] <RoanKattouw>	*codebase
[18:50:49] <RoanKattouw>	And yes, wikiEditor is a /crapload/ of code
[18:51:06] <TrevorParscal>	ok, so there was this thing with the TOC that trigger ready when it was addedg
[18:51:32] <TrevorParscal>	I cleverly moved that to the create function, as the comment hinted should probably be done
[18:51:41] <TrevorParscal>	but now ready seems to be being called prematurely..
[18:54:24] <RoanKattouw>	I have no idea what you're talking about, and frankly, I don't care right now; I'm working on AA :)
[19:04:07] <RoanKattouw>	TrevorParscal: global $mediaWiki; $mediaWiki->getVal( 'action' ) :D not totally evil I guess
[19:04:39] <TrevorParscal>	$mediaWiki?
[19:09:15] <RoanKattouw>	See index.php
[19:49:06] <TrevorParscal>	RoanKattouw: Database returned error "1153: Got a packet bigger than 'max_allowed_packet' bytes (localhost)"
[19:49:16] <TrevorParscal>	MessageBlobStore::updateModule
[19:52:21] <TrevorParscal>	http://img816.imageshack.us/img816/7301/screenshot20100916at125.png
[19:53:48] <TrevorParscal>	this happens when 33 modules are requested
[19:54:11] <TrevorParscal>	but not when only a few are
[19:59:35] <TrevorParscal>	RoanKattouw: ... hello?
[20:12:48] <RoanKattouw>	Oh sorry I'm back
[20:12:54] <RoanKattouw>	OK that's weird
[20:13:05] <TrevorParscal>	ok
[20:13:08] <TrevorParscal>	basically
[20:13:13] <RoanKattouw>	Well what's happening is pretty obvious, what's not is why it's being allowed to happen
[20:13:13] <TrevorParscal>	updateModule
[20:14:48] <TrevorParscal>	it's running 4 times, each time with double the number of $newRows
[20:15:07] <TrevorParscal>	2048, 4096, 8192, then 16384
[20:15:10] <TrevorParscal>	then it bombs
[20:15:17] <TrevorParscal>	because the packet size is too big
[20:15:44] <RoanKattouw>	Wait, why are you getting such a huge number of $newRows
[20:15:48] <RoanKattouw>	That's not normal
[20:16:01] <TrevorParscal>	agreed
[20:16:11] <TrevorParscal>	I'm working on the WikiEditor stuff
[20:16:22] <RoanKattouw>	You sure this isn't $newLinksRows[] instead?
[20:16:50] <RoanKattouw>	Presumably you have a module that contains a crapload of messages?
[20:16:52] <TrevorParscal>	I got that number from adding
[20:16:53] <TrevorParscal>	var_dump( count( $newRows ) ); to line 151
[20:16:56] <RoanKattouw>	Oh
[20:17:14] <RoanKattouw>	That's... shocking
[20:17:36] <TrevorParscal>	each new row is the same thing, too
[20:17:37] <RoanKattouw>	Actually it's theoretically impossible, because it gets rows with mr_resource='something' AND mr_lang=anything
[20:17:42] <RoanKattouw>	Right
[20:17:49] <RoanKattouw>	I think your DB is missing a unique index
[20:17:58] <TrevorParscal>	i ran update
[20:18:13] <RoanKattouw>	OK well
[20:18:16] <TrevorParscal>	how can I purge the message blob store?
[20:18:28] <RoanKattouw>	Can you pastebin the output of the SQL statements SHOW CREATE TABLE msg_resource; and SHOW CREATE TABLE msg_resource_links; ?
[20:18:29] <TrevorParscal>	did you add a script for it, or do I need to do it manually?
[20:18:39] <RoanKattouw>	Did not add a script, no
[20:18:49] <RoanKattouw>	But please don't purge it yet
[20:19:01] <RoanKattouw>	I'm interested in this bug and in the state of your DB
[20:19:58] <TrevorParscal>	http://pastebin.com/KpysgEn8
[20:20:26] <RoanKattouw>	Yup, there's no unique index on msg_resource
[20:20:50] <TrevorParscal>	so if I drop the table and update, I should be fine?
[20:20:55] <RoanKattouw>	Run SELECT COUNT(*), mr_lang FROM msg_resource WHERE mr_resource='the name of the module causing problems' GROUP BY mr_lang
[20:20:57] <RoanKattouw>	yes
[20:21:04] <RoanKattouw>	That last query will illustrate the problem for you :)
[20:21:45] <TrevorParscal>	btw - that query was empty
[20:21:54] <TrevorParscal>	oops
[20:21:58] <TrevorParscal>	i messed it up
[20:22:00] <TrevorParscal>	2048
[20:22:14] <RoanKattouw>	| 2048 | en | ?
[20:22:46] <TrevorParscal>	right
[20:23:10] <TrevorParscal>	fixed
[20:23:13] <TrevorParscal>	tons of fun
[20:24:30] <TrevorParscal>	that was crazy
[20:24:31] <TrevorParscal>	ok
[20:24:33] <TrevorParscal>	thank you!
[20:24:41] <RoanKattouw>	I'm surprised it was as low as 2048
[20:24:53] <RoanKattouw>	That means updateModule() only ran 11 or 12 times
[20:25:11] <RoanKattouw>	11
[20:25:29] <RoanKattouw>	Oh there you go
[20:25:36] <RoanKattouw>	It's only called when the messages array changes
[20:26:38] <RoanKattouw>	Which apparently happened 11 times (that's a lot, what were you doing :P )
[20:28:37] <TrevorParscal>	ok
[20:29:08] <TrevorParscal>	also, someting that triggered it was defining messages incorrectly when creating a ResoruceLoaderFileModule
[20:30:01] <TrevorParscal>	I copy-pasted from the i18n file, but forgot to convert it from array( key => value, key => value, key => value ) to array( key, key, key )
[20:30:37] <RoanKattouw>	Right
[20:35:50] <RoanKattouw>	OK I'm gonna go to bed now
[20:36:04] <RoanKattouw>	I'll be working tomorrow but will be on line a bit later than usual I think