[02:40:12] oink. [02:40:17] *jorm returns from tahoe. [02:40:22] how was it? [02:43:13] *guillom shuts down to reinstall ubuntu [06:54:03] hello everyone [06:55:01] Why vector hasn't take effect in small wikis yet? what was the deadline? AUG 25 or SEP 25? [06:56:23] anybody knows the update? [07:15:14] September 1 [07:18:48] oh.. thanks Ashlee [20:26:04] Reedy: you around? [20:26:10] adam_miller, yup [20:26:24] when i submit ratings, should it be 0-4 or 1-5? [20:26:54] should what? [20:26:59] the values [20:27:17] It was discussed that a rating of 0 shouldn't happen [20:27:23] then 1-5 [20:27:31] A rating of '0' means the user hasn't submitted a rating [20:27:35] not that they rated it 0 [20:27:36] Right [20:37:21] Reedy: i keep getting an error when submitting ratings [20:37:30] such as? [20:37:35] duplicate entry [20:37:44] are you using the newest tables? [20:37:54] maybe not? [20:37:54] as there were some daft issues in the initial implementation (not by me) [20:38:09] i remember getting that quite early on :) [20:39:15] ok now i am [20:39:18] for sure [20:39:20] and same deal [20:39:28] right, what are you sending? [20:39:37] you did drop and then run update.php, yes? [20:39:49] yes [20:40:15] requesting api.php?action=articleassessment&aarevid=1505&aapageid=74&aar1=5&aar2=3&aar3=4&aar4=2&data=json [20:40:42] it creates two records, but aa_rating_value is 0 for both [20:41:01] everything else seems like it's stored correctly [20:41:16] (unrelated) what's &data=json? [20:41:44] seemed to need that [20:41:47] no? [20:41:55] i've never seen it before in my life.. [20:42:23] &format=json, sure [20:43:03] oh i think data=json is something jquery is adding [20:43:15] heh, fair enough [20:43:21] when you tell it you're sending and expecting json [20:46:42] Reedy: so any ideas what's going on? [20:46:53] give me a few, i'll poke it [20:46:56] ok [20:47:03] I'm just trying to work out kooky syntax to left join [20:50:35] Reedy: why do we need two rows for each rating? [20:50:53] We don't [20:51:07] is the stuff in _pages for aggregation? [20:51:29] it's a tracking esk table, yeah [20:52:12] hmm, found what's up upsetting the sql [20:53:31] also, wondering if we should be submitting the ratings with parameters that are more transparent [20:53:48] ^demon: Around? [20:54:01] <^demon> What's up? [20:54:03] it's not instantly apparent that aar1 needs to be well sourced, &c [20:55:41] adam_miller, that's easily changable [20:55:49] lets do it then [20:56:08] so we don't get ourselves in trouble [20:56:10] it was trying to keep it extendable [20:56:18] as it may change [20:56:19] ish [20:56:30] ok, well how about we just comment the hell out of it then [20:56:30] hence returning the message keys [20:56:53] put a map in a comment above the code dealing with those params in your code [20:57:10] and i'll do the same in mine [20:58:00] maybe that will be ok...it just scares me when i'm dealing with contextless variables [21:00:23] adam_miller, heh [21:00:53] It was discussed that the names could change, and otherwise we've got to keep renaming stuff... [21:01:02] I don't really know what's the sanest way tbh [21:05:52] adam_miller, right. I've added the get userrating [21:06:02] But that's caused a break with something else, so won't commit as of yet [21:06:15] I'll have a look at your issue now [21:06:50] ok thanks [21:11:39] adam_miller, :D [21:11:41] sorted [21:11:50] Minor oversight, I was trying to insert a value, rather than using it for the where [21:11:51] and committed? [21:11:58] gotcha [21:12:01] just doing now [21:12:49] adam_miller, 71981 [21:16:03] thanks man [21:16:49] np [21:17:02] Just trying to decide what's best to do about descriptions etc [21:17:22] As i'm including the message key in the list result, just as a bit of verbosity for mapping [21:31:42] flipzagging, is http://svn.wikimedia.org/viewvc/mediawiki/branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js?view=markup&pathrev=66170 the latest version for the interface messages of the upload wizard? [21:32:34] no [21:32:39] (guillom) [21:32:58] could you tell me where I can find it, then, please? :) [21:33:08] yes, I'm getting it now [21:33:14] thanks [21:33:41] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UploadWizard/UploadWizard.i18n.php [21:33:47] but this is in translatewiki now [21:34:00] Wheeeee [21:34:05] thanks [21:34:16] adam_miller, any idea what we should call the "user" api parameter? [21:35:05] returnUserRating? [21:35:30] Hmm [21:35:38] I'd used just "user" (becoming aauser) [21:36:19] which is normally if we're passing a user parameter [21:44:00] can I use {{SITENAME}} in message strings or is it handled differently? [21:49:25] Reedy: looks like the page id isn't getting saved in _pages now [21:49:57] Reedy: wait hold on i think it's my fault... [21:50:18] lol [21:52:44] Reedy: ok page id is getting passed, i was just trying to rate an article that didnt exist yet :) [21:52:46] BUT [21:52:52] the rating still isn't getting saved [21:52:56] still all 0s [21:53:33] Mmmm [21:53:59] is it working for you? [22:03:54] I've got 0's also [22:04:47] I can guess [22:06:52] some $ would help [22:10:03] adam_miller, it gets confusing when I've done things one way, tested it, and then have to rewrite it for one reason or another [22:10:10] 71987 [22:10:37] Reedy: how would some dollar signs help? [22:10:50] They were missing [22:10:53] either way, it's fixed [22:11:09] either way, i thank you. [22:11:27] Reedy: do you live in SF or you just visiting? [22:11:35] just visiting [22:11:45] where home be? [22:11:59] England! [22:12:42] woo! you're more excited about that than i would be [22:12:52] :P [22:12:57] lol [22:12:57] what part of england? [22:13:15] The north - Hull for uni, between Hull and York for home [22:13:54] cool, i've never been to either so i'll just shut up [22:16:35] haha [22:16:42] Most americans don't have any idea where they are [22:18:09] Even I have no idea where they are, and I was living much closer to England that most Americans. [22:18:17] lol [22:18:20] Hull isn't suprising [22:18:44] but York is semi (it's a place a lot of tourists go) [22:19:33] all I know of England is London [22:19:38] and "know" is ambitious [22:19:51] the longer I stayed there was a week, and it wasn't vacations! [22:20:26] lol [22:23:09] Hmm, just this G?UID to store for users in one way or another [22:23:13] *anon users [22:25:46] TrevorParscal: dogg, is there a way to parse wikitext with javascript? [22:26:33] adam_miller, userrating now included [22:26:47] i'm not looking to jump through any hoops, just have a few i18n messages with wikitext in them that would be handy to through through some sort of psuedo-parser if we've got one [22:27:18] adam_miller, flipzagging or michael dale have had recent discussions about that iirc [22:27:34] they may be able to answer some questions [22:28:03] guillom: is it something that's already in place? [22:28:27] dunno, but flipzagging will know (when he comes back to his desk ; trevor is at his desk but in a discussion) [22:28:35] Roans doing CR [22:28:46] CR? [22:28:51] code review [22:28:55] with ryan k [22:30:16] adam_miller: there is a sort of parser in the mwEmbed framework, which I'm sort of sucked into my own work, and the plan is to put that into the new Resource Loader framework [22:30:25] adam_miller: what are you trying to do exactly [22:31:32] just have a few msgs that would be nice to run through, one's got a link, another a pluralization [22:31:41] adam_miller: right [22:31:56] ok, I haven't checked in my thing yet, and it isn't in Resource Loader yet either [22:32:03] but here's what mdale was doing [22:32:06] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/JS2Support/mwEmbed/components/mw.Parser.js?view=log [22:32:46] it's called from the related library mw.Language.js [22:32:48] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/JS2Support/mwEmbed/components/mw.Language.js?view=markup [22:33:06] adam_miller: parsing wikitext with JS? You're crazy! It can't be done!!! [22:33:18] adam_miller: how much functionality do you need? [22:33:20] the "messageSwapObject" is frankly, somewhat bizarre [22:33:29] oh ok so that's not being loaded right now though it looks like though [22:33:30] I've written a few JS parsers for different purposes [22:33:36] and tries to do very odd things indeed if you pass in a jquery object [22:34:05] TrevorParscal: i've got one link, and one pluralization, maybe italics in one spot too [22:35:00] adam_miller: this is the ratings thing? [22:35:02] all of it (save the pluralization) seems easy enough to just handle with code specific to this case [22:35:03] yeah [22:35:15] mdale has something (which is a little scary) that does it... and flipzagging was working on making something similar in purpose but less evil in execution [22:35:37] I tried to do more of it server side but failed, am just using mw.Parser as it is [22:35:47] my recommendation for the time being, if you can render it on the server, do... [22:36:04] consider none of us have time to remove the scariness I suggest we use it as is (or as Trevor recommended, just use different messages server side) [22:36:08] ok, i can't but i can handle it another way [22:36:21] thanks for the info [22:36:47] adam_miller: if I get a chance to hack at it more I'll let you know though [22:38:24] Also, when/if Nikerabbit finishes his new Message class things might suck less here ;) [23:05:15] Tim's not in here? [23:05:38] not right now, no. [23:05:50] Has he ever been? [23:05:52] i don't know if i've ever seen him in here. [23:05:54] Reedy: when does the data in article_assessment_pages get updated? [23:06:11] And the channel is being logged? [23:06:11] should i expect that to update when i submit a rating? [23:07:03] ... it may not be right now. i believe roan was going to poke at getting that working. [23:08:07] It needs to be mentioned in the channel topic if so. [23:08:15] ugh. i totally hate this anti-vector feedback form. [23:08:30] Why's that? [23:08:40] i do not see the presence of a logging bot, so i'm going to guess "no". [23:08:49] elephant? [23:08:53] yep [23:08:57] elephant's the logging bot [23:09:11] it's just too big. too many questions. [23:09:29] well, then it's being logged, and it should be indicated in the topic. i don't have rights to do so (i don't think) [23:09:37] FTFY. [23:09:37] unless the channel isn't +t. [23:26:03] http://www.thewildernessdowntown.com/ You have to use chrome with this; requires audio;