[02:22:29] (03PS4) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [02:24:17] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [04:30:50] (03CR) 10Aron Manning: Replace Grunt tasks with npm scripts in package.json (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/574893 (https://phabricator.wikimedia.org/T242781) (owner: 10Jdrewniak) [05:16:15] (03CR) 10Aron Manning: [C: 03+1] "Bump. Another week has passed." [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [05:41:23] (03PS14) 10Aron Manning: Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) [05:41:37] (03PS15) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [05:54:45] (03CR) 10jerkins-bot: [V: 04-1] [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [06:20:58] (03PS16) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [07:07:30] (03Abandoned) 10Shizhao: add replace: "|" -> "," [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575261 (owner: 10Shizhao) [10:18:08] 10Pywikibot, 10Pywikibot-Wikidata: editEntity fails if there is an existing coordinates claim with no precision value - https://phabricator.wikimedia.org/T246359 (10matej_suchanek) p:05Triage→03High Yes, this is annoying. There are multiple issues: - #Wikidata apparently still stores the invalid data (but... [10:37:15] 10Pywikibot, 10Pywikibot-tests: test bot is unable to login on wikipedia:en - https://phabricator.wikimedia.org/T245012 (10Dvorapa) This seems like an issue with aspects.py. The test finds out it is not logged in, it tries to log in successfully, but still skips the test as unable to log in [15:05:46] (03CR) 10Niedzielski: [C: 04-1] "The test failures appear related." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [15:18:54] 10Pywikibot, 10Pywikibot-Wikidata: Ability to change a label name for new Wikidata items in Pywikibot - https://phabricator.wikimedia.org/T246298 (10Vladis13) [15:25:40] (03PS1) 10Matěj Suchánek: [IMPR] Fix search for changed claims when saving entity [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575548 (https://phabricator.wikimedia.org/T246359) [15:28:26] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Fix search for changed claims when saving entity [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575548 (https://phabricator.wikimedia.org/T246359) (owner: 10Matěj Suchánek) [15:41:04] (03PS2) 10Matěj Suchánek: [IMPR] Fix search for changed claims when saving entity [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575548 (https://phabricator.wikimedia.org/T246359) [15:58:04] 10Pywikibot, 10Beta-Cluster-Infrastructure, 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Attempt to login fails several times - https://phabricator.wikimedia.org/T224712 (10Dvorapa) It first failed in May 29th after https://github.com/wikimedia/pywikibot/commit/893d03f... [16:10:37] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10Dvorapa) Hopefully this helps. There were more issues with sseclient 0.0.23 and 0.0.24 (https://github.com/wikime... [18:02:16] (03Abandoned) 10Jdlrobson: Use template partials [skins/Vector] - 10https://gerrit.wikimedia.org/r/570861 (owner: 10Jdlrobson) [18:10:35] (03CR) 10Jforrester: [C: 03+1] "Add a comment against each one saying `// Support: MediaWiki 1.31 and before` so that people know when it can be removed?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) (owner: 10Daimona Eaytoy) [18:19:08] 10Pywikibot, 10Toolforge: Create symlink to PWB py2 version in /shared/pywikibot - https://phabricator.wikimedia.org/T245209 (10Dvorapa) 05Open→03Resolved a:03Dvorapa Done! `core_python2` [18:27:11] (03CR) 10Daimona Eaytoy: "> Add a comment against each one saying `// Support: MediaWiki 1.31" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) (owner: 10Daimona Eaytoy) [18:28:37] (03PS3) 10Daimona Eaytoy: Don't use $wgContLang on MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) [18:29:33] (03PS4) 10Daimona Eaytoy: Don't use $wgContLang on MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) [18:30:31] (03CR) 10Jforrester: [C: 03+2] Don't use $wgContLang on MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) (owner: 10Daimona Eaytoy) [18:35:04] (03Merged) 10jenkins-bot: Don't use $wgContLang on MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) (owner: 10Daimona Eaytoy) [18:45:04] (03CR) 10Yaron Koren: "@Daimona Eaytoy, @Jforrester - thank you to both of you!" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574229 (https://phabricator.wikimedia.org/T245940) (owner: 10Daimona Eaytoy) [18:49:53] (03PS5) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [18:51:43] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [19:07:30] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10TheSandDoctor) Since updating to the latest master version of sseclient (post-fix merges) more of the workers cra... [19:14:19] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10Dvorapa) I tried this file and a random file to compare and Pywikibot is correct. The file has no imageinfo as it... [19:16:07] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10Dvorapa) > pywikibot.exceptions.Error: Title contains illegal char (\uFFFD 'REPLACEMENT CHARACTER') This should... [19:17:48] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10TheSandDoctor) @Dvorapa I saw that myself & just updated my above comment prior to seeing your response. It appea... [19:21:31] (03PS5) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [19:22:48] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [19:45:11] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10zhuyifei1999) I will be running the script with pdb + save all sseclient trace over the weekend. [19:45:49] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10Upstream, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10zhuyifei1999) [19:54:31] (03PS4) 10Jdlrobson: Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) [19:56:40] (03PS5) 10Jdlrobson: Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) [19:57:05] (03CR) 10jerkins-bot: [V: 04-1] Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [20:10:40] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10Upstream, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10TheSandDoctor) >>! In T181443#5927759, @zhuyifei1999 wrote: > I will be running the script with pdb... [20:12:53] (03PS6) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [20:12:57] (03PS1) 10Nray: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [20:14:10] (03PS2) 10Nray: WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [20:17:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [20:17:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [20:18:00] (03PS3) 10Nray: WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [20:18:04] (03CR) 10Jdlrobson: "NEAT." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [20:18:48] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: AppVeyor and some Travis environments warn that "setup.py test" is deprecated - https://phabricator.wikimedia.org/T243224 (10Dvorapa) [20:19:49] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10Upstream, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10zhuyifei1999) Whichever is simplest. [20:20:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [20:57:40] (03PS1) 10Polishdeveloper: Instead of accessing $data property use set/get/html methods [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) [21:06:17] (03PS2) 10Polishdeveloper: Instead of accessing $data property use set/get/html methods [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) [21:32:14] 10Pywikibot, 10Commons, 10Pywikibot-category.py, 10Upstream, 10User-TheSandDoctor: Pywikibot stops when finding the character \uFFFD - 'REPLACEMENT CHARACTER' - https://phabricator.wikimedia.org/T181443 (10TheSandDoctor) >>! In T181443#5927865, @zhuyifei1999 wrote: > Whichever is simplest. That would be... [23:11:21] (03CR) 10Jdlrobson: [C: 04-1] "small thoughts awaiting your consideration..." (035 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) (owner: 10Polishdeveloper) [23:18:26] (03CR) 10Nray: [C: 04-1] "Everything looks good, just couple nitpicks!" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [23:18:36] (03PS7) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [23:18:40] (03PS4) 10Nray: WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [23:18:44] (03PS1) 10Nray: WIP: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) [23:19:20] (03PS6) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [23:23:42] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [23:24:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [23:25:49] (03CR) 10Nray: Use template partials rather than HTML strings (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [23:26:08] (03CR) 10jerkins-bot: [V: 04-1] WIP: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [23:27:05] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [23:29:17] (03CR) 10Polishdeveloper: Instead of accessing $data property use set/get/html methods (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) (owner: 10Polishdeveloper) [23:32:53] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/575640 (https://phabricator.wikimedia.org/T246142) [23:34:33] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/575640 (https://phabricator.wikimedia.org/T246142) [23:36:04] (03CR) 10Jdlrobson: [C: 03+2] Instead of accessing $data property use set/get/html methods [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) (owner: 10Polishdeveloper) [23:38:17] (03PS7) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [23:39:03] (03PS3) 10DannyS712: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/575640 (https://phabricator.wikimedia.org/T246142) [23:39:57] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [23:48:58] (03CR) 10Nray: [C: 03+2] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [23:50:33] (03Merged) 10jenkins-bot: Instead of accessing $data property use set/get/html methods [skins/Vector] - 10https://gerrit.wikimedia.org/r/575615 (https://phabricator.wikimedia.org/T246161) (owner: 10Polishdeveloper) [23:57:09] (03PS8) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [23:57:13] (03PS5) 10Nray: WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [23:57:17] (03PS2) 10Nray: WIP: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281)