[00:03:53] (03CR) 10MewOphaswongse: [WIP] Add a link: Mobile UX improvements (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685953 (https://phabricator.wikimedia.org/T281771) (owner: 10MewOphaswongse) [07:13:24] (03PS1) 10Kosta Harlan: AddLink: Instrumentation for onboarding dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686349 (https://phabricator.wikimedia.org/T278111) [07:30:03] 10Growth-Team, 10Add-Link: [mobile] Add link: clicking on article elements triggers "Unrecognized symbolic name: alien" - https://phabricator.wikimedia.org/T282194 (10kostajh) p:05Triage→03Medium [07:39:56] 10Growth-Team, 10MediaWiki-Recent-changes, 10Wikimedia-production-error: TypeError: Cannot read property 'isHighlightable' of null - https://phabricator.wikimedia.org/T282047 (10kostajh) 14 cases of this in the last 30 days. #growth-team is not going to be able to work on this any time soon. [07:40:48] 10Growth-Team, 10GrowthExperiments-NewcomerTasks: Show task name in edit tags for NewcomerTasks - https://phabricator.wikimedia.org/T282099 (10kostajh) [07:42:21] 10Growth-Team, 10GrowthExperiments-NewcomerTasks: Show task name in edit tags for NewcomerTasks - https://phabricator.wikimedia.org/T282099 (10kostajh) cc @MMiller_WMF & @Trizek-WMF [07:43:50] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Russian-Sites: Disable unused Flow extension on ru.wikipedia - https://phabricator.wikimedia.org/T282132 (10kostajh) If the discussion is unstalled, let us know, but yeah AFAIK this is not straightforward to do unfortunately. [07:48:41] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10kostajh) #growth-team hasn't made any changes to Watchlist code in some time, so my guess is that this is related to actor... [08:03:23] (03PS12) 10Sahilgrewalhere: Upgraded WebdriverIO to v7 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) [08:19:45] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO to v7 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) (owner: 10Sahilgrewalhere) [09:07:55] (03PS4) 10Kosta Harlan: Prevent suggestions mode from loading after exiting post-edit dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683853 (https://phabricator.wikimedia.org/T281462) [09:14:26] (03PS5) 10Kosta Harlan: Prevent suggestions mode from loading after exiting post-edit dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683853 (https://phabricator.wikimedia.org/T281462) [09:14:32] (03CR) 10Kosta Harlan: Prevent suggestions mode from loading after exiting post-edit dialog (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683853 (https://phabricator.wikimedia.org/T281462) (owner: 10Kosta Harlan) [09:31:35] (03PS1) 10Kosta Harlan: Tracker: Untrack pages after link recommendation edit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686433 (https://phabricator.wikimedia.org/T277518) [10:01:25] (03Abandoned) 10Gergő Tisza: [WIP] Add test for AddLinkSubmissionHandler [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/674395 (owner: 10Gergő Tisza) [10:35:15] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10Ammarpad) [10:57:15] (03CR) 10Zfilipin: "Hi!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) (owner: 10Sahilgrewalhere) [11:08:58] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10Xaosflux) Wild guess that @Cicalese might have insight in to this? [11:12:20] (03CR) 10Sahilgrewalhere: "> Patch Set 12:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) (owner: 10Sahilgrewalhere) [11:36:21] (03PS13) 10Sahilgrewalhere: Upgraded WebdriverIO to v7 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) [11:51:58] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO to v7 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/678287 (https://phabricator.wikimedia.org/T274579) (owner: 10Sahilgrewalhere) [11:55:25] 10Growth-Team, 10Growth-Team-Filtering, 10Notifications, 10AbuseFilter, and 16 others: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName - https://phabricator.wikimedia.org/T275030 (10Vlad.shapik) The patch will be merged and the ticket will be resolved when the setters of AbstractAuth... [13:58:10] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10CCicalese_WMF) I have indeed been working on the watchlist code recently. I will look into this. Thanks for the ping. [14:12:01] (03CR) 10Tchanders: Allow partially blocking giving thanks (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/681421 (https://phabricator.wikimedia.org/T242785) (owner: 10STran) [15:12:23] (03PS1) 10Amire80: Correct growthexperiments-edit-config-newcomer-tasks-* messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686624 [15:15:43] (03PS3) 10Amire80: Replace some instances of "recommend" with "suggest" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682248 (https://phabricator.wikimedia.org/T281083) [15:15:56] (03PS4) 10Amire80: Replace some instances of "recommend" with "suggest" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682248 (https://phabricator.wikimedia.org/T281083) [15:21:38] (03CR) 10Kosta Harlan: [C: 03+2] Correct growthexperiments-edit-config-newcomer-tasks-* messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686624 (owner: 10Amire80) [15:33:15] (03Merged) 10jenkins-bot: Correct growthexperiments-edit-config-newcomer-tasks-* messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686624 (owner: 10Amire80) [15:35:28] (03CR) 10Rho: [C: 03+1] Replace some instances of "recommend" with "suggest" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682248 (https://phabricator.wikimedia.org/T281083) (owner: 10Amire80) [15:42:10] (03CR) 10Jforrester: [C: 03+2] Use static closures where safe to use [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685007 (owner: 10Umherirrender) [15:52:48] (03Merged) 10jenkins-bot: Use static closures where safe to use [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685007 (owner: 10Umherirrender) [15:56:59] 10Growth-Team, 10Growth-Team-Filtering, 10Image-Recommendations, 10Wikipedia-Android-App-Backlog, 10Research (FY2020-21-Research-April-June): Image matching algorithm - https://phabricator.wikimedia.org/T256081 (10Miriam) [15:57:01] 10Growth-Team, 10Growth-Team-Filtering, 10Image-Recommendations, 10Wikipedia-Android-App-Backlog, 10Research (FY2020-21-Research-April-June): Assess prevalence of Wikidata infoboxes - https://phabricator.wikimedia.org/T272109 (10Miriam) 05Open→03Resolved Resolving this for now, as all experiments are... [15:57:03] 10Growth-Team, 10Growth-Team-Filtering, 10Image-Recommendations, 10Research (FY2020-21-Research-April-June): Investigate placeholder image recommendation - https://phabricator.wikimedia.org/T277828 (10Miriam) Weekly updates: none [15:58:47] (03PS29) 10Kosta Harlan: Use ApiVisualEditorEditPostSaveHook for link-recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682015 (https://phabricator.wikimedia.org/T269657) [15:59:09] (03PS2) 10Kosta Harlan: Tracker: Untrack pages after link recommendation edit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686433 (https://phabricator.wikimedia.org/T277518) [15:59:53] (03PS14) 10Kosta Harlan: AddLink: LinkSuggestionInteraction logger and instrumentation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/684127 (https://phabricator.wikimedia.org/T278116) [15:59:55] (03PS2) 10Kosta Harlan: AddLink: Instrumentation for onboarding dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686349 (https://phabricator.wikimedia.org/T278111) [17:27:23] (03PS2) 10Umherirrender: Fix error handling around WorkflowLoader::handleSubmit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685871 (https://phabricator.wikimedia.org/T269792) [17:28:00] (03CR) 10Umherirrender: Fix error handling around WorkflowLoader::handleSubmit (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685871 (https://phabricator.wikimedia.org/T269792) (owner: 10Umherirrender) [18:37:23] (03PS2) 10Umherirrender: build: Updating dependencies [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/686366 (owner: 10Libraryupgrader) [18:37:33] (03CR) 10Umherirrender: [C: 03+2] build: Updating dependencies [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/686366 (owner: 10Libraryupgrader) [19:18:11] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: [mobile] Add link: context item displays issues - https://phabricator.wikimedia.org/T281645 (10Etonkovidova) Checked `#3 context item might not be fully displayed in the viewport` as part of testing the patches in T281616 - all looks fine. [19:32:07] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Accessibility, 10Patch-For-Review: Flow could use article tags - https://phabricator.wikimedia.org/T175937 (10Izno) [19:46:40] 10Growth-Team, 10Add-Link: Add link: Monobook and Modern skins issues - https://phabricator.wikimedia.org/T282277 (10Etonkovidova) [19:59:42] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10suffusion_of_yellow) This also happens at Special:RecentChanges and Special:Special:RecentChangesLinked. https://en.wikipe... [20:03:23] 10Growth-Team, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist and recentchanges results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10Xaosflux) [20:03:33] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist and recentchanges results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10Xaosflux) [20:19:37] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist and recentchanges results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10suffusion_of_yellow) But the API seems to work: https://en.wikipedia.org/... [20:26:16] 10Growth-Team, 10Notifications, 10Desktop Improvements, 10RW-Feature-DI-User-Menu, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): User Links: Handling of talk page notification - https://phabricator.wikimedia.org/T274428 (10Jdlrobson) 05Stalled→03Open [20:26:39] 10Growth-Team, 10Notifications, 10Desktop Improvements, 10RW-Feature-DI-User-Menu, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): User Links: Handling of talk page notification - https://phabricator.wikimedia.org/T274428 (10Jdlrobson) [20:27:05] (03Abandoned) 10Umherirrender: build: Updating composer dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/684978 (owner: 10Libraryupgrader) [20:27:31] 10Growth-Team, 10Notifications, 10Desktop Improvements, 10RW-Feature-DI-User-Menu, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): User Links: Handling of talk page notification - https://phabricator.wikimedia.org/T274428 (10Jdlrobson) [20:28:20] 10Growth-Team, 10Notifications, 10Desktop Improvements, 10RW-Feature-DI-User-Menu, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): User Links: Handling of talk page notification - https://phabricator.wikimedia.org/T274428 (10Jdlrobson) a:05Jdlrobson→03None [20:43:43] (03PS3) 10MewOphaswongse: Add a link: open help panel's suggested-edits panel instead of home [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685544 (https://phabricator.wikimedia.org/T278488) [20:49:59] 10Growth-Team, 10GrowthExperiments-Mentorship: growthsetmentor API error message growthexperiments-homepage-claimmentee-already-mentor assumes request is made by mentor - https://phabricator.wikimedia.org/T282281 (10Tgr) [20:52:32] 10Growth-Team, 10Growth-Team-Filtering, 10StructuredDiscussions, 10Patch-For-Review, 10Wikimedia-production-error: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. - https://phabricator.wikimedia.org/T269792 (10Tgr) This happens when a mentee sends a question... [20:53:24] (03CR) 10jerkins-bot: [V: 04-1] Add a link: open help panel's suggested-edits panel instead of home [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685544 (https://phabricator.wikimedia.org/T278488) (owner: 10MewOphaswongse) [20:54:57] (03CR) 10Gergő Tisza: [C: 03+2] Fix error handling around WorkflowLoader::handleSubmit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685871 (https://phabricator.wikimedia.org/T269792) (owner: 10Umherirrender) [20:56:04] 10Growth-Team, 10Growth-Team-Filtering, 10StructuredDiscussions, 10Patch-For-Review, 10Wikimedia-production-error: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. - https://phabricator.wikimedia.org/T269792 (10Tgr) 05Open→03Resolved a:03Umherirrender T... [20:58:53] (03CR) 10MewOphaswongse: [C: 03+1] AddLink: LinkSuggestionInteraction logger and instrumentation (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/684127 (https://phabricator.wikimedia.org/T278116) (owner: 10Kosta Harlan) [21:01:30] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Platform Engineering, 10Regression: Hiding own edits on watchlist and recentchanges results in hiding all IP edits. - https://phabricator.wikimedia.org/T282183 (10CCicalese_WMF) git bisect indicates that the issue may have been caused by... [21:03:53] (03Merged) 10jenkins-bot: Fix error handling around WorkflowLoader::handleSubmit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/685871 (https://phabricator.wikimedia.org/T269792) (owner: 10Umherirrender) [21:15:13] (03PS1) 10Umherirrender: Replace uses of DB_MASTER with DB_PRIMARY [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686769 [21:55:23] (03CR) 10Gergő Tisza: [C: 03+2] Replace uses of DB_MASTER with DB_PRIMARY [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686769 (owner: 10Umherirrender) [22:01:27] 10Growth-Team, 10Add-Link: Add link - navigating with browser back button should keep the Add link context item open - https://phabricator.wikimedia.org/T282043 (10Etonkovidova) [22:03:18] (03PS1) 10Umherirrender: Use ::class for class name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/686782 [22:04:43] (03Merged) 10jenkins-bot: Replace uses of DB_MASTER with DB_PRIMARY [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686769 (owner: 10Umherirrender) [22:17:17] (03CR) 10Gergő Tisza: [C: 03+2] Use ApiVisualEditorEditPostSaveHook for link-recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682015 (https://phabricator.wikimedia.org/T269657) (owner: 10Kosta Harlan) [22:27:59] (03Merged) 10jenkins-bot: Use ApiVisualEditorEditPostSaveHook for link-recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682015 (https://phabricator.wikimedia.org/T269657) (owner: 10Kosta Harlan) [22:29:07] 10Growth-Team, 10Add-Link: [mobile] suggested add link inspector - reloading page workflows - https://phabricator.wikimedia.org/T282290 (10Etonkovidova) [22:33:04] (03CR) 10Gergő Tisza: [C: 03+2] Tracker: Untrack pages after link recommendation edit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686433 (https://phabricator.wikimedia.org/T277518) (owner: 10Kosta Harlan) [22:42:54] (03Merged) 10jenkins-bot: Tracker: Untrack pages after link recommendation edit [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/686433 (https://phabricator.wikimedia.org/T277518) (owner: 10Kosta Harlan)