[00:46:17] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Johan) Making sure I read the task correctly: Only English Wikipedia and Growth features (trivially) will be affected. Echo, CX and a few other things wi... [03:21:15] 10Growth-Team, 10StructuredDiscussions, 10Chinese-Sites: Content in Extension:StructuredDiscussions cannot be converted - https://phabricator.wikimedia.org/T281074 (10Shizhao) [03:47:02] (03CR) 10Krinkle: "There's no problem with polyfilling something from an extension. Requiring them in core is not the status quo as I see it, and I can think" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/683103 (https://phabricator.wikimedia.org/T272904) (owner: 10Jdlrobson) [04:11:52] (03CR) 10Jdlrobson: [C: 04-1] "Polyfill was the wrong word to use here. Polyfilling shouldn't clobber existing functions without feature detection and shouldn't change b" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/683103 (https://phabricator.wikimedia.org/T272904) (owner: 10Jdlrobson) [04:25:59] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Marostegui) @Johan all wikipedias will be affected, as x1 holds echo for all the projects. [05:02:50] (03PS1) 10Tim Starling: EchoEventMapper: use DISTINCT instead of GROUP BY [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683122 (https://phabricator.wikimedia.org/T281329) [05:43:50] (03PS1) 10Func: Do not pass actorId to UserIdentityValue [extensions/GrowthExperiments] (REL1_36) - 10https://gerrit.wikimedia.org/r/683129 [05:44:38] (03PS4) 10Func: Handle EditFilterMergedContent hook properly to break hook chains and display error message [extensions/GrowthExperiments] (REL1_36) - 10https://gerrit.wikimedia.org/r/682721 (https://phabricator.wikimedia.org/T280312) [09:11:26] (03PS4) 10Kosta Harlan: Add a link: Update background color value for active annotation & triangle [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683090 (https://phabricator.wikimedia.org/T279684) (owner: 10MewOphaswongse) [09:13:20] (03CR) 10Kosta Harlan: [C: 03+2] Add a link: Update background color value for active annotation & triangle [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683090 (https://phabricator.wikimedia.org/T279684) (owner: 10MewOphaswongse) [09:17:57] (03CR) 10Kosta Harlan: [C: 03+2] Fixes for save dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683105 (https://phabricator.wikimedia.org/T269657) (owner: 10Gergő Tisza) [09:25:42] (03Merged) 10jenkins-bot: Add a link: Update background color value for active annotation & triangle [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683090 (https://phabricator.wikimedia.org/T279684) (owner: 10MewOphaswongse) [09:29:07] (03Merged) 10jenkins-bot: Fixes for save dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683105 (https://phabricator.wikimedia.org/T269657) (owner: 10Gergő Tisza) [10:27:13] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Johan) @Marostegui Thanks! And notifications for this minute will be lost, not just delayed? [11:06:42] (03CR) 10Kosta Harlan: [C: 04-1] Replace some instances of "recommend" with "suggest" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682248 (https://phabricator.wikimedia.org/T281083) (owner: 10Amire80) [11:12:35] 10Growth-Team, 10Growth-Team-Filtering, 10Add-Link, 10Growth-Structured-Tasks: Add a link: link inspector can obscure text - https://phabricator.wikimedia.org/T281185 (10kostajh) [11:24:10] 10Growth-Team, 10Add-Link, 10GrowthExperiments, 10Patch-For-Review: Consistently use "recommend" and "suggest" in GrowthExperiments messages - https://phabricator.wikimedia.org/T281083 (10kostajh) >>! In T281083#7040292, @MMiller_WMF wrote: > @RHo -- I agree that we should change that one instance of "reco... [11:41:36] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Marostegui) I am not fully sure about that, as I don't know whether they get re-tried or not. [11:52:49] 10Growth-Team, 10Growth-Team-Filtering, 10Add-Link, 10Growth-Structured-Tasks: Add a link: link inspector can obscure text - https://phabricator.wikimedia.org/T281185 (10kostajh) p:05Triage→03Medium [14:23:35] 10Growth-Team, 10Growth-Team-Filtering, 10MediaWiki-Watchlist, 10Platform Engineering, 10User-Marostegui: Purge unused watchlist rows - https://phabricator.wikimedia.org/T258098 (10Marostegui) Test on wikidata: ` -rw-rw---- 1 mysql mysql 11G Apr 28 12:22 watchlist.ibd optimize -rw-rw---- 1 mysql mysql 2.... [14:30:36] (03PS1) 10Gergő Tisza: Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) [14:30:58] (03CR) 10jerkins-bot: [V: 04-1] Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) (owner: 10Gergő Tisza) [14:32:00] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Trizek-WMF) IIRC, notifications work on a one-time attempt. I'll ask around. This read-only is a big one, affecting multiple wikis and cross-wiki services... [14:33:16] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Marostegui) From what I can see on the last time we did this, it was just announce on tech news: https://phabricator.wikimedia.org/T273758#6832250 [14:33:48] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Marostegui) @Trizek-WMF if you want me to create a task for that I can do that too, whatever works best for you. [14:39:02] (03PS2) 10Gergő Tisza: Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) [14:47:47] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Trizek-WMF) Last time, [[ https://phabricator.wikimedia.org/T273762#6815905 | we setup a banner ]]. :) [14:48:24] 10Growth-Team, 10Cognate, 10ContentTranslation, 10DBA, and 9 others: Restart x1 database master (db1103) - https://phabricator.wikimedia.org/T281212 (10Marostegui) @Trizek-WMF this is what we listed as impact last time: T273762 [14:52:07] (03CR) 10jerkins-bot: [V: 04-1] Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) (owner: 10Gergő Tisza) [15:07:46] (03CR) 10Ppchelko: [C: 03+2] Replace usage of deprecated User watchlist methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) (owner: 10Cicalese) [15:13:55] (03PS3) 10Gergő Tisza: Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) [15:19:50] 10Growth-Team, 10Growth-Team-Filtering, 10GrowthExperiments-MentorDashboard, 10GrowthExperiments-Mentorship, 10User-Urbanecm_WMF (Engineering): Mentor dashboard: M2 mentor tools/settings - https://phabricator.wikimedia.org/T280307 (10Trizek-WMF) Side note: it would be nice to have all mentor's mentees be... [15:34:58] (03CR) 10jerkins-bot: [V: 04-1] Replace usage of deprecated User watchlist methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) (owner: 10Cicalese) [16:16:57] 10Growth-Team, 10Growth-Team-Filtering, 10User-Dyolf77, 10User-PPham, 10User-Urbanecm_WMF (Ambassador): 2021-Q2 mentor audit - https://phabricator.wikimedia.org/T280139 (10Trizek-WMF) @Urbanecm_WMF, can you share your report there, using the same format as others? This way I will be able to publish the r... [16:20:30] (03Abandoned) 10Jdlrobson: Drop modifications to Date.prototype [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/683103 (https://phabricator.wikimedia.org/T272904) (owner: 10Jdlrobson) [16:21:43] 10Growth-Team, 10PageCuration, 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), and 3 others: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema - https://phabricator.wikimedia.org/T272904 (10Jdlrobson) [16:23:56] 10Growth-Team, 10PageCuration, 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), and 2 others: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema - https://phabricator.wikimedia.org/T272904 (10Jdlrobson) The last release of... [16:40:23] 10Growth-Team, 10Growth-Team-Filtering, 10User-Dyolf77, 10User-PPham, 10User-Urbanecm_WMF (Ambassador): 2021-Q2 mentor audit - https://phabricator.wikimedia.org/T280139 (10Urbanecm_WMF) @Trizek-WMF Sorry, I thought I did share it already. Here you go! * No new mentors (last addition was December 2020) *... [16:42:40] 10Growth-Team, 10Growth-Team-Filtering, 10GrowthExperiments-MentorDashboard, 10GrowthExperiments-Mentorship, 10User-Urbanecm_WMF (Engineering): Mentor dashboard: M2 mentor tools/settings - https://phabricator.wikimedia.org/T280307 (10Urbanecm_WMF) >>! In T280307#7036035, @MMiller_WMF wrote: > @Urbanecm_W... [16:54:16] 10Growth-Team, 10Growth-Team-Filtering, 10GrowthExperiments-MentorDashboard, 10GrowthExperiments-Mentorship, 10User-Urbanecm_WMF (Engineering): Mentor dashboard: M2 mentor tools/settings - https://phabricator.wikimedia.org/T280307 (10OTichonova) >>! In T280307#7042331, @Trizek-WMF wrote: > Side note: it... [17:45:37] 10Growth-Team, 10CommRel-Specialists-Support (Apr-Jun-2021): Increase the number of translations for a set of wikis that use Growth features - https://phabricator.wikimedia.org/T281393 (10Trizek-WMF) [17:45:44] 10Growth-Team, 10CommRel-Specialists-Support (Apr-Jun-2021): Increase the number of translations for a set of wikis that use Growth features - https://phabricator.wikimedia.org/T281393 (10Trizek-WMF) p:05Triage→03Medium [17:50:04] (03PS1) 10MewOphaswongse: Add a link: Fix persistent page reloading when switching tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683410 (https://phabricator.wikimedia.org/T280616) [17:55:13] (03CR) 10MewOphaswongse: [C: 03+2] Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) (owner: 10Gergő Tisza) [18:03:33] (03CR) 10jerkins-bot: [V: 04-1] Add a link: Fix persistent page reloading when switching tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683410 (https://phabricator.wikimedia.org/T280616) (owner: 10MewOphaswongse) [18:16:34] (03Merged) 10jenkins-bot: Add Link: "skipped all suggestions" dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683296 (https://phabricator.wikimedia.org/T269658) (owner: 10Gergő Tisza) [18:29:44] (03PS1) 10MewOphaswongse: Add a link: don't write or read from restored edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683414 (https://phabricator.wikimedia.org/T267690) [18:59:02] (03CR) 10DannyS712: [C: 04-1] "extension supports 1.36+, new methods only available in 1.37" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) (owner: 10Cicalese) [20:59:20] (03CR) 10Kosta Harlan: [C: 03+2] Add a link: don't write or read from restored edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683414 (https://phabricator.wikimedia.org/T267690) (owner: 10MewOphaswongse) [21:02:24] (03CR) 10Krinkle: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/679963 (owner: 10Krinkle) [21:02:27] (03PS2) 10Krinkle: build: Remove old left-over Gemfile from Ruby-based browser testing era [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/679963 [21:03:14] (03PS1) 10Urbanecm: Set GEMentorshipMigrationStage to SCHEMA_COMPAT_NEW [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683431 (https://phabricator.wikimedia.org/T275773) [21:07:05] (03CR) 10Kosta Harlan: [C: 03+2] Add a link: Fix persistent page reloading when switching tabs (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683410 (https://phabricator.wikimedia.org/T280616) (owner: 10MewOphaswongse) [21:09:47] (03Merged) 10jenkins-bot: Add a link: don't write or read from restored edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683414 (https://phabricator.wikimedia.org/T267690) (owner: 10MewOphaswongse) [21:12:40] (03CR) 10jerkins-bot: [V: 04-1] Set GEMentorshipMigrationStage to SCHEMA_COMPAT_NEW [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683431 (https://phabricator.wikimedia.org/T275773) (owner: 10Urbanecm) [21:17:27] (03Merged) 10jenkins-bot: Add a link: Fix persistent page reloading when switching tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683410 (https://phabricator.wikimedia.org/T280616) (owner: 10MewOphaswongse) [21:17:30] (03PS2) 10Cicalese: Replace usage of deprecated User watchlist methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) [21:24:14] (03PS1) 10Urbanecm: MentorPageMentorManagerTest: Do not use setOption() directly to set mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683434 [21:24:22] (03CR) 10Urbanecm: "Good catch, jenkins." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683431 (https://phabricator.wikimedia.org/T275773) (owner: 10Urbanecm) [21:24:47] (03PS2) 10Urbanecm: Set GEMentorshipMigrationStage to SCHEMA_COMPAT_NEW [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683431 (https://phabricator.wikimedia.org/T275773) [21:32:56] (03PS1) 10Urbanecm: MentorPageMentorManagerTest: Test getMentorForUserIfExists works as intended [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683437 [21:42:47] (03CR) 10jerkins-bot: [V: 04-1] MentorPageMentorManagerTest: Test getMentorForUserIfExists works as intended [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/683437 (owner: 10Urbanecm) [21:48:16] 10Growth-Team, 10Add-Link: Add a link: open the article in edit mode right away - https://phabricator.wikimedia.org/T280991 (10mewoph) From @kostajh's comment in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/683410/1/includes/HomepageModules/SuggestedEdits.php > > it seems like w... [21:56:27] (03CR) 10Ppchelko: [C: 03+2] Replace usage of deprecated User watchlist methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) (owner: 10Cicalese) [22:18:48] (03Merged) 10jenkins-bot: Replace usage of deprecated User watchlist methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/683021 (https://phabricator.wikimedia.org/T281187) (owner: 10Cicalese) [22:20:38] 10Growth-Team, 10Wikimedia-production-error: '.event.module' should be equal to one of the allowed values - https://phabricator.wikimedia.org/T281424 (10Etonkovidova) [23:51:45] 10Growth-Team, 10Add-Link: Add link: VE shortcut open a regular link inspector overlapping add link context item - https://phabricator.wikimedia.org/T281434 (10Etonkovidova) [23:53:16] 10Growth-Team, 10Add-Link: Add link: VE shortcut opens a regular link inspector overlapping add link context item - https://phabricator.wikimedia.org/T281434 (10Etonkovidova) [23:56:54] 10Growth-Team, 10Add-Link: Add link: VE shortcut opens a regular link inspector overlapping add link context item - https://phabricator.wikimedia.org/T281434 (10Etonkovidova)