[15:17:15] 10Growth-Team, 10Add-Link: Review changes button does not show diff in Visual mode - https://phabricator.wikimedia.org/T280980 (10Tgr) @RHo I think this is the wrong parent task for {T280846}. [15:26:35] 10Growth-Team, 10Add-Link: Review changes button does not show diff in Visual mode - https://phabricator.wikimedia.org/T280980 (10Tgr) I you add a normal link and look at the visual diff, there is a small "Link added: XXX" annotation on the right side. (Is that a new feature? I don't recall seeing it in the pa... [16:06:16] (03CR) 10Gergő Tisza: [C: 03+2] Handle EditFilterMergedContent hook properly to break hook chains and display error message [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/680362 (https://phabricator.wikimedia.org/T280312) (owner: 10Func) [16:19:48] (03Merged) 10jenkins-bot: Handle EditFilterMergedContent hook properly to break hook chains and display error message [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/680362 (https://phabricator.wikimedia.org/T280312) (owner: 10Func) [17:03:37] (03CR) 10Gergő Tisza: [C: 03+2] "I have mixed feelings about using a config object that needs to be called via custom methods beyond the standard Config interface, but I d" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [17:14:28] (03Merged) 10jenkins-bot: Special:EditGrowthConfig should not use cache to load config [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [17:17:58] 10Growth-Team, 10Growth-Team-Filtering, 10GrowthExperiments-MentorDashboard, 10GrowthExperiments-Mentorship, 10User-Urbanecm_WMF (Engineering): Mentor dashboard: M1 mentee overview module - https://phabricator.wikimedia.org/T278971 (10Urbanecm_WMF) >>! In T278971#7030536, @MMiller_WMF wrote: >>>! In T278... [17:21:13] (03CR) 10Gergő Tisza: "This works as a bandaid, but it's slow since WikiPageConfigLoader does not cache READ_LATEST calls so the special page will do many DB rea" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [17:22:16] (03CR) 10Urbanecm: "This very likely needs review by Marshall, Growth's product manager. Would you be willing to create a Phabricator task in #growth-team, li" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682248 (owner: 10Amire80) [17:24:47] 10Growth-Team, 10Growth-Team-Filtering, 10GrowthExperiments-MentorDashboard, 10GrowthExperiments-Mentorship, 10User-Urbanecm_WMF (Engineering): Mentor dashboard: M2 mentor tools/settings - https://phabricator.wikimedia.org/T280307 (10Urbanecm_WMF) >>! In T280307#7030426, @MMiller_WMF wrote: > [...] > @Ur... [17:28:12] (03CR) 10Gergő Tisza: [C: 03+2] Make it possible to disable on-wiki configuration [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681346 (https://phabricator.wikimedia.org/T280581) (owner: 10Urbanecm) [17:39:14] (03Merged) 10jenkins-bot: Make it possible to disable on-wiki configuration [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681346 (https://phabricator.wikimedia.org/T280581) (owner: 10Urbanecm) [18:38:43] 10Growth-Team, 10Growth-Team-Filtering, 10Growth-Deployments, 10MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), 10User-Urbanecm_WMF (Engineering): Deploy Growth features on Greek Wikipedia - https://phabricator.wikimedia.org/T280172 (10geraki) >>! In T280172#7029197, @Trizek-WMF wrote: > Also geraki, do you th... [18:41:56] (03CR) 10Gergő Tisza: "If the old on-wiki configuration is invalid (can happen due to the recent patches changing some field definitions), trying to save will re" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681112 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [18:42:01] (03CR) 10Gergő Tisza: [C: 03+2] Validate in WikiPageConfigWriter rather than in Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681112 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [18:42:11] (03CR) 10Gergő Tisza: [C: 04-1] Decouple validation from UI definition (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [18:42:19] (03CR) 10Gergő Tisza: [C: 03+2] Special:EditGrowthConfig: Use radio buttons rather than checkboxes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681124 (https://phabricator.wikimedia.org/T280352) (owner: 10Urbanecm) [18:42:36] (03CR) 10Gergő Tisza: Allow users to maintain help panel links from Special:EditGrowthConfig (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [18:43:02] (03CR) 10Gergő Tisza: [C: 03+2] Remove "Tutorial page title" from from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681171 (https://phabricator.wikimedia.org/T280350) (owner: 10Urbanecm) [18:59:30] (03Merged) 10jenkins-bot: Validate in WikiPageConfigWriter rather than in Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681112 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [20:06:31] 10Growth-Team, 10Add-Link: Review changes button does not show diff in Visual mode - https://phabricator.wikimedia.org/T280980 (10RHo) [20:07:11] 10Growth-Team, 10Add-Link: Review changes button does not show diff in Visual mode - https://phabricator.wikimedia.org/T280980 (10RHo) >>! In T280980#7031970, @Tgr wrote: > @RHo I think this is the wrong parent task for {T280846}. Yes sorry, removed! [20:52:08] 10Edit-Review-Improvements, 10Growth-Team, 10Growth-Team-Filtering: Fix "JQMIGRATE: jQuery.fn.offset() requires an element connected to a document" in RCFilters - https://phabricator.wikimedia.org/T175991 (10Krinkle) [20:52:34] 10Growth-Team, 10Growth-Team-Filtering, 10PageCuration, 10Patch-For-Review, and 2 others: PageTriage gives deprecation warnings - https://phabricator.wikimedia.org/T216800 (10Krinkle) [20:58:48] 10Growth-Team, 10Growth-Team-Filtering, 10PageCuration, 10Patch-For-Review, and 2 others: PageTriage gives deprecation warnings - https://phabricator.wikimedia.org/T216800 (10Krinkle) [21:00:14] 10Growth-Team, 10Growth-Team-Filtering, 10PageCuration, 10Patch-For-Review, and 2 others: PageTriage gives deprecation warnings - https://phabricator.wikimedia.org/T216800 (10Krinkle) Detaching since these are not polyfilled by jQuery Migrate, these methods still exist in jQuery 3 fine even without migrate... [21:19:20] (03PS6) 10DannyS712: Replace bind/unbind function calls with on/off [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/553842 (https://phabricator.wikimedia.org/T216800) [22:06:27] (03PS1) 10Urbanecm: WikiPageConfig: Do not make multiple DB requests with READ_LATEST [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682340 (https://phabricator.wikimedia.org/T274520) [22:13:41] (03CR) 10Urbanecm: "> Patch Set 11:" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [22:14:32] (03CR) 10Urbanecm: Special:EditGrowthConfig should not use cache to load config (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [22:16:25] (03CR) 10jerkins-bot: [V: 04-1] WikiPageConfig: Do not make multiple DB requests with READ_LATEST [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682340 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [22:19:10] (03PS4) 10Urbanecm: Decouple validation from UI definition [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) [22:19:22] (03CR) 10Urbanecm: Decouple validation from UI definition (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:20:24] (03PS2) 10Urbanecm: WikiPageConfig: Do not make multiple DB requests with READ_LATEST [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682340 (https://phabricator.wikimedia.org/T274520) [22:20:40] (03PS3) 10Urbanecm: Special:EditGrowthConfig: Use radio buttons rather than checkboxes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681124 (https://phabricator.wikimedia.org/T280352) [22:24:43] (03PS18) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) [22:24:52] (03CR) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:24:57] (03PS19) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) [22:24:59] (03CR) 10jerkins-bot: [V: 04-1] Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:26:30] (03PS3) 10Urbanecm: WikiPageConfig: Do not make multiple DB requests with READ_LATEST [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682340 (https://phabricator.wikimedia.org/T274520) [22:43:10] (03CR) 10Gergő Tisza: Decouple validation from UI definition (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:48:42] (03CR) 10Gergő Tisza: Decouple validation from UI definition (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:51:12] (03PS5) 10Urbanecm: Decouple validation from UI definition [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) [22:52:19] (03PS6) 10Urbanecm: Decouple validation from UI definition [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) [22:52:49] (03PS4) 10Urbanecm: Remove "Tutorial page title" from from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681171 (https://phabricator.wikimedia.org/T280350) [22:53:25] (03CR) 10Gergő Tisza: [C: 03+2] Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [22:53:52] (03PS4) 10Urbanecm: Special:EditGrowthConfig: Use radio buttons rather than checkboxes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681124 (https://phabricator.wikimedia.org/T280352) [22:54:32] (03PS20) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) [22:54:47] (03PS5) 10Urbanecm: Remove "Tutorial page title" from from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681171 (https://phabricator.wikimedia.org/T280350) [22:58:13] (03PS21) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) [23:09:41] (03CR) 10Gergő Tisza: "> Caching READ_LATEST calls doesn't sound like a good idea, especially considering WikiPageConfig is actually a service, which means it ge" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/679920 (https://phabricator.wikimedia.org/T280282) (owner: 10Urbanecm) [23:10:02] (03PS6) 10Urbanecm: Remove "Tutorial page title" from from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681171 (https://phabricator.wikimedia.org/T280350) [23:11:06] (03CR) 10Gergő Tisza: [C: 03+2] Decouple validation from UI definition [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [23:15:41] (03CR) 10Gergő Tisza: [C: 04-1] Allow users to maintain help panel links from Special:EditGrowthConfig (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [23:22:17] (03Merged) 10jenkins-bot: Decouple validation from UI definition [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681115 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [23:22:52] (03Merged) 10jenkins-bot: Special:EditGrowthConfig: Use radio buttons rather than checkboxes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/681124 (https://phabricator.wikimedia.org/T280352) (owner: 10Urbanecm) [23:24:59] (03CR) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [23:25:04] (03PS22) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) [23:48:30] (03PS1) 10Urbanecm: i18n: Special:EditGrowthConfig: Fix a terrible typo [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682343 [23:50:15] (03PS1) 10Urbanecm: Special:EditGrowthConfig: config-changed copy changes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682344 [23:50:31] (03CR) 10Gergő Tisza: Allow users to maintain help panel links from Special:EditGrowthConfig (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [23:57:03] (03CR) 10Gergő Tisza: [C: 03+2] i18n: Special:EditGrowthConfig: Fix a terrible typo [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682343 (owner: 10Urbanecm) [23:58:14] (03CR) 10Gergő Tisza: Special:EditGrowthConfig: config-changed copy changes (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/682344 (owner: 10Urbanecm) [23:59:30] (03PS23) 10Urbanecm: Allow users to maintain help panel links from Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/677916 (https://phabricator.wikimedia.org/T274031)