[00:25:46] (03CR) 10DannyS712: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/673798 (owner: 10DannyS712) [07:28:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] TitleFactory is not @newable, retrieve from MediaWikiServices (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/673798 (owner: 10DannyS712) [07:49:54] (03Merged) 10jenkins-bot: TitleFactory is not @newable, retrieve from MediaWikiServices [extensions/Echo] - 10https://gerrit.wikimedia.org/r/673798 (owner: 10DannyS712) [09:13:36] 10Growth-Team, 10Add-Link: Define SLIs/SLOs for link recommendation service - https://phabricator.wikimedia.org/T278083 (10kostajh) [09:16:08] (03PS2) 10Kosta Harlan: LinkRecommendation: Modify path args for calls to API [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673816 (https://phabricator.wikimedia.org/T277865) [10:19:48] (03PS1) 10Gergő Tisza: Fix refreshLinkRecommendations.php task count check [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673974 [10:26:06] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10Tgr) [10:28:43] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10kostajh) [10:30:15] (03CR) 10Kosta Harlan: [C: 03+2] Fix refreshLinkRecommendations.php task count check [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673974 (owner: 10Gergő Tisza) [10:32:13] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10Tgr) Some options: * Parallel requests via MultiHttpRequest. This might help with the first problem but not the second (but maybe if the speedup is sufficient the second stops... [10:33:08] 10Growth-Team, 10Editing-Team-Request, 10Growth-Structured-Tasks: Generic framework for implementing suggestions in VisualEditor - https://phabricator.wikimedia.org/T261400 (10kostajh) [10:33:31] 10Growth-Team, 10Editing-Team-Request, 10Growth-Structured-Tasks: Generic framework for implementing suggestions in VisualEditor - https://phabricator.wikimedia.org/T261400 (10kostajh) Removing from the list of tasks needed for our initial release, though we should revisit this again in the context of the #i... [10:33:57] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10Tgr) A somewhat related issue is that the script turns task candidates into tasks, and this can get very slow if most task candidates are unsuitable (e.g. on a small wiki wher... [10:41:38] 10Growth-Team, 10Add-Link: Add a link engineering: cronjob to clean up old entries in growthexperiments_link_recommendations - https://phabricator.wikimedia.org/T275790 (10kostajh) IIRC we were going to do this by listening after page edit and invaliding the cache and search index that way, or is the proposed... [10:42:53] 10Growth-Team, 10Add-Link: Ensure MediaWiki sets the X-Request-Id header on linkrecommendation service requests, and mwaddlink includes it in its logs - https://phabricator.wikimedia.org/T276436 (10kostajh) 05Open→03Invalid >>! In T276436#6882612, @Tgr wrote: > X-Request-Id is set on outgoing MediaWiki req... [10:43:51] (03Merged) 10jenkins-bot: Fix refreshLinkRecommendations.php task count check [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673974 (owner: 10Gergő Tisza) [10:43:56] 10Growth-Team, 10Add-Link: Lock database to prevent parallel jobs from erroring out - https://phabricator.wikimedia.org/T274978 (10kostajh) 05Open→03Declined Declining, if it becomes a problem we could reopen this. [10:46:09] 10Growth-Team, 10Add-Link: Add a link engineering: cronjob to clean up old entries in growthexperiments_link_recommendations - https://phabricator.wikimedia.org/T275790 (10Tgr) We do that for the index but not for the cache. That might be a better option, I didn't want to impact page save performance but I gue... [10:47:42] 10Growth-Team, 10Add-Link: Add a link engineering: cronjob to clean up old entries in growthexperiments_link_recommendations - https://phabricator.wikimedia.org/T275790 (10kostajh) >>! In T275790#6934035, @Tgr wrote: > We do that for the index but not for the cache. That might be a better option, I didn't want... [10:48:10] 10Growth-Team, 10Add-Link: Add a link engineering: clean up old entries in growthexperiments_link_recommendations - https://phabricator.wikimedia.org/T275790 (10kostajh) [10:53:50] 10Growth-Team, 10Add-Link: Ensure MediaWiki sets the X-Request-Id header on linkrecommendation service requests, and mwaddlink includes it in its logs - https://phabricator.wikimedia.org/T276436 (10Tgr) Yeah, sorry, I didn't realize it got included in MediaWiki requests by default. And it seems like `json_log... [11:44:22] 10Growth-Team, 10DiscussionTools, 10GrowthExperiments-Help panel, 10VisualEditor, 10OWC2020 (OWC2020 Replying 1.0): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10Tgr) We assumed this is not too much of an issue since... [12:13:11] (03PS1) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:13:24] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) (owner: 10Urbanecm) [12:22:27] (03PS2) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:28:05] (03PS3) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:30:51] (03PS4) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:42:00] (03PS5) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:43:39] (03PS6) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:47:33] (03CR) 10Ottomata: Finalize event platform migration (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/666651 (https://phabricator.wikimedia.org/T267333) (owner: 10Ottomata) [12:54:28] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) (owner: 10Urbanecm) [12:55:53] (03PS7) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [12:59:27] (03PS8) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [13:12:19] (03PS9) 10Urbanecm: WIP: Create DatabaseMentorManager for loading data from database [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673999 (https://phabricator.wikimedia.org/T275773) [13:16:48] (03PS27) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [13:17:00] (03PS28) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [13:27:48] (03CR) 10DannyS712: [C: 04-1] Introduce Special:EditGrowthConfig (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [13:35:08] 10Growth-Team, 10Growth-Structured-Tasks: Add a link engineering: Investigate adding a third mode to VisualEditor's read / edit modes - https://phabricator.wikimedia.org/T261399 (10kostajh) [13:37:26] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks, 10GrowthExperiments: Add a link: mobile swiping gesture in suggested edits feed - https://phabricator.wikimedia.org/T268709 (10kostajh) [13:37:41] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks, 10GrowthExperiments: Add a link: mobile navigation in suggested edits module - https://phabricator.wikimedia.org/T268708 (10kostajh) [14:58:26] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, and 4 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10dancy) p:05Triage→03Unbreak! [15:55:12] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [16:11:18] 10Growth-Team, 10Growth-Scaling, 10Growth-Deployments: Deploy Growth features on Simple English Wikipedia - https://phabricator.wikimedia.org/T277550 (10Trizek-WMF) [[https://simple.wikipedia.org/wiki/Wikipedia:Simple_talk#%5Bupcoming_deployment%5D_Growth_team_features|I notified the community]]. [16:24:56] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10Tgr) Loosely related: there should be some kind of back-off when the service request fails, to avoid hammering it when it's overloaded. [16:32:40] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, and 4 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10daniel) After @brennen deployed PEtr's fix, I see exactly one occurrence that wasn't triggered via runSin... [17:39:10] 10Growth-Team-Leftovers, 10MediaWiki-General, 10Growth-Team (Current Sprint), 10JavaScript, and 2 others: Support the WebRequest / WebResponse SameSite behavior on the JS side - https://phabricator.wikimedia.org/T257936 (10alistair3149) >>! In T257936#6935555, @gerritbot wrote: > Change 674106 had a relate... [17:40:20] 10Growth-Team-Leftovers, 10MediaWiki-General, 10Growth-Team (Current Sprint), 10JavaScript, and 3 others: Support the WebRequest / WebResponse SameSite behavior on the JS side - https://phabricator.wikimedia.org/T257936 (10alistair3149) [17:47:19] (03PS29) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [17:47:23] (03CR) 10Urbanecm: Introduce Special:EditGrowthConfig (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [17:58:01] 10Growth-Team-Leftovers, 10Add-Link, 10Growth-Structured-Tasks, 10GrowthExperiments, 10Growth-Team (Current Sprint): Add a link [leftovers]: Add robot icon and paragraph break to the task type info pop-up in the suggested edits module - https://phabricator.wikimedia.org/T278159 (10RHo) [18:09:10] 10Growth-Team, 10GrowthExperiments-Homepage: [SuggestedEdits] Provide a way to redirect users to a set of filtered tasks on their Homepage - https://phabricator.wikimedia.org/T278163 (10Trizek-WMF) [18:33:43] (03PS1) 10MewOphaswongse: [WIP] Add a link: AI suggestions mode: update toolbar & publish button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/674102 (https://phabricator.wikimedia.org/T278165) [19:07:29] 10Growth-Team, 10PageCuration, 10Patch-Needs-Improvement: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10Aklapper) [19:51:27] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10kostajh) Was just discussing this with @MMiller_WMF as a candidate for something to work on after the initial release, as we only need the task pool populated for our four tar... [20:24:52] (03CR) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [20:24:58] (03PS13) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) [20:25:07] 10Growth-Team, 10Add-Link: Parallelize GrowthExperiments' refreshLinkRecommendations.php - https://phabricator.wikimedia.org/T278103 (10Tgr) Makes sense. Let's get verbose logging deployed first though so we have a better idea of what the script is doing. (Btw normal cronjob logging will probably get messed u... [20:36:35] (03CR) 10jerkins-bot: [V: 04-1] Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [20:37:20] (03PS1) 10Kosta Harlan: Add a link: dialog for no suggestions available [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/674141 (https://phabricator.wikimedia.org/T277508) [20:42:02] (03PS4) 10Kosta Harlan: Fix StartEditing breakage for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) [20:42:25] (03CR) 10Kosta Harlan: Fix StartEditing breakage for variant C users (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [20:45:02] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, and 4 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10daniel) This may have the same root cause as T224949: A transaction that inserted into the actor table wa... [22:25:41] 10Growth-Team: Deploy Growth experiments at Latvian Wikipedia - https://phabricator.wikimedia.org/T278191 (10Papuass) [22:52:22] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, and 4 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Pchelolo) Status update: we expect https://gerrit.wikimedia.org/r/674131 to completely mitigate the issue...