[00:06:21] (03PS4) 10Gergő Tisza: Prefer UserIdentity interface over User class where possible [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [00:06:37] (03CR) 10Gergő Tisza: "User::getUserId() has been removed since this patch was written." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [00:10:27] 10Growth-Team, 10GrowthExperiments, 10Wikimedia-production-error: TypeError: task is undefined - https://phabricator.wikimedia.org/T277726 (10Jdlrobson) [00:10:38] 10Growth-Team, 10GrowthExperiments, 10Wikimedia-production-error: TypeError: task is undefined at homepage/suggestededits/ext.growthExperiments.NewcomerTaskLogger.js - https://phabricator.wikimedia.org/T277726 (10Jdlrobson) [00:56:12] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10SyntaxHighlight: Flow: syntax highlighting tags (GeSHi) don't get styled - https://phabricator.wikimedia.org/T59159 (10Krinkle) As a recent example, this can be seen at . [01:02:56] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10SyntaxHighlight: Flow: syntax highlighting tags (GeSHi) don't get styled - https://phabricator.wikimedia.org/T59159 (10Krinkle) >>! In T59159#6923746, @Krinkle wrote: > As a recent example, this can be seen at 10Growth-Team, 10Analytics, 10Analytics-Kanban, 10Product-Analytics: Revisions missing from mediawiki_revision_create - https://phabricator.wikimedia.org/T215001 (10Milimetric) (tl;dr; no simple answers) As this is becoming a pivotal issue I wanted to make sure to exhaust simple explanations. My query is... [09:37:57] (03PS1) 10Kosta Harlan: Fix StartEditing breakage for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) [09:38:13] (03PS2) 10Kosta Harlan: Fix StartEditing breakage for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) [09:40:45] (03PS3) 10Kosta Harlan: Fix StartEditing breakage for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) [09:41:25] (03CR) 10Kosta Harlan: "Caused T277727" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/669872 (https://phabricator.wikimedia.org/T272754) (owner: 10Kosta Harlan) [09:43:13] (03CR) 10Kosta Harlan: Fix StartEditing breakage for variant C users (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [09:47:33] (03PS1) 10Kosta Harlan: Remove variant C from list of valid variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) [09:49:47] (03CR) 10Kosta Harlan: "See also I89d1180fe501dde12b6de10dd8f3b3a45a6f5708 which is probably safer for backporting purposes." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [09:54:44] (03CR) 10Kosta Harlan: [C: 03+2] Fix "no transaction to commit" logspam [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673150 (https://phabricator.wikimedia.org/T277702) (owner: 10Gergő Tisza) [09:57:48] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Add a link in VE: consider using a permanent context instead of VE's built-in context - https://phabricator.wikimedia.org/T267706 (10kostajh) [09:58:01] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Add a link in VE: consider using a permanent context instead of VE's built-in context - https://phabricator.wikimedia.org/T267706 (10kostajh) [09:58:03] 10Growth-Team, 10Growth-Structured-Tasks, 10Epic: [EPIC] Growth: "add a link" structured task improvements - https://phabricator.wikimedia.org/T276517 (10kostajh) [10:00:58] (03CR) 10jerkins-bot: [V: 04-1] Remove variant C from list of valid variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [10:02:29] (03PS2) 10Kosta Harlan: Remove variant C from list of valid variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) [10:24:31] (03Merged) 10jenkins-bot: Fix "no transaction to commit" logspam [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673150 (https://phabricator.wikimedia.org/T277702) (owner: 10Gergő Tisza) [10:32:19] (03CR) 10Urbanecm: [C: 03+1] "i confirm this patch fixes the bug reported in T277727. Treat as a +2 for the purpose of backporting." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [10:52:26] (03CR) 10Gergő Tisza: [C: 03+2] Remove variant C from list of valid variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [10:56:57] (03PS1) 10Kosta Harlan: Remove variant C from list of valid variants [extensions/GrowthExperiments] (wmf/1.36.0-wmf.35) - 10https://gerrit.wikimedia.org/r/673107 (https://phabricator.wikimedia.org/T277727) [11:01:22] (03CR) 10Urbanecm: [C: 03+2] Remove variant C from list of valid variants [extensions/GrowthExperiments] (wmf/1.36.0-wmf.35) - 10https://gerrit.wikimedia.org/r/673107 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [11:07:42] (03Merged) 10jenkins-bot: Remove variant C from list of valid variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673218 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [11:12:53] (03Merged) 10jenkins-bot: Remove variant C from list of valid variants [extensions/GrowthExperiments] (wmf/1.36.0-wmf.35) - 10https://gerrit.wikimedia.org/r/673107 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [11:21:26] 10Growth-Team, 10GrowthExperiments-Homepage, 10Mobile, 10good first task: [minor-mobile] Newcomer homepage module should use the equivalent 'arrow previous' icon as the 'arrow next' in the module preview - https://phabricator.wikimedia.org/T276924 (10VartikaS12) Hey, @Aklapper I want to work on this issue,... [12:32:28] (03CR) 10Kosta Harlan: [C: 03+2] Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [12:33:48] 10Growth-Team, 10GrowthExperiments-Homepage, 10Mobile, 10good first task: [minor-mobile] Newcomer homepage module should use the equivalent 'arrow previous' icon as the 'arrow next' in the module preview - https://phabricator.wikimedia.org/T276924 (10Aklapper) @VartikaS12: Hi and welcome. Please read the p... [12:41:28] (03Merged) 10jenkins-bot: Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [12:50:14] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [12:53:02] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [12:53:27] (03CR) 10Kosta Harlan: [C: 04-1] "Looks good overall! Just some minor style fixes needed." (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [12:57:07] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BlueSpice, and 14 others: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName - https://phabricator.wikimedia.org/T275030 (10Vlad.shapik) [12:57:18] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [13:02:06] (03CR) 10Gergő Tisza: Fix StartEditing breakage for variant C users (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673216 (https://phabricator.wikimedia.org/T277727) (owner: 10Kosta Harlan) [14:16:53] (03Merged) 10jenkins-bot: Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/670263 (https://phabricator.wikimedia.org/T276412) (owner: 10Vadim Kovalenko) [15:38:52] 10Growth-Team, 10Notifications, 10Community-Tech, 10GrowthExperiments, and 12 others: Avoid using User ::isIP, ::getOptions - https://phabricator.wikimedia.org/T275602 (10ppelberg) [15:56:08] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BlueSpice, and 14 others: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName - https://phabricator.wikimedia.org/T275030 (10Vlad.shapik) [15:56:24] (03PS5) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) [15:56:32] (03CR) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [16:06:35] (03CR) 10jerkins-bot: [V: 04-1] WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [16:10:44] (03PS26) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [16:10:46] (03CR) 10Urbanecm: Introduce Special:EditGrowthConfig (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [16:12:24] (03PS6) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) [16:16:53] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BlueSpice, and 14 others: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName - https://phabricator.wikimedia.org/T275030 (10Nikerabbit) I suppose you meant Translate instead of translatewiki. [16:24:07] (03CR) 10jerkins-bot: [V: 04-1] Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [16:35:07] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BlueSpice, and 14 others: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName - https://phabricator.wikimedia.org/T275030 (10Vlad.shapik) Yes, sorry! [17:42:09] (03CR) 10Gergő Tisza: [C: 03+2] "> Sure. This is a step in this direction. Utilizing actual dependency injection would be good, yes. But it would make this patch much bigg" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [17:47:58] 10Growth-Team, 10Growth-Scaling, 10Growth-Deployments, 10Patch-For-Review: Deploy Growth features on Simple English Wikipedia - https://phabricator.wikimedia.org/T277550 (10Urbanecm_WMF) p:05Triage→03Medium [17:49:15] 10Growth-Team, 10Growth-Scaling, 10Growth-Deployments, 10Patch-For-Review: Deploy Growth features on Simple English Wikipedia - https://phabricator.wikimedia.org/T277550 (10Urbanecm_WMF) a:03Trizek-WMF @Trizek-WMF This was just done (in stealth mode). [18:00:29] (03Merged) 10jenkins-bot: Prefer UserIdentity interface over User class where possible [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [18:12:27] (03CR) 10Gergő Tisza: [C: 03+2] WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [18:17:11] (03CR) 10Gergő Tisza: [C: 03+2] Use UserIdentityLookup for batch user operations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663378 (owner: 10Ppchelko) [18:19:47] (03PS7) 10Gergő Tisza: Avoid using User::getOptions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/666605 (https://phabricator.wikimedia.org/T275602) (owner: 10Vlad.shapik) [18:23:09] (03Merged) 10jenkins-bot: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [18:27:58] (03Merged) 10jenkins-bot: Use UserIdentityLookup for batch user operations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663378 (owner: 10Ppchelko) [18:30:50] (03CR) 10Gergő Tisza: [C: 03+2] Avoid using User::getOptions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/666605 (https://phabricator.wikimedia.org/T275602) (owner: 10Vlad.shapik) [18:43:38] (03Merged) 10jenkins-bot: Avoid using User::getOptions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/666605 (https://phabricator.wikimedia.org/T275602) (owner: 10Vlad.shapik) [18:44:22] 10Growth-Team, 10Notifications, 10Community-Tech, 10GrowthExperiments, and 12 others: Avoid using User ::isIP, ::getOptions - https://phabricator.wikimedia.org/T275602 (10Vlad.shapik) [18:46:38] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Mobile-Web-Settings, and 5 others: Notifications cannot be displayed from search result pages in mobile version - https://phabricator.wikimedia.org/T275901 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson I can confirm this is fixed on https://he.m.wikip... [19:55:34] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Engineering, 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10brennen) [19:56:35] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Pchelolo) [20:15:44] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Pchelolo) Interesting. Definitely a fallout of https://gerrit.wikimedia.org/r/c/mediawiki/co... [20:17:57] (03PS1) 10Gergő Tisza: refreshLinkRecommendations.php: Don't init tasks when disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673355 (https://phabricator.wikimedia.org/T277798) [20:21:48] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10daniel) >>! In T277795#6926585, @Pchelolo wrote: > Interesting. Definitely a fallout of http... [20:25:21] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10daniel) If the above is the reason, I can see two solutions: * make sure we remember all act... [20:26:07] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Pchelolo) It seems like it happens for recent changes for anons who just made their first co... [20:30:01] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Pchelolo) > try harder to look up actors by falling back to master of the ID isn't found. Si... [20:43:46] 10Growth-Team, 10GrowthExperiments: Add links: post-edit dialog option "Close and edit this article again" re-starts Add links tasks - https://phabricator.wikimedia.org/T277802 (10Etonkovidova) [21:08:35] (03PS1) 10Zabe: Avoid using User::getIntOption() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/673361 (https://phabricator.wikimedia.org/T277600) [21:08:56] 10Growth-Team, 10MediaWiki-Recent-changes, 10Platform Team Workboards (MW Expedition), 10User-brennen, 10Wikimedia-production-error: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10brennen) Now up to 43 of these since deploy. I'm inclined to think this is probably a train... [21:17:47] 10Growth-Team, 10GrowthExperiments: Add links: VE "Review your edits" does not display Add links edits correctly. - https://phabricator.wikimedia.org/T277806 (10Etonkovidova) [21:29:15] 10Growth-Team, 10GrowthExperiments: Add links: VE "Review your edits" does not display Add links edits correctly. - https://phabricator.wikimedia.org/T277806 (10kostajh) @Etonkovidova I think we could merge this into {T269657} [21:30:33] 10Growth-Team, 10GrowthExperiments: Add links: post-edit dialog option "Close and edit this article again" re-starts Add links tasks - https://phabricator.wikimedia.org/T277802 (10kostajh) I'd propose to close this task in favor of {T269659} [21:30:54] (03CR) 10Kosta Harlan: [C: 03+2] refreshLinkRecommendations.php: Don't init tasks when disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673355 (https://phabricator.wikimedia.org/T277798) (owner: 10Gergő Tisza) [21:30:59] 10Growth-Team, 10GrowthExperiments: Add links: VE "Review your edits" does not display Add links edits correctly. - https://phabricator.wikimedia.org/T277806 (10Etonkovidova) >>! In T277806#6926856, @kostajh wrote: > @Etonkovidova I think we could merge this into {T269657} Right, this task can be served as a... [21:31:53] 10Growth-Team, 10GrowthExperiments: Add links: VE "Review your edits" does not display Add links edits correctly. - https://phabricator.wikimedia.org/T277806 (10Etonkovidova) [21:38:23] 10Growth-Team, 10GrowthExperiments: Add links: post-edit dialog option "Close and edit this article again" re-starts Add links tasks - https://phabricator.wikimedia.org/T277802 (10Etonkovidova) 05Open→03Declined >>! In T277802#6926862, @kostajh wrote: > I'd propose to close this task in favor of {T269659}... [21:44:45] (03Merged) 10jenkins-bot: refreshLinkRecommendations.php: Don't init tasks when disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673355 (https://phabricator.wikimedia.org/T277798) (owner: 10Gergő Tisza) [21:57:23] 10Growth-Team, 10GrowthExperiments: Add links: "Works cited" displays add links suggestions - https://phabricator.wikimedia.org/T277812 (10Etonkovidova) [22:06:28] (03PS3) 10Gergő Tisza: Filter link recommendation links on demand [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672157 (https://phabricator.wikimedia.org/T266437) [22:17:14] (03CR) 10jerkins-bot: [V: 04-1] Filter link recommendation links on demand [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672157 (https://phabricator.wikimedia.org/T266437) (owner: 10Gergő Tisza) [22:59:43] 10Growth-Team, 10MediaWiki-Recent-changes, 10Patch-For-Review, 10Performance-Team (Radar), and 3 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Krinkle) [23:00:07] 10Growth-Team, 10MediaWiki-Recent-changes, 10Patch-For-Review, 10Performance-Team (Radar), and 3 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10Krinkle) >>! In T277795#6926635, @daniel wrote: > If the above is the reason, I can see two solutions: > * make sure we re... [23:09:33] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, and 4 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10brennen) > Mentioned in SAL (#wikimedia-operations) [2021-03-18T23:06:44Z] train status: 1.36.0... [23:35:59] 10Growth-Team, 10MediaWiki-Recent-changes, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Performance-Team (Radar), and 3 others: User not found by actor ID: [id] - https://phabricator.wikimedia.org/T277795 (10brennen) > I may have spoken too soon. 2 more of these since 23:05 UTC. Disregard; synced wrong... [23:47:05] 10Growth-Team, 10Growth-Scaling: Scale: streamlined configuration - https://phabricator.wikimedia.org/T246939 (10Etonkovidova)