[00:59:07] (03PS5) 10Urbanecm: Prepare a maintenance script for providing default values for on-wiki config [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) [00:59:20] (03CR) 10Urbanecm: [C: 03+2] "per Gergo" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) (owner: 10Urbanecm) [01:09:17] (03Merged) 10jenkins-bot: Prepare a maintenance script for providing default values for on-wiki config [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) (owner: 10Urbanecm) [10:04:29] (03PS2) 10Kosta Harlan: Guard against undefined suggestion [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672707 (https://phabricator.wikimedia.org/T276838) [10:04:48] (03CR) 10Kosta Harlan: Guard against undefined suggestion (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672707 (https://phabricator.wikimedia.org/T276838) (owner: 10Kosta Harlan) [10:05:28] (03Abandoned) 10Kosta Harlan: [WIP] Ensure consistent access to Mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/666211 (owner: 10Kosta Harlan) [10:27:23] (03CR) 10Gergő Tisza: [C: 03+2] Guard against undefined suggestion [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672707 (https://phabricator.wikimedia.org/T276838) (owner: 10Kosta Harlan) [10:40:42] (03Merged) 10jenkins-bot: Guard against undefined suggestion [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672707 (https://phabricator.wikimedia.org/T276838) (owner: 10Kosta Harlan) [10:58:00] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BetaFeatures, and 12 others: Avoid using User ::addGroup, ::removeGroup, ::getAllGroups, ::clearNotification - https://phabricator.wikimedia.org/T276094 (10ArTrix) [10:58:17] 10Growth-Team, 10Notifications, 10AbuseFilter, 10BetaFeatures, and 12 others: Avoid using User ::addGroup, ::removeGroup, ::getAllGroups, ::clearNotification - https://phabricator.wikimedia.org/T276094 (10ArTrix) [11:01:30] (03CR) 10Gergő Tisza: [C: 04-1] "Should use dependency injection for UserEditTracker." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672802 (https://phabricator.wikimedia.org/T277596) (owner: 10Zabe) [11:04:52] 10Growth-Team, 10Notifications: Update Echo for the EditResult revert detection improvements - https://phabricator.wikimedia.org/T277649 (10matmarex) [11:05:42] 10Growth-Team, 10Notifications, 10Editing-team (FY2020-21 Kanban Board): Update Echo for the EditResult revert detection improvements - https://phabricator.wikimedia.org/T277649 (10matmarex) a:03matmarex [11:25:33] 10Growth-Team, 10Notifications, 10Editing-team (FY2020-21 Kanban Board): Update Echo for the EditResult revert detection improvements - https://phabricator.wikimedia.org/T277649 (10kostajh) @matmarex you may want to look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/608884 as part of this [11:41:28] 10Growth-Team, 10Notifications, 10Editing-team (FY2020-21 Kanban Board): Update Echo for the EditResult revert detection improvements - https://phabricator.wikimedia.org/T277649 (10matmarex) I've seen it, but it also includes functional changes, and I'd like to keep this to just a code cleanup, to make it ea... [11:58:44] (03PS1) 10Bartosz Dziewoński: Remove redundant check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/673002 [11:58:46] (03PS1) 10Bartosz Dziewoński: Simplify code for detecting rollbacks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/673003 (https://phabricator.wikimedia.org/T277649) [12:00:31] (03CR) 10Bartosz Dziewoński: "I'm doing the EditResult-related cleanup part of this in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/673003" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:01:24] (03CR) 10Bartosz Dziewoński: "The problems with EchoTalkPageFunctionalTest might be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/668228" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:02:49] (03CR) 10Ostrzyciel: "> Patch Set 40:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:09:57] 10Growth-Team, 10Notifications: Revert notifications in Echo when "non-edit" contributions are in page history - https://phabricator.wikimedia.org/T85728 (10matmarex) [12:10:06] 10Growth-Team, 10Notifications: Revert notification send to user who just protected a page - https://phabricator.wikimedia.org/T235609 (10matmarex) [12:13:47] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications: reverting a talk page shouldn't send Echo mentioning notification - https://phabricator.wikimedia.org/T118552 (10matmarex) This has been fixed in 2018 as T189819. [12:14:12] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications: reverting a talk page shouldn't send Echo mentioning notification - https://phabricator.wikimedia.org/T118552 (10matmarex) [12:14:16] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech: Revert to last revision by user should not mention - https://phabricator.wikimedia.org/T189819 (10matmarex) [12:16:05] 10Growth-Team, 10Notifications: Duplicate revert notification received - https://phabricator.wikimedia.org/T128504 (10matmarex) 05Open→03Declined I don't think it's realistic to debug this 5 years later, and I haven't seen any more recent reports of this bug. If this was caused by T123843 as @catrope guess... [12:17:08] 10Growth-Team, 10Notifications: A revert on own user talk page should give only one notification - https://phabricator.wikimedia.org/T233908 (10matmarex) [12:17:27] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications: Edit revert should not trigger a talk page post notification if the edit being reverted was performed by the owner of the talk page - https://phabricator.wikimedia.org/T49143 (10matmarex) [12:22:47] (03CR) 10Gergő Tisza: "Would be nice to show some kind of explanation on top of the config page which says what the page is for and maybe linking to the form (th" (0310 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [12:25:32] (03CR) 10Gergő Tisza: "I think we need proper validation in place before doing this. Right now you can provide an array when the code expects a string etc, set a" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [12:33:29] (03PS41) 10Bartosz Dziewoński: Notify users of multi-revision reverts; EditResult-related cleanup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:34:46] (03CR) 10Bartosz Dziewoński: "Rebased on top of my patch" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:34:55] (03PS42) 10Bartosz Dziewoński: Notify users of multi-revision reverts; EditResult-related cleanup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:35:14] (03CR) 10Bartosz Dziewoński: "Undid the change to EchoTalkPageFunctionalTest, let's see if it passes" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [12:53:52] 10Growth-Team, 10StructuredDiscussions: Boite de discussion - https://phabricator.wikimedia.org/T277643 (10MarcoAurelio) a:05Pierre_Andre_Leclercq→03None Hello @Pierre_Andre_Leclercq. Welcome to Phabricator. Unfortunatelly your report is missing some information such as where (which site) this bug is happe... [12:54:40] 10Growth-Team, 10StructuredDiscussions: Boite de discussion - https://phabricator.wikimedia.org/T277643 (10MarcoAurelio) [12:57:02] 10Growth-Team, 10StructuredDiscussions: Fatal exception on StructuredDiscussions talk page at fr.wikipedia - https://phabricator.wikimedia.org/T277643 (10MarcoAurelio) [12:59:11] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Wikimedia-production-error: Fatal exception on StructuredDiscussions talk page at fr.wikipedia - https://phabricator.wikimedia.org/T277643 (10MarcoAurelio) Fatal exception when visiting https://fr.wikipedia.org/wiki/Discussion_utilisateur... [12:59:29] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Wikimedia-production-error: Fatal exception on StructuredDiscussions talk page at fr.wikipedia - https://phabricator.wikimedia.org/T277643 (10MarcoAurelio) [13:01:45] (03CR) 10jerkins-bot: [V: 04-1] Notify users of multi-revision reverts; EditResult-related cleanup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [13:03:01] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Wikimedia-production-error: Fatal exception on StructuredDiscussions talk page at fr.wikipedia - https://phabricator.wikimedia.org/T277643 (10kostajh) This is an instance of {T265534}. [13:08:23] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Wikimedia-production-error: Fatal exception on StructuredDiscussions talk page at fr.wikipedia - https://phabricator.wikimedia.org/T277643 (10kostajh) ` mwscript extensions/Flow/maintenance/FlowFixInconsistentBoards.php --wiki=frwiki --na... [14:25:47] 10Notifications, 10The-Wikipedia-Library (Kanban): Implement a way to roll the notification out gradually based on global edit count - https://phabricator.wikimedia.org/T271921 (10Samwalton9) - Once we have the data and a rollout plan we should ask another team to sanity check whether this is a sensible plan -... [14:43:01] 10Growth-Team, 10Notifications, 10The-Wikipedia-Library, 10User-notice, 10Wikimedia-extension-review-queue: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084 (10Samwalton9) [14:43:08] 10Notifications, 10The-Wikipedia-Library (Kanban): Implement a way to roll the notification out gradually based on global edit count - https://phabricator.wikimedia.org/T271921 (10Samwalton9) 05Open→03Resolved a:03Samwalton9 We confirmed at today's engineering meeting that this is already possible via co... [15:13:52] (03PS2) 10Zabe: Avoid using User::getLatestEditTimestamp [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672802 (https://phabricator.wikimedia.org/T277596) [15:20:24] (03PS3) 10Gergő Tisza: Avoid using User::getLatestEditTimestamp [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672802 (https://phabricator.wikimedia.org/T277596) (owner: 10Zabe) [15:21:29] (03PS3) 10Gergő Tisza: Prefer UserIdentity interface over User class where possible [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [15:21:38] (03PS4) 10Gergő Tisza: Fix smaller mistakes and remove unused code [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668414 (owner: 10Thiemo Kreuz (WMDE)) [15:21:43] (03PS6) 10Gergő Tisza: Prefer UserIdentity::isRegistered() over user::isAnon() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 (owner: 10Thiemo Kreuz (WMDE)) [15:37:15] (03CR) 10jerkins-bot: [V: 04-1] Prefer UserIdentity interface over User class where possible [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668416 (owner: 10Thiemo Kreuz (WMDE)) [16:06:03] (03PS10) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) [16:13:17] (03CR) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [16:13:38] (03CR) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [16:17:56] (03CR) 10jerkins-bot: [V: 04-1] Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [16:19:43] (03PS11) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) [16:36:02] (03CR) 10jerkins-bot: [V: 04-1] Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [17:23:00] 10Growth-Team, 10Desktop Improvements, 10Readers-Web-Backlog: Consider applying 960px max-width to Newcomer Homepage - https://phabricator.wikimedia.org/T277189 (10LGoto) [17:24:52] 10Growth-Team, 10Desktop Improvements, 10Readers-Web-Backlog (Tracking): Consider applying 960px max-width to Newcomer Homepage - https://phabricator.wikimedia.org/T277189 (10LGoto) [17:26:54] 10Growth-Team, 10GrowthExperiments-Homepage, 10Mobile, 10good first task: [minor-mobile] Newcomer homepage module should use the equivalent 'arrow previous' icon as the 'arrow next' in the module preview - https://phabricator.wikimedia.org/T276924 (10Bhargav644) Can i work on it .I will must Solve This. [17:27:37] 10Growth-Team, 10GrowthExperiments-Homepage, 10Mobile, 10good first task: [minor-mobile] Newcomer homepage module should use the equivalent 'arrow previous' icon as the 'arrow next' in the module preview - https://phabricator.wikimedia.org/T276924 (10Bhargav644) from where I can edit this code ??? [17:39:43] 10Growth-Team, 10GrowthExperiments-Homepage, 10Mobile, 10good first task: [minor-mobile] Newcomer homepage module should use the equivalent 'arrow previous' icon as the 'arrow next' in the module preview - https://phabricator.wikimedia.org/T276924 (10Aklapper) @Bhargav644: Hi and welcome. Please follow htt... [17:58:42] (03PS8) 10MewOphaswongse: Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) [18:00:10] (03CR) 10MewOphaswongse: Add a link: onboarding (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [18:07:24] (03CR) 10MewOphaswongse: Add a Link: Open edit mode from JS (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) (owner: 10MewOphaswongse) [18:18:13] (03CR) 10Daniel Kinzler: [C: 03+2] Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/670263 (https://phabricator.wikimedia.org/T276412) (owner: 10Vadim Kovalenko) [18:28:08] (03CR) 10MewOphaswongse: Add robot icon and AI description to difficultyFilter checkbox (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [19:07:21] (03CR) 10MewOphaswongse: Add a Link: Open edit mode from JS (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) (owner: 10MewOphaswongse) [19:12:37] (03PS12) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) [19:24:20] (03CR) 10jerkins-bot: [V: 04-1] Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [19:52:35] (03CR) 10Kosta Harlan: [C: 03+1] Add a Link: Open edit mode from JS (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) (owner: 10MewOphaswongse) [20:08:54] (03CR) 10Ostrzyciel: "I fiddled around with this failing test a bit and uhhh... I'm lost. It does not fail when ran on its own, only when the entire test suite " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [20:26:14] 10Growth-Team, 10Growth-Structured-Tasks, 10Wikimedia-production-error: GrowthExperiments\Maintenance\RefreshLinkRecommendations: no transaction to commit, something got out of sync - https://phabricator.wikimedia.org/T277702 (10Etonkovidova) [21:42:48] (03CR) 10Kosta Harlan: [C: 03+2] Add a Link: Open edit mode from JS [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) (owner: 10MewOphaswongse) [21:52:37] (03Merged) 10jenkins-bot: Add a Link: Open edit mode from JS [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) (owner: 10MewOphaswongse) [21:59:01] (03CR) 10Kosta Harlan: [C: 03+1] Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [21:59:46] (03PS2) 10Esanders: Introduce 'EchoGetEventsForRevision' hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/670498 (https://phabricator.wikimedia.org/T276990) [22:15:18] (03PS9) 10MewOphaswongse: Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) [22:17:51] 10Growth-Team, 10Editing-team, 10VisualEditor, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): EventLogging validation errors for EditAttemptStep - https://phabricator.wikimedia.org/T237063 (10MBinder_WMF) [22:17:57] 10Growth-Team, 10Editing-team, 10StructuredDiscussions, 10VisualEditor, and 2 others: Uncaught Error: Cannot insert (mwHeading, mwTable, paragraph, mwTransclusionBlock) even after closing all containing nodes (at index ) - https://phabricator.wikimedia.org/T259718 (10MBinder_WMF) [22:25:49] (03CR) 10Gergő Tisza: [C: 03+2] Prefer UserIdentity::isRegistered() over user::isAnon() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 (owner: 10Thiemo Kreuz (WMDE)) [22:35:47] (03Merged) 10jenkins-bot: Prefer UserIdentity::isRegistered() over user::isAnon() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 (owner: 10Thiemo Kreuz (WMDE)) [22:58:39] (03PS1) 10Gergő Tisza: Fix "no transaction to commit" logspam [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/673150 (https://phabricator.wikimedia.org/T277702) [23:16:11] (03PS6) 10Krinkle: Remove `jquery.badge.external` RL module [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/666335 (https://phabricator.wikimedia.org/T221269) (owner: 10DannyS712) [23:18:11] (03PS7) 10Krinkle: Remove `jquery.badge.external` RL module [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/666335 (https://phabricator.wikimedia.org/T221269) (owner: 10DannyS712) [23:18:58] (03CR) 10Krinkle: [C: 03+2] Remove `jquery.badge.external` RL module [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/666335 (https://phabricator.wikimedia.org/T221269) (owner: 10DannyS712) [23:35:25] (03CR) 10Gergő Tisza: [C: 03+2] Fix smaller mistakes and remove unused code [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668414 (owner: 10Thiemo Kreuz (WMDE)) [23:42:24] (03Merged) 10jenkins-bot: Remove `jquery.badge.external` RL module [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/666335 (https://phabricator.wikimedia.org/T221269) (owner: 10DannyS712) [23:45:06] (03PS5) 10DannyS712: Merge defaultTagsOptions and defaultDeletionTagsOptions RL modules [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/665183 (https://phabricator.wikimedia.org/T221269) [23:46:43] 10Growth-Team, 10PageCuration, 10MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), 10Patch-For-Review, and 2 others: Reduce module registrations from PageTriage - https://phabricator.wikimedia.org/T221269 (10DannyS712) [23:57:37] (03Merged) 10jenkins-bot: Fix smaller mistakes and remove unused code [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668414 (owner: 10Thiemo Kreuz (WMDE))