[00:07:55] (03CR) 10jerkins-bot: [V: 04-1] Use a lock in refreshLinkRecommendations.php to avoid self-conflict [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [01:27:46] (03CR) 10Reedy: "check php" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/671813 (owner: 10Reedy) [02:10:09] (03PS2) 10Gergő Tisza: Use a lock in refreshLinkRecommendations.php to avoid self-conflict [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 [02:21:28] (03CR) 10Gergő Tisza: [C: 04-2] "I'll need to rethink this. The case where a rejection causes the number of links to drop below the minimum allowed link count should be ha" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672157 (owner: 10Gergő Tisza) [09:35:18] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10MGerlach) @kostajh : - the `ngram_iterator` generates substrings from the text of the article to check as candidate-anchors for links. It will do that by concatenating individual word-tok... [09:42:36] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) >>! In T277342#6912895, @MGerlach wrote: > @kostajh : > - the `ngram_iterator` generates substrings from the text of the article to check as candidate-anchors for links. It will... [09:50:55] (03CR) 10Kosta Harlan: Disable refresh script if $wgGENewcomerTasksRemoteApiUrl is set (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672158 (owner: 10Gergő Tisza) [09:58:21] (03CR) 10Kosta Harlan: Use a lock in refreshLinkRecommendations.php to avoid self-conflict (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [10:02:44] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10MGerlach) > Could we try some libs from `multiprocessing` for the `process_page()` function, specifically around `for gram in ngram_iterator(node, 10, 1):` or higher up in `for node in pa... [10:20:46] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) p:05Triage→03Low >>! In T277342#6912956, @MGerlach wrote: > >> Could we try some libs from `multiprocessing` for the `process_page()` function, specifically around `for gram... [10:46:16] (03PS4) 10Vadim Kovalenko: Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity Refactor $actor as UserIdentity [extensions/Echo] - 10https://gerrit.wikimedia.org/r/670262 (https://phabricator.wikimedia.org/T276412) [10:58:00] (03CR) 10Gergő Tisza: Use a lock in refreshLinkRecommendations.php to avoid self-conflict (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [10:58:58] (03PS3) 10Gergő Tisza: Disable refresh script if $wgGENewcomerTasksRemoteApiUrl is set [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672158 [10:59:20] (03CR) 10Gergő Tisza: Disable refresh script if $wgGENewcomerTasksRemoteApiUrl is set (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672158 (owner: 10Gergő Tisza) [11:04:57] (03CR) 10Kosta Harlan: [C: 03+2] Use a lock in refreshLinkRecommendations.php to avoid self-conflict [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [11:05:04] (03CR) 10Kosta Harlan: [C: 03+2] Disable refresh script if $wgGENewcomerTasksRemoteApiUrl is set [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672158 (owner: 10Gergő Tisza) [11:05:27] (03CR) 10Kosta Harlan: [C: 03+2] Use a lock in refreshLinkRecommendations.php to avoid self-conflict (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [11:08:23] (03CR) 10jerkins-bot: [V: 04-1] Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity Refactor $actor as UserIdentity [extensions/Echo] - 10https://gerrit.wikimedia.org/r/670262 (https://phabricator.wikimedia.org/T276412) (owner: 10Vadim Kovalenko) [11:15:21] (03Merged) 10jenkins-bot: Disable refresh script if $wgGENewcomerTasksRemoteApiUrl is set [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672158 (owner: 10Gergő Tisza) [12:23:26] (03CR) 10Kosta Harlan: [C: 03+2] Use a lock in refreshLinkRecommendations.php to avoid self-conflict [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672159 (owner: 10Gergő Tisza) [13:16:01] (03PS2) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) [13:16:13] (03CR) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [13:20:49] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) >>! In T277342#6912907, @kostajh wrote: >>>! In T277342#6912895, @MGerlach wrote: >> @kostajh : >> - the `ngram_iterator` generates substrings from the text of the article to che... [13:26:13] (03CR) 10jerkins-bot: [V: 04-1] WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [14:38:46] 10Growth-Team, 10Add-Link, 10serviceops, 10MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), 10Patch-For-Review: Add Link engineering: Allow external traffic to linkrecommendation service - https://phabricator.wikimedia.org/T269581 (10kostajh) [14:44:32] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) @akosiaris maybe the [keepalive](https://docs.gunicorn.org/en/stable/settings.html#keepalive) valu... [14:50:02] 10Growth-Team, 10Add-Link, 10serviceops, 10MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), 10Patch-For-Review: Add Link engineering: Allow external traffic to linkrecommendation service - https://phabricator.wikimedia.org/T269581 (10kostajh) 05Open→03Resolved Done, thank you so much to everyone who helped... [15:50:04] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [15:50:27] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [15:59:11] (03PS1) 10Gergő Tisza: Fix topic scores in importOresTopics.php [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672447 (https://phabricator.wikimedia.org/T276163) [17:10:05] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2021), 10Goal: [goal] Deploy Growth features on wikis - https://phabricator.wikimedia.org/T228980 (10Trizek-WMF) [17:11:34] (03PS3) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) [17:13:00] (03PS20) 10Urbanecm: Add migrateServerConfig.php maintenance script [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667382 (https://phabricator.wikimedia.org/T275795) [17:13:22] (03CR) 10Urbanecm: Add migrateServerConfig.php maintenance script (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667382 (https://phabricator.wikimedia.org/T275795) (owner: 10Urbanecm) [17:17:10] 10Growth-Team: Request to implement Growth experiments on Telugu Wikipedia (Tewiki) - https://phabricator.wikimedia.org/T277491 (10Chaduvari) [17:33:44] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [17:41:36] 10Growth-Team, 10Cognate, 10MediaWiki-Page-rename, 10MediaWiki-extensions-CentralAuth, and 9 others: Hard deprecate manually constructing MovePage objects - https://phabricator.wikimedia.org/T252934 (10Pchelolo) a:03Pchelolo [17:42:17] 10Growth-Team: Request to implement Growth experiments on Telugu Wikipedia (Tewiki) - https://phabricator.wikimedia.org/T277491 (10Trizek-WMF) Thank you for your interest for our features! In order to work on the configuration, can you translate the labels for help links you choose on the Help desk section? Th... [17:42:19] 10Growth-Team: Request to implement Growth experiments on Telugu Wikipedia (Tewiki) - https://phabricator.wikimedia.org/T277491 (10Trizek-WMF) [17:42:22] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2021): Scale: deploy Growth features to a new set of wikis - https://phabricator.wikimedia.org/T275069 (10Trizek-WMF) [17:42:24] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2021), 10Goal: [goal] Deploy Growth features on wikis - https://phabricator.wikimedia.org/T228980 (10Trizek-WMF) [18:03:17] (03PS4) 10Urbanecm: Prepare a maintenance script for providing default values for on-wiki config [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) [18:06:24] (03CR) 10Urbanecm: Prepare a maintenance script for providing default values for on-wiki config (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) (owner: 10Urbanecm) [18:16:00] 10Growth-Team, 10GrowthExperiments: Provide a convenience function to construct WikiPageConfigWriter from GEWikiConfigPageTitle - https://phabricator.wikimedia.org/T277493 (10Urbanecm_WMF) [18:16:04] 10Growth-Team, 10GrowthExperiments: Provide a convenience function to construct WikiPageConfigWriter from GEWikiConfigPageTitle - https://phabricator.wikimedia.org/T277493 (10Urbanecm_WMF) p:05Triage→03Low [18:17:19] (03CR) 10Urbanecm: Add migrateServerConfig.php maintenance script (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667382 (https://phabricator.wikimedia.org/T275795) (owner: 10Urbanecm) [18:20:41] 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Documentation: Setup jsduck for GettingStarted - https://phabricator.wikimedia.org/T92072 (10Jdlrobson) 05Open→03Declined Please use jsdoc in this extension. See T138401 [18:22:40] 10Growth-Team, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 10 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10Jdlrobson) [18:24:38] (03PS23) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [18:24:47] (03CR) 10Urbanecm: Introduce Special:EditGrowthConfig (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [18:26:07] 10Growth-Team, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 10 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10Jdlrobson) > T138401#6315952 Just wanted to note, I have wasted quite a bit of time making jsdo... [18:28:37] (03PS24) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [18:34:06] (03PS25) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [18:42:19] (03PS1) 10Urbanecm: Cache config in WikiPageConfigLoader for a day [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) [18:54:59] (03CR) 10Gergő Tisza: "It would be preferable to use proper dependency injection." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [19:05:02] (03PS3) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [19:08:54] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [19:10:22] (03CR) 10Urbanecm: "> Patch Set 2:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [19:10:59] (03PS4) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [19:24:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [19:52:56] (03CR) 10DannyS712: WikiPageConfigWriter: save should succeed if no change was made (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [19:52:59] (03CR) 10Kosta Harlan: [C: 03+1] "Looks good to me! The comments from DannyS712 IMO could be nice to do now or as follow-ups, as you prefer. I think Gergo was going to have" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [19:58:56] 10Growth-Team, 10Notifications, 10Quality-and-Test-Engineering-Team (QTE), 10Browser-Tests, 10User-zeljkofilipin: Make Echo browser tests record and save videos in CI - https://phabricator.wikimedia.org/T276503 (10Addshore) [20:39:18] (03PS1) 10MewOphaswongse: wip [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672531 [20:41:35] (03Abandoned) 10MewOphaswongse: wip [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672531 (owner: 10MewOphaswongse) [20:53:23] 10Growth-Team, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 10 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10kostajh) >>! In T138401#6915067, @Jdlrobson wrote: >> T138401#6315952 > > Just wanted to note,... [21:01:22] (03PS6) 10MewOphaswongse: Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) [21:03:01] (03CR) 10MewOphaswongse: Add a link: onboarding (035 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [21:13:24] (03PS5) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [21:17:20] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [21:20:18] 10Growth-Team, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 10 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10Jdlrobson) > Maybe bringing this to the tech-decision-forum could help clarify a path forward?... [21:20:28] (03PS6) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [21:22:53] (03PS7) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [21:28:00] (03PS8) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [21:32:12] (03CR) 10DannyS712: [C: 04-1] Cache config in WikiPageConfigLoader for a day (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [21:36:10] (03PS9) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [21:36:17] (03CR) 10Kosta Harlan: [C: 03+2] Fix topic scores in importOresTopics.php [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672447 (https://phabricator.wikimedia.org/T276163) (owner: 10Gergő Tisza) [21:38:14] (03PS2) 10Urbanecm: Cache config in WikiPageConfigLoader for a day [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) [21:38:56] (03CR) 10Urbanecm: Cache config in WikiPageConfigLoader for a day (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [21:47:33] (03Merged) 10jenkins-bot: Fix topic scores in importOresTopics.php [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672447 (https://phabricator.wikimedia.org/T276163) (owner: 10Gergő Tisza) [21:49:34] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [21:59:14] (03CR) 10Gergő Tisza: "This should only be done for local configuration. Interwiki configuration is not invalidated so we still rely on quick expiry." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [22:01:10] (03CR) 10Urbanecm: "> Patch Set 2:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672505 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [22:08:07] 10Growth-Team, 10Growth-Scaling: Incorporate newcomer tasks configurations to Special:EditGrowthConfig - https://phabricator.wikimedia.org/T277513 (10Urbanecm_WMF) [22:13:38] 10Growth-Team, 10GrowthExperiments-NewcomerTasks: Decide what to do with MediaWiki:NewcomerTopics.json files - https://phabricator.wikimedia.org/T277514 (10Urbanecm_WMF) [23:25:54] 10Growth-Team, 10Notifications, 10MediaWiki-Parser, 10Talk Pages: If a section title on a talk page is '_' (underscore), it is shown instead of any other sections on mobile web - https://phabricator.wikimedia.org/T249412 (10Jdlrobson) [23:37:16] (03PS1) 10MewOphaswongse: Add a Link: Open edit mode from JS [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) [23:38:32] (03CR) 10Gergő Tisza: [C: 03+2] Variant C/D hybrid (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/669872 (https://phabricator.wikimedia.org/T272754) (owner: 10Kosta Harlan) [23:41:11] (03PS2) 10MewOphaswongse: Add a Link: Open edit mode from JS [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/672560 (https://phabricator.wikimedia.org/T277228) [23:45:31] (03CR) 10MewOphaswongse: Add robot icon and AI description to difficultyFilter checkbox (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [23:52:24] (03Merged) 10jenkins-bot: Variant C/D hybrid [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/669872 (https://phabricator.wikimedia.org/T272754) (owner: 10Kosta Harlan)