[00:04:00] (03PS11) 10Mepps: Use iconData array to display tasktype icons [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667016 (https://phabricator.wikimedia.org/T268706) [00:04:39] (03PS9) 10Mepps: Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) [00:05:46] (03CR) 10Mepps: Use iconData array to display tasktype icons (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667016 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [00:13:12] (03CR) 10DannyS712: WIP: Introduce Special:EditGrowthConfig (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [00:14:14] (03CR) 10jerkins-bot: [V: 04-1] Add robot icon and AI description to difficultyFilter checkbox [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668541 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [02:19:30] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages - https://phabricator.wikimedia.org/T277130 (10Nirmos) I'm assuming that the problem and solution is the same as T137383 / https://gerrit.wikimedia.org/r/294701 [03:46:30] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages - https://phabricator.wikimedia.org/T277130 (10Nirmos) I've tried my best to investigate this, without any luck. Part of that might be because I'm not familiar with less. What I've found is: - `.comment--without-parentheses` is... [04:39:35] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages - https://phabricator.wikimedia.org/T277130 (10Nirmos) omg, I figured it out: So, Flow does not load `mediawiki.interface.helpers.styles` at all. VisualEditor does. From https://phabricator.wikimedia.org/diffusion/EVED/browse/ma... [05:44:39] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages - https://phabricator.wikimedia.org/T277130 (10Nirmos) ...but this is still strange. From https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/actions/HistoryAction.php `lang=php $out->addModuleStyles( [ '... [05:50:38] 10Growth-Team, 10StructuredDiscussions, 10Regression: mediawiki.interface.helpers.styles not loaded on Flow history pages - https://phabricator.wikimedia.org/T277130 (10Nirmos) [06:06:30] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) [06:15:51] 10Growth-Team, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) When I reported this, the bug did not manifest on svwiki like https://sv.wikipedia.org/w/index.php?title=Wikipediadiskussion:... [06:39:44] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) Going through Flow patches in 1.36.0-wmf.34 we find https://gerrit.w... [08:14:35] 10Growth-Team, 10Add-Link, 10Release Pipeline, 10Continuous-Integration-Config: java.lang.RuntimeException: Invalid Credential: 'SONAR_API_KEY' - https://phabricator.wikimedia.org/T277236 (10kostajh) 05Open→03Resolved a:03kostajh >>! In T277236#6906912, @dduvall wrote: > We hadn't yet merged a [[ htt... [08:20:13] (03CR) 10Kosta Harlan: [C: 03+2] Don't show mobile peek and help panel for add link task [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670974 (https://phabricator.wikimedia.org/T276508) (owner: 10MewOphaswongse) [08:24:42] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) @Krinkle This feels a lot like T173411 [08:40:58] (03Merged) 10jenkins-bot: Don't show mobile peek and help panel for add link task [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670974 (https://phabricator.wikimedia.org/T276508) (owner: 10MewOphaswongse) [08:45:08] 10Growth-Team, 10Add-Link, 10Release Pipeline, 10Continuous-Integration-Config: java.lang.RuntimeException: Invalid Credential: 'SONAR_API_KEY' - https://phabricator.wikimedia.org/T277236 (10hashar) @dduvall nice! Thank you for the detailed fix up report. [08:55:00] (03PS16) 10Kosta Harlan: Variant C/D hybrid [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/669872 (https://phabricator.wikimedia.org/T272754) [08:55:04] (03CR) 10Kosta Harlan: Variant C/D hybrid (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/669872 (https://phabricator.wikimedia.org/T272754) (owner: 10Kosta Harlan) [09:02:42] (03CR) 10Kosta Harlan: [C: 03+2] Unset user-to-user email option when user emails are disabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/669994 (https://phabricator.wikimedia.org/T266087) (owner: 10Mech.fandom) [09:03:42] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10good first task: Echo should unset user-to-user email option when email features are disabled. - https://phabricator.wikimedia.org/T266087 (10kostajh) 05Open→03Resolved a:03kostajh [09:04:16] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10good first task: Echo should unset user-to-user email option when email features are disabled. - https://phabricator.wikimedia.org/T266087 (10kostajh) a:05kostajh→03Mech.fandom [09:05:23] 10Growth-Team, 10Notifications, 10Mention-Notification: Do not send multiple notifications if mentioned multiple times in one edit - https://phabricator.wikimedia.org/T55607 (10Urbanecm) p:05High→03Low Doesn't sound like high priority anymore. [09:29:41] (03Merged) 10jenkins-bot: Unset user-to-user email option when user emails are disabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/669994 (https://phabricator.wikimedia.org/T266087) (owner: 10Mech.fandom) [10:44:40] 10Growth-Team, 10StructuredDiscussions, 10MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), 10Platform Team Workboards (MW Expedition), 10Technical-Debt (Deprecation process): Avoid using User::clearNotification - https://phabricator.wikimedia.org/T276572 (10Zabe) 05Open→03Resolved Unused [10:58:30] 10Collab-Notifications-Page, 10Collaboration-Team-Triage, 10Growth-Team, 10I18n: Proper date localization in Special:Notifications page - https://phabricator.wikimedia.org/T69843 (10Pikne) Apparently now this concerns JavaScript-free version of Special:Notifications. With JavaScript dates are fine. [11:35:50] 10Growth-Team, 10Add-Link, 10Image-Recommendations, 10Discovery-Search (Current work): Consume new event from the AddLink feature - https://phabricator.wikimedia.org/T262226 (10Tgr) 05Resolved→03Open We enabled event generation on testwiki yesterday, the pipeline seems to be working fine. [11:36:30] 10Growth-Team, 10Add-Link, 10Image-Recommendations, 10Discovery-Search (Current work): Consume new event from the AddLink feature - https://phabricator.wikimedia.org/T262226 (10Tgr) 05Open→03Resolved [12:17:08] (03CR) 10Urbanecm: "translations verified with Benoit, can be reviewed now" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670587 (https://phabricator.wikimedia.org/T276830) (owner: 10Urbanecm) [13:32:16] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) Is there a list of all patches merged in 1.36.0-wmf.34? [13:33:17] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (module mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10Nirmos) [13:49:18] (03CR) 10Kosta Harlan: [C: 04-1] "looks good overall! The -1 item is for the font size in this comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperimen" (037 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [13:52:45] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (module mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10kostajh) >>! In T277130#6908341, @Nirmos wrote: > Is there a list of... [14:11:42] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) [14:12:07] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Create Grafana dashboard for link recommendation service and document it on wikitech - https://phabricator.wikimedia.org/T276769 (10kostajh) >>! In T276769#6893448, @Tgr wrote: > So to be clear there are two distinct issues: > * requests time out (fail wi... [14:12:54] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) [14:19:47] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Create Grafana dashboard for link recommendation service and document it on wikitech - https://phabricator.wikimedia.org/T276769 (10akosiaris) >>! In T276769#6893448, @Tgr wrote: > So to be clear there are two distinct issues: > * requests time out (fail... [14:20:25] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Create Grafana dashboard for link recommendation service and document it on wikitech - https://phabricator.wikimedia.org/T276769 (10kostajh) >>! In T276769#6908482, @akosiaris wrote: >>>! In T276769#6893448, @Tgr wrote: >> So to be clear there are two dis... [14:22:49] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks: Create Grafana dashboard for link recommendation service and document it on wikitech - https://phabricator.wikimedia.org/T276769 (10akosiaris) >>! In T276769#6908483, @kostajh wrote: >>>! In T276769#6908482, @akosiaris wrote: >>>>! In T276769#6893448, @Tg... [14:23:35] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10akosiaris) Ah, so a simple for i in 1..10 do curl -s https://api.wikimedia.org/service/linkrecommendation... [14:26:31] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) >>! In T277297#6908492, @akosiaris wrote: > Ah, so a simple > > for i in 1..10 > do > curl -s ht... [14:26:53] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) [14:27:07] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) [14:29:33] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10akosiaris) Ahem.. ` $ ab -n 100 -c 1 https://api.wikimedia.org/service/linkrecommendation/v0/linkrecommend... [14:47:51] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10akosiaris) Bypassing the api-gateway (and the services proxy) doesn't fix this in any way. Logs aren't he... [15:16:16] (03PS2) 10Urbanecm: WIP: Use getGrowthWikiConfig in appropriate places [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670968 (https://phabricator.wikimedia.org/T274520) [15:22:23] (03PS21) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [15:27:04] (03PS22) 10Urbanecm: Introduce Special:EditGrowthConfig [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) [15:31:03] 10Growth-Team, 10StructuredDiscussions, 10Parsoid (Tracking), 10User-brennen, 10Wikimedia-production-error: Request to parsoid for "wikitext" to "html" conversion of content connected to title "[title]" failed: 504 - https://phabricator.wikimedia.org/T276982 (10Arlolra) [15:36:43] (03PS1) 10Urbanecm: WikiPageConfigWriter: save should succeed if no change was made [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) [15:36:58] 10Growth-Team, 10Add-Link, 10serviceops, 10Platform Team Initiatives (API Gateway): 504 timeout and 503 errors when accessing linkrecommendation service - https://phabricator.wikimedia.org/T277297 (10kostajh) >>! In T277297#6908552, @akosiaris wrote: > Bypassing the api-gateway (and the services proxy) doe... [15:42:11] (03CR) 10Urbanecm: Introduce Special:EditGrowthConfig (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [15:51:29] (03CR) 10DannyS712: [C: 04-1] "-1 for the use of hard-deprecated code" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667371 (https://phabricator.wikimedia.org/T274031) (owner: 10Urbanecm) [15:56:46] (03CR) 10DannyS712: WikiPageConfigWriter: save should succeed if no change was made (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [16:45:45] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (module mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10matmarex) >>! In T277130#6908341, @Nirmos wrote: > Is there a list of... [16:46:09] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, 10Regression: FOUC on Flow history pages (module mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10matmarex) >>! In T277130#6907439, @Nirmos wrote: > ...but this is sti... [17:16:57] (03CR) 10MewOphaswongse: Add a link: onboarding (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [17:56:46] 10Growth-Team, 10GrowthExperiments, 10JavaScript, 10Wikimedia-production-error: GrowthExperiments help error : TypeError: title is undefined, Uncaught TypeError: Cannot read property 'replace' of undefined - https://phabricator.wikimedia.org/T276966 (10Jdlrobson) Just a word of warning at 485 errors in la... [17:57:39] (03PS4) 10DannyS712: Add redirects to queue when targets change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/642751 [17:58:17] (03PS5) 10DannyS712: Remove `jquery.badge.external` RL module [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/666335 (https://phabricator.wikimedia.org/T221269) [17:58:30] (03PS4) 10DannyS712: Merge defaultTagsOptions and defaultDeletionTagsOptions RL modules [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/665183 (https://phabricator.wikimedia.org/T221269) [18:13:53] (03PS5) 10MewOphaswongse: Add a link: onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) [18:14:47] (03CR) 10MewOphaswongse: Add a link: onboarding (037 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [18:54:54] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-User-management, 10Platform Engineering, 10Technical-Debt (Deprecation process): How to replace deprecated User::getTokenFromOption for the watchlisttoken? - https://phabricator.wikimedia.org/T267013 (10DannyS712) Might fall into scope of platform engine... [19:02:47] (03CR) 10MewOphaswongse: [C: 03+2] Add Japanese special page aliases [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670587 (https://phabricator.wikimedia.org/T276830) (owner: 10Urbanecm) [19:07:01] (03CR) 10MewOphaswongse: [C: 03+2] Use iconData array to display tasktype icons (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667016 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [19:13:43] (03Merged) 10jenkins-bot: Add Japanese special page aliases [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670587 (https://phabricator.wikimedia.org/T276830) (owner: 10Urbanecm) [19:29:05] (03CR) 10Gergő Tisza: Add migrateServerConfig.php maintenance script (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667382 (https://phabricator.wikimedia.org/T275795) (owner: 10Urbanecm) [19:31:44] (03CR) 10DannyS712: Add migrateServerConfig.php maintenance script (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667382 (https://phabricator.wikimedia.org/T275795) (owner: 10Urbanecm) [19:40:00] (03Merged) 10jenkins-bot: Use iconData array to display tasktype icons [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/667016 (https://phabricator.wikimedia.org/T268706) (owner: 10Mepps) [19:42:05] (03CR) 10DannyS712: Add a link: onboarding (035 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670620 (https://phabricator.wikimedia.org/T269490) (owner: 10MewOphaswongse) [20:20:44] (03CR) 10DannyS712: [C: 04-1] Prefer UserIdentity::isRegistered() over user::isAnon() (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 (owner: 10Thiemo Kreuz (WMDE)) [20:56:09] (03PS5) 10Thiemo Kreuz (WMDE): Prefer UserIdentity::isRegistered() over user::isAnon() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 [20:57:29] (03CR) 10Thiemo Kreuz (WMDE): Prefer UserIdentity::isRegistered() over user::isAnon() (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/668415 (owner: 10Thiemo Kreuz (WMDE)) [21:03:07] 10Growth-Team, 10Add-Link: Experiment with ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) [21:03:20] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) [21:03:46] 10Growth-Team, 10Add-Link: Experiment with and/or document ngram parameters - https://phabricator.wikimedia.org/T277342 (10kostajh) [21:09:30] (03CR) 10Gergő Tisza: "Looks good. What's left to unWIP it?" (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/670888 (https://phabricator.wikimedia.org/T275163) (owner: 10Urbanecm) [21:12:48] (03CR) 10Gergő Tisza: WikiPageConfigWriter: save should succeed if no change was made (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/671179 (https://phabricator.wikimedia.org/T274520) (owner: 10Urbanecm) [21:13:11] (03PS1) 10Bartosz Dziewoński: Add some missing styles for Flow history pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/671254 (https://phabricator.wikimedia.org/T277130) [21:14:30] 10Growth-Team, 10MediaWiki-General, 10MediaWiki-extensions-General, 10StructuredDiscussions, and 2 others: FOUC on Flow history pages (module mediawiki.interface.helpers.styles not loaded) - https://phabricator.wikimedia.org/T277130 (10matmarex) I don't think this is a new issue, I couldn't find any recent... [21:18:09] (03CR) 10Jdlrobson: [C: 03+2] Add some missing styles for Flow history pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/671254 (https://phabricator.wikimedia.org/T277130) (owner: 10Bartosz Dziewoński) [21:34:13] (03CR) 10jerkins-bot: [V: 04-1] Add some missing styles for Flow history pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/671254 (https://phabricator.wikimedia.org/T277130) (owner: 10Bartosz Dziewoński) [21:44:16] (03Merged) 10jenkins-bot: Add some missing styles for Flow history pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/671254 (https://phabricator.wikimedia.org/T277130) (owner: 10Bartosz Dziewoński)