[00:29:00] (03CR) 10MewOphaswongse: [WIP] Updated unactivated state of impact module (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [00:41:16] (03CR) 10MewOphaswongse: [WIP] Updated unactivated state of impact module (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [00:42:59] (03PS5) 10MewOphaswongse: [WIP] Updated unactivated state of impact module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) [00:45:47] (03PS1) 10Urbanecm: WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 [00:47:59] (03CR) 10jerkins-bot: [V: 04-1] WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 (owner: 10Urbanecm) [01:01:41] 10Growth-Team, 10Notifications, 10MediaWiki-Authentication-and-authorization, 10Security-Team: Notifications were updated even though session had expired - https://phabricator.wikimedia.org/T273842 (10Huji) >>! In T273842#6813330, @sbassett wrote: >> Could there be a cache-related security issue here? > >... [01:02:57] 10Growth-Team, 10Notifications, 10MediaWiki-Authentication-and-authorization, 10Security-Team: Notifications were updated even though session had expired - https://phabricator.wikimedia.org/T273842 (10Huji) By the way, my working theory is this: even if a session expires, the cookies from the last page vie... [01:39:27] 10Growth-Team, 10Growth-Structured-Tasks: Add a link: quality gates - https://phabricator.wikimedia.org/T274325 (10MMiller_WMF) [01:40:10] 10Growth-Team, 10Growth-Structured-Tasks: Add a link: quality gates - https://phabricator.wikimedia.org/T274325 (10MMiller_WMF) [02:26:26] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks, 10GrowthExperiments: Add a link: changing the link target (not for initial release) - https://phabricator.wikimedia.org/T269648 (10MMiller_WMF) [09:03:47] 10Growth-Team, 10Growth-Structured-Tasks: Add a link: quality gates - https://phabricator.wikimedia.org/T274325 (10RHo) [10:59:09] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Scaling GrowthExperiments - Help panel tests - https://phabricator.wikimedia.org/T274166 (10zeljkofilipin) [12:26:35] (03PS2) 10Urbanecm: WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 [12:28:01] (03PS3) 10Urbanecm: WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 [12:30:10] (03PS4) 10Urbanecm: WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 [12:37:59] (03PS5) 10Urbanecm: WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 [12:51:26] (03CR) 10jerkins-bot: [V: 04-1] WIP: Move configuration-loading to new Config namespace [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663086 (owner: 10Urbanecm) [12:59:14] (03PS1) 10Urbanecm: WIP: Add WikiPageConfig that can provide config from wiki page [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 [13:09:36] (03PS2) 10Urbanecm: WIP: Add WikiPageConfig that can provide config from wiki page [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 [13:10:24] (03PS3) 10Urbanecm: WIP: Add WikiPageConfig that can provide config from wiki page [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 [13:20:58] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add WikiPageConfig that can provide config from wiki page [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 (owner: 10Urbanecm) [14:01:07] 10Growth-Team, 10Add-Link, 10Growth-Structured-Tasks, 10GrowthExperiments: Add a link: sentence highlighting research spike - https://phabricator.wikimedia.org/T269655 (10Tgr) If we took the T267694#6764244 approach to identifying the anchor, we would get this for free (assuming the performance of nltk.tok... [14:20:00] 10Growth-Team, 10Growth-Scaling: On wikis trying the Growth tools, have Special:WelcomeSurvey working without parameters - https://phabricator.wikimedia.org/T274368 (10Trizek-WMF) [14:30:24] 10Growth-Team, 10Growth-Scaling: On wikis trying the Growth tools, have Special:WelcomeSurvey working without parameters - https://phabricator.wikimedia.org/T274368 (10Urbanecm_WMF) Quoting @Tgr from the other task: >>! In T256126#6818550, @Tgr wrote: > Should be pretty straightforward, just allow to pass in... [14:46:03] (03PS1) 10Urbanecm: Make Special:WelcomeSurvey work without group parameter when directly viewed [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) [14:46:22] 10Growth-Team, 10Growth-Scaling, 10Patch-For-Review: On wikis trying the Growth tools, have Special:WelcomeSurvey working without parameters - https://phabricator.wikimedia.org/T274368 (10Urbanecm_WMF) It sounds this is indeed way easier than I anticipated. Uploaded a patch :). [14:48:13] (03PS2) 10Urbanecm: Make Special:WelcomeSurvey work without group parameter when directly viewed [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) [15:51:15] (03CR) 10Urbanecm: [WIP] Updated unactivated state of impact module (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [18:10:34] (03PS6) 10MewOphaswongse: [WIP] Updated unactivated state of impact module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) [18:17:03] (03CR) 10Kosta Harlan: [WIP] Updated unactivated state of impact module (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [18:52:21] 10Growth-Team, 10MediaWiki-Special-pages, 10MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: Special:Contributions triggers PHP Notice: Undefined index: start - https://phabricator.wikimedia.org/T271979 (10Jdforrester-WMF) >>! In T271... [19:15:12] (03PS13) 10Mepps: Animate live-broadcast icon, count on search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662768 (https://phabricator.wikimedia.org/T236842) [19:28:45] (03CR) 10jerkins-bot: [V: 04-1] Animate live-broadcast icon, count on search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662768 (https://phabricator.wikimedia.org/T236842) (owner: 10Mepps) [19:29:54] (03PS2) 10Mepps: Create separate setSearching function to animate broadcast icon [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663046 (https://phabricator.wikimedia.org/T236842) [19:32:40] 10Growth-Team, 10Notifications, 10Wikimedia-production-error: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query  - https://phabricator.wikimedia.org/T274408 (10thcipriani) [19:32:53] 10Growth-Team, 10Notifications, 10Wikimedia-production-error: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query - https://phabricator.wikimedia.org/T274408 (10thcipriani) [19:35:38] (03CR) 10Mepps: "What are the scenarios where someone wouldn't want to be able to access a default group without a group url parameter? The code looks good" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) (owner: 10Urbanecm) [19:40:17] (03CR) 10jerkins-bot: [V: 04-1] Create separate setSearching function to animate broadcast icon [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663046 (https://phabricator.wikimedia.org/T236842) (owner: 10Mepps) [19:40:43] 10Growth-Team, 10Notifications, 10Wikimedia-production-error: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query - https://phabricator.wikimedia.org/T274408 (10thcipriani) This message really started in 1.36.0-wmf.26 -- there are 3 in the roughly 2 months and then there have been 356 sine 1.36.0... [19:47:54] 10Growth-Team, 10Notifications, 10Wikimedia-production-error: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query - https://phabricator.wikimedia.org/T274408 (10matmarex) Looks similar to T273479 (but different stack trace). [20:26:40] 10Growth-Team, 10Notifications, 10Wikimedia-production-error: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query - https://phabricator.wikimedia.org/T274408 (10daniel) [20:26:44] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), 10Wikimedia-production-error: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query - https://phabricator.wikimedia.org/T273479 (10daniel) [20:30:05] 10Growth-Team, 10Notifications, 10wikitech.wikimedia.org, 10Wikimedia-production-error, 10cloud-services-team (Kanban): DeferredUpdates: Deferred update 'AtomicSectionUpdate_EchoNotificationMapper::insert' failed to run. - https://phabricator.wikimedia.org/T273808 (10daniel) Related to {T273479}? [20:33:34] (03PS1) 10Vlad.shapik: Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/663297 (https://phabricator.wikimedia.org/T274151) [20:56:34] (03CR) 10jerkins-bot: [V: 04-1] Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/663297 (https://phabricator.wikimedia.org/T274151) (owner: 10Vlad.shapik) [20:59:42] (03PS2) 10Vlad.shapik: Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/663297 (https://phabricator.wikimedia.org/T274151) [21:18:45] (03PS3) 10Vlad.shapik: Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/663297 (https://phabricator.wikimedia.org/T274151) [21:22:10] (03CR) 10Gergő Tisza: "Do we actually have a use case for the "fall back to globals" behavior?" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 (owner: 10Urbanecm) [21:23:20] (03CR) 10Urbanecm: "> Patch Set 2:" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) (owner: 10Urbanecm) [21:24:56] (03CR) 10Urbanecm: "> Patch Set 2:" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) (owner: 10Urbanecm) [21:27:38] (03CR) 10Urbanecm: Make Special:WelcomeSurvey work without group parameter when directly viewed (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663210 (https://phabricator.wikimedia.org/T274368) (owner: 10Urbanecm) [21:31:33] (03CR) 10Urbanecm: "> Patch Set 3:" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 (owner: 10Urbanecm) [21:34:34] (03CR) 10Urbanecm: WIP: Add WikiPageConfig that can provide config from wiki page (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663189 (owner: 10Urbanecm) [21:57:47] (03PS1) 10Kosta Harlan: Guidance: use language.convertNumber for tip panel labels [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663311 (https://phabricator.wikimedia.org/T274379) [21:59:50] (03PS2) 10Kosta Harlan: Guidance: use language.convertNumber for tip panel labels [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663311 (https://phabricator.wikimedia.org/T274379) [22:22:59] (03CR) 10Kosta Harlan: [WIP] Updated unactivated state of impact module (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [22:31:52] (03CR) 10Kosta Harlan: [WIP] Updated unactivated state of impact module (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [22:39:08] (03CR) 10MewOphaswongse: [C: 03+2] Guidance: use language.convertNumber for tip panel labels [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663311 (https://phabricator.wikimedia.org/T274379) (owner: 10Kosta Harlan) [22:50:21] (03Merged) 10jenkins-bot: Guidance: use language.convertNumber for tip panel labels [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663311 (https://phabricator.wikimedia.org/T274379) (owner: 10Kosta Harlan) [22:57:22] (03CR) 10MewOphaswongse: "Added some clarification questions" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663046 (https://phabricator.wikimedia.org/T236842) (owner: 10Mepps) [23:03:05] (03CR) 10DannyS712: [C: 03+2] Remove unused properties from RevisionFormatter test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/662648 (owner: 10Thiemo Kreuz (WMDE)) [23:31:38] (03Merged) 10jenkins-bot: Remove unused properties from RevisionFormatter test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/662648 (owner: 10Thiemo Kreuz (WMDE)) [23:34:37] (03CR) 10DannyS712: [C: 03+2] "Feel free to add me as a reviewer to such patches in the future" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/662647 (owner: 10Thiemo Kreuz (WMDE)) [23:50:48] (03CR) 10MewOphaswongse: [WIP] Updated unactivated state of impact module (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662028 (https://phabricator.wikimedia.org/T223221) (owner: 10MewOphaswongse) [23:52:47] (03CR) 10MewOphaswongse: Create separate setSearching function to animate broadcast icon (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/663046 (https://phabricator.wikimedia.org/T236842) (owner: 10Mepps)