[01:52:40] (03CR) 10DannyS712: "mostly LGTM, 2 questions" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [01:57:35] (03CR) 10DannyS712: [C: 03+2] Remove wrong return null from function documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/661465 (owner: 10Umherirrender) [02:01:28] 10Growth-Team, 10GrowthExperiments: Welcome survey: `welcomesurvey-sidebar` may overflow the footer container - https://phabricator.wikimedia.org/T273820 (10Etonkovidova) [02:01:50] 10Growth-Team, 10GrowthExperiments: Welcome survey: 'welcomesurvey-sidebar' may overflow the footer container - https://phabricator.wikimedia.org/T273820 (10Etonkovidova) [02:18:34] 10Growth-Team, 10GrowthExperiments: Welcome survey: 'welcomesurvey-sidebar' may overflow the footer container - https://phabricator.wikimedia.org/T273820 (10Etonkovidova) 05Open→03Invalid Re-tested (`ruwiki`, `cswiki wmf.27`) - the issue seems to be not present anymore. [02:51:29] (03Merged) 10jenkins-bot: Remove wrong return null from function documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/661465 (owner: 10Umherirrender) [02:56:26] 10Growth-Team, 10StructuredDiscussions: [wmf.10] extensions/Flow - Unable to load history error - https://phabricator.wikimedia.org/T240406 (10Krinkle) If I recall correctly, some months ago in a different task the root cause of this was investigated and the short to medium term fix was to "catch" the error a... [03:09:46] (03CR) 10DannyS712: api: setmentor should require csrf token (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661228 (owner: 10Urbanecm) [08:53:15] (03PS5) 10Urbanecm: api: setmentor should require csrf token [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661228 [08:53:36] (03CR) 10Urbanecm: api: setmentor should require csrf token (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661228 (owner: 10Urbanecm) [11:39:21] (03CR) 10Thiemo Kreuz (WMDE): "Full review done. I think this is all correct, except when I left a comment. The only (mild) concerns I have are about the "null" as well " (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [11:42:11] (03Abandoned) 10Aklapper: Added Extension name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539450 (owner: 10Haritha Mattupalli) [11:44:52] (03Abandoned) 10Aklapper: Fix "unreachable code after return statement" warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [12:11:43] (03PS3) 10Aklapper: Disable new Notifications for simple Patrol actions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/175168 (https://phabricator.wikimedia.org/T75925) (owner: 10Ragesoss) [12:11:57] (03CR) 10jerkins-bot: [V: 04-1] Disable new Notifications for simple Patrol actions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/175168 (https://phabricator.wikimedia.org/T75925) (owner: 10Ragesoss) [12:13:00] 10Growth-Team, 10PageCuration, 10Patch-Needs-Improvement: PageTriage Echo notifications for basic review/patrol actions are not useful - https://phabricator.wikimedia.org/T75925 (10Aklapper) p:05High→03Triage [15:26:09] 10Growth-Team, 10Analytics, 10Growth-Scaling, 10Product-Analytics: Growth: delete data older than 90 days - https://phabricator.wikimedia.org/T273821 (10mpopov) Thanks, @Rileych! The PA team will prioritize this in our next board refinement meeting (Feb 8). [15:26:59] 10Growth-Team, 10Analytics, 10Growth-Scaling, 10Product-Analytics: Growth: End wider data purge window - https://phabricator.wikimedia.org/T273815 (10mpopov) Thanks, @Rileych! The PA team will prioritize this in our next board refinement meeting (Feb 8). [15:49:41] (03PS4) 10Umherirrender: Improve function and property documentation in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 [15:49:53] (03CR) 10Umherirrender: Improve function and property documentation in tests (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [16:10:45] (03CR) 10Thiemo Kreuz (WMDE): Improve function and property documentation in tests (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [18:18:24] (03PS5) 10Umherirrender: Improve function and property documentation in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 [18:18:37] (03CR) 10Umherirrender: Improve function and property documentation in tests (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [18:32:02] 10Growth-Team, 10Growth-Scaling, 10GrowthExperiments-MentorshipModule: Have a special page for mentors to sign up - https://phabricator.wikimedia.org/T264343 (10Urbanecm_WMF) [18:51:54] 10Growth-Team, 10Growth-Scaling: [Scaling] Provide data and information to all communities about newcomers - https://phabricator.wikimedia.org/T272372 (10Urbanecm_WMF) [19:03:05] (03CR) 10MewOphaswongse: [C: 03+2] Fix logging in MentorPageMentorManager::getMentorsForPage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661405 (owner: 10Urbanecm) [19:05:48] 10Growth-Team, 10Growth-Scaling: Consider to have links used in Growth features as standalones being treated as local configuration more than translations - https://phabricator.wikimedia.org/T271237 (10Urbanecm_WMF) I don't have much to say on this scaling tasks. Generally speaking, this sounds like a good ide... [19:19:21] (03Merged) 10jenkins-bot: Fix logging in MentorPageMentorManager::getMentorsForPage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661405 (owner: 10Urbanecm) [20:17:36] 10MediaWiki-Watchlist, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Performance-Team (Radar), 10Regression, and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Mathis_Benguigui) I just had the bug again 3 times today... [20:34:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Thanks. I will have another look the next days." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/657968 (owner: 10Umherirrender) [20:44:21] 10MediaWiki-Watchlist, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Performance-Team (Radar), 10Regression, and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Joeyconnick) >>! In T218511#6807566, @Mathis_Benguigui wr... [21:17:18] 10Growth-Team, 10GrowthExperiments-NewcomerTasks: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis? - https://phabricator.wikimedia.org/T274009 (10Urbanecm_WMF) [21:17:44] 10Growth-Team, 10Growth-Scaling, 10GrowthExperiments-NewcomerTasks: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis? - https://phabricator.wikimedia.org/T274009 (10Urbanecm_WMF) [21:17:58] 10Growth-Team, 10Growth-Scaling: Scale: deploy without SuggestedEdits - https://phabricator.wikimedia.org/T270300 (10Urbanecm_WMF) [21:18:13] 10Growth-Team, 10Growth-Scaling: Scale: deploy without SuggestedEdits - https://phabricator.wikimedia.org/T270300 (10Urbanecm_WMF) [21:18:56] 10Growth-Team, 10Growth-Scaling, 10GrowthExperiments-NewcomerTasks: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis? - https://phabricator.wikimedia.org/T274009 (10Urbanecm_WMF) [21:18:58] 10Growth-Team, 10Growth-Scaling: Consider to have links used in Growth features as standalones being treated as local configuration more than translations - https://phabricator.wikimedia.org/T271237 (10Urbanecm_WMF) [21:19:00] 10Growth-Team, 10Growth-Scaling: Scale: deploy without SuggestedEdits - https://phabricator.wikimedia.org/T270300 (10Urbanecm_WMF) [21:50:40] (03CR) 10MewOphaswongse: [C: 03+2] Fix logging in MentorPageMentorManager [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661752 (owner: 10Urbanecm) [22:00:15] 10Growth-Team, 10Growth-Scaling, 10GrowthExperiments-NewcomerTasks: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis? - https://phabricator.wikimedia.org/T274009 (10Tgr) In practice it's not so much about defaults as per-wiki configuration for things like maintenance... [22:07:21] (03Merged) 10jenkins-bot: Fix logging in MentorPageMentorManager [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/661752 (owner: 10Urbanecm) [22:08:05] 10Growth-Team, 10Growth-Scaling: Consider to have links used in Growth features as standalones being treated as local configuration more than translations - https://phabricator.wikimedia.org/T271237 (10Tgr) Translatewiki is really bad for this since it means multiple wikis in the same language will have to sha... [22:18:23] 10Growth-Team, 10Growth-Scaling, 10GrowthExperiments-NewcomerTasks: Scaling: Open question: How should we deal with on-wiki configuration for dozens of wikis? - https://phabricator.wikimedia.org/T274009 (10Tgr) It's already the case although it's treated as an error condition now (in terms of logging and cac... [23:11:14] 10Growth-Team, 10GrowthExperiments-NewcomerTasks, 10User-Urbanecm_WMF: Link docs in an editnotice displayed when editing MediaWiki:NewcomerTasks.json - https://phabricator.wikimedia.org/T274017 (10Urbanecm_WMF) [23:12:32] 10Growth-Team, 10GrowthExperiments-NewcomerTasks, 10User-Urbanecm_WMF: Link docs in an editnotice displayed when editing MediaWiki:NewcomerTasks.json - https://phabricator.wikimedia.org/T274017 (10Urbanecm_WMF) p:05Triage→03Low [23:16:18] (03PS1) 10Urbanecm: WIP: Link the docs for editing NewcomerTasks.json to communities [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662024 (https://phabricator.wikimedia.org/T274017) [23:16:43] 10Growth-Team, 10GrowthExperiments-NewcomerTasks, 10Patch-For-Review, 10User-Urbanecm_WMF (Engineering): Link docs in an editnotice displayed when editing MediaWiki:NewcomerTasks.json - https://phabricator.wikimedia.org/T274017 (10Urbanecm_WMF) [23:20:55] 10Growth-Team, 10Growth-Scaling: Consider to have links used in Growth features as standalones being treated as local configuration more than translations - https://phabricator.wikimedia.org/T271237 (10Urbanecm_WMF) >>! In T271237#6807873, @Tgr wrote: > Translatewiki is really bad for this since it means multi... [23:21:42] 10Growth-Team, 10GrowthExperiments-Help panel: Help panel: Manage help panel links on wiki - https://phabricator.wikimedia.org/T215911 (10Urbanecm_WMF) We should make this an on-wiki JSON, similar to https://cs.wikipedia.org/wiki/MediaWiki:NewcomerTasks.json. [23:26:24] (03CR) 10jerkins-bot: [V: 04-1] WIP: Link the docs for editing NewcomerTasks.json to communities [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662024 (https://phabricator.wikimedia.org/T274017) (owner: 10Urbanecm) [23:30:55] (03PS2) 10Urbanecm: WIP: Link the docs for editing NewcomerTasks.json to communities [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662024 (https://phabricator.wikimedia.org/T274017) [23:31:56] 10Growth-Team, 10Growth-Scaling: Divide translation blocks by feature - https://phabricator.wikimedia.org/T269606 (10Urbanecm_WMF) It should not be an issue to divide the messages into more groups. However, I'm not sure how will we preserve translations. Is copying keys from (for instance) `cs.json` directly i... [23:35:11] 10Growth-Team, 10Growth-Scaling: Divide translation blocks by feature - https://phabricator.wikimedia.org/T269606 (10Amire80) Simply moving the messages in en.json and qqq.json is enough. Everything else will be done by translatewiki scripts. [23:41:07] (03CR) 10jerkins-bot: [V: 04-1] WIP: Link the docs for editing NewcomerTasks.json to communities [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/662024 (https://phabricator.wikimedia.org/T274017) (owner: 10Urbanecm)