[00:50:44] (03CR) 10DannyS712: [C: 03+2] Add missing @var documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/650965 (owner: 10Umherirrender) [00:51:51] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10CatWatch: Diff and history links missing for grouped category changes on Watchlist/RecentChanges - https://phabricator.wikimedia.org/T270662 (10Nardog) [00:54:27] (03CR) 10DannyS712: [C: 03+2] Add missing @var documentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/650967 (owner: 10Umherirrender) [01:10:54] 10Growth-Team, 10StructuredDiscussions, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Platform Team Workboards (External Code Reviews), 10User-DannyS712: Flow uses $wgUser - https://phabricator.wikimedia.org/T262111 (10DannyS712) 05Open→03Resolved a:03DannyS712 [01:15:03] (03Merged) 10jenkins-bot: Add missing @var documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/650965 (owner: 10Umherirrender) [01:15:08] (03Merged) 10jenkins-bot: Add missing @var documentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/650967 (owner: 10Umherirrender) [01:15:11] (03Merged) 10jenkins-bot: Use Maintenance::set/getBatchSize in maintenance scripts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/650968 (owner: 10Umherirrender) [01:42:10] (03PS4) 10Gergő Tisza: Remove fragile SubpageLinkRecommendationProvider::setup() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/649285 [01:42:12] (03PS11) 10Gergő Tisza: Track task type alongside with target page ID, step 2 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645231 (https://phabricator.wikimedia.org/T269366) [01:42:14] (03PS13) 10Gergő Tisza: Add LinkRecommendation task type [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645297 (https://phabricator.wikimedia.org/T269366) [01:42:16] (03PS14) 10Gergő Tisza: Replace TemplateFilter with TaskSuggester::filter [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645788 (https://phabricator.wikimedia.org/T269642) [01:42:18] (03PS8) 10Gergő Tisza: Add ConfigurationLoaderTrait [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/647132 [01:42:20] (03PS28) 10Gergő Tisza: [WIP] Maintenance script for updating link recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/640582 (https://phabricator.wikimedia.org/T261408) [01:42:22] (03PS16) 10Gergő Tisza: [DNM] Remove cache migration logic [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645481 (https://phabricator.wikimedia.org/T269366) [01:42:24] (03PS1) 10Gergő Tisza: Track task type alongside with target page ID, step 1 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/651305 (https://phabricator.wikimedia.org/T269366) [01:58:18] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Remove cache migration logic [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645481 (https://phabricator.wikimedia.org/T269366) (owner: 10Gergő Tisza) [03:37:13] 10Growth-Team, 10MediaWiki-Watchlist, 10Community-Tech, 10DBA, and 2 others: ClearUserWatchlistJob/WatchedItemStore::removeWatchBatchForUser bad database peformance on enwiki and others, causing database lag - https://phabricator.wikimedia.org/T270481 (10MusikAnimal) >>! In T270481#6705544, @Marostegui wro... [05:53:01] 10Growth-Team, 10MediaWiki-Watchlist, 10Community-Tech, 10DBA, and 2 others: ClearUserWatchlistJob/WatchedItemStore::removeWatchBatchForUser bad database peformance on enwiki and others, causing database lag - https://phabricator.wikimedia.org/T270481 (10Marostegui) Thank you - let's chat there about the v... [06:01:10] 10Growth-Team, 10Notifications: Muting does not work to suppress the notification when the muted user "thanks" another user for edits to their own talk page - https://phabricator.wikimedia.org/T270533 (10Fuhghettaboutit) [08:02:31] 10Growth-Team, 10MediaWiki-Watchlist, 10Community-Tech, 10DBA, and 2 others: ClearUserWatchlistJob/WatchedItemStore::removeWatchBatchForUser bad database peformance on enwiki and others, causing database lag - https://phabricator.wikimedia.org/T270481 (10Marostegui) Thanks @MusikAnimal for providing values... [10:29:12] (03PS29) 10Gergő Tisza: Maintenance script for updating link recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/640582 (https://phabricator.wikimedia.org/T261408) [10:29:14] (03PS17) 10Gergő Tisza: [DNM] Remove cache migration logic [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645481 (https://phabricator.wikimedia.org/T269366) [10:42:11] (03PS1) 10Gergő Tisza: Fix WelcomeSurvey autonym handling for variants [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/651460 (https://phabricator.wikimedia.org/T270519) [10:42:32] (03CR) 10jerkins-bot: [V: 04-1] Maintenance script for updating link recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/640582 (https://phabricator.wikimedia.org/T261408) (owner: 10Gergő Tisza) [10:43:48] (03PS5) 10Gergő Tisza: Remove fragile SubpageLinkRecommendationProvider::setup() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/649285 [10:43:50] (03PS2) 10Gergő Tisza: Track task type alongside with target page ID, step 1 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/651305 (https://phabricator.wikimedia.org/T269366) [10:43:52] (03PS12) 10Gergő Tisza: Track task type alongside with target page ID, step 2 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645231 (https://phabricator.wikimedia.org/T269366) [10:43:54] (03PS14) 10Gergő Tisza: Add LinkRecommendation task type [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645297 (https://phabricator.wikimedia.org/T269366) [10:43:56] (03PS15) 10Gergő Tisza: Replace TemplateFilter with TaskSuggester::filter [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645788 (https://phabricator.wikimedia.org/T269642) [10:43:58] (03PS9) 10Gergő Tisza: Add ConfigurationLoaderTrait [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/647132 [10:44:00] (03PS30) 10Gergő Tisza: Maintenance script for updating link recommendations [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/640582 (https://phabricator.wikimedia.org/T261408) [10:44:02] (03PS18) 10Gergő Tisza: [DNM] Remove cache migration logic [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/645481 (https://phabricator.wikimedia.org/T269366) [15:42:59] (03PS1) 10Thiemo Kreuz (WMDE): Prefer UserIdentity::isRegistered over isAnon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/651543 [18:56:48] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10kaldari) Maybe the real problem here is just that the string in German is way too long. @daniel - Would it make sense t... [18:58:44] 10Growth-Team, 10MediaWiki-Watchlist, 10Community-Tech, 10DBA, and 3 others: ClearUserWatchlistJob/WatchedItemStore::removeWatchBatchForUser bad database peformance on enwiki and others, causing database lag - https://phabricator.wikimedia.org/T270481 (10MusikAnimal) I don't think there is a need to ORDER... [19:06:54] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10Accessibility, and 2 others: Add accessibility check for Homepage - https://phabricator.wikimedia.org/T232638 (10zeljkofilipin) @Ephemeralwaves are you working on this? [19:15:05] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10daniel) >>! In T111735#6708782, @kaldari wrote: > Maybe the real problem here is just that the string in German is way t... [20:13:31] (03PS1) 10Jforrester: Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 [20:55:38] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10kaldari) I [[ https://de.wikipedia.org/w/index.php?title=MediaWiki%3AThanks-confirmation2&type=revision&diff=206802705&o... [21:18:35] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10daniel) >>! In T111735#6709098, @kaldari wrote: > I [[ https://de.wikipedia.org/w/index.php?title=MediaWiki%3AThanks-con... [21:51:39] (03Abandoned) 10Reedy: Updating pimple/pimple (v3.3.0 => v3.3.1) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/644040 (owner: 10Reedy) [21:51:45] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [21:51:51] (03PS1) 10Reedy: Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 [21:52:44] (03CR) 10jerkins-bot: [V: 04-1] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 (owner: 10Reedy) [21:56:30] 10Growth-Team, 10StructuredDiscussions, 10Technical-Debt: Replace Flow DI (pimple) with MediaWikiServices - https://phabricator.wikimedia.org/T170330 (10Reedy) >Pimple is now closed for changes. No new features will be added and no cosmetic changes will be accepted either. The only accepted changes are compa... [21:57:01] 10Growth-Team, 10StructuredDiscussions, 10Technical-Debt: Replace Flow DI (pimple) with MediaWikiServices - https://phabricator.wikimedia.org/T170330 (10Jdforrester-WMF) Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this w... [22:39:22] (03PS2) 10Reedy: Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 [22:39:27] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 (owner: 10Reedy) [22:42:47] (03CR) 10jerkins-bot: [V: 04-1] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 (owner: 10Reedy) [22:43:09] 10Growth-Team, 10StructuredDiscussions, 10Dependency injection, 10Technical-Debt: Replace Flow DI (pimple) with MediaWikiServices - https://phabricator.wikimedia.org/T170330 (10Jdforrester-WMF) [22:43:42] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 (owner: 10Reedy) [22:52:50] (03Merged) 10jenkins-bot: Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] (REL1_35) - 10https://gerrit.wikimedia.org/r/651592 (owner: 10Reedy) [23:09:57] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [23:30:17] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10Aklapper) >>! In T111735#6708782, @kaldari wrote: > Maybe the real problem here is just that the string in German is way... [23:42:58] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [23:44:13] (03PS2) 10Reedy: Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [23:44:22] (03CR) 10Reedy: [C: 03+2] "Seems the abandoned cherry pick upset it..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [23:44:36] (03CR) 10Reedy: [C: 03+2] Upgrade pimple/pimple from 3.3.0 to 3.3.1 for PHP 8.0 support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/651619 (owner: 10Jforrester) [23:46:04] 10Growth-Team, 10Thanks, 10JavaScript, 10Patch-Needs-Improvement: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10kaldari) >>! In T111735#6709412, @Aklapper wrote: >>>! In T111735#6708782, @kaldari wrote: >> Maybe the real problem her... [23:49:49] 10Growth-Team, 10StructuredDiscussions, 10Dependency injection, 10Technical-Debt, 10User-DannyS712: Replace Flow DI (pimple) with MediaWikiServices - https://phabricator.wikimedia.org/T170330 (10DannyS712) >>! In T170330#6709249, @Jdforrester-WMF wrote: > Upstream (pimple) have announced they're no longe... [23:52:14] 10Growth-Team, 10StructuredDiscussions, 10Dependency injection, 10Technical-Debt, 10User-DannyS712: Replace Flow DI (pimple) with MediaWikiServices - https://phabricator.wikimedia.org/T170330 (10Jdforrester-WMF) >>! In T170330#6709421, @DannyS712 wrote: >>>! In T170330#6709249, @Jdforrester-WMF wrote: >>... [23:56:39] 10Growth-Team, 10GrowthExperiments, 10MediaWiki-extensions-CentralNotice, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), and 3 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy)