[01:15:40] 10Growth-Team, 10GrowthExperiments-Homepage, 10Beta-Cluster-reproducible: [betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded - https://phabricator.wikimedia.org/T263302 (10Tgr) I can't reproduce that (and it seems like a ResourceLoader error, not a GrowthE... [01:19:30] 10Growth-Team, 10GrowthExperiments-Homepage, 10Beta-Cluster-reproducible: [betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded - https://phabricator.wikimedia.org/T263302 (10Tgr) Hm, this seems legitimately possible if the Mentorship module is loaded and Sug... [01:22:51] (03PS1) 10Gergő Tisza: Add missing dependency for Mentorship JS module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628468 (https://phabricator.wikimedia.org/T263302) [01:45:54] (03PS2) 10Gergő Tisza: Move TourHooks to the new hook system [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 [01:45:56] (03PS2) 10Gergő Tisza: [WIP] Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) [01:46:07] (03CR) 10Gergő Tisza: Move TourHooks to the new hook system (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [01:56:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [02:16:24] (03CR) 10DannyS712: Move TourHooks to the new hook system (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [02:20:50] (03CR) 10Gergő Tisza: Move TourHooks to the new hook system (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [02:23:35] (03CR) 10DannyS712: Move TourHooks to the new hook system (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [02:29:38] 10Growth-Team, 10MediaWiki-extensions-GuidedTour: For guider.js positions like leftTop the arrow aligns poorly with the target - https://phabricator.wikimedia.org/T263312 (10Tgr) [03:44:12] (03CR) 10Gergő Tisza: Move TourHooks to the new hook system (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [03:47:12] (03PS3) 10Gergő Tisza: Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) [03:57:06] (03CR) 10jerkins-bot: [V: 04-1] Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [04:11:38] (03PS4) 10Gergő Tisza: Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) [05:42:15] 10Growth-Team, 10ProofreadPage, 10StructuredDiscussions, 10VisualEditor, and 2 others: Deprecate SkinMinervaDefaultModules hook - https://phabricator.wikimedia.org/T256086 (10Ammarpad) > ProofReadPage extension uses this hook to disable the editor - this should be replaced by a configuration flag in Minerv... [07:39:46] (03PS13) 10Kosta Harlan: Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) [07:47:24] (03CR) 10jerkins-bot: [V: 04-1] Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [07:48:46] (03PS14) 10Kosta Harlan: Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) [07:57:13] (03PS15) 10Kosta Harlan: Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) [07:58:33] (03CR) 10Kosta Harlan: [C: 03+2] Avoid shadowed variables in javascript [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628415 (owner: 10Umherirrender) [07:58:59] (03CR) 10Kosta Harlan: [C: 03+2] Add missing dependency for Mentorship JS module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628468 (https://phabricator.wikimedia.org/T263302) (owner: 10Gergő Tisza) [08:01:11] (03CR) 10Kosta Harlan: [C: 03+2] Move TourHooks to the new hook system [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [08:05:21] (03CR) 10jerkins-bot: [V: 04-1] Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [08:06:58] (03Merged) 10jenkins-bot: Avoid shadowed variables in javascript [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628415 (owner: 10Umherirrender) [08:09:19] (03CR) 10Kosta Harlan: [C: 04-1] Variant C/D welcome popup on desktop (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [08:09:33] (03Merged) 10jenkins-bot: Add missing dependency for Mentorship JS module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628468 (https://phabricator.wikimedia.org/T263302) (owner: 10Gergő Tisza) [08:10:18] (03Merged) 10jenkins-bot: Move TourHooks to the new hook system [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628248 (owner: 10Gergő Tisza) [08:17:19] (03PS5) 10Kosta Harlan: Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [08:18:07] (03CR) 10Kosta Harlan: [C: 03+2] "PS5 adds a missing word to a i18n string as well as $1 parameter for GENDER." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [08:26:13] (03Merged) 10jenkins-bot: Variant C/D welcome popup on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628249 (https://phabricator.wikimedia.org/T258009) (owner: 10Gergő Tisza) [14:01:48] (03PS16) 10Kosta Harlan: Add TemplateFilter for validating TaskSet [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628073 (https://phabricator.wikimedia.org/T260758) [14:08:04] (03PS4) 10Kosta Harlan: Homepage: Don't show welcome notice for variant C/D users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627774 (https://phabricator.wikimedia.org/T258010) [14:15:47] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Don't show welcome notice for variant C/D users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627774 (https://phabricator.wikimedia.org/T258010) (owner: 10Kosta Harlan) [14:22:32] (03CR) 10Kosta Harlan: Homepage: Don't show welcome notice for variant C/D users (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627774 (https://phabricator.wikimedia.org/T258010) (owner: 10Kosta Harlan) [14:28:28] (03PS5) 10Kosta Harlan: Homepage: Don't show welcome notice for variant C/D users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627774 (https://phabricator.wikimedia.org/T258010) [14:31:24] (03PS1) 10Kosta Harlan: Extend MediaWikiUnitTestCase, not TestCase [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/628490 [14:31:48] (03PS5) 10Kosta Harlan: Homepage: Add hook for when mobile homepage summary HTML is loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627775 (https://phabricator.wikimedia.org/T258010) [15:05:54] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Collection, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [15:59:18] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-User-preferences: Allow to exclude bots from watchlist notifications - https://phabricator.wikimedia.org/T262750 (10Jidanni) https://commons.wikimedia.org/wiki/Commons:Help_desk#How_can_I_stop_receiving_bot_notification_by_email?? [16:03:16] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-User-preferences: Allow to exclude bots from watchlist notifications - https://phabricator.wikimedia.org/T262750 (10Jidanni) https://commons.wikimedia.org/wiki/Commons:Help_desk/Archive/2020/08#How_to_keep_an_eye_on_my_uploads_after_kind_of_spam_notifications%3F [16:15:06] 10Growth-Team, 10StructuredDiscussions: Caught exception of type Flow\Exception\NoParserException - https://phabricator.wikimedia.org/T263325 (10Eafm2020) [18:02:51] 10Growth-Team, 10StructuredDiscussions: Caught exception of type Flow\Exception\NoParserException - https://phabricator.wikimedia.org/T263325 (10Eafm2020) Solved ! I forgot to add the setMwApi on localsettings.js as follows: ` exports.setup = function(parsoidConfig) { // Do something dynamic with `parsoidC... [18:17:42] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Collection, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [18:55:37] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [19:00:38] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Collection, and 25 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [19:07:08] (03CR) 10Jforrester: Fix PSR12.Properties.ConstantVisibility.NotFound (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:17:47] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:28:27] 10Growth-Team, 10MediaWiki-Recent-changes, 10User-Urbanecm: IRCColourfulRCFeedFormatter ignores bot flag for log entries - https://phabricator.wikimedia.org/T251716 (10Urbanecm) 05Open→03Declined [20:02:25] 10Growth-Team, 10Turkish-Sites: Deploy Growth features on Turkish Wikipedia - https://phabricator.wikimedia.org/T243445 (10Mavrikant) [21:06:36] (03PS2) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [21:24:44] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [21:26:50] (03PS3) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [21:38:05] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Discovery-Search, and 23 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [22:00:22] (03CR) 10DannyS712: "LGTM, 1 suggestion though" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [23:38:41] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Discovery-Search, and 23 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [23:39:40] 10Growth-Team, 10Notifications, 10CirrusSearch, 10Discovery-Search, and 22 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy)