[00:10:31] 10Growth-Team, 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review: Deploy Growth features on Swedish Wikipedia - https://phabricator.wikimedia.org/T257220 (10Catrope) > Help desk: https://sv.wikipedia.org/wiki/Wikipedia:Fikarummet However, new questions should be posted to [[https://sv.wikipedia.... [00:15:04] (03CR) 10Gergő Tisza: [C: 03+2] StartEditingDialog: Various fixes for variant C onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626795 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [00:16:52] (03CR) 10Gergő Tisza: [C: 04-2] StartEditingDialog: Various fixes for variant C onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626795 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [00:17:27] (03CR) 10Gergő Tisza: [C: 04-2] "On second thought, merging two hours before the branch cut seems like bad form. I'll merge it soon." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626795 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [00:41:29] (03CR) 10Ppchelko: Replace $wgUser with RequestContext::getMain (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/626904 (https://phabricator.wikimedia.org/T262111) (owner: 10DannyS712) [00:41:29] (03CR) 10DannyS712: Replace $wgUser with RequestContext::getMain (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/626904 (https://phabricator.wikimedia.org/T262111) (owner: 10DannyS712) [00:47:32] 10Growth-Team, 10GrowthExperiments: Support posting new help desk questions at the top of the page - https://phabricator.wikimedia.org/T261714 (10MMiller_WMF) @Catrope -- this task my be overtaken by events depending on the results from {T250235}. @Iniquity -- do you think this is an important issue that we s... [00:57:58] (03CR) 10Gergő Tisza: "A test for CacheDecorator would be nice." (035 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [01:12:01] (03CR) 10DannyS712: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/627224 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [01:12:52] (03CR) 10Ppchelko: [C: 03+2] NotificationsTest: No need to set $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/627224 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [01:31:40] (03Merged) 10jenkins-bot: NotificationsTest: No need to set $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/627224 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [02:45:48] 10Growth-Team, 10MediaWiki-extensions-GettingStarted: Make Getting Started temporarily suppress the VE dialog by adding "vehidebetadialog" to the query string - https://phabricator.wikimedia.org/T235812 (10kaldari) @phuedx - Since I can't get any traction with the Growth team on this, any chance you'd like to... [05:24:38] (03CR) 10Gergő Tisza: [C: 03+2] StartEditingDialog: Various fixes for variant C onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626795 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [05:32:43] (03Merged) 10jenkins-bot: StartEditingDialog: Various fixes for variant C onboarding [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626795 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [06:57:54] (03PS1) 10Thiemo Kreuz (WMDE): Fix insufficient isset() check in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/627416 (https://phabricator.wikimedia.org/T259739) [07:19:43] (03CR) 10Ostrzyciel: "I'm a bit stuck on a badly-written test that is causing me headaches…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/608884 (https://phabricator.wikimedia.org/T154637) (owner: 10ProcrastinatingReader) [07:30:29] 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Google-Summer-of-Code (2020), 10Growth-Team (Current Sprint), 10User-notice: Add Reverted filter to RecentChanges Filters - https://phabricator.wikimedia.org/T164307 (10Ostrzyciel) [07:30:35] 10Growth-Team, 10Notifications: "reverted"-type notifications should be based on the actual page content - https://phabricator.wikimedia.org/T56007 (10Ostrzyciel) [07:30:44] 10Growth-Team, 10Contributors-Team, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 5 others: Add method to Revision to check if it was a Revert, and whether an edit was Reverted - https://phabricator.wikimedia.org/T152434 (10Ostrzyciel) 05Open→03Resolved a:03Ostrzyciel I'm marking this as resol... [07:32:19] (03CR) 10Ammarpad: [C: 03+2] Fix insufficient isset() check in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/627416 (https://phabricator.wikimedia.org/T259739) (owner: 10Thiemo Kreuz (WMDE)) [07:55:55] (03Merged) 10jenkins-bot: Fix insufficient isset() check in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/627416 (https://phabricator.wikimedia.org/T259739) (owner: 10Thiemo Kreuz (WMDE)) [08:13:36] (03PS25) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [08:13:47] (03CR) 10Kosta Harlan: Cache newcomer TaskSets per user (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [08:15:31] (03CR) 10Jgiannelos: [C: 03+2] Change echo_push_* column types from TEXT to BLOB [extensions/Echo] - 10https://gerrit.wikimedia.org/r/627346 (https://phabricator.wikimedia.org/T246716) (owner: 10Mholloway) [08:22:29] (03PS26) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [08:22:49] (03CR) 10Kosta Harlan: Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [08:36:51] (03Merged) 10jenkins-bot: Change echo_push_* column types from TEXT to BLOB [extensions/Echo] - 10https://gerrit.wikimedia.org/r/627346 (https://phabricator.wikimedia.org/T246716) (owner: 10Mholloway) [08:41:20] (03PS1) 10Gergő Tisza: Make wrapping SmallTaskCard in an optional [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627424 (https://phabricator.wikimedia.org/T258021) [08:41:22] (03PS1) 10Gergő Tisza: Memoize calls to HomepageModuleRegistry [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627425 [08:41:24] (03PS1) 10Gergő Tisza: [WIP] Show task preview in variant C/D mobile summary [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627426 (https://phabricator.wikimedia.org/T258021) [08:47:32] (03CR) 10Gergő Tisza: Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [08:49:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show task preview in variant C/D mobile summary [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627426 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [08:53:01] (03PS27) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [08:54:34] (03PS28) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [08:56:52] (03CR) 10Kosta Harlan: Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [09:02:17] (03PS29) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [10:11:15] 10Growth-Team, 10GrowthExperiments, 10Wikimedia-production-error: Uncaught TypeError: data.homepagequestionstore.questions.forEach is not a function - https://phabricator.wikimedia.org/T255616 (10kostajh) [10:11:17] 10Growth-Team, 10GrowthExperiments-Homepage, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: data.homepagequestionstore.questions.forEach is not a function - https://phabricator.wikimedia.org/T257639 (10kostajh) [10:27:25] 10Growth-Team, 10Growth-Structured-Tasks: Move mwaddlink from github to gerrit - https://phabricator.wikimedia.org/T261403 (10kostajh) [10:27:34] 10Growth-Team, 10Growth-Structured-Tasks: Move mwaddlink-api from github to gerrit - https://phabricator.wikimedia.org/T261403 (10kostajh) [12:23:29] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-User-management, 10Wikidata, and 2 others: Wikibase entities created/edited via OAuth consumer without “edit your watchlist” grant are not added to watchlist despite setting - https://phabricator.wikimedia.org/T217144 (10WMDE-leszek) [12:57:11] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-User-management, 10Wikidata, and 2 others: Wikibase entities created/edited via OAuth consumer without “edit your watchlist” grant are not added to watchlist despite setting - https://phabricator.wikimedia.org/T217144 (10Lucas_Werkmeister_WMDE) [13:16:33] 10Growth-Team, 10Contributors-Team, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 5 others: Add method to Revision to check if it was a Revert, and whether an edit was Reverted - https://phabricator.wikimedia.org/T152434 (10Ottomata) Yeah this is great stuff thank youuuuu! [13:36:19] 10Growth-Team, 10Notifications: Logging in to a WMF wiki shows some Notifications as "new" though I already marked them as read on other wikis - https://phabricator.wikimedia.org/T262927 (10Aklapper) [13:36:57] 10Growth-Team, 10Notifications: Logging in to a WMF wiki shows some Notifications as "new" though I already saw them on other wikis - https://phabricator.wikimedia.org/T262927 (10Aklapper) [13:49:55] (03PS1) 10Catrope: [WIP] Sketch for add a link with VisualEditor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627505 [13:50:44] (03PS2) 10Catrope: [WIP] Sketch for add a link with VisualEditor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627505 (https://phabricator.wikimedia.org/T261398) [14:18:25] 10Growth-Team, 10Contributors-Team, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 5 others: Add method to Revision to check if it was a Revert, and whether an edit was Reverted - https://phabricator.wikimedia.org/T152434 (10Halfak) Fantastic! Wonderful work! [14:50:10] 10Growth-Team, 10Contributors-Team, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 5 others: Add method to Revision to check if it was a Revert, and whether an edit was Reverted - https://phabricator.wikimedia.org/T152434 (10Jdlrobson) Yay! [15:17:31] 10Growth-Team, 10GrowthExperiments: Support posting new help desk questions at the top of the page - https://phabricator.wikimedia.org/T261714 (10Iniquity) >>! In T261714#6461034, @MMiller_WMF wrote: > @Iniquity -- do you think this is an important issue that we should work on? Usually, new questions on the R... [16:59:17] 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Google-Summer-of-Code (2020), 10Growth-Team (Current Sprint), and 2 others: Add Reverted filter to RecentChanges Filters - https://phabricator.wikimedia.org/T164307 (10Trizek-WMF) [[https://meta.wikimedia.org/w/index.php?t... [16:59:24] (03CR) 10Urbanecm: "> Patch Set 20: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [17:02:06] (03CR) 10Catrope: [C: 03+2] Make wrapping SmallTaskCard in an optional [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627424 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:02:45] (03CR) 10Catrope: [C: 03+2] Memoize calls to HomepageModuleRegistry [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627425 (owner: 10Gergő Tisza) [17:06:41] (03CR) 10Catrope: [C: 03+2] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [17:06:53] (03PS4) 10Catrope: Define default task types as constant and export to frontend [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626364 (owner: 10Kosta Harlan) [17:07:02] (03PS5) 10Catrope: Newcomer tasks: Warm cache for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623776 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [17:07:10] (03PS6) 10Catrope: Always load the first task on the server side [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626244 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:07:30] (03CR) 10Catrope: [C: 03+2] Always load the first task on the server side [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626244 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:16:12] (03Merged) 10jenkins-bot: Make wrapping SmallTaskCard in an optional [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627424 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:16:14] (03Merged) 10jenkins-bot: Memoize calls to HomepageModuleRegistry [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627425 (owner: 10Gergő Tisza) [17:19:04] (03CR) 10jerkins-bot: [V: 04-1] Always load the first task on the server side [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626244 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:20:05] (03Merged) 10jenkins-bot: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [17:20:09] (03Merged) 10jenkins-bot: Define default task types as constant and export to frontend [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626364 (owner: 10Kosta Harlan) [17:20:11] (03Merged) 10jenkins-bot: Newcomer tasks: Warm cache for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623776 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [17:20:13] (03Merged) 10jenkins-bot: Always load the first task on the server side [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626244 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [17:52:22] (03PS1) 10Catrope: StartEditingDialog: Change header text [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627576 (https://phabricator.wikimedia.org/T258016) [18:01:15] (03CR) 10jerkins-bot: [V: 04-1] StartEditingDialog: Change header text [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/627576 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [18:16:21] 10Growth-Team, 10WikiLove, 10FileAnnotations, 10Jade, and 24 others: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal - https://phabricator.wikimedia.org/T255319 (10Jdlrobson) [18:30:46] 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Google-Summer-of-Code (2020), 10Growth-Team (Current Sprint), 10User-notice: Add Reverted filter to RecentChanges Filters - https://phabricator.wikimedia.org/T164307 (10Urbanecm) This was just deployed :-). [18:34:09] 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Google-Summer-of-Code (2020), 10Growth-Team (Current Sprint), 10User-notice: Add Reverted filter to RecentChanges Filters - https://phabricator.wikimedia.org/T164307 (10Etonkovidova) >>! In T164307#6463957, @Urbanecm wro... [20:00:40] (03CR) 10C. Scott Ananian: Do not throw exception for zero-config VisualEditor (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/622258 (https://phabricator.wikimedia.org/T260648) (owner: 10Lens0021)