[00:21:08] (03PS1) 10Catrope: Homepage: Fix mobile summary styling when not wrapped in a link [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626519 (https://phabricator.wikimedia.org/T258008) [00:35:03] (03PS6) 10Catrope: StartEditingDialog: Display without topic selector in variant C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) [00:35:07] (03CR) 10Catrope: "> Patch Set 5: Code-Review-1" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [00:49:46] (03CR) 10Catrope: "> Patch Set 4: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626051 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [00:50:44] (03PS5) 10Catrope: StartEditingDialog: Make the mobile info icon also launch the dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626051 (https://phabricator.wikimedia.org/T258016) [00:52:11] (03PS7) 10Catrope: StartEditingDialog: Display without topic selector in variant C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) [01:00:22] (03PS6) 10Catrope: StartEditingDialog: Make the mobile info icon also launch the dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626051 (https://phabricator.wikimedia.org/T258016) [01:07:40] (03CR) 10Catrope: [C: 04-1] "Good to merge except for two omissions" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626364 (owner: 10Kosta Harlan) [01:17:33] (03CR) 10Catrope: [C: 04-1] Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [01:18:30] (03CR) 10Catrope: [C: 03+2] Newcomer tasks: Warm cache for variant C users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623776 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [01:21:33] (03CR) 10Catrope: [C: 03+1] Fix the first element of the suggested edits task queue on page load [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/621595 (https://phabricator.wikimedia.org/T258024) (owner: 10Gergő Tisza) [01:23:48] (03CR) 10Catrope: [C: 04-1] "Looks good, very small nitpick inline" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626243 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:26:11] (03CR) 10Catrope: "> Patch Set 2: Code-Review-2" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626244 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:29:09] (03PS3) 10Catrope: Disable suggested edits navigation and result count until fully loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626243 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:30:04] (03CR) 10Catrope: [C: 03+2] Disable suggested edits navigation and result count until fully loaded (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626243 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:30:12] (03CR) 10Catrope: [C: 03+2] Disable suggested edits navigation and result count until fully loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626243 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:30:18] (03CR) 10Catrope: [C: 03+2] Fix the first element of the suggested edits task queue on page load [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/621595 (https://phabricator.wikimedia.org/T258024) (owner: 10Gergő Tisza) [01:32:13] (03CR) 10Catrope: [C: 04-1] Fix the first element of the suggested edits task queue on page load [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/621595 (https://phabricator.wikimedia.org/T258024) (owner: 10Gergő Tisza) [01:33:09] (03CR) 10Catrope: [C: 03+2] Fix the first element of the suggested edits task queue on page load [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/621595 (https://phabricator.wikimedia.org/T258024) (owner: 10Gergő Tisza) [01:42:27] (03Merged) 10jenkins-bot: Fix the first element of the suggested edits task queue on page load [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/621595 (https://phabricator.wikimedia.org/T258024) (owner: 10Gergő Tisza) [01:42:29] (03Merged) 10jenkins-bot: Disable suggested edits navigation and result count until fully loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626243 (https://phabricator.wikimedia.org/T258021) (owner: 10Gergő Tisza) [01:56:59] (03CR) 10Gergő Tisza: "This will break when first called with limit=10 and then with limit=250 (which would be common). I think the correct logic would be:" (0311 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [02:01:49] (03CR) 10Gergő Tisza: Define default task types as constant and export to frontend (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626364 (owner: 10Kosta Harlan) [02:34:54] (03CR) 10Gergő Tisza: [C: 04-1] "Sorry for the super long wait on this. We discussed it with Marshall, and the preference is to have everyone who can be a mentor on the me" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [03:00:41] (03CR) 10Gergő Tisza: [C: 04-1] "This also applies the 0 padding-top which looks bad on the startemail module as it does not have a header." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626519 (https://phabricator.wikimedia.org/T258008) (owner: 10Catrope) [08:28:15] 10Growth-Team, 10Product-Infrastructure-Team-Backlog: Create "EditReminder" Echo Notification (Strawman) - https://phabricator.wikimedia.org/T262606 (10Aklapper) @sdkim: Hi, which code base is this task about? If this is about #Echo, could you please add that project tag so other people who don't know or don't... [08:28:17] 10Growth-Team, 10Product-Infrastructure-Team-Backlog: Create "EditReminder" Echo Notification (Full Fidelity) - https://phabricator.wikimedia.org/T262607 (10Aklapper) @sdkim: Hi, which code base is this task about? If this is about #Echo, could you please add that project tag so other people who don't know or... [08:30:27] (03PS1) 10Kosta Harlan: Protect against empty task preview data [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626597 (https://phabricator.wikimedia.org/T258024) [09:02:04] (03PS1) 10Kosta Harlan: Define minimum height for SE module on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626600 (https://phabricator.wikimedia.org/T238231) [09:31:30] (03CR) 10Kosta Harlan: "I think we need to set a minimum height on the dialog; now that the topic dialog is just text and is therefore much shorter than it was be" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [09:38:36] (03CR) 10Kosta Harlan: [C: 03+2] StartEditingDialog: Make the mobile info icon also launch the dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626051 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [09:38:54] (03CR) 10Kosta Harlan: [C: 03+2] "Will comment on task with follow up items needed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [09:47:05] (03Merged) 10jenkins-bot: StartEditingDialog: Display without topic selector in variant C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626050 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [09:49:35] (03Merged) 10jenkins-bot: StartEditingDialog: Make the mobile info icon also launch the dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626051 (https://phabricator.wikimedia.org/T258016) (owner: 10Catrope) [10:05:25] (03CR) 10Jforrester: [C: 03+2] Protect against empty task preview data [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626597 (https://phabricator.wikimedia.org/T258024) (owner: 10Kosta Harlan) [10:13:12] (03Merged) 10jenkins-bot: Protect against empty task preview data [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626597 (https://phabricator.wikimedia.org/T258024) (owner: 10Kosta Harlan) [10:48:04] 10Growth-Team, 10Tech-Product API Roadmap: Link recommendation model productized - https://phabricator.wikimedia.org/T259473 (10Naike) [10:49:32] 10Growth-Team, 10Growth-Structured-Tasks, 10Tech-Product API Roadmap, 10Wikipedia-Android-App-Backlog: User contributions API (editing stats) - https://phabricator.wikimedia.org/T259479 (10Naike) [10:53:51] 10Growth-Team, 10Growth-Structured-Tasks, 10Tech-Product API Roadmap, 10Wikipedia-Android-App-Backlog: Task suggestions investigation - https://phabricator.wikimedia.org/T259487 (10Naike) [10:54:23] 10Growth-Team, 10Growth-Structured-Tasks, 10Tech-Product API Roadmap, 10Wikipedia-Android-App-Backlog, 10Research (FY2020-21-Research-July-September): Image suggestion API - https://phabricator.wikimedia.org/T260832 (10Naike) [11:03:13] (03CR) 10Urbanecm: "> Patch Set 20: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [11:43:46] 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, 10Editing-team (Tracking), 10Wikimedia-production-error: [betalabs] 'Uncaught TypeError: Cannot read property 'model' of undefined' for non-persistent Comments in Flow posts - https://phabricator.wikimedia.org/T136780 (10Esanders) [11:59:20] 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, 10Wikimedia-production-error: Error: Unbalanced input passed to document - https://phabricator.wikimedia.org/T261782 (10Esanders) [12:00:29] 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), and 2 others: Uncaught Error: Cannot insert mwHeading even after closing all containing nodes (at index 2) - https://phabricator.wikimedia.org/T259718 (10Esanders) [12:13:07] (03PS15) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [12:15:42] (03PS16) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [12:24:08] (03CR) 10jerkins-bot: [V: 04-1] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [12:42:22] (03CR) 10Kosta Harlan: Cache newcomer TaskSets per user (037 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [12:59:33] (03CR) 10Gergő Tisza: Cache newcomer TaskSets per user (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [13:15:30] (03CR) 10Kosta Harlan: Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [13:18:53] (03CR) 10Kosta Harlan: "Overall I think this will help the variation C/D work, since the server side check to load a result set to export to the client side will " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [13:26:28] (03PS17) 10Kosta Harlan: Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [13:34:27] (03CR) 10jerkins-bot: [V: 04-1] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [13:35:16] 10Growth-Team, 10Notifications, 10Product-Infrastructure-Team-Backlog, 10Push-Notification-Service: Create "EditReminder" Echo Notification (Strawman) - https://phabricator.wikimedia.org/T262606 (10sdkim) @Aklapper roger that! [13:36:25] 10Growth-Team, 10Notifications, 10Product-Infrastructure-Team-Backlog, 10Push-Notification-Service: Create "EditReminder" Echo Notification (Full Fidelity) - https://phabricator.wikimedia.org/T262607 (10sdkim) @Aklapper roger that! [16:24:08] 10Growth-Team, 10WikiLove, 10FileAnnotations, 10Jade, and 27 others: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal - https://phabricator.wikimedia.org/T255319 (10Jdlrobson) [16:24:26] 10Growth-Team, 10WikiLove, 10FileAnnotations, 10Jade, and 27 others: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal - https://phabricator.wikimedia.org/T255319 (10Jdlrobson) [16:42:44] 10Growth-Team, 10WikiLove, 10FileAnnotations, 10Jade, and 27 others: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal - https://phabricator.wikimedia.org/T255319 (10Jdlrobson) Thank you @pwirth and @Osnard ! [16:52:52] (03CR) 10Gergő Tisza: [C: 04-1] "I think this patch is fine as it is, except using claimmentee should be conditional on the user being in MentorManager::getAvailableMentor" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [17:36:31] 10Growth-Team, 10Notifications, 10MediaWiki-skins-WikimediaApiPortal, 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), and 3 others: Don't show notifications when logged out - https://phabricator.wikimedia.org/T260394 (10apaskulin) 05Resolved→03Open @CCicalese_WMF I just noticed that this is still appearing... [18:00:04] 10Growth-Team, 10Notifications, 10MobileFrontend, 10Wikimedia-production-error: Uncaught TypeError: e.on is not a function - https://phabricator.wikimedia.org/T262703 (10Jdlrobson) [19:08:15] 10Growth-Team, 10Notifications, 10MediaWiki-skins-WikimediaApiPortal, 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), and 4 others: Don't show notifications when logged out - https://phabricator.wikimedia.org/T260394 (10CCicalese_WMF) Oops! I made the change in one place but not the other. The new patch should... [20:04:37] (03PS18) 10Kosta Harlan: [WIP] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [20:06:59] (03PS19) 10Kosta Harlan: [WIP] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) [20:14:37] (03CR) 10Krinkle: [WIP] Cache newcomer TaskSets per user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [20:16:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Cache newcomer TaskSets per user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [20:32:37] 10Growth-Team, 10WikiLove, 10FileAnnotations, 10Jade, and 26 others: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal - https://phabricator.wikimedia.org/T255319 (10Jdlrobson) [20:41:19] (03CR) 10Catrope: [C: 04-1] "This approach looks good to me" (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/623768 (https://phabricator.wikimedia.org/T260758) (owner: 10Kosta Harlan) [21:04:47] (03CR) 10Catrope: [C: 03+2] Define minimum height for SE module on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626600 (https://phabricator.wikimedia.org/T238231) (owner: 10Kosta Harlan) [21:19:53] (03Merged) 10jenkins-bot: Define minimum height for SE module on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626600 (https://phabricator.wikimedia.org/T238231) (owner: 10Kosta Harlan) [21:26:06] (03PS1) 10Umherirrender: build: Use existing eslint also for json linting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) [21:30:37] (03CR) 10jerkins-bot: [V: 04-1] build: Use existing eslint also for json linting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [21:38:12] (03CR) 10Umherirrender: "phpunit tests now failing on warnings, need fixing" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [21:42:42] (03CR) 10Krinkle: build: Use existing eslint also for json linting (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [21:43:25] (03CR) 10Krinkle: build: Use existing eslint also for json linting (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [21:54:33] (03PS1) 10Gergő Tisza: Do not fatal when the task suggester returns an error [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626772 [21:54:35] (03PS1) 10Gergő Tisza: Fix task card image loading animation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626773 [21:54:37] (03PS1) 10Gergő Tisza: Extract task card loading skeleton CSS rules into mixin [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626774 [21:54:39] (03PS1) 10Gergő Tisza: Show a skeleton animation while the small task card is loading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626775 [21:58:36] (03CR) 10Umherirrender: build: Use existing eslint also for json linting (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [22:00:14] (03PS2) 10Umherirrender: build: Use existing eslint also for json linting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) [22:00:28] (03CR) 10Umherirrender: build: Use existing eslint also for json linting (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [22:03:30] (03CR) 10jerkins-bot: [V: 04-1] Extract task card loading skeleton CSS rules into mixin [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626774 (owner: 10Gergő Tisza) [22:04:10] (03CR) 10jerkins-bot: [V: 04-1] build: Use existing eslint also for json linting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) (owner: 10Umherirrender) [22:04:31] (03CR) 10jerkins-bot: [V: 04-1] Show a skeleton animation while the small task card is loading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626775 (owner: 10Gergő Tisza) [22:13:41] (03PS1) 10Umherirrender: Replace deprecated assertArraySubset [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626780 [22:17:24] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated assertArraySubset [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626780 (owner: 10Umherirrender) [22:30:24] (03PS2) 10Umherirrender: Replace deprecated assertArraySubset [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626780 [22:30:42] (03PS1) 10Catrope: [WIP] DO NOT MERGE: test for a CI bug [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626782 [22:36:12] (03PS3) 10Umherirrender: build: Use existing eslint also for json linting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/626759 (https://phabricator.wikimedia.org/T220036) [22:40:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] DO NOT MERGE: test for a CI bug [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/626782 (owner: 10Catrope)